Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-30 Thread Denis Fondras
Le Tue, Dec 29, 2020 at 12:36:22PM -0700, Todd C. Miller a écrit : > On Sat, 26 Dec 2020 15:07:36 -0700, "Theo de Raadt" wrote: > > > Well in that case this should still be a multistep process. > > > > Add STAILQ > > > > Convert things, including everything in ports > > > > No diff should change

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-29 Thread Todd C . Miller
On Tue, 29 Dec 2020 12:36:22 -0700, Todd C. Miller wrote: > That looks something like this. I used the FreeBSD macros which > incorporate STAILQ_NEXT and STAILQ_FIRST but I can inline things > if someone has a strong opinion on this. Here is the updated man page. The table doesn't reflect

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-29 Thread Todd C . Miller
On Sat, 26 Dec 2020 15:07:36 -0700, "Theo de Raadt" wrote: > Well in that case this should still be a multistep process. > > Add STAILQ > > Convert things, including everything in ports > > No diff should change a line of code before it's time That looks something like this. I used the FreeBSD

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-28 Thread Christian Weisgerber
Denis Fondras: > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify with > FreeBSD and Linux. > > I added aliases at the end of queue.h to avoid breaking base too much. they > will > be removed as soon as diff 2,3,4,5,6,7 are commited. > > net/sniproxy has a patch to define

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Theo de Raadt
Christian Weisgerber wrote: > Theo de Raadt: > > > What is lacking in this converstation is the justification. > > Why? > > Providing STAILQ in OpenBSD will simplify porting to OpenBSD. > (Reality check: There is one port affected by this.) > > Switching OpenBSD to STAILQ will simplify

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Christian Weisgerber
Theo de Raadt: > What is lacking in this converstation is the justification. > Why? Providing STAILQ in OpenBSD will simplify porting to OpenBSD. (Reality check: There is one port affected by this.) Switching OpenBSD to STAILQ will simplify porting from OpenBSD. (There are three or four FreeBSD

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Theo de Raadt
Todd C. Miller wrote: > On Sat, 26 Dec 2020 10:45:21 -0700, "Theo de Raadt" wrote: > > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > > with FreeBSD and Linux. > > > > More than half the stuff being touched doesn't exist in FreeBSD or Linux. > > > > SIMPLEQ_ goes

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Stuart Henderson
On 2020/12/26 18:39, Denis Fondras wrote: > Le Sat, Dec 26, 2020 at 06:23:41PM +0100, Mark Kettenis a écrit : > > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > > > with FreeBSD and Linux. > > > > > > > > I added aliases at the end of queue.h to avoid breaking base

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Todd C . Miller
On Sat, 26 Dec 2020 10:45:21 -0700, "Theo de Raadt" wrote: > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > with FreeBSD and Linux. > > More than half the stuff being touched doesn't exist in FreeBSD or Linux. > > SIMPLEQ_ goes back to 97. STAILQ goes back to 96.

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Denis Fondras
Le Sat, Dec 26, 2020 at 06:55:09PM +0100, Mark Kettenis a écrit : > > Date: Sat, 26 Dec 2020 18:39:36 +0100 > > From: Denis Fondras > > > > Le Sat, Dec 26, 2020 at 06:23:41PM +0100, Mark Kettenis a écrit : > > > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > > > >

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Mark Kettenis
> Date: Sat, 26 Dec 2020 18:39:36 +0100 > From: Denis Fondras > > Le Sat, Dec 26, 2020 at 06:23:41PM +0100, Mark Kettenis a écrit : > > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > > > with FreeBSD and Linux. > > > > > > > > I added aliases at the end of queue.h

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Theo de Raadt
Denis Fondras wrote: > Le Sat, Dec 26, 2020 at 06:23:41PM +0100, Mark Kettenis a écrit : > > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > > > with FreeBSD and Linux. > > > > > > > > I added aliases at the end of queue.h to avoid breaking base too much. > > > >

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Theo de Raadt
> This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > with FreeBSD and Linux. More than half the stuff being touched doesn't exist in FreeBSD or Linux. SIMPLEQ_ goes back to 97. Why is this the direction to go??? Denis, you appear to be making an arbitrary decision and not

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Theo de Raadt
Martin Pieuchot wrote: > On 26/12/20(Sat) 18:23, Mark Kettenis wrote: > > [...] > > NetBSD and Solaris both provide SIMPLEQ_* and STAILQ_*. I'm not sure > > removing one in favour of the other is helpful. > > It would be helpful to provide both set of macros for some time to ease > the

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Denis Fondras
Le Sat, Dec 26, 2020 at 06:23:41PM +0100, Mark Kettenis a écrit : > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify with > > > FreeBSD and Linux. > > > > > > I added aliases at the end of queue.h to avoid breaking base too much. > > > they will > > > be removed as soon

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Martin Pieuchot
On 26/12/20(Sat) 18:23, Mark Kettenis wrote: > [...] > NetBSD and Solaris both provide SIMPLEQ_* and STAILQ_*. I'm not sure > removing one in favour of the other is helpful. It would be helpful to provide both set of macros for some time to ease the transition/conversion. Then we can decide if

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Mark Kettenis
> Date: Sat, 26 Dec 2020 16:40:15 +0100 > From: Christian Weisgerber > > Denis Fondras: > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify with > > FreeBSD and Linux. > > > > I added aliases at the end of queue.h to avoid breaking base too much. they > > will > > be

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Christian Weisgerber
Denis Fondras: > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify with > FreeBSD and Linux. > > I added aliases at the end of queue.h to avoid breaking base too much. they > will > be removed as soon as diff 2,3,4,5,6,7 are commited. We'll need to run a ports bulk build

Re: Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Todd C . Miller
I read through all the diffs and they look fine to me. My only comment is that it would be nice if the whitespace changes to queue.h were done separately as they makes it more difficult to see the important changes. I was pleasntly surprised to find the nothing in the tree reaches into the data

Rename SIMPLEQ_ to STAILQ_, diff 1/7

2020-12-26 Thread Denis Fondras
mpi@ reminded me I had this diff cooking. This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify with FreeBSD and Linux. I added aliases at the end of queue.h to avoid breaking base too much. they will be removed as soon as diff 2,3,4,5,6,7 are commited. net/sniproxy has a patch