Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Hrvoje Popovski
On 22.10.2021. 16:57, Theo de Raadt wrote: > Claudio Jeker wrote: > >> For ospfd tests you want to make sure that some of the ospf packets need >> fragmenting. So this needs a sizeable network to hit this. > > Yes, as I remember, the problems only related to fragments of large > packets. > >

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread David Riley
On Oct 22, 2021, at 7:55 AM, Stuart Henderson wrote: > > On 2021/10/22 11:25, Jan Klemkow wrote: >> this diff add hardware checksum offloading for the receive path of >> ixl(4) interfaces. > > Would be good to have this tested with NFS if anyone has a way to do so. > nics are probably better

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Hrvoje Popovski
On 22.10.2021. 16:53, Claudio Jeker wrote: > On Fri, Oct 22, 2021 at 04:45:09PM +0200, Hrvoje Popovski wrote: >> On 22.10.2021. 16:09, Florian Obser wrote: >>> >>> >>> On 22 October 2021 13:55:20 CEST, Stuart Henderson >>> wrote: On 2021/10/22 11:25, Jan Klemkow wrote: > this diff add

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Theo de Raadt
Claudio Jeker wrote: > For ospfd tests you want to make sure that some of the ospf packets need > fragmenting. So this needs a sizeable network to hit this. Yes, as I remember, the problems only related to fragments of large packets. These tests are too narrow and the results inconclusive.

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Theo de Raadt
the nfs issues related to fragments being incorrectly labelled as checksummed. I am vague on whether this was hardware incorrectly indicating checksum valid in damaged packets. of course, that was nothing compared to the astoundingly nasty v6 checksum hardware bug in tht(4)... Hrvoje Popovski

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Claudio Jeker
On Fri, Oct 22, 2021 at 04:45:09PM +0200, Hrvoje Popovski wrote: > On 22.10.2021. 16:09, Florian Obser wrote: > > > > > > On 22 October 2021 13:55:20 CEST, Stuart Henderson > > wrote: > >> On 2021/10/22 11:25, Jan Klemkow wrote: > >>> this diff add hardware checksum offloading for the receive

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Hrvoje Popovski
On 22.10.2021. 16:22, Sebastian Benoit wrote: > Stuart Henderson(s...@spacehopper.org) on 2021.10.22 12:55:20 +0100: >> On 2021/10/22 11:25, Jan Klemkow wrote: >>> this diff add hardware checksum offloading for the receive path of >>> ixl(4) interfaces. >> >> Would be good to have this tested with

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Hrvoje Popovski
On 22.10.2021. 16:09, Florian Obser wrote: > > > On 22 October 2021 13:55:20 CEST, Stuart Henderson > wrote: >> On 2021/10/22 11:25, Jan Klemkow wrote: >>> this diff add hardware checksum offloading for the receive path of >>> ixl(4) interfaces. >> >> Would be good to have this tested with NFS

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Sebastian Benoit
Stuart Henderson(s...@spacehopper.org) on 2021.10.22 12:55:20 +0100: > On 2021/10/22 11:25, Jan Klemkow wrote: > > this diff add hardware checksum offloading for the receive path of > > ixl(4) interfaces. > > Would be good to have this tested with NFS if anyone has a way to do so. > nics are

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Hrvoje Popovski
On 22.10.2021. 13:55, Stuart Henderson wrote: > On 2021/10/22 11:25, Jan Klemkow wrote: >> this diff add hardware checksum offloading for the receive path of >> ixl(4) interfaces. > > Would be good to have this tested with NFS if anyone has a way to do so. > nics are probably better now but I'm

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Florian Obser
On 22 October 2021 13:55:20 CEST, Stuart Henderson wrote: >On 2021/10/22 11:25, Jan Klemkow wrote: >> this diff add hardware checksum offloading for the receive path of >> ixl(4) interfaces. > >Would be good to have this tested with NFS if anyone has a way to do so. >nics are probably better

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Hrvoje Popovski
On 22.10.2021. 13:39, Jan Klemkow wrote: > Hi Hrvoje, > > Thats because, you only see this flags, if the checksum offloading is > enabled for "sending". I'm still working/debugging on the sending side. > Thus, I just send a diff with the receiving part for now. > > You can see if its working

ixl(4): add checksum receive offloading

2021-10-22 Thread Jan Klemkow
Hi, this diff add hardware checksum offloading for the receive path of ixl(4) interfaces. Tested on: ixl1 at pci3 dev 0 function 1 "Intel X710 SFP+" rev 0x02: port 1, FW 6.0.48442 API 1.7, msix, 8 queues, address 40:a6:b7:02:38:3d OK? Index: dev/pci/if_ixl.c

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Stuart Henderson
On 2021/10/22 11:25, Jan Klemkow wrote: > this diff add hardware checksum offloading for the receive path of > ixl(4) interfaces. Would be good to have this tested with NFS if anyone has a way to do so. nics are probably better now but I'm pretty sure we have had problems with NFS and offloading

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Klemens Nanni
On Fri, Oct 22, 2021 at 01:39:47PM +0200, Jan Klemkow wrote: > On Fri, Oct 22, 2021 at 12:01:41PM +0200, Hrvoje Popovski wrote: > > On 22.10.2021. 11:25, Jan Klemkow wrote: > > > this diff add hardware checksum offloading for the receive path of > > > ixl(4) interfaces. > > > > > > Tested on: > >

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Jan Klemkow
On Fri, Oct 22, 2021 at 12:01:41PM +0200, Hrvoje Popovski wrote: > On 22.10.2021. 11:25, Jan Klemkow wrote: > > this diff add hardware checksum offloading for the receive path of > > ixl(4) interfaces. > > > > Tested on: > > ixl1 at pci3 dev 0 function 1 "Intel X710 SFP+" rev 0x02: port 1, FW >

Re: ixl(4): add checksum receive offloading

2021-10-22 Thread Hrvoje Popovski
On 22.10.2021. 11:25, Jan Klemkow wrote: > Hi, > > this diff add hardware checksum offloading for the receive path of > ixl(4) interfaces. > > Tested on: > ixl1 at pci3 dev 0 function 1 "Intel X710 SFP+" rev 0x02: port 1, FW > 6.0.48442 API 1.7, msix, 8 queues, address 40:a6:b7:02:38:3d > >