Re: patch: nullify v_data with NULL (and not with 0)

2021-10-21 Thread Sebastien Marie
On Wed, Oct 20, 2021 at 10:18:57AM +1100, Jonathan Gray wrote: > On Tue, Oct 19, 2021 at 07:37:36AM -0600, Todd C. Miller wrote: > > On Tue, 19 Oct 2021 18:08:04 +1100, Jonathan Gray wrote: > > > > > There are many others along those lines in the kernel, for example > > > sparse complains about

Re: patch: nullify v_data with NULL (and not with 0)

2021-10-19 Thread Jonathan Gray
On Tue, Oct 19, 2021 at 07:37:36AM -0600, Todd C. Miller wrote: > On Tue, 19 Oct 2021 18:08:04 +1100, Jonathan Gray wrote: > > > There are many others along those lines in the kernel, for example > > sparse complains about these in vfs_subr.c > > > > /sys/kern/vfs_subr.c:274:64: warning: Using

Re: patch: nullify v_data with NULL (and not with 0)

2021-10-19 Thread Todd C . Miller
On Tue, 19 Oct 2021 18:08:04 +1100, Jonathan Gray wrote: > There are many others along those lines in the kernel, for example > sparse complains about these in vfs_subr.c > > /sys/kern/vfs_subr.c:274:64: warning: Using plain integer as NULL pointer > /sys/kern/vfs_subr.c:275:64: warning: Using

Re: patch: nullify v_data with NULL (and not with 0)

2021-10-19 Thread Sebastien Marie
On Tue, Oct 19, 2021 at 06:08:04PM +1100, Jonathan Gray wrote: > On Tue, Oct 19, 2021 at 08:32:57AM +0200, Sebastien Marie wrote: > > Hi, > > > > Simple online diff for properly nullify v_data (which is `void *`) > > with NULL instead of 0. > > > > Comments or OK ? > > -- > > Sebastien Marie >

Re: patch: nullify v_data with NULL (and not with 0)

2021-10-19 Thread Jonathan Gray
On Tue, Oct 19, 2021 at 08:32:57AM +0200, Sebastien Marie wrote: > Hi, > > Simple online diff for properly nullify v_data (which is `void *`) > with NULL instead of 0. > > Comments or OK ? > -- > Sebastien Marie > There are many others along those lines in the kernel, for example sparse

patch: nullify v_data with NULL (and not with 0)

2021-10-19 Thread Sebastien Marie
Hi, Simple online diff for properly nullify v_data (which is `void *`) with NULL instead of 0. Comments or OK ? -- Sebastien Marie blob - 1f7409235f4696765c6b8b22e65d953b1d6e5100 blob + 8cb011e9c3e48fcc34b8ce62974cafd430bb4e6a --- sys/kern/vfs_subr.c +++ sys/kern/vfs_subr.c @@ -469,7 +469,7