Re: sndiod hangs

2015-07-16 Thread Alexandre Ratchov
On Mon, Jul 13, 2015 at 12:52:14PM +0200, Alexandre Ratchov wrote: > On Sat, Jul 11, 2015 at 02:23:03PM +0200, Mark Kettenis wrote: > > Every now and then sndiod hangs on me. Usually I discover this as > > mplayer hangs while playing a video or hangs while opening the audio > > device on startup.

Rational behind split struct in uvideo.h

2015-07-16 Thread ludovic coues
I am looking for some insight about some choice in the code. In the file /sys/dev/usb/uvideo.h, the structure usb_video_header_desc store a part of an USB descriptor. The entire descriptor is stored in usb_video_header_desc_all which consist of fix, a pointer to the former struct and baInterfaceNR

nsd update

2015-07-16 Thread Stuart Henderson
Highlights: reallocarray, various fixes for zone file parsing. I haven't added the compat file for reallocarray as we don't need it (we can remove most other compat files but that's not part of this diff). Comments, OK? NSD 4.1.3: Features nsd-control addzones and delzones read list of zon

Xen still failing with recent v1.41 vector.S

2015-07-16 Thread Joel
Hello, I was excited to see Xen mentioned in a recent commit log. Unfortunately, there are still some issues when going multiprocessor. The dom0 machine was an Ubuntu server running 10.04.2 with a Xen version of 4.4.1 (refer to file xen.info). The original (mp.57) tests were using a base 5.7 sys

tcpdump 11n HT capabilities

2015-07-16 Thread Stefan Sperling
Make tcpdump show 11n HT capabilities. OK? Index: print-802_11.c === RCS file: /cvs/src/usr.sbin/tcpdump/print-802_11.c,v retrieving revision 1.18 diff -u -p -r1.18 print-802_11.c --- print-802_11.c 15 Jul 2015 03:05:00 -

Re: tcpdump 11n HT capabilities

2015-07-16 Thread Vadim Zhukov
2015-07-16 22:05 GMT+03:00 Stefan Sperling : > Make tcpdump show 11n HT capabilities. > > OK? > > Index: print-802_11.c > === > RCS file: /cvs/src/usr.sbin/tcpdump/print-802_11.c,v > retrieving revision 1.18 > diff -u -p -r1.18 print-8

Re: Rational behind split struct in uvideo.h

2015-07-16 Thread Martin Pieuchot
On 16/07/15(Thu) 16:24, ludovic coues wrote: > I am looking for some insight about some choice in the code. > > In the file /sys/dev/usb/uvideo.h, the structure usb_video_header_desc > store a part of an USB descriptor. The entire descriptor is stored in > usb_video_header_desc_all which consist o

Re: Rational behind split struct in uvideo.h

2015-07-16 Thread ludovic coues
2015-07-16 21:45 GMT+02:00 Martin Pieuchot : > On 16/07/15(Thu) 16:24, ludovic coues wrote: >> But I don't know why this code is done this way. As it haven't been >> touched since version 1.4 in 2008, I assume it's an old way of doing >> things or a short term solution. If that the case, I'll go ah

Re: Xen still failing with recent v1.41 vector.S

2015-07-16 Thread Mike Belopuhov
On 16 July 2015 at 19:42, Joel wrote: > Hello, > > I was excited to see Xen mentioned in a recent commit log. > Unfortunately, there are still some issues when going multiprocessor. > > The dom0 machine was an Ubuntu server running 10.04.2 with a Xen version > of 4.4.1 (refer to file xen.info). >

words splitting in doas

2015-07-16 Thread Vadim Zhukov
The manpage recommends using absolute paths for commands, but those won't work. :) This patch makes everything not in a list of special characters to be a part of word; this way you can easily put the following in doas.conf: permit :somepeople cmd /usr/bin/mail viva+d...@openbsd.org The next st

Re: words splitting in doas

2015-07-16 Thread Ted Unangst
Vadim Zhukov wrote: > The manpage recommends using absolute paths for commands, but those > won't work. :) This patch makes everything not in a list of special > characters to be a part of word; this way you can easily put > the following in doas.conf: > > permit :somepeople cmd /usr/bin/mail vi

tcpdump: decode 802.11 country element

2015-07-16 Thread Stefan Sperling
tcpdump currently prints country elements in 802.11 mgmt frames in hex: country 67 65 32 1 11 30, This diff makes tcpdump display the decoded form instead: country 'CA ', channels 1 2 3 4 5 6 7 8 9 10, max TX power 30dB Also show the power constraint which needs to be subtraced from max T

Ask for password for failed commands

2015-07-16 Thread Vadim Zhukov
Ask for a password when we're going to fail() anyway, to avoid leaking information about available commands. The sudo(8) behaves the same way, FWIW. okay? -- WBR, Vadim Zhukov Index: doas.c === RCS file: /cvs/src/usr.bin/doas/doa

Bump LIBRESSL_VERSION defines

2015-07-16 Thread Brent Cook
Up to now, we have only bumped the LIBRESSL_VERSION_TEXT for each portable release in the portable tree, and the VERSION_NUMBER has never incremented. This change establishes a policy of bumping the number for each portable release, and syncs the version string between the portable and in-tree rel

Re: words splitting in doas

2015-07-16 Thread Vadim Zhukov
2015-07-17 1:02 GMT+03:00 Ted Unangst : > Vadim Zhukov wrote: >> The manpage recommends using absolute paths for commands, but those >> won't work. :) This patch makes everything not in a list of special >> characters to be a part of word; this way you can easily put >> the following in doas.conf:

Re: Ask for password for failed commands

2015-07-16 Thread Ted Unangst
Vadim Zhukov wrote: > Ask for a password when we're going to fail() anyway, to avoid > leaking information about available commands. The sudo(8) behaves > the same way, FWIW. > > okay? i need to think about this for a bit. there's a strange interaction where if the nopasswd option is used, you've

Re: words splitting in doas

2015-07-16 Thread Ted Unangst
Vadim Zhukov wrote: > 2015-07-17 1:02 GMT+03:00 Ted Unangst : > > Vadim Zhukov wrote: > >> The manpage recommends using absolute paths for commands, but those > >> won't work. :) This patch makes everything not in a list of special > >> characters to be a part of word; this way you can easily put >

Re: Bump LIBRESSL_VERSION defines

2015-07-16 Thread Bob Beck
ok beck@ after much discusison :) On Thu, Jul 16, 2015 at 4:08 PM, Brent Cook wrote: > Up to now, we have only bumped the LIBRESSL_VERSION_TEXT for each > portable release in the portable tree, and the VERSION_NUMBER has never > incremented. > > This change establishes a policy of bumping the nu

Re: tcpdump: decode 802.11 country element

2015-07-16 Thread Vadim Zhukov
2015-07-17 1:04 GMT+03:00 Stefan Sperling : > tcpdump currently prints country elements in 802.11 mgmt frames in hex: > >country 67 65 32 1 11 30, > > This diff makes tcpdump display the decoded form instead: > >country 'CA ', channels 1 2 3 4 5 6 7 8 9 10, max TX power 30dB > > Also show t

Re: words splitting in doas

2015-07-16 Thread Ted Unangst
Vadim Zhukov wrote: > 2015-07-17 1:02 GMT+03:00 Ted Unangst : > > Vadim Zhukov wrote: > >> The manpage recommends using absolute paths for commands, but those > >> won't work. :) This patch makes everything not in a list of special > >> characters to be a part of word; this way you can easily put >

Re: Ask for password for failed commands

2015-07-16 Thread Ted Unangst
Vadim Zhukov wrote: > Ask for a password when we're going to fail() anyway, to avoid > leaking information about available commands. The sudo(8) behaves > the same way, FWIW. Let's say no for now. I'm not too concerned about this leak. I'm not sure what a user would hope to discover. Hasn't the sy

tcpdump: show 802.11 bss load

2015-07-16 Thread Stefan Sperling
With this diff, if management frames contain information about the load of the BSS, tcpdump displays it. Tested in the calgary hackroom: 6 stations, 10% utilization, admission capacity 732us/s Only so few people on 5GHz? ;) The meaning of 'adminission capacity' is a bit cryptic. It helps STAs

Re: tcpdump: decode 802.11 country element

2015-07-16 Thread Stefan Sperling
On Fri, Jul 17, 2015 at 01:23:54AM +0300, Vadim Zhukov wrote: > > + printf(", channels %d", first_chan); > > + for (i = first_chan + 1; i < nchan; i++) > > + printf(" %i", i); > > It looks like you simply enumerate from first_chan till nchan; why n

sa_family_t is not always equal to u_int8_t

2015-07-16 Thread Alexandr Nedvedicky
Hello, we hit this problem while building PF on Solaris, where sizeof(sa_family_t) == 2 patch below fixes the problem for Solaris. regards sasha cvs diff -p output: --8<--8<--8<-- Index: pfvar.h === RCS file: /cvs/

potential memory leak when pf_create_state() fails

2015-07-16 Thread Alexandr Nedvedicky
Hello, It seems to me PF might leak rule items when pf_create_state() fails to create state for matching packet. The scenario is as follows: packet matches couple of 'match' rules before it hits a 'pass' rule match rules are kept in `rules` single list, which is a local variable of p

Re: tcpdump: decode 802.11 country element

2015-07-16 Thread Vadim Zhukov
2015-07-17 1:49 GMT+03:00 Stefan Sperling : > On Fri, Jul 17, 2015 at 01:23:54AM +0300, Vadim Zhukov wrote: >> > + printf(", channels %d", first_chan); >> > + for (i = first_chan + 1; i < nchan; i++) >> > + printf(" %i", i); >> >> It looks like you

update kroute.c to follow bgpd/kroute.c

2015-07-16 Thread Claudio Jeker
So mpi@ fixed a problem with connected routes in bgpd. It is time to update all the other kroute.c implementations as well. ospfd, ospf6d, ripd, ldpd and snmpd (which I'm unsure about) Please test -- :wq Claudio Index: kroute.c ===

potential memory leak in SIOCADDRULE

2015-07-16 Thread Alexandr Nedvedicky
Hello, PF can leak memory in DIOCADDRULE code path in case something goes wrong with rule creation. Our story begins when we do pf_rule_copyin(): 1070 if ((error = pf_rule_copyin(&pr->rule, rule, ruleset))) { 1071 pool_put(&pf_rule_pl, rule);

Re: sa_family_t is not always equal to u_int8_t

2015-07-16 Thread Alexandr Nedvedicky
On Thu, Jul 16, 2015 at 11:10:06PM +, Miod Vallat wrote: > > cvs diff -p output: > > Please send unified diffs (diff -u). The easiest way is to have a > diff -up > line in your ~/.cvsrc file. Or "diff -uNp" if you want cvs diff to show > new files as well. > > Miod Sorry, now I got it.. r

bridge(4) and etherip fix

2015-07-16 Thread Martin Pieuchot
goda@ found a regression due to the recent M_PROTO1 change. Apparently gif(4) is using this flag to know that a packet comes from bridge(4) and wants etherip encapsulation. Instead of hiding another layer-violation (yeah for bridge!) make it obvious. Diff below, any ok? Index: net/if_bridge.c =

Re: tcpdump: decode 802.11 country element

2015-07-16 Thread Stefan Sperling
On Fri, Jul 17, 2015 at 02:26:29AM +0300, Vadim Zhukov wrote: > 2015-07-17 1:49 GMT+03:00 Stefan Sperling : > > On Fri, Jul 17, 2015 at 01:23:54AM +0300, Vadim Zhukov wrote: > >> > + printf(", channels %d", first_chan); > >> > + for (i = first_chan + 1; i < nchan; i++) >

Fix socketpair(2) handling of unix datagram sockets using cloexec/nonblock

2015-07-16 Thread Jeremy Evans
Fix socketpair(2) on Unix datagram sockets that use SOCK_CLOEXEC or SOCK_NONBLOCK. This fixes a failure in the ruby test suite. OK? Thanks, Jeremy Index: kern/uipc_syscalls.c === RCS file: /cvs/src/sys/kern/uipc_syscalls.c,v retrie

Re: sa_family_t is not always equal to u_int8_t

2015-07-16 Thread Martin Pieuchot
On 17/07/15(Fri) 01:41, Alexandr Nedvedicky wrote: > On Thu, Jul 16, 2015 at 11:10:06PM +, Miod Vallat wrote: > > > cvs diff -p output: > > > > Please send unified diffs (diff -u). The easiest way is to have a > > diff -up > > line in your ~/.cvsrc file. Or "diff -uNp" if you want cvs diff t

Re: Fix socketpair(2) handling of unix datagram sockets using cloexec/nonblock

2015-07-16 Thread Philip Guenther
On Thu, Jul 16, 2015 at 4:54 PM, Jeremy Evans wrote: > Fix socketpair(2) on Unix datagram sockets that use SOCK_CLOEXEC or > SOCK_NONBLOCK. > > This fixes a failure in the ruby test suite. > > OK? No, that'll have false positives on SOCK_RAW sockets. You need to mask things, perhaps a diff like

Re: tcpdump: decode 802.11 country element

2015-07-16 Thread Vadim Zhukov
2015-07-17 2:53 GMT+03:00 Stefan Sperling : > On Fri, Jul 17, 2015 at 02:26:29AM +0300, Vadim Zhukov wrote: >> 2015-07-17 1:49 GMT+03:00 Stefan Sperling : >> > On Fri, Jul 17, 2015 at 01:23:54AM +0300, Vadim Zhukov wrote: >> >> > + printf(", channels %d", first_chan); >> >> > +

[patch] Disklabel message tweak

2015-07-16 Thread Michael McConville
This is another trivial patch, but I've always found the disklabel message "No label changes" confusing. For example, if you print (p), add a label (a), write (w), print to check your changes (p), and then quit (q), it seems odd to be told "No label changes". Index: sbin/disklabel/editor.c

Re: [patch] Disklabel message tweak

2015-07-16 Thread Miod Vallat
> This is another trivial patch, but I've always found the disklabel > message "No label changes" confusing. For example, if you print (p), add > a label (a), write (w), print to check your changes (p), and then quit > (q), it seems odd to be told "No label changes". Well, the current message mak

Re: Ask for password for failed commands

2015-07-16 Thread Bob Beck
I concur. Vadim I like the basic idea, but I do not like that in the bogus case we still run all the priviledged user auth code. On Thu, Jul 16, 2015 at 4:30 PM, Ted Unangst wrote: > Vadim Zhukov wrote: >> Ask for a password when we're going to fail() anyway, to avoid >> leaking information abo

Re: Ask for password for failed commands

2015-07-16 Thread David Gwynne
> On 17 Jul 2015, at 16:18, Bob Beck wrote: > > I concur. Vadim I like the basic idea, but I do not like that in the > bogus case we still run all the priviledged user auth code. sudo also has the -l flag, which lists what commands you're allowed to run. however, it looks like if you arent al

Re: [patch] Disklabel message tweak

2015-07-16 Thread Theo de Raadt
>This is another trivial patch, but I've always found the disklabel >message "No label changes" confusing. For example, if you print (p), add >a label (a), write (w), print to check your changes (p), and then quit >(q), it seems odd to be told "No label changes". > > > >Index: sbin/disklabel/edito