Re: Process-shared futexes

2018-06-02 Thread Martin Pieuchot
On 01/06/18(Fri) 19:13, Mark Kettenis wrote: > The diff below changes our futex implementation to allow futexes that > are shared between processes. Such futexes are a little bit tricky > since there is no guarantee that a futex is mapped at the same address > in each process. To solve tis issue

Re: Remove unused C3 values (VIA)

2018-06-02 Thread Visa Hankala
On Sat, Jun 02, 2018 at 01:00:05PM +0200, Frederic Cambus wrote: > Hi tech@, > > Here is a diff to remove unused C3 values. > > Comments? OK? I would keep the definitions because they can at least serve as a weak form of documentation about the hardware. For example, C3_CRYPT_CWLO_ALG_M

Remove unused C3 values (VIA)

2018-06-02 Thread Frederic Cambus
Hi tech@, Here is a diff to remove unused C3 values. Comments? OK? Index: sys/arch/amd64/include/specialreg.h === RCS file: /cvs/src/sys/arch/amd64/include/specialreg.h,v retrieving revision 1.72 diff -u -p -r1.72 specialreg.h ---

Locking problem with open(2)

2018-06-02 Thread Visa Hankala
The open(2) system call uses a problematic locking pattern that can cause problems when the process has more than one thread. The system call keeps the file descriptor table locked when calling vn_open(9). If vn_open(9) blocks, the other threads get blocked too if they try to modify the descriptor

Re: Process-shared futexes

2018-06-02 Thread Mark Kettenis
> Date: Sat, 2 Jun 2018 12:04:16 +0200 > From: Martin Pieuchot > > On 01/06/18(Fri) 19:13, Mark Kettenis wrote: > > The diff below changes our futex implementation to allow futexes that > > are shared between processes. Such futexes are a little bit tricky > > since there is no guarantee that a

Re: Remove unused C3 values (VIA)

2018-06-02 Thread Mark Kettenis
> Date: Sat, 2 Jun 2018 11:30:15 + > From: Visa Hankala > > On Sat, Jun 02, 2018 at 01:00:05PM +0200, Frederic Cambus wrote: > > Hi tech@, > > > > Here is a diff to remove unused C3 values. > > > > Comments? OK? > > I would keep the definitions because they can at least serve as a weak >

armv7 lld fix

2018-06-02 Thread Mark Kettenis
Diff below works around a crash provoked by the /DISCARD/ : { *(.ARM.exidx) } fragment in the kernel linker script. It seems this issue is already fixed upstream in a different way. But backporting that fix isn't trivial. ok? Index:

Re: Remove BACKWARDS flag from get_shell_command in ed(1)

2018-06-02 Thread Martijn van Duren
anyone? On 05/24/18 09:40, Martijn van Duren wrote: > Since we accept "!" as a full command to system(3), I decided to do even > more trimming than when BACKWARDS is not defined. This way we trim even > more LoC and have one less error case. > > Note that running "!!" without a prior command

Re: Process-shared futexes

2018-06-02 Thread Mark Kettenis
> Date: Sat, 2 Jun 2018 12:42:14 +0200 (CEST) > From: Mark Kettenis > > > Date: Sat, 2 Jun 2018 12:04:16 +0200 > > From: Martin Pieuchot > > > > On 01/06/18(Fri) 19:13, Mark Kettenis wrote: > > > The diff below changes our futex implementation to allow futexes that > > > are shared between

ed remove BACKWARDS from GET_THIRD_ADDR

2018-06-02 Thread Martijn van Duren
Hello tech@, The following patch removes the non-backwards case for GET_THIRD_ADDR. POSIX states nothing about making it optional, and since it is our and NetBSD's current behaviour, just leave it as is. I can see how for interactive use making the 3rd argument default to the current address

Re: Remove unused C3 values (VIA)

2018-06-02 Thread Frederic Cambus
On Sat, Jun 02, 2018 at 11:30:15AM +, Visa Hankala wrote: > On Sat, Jun 02, 2018 at 01:00:05PM +0200, Frederic Cambus wrote: > > Hi tech@, > > > > Here is a diff to remove unused C3 values. > > > > Comments? OK? > > I would keep the definitions because they can at least serve as a weak >

witness report

2018-06-02 Thread Bryan Steele
Happens while booting my AMD desktop w/ radeon. lock order reversal: 1st 0xff01d4b2be30 vmmaplk (>lock) @ /home/brynet/Projects/current/src/sys/uvm/uvm_map.c:4433 2nd 0xff01d415a0a0 inode (>i_lock) @ /home/brynet/Projects/current/src/sys/ufs/ufs/ufs_vnops.c:1559 lock order

Re: Allow disks to be specifid by duid in install.sub

2018-06-02 Thread Robert Peichaer
On Fri, May 18, 2018 at 12:14:36PM +0200, Theo Buehler wrote: > On Thu, May 17, 2018 at 06:42:15PM -0600, Aaron Bieber wrote: > > On Thu, May 17, 2018 at 06:37:56PM -0600, Aaron Bieber wrote: > > > On Fri, Mar 02, 2018 at 07:32:04AM -0700, Aaron Bieber wrote: > > > > Hi, > > > > > > > > Currently

[patch] rc.subr support for pidfile-based daemons

2018-06-02 Thread Il Ka
Hello, rc.subr(8) uses pgrep(1)/pkill(1) to control daemons using their command lines. But in some cases it is more convenient to use pidfiles. Many services do so, inluding apache and postgresql. But not all services do have special tool for that. I run gunicorn (python wsgi server) that is

acme-client/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to acme-client. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/acme-client/parse.y,v retrieving revision 1.21 diff -u -p -r1.21 parse.y ---

bgpd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to bgpd Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v retrieving revision 1.320 diff -u -p -r1.320 parse.y --- parse.y 26

Re: [patch] rc.subr support for pidfile-based daemons

2018-06-02 Thread Stuart Henderson
On 2018/06/02 23:07, Il Ka wrote: > rc.subr(8) uses pgrep(1)/pkill(1) to control daemons > using their command lines. This is intentional. pid files can easily get out of sync with the expected process (example: daemon starts, writes a pid file, later it crashes. at any point between the crash

witness during regress

2018-06-02 Thread Alexander Bluhm
Hi, Apart from the traces already reported, my amd64 machine finds this one while running regress. acquiring duplicate lock of same type: ">mnt_lock" 1st vfslock @ /usr/src/sys/kern/vfs_subr.c:191 2nd vfslock @ /usr/src/sys/kern/vfs_subr.c:191 Starting stack trace...

hostapd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to hostapd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/hostapd/parse.y,v retrieving revision 1.55 diff -u -p -r1.55 parse.y --- parse.y

smtpd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to smtpd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/smtpd/parse.y,v retrieving revision 1.210 diff -u -p -r1.210 parse.y --- parse.y 1

eigrpd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to eigrpd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/eigrpd/parse.y,v retrieving revision 1.23 diff -u -p -r1.23 parse.y --- parse.y

snmpd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to snmpd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/snmpd/parse.y,v retrieving revision 1.47 diff -u -p -r1.47 parse.y --- parse.y 26

switchd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to switchd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/switchd/parse.y,v retrieving revision 1.6 diff -u -p -r1.6 parse.y --- parse.y

iked/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to iked. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/sbin/iked/parse.y,v retrieving revision 1.71 diff -u -p -r1.71 parse.y --- parse.y 26 Apr

httpd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to httpd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/httpd/parse.y,v retrieving revision 1.99 diff -u -p -r1.99 parse.y --- parse.y 23

iscsictl/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to iscsictl. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/iscsictl/parse.y,v retrieving revision 1.11 diff -u -p -r1.11 parse.y --- parse.y

vmd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to vmd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/vmd/parse.y,v retrieving revision 1.33 diff -u -p -r1.33 parse.y --- parse.y 26 Apr

ldpd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to ldpd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/ldpd/parse.y,v retrieving revision 1.62 diff -u -p -r1.62 parse.y --- parse.y 26

ospf6d/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to ospf6d. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/ospf6d/parse.y,v retrieving revision 1.31 diff -u -p -r1.31 parse.y --- parse.y

ldapd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to ldapd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/ldapd/parse.y,v retrieving revision 1.28 diff -u -p -r1.28 parse.y --- parse.y 18

ypldap/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to ypldap. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/ypldap/parse.y,v retrieving revision 1.24 diff -u -p -r1.24 parse.y --- parse.y

relayd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to relayd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/relayd/parse.y,v retrieving revision 1.223 diff -u -p -r1.223 parse.y --- parse.y

Re: [patch] rc.subr support for pidfile-based daemons

2018-06-02 Thread IL Ka
> > pid files can easily get out of sync with the expected process (example: > daemon starts, writes a pid file, later it crashes. at any point between > the crash and you trying to stop/restart the daemon another process > could be assigned the same pid, then the wrong process is signalled). >

Re: [patch] rc.subr support for pidfile-based daemons

2018-06-02 Thread Theo de Raadt
IL Ka wrote: > > > > pid files can easily get out of sync with the expected process (example: > > daemon starts, writes a pid file, later it crashes. at any point between > > the crash and you trying to stop/restart the daemon another process > > could be assigned the same pid, then the wrong

route: regress: Allow specifying binary via ROUTE

2018-06-02 Thread Klemens Nanni
With `make ROUTE=/usr/obj/sbin/route/route' I can test my patched version without having to modify PATH or the regress Makefile. pfctl already does it that way. OK? Index: Makefile === RCS file:

Re: route: regress: Allow specifying binary via ROUTE

2018-06-02 Thread Alexander Bluhm
On Sun, Jun 03, 2018 at 12:26:18AM +0200, Klemens Nanni wrote: > With `make ROUTE=/usr/obj/sbin/route/route' I can test my patched > version without having to modify PATH or the regress Makefile. > > pfctl already does it that way. This is the right approach. > OK? I prefer ROUTE ?=

route: zap unused sockaddr

2018-06-02 Thread Klemens Nanni
No object change. OK? Index: show.c === RCS file: /cvs/src/sbin/route/show.c,v retrieving revision 1.112 diff -u -p -r1.112 show.c --- show.c 1 May 2018 18:13:21 - 1.112 +++ show.c 2 Jun 2018 22:55:26 - @@