Re: uow patch

2015-08-30 Thread Martin Pieuchot
On 29/08/15(Sat) 16:33, John L. Scarfone wrote: fixes panic on attach/detach due to free list corruption, also use after usbd_free_xfer(), tested on i386 That's good but the original design of allocating an xfer for every usbd_transfer(9) call does not make much sense. You could allocate two

Re: Using tame() in userland

2015-08-30 Thread Martin Natano
Inline comments below. --- tsort.c 29 Jul 2015 10:42:37 - 1.26 +++ tsort.c 28 Aug 2015 08:03:59 - @@ -798,6 +799,43 @@ find_longest_cycle(struct array *h, stru #define plural(n) ((n) 1 ? s : ) +static void +TAME(int flags, const char *wl[]) +{ + if

Re: syslogd host matches ip

2015-08-30 Thread Alexander Bluhm
On Sat, Aug 29, 2015 at 04:43:39PM +0200, Sebastien Marie wrote: On Fri, Aug 28, 2015 at 07:53:23PM +0200, Alexander Bluhm wrote: On Fri, Aug 28, 2015 at 06:11:02PM +0200, Alexander Bluhm wrote: The +host feature allows to select log messages from a specific host. Normally syslogd does a

Re: pool allocator names

2015-08-30 Thread Mark Kettenis
From: Ted Unangst t...@tedunangst.com Date: Sat, 29 Aug 2015 18:38:45 -0400 Mark Kettenis wrote: This diff is purely mechanical. This means that it also changes some pool_allocator_nointr into pool_allocator_single where the intention was to signal that the pool would never be used in

Re: [patch] return instead of exit(3) in src/bin/

2015-08-30 Thread Tobias Stoeckmann
On Sun, Aug 30, 2015 at 12:18:12PM -0600, Theo de Raadt wrote: In a more complex program with a large main() function, a call to exit() is an explicit statement about termination, so that even if someone refactors code to a subfunction, they must consider that it carefully. The return is

Re: [patch] return instead of exit(3) in src/bin/

2015-08-30 Thread Theo de Raadt
As suggested by deraadt@ and tobias@ it might be better to use the *return* statement instead of exit(3) inside the *main* function, to let the stack protector do its work. This diff removes such calls in all *src/bin/* tools, except those who already use it. I think I didn't miss a call

ntpd(8): Make -n quieter

2015-08-30 Thread Michael Reed
Hi all, If ntpd is run with the -n flag, and /etc/ntpd.conf is parsed without error, then Configuration OK is printed. I don't think this is particularly useful, as both a lack of an error message and an exit value of 0 already indicate success in this case. This seems to be the case for most

add midicat utility

2015-08-30 Thread Alexandre Ratchov
As aucat was simplified, base system lost the ability to move midi data from one port to another; for instance to connect a midi keyboard to a synth. The diff below adds the midicat utility which I used last few months to test/debug my midi setup and to connect my keyboard to a my synth. Example:

Re: [patch] httpd: fcgi/PATH_INFO not handled correctly

2015-08-30 Thread Joerg Jung
On Wed, Aug 26, 2015 at 08:23:22PM +0200, Denis Fondras wrote: Hello, While using httpd together uwsgi and Flask, I noticed that GET requests to / returned 404. The same setup with nginx was returning 200. The culprit is that PATH_INFO is not set when REQUEST_URI is /. The following patch

Re: [PATCH] PF: cksum modification refactor [1/24]

2015-08-30 Thread Joerg Jung
On Sun, Aug 30, 2015 at 06:22:14PM +1200, Richard Procter wrote: * constify local aliases - enables compilation to verify they are never reassigned ok? Your next patch [2/24] does remove this line, so no need for this one, right? to apply: $ cd /usr/src/sys $ cat - | patch

Re: [patch] cat's main never return

2015-08-30 Thread Tobias Stoeckmann
On Sat, Aug 29, 2015 at 05:02:33PM -0600, Theo de Raadt wrote: It really does not matter. Coder's choice. The result is the same. You could hunt them all down, change them all, save a few code bytes, but don't you dare introduce any bugs... The main function is called by crt0 like

Re: [PATCH] PF: cksum modification refactor [2/24]

2015-08-30 Thread Joerg Jung
On Sun, Aug 30, 2015 at 06:22:30PM +1200, Richard Procter wrote: * Remove local aliases saddr, daddr - eases refactoring later on I fail to see how yet, but ... [...] ok? ... with the assumption that the above statement will become true in the bigger picture, ok jung@ to apply:

ping6(8): cleanup getaddrinfo

2015-08-30 Thread Florian Obser
switch ping6(8) to the canonical example from getaddrinfo(3): error = getaddrinfo(..., res0); if (error) errx(1,...); [do stuff] freeaddrinfo(res0); I find this easier on the eyes: Hold on, why is it using a different struct addrinfo here? Why is it not calling freeaddrinfo(3)? Is it

Re: tap-and-drag on ALPS touchpads

2015-08-30 Thread Martin Pieuchot
On 15/08/15(Sat) 01:32, Ulf Brosziewski wrote: The tap-and-drag gesture doesn't work reliably with the ALPS touchpads supported by pms. To make it work, it is necessary to start dragging immediately with the second touch, which doesn't always succeed. Increasing the tap timeout helps, but

remove RH0 support from ping6(8)

2015-08-30 Thread Florian Obser
RH0 has been deprecated for quite some time now in RFC 5095. It's quite useless on OpenBSD since our stack unconditionally drops packets with a RH0 header so you can't get the packet out anyway. And last but not least it might get in the way if I ever manage to unify ping(8) and ping6(8). OK?

Re: synaptics touchpads: w mode and resolution

2015-08-30 Thread Martin Pieuchot
On 29/08/15(Sat) 15:10, Ulf Brosziewski wrote: On 08/29/2015 01:13 PM, Alexandr Shadchin wrote: On Fri, Aug 28, 2015 at 10:04:51PM +0200, Ulf Brosziewski wrote: Some weeks ago a change was made in pms to support Synaptics touchpads that don't provide W mode. I assume that only fairly old

Re: ntpd(8): Make -n quieter

2015-08-30 Thread Michael Reed
On 08/30/15 14:58, Michael Reed wrote: Hi all, If ntpd is run with the -n flag, and /etc/ntpd.conf is parsed without error, then Configuration OK is printed. I don't think this is particularly useful, as both a lack of an error message and an exit value of 0 already indicate success in