VMD: add regress tests for cdrom keyword

2018-01-06 Thread Carlos Cardenas
Attached are regress tests for the cdrom keyword. Comments? Ok? +--+ Carlos Index: Makefile === RCS file: /home/los/cvs/src/regress/usr.sbin/vmd/config/Makefile,v retrieving revision 1.3 diff -u -p -r1.3 Makefile --- Makefile11 N

Re: ksh: add missing bounds check in kb_add

2018-01-06 Thread Todd C. Miller
On Sat, 06 Jan 2018 13:25:37 -0700, "Todd C. Miller" wrote: > kb_add() counts the number of arguments passed via stdargs. > This would make sense if the buffer was allocated dynamically > but it is not. As such, there's no need to loop over the > arguments twice. > > Also, the loop that fills in

Re: init(8): unifdef LOGIN_CAP

2018-01-06 Thread Eitan Adler
On 6 January 2018 at 17:03, Eitan Adler wrote: > On 6 January 2018 at 05:48, Todd C. Miller wrote: >> There's no need for a compile-time knob to control the use of >> login.conf. > > What about usr.bin/login, usr.bin/passwd, usr.bin/newgrp, etc? ... or nevermind. I was looking at the wrong code :

Re: init(8): unifdef LOGIN_CAP

2018-01-06 Thread Eitan Adler
On 6 January 2018 at 05:48, Todd C. Miller wrote: > There's no need for a compile-time knob to control the use of > login.conf. What about usr.bin/login, usr.bin/passwd, usr.bin/newgrp, etc? -- Eitan Adler

Re: Meltdown, aka "Dear Intel, you suck"

2018-01-06 Thread Mark Kettenis
> From: Philip Guenther > Date: Fri, 5 Jan 2018 20:52:20 -0800 > > Unless something unexpected happens, we'll be applying the workaround to > amd64 first and then working out what to do for i386 and arm* (if still > though to be necessary for arm) after that. FWIW, Meltdown is a non-issue for Op

add .fs to mime.types as application/octet-stream

2018-01-06 Thread Stuart Henderson
e.g. "install62.fs". Some mirrors are doing this already but others aren't - let's at least make it easy for the ones running httpd. OK? Index: mime.types === RCS file: /cvs/src/share/misc/mime.types,v retrieving revision 1.3 diff -u

Re: clean on-disk filesystems through {suspend,hibernate}/resume

2018-01-06 Thread Theo de Raadt
> 4. Now the interesting case. Basically the same as (2) but now I > extracted src.tar.gz not in /tmp but in /home which is my largest > partition. This time, the suspend process does not finished and I > pulled the plug after some time. I've heard a report or two of it not completing sync. I

Re: clean on-disk filesystems through {suspend,hibernate}/resume

2018-01-06 Thread Matthias Schmidt
Hi, * Theo de Raadt wrote: > > I would appreciate reports, and later I'll cut this into pieces and > commit incremental changes. I run four tests on an Intel NUC with softraid CRYPTO and a keydisk. Although the sync+suspend does not finish in one test it is definitely am improvement and your wor

ksh: add missing bounds check in kb_add

2018-01-06 Thread Todd C. Miller
kb_add() counts the number of arguments passed via stdargs. This would make sense if the buffer was allocated dynamically but it is not. As such, there's no need to loop over the arguments twice. Also, the loop that fills in the line buffer (l) doesn't ensure that we stay within the bounds of the

clean on-disk filesystems through {suspend,hibernate}/resume

2018-01-06 Thread Theo de Raadt
I've been working for about a month to ensure filesystems are maximally syncronized and/or clean on-disk through a suspend/resume cycle. The idea is if a suspend/resume or hibernate/resume sequence gets broken (by pulling the power+battery during suspend, or similar circumstances during the hibera

ksh: State of NOTES and PROJECTS

2018-01-06 Thread Klemens Nanni
Looking at the CVS log one can see that other legacies such as ChangeLog have already been zapped. NOTES and PROJECTS have seen sporadic minor updates since import and still list valid topics, but they lack other long overdue correcttions. For example: - support for POSIX character class globbing

Re: ifconfig & wpa keys

2018-01-06 Thread Stefan Sperling
On Sat, Jan 06, 2018 at 03:03:55PM +0100, Martin Pieuchot wrote: > We're no longer exporting keys to userland, so can we stop printing > ""? > > ok? Fine with me. > > Index: ifconfig.c > === > RCS file: /cvs/src/sbin/ifconfig/ifcon

Re: ifconfig & wpa keys

2018-01-06 Thread Theo de Raadt
We used to try to create ifconfig output that someone could cut'n'paste back in as input, when it was reasonable. Therefore ifconfig output was a human hint suggesting what ifconfig command takes as input. But this one doesn't bother me, since for this line it doesn't work and making it shorter w

authpf: use monotime for duration log

2018-01-06 Thread Scott Cheloha
Hey, Use monotime here so the correct session duration is logged even in the event of a clock jump. While here, I think it's a good idea to cast time_t to the widest practical integer type when printing it to minimize the likelihood of truncation on platforms where int is smaller than time_t, or

ifconfig & wpa keys

2018-01-06 Thread Martin Pieuchot
We're no longer exporting keys to userland, so can we stop printing ""? ok? Index: ifconfig.c === RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v retrieving revision 1.351 diff -u -p -r1.351 ifconfig.c --- ifconfig.c 17 Nov 2017 18:04

init(8): unifdef LOGIN_CAP

2018-01-06 Thread Todd C. Miller
There's no need for a compile-time knob to control the use of login.conf. - todd Index: sbin/init/Makefile === RCS file: /cvs/src/sbin/init/Makefile,v retrieving revision 1.9 diff -u -p -u -r1.9 Makefile --- sbin/init/Makefile 25 S

Re: typecast to int in awk lshift function.

2018-01-06 Thread Otto Moerbeek
On Sat, Jan 06, 2018 at 09:00:07AM +, Prabhu Gurumurthy wrote: > On my 6.2 OpenBSD > > europa: [/usr/src/usr.bin/awk] > [1270]>> uname -a > OpenBSD europa.undisclosed.noname 6.2 GENERIC.MP#134 amd64 > > europa: [/usr/src/usr.bin/awk] > [1271]>> echo "172" | awk '{ print lshift($0, 24); }' >

Re: [patch] faq5.html, added missing branch to update -stable trees.

2018-01-06 Thread Job Snijders
Hi, On Sat, Jan 6, 2018 at 9:53 AM, Christoph R. Murauer wrote: > Here is a diff for the missing -rOPENBSD_6_2 branch to update the > -stable CVS trees as described in https://www.openbsd.org/anoncvs.html > at Updating an existing tree. I don't think this is needed in this context of the documen

[patch] macppc.html, added PowerMac7,3 G5 dual 1.8 GHz.

2018-01-06 Thread Christoph R. Murauer
Hello ! Here is a diff to add a PowerMac7,3 G5 1.8 GHz to the list of supported devices. As reference see my dmesg at https://marc.info/?l=openbsd-ppc&m=151311724932380&w=2 and the models at https://en.wikipedia.org/wiki/Power_Mac_G5#Product_revision_history Index: macppc.html ==

typecast to int in awk lshift function.

2018-01-06 Thread Prabhu Gurumurthy
On my 6.2 OpenBSD europa: [/usr/src/usr.bin/awk] [1270]>> uname -a OpenBSD europa.undisclosed.noname 6.2 GENERIC.MP#134 amd64 europa: [/usr/src/usr.bin/awk] [1271]>> echo "172" | awk '{ print lshift($0, 24); }' -1409286144 this seems to be caused by typecasting getfval in run.c to signed integer

[patch] faq5.html, added missing branch to update -stable trees.

2018-01-06 Thread Christoph R. Murauer
Hello ! Here is a diff for the missing -rOPENBSD_6_2 branch to update the -stable CVS trees as described in https://www.openbsd.org/anoncvs.html at Updating an existing tree. Index: faq5.html === RCS file: /cvs/www/faq/faq5.html,v re