Re: unwind: log missing config file

2019-11-18 Thread Claudio Jeker
On Mon, Nov 18, 2019 at 07:57:09PM -0700, Theo de Raadt wrote: > Florian Obser wrote: > > > On Tue, Nov 19, 2019 at 12:15:34AM +0100, Klemens Nanni wrote: > > > On Mon, Nov 18, 2019 at 10:19:47PM +0100, Klemens Nanni wrote: > > > > With that, my initial case is no longer misleading; alternativel

Re: unwind: log missing config file

2019-11-18 Thread Theo de Raadt
Florian Obser wrote: > On Tue, Nov 19, 2019 at 12:15:34AM +0100, Klemens Nanni wrote: > > On Mon, Nov 18, 2019 at 10:19:47PM +0100, Klemens Nanni wrote: > > > With that, my initial case is no longer misleading; alternatively, I > > > can implement the dash semantic, but that's another diff. > >

Re: unwind: log missing config file

2019-11-18 Thread Florian Obser
On Tue, Nov 19, 2019 at 12:15:34AM +0100, Klemens Nanni wrote: > On Mon, Nov 18, 2019 at 10:19:47PM +0100, Klemens Nanni wrote: > > With that, my initial case is no longer misleading; alternatively, I > > can implement the dash semantic, but that's another diff. > Hm, that makes the default setup

Re: unwind: log missing config file

2019-11-18 Thread Klemens Nanni
On Mon, Nov 18, 2019 at 10:19:47PM +0100, Klemens Nanni wrote: > With that, my initial case is no longer misleading; alternatively, I > can implement the dash semantic, but that's another diff. Hm, that makes the default setup (no /etc/unwind.conf, empty unwind_flags) always print a warning, which

Re: ifconfig inet6 netmask

2019-11-18 Thread Alexander Bluhm
On Mon, Nov 18, 2019 at 12:04:47PM -0700, Theo de Raadt wrote: > > As our ifconfig(8) man page says we support it, and route(8) also > > supports it, I prefer fixing inet6 netmask. > > accepting a netmask also requires thinking about the behaviour in the > discontig case (surely that means detectin

contiguous inet netmask check in kernel

2019-11-18 Thread Alexander Bluhm
Hi, Although ifconfig(8) checks it already, contiguous inet netmask should be enforced by the kernel. Currently the routing table does not support non-contiguous netmask, but we should error out early during interface ioctl(2). ok? bluhm Index: netinet/in.c

Re: kill VNDIOCGET60

2019-11-18 Thread Theo de Raadt
Jeremie Courreges-Anglas wrote: > On Mon, Nov 18 2019, Benjamin Baier wrote: > > Hi, found this. > > No idea why I commented this out instead of just deleting it. We're not > keeping old ioctls in other places. Committed, thanks. yes, that was a weird style.

Re: kill VNDIOCGET60

2019-11-18 Thread Jeremie Courreges-Anglas
On Mon, Nov 18 2019, Benjamin Baier wrote: > Hi, found this. No idea why I commented this out instead of just deleting it. We're not keeping old ioctls in other places. Committed, thanks. > -- Ben > > Index: vndioctl.h > === > RC

kill VNDIOCGET60

2019-11-18 Thread Benjamin Baier
Hi, found this. -- Ben Index: vndioctl.h === RCS file: /cvs/src/sys/dev/vndioctl.h,v retrieving revision 1.10 diff -u -p -r1.10 vndioctl.h --- vndioctl.h 14 Dec 2016 18:59:12 - 1.10 +++ vndioctl.h 18 Nov 2019 20:11:50 -00

unwind: log missing config file

2019-11-18 Thread Klemens Nanni
I gave unwind.conf(5) a read and wanted to test the following: $ echo preference dhcp | unwind -vnf- preference { DoT forwarder recursor dhcp stub } First, I thought unwind had a parser bug and would ignore my preference, but turns out it simply does not treat "-" as standard inpu

Re: XHCI support for bulk xfers >64k

2019-11-18 Thread Marcus Glocker
On Sun, Nov 17, 2019 at 12:36:49PM +0100, Marcus Glocker wrote: > While recently testing UDL on XHCI I faced a lot of USB timeouts, and > therefore screen rendering issues. > The reason is that XHCI currently only supports single bulk transfers > up to 64k, while UDL can schedule a bulk transfer u

Re: ifconfig inet6 netmask

2019-11-18 Thread Theo de Raadt
Alexander Bluhm wrote: > On Mon, Nov 18, 2019 at 09:58:34AM -0700, Theo de Raadt wrote: > > how about the text "use prefixlen instead of netmask for inet6" > > Much better error message, I have changed my diff. > > But we still have to decide whether we want to fix or disable inet6 > netmask.

Re: ifconfig inet6 netmask

2019-11-18 Thread Alexander Bluhm
On Mon, Nov 18, 2019 at 09:58:34AM -0700, Theo de Raadt wrote: > how about the text "use prefixlen instead of netmask for inet6" Much better error message, I have changed my diff. But we still have to decide whether we want to fix or disable inet6 netmask. Man page in FreeBSD says (Inet only.),

Re: ifconfig inet6 netmask

2019-11-18 Thread Theo de Raadt
Alexander Bluhm wrote: > + if (which == MASK) > + errx(1, "inet6 needs prefixlen, not netmask"); needs? you can configure an inet6 without prefixlen, and one is inferred. how about the text "use prefixlen instead of netmask for inet6"

Re: ifconfig inet6 netmask

2019-11-18 Thread Sebastian Benoit
Alexander Bluhm(alexander.bl...@gmx.net) on 2019.11.18 16:31:05 +0100: > On Thu, Nov 14, 2019 at 11:14:45PM +0100, Sebastian Benoit wrote: > > The alternative is to not allow netmask for ipv6 and only / and > > prefixlen > > . Why support such a crazy way of specifying the mask? > > We can also d

Re: ifconfig inet6 netmask

2019-11-18 Thread Alexander Bluhm
On Thu, Nov 14, 2019 at 11:14:45PM +0100, Sebastian Benoit wrote: > The alternative is to not allow netmask for ipv6 and only / and > prefixlen > . Why support such a crazy way of specifying the mask? We can also do it the other way around and forbid ifconfig inet6 netmask. > In route we removed

Re: sysupgrade: Allow to use another directory for the sets

2019-11-18 Thread Raimo Niskanen
On Mon, Nov 18, 2019 at 01:23:27PM +0100, Renaud Allard wrote: > > > On 11/18/19 10:08 AM, Raimo Niskanen wrote: > > > A configuration parameter could be accomplished through an optional symlink > > /etc/_sysupgrade that the sysadmin can create to point at the installation's > > sysupgrade direc

iked(8): enable udpencap with -t

2019-11-18 Thread Tobias Heider
Hi, this is only a minor fix. The '-t' flag forces iked to use NAT-traversal on UDP port 4500. Currently it enables NATT only for IKE, not for the resulting ESP SAs. The diff enables ESP NATT when iked NATT is enforced. ok? diff --git a/sbin/iked/ikev2.c b/sbin/iked/ikev2.c index bd22bda0255..3f

[PATCH] Extra lines in ssh-pkcs11-client.c file

2019-11-18 Thread Ville Valkonen
Hello, if I didn't overlook the function, there's extra lines in there. Please see the patch below. diff --git usr.bin/ssh/ssh-pkcs11-client.c usr.bin/ssh/ssh-pkcs11-client.c index 20284d98ecf..44065df1a96 100644 --- usr.bin/ssh/ssh-pkcs11-client.c +++ usr.bin/ssh/ssh-pkcs11-client.c @@ -230,9 +

Re: sysupgrade: Allow to use another directory for the sets

2019-11-18 Thread Renaud Allard
On 11/18/19 10:08 AM, Raimo Niskanen wrote: A configuration parameter could be accomplished through an optional symlink /etc/_sysupgrade that the sysadmin can create to point at the installation's sysupgrade directory. The sysupgrade script would test -s /etc/_sysupgrade and if there is a sym

Re: [PATCH] [src] bin/ed/README - fix quote/comma

2019-11-18 Thread Jason McIntyre
On Sun, Nov 17, 2019 at 11:08:49AM +, Raf Czlonka wrote: > On Sun, Nov 17, 2019 at 10:23:38AM GMT, Otto Moerbeek wrote: > > On Sun, Nov 17, 2019 at 08:31:00AM +, Raf Czlonka wrote: > > > > > Hi all, > > > > > > Pretty straightforward - comma snuck in inside the quoted book title. > > > >

Re: iwm: support 9260 devices

2019-11-18 Thread Stefan Sperling
On Mon, Nov 18, 2019 at 04:00:29AM +0100, Mark Kettenis wrote: > > > iwm0: hw rev 0x310, fw ver 34.-1169155311.0, address 90:78:41:39:57:8d > > > > I don't know yet what's up with that. Also happens on -17 firmware. > > The number we show for -34 firmware on 8260 looks OK though. > > It's printed

Re: sysupgrade: Allow to use another directory for the sets

2019-11-18 Thread Raimo Niskanen
On Thu, Nov 14, 2019 at 10:32:43AM +0100, Renaud Allard wrote: > > > On 11/13/19 11:51 PM, Renaud Allard wrote: > > > > > > On 12/11/2019 19:02, Renaud Allard wrote: > >> > >> > >> On 12/11/2019 08:29, Theo de Raadt wrote: > >>> > >>> Renaud, please test it for me like this: > >>> > >>>   s

Re: ospfd: type p2p

2019-11-18 Thread Kapetanakis Giannis
On 17/11/2019 13:44, Remi Locherer wrote: > Yes, I'll send a separate diff for that later. > > OK for the new diff? Works for me. G