Re: cwm: add fvwm and tvm as default wm entries

2023-05-15 Thread Klemens Nanni
On Mon, May 15, 2023 at 09:42:47AM -0400, Bryan Steele wrote: > On Mon, May 15, 2023 at 09:17:00AM -0400, Okan Demirmen wrote: > > On Mon 2023.05.15 at 10:41 +0200, Matthieu Herrb wrote: > > > On Mon, May 15, 2023 at 06:26:41AM +, Klemens Nanni wrote: > > > > Both fvwm(1) and twm(1) have a

Re: seperate LRO/TSO flags

2023-05-15 Thread Alexander Bluhm
On Mon, May 15, 2023 at 11:16:59PM +0200, Jan Klemkow wrote: > - updated the diff to the current source state > - improved the vlan(4) capability handling > > ok? OK bluhm@ > - "\11CSUM_UDPv6\17TSO\20WOL" > + "\11CSUM_UDPv6\15TSOv4\16TSOv6\17LSO\20WOL" typo s/LSO/LRO/

Re: Status of Virtual Function driver for Intel 82599 series port?

2023-05-15 Thread Yuichiro NAITO
Hi. Paul notified me that my previous patch was broken. I changed my mailer to Mew on Emacs that sends a plain text mail without any modification. I re-send my patch by Mew. Please try following patch. Thank you! diff --git a/sys/arch/amd64/conf/GENERIC b/sys/arch/amd64/conf/GENERIC index

Re: seperate LRO/TSO flags

2023-05-15 Thread Jan Klemkow
On Mon, May 15, 2023 at 11:40:20AM +0200, Alexander Bluhm wrote: > On Mon, May 15, 2023 at 09:34:21AM +0200, Jan Klemkow wrote: > > @@ -251,12 +251,16 @@ struct if_status_description { > > #defineIFCAP_VLAN_HWTAGGING0x0020 /* hardware VLAN tag > > support */ > > #define

Re: ix hardware tso

2023-05-15 Thread Alexander Bluhm
On Sun, May 14, 2023 at 11:39:01PM +0200, Hrvoje Popovski wrote: > I've tested this on openbsd box with 4 iperf3's. 2 for ip4 and 2 for ip6 > and with 16 tcp streams per iperf. When testing over ix(4) there is big > differences in output performance. When testing ix/veb/vport there is >

OpenBSD Errata: Mai 16, 2023 (bgpd)

2023-05-15 Thread Alexander Bluhm
An errata patch for bgpd and bgpctl has been released for OpenBSD 7.3. Binary updates for the amd64, i386 and arm64 platform are available via the syspatch utility. Source code patches can be found on the respective errata page: https://www.openbsd.org/errata73.html

user: simplify memsave() to strsave()

2023-05-15 Thread Todd C . Miller
All the callers of memsave() pass strlen(s) as the size argument. We can eliminate the size argument and just use strdup(3) instead. OK? - todd Index: user.c === RCS file: /cvs/src/usr.sbin/user/user.c,v retrieving revision 1.128

Re: cwm: add fvwm and tvm as default wm entries

2023-05-15 Thread Bryan Steele
On Mon, May 15, 2023 at 09:17:00AM -0400, Okan Demirmen wrote: > On Mon 2023.05.15 at 10:41 +0200, Matthieu Herrb wrote: > > On Mon, May 15, 2023 at 06:26:41AM +, Klemens Nanni wrote: > > > Both fvwm(1) and twm(1) have a restart menu that contains other window > > > managers by default, which

Re: smtpd: nits to reduce the diff with -portable

2023-05-15 Thread Omar Polo
On 2023/05/15 07:34:03 -0600, "Todd C. Miller" wrote: > On Mon, 15 May 2023 13:54:35 +0200, Omar Polo wrote: > > > almost always (cast)var. I've adjusted the spacing in the line I was > > touching, grepping for common types I could only find one instance of > > a '(long long) src' in envelope.c

Re: smtpd: nits to reduce the diff with -portable

2023-05-15 Thread gilles
May 15, 2023 3:34 PM, "Todd C. Miller" wrote: > On Mon, 15 May 2023 13:54:35 +0200, Omar Polo wrote: > >> almost always (cast)var. I've adjusted the spacing in the line I was >> touching, grepping for common types I could only find one instance of >> a '(long long) src' in envelope.c which I'm

Re: smtpd: nits to reduce the diff with -portable

2023-05-15 Thread Todd C . Miller
On Mon, 15 May 2023 13:54:35 +0200, Omar Polo wrote: > almost always (cast)var. I've adjusted the spacing in the line I was > touching, grepping for common types I could only find one instance of > a '(long long) src' in envelope.c which I'm not addressing here. OK millert@. It would be nice

Re: cwm: add fvwm and tvm as default wm entries

2023-05-15 Thread Okan Demirmen
On Mon 2023.05.15 at 10:41 +0200, Matthieu Herrb wrote: > On Mon, May 15, 2023 at 06:26:41AM +, Klemens Nanni wrote: > > Both fvwm(1) and twm(1) have a restart menu that contains other window > > managers by default, which is useful if you want to switch around > > without restarting X and/or

Re: smtpd: nits to reduce the diff with -portable

2023-05-15 Thread Omar Polo
On 2023/05/15 09:40:50 +0200, theo Buehler wrote: > Do we care that sometimes we (cast)var and sometimes we (cast) var? > Is this at least consistent per-file? almost always (cast)var. I've adjusted the spacing in the line I was touching, grepping for common types I could only find one instance

pfsync(4) must protect state with mutex

2023-05-15 Thread Alexandr Nedvedicky
Hello, diff below has been posted to bugs@ ~week [1] ago. Diff fixes long lasting issue I was scratching my head around for several months. Recently I've shared my itch with bluhm@ who pointed out that `sc_st_mtx` mutex is not sufficient protection. We also need to grab pf_state::mtx when

Re: calendar.usholiday: add Juneteenth

2023-05-15 Thread Jason McIntyre
ok. jmc On 15 May 2023 09:58:29 BST, "Anthony J. Bentley" wrote: >A federal holiday since 2021. > >ok? > >Index: usr.bin/calendar/calendars/calendar.usholiday >=== >RCS file: /cvs/src/usr.bin/calendar/calendars/calendar.usholiday,v

Re: seperate LRO/TSO flags

2023-05-15 Thread Alexander Bluhm
On Mon, May 15, 2023 at 09:34:21AM +0200, Jan Klemkow wrote: > @@ -251,12 +251,16 @@ struct if_status_description { > #define IFCAP_VLAN_HWTAGGING0x0020 /* hardware VLAN tag > support */ > #define IFCAP_CSUM_TCPv60x0080 /* can do IPv6/TCP > checksums */

Re: hardware TSO TCP/IP layer

2023-05-15 Thread Alexandr Nedvedicky
Hello, I see tcp_dochopper() got committed already... anyway changes here look good. I have no objection. OK sashan

calendar.usholiday: add Juneteenth

2023-05-15 Thread Anthony J. Bentley
A federal holiday since 2021. ok? Index: usr.bin/calendar/calendars/calendar.usholiday === RCS file: /cvs/src/usr.bin/calendar/calendars/calendar.usholiday,v retrieving revision 1.9 diff -u -p -r1.9 calendar.usholiday ---

Re: ix hardware tso

2023-05-15 Thread Peter Stuge
Claudio Jeker wrote: > > > Do not set ifconfig ix tso, this flag does not work correctly. > > > > Are there plans for that flag? Remove it? Use it? Only document as > > deprecated? Also print a deprecation message if used? > > It will be removed. No need to overcomplicate it with deprecation

Re: ix hardware tso

2023-05-15 Thread Claudio Jeker
On Mon, May 15, 2023 at 08:42:20AM +, Peter Stuge wrote: > Alexander Bluhm wrote: > > Do not set ifconfig ix tso, this flag does not work correctly. > > Are there plans for that flag? Remove it? Use it? Only document as > deprecated? Also print a deprecation message if used? It will be

Re: ix hardware tso

2023-05-15 Thread Peter Stuge
Alexander Bluhm wrote: > Do not set ifconfig ix tso, this flag does not work correctly. Are there plans for that flag? Remove it? Use it? Only document as deprecated? Also print a deprecation message if used? Thanks //Peter

Re: cwm: add fvwm and tvm as default wm entries

2023-05-15 Thread Matthieu Herrb
On Mon, May 15, 2023 at 06:26:41AM +, Klemens Nanni wrote: > Both fvwm(1) and twm(1) have a restart menu that contains other window > managers by default, which is useful if you want to switch around > without restarting X and/or custom window manager config. > > cwm(1) only offers to restart

Re: ifconfig description for wireguard peers

2023-05-15 Thread Hrvoje Popovski
On 15.5.2023. 9:47, Hrvoje Popovski wrote: > On 12.1.2023. 5:49, Mikolaj Kucharski wrote: >> Hi, >> >> Is there anything else which I can do, to help this diff reviwed and >> increase the chance of getting in? >> >> Thread at https://marc.info/?t=16347829861=1=2 >> >> Last version of the diff

Re: ifconfig description for wireguard peers

2023-05-15 Thread Hrvoje Popovski
On 12.1.2023. 5:49, Mikolaj Kucharski wrote: > Hi, > > Is there anything else which I can do, to help this diff reviwed and > increase the chance of getting in? > > Thread at https://marc.info/?t=16347829861=1=2 > > Last version of the diff at >

Re: smtpd: nits to reduce the diff with -portable

2023-05-15 Thread theo Buehler
On Mon, May 15, 2023 at 09:22:47AM +0200, Omar Polo wrote: > On 2023/05/15 09:03:47 +0200, Omar Polo wrote: > > On 2023/05/14 18:03:17 -0600, "Theo de Raadt" wrote: > > > Omar Polo wrote: > > > > On 2023/05/10 09:30:12 +0200, Theo Buehler wrote: > > > > > > I forgot to include one off_t cast

Re: seperate LRO/TSO flags

2023-05-15 Thread Jan Klemkow
On Sat, May 13, 2023 at 04:44:18PM +0200, Christian Weisgerber wrote: > Jan Klemkow: > > > This diff introduces separate flags for TCP offloading. We split this > > into LRO (large receive offloading) and TSO (TCP segmentation > > offloading). Thus, we are able to turn it on/off separately. >

Re: smtpd: nits to reduce the diff with -portable

2023-05-15 Thread Omar Polo
On 2023/05/15 09:03:47 +0200, Omar Polo wrote: > On 2023/05/14 18:03:17 -0600, "Theo de Raadt" wrote: > > Omar Polo wrote: > > > On 2023/05/10 09:30:12 +0200, Theo Buehler wrote: > > > > > I forgot to include one off_t cast since it was in a different > > > > > directory and -even if off topic

Re: smtpd: nits to reduce the diff with -portable

2023-05-15 Thread Omar Polo
On 2023/05/14 18:03:17 -0600, "Theo de Raadt" wrote: > Omar Polo wrote: > > On 2023/05/10 09:30:12 +0200, Theo Buehler wrote: > > > > I forgot to include one off_t cast since it was in a different > > > > directory and -even if off topic because it's not in portable- instead > > > > of

cwm: add fvwm and tvm as default wm entries

2023-05-15 Thread Klemens Nanni
Both fvwm(1) and twm(1) have a restart menu that contains other window managers by default, which is useful if you want to switch around without restarting X and/or custom window manager config. cwm(1) only offers to restart into itself by deafult. Add the other two we ship by default so users