Remove plain DES from kernel crypto

2015-12-10 Thread Christian Weisgerber
We just removed DES support from IPsec and there are no other users, so this deletes plain DES from the kernel crypto framework, including the crypto accelerator drivers. ok? Index: sys/crypto/cryptodev.h === RCS file: /cvs/src/sys/c

Re: initial 11n support for iwn (n, not m)

2015-12-16 Thread Christian Weisgerber
On 2015-12-16, David Hill wrote: > Thanks for the 11n work! > Unfortunately, your diff breaks iwn on my machine. > > iwn0 at pci2 dev 0 function 0 "Intel Centrino Ultimate-N 6300" rev 0x35: > msi, MIMO 3T3R, MoW, That is odd, because it works for me: iwn0 at pci2 dev 0 function 0 "Intel Centri

Re: Thinkpad display brightness control

2015-12-17 Thread Christian Weisgerber
On 2015-12-16, Mark Kettenis wrote: > The downside of this diff is that number of levels is limited to 16 > whereas we currently have much finer granularity. But I think that is > acceptable. The levels are probably better calibrated and we now have > proper coordination between the OS and the

Re: allocation simplifications in yacc

2015-12-30 Thread Christian Weisgerber
Michael McConville: > Index: skeleton.c > === > RCS file: /cvs/src/usr.bin/yacc/skeleton.c,v > retrieving revision 1.35 > diff -u -p -r1.35 skeleton.c > --- skeleton.c16 Mar 2014 18:38:30 - 1.35 > +++ skeleton.c

Re: allocation simplifications in yacc

2015-12-30 Thread Christian Weisgerber
Christian Weisgerber: > The removal of the casts causes a problem in ports/devel/mico, where > the yacc output is used in C++: Also: graphics/grap math/aamath math/logic2cnf -- Christian "naddy" Weisgerber na...@mips.inka.de

Re: ksh another home/end pair

2015-12-30 Thread Christian Weisgerber
On 2015-12-29, "Ted Unangst" wrote: > In tmux, home and end send different bytes. I don't know why, but I want > things to just work. We already have two different keys here, so what's one > more? (how many can there be...?) We shouldn't have any there. That's what termcap(3) is for. If you do

Re: Problem with svlan(4) and bge(4)

2016-01-10 Thread Christian Weisgerber
On 2016-01-10, Denis Fondras wrote: > Following http://article.gmane.org/gmane.os.openbsd.tech/47475, I have a > similar > problem with svlan(4) and em(4) (Intel 80003ES2). The main difference with > bge(4) is that ping works with em(4) but not tcp/udp. (obviously my bge(4) > supports IFCAP_CSUM

Re: Non-functional USB ports on thinkpad x230t/OpenBSD

2014-06-01 Thread Christian Weisgerber
On 2014-06-01, Edd Barrett wrote: > I am having a problem with the USB ports on my x230t. Other than the foldable touch display, this should be exactly the same machine as the X230. > The machine has three USB ports, two blue and one yellow. I'm assuming > the blue ones are USBv3, although I am

Re: mfi(4) vs WT and WB

2014-06-06 Thread Christian Weisgerber
On 2014-06-06, Otto Moerbeek wrote: > So what's the status of this WT/WB flag? Can't it be trusted for PERC > 6/i and maybe other adapters? On the old hub.ports (which had a PERC 5/i), the WT/WB flag could be trusted. Disk performance was noticeably worse in WT mode. -- Christian "naddy" Weis

Re: Non-functional USB ports on thinkpad x230t/OpenBSD

2014-06-08 Thread Christian Weisgerber
On 2014-06-01, Christian Weisgerber wrote: >> The blue ports do not appear to function under OpenBSD. > > They do. I just tried a mouse in all three of my X230's USB ports. > It worked in all of them. > > (I use the default BIOS settings, i.e., USB 3.0 mode [Auto].) I

We can dump(8) more than 2TB

2014-06-12 Thread Christian Weisgerber
After writing 2TB (INT_MAX * TP_BSIZE), dump(8) stops reporting progress because the blockswritten variable has wrapped around to negative. It needs to be a larger type like the tapesize variable; see optr.c:timeest(). This only affects the terminal chatter. The actual dump functionality is fine

Re: We can dump(8) more than 2TB

2014-06-12 Thread Christian Weisgerber
Ted Unangst: > > -intblockswritten; /* number of blocks written on current tape */ > > +off_t blockswritten; /* number of blocks written on current tape */ > > time_t tstart_writing; /* when started writing the first tape block */ > > longxferrate; /* averaged tra

Re: We can dump(8) more than 2TB

2014-06-12 Thread Christian Weisgerber
New diff. * Move all off_t variables that don't look like file sizes to int64_t. * Switch blockswritten to int64_t, so it won't wrap at 2TB. * Same for blocksthisvol (deraadt@). * Switch xferrate (tedu@) and blocksperfile from long to uint64_t. * Since blocksperfile can be set with -B, move numa

Re: ANONCVS MIRROR MAINTAINERS.. YOU NEED TO READ THIS!

2014-06-26 Thread Christian Weisgerber
As everybody noticed, there was another problem. Please update to cvsync-0.25.0pre0p0 for the latest bug fix. Sorry for all the inconvenience. -- Christian "naddy" Weisgerber na...@mips.inka.de

Re: divert(4) checksum offload

2014-07-10 Thread Christian Weisgerber
On 2014-07-10, Henning Brauer wrote: >> 1. Zero the protocol checksum. > > that should not be needed. at least afair. Indeed, we'll overwrite it with the pseudo-header checksum anyway. -- Christian "naddy" Weisgerber na...@mips.inka.de

Add mpbios to RAMDISK_CD?

2014-07-15 Thread Christian Weisgerber
The reason the Soekris net6501 has hw.ncpufound=1 in bsd.rd is stupid. The net6501 has MP BIOS, but not ACPI. Only the GENERIC (thus also GENERIC.MP) and RAMDISK kernels on amd64 and i386 include mpbios(4), RAMDISK_CD doesn't. Is there any reason we don't have mpbios(4) in RAMDISK_CD? Are there

Re: Add mpbios to RAMDISK_CD?

2014-07-15 Thread Christian Weisgerber
Ted Unangst: > > Is there any reason we don't have mpbios(4) in RAMDISK_CD? Are > > there space constraints to consider? It looks like an accidental > > omission to me. > > I think there is some concern that the mpbios is wrong on many > machines with acpi? RAMDISK_CD also has acpi0

Re: /etc/services records for squid & cvsyncd

2014-07-15 Thread Christian Weisgerber
On 2014-07-15, Craig R. Skinner wrote: > http://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?search= >= cbt, not cvsync I don't know what this entry is, but it isn't cvsync. (Maybe... Core Based Trees Multicast Routing, RFC 2189.) -- Christian "naddy

Re: apmd -C tweak

2014-07-15 Thread Christian Weisgerber
On 2014-07-13, Ted Unangst wrote: > for reference, i use this. faster query interval and when not idle, slam > high immediately. This appears to be much better than the current thresholds. -- Christian "naddy" Weisgerber na...@mips.inka.de

Drop accept_rtadv from installer

2014-07-17 Thread Christian Weisgerber
Since net.inet6.ip6.accept_rtadv is gone, the installer shouldn't set it. It is not obvious to me that enabling rediraccept is more important for IPv6 than for IPv4, where we keep is disabled by default. Do we want to kill that whole block? Index: install.sh =

arc4random.3: sysctl -> getentropy

2014-07-19 Thread Christian Weisgerber
Sync with reality. Index: arc4random.3 === RCS file: /cvs/src/lib/libc/crypt/arc4random.3,v retrieving revision 1.33 diff -u -p -r1.33 arc4random.3 --- arc4random.39 Jul 2014 16:57:49 - 1.33 +++ arc4random.31

Re: recent ipv6 changes: how to pick up rtadv without an autoconf address?

2014-07-25 Thread Christian Weisgerber
On 2014-07-25, Florian Obser wrote: >> Following the recent IPv6 changes, what method should now be used >> to have a statically configured ipv6 address but accept router >> advertisements to pick up a default route? > inet6 2001:DB8::23 > inet6 autoconf > up -autoconfprivacy You probably don't

newsyslog.conf: add httpd default log files to the rotation

2014-08-27 Thread Christian Weisgerber
Add httpd default log files to the rotation. Index: newsyslog.conf === RCS file: /cvs/src/etc/newsyslog.conf,v retrieving revision 1.32 diff -u -p -r1.32 newsyslog.conf --- newsyslog.conf 26 Aug 2014 19:33:48 - 1.32 +++

Re: HEADS-UP: faster mirrors synching coming your way soon

2014-09-23 Thread Christian Weisgerber
On 2014-09-23, Marc Espie wrote: > I got a newer snaps, so an actual test on real data. Snaps apart by about > 1 week. > > sent 7,502,610,665 bytes received 40,313,605 bytes 4,561,792.72 bytes/sec > total size is 28,788,092,671 speedup is 3.82 The first improved format amd64 package snapshot is

Re: Speeding up openbsd on amd64 MP - patch 2/2

2014-09-24 Thread Christian Weisgerber
On 2014-09-14, Stefan Fritsch wrote: > Optimize pmap on amd64 > > based on a patch for i386 by Art from 2008 that removes the APTE stuff. > Some additional bits were taken from a patch by Art for amd64 from 2005. I put this on the amd64 ports machines (2 x Xeon E5-2637 for a total of hw.ncpu=8

Re: improving OpenBSD's gmac.c...

2014-10-07 Thread Christian Weisgerber
John-Mark Gurney: > So, as I was working on FreeBSD's implementation of gmac.c, I noticed > that I was able to get a significant speed up by using a mask instead > of an if branch in ghash_gfmul in gmac.c from OpenBSD... > > Add a mask var and replace the code between the comments > "update Z" an

Re: improving OpenBSD's gmac.c...

2014-10-09 Thread Christian Weisgerber
John-Mark Gurney: > I also have an implementation of ghash that does a 4 bit lookup table > version with the table split between cache lines in p4 at: > https://p4db.freebsd.org/fileViewer.cgi?FSPC=//depot/projects/opencrypto/sys/opencrypto/gfmult.c&REV=4 > > This also has a version with does 4 b

Re: improving OpenBSD's gmac.c...

2014-10-12 Thread Christian Weisgerber
Here's a cleaned-up diff. Briefly tested on amd64 & sparc64. I'll do some more testing tomorrow. This already has mikeb@'s blessing. Index: regress/sys/crypto/gmac/Makefile === RCS file: /cvs/src/regress/sys/crypto/gmac/Makefile,v

Re: improving OpenBSD's gmac.c...

2014-10-13 Thread Christian Weisgerber
David Gwynne: > dont you need endian.h to get bemtoh64 and htobem64? I went by the man page, which says . PS: I accidentally omitted a chunk: Index: sys/conf/files === RCS file: /cvs/src/sys/conf/files,v retrieving revision 1.581

Re: tcpdump follows incorrect alignment requirement rules

2014-12-09 Thread Christian Weisgerber
On 2014-12-03, Mike Belopuhov wrote: > bpf aligns data following the datalink header (e.g. ethernet) > on the BPF_ALIGNMENT boundary. Since rev1.41 of bpf.h it's > uint32_t instead of a long. And also since then almost all > packets become "unaligned" from the tcpdump perspective and > require

Re: NTP

2014-12-20 Thread Christian Weisgerber
On 2014-12-20, Peter Hessler wrote: >:And it is probably vulnerable to this: >:https://github.com/PentesterES/Delorean >:(tl;dr Man-in-the-Middle) > > OpenNTPd embeds random cookies into several fields of the ntp packet, > the server is required to copy them back into the reply, and the client >

ntpd: switch drift file to ppm

2015-01-13 Thread Christian Weisgerber
Here's a patch to switch the drift file from an unscaled frequency offset to ppm. The latter format is compatible with that of ntp.org. This allows easy switching between ntpd daemons. (I asked PHK and ntimed will probably not have a drift file at all.) Old drift files are handled automagically.

Re: ntpd: switch drift file to ppm

2015-01-13 Thread Christian Weisgerber
Mark Kettenis: > Does this in any way force a write of the drift file or are you > relying on ntpd deciding that it has a better estimate of the > drift somewhere in the next year? ntpd always updates the drift file when it adjusts the frequency, and it always adjusts the frequency when it is syn

Re: ntpd: switch drift file to ppm

2015-01-13 Thread Christian Weisgerber
On 2015-01-13, Theo de Raadt wrote: >> > Hmm, I guess we could skip the compatibility handling completely >> > and just let ntpd re-discover the drift. >> >> Heh. Sounds plausible. > > Smaller diff. I started with 2.679024e-05 in ntpd.drift and pretty soon got this: adjusting clock frequency b

shutdown -p

2015-01-20 Thread Christian Weisgerber
As proposed on misc@, here's a diff to bring our shutdown(8) in line with FreeBSD's and use plain "-p" to specify "halt and power down". Mostly from FreeBSD. Index: shutdown.8 === RCS file: /cvs/src/sbin/shutdown/shutdown.8,v retrievi

Re: shutdown -p

2015-01-20 Thread Christian Weisgerber
Mark Kettenis: > I'm fine with makeing "shutdown -p" equivalent to "shutdown -hp", but > I don't see why we have to break the latter. Due to overwhelming demand, "shutdown -hp" is now still accepted in place of "shutdown -p". ok? Index: shutdown.8 ===

shutdown: unobfuscate exec

2015-01-20 Thread Christian Weisgerber
I think shutdown.c's love of the conditional operator is excessive. This is a more readable alternative, adapted from NetBSD: Index: shutdown.c === RCS file: /cvs/src/sbin/shutdown/shutdown.c,v retrieving revision 1.38 diff -u -p -r1.

Re: Aq macro

2015-02-15 Thread Christian Weisgerber
On 2015-02-15, "Ted Unangst" wrote: > mandoc already special cases Aq in Mt macros to output plain . > Existing usage suggests that's what people want elsewhere as well. pf > and headers are not math equations either. I think these manuals should use actual < > instead of the Aq macro. There

Re: ksh version lies

2015-02-18 Thread Christian Weisgerber
On 2015-02-17, "Ted Unangst" wrote: >> pdksh is not the same thing as ksh88 or ksh93. And not the same thing as >> mksh, which has grew features since it was based on pdksh from the >> OpenBSD tree. And you may want to avoid known problems in some of those, >> or use known nice features in others

Re: stop deleting /usr/include/openssl

2015-02-18 Thread Christian Weisgerber
On 2015-02-16, Jérémie Courrèges-Anglas wrote: >> -@ln -sf openssl ${DESTDIR}/usr/include/ssl > > Not ok for this part... I now have lrwxr-xr-x 1 root bin 7 Feb 17 15:32 /usr/include/openssl/openssl -> openssl on updated systems. /usr/include/openssl/blowfish.h:62:33: error: /usr/incl

Re: ksh diff, escape !

2015-03-08 Thread Christian Weisgerber
On 2015-03-08, Stuart Henderson wrote: > ! needs to be escaped in tab-completion otherwise this happens. > > $ ls > Season 4 UPDATE!-FFdJhCSr8ng.mp4 > $ ls Season\ 4\ UPDATE!-FFdJhCSr8ng.mp4 > ls: Season 4 UPDATE!4: No such file or directory Huh? $ ls Season 4 UPDATE!-FFdJhCSr8ng.mp4 $ ls Seaso

Re: ksh version lies

2015-03-12 Thread Christian Weisgerber
On 2015-03-12, Patrik Lundin wrote: >=== > elif [ -n "$KSH_VERSION" ]; then > HACKING_DIR=$(dirname "${.sh.file}") >=== .sh.file and related dot variables are a ksh93 extension. I don't think ksh88 supports this, so this is unportable even within the ksh family. ... Actually, ksh88 doesn't

Re: ksh version lies

2015-03-14 Thread Christian Weisgerber
On 2015-03-13, Patrik Lundin wrote: > If ksh88 neither has KSH_VERSION or the .sh variables, could the > presence of KSH_VERSION mean "this shell is at least ksh93 equivalent"? No. As far as I can tell, pdksh actually pre-dates ksh93. I don't know when KSH_VERSION was added--possibly at the tim

Re: ehci(4) Full-speed isochronous transfers support

2015-03-29 Thread Christian Weisgerber
Stuart Henderson: > The diff functions for me in letting audio play, but there are some > weird scratchy noises on one channel when music is playing, I'll have > to dig out another machine to try the ua-1ex on on and see if it > happens there too I'm seeing, uh, hearing some problems if there are

Re: ehci(4) Full-speed isochronous transfers support

2015-03-29 Thread Christian Weisgerber
Martin Pieuchot: > Please let me know how it goes with 1.1 and 2.0 devices. Playing audio works in principle with the three USB->S/PDIF audio dongles I have here. When I tried two audio dongles simultaneously on the same USB bus, it worked for 44.1 kHz, but audio was distored if one or both ran

Fix /etc/mail/aliases.db permissions

2015-05-25 Thread Christian Weisgerber
As Mark Patruck has noticed, etc/mail/aliases.db in etc.tgz ends up with the owner:group of the aliases file in the source tree. The problem is that we call makemap with the source tree file instead of the DESTDIR one, and makemap gives the .db file the owner:group of the input file. This error w

Re: unneeded var breaks build in xenocara/driver/xf86-video-mach64

2015-05-27 Thread Christian Weisgerber
On 2015-05-27, dan mclaughlin wrote: > someone will hit this soon enough if they haven't already, but building > xerocara after recent import gave the following error: What's "recent"? "Update to xf86-video-mach64 6.9.5" was four days ago and I've built xenocara since then without any problems.

Re: unneeded var breaks build in xenocara/driver/xf86-video-mach64

2015-05-27 Thread Christian Weisgerber
Matthias Kilian: > I've > > #define TV_OUT 1 > > in /usr/xobj/driver/xf86-video-mach64/config.h, and my build log shows > > checking whether to include TV Out support... yes > > for xf86-video-mach64. It turns out TV_OUT is defined on i386, but not on amd64. -- Christian "naddy"

Re: FreeType 2.7.1

2017-01-12 Thread Christian Weisgerber
Stuart Henderson: > > And, if you can, put it in your next bulk build. > > i386 bulk was clean. amd64 also looks fine. (iridium and chromium are still building on their n-th try...) -- Christian "naddy" Weisgerber na...@mips.inka.de

Re: FreeType 2.7.1

2017-01-13 Thread Christian Weisgerber
Matthieu Herrb: > In my analysis of the changed symbols, only a minor bump was required, > but now that people have started installing libfreetype.so.28.0, > commit it like that. FWIW, I run such testing bulk builds without plist registration, don't upload the resulting packages, and wipe the aff

Re: Sync sys/videoio.h with recent Linux kernel

2017-01-29 Thread Christian Weisgerber
On 2017-01-29, Martin Pieuchot wrote: >> which allows us to fully comply with the V4L2 API. The attached diff >> implements this and syncs with videodev2.h from the Linux kernel version >> 4.10-rc5 at the same time > > This needs to go in a bulk since most users of this API are ports. I have sta

Re: Sync sys/videoio.h with recent Linux kernel

2017-01-30 Thread Christian Weisgerber
On 2017-01-29, Christian Weisgerber wrote: >>> which allows us to fully comply with the V4L2 API. The attached diff >>> implements this and syncs with videodev2.h from the Linux kernel version >>> 4.10-rc5 at the same time >> >> This needs to go in a bulk

Re: NFS: Kill so_upcall NET_LOCK() recursion

2017-02-11 Thread Christian Weisgerber
On 2017-02-06, Martin Pieuchot wrote: > guenther@ pointed out during a2k17 that nfsrv_rcv() already has a way to > not re-enter the socket layer. Instead of doing soreceive() directly in > the receiving path, we notify and wakeup nfsd(8) to do it. > > I'd like to do that unconditionally to fix o

Re: make bugfix (?) / improvement

2017-02-24 Thread Christian Weisgerber
Marc Espie: > The substitution used is called SYSV substitution, it takes the form > ${VAR:before=after} and substitute before into after on each word of > the variable. > > Back when I added recursive variable support into make, I only did this on > the rhs of that construct. Apparently, other m

xenocara: honor CC, CXX, CXXFLAGS

2017-03-07 Thread Christian Weisgerber
I noticed that the xenocara build uses "gcc" and "g++" everywhere if those exist at build time. It's the result of an omission: CC, CXX, and CXXFLAGS simply aren't passed into the build and the GNU configure defaults are used. Straightforward fix. OK? PS: Does anybody remember why we need to de

Re: Question regarding (portable) OpenNTPD adjfreq

2017-03-08 Thread Christian Weisgerber
Patrik Lundin: > By looking around in the code I notice that adjfreq is only performed if > openntpd considers itself synced. This makes me wonder: what happens if > the frequency is so off target that the skew introduced by adjtime() is > unable to overcome it? Then ntpd cannot maintain the time

sync root.mail

2017-03-29 Thread Christian Weisgerber
Sync the version of the example package. ok? Index: root.mail === RCS file: /cvs/src/etc/root/root.mail,v retrieving revision 1.121 diff -u -p -r1.121 root.mail --- root.mail 5 Mar 2017 15:08:03 - 1.121 +++ root.mail 29

Re: sync root.mail

2017-03-29 Thread Christian Weisgerber
Antoine Jacoutot: > Why not just: > > # pkg_add -v rsync chromium emacs--no_x11 > > So we don't have to change it each release? Because people won't let Emacs 21 die. Ambiguous: choose package for emacs--no_x11 a 0: 1: emacs-21.4p37-no_x11 2: emacs-25.1p3-no_x11 Your cho

Re: ./usr/include/g++/std removed from distrib/sets/lists/

2017-04-18 Thread Christian Weisgerber
On 2017-04-18, Sebastien Marie wrote: > I saw that with the split of comp lists to gcc/clang parts, > ./usr/include/g++/std entry was removed from comp/mi, and not added > back in comp/gcc.*. That was on purpose. It was also removed from etc/mtree/4.4BSD.dist. -- Christian "naddy" Weisgerber

bin/ed: fix clang warnings

2017-04-26 Thread Christian Weisgerber
This fixes the clang warnings in bin/ed. One extra pair of parentheses and stop passing empty format strings to printf-family functions. ok? Index: glbl.c === RCS file: /cvs/src/bin/ed/glbl.c,v retrieving revision 1.18 diff -u -p -r

Re: bin/ed: fix clang warnings

2017-04-26 Thread Christian Weisgerber
Todd C. Miller: > > case FATAL: > > - if (!interactive) > > - fprintf(stderr, garrulous ? > > - "script, line %d: %s\n" : "", > > - lineno, errmsg); > > - else > >

Re: My ELFSEC implementation (signed binaries for amd64)

2017-05-05 Thread Christian Weisgerber
On 2017-05-05, "Peter J. Philipp" wrote: > This is my second official contribution to what I call ELFSEC, it places a > signature in binaries, in the ELF header to be exact. -snip- How does this defend against binary code introduced as a shared library by way of LD_LIBRARY_PATH or LD_PRELOAD?

Re: Unlock minherit(2)

2022-12-02 Thread Christian Weisgerber
Klemens Nanni: > This has been running fine through regress and daily usage on my X230 driver > for months, incl. selected ports builds. > > Feedback? Objection? Tests? OK? The only user of minherit() in base appears to be libc's arc4random. I successfully ran a full amd64 package bulk build wi

Re: sparc64: don't install %TICK timecounter on UltraSPARC IIe

2022-12-10 Thread Christian Weisgerber
Scott Cheloha: > The UltraSPARC IIe's %TICK register has a variable frequency. > miod@ confirmed that the problem is real. Indeed, I remember clocking down the Blade 100 with apm(8). Somebody with access to the hardware might want to adapt the NetBSD code that adds timecounter support for the ST

Re: refactor mbuf parsing on driver level

2023-01-26 Thread Christian Weisgerber
Jan Klemkow: > we have several drivers which have to parse the content of mbufs. This > diff suggest a central parsing function for this. Thus, we can reduce > redundant code. > > I just start with ix(4) and ixl(4) because it was easy to test for me. > But, this could also improve em(4), igc(4)

Re: refactor mbuf parsing on driver level

2023-01-27 Thread Christian Weisgerber
Vitaliy Makkoveev: > The ether_extract_headers() diff was reverted, because is wrong for the > cases other than tcp/udp/icmp. We need to fix it and recommit again > before continue. I think (TCP or) UDP fragments are the problem. Fragments don't have the protocol header but will still end up her

Re: Double underlining and strikeout console patch

2023-01-30 Thread Christian Weisgerber
Crystal Kolipe: > Here is the latest version of the double underline and strikeout parts of my > console patchset. I'm sorry, but I gotta ask: Who or what uses something like this?? Offhand, I don't even know if xterm can do it. If you want this kind of typographic detail, shouldn't you be usin

Re: refactor mbuf parsing on driver level

2023-01-31 Thread Christian Weisgerber
Jan Klemkow: > - I turned the KASSERTS to returns. > - Check if the mbuf is large enough for an ether header. > - additionally #ifdef'd INET6 around the ip6_hdr in the new struct For non-initial fragments of TCP/UDP packets, ether_extract_headers() will create ext.tcp/ext.udp pointers that do

Re: refactor mbuf parsing on driver level

2023-02-05 Thread Christian Weisgerber
Jan Klemkow: > > > - I turned the KASSERTS to returns. > > > - Check if the mbuf is large enough for an ether header. > > > - additionally #ifdef'd INET6 around the ip6_hdr in the new struct > > > > For non-initial fragments of TCP/UDP packets, ether_extract_headers() > > will create ext.tcp/e

Re: refactor mbuf parsing on driver level

2023-02-06 Thread Christian Weisgerber
Christian Weisgerber: > I also switched over em(4) to this and have successfully used it > for a full 30-hour package build on the four amd64 ports machines > with their I350 interfaces. Additionally, I've done some IPv6 > testing at home over an I210. ok for this? igc(4) has

Re: refactor mbuf parsing on driver level

2023-02-06 Thread Christian Weisgerber
Jan Klemkow: > > igc(4) has very similar code, but I don't have access to a machine > > with that hardware. > > Send me an ssh-key and I give you access to this machine: Alternatively, here's the diff, so other people can test it. diff a0c537a1c9d84e98322b55d8f71438a147aaa7c4 7d976644b87094d08

installer: remove obsolete libLLVM.so.[0-6].0

2023-03-08 Thread Christian Weisgerber
The installer deletes obsolete libLLVM.so versions during an upgrade. However, a number of libLLVM.so versions have come and gone and the installer hasn't been synced. We're now at .7.0, so delete all the earlier ones. ok? --- remove obsolete libLLVM.s

Re: [installer] default answer to "Is the disk partition already mounted?"

2023-04-06 Thread Christian Weisgerber
On 2023-04-05, Klemens Nanni wrote: >> In conversation with Klemens (kn@) new iteration has been born, it >> follows to what Omar (op@) has suggested - we're not trying to change >> the default answer for all cases, since no one complained for all these >> years, but just flip default for install

llvm15: Make -mbranch-protection=bti the default

2023-04-18 Thread Christian Weisgerber
penBSD. LLVM 15 reshuffled some code, so the change above no longer applies there. Here's my attempt to add it: --- commit d80c4bf3bc72f631512bdaa922cc31d46a07257b (llvm15) from: Christian Weisgerber date: Mon Apr 17 22:33:20 2023 UTC llvm:

Re: plt section in kernel due to endbr64

2023-04-21 Thread Christian Weisgerber
Alexander Bluhm: > After enabling -fcf-protection=branch for the kernel, we have a new > .plt section in the kernel. It was not there before. Same issue in userland: At least /usr/lib/crt0.o and /usr/lib/crtbegin.o have grown .plt and .note.gnu.property sections and some tools (ld.bfd?) don't li

llvm15: Implement support for PT_OPENBSD_NOBTCFI in lld(1)

2023-04-21 Thread Christian Weisgerber
commit 072b0a41d978c446342c34a7a901579f460f80d2 (llvm15) from: Christian Weisgerber date: Fri Apr 21 21:25:24 2023 UTC Implement support for PT_OPENBSD_NOBTCFI in lld(1). This can be set using the -z nobtcfi option. ok deraadt@ diff 0

Re: seperate LRO/TSO flags

2023-05-13 Thread Christian Weisgerber
Jan Klemkow: > This diff introduces separate flags for TCP offloading. We split this > into LRO (large receive offloading) and TSO (TCP segmentation > offloading). Thus, we are able to turn it on/off separately. Wait, why do we even have a knob for TSO? We specifically decided not to have a kn

Installer: use $(

2023-05-23 Thread Christian Weisgerber
This replaces "$(cat file)" with the ksh construct "$(/dev/null) unchanged, since it would require { local var=$(<$HTTP_SEC); } 2>/dev/null which is sufficiently opaque that I'm not sure it's an improvement. --- distrib/miniroot/install.sub +++ distrib/miniroot/install.sub @@ -77,7 +77

arc4random for src/games

2013-08-28 Thread Christian Weisgerber
This replaces srandomdev()+random() with calls to arc4random*() in src/games. There isn't much practical benefit to this. Consider it a style fix. I have NOT touched the games that call srandom() with a particular seed for deterministic gameplay. Index: arithmetic/arithmetic.c =

games/trek: fix for tournament mode

2013-08-28 Thread Christian Weisgerber
trek(6)'s tournament mode is intended to have deterministic "random" numbers based on a password. This was broken 15 years ago when rand() was changed to random(), but the initial srand() was forgotten. ok? Index: setup.c === RCS fi

Re: arc4random for src/games

2013-08-29 Thread Christian Weisgerber
Todd C. Miller: > Looks good but I think this idiom used in hangman: > > pos = (double) random() / (RAND_MAX + 1.0) * (double) Dict_size; > > Can be replaced with: > > pos = arc4random_uniform(Dict_size); > > so long as Dict_size <= UINT32_MAX, which should always be the case. Hmm. D

Re: em(4): enable checksum offload

2013-09-19 Thread Christian Weisgerber
Brad Smith wrote: > > > Since I have been asked to send out these diffs again here is a diff > to enable > > > the checksum offload support for em(4). > > > > > > Looking for any testing. > > > > tx checksum offloading will not work on 75, 76, 80, i350. > > Oh yes, you're right. The same exclu

Re: linebuffering diff for tr(1)

2013-11-20 Thread Christian Weisgerber
Jan Klemkow wrote: > here is a diff that adds optional linebuffering to tr(1) with command > line switch -u like in sed(1). I need this to remove '\r' characters > from a continues input steam which lines have to be there immediately. It's really odd to make tr output line-buffered, since tr do

lynx: drop -lcompat

2013-12-02 Thread Christian Weisgerber
The configure script unconditionally adds -lcompat. This isn't needed; configure checks for the presence of cuserid() and ftime() and the build copes well with the absence of either. ftime() would only ever be used if gettimeofday() wasn't available, and cuserid() is replaced by getlogin() but th

xenocara fallout from libcompat removal

2013-12-03 Thread Christian Weisgerber
The xenocara fallout from libcompat removal is actually minimal. I don't know if there are any extant operating systems that still require for getrusage(). Index: app/xgc/tests.c === RCS file: /cvs/xenocara/app/xgc/tests.c,v retriev

select.2: update includes

2013-12-03 Thread Christian Weisgerber
POSIX says select() and everything it needs should come from . Eight years ago our headers have been fixed to provide this. Time to acknowledge this in the man page, too. ok? Index: select.2 === RCS file: /cvs/src/lib/libc/sys/sele

Re: select.2: update includes

2013-12-03 Thread Christian Weisgerber
Philip Guenther: > needs to stay until FD_ZERO() and FD_COPY() are changed to > not use memset()/memcpy(). We could grab this from FreeBSD: #if __BSD_VISIBLE #define FD_COPY(f, t) (void)(*(t) = *(f)) #endif #define FD_ZERO(p) do { \ fd_set *_p;

Re: select.2: update includes

2013-12-03 Thread Christian Weisgerber
Combining the various suggestions, I now have this: Index: sys/sys/select.h === RCS file: /cvs/src/sys/sys/select.h,v retrieving revision 1.13 diff -u -p -r1.13 select.h --- sys/sys/select.h29 Oct 2013 02:44:52 - 1.13 +++

Re: select.2: update includes

2013-12-03 Thread Christian Weisgerber
Matthew Dempsky: > I think you're missing a "{" after the do. :) Hmm, yes. This survives a make build: Index: sys/sys/select.h === RCS file: /cvs/src/sys/sys/select.h,v retrieving revision 1.13 diff -u -p -r1.13 select.h --- sys/sy

Remove 4.3BSD tty compatibility

2013-12-08 Thread Christian Weisgerber
I would like to use the current momentum of the removal and kill the remaining parts of the COMPAT_43 tty handling in the kernel, too. (There are some further network-related COMPAT_43 fragments that are not touched by this.) The diff below has only been tested as far as building and running a k

Re: Remove 4.3BSD tty compatibility

2013-12-08 Thread Christian Weisgerber
Christian Weisgerber wrote: > The diff below has only been tested as far as building and running > a kernel. I'm throwing this out so people with a better understanding > of the kernel can tell me if I'm missing something. Please ignore this for the time being. There is mo

lpd: remove printcap fc, fs, xc, xs capabilities

2013-12-09 Thread Christian Weisgerber
Bad news: That serial printer you hooked up 30 years ago, with magic numbers in a printcap file you haven't changed since, well, that configuration might stop working. This diff removes the printcap fc, fs, xc, xs capabilities from lpd. They allowed configuring a tty with magic numbers that were

getty: remove gettytab f0, f1, f2 capabilities

2013-12-10 Thread Christian Weisgerber
Bad news: That terminal you hooked up 30 years ago--okay, okay. Same thing as yesterday's lpd diff: Remove from getty the f0, f1, f2 gettytab capabilities that were used to poke magic numbers into sgtty. The "modern" replacement for f# is the set i#, o#, c#, l# to poke magic numbers into termios.

Remove 4.3BSD tty compatibility, take 2

2013-12-10 Thread Christian Weisgerber
New attempt, now that the userland has been cleaned up. This diff kills the remaining parts of the COMPAT_43 tty handling in the kernel. (There are some further network-related COMPAT_43 fragments that are not touched by this.) Comments? ok? R compat/common/tty_43.c M conf/files M ddb/db_struc

Re: Remove 4.3BSD tty compatibility, take 2

2013-12-10 Thread Christian Weisgerber
Mark Kettenis: > Noticed TIOCGSID in that list. Don't think that is a 4.3 compat > ioctl. Rather a System V compat ioctl. Well, it's implemented in compat/common/tty_43.c. If we want to save it, we need to move it to kern/tty.c:ttioctl(). Do we? -- Christian "naddy" Weisgerber

Re: Remove 4.3BSD tty compatibility, take 2

2013-12-12 Thread Christian Weisgerber
Christian Weisgerber wrote: > New attempt, now that the userland has been cleaned up. This diff > kills the remaining parts of the COMPAT_43 tty handling in the > kernel. (There are some further network-related COMPAT_43 fragments > that are not touched by this.) > > Co

Garbage-collect struct ttysize

2013-12-12 Thread Christian Weisgerber
Earlier today I found myself patching struct winsize to ttysize in a port, because I had been confused by into thinking OpenBSD had the latter instead of the former. Ugh. I think we can drop compatibility to SunOS < 3.2 (Sep 1986). FreeBSD also got rid of this 4.5 years ago. I've verified that

Re: signify untrusted comments

2014-01-07 Thread Christian Weisgerber
Ted Unangst wrote: > To that end, I think the comment should be marked as untrusted, and > signify should even check that it says untrusted. Hopefully this makes > it a little harder to con somebody into believing the comment actually > should be trusted. I think somebody who can be conned into

Re: fw_update experiments

2014-01-10 Thread Christian Weisgerber
Marc Espie wrote: > if you're trying to use pkg_add directly to grab/update firmwares, make > sure to use -DFW_UPDATE on those. Also for pkg_delete: # pkg_delete acx-firmware-1.4p4 Package signed by untrusted party 54fw Fatal error: package acx-firmware-1.4p4 was corrupted: signature check fail

IPv6 pseudo-header checksum

2014-01-21 Thread Christian Weisgerber
This diff splits the TCP/UDP/ICMPv6 checksumming for IPv6 into separate calculations of the pseudo-header checksum and the rest, just like we do for IPv4. This should allow us to enable TX checksum offload for IPv6 on some chipsets. I'm uncertain how much consistency checking we want. Also, this

<    1   2   3   4   5   6   >