Re: games/fortune translation fix

2019-02-03 Thread Ingo Schwarze
Hi Pascal, Pascal Stumpf wrote on Sun, Feb 03, 2019 at 11:13:12AM +0100: > That is not correct because [...] Which illustrates yet again that getting good grades at school doesn't imply real understanding; i dared to try and research the matter anyway because i forgot that with pascal@, we have

Re: games/fortune translation fix

2019-02-06 Thread Ingo Schwarze
Hi Scott, Scott Cheloha wrote on Tue, Feb 05, 2019 at 12:02:39AM -0600: > Oof, folks I think we've missed the forest for the trees here. > > By focussing on the minutiae of the Latin translation we've discarded > the English motto ("through to the stars") that imho > anchored the whole thing. >

Re: install(1) could fail due to race

2019-02-06 Thread Ingo Schwarze
Hi Ted, Ted Unangst wrote on Sun, Jan 27, 2019 at 10:37:52AM -0500: > Ingo Schwarze wrote: >> If people here agree with the general direction of making -S the >> default and removing the fragile non-S mode (see the patch below), >> i'll run a full make build and make re

Re: install(1) could fail due to race

2019-02-08 Thread Ingo Schwarze
Ted Unangst wrote on Sun, Jan 27, 2019 at 10:37:52AM -0500: > Ingo Schwarze wrote: >> If people here agree with the general direction of making -S the >> default and removing the fragile non-S mode (see the patch below), >> i'll run a full make build and make release and

Re: update ctype data to unicode 10

2019-02-22 Thread Ingo Schwarze
Hi Andrew, Andrew Fresh wrote on Thu, Feb 21, 2019 at 08:22:16PM -0700: > On Fri, Feb 22, 2019 at 01:57:01AM +0200, Lauri Tirkkonen wrote: >> Hi, the recent perl-5.28.1 and related unicore update brought the >> unicode data from version 8.0.0 to version 10.0.0. That fixes some >> character classi

Re: update ctype data to unicode 10

2019-02-22 Thread Ingo Schwarze
Hi Andrew, Lauri Tirkkonen wrote on Fri, Feb 22, 2019 at 01:57:01AM +0200: > Hi, the recent perl-5.28.1 and related unicore update brought the > unicode data from version 8.0.0 to version 10.0.0. That fixes some > character classifications (eg. emoji characters gained East_Asian_Width > value 'Wi

start cleaning up UTF-8 processing in less(1)

2019-02-23 Thread Ingo Schwarze
Hi, Evan Silberman, by posting a well-founded bug report to bugs@, just drew my attention to the pigsty of having a hand-rolled re-implemention of Unicode character property handling within less(1). The root of the evil is the existence of the custom definition typedef unsigned long LWCHAR; i

Re: archaic quotes in calendar

2019-02-23 Thread Ingo Schwarze
Hi, Anthony J. Bentley wrote on Wed, Jan 30, 2019 at 04:01:30AM -0700: > Jason McIntyre writes: >> in the man page you have used Sq. that will make it mark up the same as >> it already does: >> >> (`*') > There's a difference: Ted uses a UTF-8 locale where Sq shows up as > pretty Unicode qu

Re: start cleaning up UTF-8 processing in less(1)

2019-02-24 Thread Ingo Schwarze
Hi, Stefan Sperling wrote on Sat, Feb 23, 2019 at 04:19:02PM +0100: > Your diff looks good to me. > And I can't see how it could make this situation any worse either. thanks for checking; i committed the first patch. To be able to continue with the less cleanup i started, i have to explain som

Re: start cleaning up UTF-8 processing in less(1)

2019-02-25 Thread Ingo Schwarze
Hi, Nicholas Marriott wrote on Mon, Feb 25, 2019 at 10:14:03AM +: > Ingo Schwarze wrote: >> During the upcoming cleanup steps, let use retain full support for >> the first (ESC-[) syntax and lets us completely delete support for >> the second and third CSI syntaxes (sing

Re: start cleaning up UTF-8 processing in less(1)

2019-02-25 Thread Ingo Schwarze
Hi Todd, Todd C. Miller wrote on Mon, Feb 25, 2019 at 09:45:12AM -0700: > One question inline. > On Mon, 25 Feb 2019 12:39:41 +0100, Ingo Schwarze wrote: >> Index: line.c [...] >> @@ -469,11 +469,10 @@ in_ansi_esc_seq(void) >> * Search backwards for either an ES

Re: start cleaning up UTF-8 processing in less(1)

2019-02-25 Thread Ingo Schwarze
Hi Todd, Todd C. Miller wrote on Mon, Feb 25, 2019 at 01:06:02PM -0700: > On Mon, 25 Feb 2019 19:43:36 +0100, Ingo Schwarze wrote: >> Todd C. Miller wrote on Mon, Feb 25, 2019 at 09:45:12AM -0700: >>> On Mon, 25 Feb 2019 12:39:41 +0100, Ingo Schwarze wrote:

less(1) UTF-8 cleanup: store_char()

2019-02-26 Thread Ingo Schwarze
Hi, Nicholas Marriott wrote on Tue, Feb 26, 2019 at 07:20:47AM +: > Looks good, ok nicm Thanks to all of you for checking. Here is the next step, slowly coming closer to the meat of the matter: Start cleaning up the function store_char(), which takes a wide character, receiving both the Uni

less(1) UTF-8 cleanup: backc()

2019-03-02 Thread Ingo Schwarze
Hi, the first step in cleaning up do_append() is the subroutine backc(), which is only called from a single place, namely in do_append(). Its purpose is to back up over the previous positive-width character during the application of backspace-encoding for "bold" or "underlined". The task here is

Re: nm(1): return on malloc error

2019-03-03 Thread Ingo Schwarze
Hi, Benjamin Baier wrote on Sat, Mar 02, 2019 at 10:10:40AM +0100: > On malloc error symtab is unmapped, so proceeding on will lead > to a NULL pointer dereference. > When malloc fails we should return like the MMAP case does. while i'm certainly not experienced with nm(1), this change looks cor

Re: nm(1): return on malloc error

2019-03-03 Thread Ingo Schwarze
Hi, Benjamin Baier wrote on Sat, Mar 02, 2019 at 10:10:40AM +0100: > On malloc error symtab is unmapped, so proceeding on will lead > to a NULL pointer dereference. > When malloc fails we should return like the MMAP case does. Committed. Thanks for the patch (and to those who checked it). Ing

Re: mandoc -Tlint systat.1 fix

2019-03-04 Thread Ingo Schwarze
Hi David, David Gwynne wrote on Mon, Mar 04, 2019 at 08:59:12PM +1000: > lint thinks uvm_swap_get() looks like a function name, > so this uses .Fn to mark it up as one. > > ok? Sure. Given that the function uvm_swap_get() appears to be important enough to be mentioned even in a userland manual

Re: xman.man: typo in mandesc section

2019-03-08 Thread Ingo Schwarze
Hi Alejandro, we normally avoid trivial changes to X11 documentation. Such changes provide little benefit but make life harder for matthieu@. If the typo still exists upstream, please report it upstream, and it will automatically appear in OpenBSD with the next regular update. Yours, Ingo A

Re: xterm and wcwidth()

2019-03-08 Thread Ingo Schwarze
Hi, Lauri Tirkkonen wrote on Fri, Mar 08, 2019 at 12:43:11PM +0200: > I feel like xterm should just use the system wcwidth() to avoid these > mismatches, so rudimentary diff to do that below. Absolutely, i strongly agree with that sentiment. Having a local character width table in an applicatio

Re: xterm and wcwidth()

2019-03-08 Thread Ingo Schwarze
Hi, Ted Unangst wrote on Fri, Mar 08, 2019 at 12:57:17PM -0500: > Lauri Tirkkonen wrote: >> in other words, xterm is (and was) using its own idea of how many >> columns characters take up. The way this manifested itself to me was >> that I received some email that contained emoji characters in th

Re: xterm and wcwidth()

2019-03-08 Thread Ingo Schwarze
Hi, Ted Unangst wrote on Fri, Mar 08, 2019 at 03:24:56PM -0500: > Matthieu Herrb wrote: >> I would prefer a diff that just add a &&!defined(__OpenBSD__) to the >> condition before the definition of systemWcwidthOk(). This will cause >> less risk of conflicts in future updates and clearly show the

delete useless setlocale(3) in spell(1)

2019-03-09 Thread Ingo Schwarze
Hi, looking through my trees for diffs that were forgotten, i found this one. Spell uses nothing locale-dependent, and it will never need support for non-English characters because the basic algorithms used are specific to the English language in the first place. So delete and setlocale(3) with

delete useless setlocale(3) in uuencode(1)

2019-03-09 Thread Ingo Schwarze
Hi, uuencode(1) and uudecode(1) do nothing locale-related and i don't see how they ever might. So delete and setlocale(3). While here, sort headers, make usage() static, return from main rather than exit(3), and drop two redundant case statements. This is also a minimally tweaked version of a

delete useless setlocale(3) from touch(1)

2019-03-09 Thread Ingo Schwarze
Hi, i initially thought touch(1) might be tricky because it is concerned with times, but it turned out is does almost all of the parsing by hand, supporting only specific numeric formats and nothing like month names. It does use strptime(3), but only for %F and %T neither of which is locale-depen

Re: mount(8): remove unnecessary white space in man page

2019-03-10 Thread Ingo Schwarze
Hi Alessandro, Alessandro Gallo wrote on Sun, Mar 10, 2019 at 02:12:21PM +0100: > There seems to be an unneeded extra space in the mount(8) man page. > The following diff fixes that: Committed, thanks. Ingo > Index: mount.8 > ==

Re: Adding fstab(5) fs_mntops to mount_nfs(8)

2019-03-11 Thread Ingo Schwarze
Hi Kurt, Kurt Mosiejczuk wrote on Mon, Mar 11, 2019 at 09:32:41AM -0400: > As far as I can tell, no man page documents the fs_mntops form of the > mount_nfs(8) options for fstab(5). Most of us who use them either know > from some other documentation, reading the source, or just doing a > copy-pas

less(1) UTF-8 cleanup: do_append()

2019-03-12 Thread Ingo Schwarze
Hi Nicholas, Nicholas Marriott wrote on Tue, Mar 12, 2019 at 11:05:07AM +: > Sorry, ok nicm if you haven't committed this already. No i hadn't, but now i have, thank you very much for checking the patch. Here is the next step, cleaning up most parts of the crucial function do_append() which

less(1) UTF-8 cleanup: pappend()

2019-03-13 Thread Ingo Schwarze
Hi Todd, Todd C. Miller wrote on Tue, Mar 12, 2019 at 09:14:43AM -0600: > This looks like an improvement to me. OK millert@ Thanks for checking the do_append() patch, i committed it. The next step is to clean up pappend(), which reads one byte of a multibyte character per call and outputs the

Re: 63 bit certificate ID is libressl affected?

2019-03-13 Thread Ingo Schwarze
Hi Tom, Tom Smyth wrote on Wed, Mar 13, 2019 at 08:32:20PM +: > Just saw the following article and i was wondering if libressl > Might be affected by the bug also > Top bit being set to 0 always making an effective 63 bits rather than 64 > bits If i understand the article you quote correctly

less(1) UTF-8 bugfix and cleanup: search.c

2019-03-14 Thread Ingo Schwarze
Hi, the following is a very simple patch to completely clean up the file less/search.c with respect to UTF-8 handling. It also fixes an outright bug: Searching for uppercase UTF-8 characters currently doesn't work because passing a Unicode codepoint (in this case, the "ch" retrieved with step_cha

Re: less(1) UTF-8 bugfix and cleanup: search.c

2019-03-14 Thread Ingo Schwarze
Hi Stefan, Stefan Sperling wrote on Thu, Mar 14, 2019 at 04:11:00PM +0100: > Yes, OK. Thanks for checking. Here is the next step outside line.c, completely cleaning up the file less/filename.c with respect to UTF-8 handling. The loop needed is very similar to the one in search.c except that th

Re: EC_POINT_new.3 glitch

2019-03-18 Thread Ingo Schwarze
Hi Jan, Jan Stary wrote on Mon, Mar 18, 2019 at 08:38:04AM +0100: > This seems to be a missed newline. Committed, thanks. Ingo > Index: EC_POINT_new.3 > === > RCS file: /cvs/src/lib/libcrypto/man/EC_POINT_new.3,v > retrieving re

Re: Unescaped backslashes in manual pages

2019-03-19 Thread Ingo Schwarze
Hi Peter, Peter Piwowarski wrote on Tue, Mar 19, 2019 at 10:03:20PM -0400: > qsort(3) has in its EXAMPLE a C \n with its backslash unescaped; a quick > grep through manpages showed similar errors in CONF_modules_load_file.3. Ouch! Thanks for the report, committed. Ingo > Index: lib/libc/std

Re: rsync: add --del, remove --no-delete

2019-03-30 Thread Ingo Schwarze
Hi, Christian Weisgerber wrote on Sat, Mar 30, 2019 at 10:34:59AM -: > On 2019-03-30, Jason McIntyre wrote: >> we could use: [--del[ete]] >> that looks ugly, but is short and clear. kind of vi(1) style. >> >> we could just note in the description of --delete that it can be >> abbreviated to

Re: rsync: add --del, remove --no-delete

2019-03-30 Thread Ingo Schwarze
Hi, Ingo Schwarze wrote on Sat, Mar 30, 2019 at 02:14:43PM +0100: > Christian Weisgerber wrote on Sat, Mar 30, 2019 at 10:34:59AM -: >> I think that if openrsync ever grows anywhere near the number of options >> that the GPL rsync has, listing them all in usage/synopsis will b

improve rsync(1) manual page

2019-03-31 Thread Ingo Schwarze
Hi, here are serveral bugfixes and improvements for the rsync(1) manual. OK? Ingo Bugfixes: * For -D and -l: s/Transfer/Also transfer/. * In the EXAMPLES, the renaming rsync -> openrsync caused a mess; the worst aspect is the --rsync-path in the last example. I don't have a good solut

Re: Removing PF

2019-04-01 Thread Ingo Schwarze
Hi Claudio, Claudio Jeker wrote on Mon, Apr 01, 2019 at 07:01:03AM +0200: > There have been internal discussions about OpenBSD also removing the pf > packet filter after the upcoming 6.5 release. Instead a switch to > using David Gwynne's new bpf filter will happen. > The benefits outweigh the dr

Re: improve rsync(1) manual page

2019-04-01 Thread Ingo Schwarze
Hi Christian, Christian Weisgerber wrote on Mon, Apr 01, 2019 at 09:13:27AM +0200: > Ingo Schwarze: >> here are serveral bugfixes and improvements for the rsync(1) manual. > ok Thanks for checking, committed with the following tweaks: > I have some comments, but I think yo

Re: update to PF pfctl(8) and pf.conf(5) manpages

2019-04-16 Thread Ingo Schwarze
Hi Alexandr, Alexandr Nedvedicky wrote on Wed, Apr 17, 2019 at 12:09:10AM +0200: > my oracle fellow pointed out [1] a PF documentation can be improved > a bit, when it comes to newly introduced 'pfctl -FR' (a reset flush > modifier). I've decided to make manpage changes in separate diff as > I e

Re: new man page: rcsfile.5

2019-04-23 Thread Ingo Schwarze
Hi Fabio, Fabio Scotoni wrote on Tue, Apr 23, 2019 at 01:45:22PM +0200: > While familiarizing myself with OpenRCS, > I noticed that there's no rcsfile(5). > This may be handy for people whose RCS file got corrupted for whatever > reasons. > Other *NIXes that ship SCCS tend to have a sccsfile(4),

Re: new man page: rcsfile.5

2019-04-23 Thread Ingo Schwarze
Hi Fabio, i applied a very small number of minor tweaks and plan to commit the patch below tomorrow based on OK jmc@ deraadt@ millert@, unless i hear objections. Fabio Scotoni wrote on Tue, Apr 23, 2019 at 05:19:48PM +0200: > I've adjusted the updated man page (inline) .Dt and .Nm to match this

Re: new man page: rcsfile.5

2019-04-23 Thread Ingo Schwarze
Hi Fabio, Fabio Scotoni wrote on Tue, Apr 23, 2019 at 07:46:31PM +0200: > On 4/23/19 7:15 PM, Ingo Schwarze wrote: >> Is it correct that you wrote all the text in the file? >> If so, your name needs to be there. > It is indeed correct that I wrote all the text in th

Re: new man page: rcsfile.5

2019-04-24 Thread Ingo Schwarze
Hi Fabio, Fabio Scotoni wrote on Wed, Apr 24, 2019 at 06:14:07AM +0200: > On 4/23/19 9:30 PM, Ingo Schwarze wrote: >> Fabio Scotoni wrote: >>> Ingo Schwarze wrote: >>>> +.\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. >>>> +.\&qu

Re: update to PF pfctl(8) and pf.conf(5) manpages

2019-04-30 Thread Ingo Schwarze
Hi, Jason McIntyre wrote on Mon, Apr 29, 2019 at 09:53:03PM +0100: > ah, so singular is correct. but it needs an article of some sort. how > about: > > .Xr pfctl 8 > .Fl F Cm Reset > restores this value to its default. > > to be honest, i don;t like it when we Xr like this, or

Re: update to PF pfctl(8) and pf.conf(5) manpages

2019-04-30 Thread Ingo Schwarze
Hi Alexandr, here are a few additional minor remarks... Alexandr Nedvedicky wrote on Mon, Apr 29, 2019 at 08:59:55PM +0200: > diff --git a/sbin/pfctl/pfctl.8 b/sbin/pfctl/pfctl.8 > index b7e941991ba..5e2c57f6bc2 100644 > --- a/sbin/pfctl/pfctl.8 > +++ b/sbin/pfctl/pfctl.8 > @@ -198,7 +198,11 @@

Re: [PATCH] [www] innovations.html - add unwind(8) to the list

2019-04-30 Thread Ingo Schwarze
Hi Raf, Raf Czlonka wrote on Tue, Apr 30, 2019 at 12:18:17PM +0100: > unwind(8) looks like a good candidate for inclusion into > innovations.html[0]. > > While there, add "released with ..." to the preceding entry. > > [0] https://www.openbsd.org/innovations.html Thanks, committed. Ingo >

Re: perldoc: fix man output & formatting

2019-05-02 Thread Ingo Schwarze
Hi Todd & Andrew, Andrew Fresh wrote on Thu, May 02, 2019 at 09:53:29AM -0700: > On Thu, May 02, 2019 at 10:21:15AM -0600, Todd C. Miller wrote: >> On Thu, 02 May 2019 10:53:37 -0500, Andrew Daugherity wrote: >>> I reported this to FreeBSD ports a couple months ago [2], and they >>> provided a fi

Re: perldoc: fix man output & formatting

2019-05-02 Thread Ingo Schwarze
Hi Andrew, Andrew Daugherity wrote on Thu, May 02, 2019 at 10:53:37AM -0500: > Also, their ToMan patch has a previously-included hunk > for MANWIDTH=tty, All that does is suppress a warning message "non-numeric MANWIDTH" when a user has MANWIDTH=tty in their environment. No idea why any user wo

Re: kqueue.2: formatting fixes and minor HISTORY expansion

2019-05-02 Thread Ingo Schwarze
Hi Fabio, Fabio Scotoni wrote on Thu, May 02, 2019 at 03:33:42PM +0200: > I've taken a stab at improving kqueue.2 formatting. > Most of the changes are markup fixes. All your formatting decisions are good. > I used ".Dv NULL" over plain "null" in accordance with > lib/libc/stdlib/malloc.3 rev.

Re: perldoc: fix man output & formatting

2019-05-05 Thread Ingo Schwarze
Hi Andrew, Andrew Fresh wrote on Fri, May 03, 2019 at 06:24:16PM -0700: > I committed this after moving the waitpid down a few lines, after the > last read from the filehandle. Oops. Sorry for missing that, and thanks for committing it, and for catching that additional issue. > I will say that

Re: perldoc: fix man output & formatting

2019-05-05 Thread Ingo Schwarze
Hi Andrew, Andrew Fresh wrote on Sun, May 05, 2019 at 02:44:58PM -0700: > On Sun, May 05, 2019 at 04:53:05PM +0200, Ingo Schwarze wrote: >> The first chunk in the patch below seems to be all that is needed. >> IIRC, we already do a similar thing in pod2man(1). > This is true

clean up LC_NUMERIC in sort(1)

2019-05-06 Thread Ingo Schwarze
Hi, it was noticed years ago that our implementation of sort(1) is very messy. It contains huge amounts of dead code -- many hundreds of lines -- and many wrapper functions around standard C library functions that are in very bad taste and mostly pointless. However, nobody ever came round to cle

less(1) UTF-8 cleanup: pshift()

2019-05-07 Thread Ingo Schwarze
Hi, thanks for checking the pappend() and filename.c patches, those are now committed. Here is basic cleanup of the last major function in line.c, pshift(). Several minor issues still remain in the file, but those are for later. This gets rid of two LWCHAR variables, one call to utf_len(), get_w

less(1) UTF-8 cleanup: cvt.c

2019-05-08 Thread Ingo Schwarze
Hi Todd, Todd C. Miller wrote on Wed, May 08, 2019 at 06:36:30AM -0600: > On Tue, 07 May 2019 23:32:20 +0200, Ingo Schwarze wrote: >> Here is basic cleanup of the last major function in line.c, pshift(). > Looks good. OK millert@ Thanks for checking, i will commit the line.c

Re: update to PF pfctl(8) and pf.conf(5) manpages

2019-05-08 Thread Ingo Schwarze
Hi Alexandr, Alexandr Nedvedicky wrote on Wed, May 08, 2019 at 04:55:57PM +0200: > below is third iteration of pf.conf.5 manpage. OK schwarze@ A few final nits inline. Thank you again for doing this work. Ingo > diff --git a/share/man/man5/pf.conf.5 b/share/man/man5/pf.conf.5 [...] > @@ -1

less(1) UTF-8 cleanup: cmd_putstr()

2019-05-09 Thread Ingo Schwarze
Hi, let's start tackling the last file which is using stuff from charset.c: the file cmdbuf.c. The first dirty function is cmd_putstr(). Fortunately, it doesn't actually need to handle non-ASCII characters. The function cmd_putstr() is called only from command.c. Almost all callers pass literal

Re: [patch] remove reference to HOSTALIASES in hostname(7)

2019-05-09 Thread Ingo Schwarze
Hi, Theo de Raadt wrote on Mon, Apr 15, 2019 at 12:56:35PM -0600: > Hiltjo Posthuma wrote: >> I noticed the man page hostname(7) still references the environment >> variable HOSTALIASES. This functionality seems to be removed in the >> commit: >> https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/li

Re: [patch] improve strptime(3) %z timezone parsing

2019-05-09 Thread Ingo Schwarze
Hi, Theo de Raadt wrote on Sun, Mar 24, 2019 at 12:48:03PM -0600: > Hiltjo Posthuma wrote: >> On Sun, Feb 24, 2019 at 01:11:39PM +0100, Hiltjo Posthuma wrote: >>> 2. The military/nautical UTC offsets are [...] broken by design. >> As discussed previously for point 2 I think it is fine to eithe

Re: [patch] improve strptime(3) %z timezone parsing

2019-05-10 Thread Ingo Schwarze
Hi Ted, Ted Unangst wrote on Thu, May 09, 2019 at 04:16:40PM -0400: > Ingo Schwarze wrote: >> I'm not mixing anything else into this diff. The other bugs should >> be handled separately. > Works for me. (with additional comment removal) Thanks for checking, committed

Re: [patch] improve strptime(3) %z timezone parsing

2019-05-10 Thread Ingo Schwarze
Hi Todd, Todd C. Miller wrote on Fri, May 10, 2019 at 02:08:45PM -0600: > On Fri, 10 May 2019 16:52:35 +0200, Ingo Schwarze wrote: >> Here is a patch to fix the code. > OK millert@ for that part. Thanks, committed. >> The change to %Z is exactly what Hiltjo sent. >> Th

Re: [patch] improve strptime(3) %z timezone parsing

2019-05-10 Thread Ingo Schwarze
Hi, > That one looks correct. OK millert@ Committed, thanks for checking! While here, i noticed ugly preprocessor macros. Let's make our future life easier by unifdefing a bit. When compiling with -g0, there is no object change. Note that if TM_ZONE is not defined, wcsftime.c doesn't currentl

Re: remove regress maxtime

2019-05-14 Thread Ingo Schwarze
Hi Alexander, Alexander Bluhm wrote on Tue, May 14, 2019 at 02:16:19AM -0400: > Does anyone use the REGRESS_MAXTIME feature? Not me. > I would like to remove it. > > - The timeout based on CPU seconds is pretty useless. > Most hanging tests sleep and do not spin. > - A timeout cannot be dist

Re: Don't use '.Sx' to refer to external sections

2019-05-14 Thread Ingo Schwarze
Hi Stephen, Stephen Gregoratto wrote on Tue, May 14, 2019 at 01:08:00PM +1000: > It was mentioned previously that the use of .Sx to refer to a section in > a different manual page is incorrect. I grepped through the src tree to > see if there were any cases of this and I found a couple. Thanks,

clean up LC_COLLATE and LC_CTYPE in sort(1)

2019-05-14 Thread Ingo Schwarze
Hi, after my LC_NUMERIC cleanup for sort(1) went in (thanks to tb@ for the review), i'd like to adress the rest of locale dependency. Large amounts of extremely ugly code in sort(1) - many hundreds of lines - deal with LC_COLLATE, which we don't support now and have no intention to support in the

Re: print regress results

2019-05-15 Thread Ingo Schwarze
Hi Alexander, Alexander Bluhm wrote on Wed, May 15, 2019 at 12:01:00AM -0400: > Regress prints FAILED in the middle of the make output, this is > hard to watch. I agree this is a nuisance. I have often wondered whether the result was "PASS" or "FAIL" after doing longer regression runs in the pa

Re: caesar(6) to accept negative argument

2019-05-15 Thread Ingo Schwarze
Hi, tleguern wrote on Wed, May 15, 2019 at 03:36:57PM +0100: > This little patch makes caesar(6) useful at both encrypting and > decrypting texts by allowing a negative rotation. Committed, thanks. > A similar patch was proposed by Dieter Rauschenberger in 2008 with > little response Well, it'

Re: grep ".one\|.two" doesn't work on OpenBSD. Is it expected?

2019-05-21 Thread Ingo Schwarze
Hi, Todd C. Miller wrote on Mon, May 20, 2019 at 01:22:21PM -0600: > On Mon, 20 May 2019 20:01:12 +0200, Juan Francisco Cantero Hurtado wrote: >> The grep command works with GNU, NetBSD, FreeBSD and BusyBox. It fails >> on OpenBSD and Solaris 11. I'm suggesting upstream to change the command >> t

Re: mdoc.7: fix Dd example

2019-05-21 Thread Ingo Schwarze
Hi Klemens, Jason McIntyre wrote on Sun, May 19, 2019 at 08:58:35PM +0100: > On Sun, May 19, 2019 at 09:52:39PM +0200, Klemens Nanni wrote: >> On Sun, May 19, 2019 at 07:31:19PM +0100, Jason McIntyre wrote: >>> no. just use $Mdocdate$ and it gets expanded on commit. just like >>> when you add $Op

Re: cp(1) add -l hard link -s symlink options

2019-05-23 Thread Ingo Schwarze
Hi Tracey, Tracey Emery wrote on Thu, May 23, 2019 at 02:35:10PM -0600: > Attached is a proposed diff for cp(1). It adds the -l (hard link) > and -s (symlink) options. I don't like that. That's exactly what can be done with ln(1) in a standard way. There is no value in making every tool do eve

Re: timeout.9: cite our sources

2019-11-02 Thread Ingo Schwarze
Hi Scott & Jason, Jason McIntyre wrote on Sat, Nov 02, 2019 at 06:16:49PM +: > On Sat, Nov 02, 2019 at 12:32:30PM -0500, Scott Cheloha wrote: >> Cite the paper describing the timing wheel. PDF here: >> >> http://www.cs.columbia.edu/~nahum/w6998/papers/ton97-timing-wheels.pdf >> >> The auth

Re: .Aq in smtpd.conf(5)

2019-12-05 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Thu, Dec 05, 2019 at 06:54:28AM -0700: > CVSROOT: /cvs > Module name: src > Changes by: j...@cvs.openbsd.org2019/12/05 06:54:28 > > Modified files: > usr.sbin/smtpd : smtpd.conf.5 > > Log message: > replace "Pf < ... Ns >" with Aq; tidy up li

Re: Split uvm(9)

2019-12-05 Thread Ingo Schwarze
Hi Martin, Martin Pieuchot wrote on Thu, Dec 05, 2019 at 01:55:00PM +0100: > Diff below split uvm(9) into the following: > > - uvm_init(9) > - uvm_fault(9) > - uvm_km_alloc(9) > - uvm_map(9) > - uvm_pagealloc(9) > - uvn_attach(9) Yes please! In particular, i like how this reduces usage of .nr

Re: .Aq in smtpd.conf(5)

2019-12-05 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Thu, Dec 05, 2019 at 02:54:20PM +: > i have reverted it, with a heavy heart. Do you think i should try and convince the groff folks to always render .Aq/.Ao/.Ac as ASCII '<' and '>', even in UTF-8, HTML, PDF output and the like? Benefits: + easier rules f

Re: Clarify drand48() return values

2019-12-21 Thread Ingo Schwarze
Hi, Alexander Nasonov wrote on Fri, Dec 20, 2019 at 08:33:40PM +: > j...@bitminer.ca wrote: >> Clarify that drand48 returns values not including 1.0. > It's not clear from the documentation whether drand48 can generate > a denormal number. If it can't, you can exclude 0.0 because it's > a de

Re: Clarify drand48() return values

2019-12-21 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Sat, Dec 21, 2019 at 04:29:24PM -0700: > Ingo Schwarze wrote: >> Alexander Nasonov wrote on Fri, Dec 20, 2019 at 08:33:40PM +: >>> j...@bitminer.ca wrote: >>>> Clarify that drand48 returns values not including 1.0. >>>

Re: Add -R alias to -r for scp(1)

2020-01-02 Thread Ingo Schwarze
Hi Kurt, Kurt Mosiejczuk wrote on Wed, Jan 01, 2020 at 08:21:04PM -0500: > cp(1) uses -R for recursive copy. scp(1) uses -r. This diff adds -R > as an alias for -r to scp(1) for those assuming consistency with cp(1). even if cp -R and scp -r did the same thing - which, if i understand tedu@ corr

Re: Add -R alias to -r for scp(1)

2020-01-02 Thread Ingo Schwarze
Hi Marc, Marc Espie wrote on Thu, Jan 02, 2020 at 11:30:35AM +0100: > And if I use scp enough, I'm also likely to use cp -r by mistake. > > Are we likely to actually remove cp -r so the second mistake > doesn't happen ? I wouldn't be opposed to that. It has been deprecated since rev. 1.1 in

Re: man.cgi(8): turn off HTML5 autocomplete for the query input field

2020-01-10 Thread Ingo Schwarze
Hi Tim & Landry, Landry Breuil wrote on Fri, Jan 10, 2020 at 07:34:47AM +0100: > On Thu, Jan 09, 2020 at 09:18:25PM -0600, Tim Baumgard wrote: >> This turns off HTML5 autocomplete for the query input field for >> man.cgi(8). This essentially makes smartphones and tablets behave >> the same as PCs

Re: man.cgi(8): turn off HTML5 autocomplete for the query input field

2020-01-10 Thread Ingo Schwarze
Hi Tim, Tim Baumgard wrote on Fri, Jan 10, 2020 at 08:58:31AM -0600: > I found out that Apple requires nonstandard [1] attributes to fully > "fix" this. I don't know if using nonstandard attributes is the right > way to go, but Apple, Google, and DuckDuckGo are using these attributes > on their s

Re: man.cgi(8): turn off HTML5 autocomplete for the query input field

2020-01-10 Thread Ingo Schwarze
Hi Tim, Tim Baumgard wrote on Fri, Jan 10, 2020 at 10:16:40AM -0600: > Thank you for getting these changes in and so quickly. I will no longer > get as agitated when I'm looking at man pages away from my desk. :) You are welcome, enjoy. :-) Also note that the search form often isn't needed: i

Re: Fix manual description in SSL_CTX_add_extra_chain_cert.3

2020-01-12 Thread Ingo Schwarze
Hello Kinichiro-san, Kinichiro Inoguchi wrote on Sun, Jan 12, 2020 at 05:09:52PM +0900: > I think both SSL_CTX_get_extra_chain_certs and > SSL_CTX_get_extra_chain_certs_only should be described here. I think the text describing what to do with internal pointers returned from LibreSSL functions i

Re: ldomctl: Add -c to start for automatic console connect

2020-01-16 Thread Ingo Schwarze
Hi Mark and Klemens, Mark Kettenis wrote on Thu, Jan 16, 2020 at 02:46:02PM +0100: > I suppose this is fine since vmctl(8) has the same option. > > However the way you change the usage output isn't quite right. > Maybe "start" should go on a line of its own then. That sounds reasonable. > But

Re: MAKE: some older keywords

2020-01-16 Thread Ingo Schwarze
Hi Marc, Marc Espie wrote on Wed, Jan 15, 2020 at 01:52:37PM +0100: > So there is some luggage in make that I think we should drop. > > Currently, our make "supports" the keywords > .EXEC, .INVISIBLE, .JOIN, .MADE, > to the extent that I never touched the code that handles those, but > frankly I

Re: Teach du(1) the -m flag, disk usage in megabytes

2020-01-29 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Wed, Jan 29, 2020 at 04:26:42PM +: > i don;t think it would be such a bad thing for du to have an example or > two, so i'm ok with this. > > so sth like: > > Display a summary of files and folders in the current directory, > sorted by size: >

Re: Teach du(1) the -m flag, disk usage in megabytes

2020-01-29 Thread Ingo Schwarze
Hi Andreas, Andreas Kusalananda wrote on Wed, Jan 29, 2020 at 06:09:54PM +0100: > On Wed, Jan 29, 2020 at 05:48:44PM +0100, Ingo Schwarze wrote: >> +.Dl du -sh * .??* | sort -h > Why the ".??*"? That would miss single (well, double) letter hidden > directory names li

Re: [patch] /bin/cp: reduce scope variable

2020-01-31 Thread Ingo Schwarze
Hi, ngc...@gmail.com wrote on Fri, Jan 31, 2020 at 10:14:52PM +0900: > Reduce scope of a few variables. No, this contradicts OpenBSD coding style. We want local variables declared up front in functions such that you can see at one glance which variables exist. > While here, remove an extraneous

Re: refer to pointers as non-null

2020-01-31 Thread Ingo Schwarze
Hi Ted, Ted Unangst wrote on Fri, Jan 31, 2020 at 05:33:05AM -0500: > Noticed this in wait.2, though I imagine other occurences abound. > > I believe non-null is clearer when refering to a pointer than non-zero, which > is a bit 80s, and less likely to be mistaken for the value pointed to. This

Re: [patch] /bin/cp: reduce scope variable

2020-02-01 Thread Ingo Schwarze
Hi Jeremie, Jeremie Courreges-Anglas wrote on Sat, Feb 01, 2020 at 01:37:32PM +0100: > On Fri, Jan 31 2020, Ingo Schwarze wrote: >> ngc...@gmail.com wrote on Fri, Jan 31, 2020 at 10:14:52PM +0900: >>> Reduce scope of a few variables. >> No, this contradicts OpenBSD

Re: Document that openlog's first paramater must continue to point to valid data

2020-02-03 Thread Ingo Schwarze
Hi, since our manual page doesn't explain the details of how openlog(3) uses *ident, it seems reasonable for users to conclude that it is safest to neither free nor modify it. Then again, given that in our implementation, freeing it may even pose a security hazard, i might seem friendly to give m

Re: Document that openlog's first paramater must continue to point to valid data

2020-02-03 Thread Ingo Schwarze
Hi Andreas, Andreas Kusalananda wrote on Mon, Feb 03, 2020 at 09:56:22PM +0100: > Related: https://www.austingroupbugs.net/view.php?id=1244 > > A proposal seems to have been accepted (if I'm reading it correctly) in > November of last year to change the wording in POSIX from > > The ide

Re: Document that openlog's first paramater must continue to point to valid data

2020-02-05 Thread Ingo Schwarze
Hi, Laurence Tratt wrote on Wed, Feb 05, 2020 at 09:38:28AM +: > On Mon, Feb 03, 2020 at 09:28:15PM +0100, Ingo Schwarze wrote: >> The parameter >> .Fa ident >> -is a string that will be prepended to every message. >> +points to a string that will be prepende

let "man -w" print the manpath

2020-02-06 Thread Ingo Schwarze
.1 7 Jan 2020 11:15:12 - 1.34 +++ man.1 6 Feb 2020 19:53:42 - @@ -3,7 +3,7 @@ .\" Copyright (c) 1989, 1990, 1993 .\"The Regents of the University of California. All rights reserved. .\" Copyright (c) 2003, 2007, 2008, 2014 Jason McInty

Re: Add note about example dhclient.conf

2020-02-08 Thread Ingo Schwarze
Hi, i think i said it before: i hate /etc/examples/ and think that the directory ought to be mostly empty. With the exception of rare cases like bgpd(8), where you have to provide a lot of information before you can start it in any meaningful way, i consider a deamon ill-designed if the configur

get rid of almost empty /etc/examples/mixerctl.conf

2020-02-08 Thread Ingo Schwarze
Hi Theo, you have a point, that was a lot of cheap talk and no patch. I don't aim at changing yacc(1) grammars. I think most parts of OpenBSD configuration systems already have sane defaults and most configuration syntaxes are already good with respect to simplicity and usability. At least "mos

Re: get rid of almost empty /etc/examples/mixerctl.conf

2020-02-08 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Sat, Feb 08, 2020 at 03:33:37PM -0700: > Jason McIntyre wrote: >> without getting into a discussion about /etc/examples, in this case i >> personally see neither the point of the example config file (so trivial >> as to be questionable) nor the addition to the ma

mention /etc/examples/ in bgpf.conf(5)/bgpd(8)

2020-02-08 Thread Ingo Schwarze
Hi, Jason McIntyre wrote on Sat, Feb 08, 2020 at 10:15:08PM +: > - i'm ok with adding the path to these files to a FILES section So, here is a specific patch for bgpf.conf(5) and bgpd(8) such that we can agree on a general direction for one case where the example file is particularly importa

Re: mention /etc/examples/ in bgpf.conf(5)/bgpd(8)

2020-02-08 Thread Ingo Schwarze
Hi, Theo de Raadt wrote on Sat, Feb 08, 2020 at 04:39:42PM -0700: > For complicated configurations, the text could explain the reason the > example is valuable -- for instance > > .It Pa /etc/examples/bgpd.conf > Example configuration file demonstrating IBGP mesh, multiple transits, > RPKI filte

Re: mention /etc/examples/ in bgpf.conf(5)/bgpd(8)

2020-02-09 Thread Ingo Schwarze
Hi Marc, Marc Espie wrote on Sun, Feb 09, 2020 at 02:27:23PM +0100: > I still think it's a good idea to put it in afterboot(8). No more objections, with or without jmc@'s tweaks. It seems clear that enough people want it in that page. Yours, Ingo > Index: afterboot.8 > =

Re: mention /etc/examples/ in bgpf.conf(5)/bgpd(8)

2020-02-09 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Sun, Feb 09, 2020 at 07:49:10AM +: > - bgpd.8 refers to /etc/bgpd.conf. that file doesn;t exist by default. I do not consider that a problem, not even a minor one. ENVIRONMENT says which variables are inspected if they exist. FILES says which files are use

Re: locate.updatedb TMPDIR

2020-02-09 Thread Ingo Schwarze
Hi Todd, Todd C. Miller wrote on Sun, Feb 09, 2020 at 07:52:10AM -0700: > I'm fine with this. I don't really object, but i'm not sure it is needed either. It's certainly obvious that command line arguments override defaults. That's what they always do. It's their whole point, in general. Also

<    1   2   3   4   5   6   7   8   9   10   >