On Mon, Mar 28, 2016 at 03:40:21AM -0600, Abel Abraham Camarillo Ojeda wrote:
> On Mon, Mar 28, 2016 at 3:27 AM, Otto Moerbeek wrote:
> > On Wed, Mar 23, 2016 at 08:00:19AM +0100, Otto Moerbeek wrote:
> >
> >> Hi,
> >>
> >> first diff that seems to w
On Mon, Mar 28, 2016 at 11:43:22AM +0200, Otto Moerbeek wrote:
> No specifics, just watch out for malloc related bugs. It's
> both important that non-threaded programs and non-threaded programs
> show no new bugs.
And don't forget to test non-threaded programs ;-)
On Sat, Apr 02, 2016 at 05:32:02PM +0200, frit...@alokat.org wrote:
> Is it really necessary to cast pid_t values to long, only
> for printing?
yes, pid_t may be long, as defined by posix,
-Otto
>
> --f.
>
>
> Index: ftpd.c
> ==
On Sat, Apr 02, 2016 at 09:13:20PM +, H??ctor Luis Gimbatti wrote:
> Hi,
> Apparently the error seems to be in /usr/src/usr.bin/grep/util.c at line 400:
>
> if ((!(lflag || cflag)) && ((!(bol || eol)) &&
> ((lastHalfDot) && ((firstHalfDot < 0) ||
> ((fg->patter
On Sun, Apr 03, 2016 at 10:31:33AM +0200, Martin Natano wrote:
> On Sun, Apr 03, 2016 at 09:14:40AM +0200, Otto Moerbeek wrote:
> > On Sat, Apr 02, 2016 at 09:13:20PM +, H??ctor Luis Gimbatti wrote:
> >
> > > Hi,
> > > Apparently the error seems to be in /us
On Wed, Mar 30, 2016 at 06:30:53PM +0200, Norman Golisz wrote:
> On Mon Mar 28 2016 11:27, Otto Moerbeek wrote:
> > Second diff. Only one person (Stefan Kempf, thanks!) gave feedback...
>
> Sorry, running with this patch since a week, but missed to give
> feedback.
>
On Thu, Apr 28, 2016 at 01:07:30PM -0400, Ted Unangst wrote:
> Otto Moerbeek wrote:
> > static void
> > -ofree(struct dir_info *pool, void *p)
> > +ofree(struct dir_info *argpool, void *p)
> > {
> > + struct dir_info *pool;
> > struct region_in
Hi,
new diff in http://www.drijf.net/openbsd/malloc/
Should fix the issue Ted spotted and contains initial code to only set
up multiple pools if threaded. This one is only lightly tested by me,
but I wanted to post this before I'll be away for a semi-long weekend,
I don't think this is ready for
On Fri, Apr 29, 2016 at 04:43:56PM +1000, David Gwynne wrote:
>
> > On 28 Apr 2016, at 22:49, Mark Kettenis wrote:
> >
> >> Date: Thu, 28 Apr 2016 13:50:53 +0200
> >> From: Martin Pieuchot
> >>
> >> The reason why we do not use 'static' in the kernel is no longer valid
> >> since all our plat
On Fri, Apr 29, 2016 at 08:54:51AM +0200, Otto Moerbeek wrote:
> On Fri, Apr 29, 2016 at 04:43:56PM +1000, David Gwynne wrote:
>
> >
> > > On 28 Apr 2016, at 22:49, Mark Kettenis wrote:
> > >
> > >> Date: Thu, 28 Apr 2016 13:50:53 +0200
> > >
On Tue, May 10, 2016 at 02:48:18PM -0400, Daniel Micay wrote:
> The ENOMEM errno wasn't being set in some code paths where it was gated
> behind mopts.malloc_xmalloc:
Called functions do set errno..., you're effectively overriding those.
Which means those can go if this is applied. This needs mor
On Tue, May 10, 2016 at 07:14:41PM -0400, Daniel Micay wrote:
> > Seems valuable. Note, though, that you're developing on top of the
> > multi-pool malloc patches:
> >
> > https://marc.info/?t=14587167622&r=1&w=2
> >
> > http://www.drijf.net/openbsd/malloc/
> >
> > So there are probably con
On Fri, Apr 29, 2016 at 08:42:00AM +0200, Otto Moerbeek wrote:
> Hi,
>
> new diff in http://www.drijf.net/openbsd/malloc/
>
> Should fix the issue Ted spotted and contains initial code to only set
> up multiple pools if threaded. This one is only lightly tested by me,
>
On Fri, Jun 09, 2017 at 07:58:48AM +, kshe wrote:
> Hi,
>
> There is an ongoing confusion in sed's source about the concept of EOL:
> the code contradicts itself as to whether it should be determined by a
> trailing NUL or by looking up the `len' field of the SPACE structure.
>
> At least tw
On Tue, Jun 13, 2017 at 10:08:11AM +, kshe wrote:
> On Sat, 10 Jun 2017 10:25:27 +0000, Otto Moerbeek wrote:
> > Thanks for the analysis and diff, I hope to get a chanche to think
> > about this soon. At least I'll make sure this diff is not forgotten,
> > -Otto
On Thu, Jun 15, 2017 at 09:01:15AM +0200, Otto Moerbeek wrote:
at last a followup, for the original problem.
This diff incorporates your later comment. It does not cause the newly
added regress test to fail, though.
So that poses the question if this is what you meant.
-Otto
Index
On Sat, Jul 01, 2017 at 01:20:19PM +, kshe wrote:
> On Tue, 27 Jun 2017 09:29:10 +0000, Otto Moerbeek wrote:
> >
> > at last a followup, for the original problem.
> >
> > This diff incorporates your later comment. It does not cause the newly
> > a
On Sun, Jul 23, 2017 at 03:04:54PM +0200, Anton Lindqvist wrote:
> Hi,
> Fairly straightforward and no intended functional change. If changes
> like this one is not encouraged I would advocate on at least using
> stdbool.h instead.
>
> Comments? OK?
why? It might be old school, but there's notin
On Thu, Aug 24, 2017 at 11:34:52AM +1000, Damien Miller wrote:
> Hi,
>
> memset(NULL, 0, 0) is (strictly speaking) undefined behaviour, but
> there's no reason that freezero(3) needs to follow suit.
>
> This mentions that freezero(NULL, 0) is valid in the manpage, so that
> anyone who copies thi
On Fri, Aug 25, 2017 at 02:31:10PM +0300, Андрей Болконский wrote:
> hello! If I will achieve change of license for reiser4 FS on BSD and ported
> it to the openbsd, you accept it?
> And what about Journaling in openbsd?
We do not make promises about accepting code, especially if it does
not exis
Hi,
this one is a bit tricky (cee http://c-faq.com/ansi/constmismatch.html),
it fixes the warning:
/usr/src/sbin/iked/crypto.c:854:44: warning: cast from 'uint8_t **'
(aka 'unsigned char **') to 'const uint8_t **' (aka
'const unsigned char **') must have all intermediate pointers con
On Wed, Aug 30, 2017 at 05:54:16PM +0100, Ricardo Mestre wrote:
> Hi,
>
> Unbreak DEBUG for nfsd(8), this one was caught with cppcheck.
>
> It has been broken for about 7 years ago when a couple of errx calls, which
> had
> string format arguments, were replaced by syslog calls.
Can you please
On Wed, Aug 30, 2017 at 08:01:36PM +0100, Ricardo Mestre wrote:
> On 19:30 Wed 30 Aug , Otto Moerbeek wrote:
> > On Wed, Aug 30, 2017 at 05:54:16PM +0100, Ricardo Mestre wrote:
> >
> > > Hi,
> > >
> > > Unbreak DEBUG for nfsd(8), this one was caug
Hi,
/usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of
unsigned enum expression < 0 is always false [-Wtautological-compare]
if (state < 0 || state > FAIL)
~ ^ ~
/usr/src/usr.sbin/sasyncd/carp.c:166:20: warning: comparison of
unsigned enum expression < 0 is alw
On Thu, Aug 31, 2017 at 05:10:27PM +0200, Boudewijn Dijkstra wrote:
> Op Thu, 31 Aug 2017 14:08:07 +0200 schreef Otto Moerbeek :
> > /usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of
> > unsigned enum expression < 0 is always false [-Wtautological-compare]
> &g
Hi,
clang complains about a quite some signed compares in pax. This fixes
a few of them, all of the form
if (var < sizeof(...))
where var is an int.
Here a conversion of the int value to unsigned takes place, due to
the conversion rules. This causes negative values of var not to be caug
On Thu, Sep 07, 2017 at 12:27:18AM -0400, Bryan Steele wrote:
> Hi,
>
> This turned out easier then pflogd thanks to the existing privsep design
> work done by deraadt@ and canacar@ many years ago. While tcpdump isn't a
Small correction for the record:
done by otto@ and cancacar@ while being pr
Hi,
this fixes the following clang warnings:
/usr/src/bin/pax/tar.c:1257:11: warning: comparison of integers of different
signs: 'unsigned long' and 'long' [-Wsign-compare]
if (len > end - p) {
~~~ ^ ~~~
/usr/src/bin/pax/tar.c:1262:12: warning: comparison
On Thu, Sep 07, 2017 at 02:30:20PM -0600, Todd C. Miller wrote:
> Why not just use strtol() then? The check against MINXHDRSZ
> will catch any negative values.
>
> - todd
Indeed, better diff,
-Otto
Index: tar.c
===
RCS f
Hi,
A double free of a chunk corrupts the canary, but I prefer to see a
double free error reported,
-Otto
Index: malloc.c
===
RCS file: /cvs/src/lib/libc/stdlib/malloc.c,v
retrieving revision 1.228
diff -u -p -r1.228 malloc.
On Tue, Jun 14, 2016 at 06:14:05PM +0200, Jeremie Courreges-Anglas wrote:
> Marc Peters writes:
>
> > Hi,
> >
> > i just did an installation of a HP DL360 Gen9 to test UEFI installations
> > with 5.9. I just accepted most of the defaults and did this for the
> > disklabels, too. I wanted to chec
On Tue, Jun 14, 2016 at 03:41:11PM +0200, Marc Peters wrote:
> Hi,
>
> i just did an installation of a HP DL360 Gen9 to test UEFI installations
> with 5.9. I just accepted most of the defaults and did this for the
> disklabels, too. I wanted to checkout the sources to do release builds,
> but the
On Tue, Jun 14, 2016 at 06:14:05PM +0200, Jeremie Courreges-Anglas wrote:
> Marc Peters writes:
>
> > Hi,
> >
> > i just did an installation of a HP DL360 Gen9 to test UEFI installations
> > with 5.9. I just accepted most of the defaults and did this for the
> > disklabels, too. I wanted to chec
On Tue, Jun 21, 2016 at 01:11:16PM +0200, Henning Brauer wrote:
> * Stefan Sperling [2016-06-21 11:15]:
> > Generally, I would appreciate more detailed error messages from the pf.conf
> > parser. I recall several occasions where pfctl threw "syntax error" and more
> > specific error reporting wou
Hi,
J/j is actually a three valued var. So document that and make it
possible to set all three values. Default is still 1.
-Otto
Index: share/man/man5/malloc.conf.5
===
RCS file: /cvs/src/share/man/man5/malloc.conf.5,v
retri
On Sat, Jul 02, 2016 at 01:17:10PM -0400, Ted Unangst wrote:
> Otto Moerbeek wrote:
> > Hi,
> >
> > J/j is actually a three valued var. So document that and make it
> > possible to set all three values. Default is still 1.
>
> I initially left the default as
On Sun, Jul 03, 2016 at 09:31:11AM +0200, Otto Moerbeek wrote:
> On Sat, Jul 02, 2016 at 01:17:10PM -0400, Ted Unangst wrote:
>
> > Otto Moerbeek wrote:
> > > Hi,
> > >
> > > J/j is actually a three valued var. So document that and make it
> > &
On Wed, May 11, 2016 at 10:04:48AM +0200, Otto Moerbeek wrote:
> On Fri, Apr 29, 2016 at 08:42:00AM +0200, Otto Moerbeek wrote:
>
> > Hi,
> >
> > new diff in http://www.drijf.net/openbsd/malloc/
> >
> > Should fix the issue Ted spotted and contains init
On Mon, Aug 22, 2016 at 04:15:16PM +0200, Gregor Best wrote:
> Hi,
>
> On Mon, Aug 22, 2016 at 08:21:08AM +0200, Otto Moerbeek wrote:
> > [...]
> > New diff posted in http://www.drijf.net/openbsd/malloc.
> >
> > The intention is that this is close to commitabl
On Mon, Aug 22, 2016 at 05:00:12PM +0200, Otto Moerbeek wrote:
> Hmm, indeed, looking into it.
Fixed diff now online,
-Otto
On Mon, Aug 22, 2016 at 07:07:21PM +0200, Gregor Best wrote:
> On Mon, Aug 22, 2016 at 05:03:34PM +0200, Otto Moerbeek wrote:
> > On Mon, Aug 22, 2016 at 05:00:12PM +0200, Otto Moerbeek wrote:
> >
> > > Hmm, indeed, looking into it.
> >
> > Fixed diff now
On Mon, Aug 22, 2016 at 07:35:49PM +0200, Otto Moerbeek wrote:
> On Mon, Aug 22, 2016 at 07:07:21PM +0200, Gregor Best wrote:
>
> > On Mon, Aug 22, 2016 at 05:03:34PM +0200, Otto Moerbeek wrote:
> > > On Mon, Aug 22, 2016 at 05:00:12PM +0200, Otto Moerbeek wrote:
>
On Mon, Aug 22, 2016 at 08:37:30PM +0200, Otto Moerbeek wrote:
> On Mon, Aug 22, 2016 at 07:35:49PM +0200, Otto Moerbeek wrote:
>
> > On Mon, Aug 22, 2016 at 07:07:21PM +0200, Gregor Best wrote:
> >
> > > On Mon, Aug 22, 2016 at 05:03:34PM +0200, Otto Moerbeek wr
On Mon, Aug 22, 2016 at 08:59:44PM -0400, Ted Unangst wrote:
> Otto Moerbeek wrote:
> >
> > After a forkl of a threaded program __isthreaded is reset, but
> > existing allocations are spread around the pools. But the new single
> > threaded child only looks in the firs
On Thu, Sep 01, 2016 at 06:36:15AM +0100, Theo Buehler wrote:
> In factor(6), there is the line
>
> 216 stop = usqrt(val) + 1;
>
> where the u_int64_t stop is the upper bound for the sieve of
> Eratosthenes (I cautiously added 1 to be sure to be on the safe side).
> Unfortunately, the
On Tue, Aug 23, 2016 at 09:57:03AM +0200, Otto Moerbeek wrote:
> On Mon, Aug 22, 2016 at 08:59:44PM -0400, Ted Unangst wrote:
>
> > Otto Moerbeek wrote:
> > >
> > > After a forkl of a threaded program __isthreaded is reset, but
> > > existing allocations a
On Mon, Sep 05, 2016 at 08:05:40AM +0300, Ali H. Fardan wrote:
> On 2016-09-05 08:01, David Gwynne wrote:
> > > On 5 Sep 2016, at 12:13, Ali H. Fardan wrote:
> > >
> > > You can't specify a buffer size in asprintf() therefore, it is not
> > > secure,
> > > you can see that snprintf() does write
On Mon, Sep 05, 2016 at 10:47:06AM +0300, Ali H. Fardan wrote:
> On 2016-09-05 10:44, David Gwynne wrote:
> > > On 5 Sep 2016, at 17:39, Ali H. Fardan wrote:
> > >
> > > and why is he telling me this? I just said if the destination is a
> > > pointer to char, how would a function automagically a
On Tue, Sep 06, 2016 at 01:56:32PM +0100, Filippo Valsorda wrote:
> Hello,
>
> I recently had the occasion to dive into the softraid crypto code [1]
> and was quite pleased with the cleanliness of it all. However, I found
> surprising the default value of 8k PBKDF2 rounds.
>
> I know it is easy
On Wed, Sep 07, 2016 at 06:29:07PM -0400, Ted Unangst wrote:
> Instead of always using a fixed byte pattern, I think malloc should use a
> random pattern. Now, this sometimes means it's harder to identify exactly
> what's used after free, so we should provide a means to get the old 0xdf
> pattern
On Thu, Sep 08, 2016 at 07:47:58PM -0400, Daniel Micay wrote:
> A nice security property of 0xdf filling is that a use-after-free of a
> pointer is guaranteed to fault in a typical environment since it ends up
> pointing outside userspace (I assume that's the case on OpenBSD). A heap
> spray could
On Thu, Sep 08, 2016 at 06:42:33PM -0400, Daniel Micay wrote:
> On Wed, 2016-09-07 at 18:29 -0400, Ted Unangst wrote:
> > Instead of always using a fixed byte pattern, I think malloc should
> > use a
> > random pattern. Now, this sometimes means it's harder to identify
> > exactly
> > what's used
On Thu, Sep 08, 2016 at 08:15:42AM +0200, Otto Moerbeek wrote:
> On Wed, Sep 07, 2016 at 06:29:07PM -0400, Ted Unangst wrote:
>
> > Instead of always using a fixed byte pattern, I think malloc should use a
> > random pattern. Now, this sometimes means it's harder to iden
On Wed, Sep 14, 2016 at 12:53:05PM -0400, Ted Unangst wrote:
> Daniel Micay wrote:
> >
> > The current OpenBSD code only wipes up to MALLOC_MAXCHUNK with junk @ 1,
> > and it similarly doesn't wipe at all with 'U' (even though junk-on-free
> > also serves the purpose of preventing information lea
On Thu, Sep 15, 2016 at 10:08:26AM -0400, Ted Unangst wrote:
> Otto Moerbeek wrote:
> > On Wed, Sep 14, 2016 at 12:53:05PM -0400, Ted Unangst wrote:
> >
> > > Daniel Micay wrote:
> > > >
> > > > The current OpenBSD code only wipes up to MALLOC_
On Fri, Sep 16, 2016 at 09:30:15PM +0200, Otto Moerbeek wrote:
> On Thu, Sep 15, 2016 at 10:08:26AM -0400, Ted Unangst wrote:
>
> > Otto Moerbeek wrote:
> > > On Wed, Sep 14, 2016 at 12:53:05PM -0400, Ted Unangst wrote:
> > >
> > > > Daniel Micay wrote
On Wed, Sep 14, 2016 at 05:41:55AM +0200, Theo Buehler wrote:
> On Tue, Sep 13, 2016 at 01:29:17PM +0200, Otto Moerbeek wrote:
> > As often, real life came in between. Did anybody do measurements? I
> > really would like to to see hard data.
>
> It seems that the price
On Thu, Sep 29, 2016 at 12:10:47AM +0300, Evgeny Grin wrote:
> Hi!
>
> I configured freshly installed OpenBSD 6.0-release with
>
> kern.maxfiles=131072
>
> in /etc/sysctl.conf
> and
>
> :openfiles-max=40960:openfiles-cur=40960:
>
> for daemon in /etc/login.conf
>
> And at each boot I see mes
On Thu, Sep 29, 2016 at 11:45:21AM +0300, Evgeny Grin wrote:
>
>
> On 29.09.2016 8:08, Otto Moerbeek wrote:
> > On Thu, Sep 29, 2016 at 12:10:47AM +0300, Evgeny Grin wrote:
> >
> >> Hi!
> >>
> >> I configured freshly installed OpenBSD
On Thu, Sep 29, 2016 at 03:33:48PM +0300, Evgeny Grin wrote:
>
>
> On 29.09.2016 13:57, Otto Moerbeek wrote:
> > On Thu, Sep 29, 2016 at 11:45:21AM +0300, Evgeny Grin wrote:
> >> May be it also worth to mention in /etc/login.conf comments, that if
> >> bo
Hi,
I have been working on a diff to do canaries in a better way.
Canaries (enabled by the C malloc option) are values stored after the
requested size that are checked for being overwritten on calling
free(3). At the moment we only do this for chunks (sub-page sized
allocations).
To be able to
On Tue, Oct 04, 2016 at 04:00:50AM -0700, Claus Assmann wrote:
> On Tue, Oct 04, 2016, Dmitrij D. Czarkoff wrote:
>
> [please do not Cc me]
>
> > I shouldn't have started on sending patches at 3AM. This one should do
> > what I intended it to do. Sorry for noise.
>
> > + else if (t
On Tue, Oct 04, 2016 at 01:26:06PM +0200, Otto Moerbeek wrote:
> On Tue, Oct 04, 2016 at 04:00:50AM -0700, Claus Assmann wrote:
>
> > On Tue, Oct 04, 2016, Dmitrij D. Czarkoff wrote:
> >
> > [please do not Cc me]
> >
> > > I shouldn't have started on
On Thu, Oct 06, 2016 at 09:15:50AM +0200, Theo Buehler wrote:
> On Thu, Oct 06, 2016 at 08:57:44AM +0200, Otto Moerbeek wrote:
> > On Tue, Oct 04, 2016 at 01:26:06PM +0200, Otto Moerbeek wrote:
> >
> > > On Tue, Oct 04, 2016 at 04:00:50AM -0700, Claus Assmann wrote:
>
On Mon, Oct 03, 2016 at 07:57:13AM +0200, Otto Moerbeek wrote:
> Hi,
>
> I have been working on a diff to do canaries in a better way.
>
> Canaries (enabled by the C malloc option) are values stored after the
> requested size that are checked for being overwritten on calling
On Fri, Oct 07, 2016 at 02:33:13PM -0500, Brent Cook wrote:
>
> > On Oct 7, 2016, at 12:18 PM, Ted Unangst wrote:
> >
> > Kinichiro Inoguchi wrote:
> >> I think this 16 bytes string assignment has boundary issue.
> >>
> >>static const char sigma[16] = "expand 32-byte k";
> >>
> >> I found
On Fri, Oct 07, 2016 at 03:06:28PM -0500, Brent Cook wrote:
>
> > On Oct 7, 2016, at 2:52 PM, Otto Moerbeek wrote:
> >
> > On Fri, Oct 07, 2016 at 02:33:13PM -0500, Brent Cook wrote:
> >
> >>
> >>> On Oct 7, 2016, at 12:18 PM, Ted Unang
Hi,
avoid recomping the offset by storing it in the chunk info, ok?
-Otto
Index: stdlib/malloc.c
===
RCS file: /cvs/src/lib/libc/stdlib/malloc.c,v
retrieving revision 1.199
diff -u -p -r1.199 malloc.c
--- stdlib/malloc.c
Hi,
Canaries and chunk validation on delayed free,
OK?
-Otto
Index: malloc.c
===
RCS file: /cvs/src/libexec/ld.so/malloc.c,v
retrieving revision 1.12
diff -u -p -r1.12 malloc.c
--- malloc.c18 Sep 2016 13:54:58 -
On Sat, Oct 08, 2016 at 05:30:11PM -0700, Philip Guenther wrote:
> On Sat, 8 Oct 2016, Otto Moerbeek wrote:
> > Canaries and chunk validation on delayed free,
> >
> > OK?
>
> There are still significant differences between the libc malloc and the
> ld.so malloc af
On Sat, Oct 08, 2016 at 06:40:00PM +0200, Otto Moerbeek wrote:
> Hi,
>
> avoid recomping the offset by storing it in the chunk info, ok?
anyone?
>
> -Otto
>
> Index: stdlib/malloc.c
> ===
>
On Mon, Oct 10, 2016 at 09:53:55PM +0200, Martijn van Duren wrote:
> Hello tech@,
>
> As reported and fixed by pfg@freebsd.
> Fixes the following case:
> % echo z | gsed -n -e 's/^a*/b/2p'
> # empty -- correct
> % echo z | sed -n -e 's/^a*/b/2p'
> z # incorrect
>
> Fix in FreeBSD r302973
>
> O
Hi,
simple diff to show the hostname on the second line. OK?
BTW, batch mode doesn't function here as expected. Need to look into that,
-Otto
Index: main.c
===
RCS file: /cvs/src/usr.bin/systat/main.c,v
retrieving revision
On Thu, Oct 13, 2016 at 12:15:34AM -0400, Ted Unangst wrote:
> Theo de Raadt wrote:
> > > On Wed, Oct 12, 2016 at 03:20:00PM +0200, Otto Moerbeek wrote:
> > > > simple diff to show the hostname on the second line. OK?
> > >
> > > OK bluhm@
> > >
On Thu, Oct 13, 2016 at 08:01:22AM +0200, Otto Moerbeek wrote:
> On Thu, Oct 13, 2016 at 12:15:34AM -0400, Ted Unangst wrote:
>
> > Theo de Raadt wrote:
> > > > On Wed, Oct 12, 2016 at 03:20:00PM +0200, Otto Moerbeek wrote:
> > > > > simple diff to s
On Thu, Oct 13, 2016 at 08:20:52AM +0200, Otto Moerbeek wrote:
> On Thu, Oct 13, 2016 at 08:01:22AM +0200, Otto Moerbeek wrote:
>
> > On Thu, Oct 13, 2016 at 12:15:34AM -0400, Ted Unangst wrote:
> >
> > > Theo de Raadt wrote:
> > > > > On Wed, Oct 1
Hi,
0xdb is better dan 0xd0, since it is unaligned in more cases (think
about the bytes being used as a pointer.
ok?
-Otto
Index: lib/libc/stdlib/malloc.c
===
RCS file: /cvs/src/lib/libc/stdlib/malloc.c,v
retrieving revisio
Hi,
this diff is somewhat big since I decided to rewrite wrterror() to be
able to get better error messages.
Please review and test this with malloc option C (and other flags). An
example run:
a.out(85360) in free(): chunk canary corrupted 0x13c68f696000 0x18a92@0x18a88
This means I overwrote a
On Sun, Oct 16, 2016 at 07:07:36AM -0600, Todd C. Miller wrote:
> It is effectively the same in this case but using the boolean OR
> is less surprising and may quiet over zealous compilers.
Are you sure? For example, in cvs/diff3.c
t2 is not always initialized with this change.
-Otto
>
On Sun, Oct 16, 2016 at 08:44:34AM -0600, Todd C. Miller wrote:
> On Sun, 16 Oct 2016 16:06:39 +0200, Otto Moerbeek wrote:
>
> > On Sun, Oct 16, 2016 at 07:07:36AM -0600, Todd C. Miller wrote:
> >
> > > It is effectively the same in this case but using the boolean
On Tue, Oct 18, 2016 at 03:23:32AM +0200, Theo Buehler wrote:
> On Sun, Oct 16, 2016 at 01:14:35PM +0200, Otto Moerbeek wrote:
> > Hi,
> >
> > this diff is somewhat big since I decided to rewrite wrterror() to be
> > able to get better error messages.
> >
>
On Tue, Oct 18, 2016 at 11:12:39AM +0200, Theo Buehler wrote:
> > That is certainly not correct: snprintf and friends return the length as
> > it would have been if an infinite buffer was passed in.
> > So the strlen should stay.
>
New diff, though the snprintf return value check might be overk
On Thu, Oct 20, 2016 at 04:42:13AM -0400, Ted Unangst wrote:
> Otto Moerbeek wrote:
> > That is certainly not correct: snprintf and friends return the length as
> > it would have been if an infinite buffer was passed in.
> > So the strlen should stay. I'll make a new
On Thu, Oct 20, 2016 at 11:17:25AM +0200, Otto Moerbeek wrote:
> On Thu, Oct 20, 2016 at 04:42:13AM -0400, Ted Unangst wrote:
>
> > Otto Moerbeek wrote:
> > > That is certainly not correct: snprintf and friends return the length as
> > > it would have been if an
On Thu, Oct 20, 2016 at 11:21:26AM +0200, Otto Moerbeek wrote:
> On Thu, Oct 20, 2016 at 11:17:25AM +0200, Otto Moerbeek wrote:
>
> > On Thu, Oct 20, 2016 at 04:42:13AM -0400, Ted Unangst wrote:
> >
> > > Otto Moerbeek wrote:
> > > > That is certainly n
On Thu, Oct 20, 2016 at 11:28:37AM +0200, Otto Moerbeek wrote:
> On Thu, Oct 20, 2016 at 11:21:26AM +0200, Otto Moerbeek wrote:
>
> > On Thu, Oct 20, 2016 at 11:17:25AM +0200, Otto Moerbeek wrote:
> >
> > > On Thu, Oct 20, 2016 at 04:42:13AM -0400, Ted Unangst
On Thu, Oct 20, 2016 at 01:50:41PM +0200, Otto Moerbeek wrote:
> On Thu, Oct 20, 2016 at 11:28:37AM +0200, Otto Moerbeek wrote:
>
> > On Thu, Oct 20, 2016 at 11:21:26AM +0200, Otto Moerbeek wrote:
> >
> > > On Thu, Oct 20, 2016 at 11:17:25AM +0200, Otto Moerbeek w
Hi,
survived a make build on amd64 and armv7 here. Note that canaries are
always enabled in ld.so's malloc.
ok?
-Otto
Index: malloc.c
===
RCS file: /cvs/src/libexec/ld.so/malloc.c,v
retrieving revision 1.14
diff -u -p -r1.1
Hi,
Pages in the malloc cache are either reused quickly or unmapped
quickly. In both cases it does not make sense to set hints on them.
So remove that option, which is just a remainder of old times when
mallco used to hold on to pages. OK?
-Otto
Index: lib/libc/stdlib/malloc.c
==
Hi,
remove some old option letters and also make P non-settable. It has
been the default for ages, and I see no valid reason to be able to
disable it.
OK?
-Otto
Index: lib/libc/stdlib/malloc.c
===
RCS file: /cvs/src/lib/l
On Sun, Oct 30, 2016 at 07:37:27AM +0100, Otto Moerbeek wrote:
> Hi,
>
> remove some old option letters and also make P non-settable. It has
> been the default for ages, and I see no valid reason to be able to
> disable it.
>
> OK?
No feedback,... I will commit this diff
On Wed, Nov 09, 2016 at 08:51:04AM -0800, Bryan Vyhmeister wrote:
> This patch accomplishes two things for umb(4) connections. One, some SIM
> cards have a plus at the beginning of the phone number while others do
> not. In my case, an AT&T Wireless SIM card in the US has the plus where
> a T-Mobi
On Thu, Nov 10, 2016 at 02:12:55PM +0100, Gerhard Roth wrote:
> On Thu, 10 Nov 2016 13:56:00 +0100 Otto Moerbeek wrote:
> > On Wed, Nov 09, 2016 at 08:51:04AM -0800, Bryan Vyhmeister wrote:
> >
> > > This patch accomplishes two things for umb(4) connections. One, som
On Sun, Nov 13, 2016 at 09:30:26PM +0300, Sergey Bronnikov wrote:
> OK?
Nope, the goal still is to have a release every six months (at least
for me). Just the way it is distributed changed.
-Otto
>
> diff --git a/goals.html b/goals.html
> index c94d4cb..ef0dbcc 100644
> --- a/goals.htm
On Thu, Nov 24, 2016 at 04:42:37PM +0100, Senthil Kumar M wrote:
> Hello Tech,
>
> In the find(1) man page, for the option `-f':
>
> -f path
> Specifies a file hierarchy for find to traverse. File
> hierarchies may be specified without the -f option if they are
>
On Wed, Nov 23, 2016 at 08:56:53PM +0100, Ingo Feinerer wrote:
> Hi,
>
> the "Lenovo N5321gw" is working for me with umb(4)
> (https://marc.info/?l=openbsd-misc&m=147992993614369&w=2). So mention it
> as a supported device in umb.4?
>
> (Lenovo seems to call it Ericsson N5321gw on its support si
On Wed, Sep 16, 2015 at 10:36:57PM -0400, Michael McConville wrote:
> Michael McConville wrote:
> > fmt.c contains two functions that are only called by command() in
> > print.c. One of them is tiny, too. It seems simpler to have them in
> > print.c as statics.
>
> I forgot to mention that I also
On Sat, Sep 19, 2015 at 05:57:23PM -0400, Michael McConville wrote:
> > What's your thinking behind this? To me this seems like a perfectly
> > rational and well motivated function to have, both for readability and
> > rather than having to repeat the same statements several times over in
> > the
On Sun, Sep 20, 2015 at 07:43:46AM -0400, Michael McConville wrote:
> Otto Moerbeek wrote:
> > I do not agree. You only have to remeber "that function does sensible
> > error checking" and you do not have to remember at each spot which
> > condition is the right
On Sat, Oct 10, 2015 at 02:55:34PM +0200, Tobias Stoeckmann wrote:
> That's what I get for copy&pasting out of a manual...
>
> The LIST_EMPTY example lacks an opening curly bracket. The other
> examples have it, so it's a pretty obvious fix.
ok,
-Otto
>
>
> Index: queue.3
> ==
401 - 500 of 927 matches
Mail list logo
