Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.05.08 09:40:38 +0200:
> Bgpctl has a way to specify the address family to show in 'show rib'
> commands. Teach it to also support IPv6 MPLS VPNs (aka VPNv6).
>
> OK?
ok
> --
> :wq Claudio
>
> Index: parser.c
> ==
Jesper Wallin(jes...@ifconfig.se) on 2020.05.01 12:15:06 +0200:
> Hi all,
>
> I was trying to score 100 on all the tests over at ssllabs.com, but seem
> to only reach 90 on "Key Exchange". Not sure if it's related, but I was
> playing with the "dhe" option in relayd.conf(5) in order to increase t
Stuart Henderson(s...@spacehopper.org) on 2020.05.01 23:46:49 +0100:
> On 2020/05/02 00:43, Stephan Mending wrote:
> > On 02/05/2020 00:40, Stuart Henderson wrote:
> > > On 2020/05/02 00:23, Stephan Mending wrote:
> > > > Hi,
> > > >
> > > > I actually read your thread. By what I understood you're
Hiltjo Posthuma(hil...@codemadness.org) on 2020.05.01 16:31:33 +0200:
> On Fri, May 01, 2020 at 01:18:03PM +0200, Claudio Jeker wrote:
> > This diff add JSON output support for bgpctl.
> > Most commands should produce now a resonable JSON object.
> > The individual objects can probably be improved
Jesper Wallin(jes...@ifconfig.se) on 2020.05.01 12:15:06 +0200:
> Hi all,
>
> I was trying to score 100 on all the tests over at ssllabs.com, but seem
> to only reach 90 on "Key Exchange". Not sure if it's related, but I was
> playing with the "dhe" option in relayd.conf(5) in order to increase t
James Jerkins(j...@jamesjerkinscomputer.com) on 2020.04.29 22:28:12 -0500:
> Hello,
>
> This patch adds two new options to sysupgrade. The first option is for
> small box systems like an APU system that only has the base and manual
We wont add tons of options to this tool for every use case.
Ju
Hi,
there have been no floppy images since the 6.2 release. This removes mention
of boot floppies from the INSTALL.alpha notes. Maybe someone who knows
something about alpha machines can do a check?
comments or oks?
diff --git distrib/notes/alpha/contents distrib/notes/alpha/contents
index eccbc
Mark Kettenis(mark.kette...@xs4all.nl) on 2020.04.23 22:56:17 +0200:
> I put this in at some point since I couldn't get the eMMC on my
> firefly-rk3399 working otherwise. But its eMMC died and on my
> rockpro64 and rk3399-q7 boards things work very well without it. On
> the latter board it even m
reads ok
Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.04.23 10:04:15 +0200:
> local-address is one of those values that need to be set in some cases but
> is not very flexible to use. This diff tries to change this a bit.
>
> It allows to set the local-address for both IPv4 and IPv6 at the sam
Bartosz Kuzma(bartosz.ku...@release11.com) on 2020.04.21 20:59:54 +0200:
> Hello,
>
> thanks for looking at this!
>
> On 21/04/2020 17:43, Florian Obser wrote:
> >Hi,
> >
> >thanks for working on this and finding another acme implementor!
> >
> >On Mon, Apr 20, 2020 at 06:51:17PM +0200, Bartosz K
Bartosz Kuzma(bartosz.ku...@release11.com) on 2020.04.20 18:51:17 +0200:
> Hello,
>
> I've tried to get a certificate from Buypass Go SSL provider using
> acme-client(1) but it ends with the following error:
>
> acme-client: https://api.buypass.com/acme-v02/new-acct: bad HTTP: 400
> acme-client:
Florian Obser(flor...@openbsd.org) on 2020.04.21 06:57:49 +0200:
> We didn't get around to run unwind per default and integrate it
> tighter with dhclient this release cycle.
> But there is also no need anymore to recomend prepend in
> dhclient.conf, unwind(8) is no longer closing it's service port
routing stacks.
See RFC 6811 for a description of how BGP Prefix Origin Validation
secures the Internet's global routing system.
rpki-client was primarily developed by Kristaps Dzonsons, Claudio
Jeker, Job Snijders, and Sebastian Benoit as part of the OpenBSD
Project and gets released as a
Edd Barrett(e...@theunixzoo.co.uk) on 2020.04.13 15:47:03 +0100:
> Hi,
>
> One thing I miss from our top(1) is the ability to see overall CPU
> utilisation at a glance (I usually scan for the idle percentage and
> invert it in my head).
>
> This diff adds a way to toggle (using `B`) CPU utilisati
Florian Obser(flor...@openbsd.org) on 2020.04.12 19:53:23 +0200:
> OK?
yes, this is probably better than having it configurable via option.
> diff --git slaacd.c slaacd.c
> index 58f15bcda37..dae2eab3434 100644
> --- slaacd.c
> +++ slaacd.c
> @@ -755,7 +755,7 @@ configure_gateway(struct imsg_conf
ok
you remove the "if (verbose > 0)" in the cms_parse_validate() case on
purpose?
Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.04.01 16:33:44 +0200:
> On Wed, Apr 01, 2020 at 01:06:21PM +0200, Claudio Jeker wrote:
> > Currently rpki-client logs missing files like this:
> >
> > rpki-client: .
Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.03.19 18:42:28 +0100:
> Move some more output functions to output.c and convert some other
> functions to a fmt_xyz() function that returns a string with the value
> instead of doing a printf(). This is mostly mechanical but please test.
>
ok
> --
I dont see that here.
Sure that you have an up-to-date tree?
And no diff in there?
Klemens Nanni(k...@openbsd.org) on 2020.03.05 23:39:20 +0100:
>
> I ran bgpd to test diffs and stumbled across what looks like simple
> disorder in the config checks.
>
> bgpd must have changed in how it orders a
Robert Scheck(rob...@fedoraproject.org) on 2020.03.06 14:02:26 +0100:
> On Fri, 06 Mar 2020, Job Snijders wrote:
> > I believe Robert is referring to this snippet of code:
> >
> >
> > https://patch-diff.githubusercontent.com/raw/kristapsdz/rpki-client/pull/21.patch
Thanks for the patch.
I co
Job Snijders(j...@openbsd.org) on 2020.03.06 17:31:13 +:
> I have a small suggestion, in some deployments I saw the convention to
> name it as following so it is clear the data came from user provided
> data rather than internal bird structures
>
> I tested Benno's patch against BIRD 1.6.6 -
Hi,
generate 3 different outputs for BIRD:
- bird v1 with IPv4 routes
- bird v1 with IPv6 routes
- bird v2
when using command line option -B.
BIRD v2 output from Robert Scheck, robert AT fedoraproject DOT org
Note that I haven't tried this with bird 1 or 2 yet ;)
comments, oks?
(benno_rpki_bir
Robert Scheck(rob...@fedoraproject.org) on 2020.03.06 14:02:26 +0100:
> On Fri, 06 Mar 2020, Job Snijders wrote:
> > I believe Robert is referring to this snippet of code:
> >
> >
> > https://patch-diff.githubusercontent.com/raw/kristapsdz/rpki-client/pull/21.patch
>
> Exactly.
Ah, i though
Robert Scheck(rob...@fedoraproject.org) on 2020.03.03 01:20:24 +0100:
> Hi,
>
> job@ suggested to move this from GitHub to tech@ list (as upstream):
>
> 1. Currently, BIRD 1.x support in rpki-client seems to be broken: As per
>BIRD upstream the "combined format" produced by rpki-client can't
ok
Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.02.14 14:06:37 +0100:
> Move and rename copy_filterset to rde_filter.c as filterset_copy.
> This way it matches the other filterset_* functions.
>
> OK?
> --
> :wq Claudio
>
> Index: bgpd.h
>
read ok
Florian Obser(flor...@openbsd.org) on 2020.02.09 10:46:34 +0100:
> Anyone? I'll commit this soon if I don't hear back, I don't think this
> is contentious.
>
> On Fri, Feb 07, 2020 at 03:59:50PM +0100, Florian Obser wrote:
> > Moving from misc to tech.
> >
> > This is effectively Ulrich'
Ingo Schwarze(schwa...@usta.de) on 2020.02.09 00:33:06 +0100:
> Hi,
>
> Jason McIntyre wrote on Sat, Feb 08, 2020 at 10:15:08PM +:
>
> > - i'm ok with adding the path to these files to a FILES section
>
> So, here is a specific patch for bgpf.conf(5) and bgpd(8) such
> that we can agree on a
ok
Florian Obser(flor...@openbsd.org) on 2020.02.07 16:49:08 +0100:
> Slightly tweaked diff by me, fixing "new sentence new line" in the man
> page.
>
> This is OK florian@ if someone wants to commit it or I can commit it
> if someone OKs it.
>
> diff --git httpd.conf.5 httpd.conf.5
> index f4ea
Lauri Tirkkonen(la...@hacktheplanet.fi) on 2020.01.29 01:31:56 +0200:
> On Tue, Jan 28 2020 18:03:19 +0100, Florian Obser wrote:
> > On Tue, Jan 28, 2020 at 09:58:40AM -0700, Todd C. Miller wrote:
> > > On Mon, 27 Jan 2020 18:29:39 -0500, Daniel Jakots wrote:
> > >
> > > > Can't you achieve what y
Bj??rn Ketelaars(bjorn.ketela...@hydroxide.nl) on 2020.01.27 20:53:52 +0100:
> Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3).
>
> Comments/OK?
reads ok benno@
> diff --git usr.sbin/snmpd/control.c usr.sbin/snmpd/control.c
> index 54b58bbb7b6..dda18c1bad5 100644
> --- usr.sbin/snmpd/
Bj??rn Ketelaars(bjorn.ketela...@hydroxide.nl) on 2020.01.27 20:52:36 +0100:
> Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3).
>
> Comments/OK?
reads ok benno@
> diff --git sbin/unwind/frontend.c sbin/unwind/frontend.c
> index b64036c4332..d2b69084db7 100644
> --- sbin/unwind/fronten
Bj??rn Ketelaars(bjorn.ketela...@hydroxide.nl) on 2020.01.27 20:53:06 +0100:
> Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3).
>
> Comments/OK?
ok benno@
> diff --git usr.sbin/bgpd/config.c usr.sbin/bgpd/config.c
> index cb43afb81fe..fc81a3efd3b 100644
> --- usr.sbin/bgpd/config.c
>
Florian Obser(flor...@openbsd.org) on 2020.01.27 19:57:41 +0100:
> On Mon, Jan 27, 2020 at 10:33:49AM -0700, Todd C. Miller wrote:
> > On Mon, 27 Jan 2020 10:05:41 +1100, Jonathan Gray wrote:
> >
> > > On Sun, Jan 26, 2020 at 11:59:33AM -0500, David Goerger wrote:
> > > > This diff teaches du(1) t
Maybe the manpage text could be better, but i'll leave that to jmc@
ok benno@
David Goerger(da...@goerger.info) on 2020.01.26 11:59:33 -0500:
> This diff teaches du(1) the -m flag, report disk usage in megabytes.
> This brings us in line with implementations in the other BSDs, Linux,
> and Illu
Remi Locherer(remi.loche...@relo.ch) on 2020.01.22 06:49:53 +0100:
> On Wed, Jan 22, 2020 at 12:56:00AM +0100, Claudio Jeker wrote:
> > On Tue, Jan 21, 2020 at 03:58:58PM +0100, Remi Locherer wrote:
> > > On Tue, Jan 21, 2020 at 01:09:30PM +0100, Denis Fondras wrote:
> > > > On Tue, Jan 21, 2020 at
chr...@openbsd.org(chr...@openbsd.org) on 2020.01.18 06:18:21 +0100:
> On Wed, Jan 15, 2020 at 12:47:28PM +0100, Sebastian Benoit wrote:
> >Christopher Zimmermann(chr...@openbsd.org) on 2020.01.15 11:55:43 +0100:
> >>Hi,
> >>
> >>as far as I can see a dua
Christopher Zimmermann(chr...@openbsd.org) on 2020.01.15 11:55:43 +0100:
> Hi,
>
> as far as I can see a dual stack carp interface does not care whether it
> receives advertisements addressed to IPv4 or IPv6. Any one will do.
> So I propose to send IPv6 advertisements only when IPv4 is not possib
Thanks for the diff, commited.
Sebastian Benoit(be...@openbsd.org) on 2020.01.14 21:14:44 +0100:
> seems sensible.
>
> ok benno@
>
>
> Tracey Emery(tra...@traceyemery.net) on 2020.01.14 13:08:03 -0700:
> > Hello,
> >
> > In the server_response fun
seems sensible.
ok benno@
Tracey Emery(tra...@traceyemery.net) on 2020.01.14 13:08:03 -0700:
> Hello,
>
> In the server_response function of httpd, the if comparison to
> srv_conf->maxrequests is using the wrong value. The value is derived from the
> first server configuration in httpd.conf, si
Alexander Bluhm(alexander.bl...@gmx.net) on 2020.01.13 18:19:31 +0100:
> On Mon, Jan 13, 2020 at 05:55:06PM +0100, Tobias Heider wrote:
> > I think we should discuss whether we can remove the flow
> > (and the -6 flag) as I constantly hear people complaining
> > that it broke their setups and I don
Theo de Raadt(dera...@openbsd.org) on 2020.01.12 12:03:40 -0700:
> Remi Locherer wrote:
>
> > On Sun, Jan 12, 2020 at 04:18:26PM +0100, Claudio Jeker wrote:
> > > On Sun, Jan 12, 2020 at 03:46:15PM +0100, Remi Locherer wrote:
> > > > On Wed, Jan 08, 2020 at 01:13:45PM +0100, Denis Fondras wrote:
nice, ok
Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.01.09 16:25:58 +0100:
> The path_hash function is called reasonably often. Calling
> SipHash24_Update() over and over for small data is not optimal.
> Inspired by /sys/sys/proc.h add a aspath_hashstart and aspath_hashend to
> the struct rde_
Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.01.09 16:05:06 +0100:
> When using 'export default-route' you still need an output filter to allow
> the default route out. I'm probably not the only one forgetting this fact
> from time to time. Now to make things worse adding the filter rule to
> al
ok
Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.01.09 13:03:13 +0100:
> On Thu, Jan 09, 2020 at 09:42:39AM +0100, Claudio Jeker wrote:
> > This diff just moves some of the code from rde.c to rde_peer.c where it
> > should be. Apart from moving the code peer_down() was modified so that it
> >
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.12.31 11:44:07 +0100:
> On Tue, Dec 31, 2019 at 11:16:37AM +0100, Martijn van Duren wrote:
> > I'm on the fence about this. So if you feel strongly about this go
> > ahead if it works.
>
> In some regard I agree but in this case I think it makes sens
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.12.30 18:35:28 +0100:
> The imsg processing in the RDE is sometimes a bit unfair. The problem is
> that peers sending many UPDATES starve out the others especially on
> intial table dumps. This comes from the fact that imsg are processed to
> completi
Alexander Bluhm(alexander.bl...@gmx.net) on 2019.12.24 23:11:12 +0100:
> Hi,
>
> Use FOREACH macro for mnt_vnodelist.
>
> ok?
ok benno@
>
> bluhm
>
> Index: nfs/nfs_subs.c
> ===
> RCS file: /data/mirror/openbsd/cvs/src/sys/nfs/nf
Denis Fondras(open...@ledeuns.net) on 2019.12.22 10:55:39 +0100:
> Rename and move calc_nexthop_clear()/calc_nexthop_add() to
> vertex_nexthop_clear()/vertex_nexthop_add()
>
> It brings ospf6d closer to ospfd.
ok
>
>
> Index: rde.h
>
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.12.20 08:24:34 +0100:
> This diff just moves most show related functions into a new file.
> It is mostly mechanical (remove function from bgpctl.c and add it to
> output.c).
>
> OK?
ok
did you check that bgplg etc still build (i dont see why they s
reads ok.
unrelated to this diff: I wonder if the manpage (of both ospfd and pspf6d)
should mention that changing fib-priority with a reload is equivalent toa
uncouple/couple?
Denis Fondras(open...@ledeuns.net) on 2019.12.15 09:56:15 +0100:
>
> Index: kroute.c
>
Remi Locherer(remi.loche...@relo.ch) on 2019.12.10 22:39:32 +0100:
> On Tue, Dec 10, 2019 at 07:05:27PM +0100, Hiltjo Posthuma wrote:
> > Hi,
> >
> > While looking at the code of ripd:
> >
> > I think there are (also) 2 small memleaks in a debug/error path
> > (IMSG_REQUEST_ADD and IMSG_RESPONSE_
David Gwynne(da...@gwynne.id.au) on 2019.12.06 15:14:42 +1000:
>
>
> > On 5 Dec 2019, at 21:14, Sebastian Benoit wrote:
> >
> > Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.12.05 09:53:49 +0100:
> >> I would suggest to just pack most of the headers into one
ok
George Brown(321.geo...@gmail.com) on 2019.12.04 18:57:17 +:
> After pledge is immediately called without the unveil promise so this
> seems redundant.
>
> diff --git a/usr.sbin/rpki-client/main.c b/usr.sbin/rpki-client/main.c
> index f05ec1c5837..53ee4223371 100644
> --- a/usr.sbin/rpki-c
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.12.05 09:53:49 +0100:
> I would suggest to just pack most of the headers into one group of ().
>
> IPv4 ttl 1 [tos 0x20] 10.0.127.15 > 10.0.127.1
> would become
> IPv4 (ttl 1 tos 0x20) 10.0.127.15 > 10.0.127.1
> and
> IPv4 ttl 1 [tos 0x20] (id 39958,
Klemens Nanni(k...@openbsd.org) on 2019.11.30 01:44:48 +0100:
> Just like on amd64 with vmctl(8), I want to be able to easily create
> disk images.
>
> ldomctl(8) currently advises to use dd(1), those files are not sparse
> either so creating big images may take a lot of time and the process
> ten
Sebastian Benoit(be...@openbsd.org) on 2019.11.26 18:46:11 +0100:
>
> remove include statement and unveil() rad.
>
> ok?
diff --git usr.sbin/rad/parse.y usr.sbin/rad/parse.y
index bb18c3d9c9c..443cff66065 100644
--- usr.sbin/rad/parse.y
+++ usr.sbin/rad/parse.y
@@ -112,7 +112,
slaacd does not have include statements
open the control socket earlier, then unveil().
diff --git sbin/slaacd/slaacd.c sbin/slaacd/slaacd.c
index 9c3f64f407d..990614df734 100644
--- sbin/slaacd/slaacd.c
+++ sbin/slaacd/slaacd.c
@@ -179,6 +179,16 @@ main(int argc, char *argv[])
if (getpwn
remove include statement and unveil() rad.
ok?
diff --git usr.sbin/rad/parse.y usr.sbin/rad/parse.y
index bb18c3d9c9c..443cff66065 100644
--- usr.sbin/rad/parse.y
+++ usr.sbin/rad/parse.y
@@ -112,7 +112,7 @@ typedef struct {
%}
-%token RA_IFACE YES NO INCLUDE ERROR
+%token RA_IFACE YES NO
Alexander Bluhm(alexander.bl...@gmx.net) on 2019.11.18 16:31:05 +0100:
> On Thu, Nov 14, 2019 at 11:14:45PM +0100, Sebastian Benoit wrote:
> > The alternative is to not allow netmask for ipv6 and only / and
> > prefixlen
> > . Why support such a crazy way of specifying the m
Alexander Bluhm(alexander.bl...@gmx.net) on 2019.11.14 22:50:50 +0100:
> Hi,
>
> While writing my ifconfig regress test I realized that IPv6 netmasks
> are parsed, but silently ignored. Ignoring commandline parameters
> feels wrong and is inconsistent to IPv4.
>
> Of course I don't expect anyone
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.11.09 15:32:39 +0100:
> On Sat, Nov 09, 2019 at 03:27:31PM +0100, Denis Fondras wrote:
> > Fix function name in error message.
> >
> > Index: kroute.c
> > ===
> > RCS file: /cvs/src/usr.
Solene Rapenne(sol...@perso.pw) on 2019.11.08 18:39:20 +0100:
> Someone on reddit had issue with this config file, there was no backup
> file, in file directory or in ~/.mg.d
>
> make-backup-files
> backup-to-home-directory
>
> in fact, having "make-backup-files" disables backups.
>
>
> I've lo
Solene Rapenne(sol...@perso.pw) on 2019.11.08 18:13:40 +0100:
> The staging api changed too. I know people who did not update that url,
> it's not especially obvious because the old url doesn't contain v01.
>
> ok ?
Nice! I actually wondered about that and my google foo was too low.
Thanks for fi
Andras Farkas(deepbluemist...@gmail.com) on 2019.10.24 13:58:26 -0400:
> Diff attached, changes bad link:
> https://man.openbsd.org/OpenBSD-6.6/acme-client.5
> to
> https://man.openbsd.org/OpenBSD-6.6/acme-client.conf.5
> on this page:
> https://www.openbsd.org/faq/upgrade66.html
>
fixed, thanks
List(l...@md5collisions.eu) on 2019.10.24 21:06:27 +0200:
> Hi,
>
> in function sr_crypto_create_keys (sys/dev/softraid_crypto.c, 489):
>
> The keydisk is masked by encrypting(1) a generated random buffer.
>
> This encrypted random buffer (keydisk) is afterwards used to encrypt(2)
> the harddisk
Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2019.10.19 16:01:45 +0200:
> On Sat, Oct 19 2019, "Theo de Raadt" wrote:
> > Jeremie Courreges-Anglas wrote:
> >
> >> On Sat, Oct 19 2019, Claudio Jeker wrote:
> >> > bgpd supports up to 255 byte shutdown communications. So the manpage is
> >> > not t
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.10.19 11:07:28 +0200:
> bgpd supports up to 255 byte shutdown communications. So the manpage is
> not telling the truth. Also I don't think it is helpful to mention the
> limit at all. bgpctl will exit with 'shutdown reason too long' if the text
> is
Alexander Bluhm(alexander.bl...@gmx.net) on 2019.10.17 16:23:32 +0200:
> Hi,
>
> I would like to fix some warings in ifconfig when compiled with
> WARNINGS=yes.
>
> - Move all prototypes and variables used in multiple .c files into
> common ifconfig.h. Basically rename brconfig.h to ifconfig.h
ok?
Index: Makefile
===
RCS file: /cvs/src/usr.sbin/sysupgrade/Makefile,v
retrieving revision 1.1
diff -u -p -r1.1 Makefile
--- Makefile25 Apr 2019 20:22:52 - 1.1
+++ Makefile1 Oct 2019 21:17:23 -
@@ -1,4 +1,4 @@
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.10.01 11:20:33 +0200:
> OK, this diff is actually what linux is going to need to be able to
> configure TCP MD5SUM on sockets. The listening socket turned out to be a
> bit more tricky since the MD5 key for each peer needs to be added to the
> socket
David Gwynne(da...@gwynne.id.au) on 2019.09.30 17:42:33 +1000:
> On Mon, Sep 30, 2019 at 06:49:14AM +0100, Jason McIntyre wrote:
> > On Mon, Sep 30, 2019 at 10:28:50AM +1000, David Gwynne wrote:
> > > i got an email recently asking how to configure the tunnel identifier
> > > on an eoip(4) interfac
ok
good idea, i might have wanted this too in the past.
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.09.26 22:29:50 +0200:
> bgpctl can show all routes under a prefix. For example
> bgpctl show rib 8/8 all
> but there was no way to do the inverse, show all routes which cover a
> certain
Tobias Heider(tobias.hei...@stusta.de) on 2019.09.25 22:34:53 +0200:
> > Your fix reads ok, but:
> >
> > please write null-pointer checks explicitly, i.e. != NULL or == NULL.
>
> Sure.
>
> > and a suggestion: how about putting a
> >
> > if (head == NULL)
> > return;
> >
> > at the top of i
Tobias Heider(tobias.hei...@stusta.de) on 2019.09.25 21:29:44 +0200:
> As the subject says this diff fixes a few leaks in the config parser.
Your fix reads ok, but:
please write null-pointer checks explicitly, i.e. != NULL or == NULL.
and a suggestion: how about putting a
if (head == NULL)
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.09.24 17:01:21 +0200:
> On Tue, Sep 24, 2019 at 03:51:43PM +0100, Stuart Henderson wrote:
> > On 2019/09/24 11:10, Claudio Jeker wrote:
> > > On Tue, Sep 24, 2019 at 10:06:51AM +0100, Stuart Henderson wrote:
> > > > On 2019/09/23 22:48, Stuart Henders
Sebastian Benoit(be...@openbsd.org) on 2019.09.20 18:06:38 +0200:
> Alexander Bluhm(alexander.bl...@gmx.net) on 2019.09.20 17:00:39 +0200:
> > Hi,
> >
> > sometimes my laptop was running out of battery while I was working.
> > To avoid that, I patched apmd(8) to w
ok benno@
Mike Larkin(mlar...@azathoth.net) on 2019.09.22 02:42:28 -0700:
> We allocate a 'pkt' for each network packet in the queue, but only were
> freeing the last one. This has always been a bug, but it looks like recent
> changes elsewhere in the network stack may have made the problem more a
Alexander Bluhm(alexander.bl...@gmx.net) on 2019.09.20 17:00:39 +0200:
> Hi,
>
> sometimes my laptop was running out of battery while I was working.
> To avoid that, I patched apmd(8) to write a emergency message to
> syslog(3). Then with this line in syslog.conf I receive a warning
> in every xt
Thanks for noticing!
Klemens Nanni(k...@openbsd.org) on 2019.09.17 22:40:10 +0200:
> On Sun, Sep 01, 2019 at 04:27:25PM +0200, Sebastian Benoit wrote:
> > This was mentioned in the upgrade guide:
> > http://www.openbsd.org/faq/upgrade64.html
> Quote:
>
> Use of the
ping
Sebastian Benoit(be...@openbsd.org) on 2019.09.01 16:27:25 +0200:
>
> Hi,
>
> in OpenBSD 6.4 and 6.5, the log options
>
> log updates
> log all
>
> are deprecated, they still work and show a warning.
>
> This was mentioned in the upgrade gu
ok
Florian Obser(flor...@openbsd.org) on 2019.09.07 09:11:36 +0200:
> On Fri, Sep 06, 2019 at 09:15:16PM +0200, Sebastian Benoit wrote:
> > Florian Obser(flor...@openbsd.org) on 2019.09.06 16:51:35 +0200:
> > > On Wed, Sep 04, 2019 at 06:07:35PM +0200, Matthieu Herrb
Florian Obser(flor...@openbsd.org) on 2019.09.06 16:51:35 +0200:
> On Wed, Sep 04, 2019 at 06:07:35PM +0200, Matthieu Herrb wrote:
> > Hi,
> >
> > I've a pair of redundant routers, which need to run rad(8) on the
> > internal interfaces.
> >
> > But using carp, on the inactive router, rad complai
Matthieu Herrb(matth...@openbsd.org) on 2019.09.04 18:07:35 +0200:
> Hi,
>
> I've a pair of redundant routers, which need to run rad(8) on the
> internal interfaces.
>
> But using carp, on the inactive router, rad complains every
> time it tries to send a RA:
>
> rad[65590]: sendmsg on carp2: C
Hi,
in OpenBSD 6.4 and 6.5, the log options
log updates
log all
are deprecated, they still work and show a warning.
This was mentioned in the upgrade guide:
http://www.openbsd.org/faq/upgrade64.html
Ok to remove the old options completly after 2 releases?
/B
diff --git usr.sbin/relayd
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.08.14 09:14:34 +0200:
> There is no reason anymore for this double wrapping of structs.
> Remove it to make the code simpler.
nice change and reads ok
/B.
> OK?
> --
> :wq Claudio
>
> Index: rde.c
> ===
Remi Locherer(remi.loche...@relo.ch) on 2019.08.11 11:37:27 +0200:
> I'd like to get a notification when a neighbor changes the src IP address
> for hello packets. Either it is a planned change or something bad happens
> in the network.
>
> OK?
ok
>
> Remi
>
>
> Index: hello.c
> =
reads ok
Remi Locherer(remi.loche...@relo.ch) on 2019.08.11 11:21:36 +0200:
> When ospfd receives a hello packet it takes the src IP address and updates
> the address in its neighbor struct for the given router id unconditionally.
>
> In the case of broadcast interfaces this is not a problem:
>
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.08.09 08:58:09 +0200:
> Yesterday I added --address support in openrsync, this was done so that
> rpki-client can pass a bind address to openrsync since in my case the
> default address selection would pick up a non routeable address (IX lan)
> for so
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.08.09 00:16:42 +0200:
> On Thu, Aug 08, 2019 at 11:06:30PM +0100, Stuart Henderson wrote:
> > On 2019/08/08 15:42, Claudio Jeker wrote:
> > > I need to be able to control the bind address for openrsync connections.
> > > This implements this but it on
Thanks, commited.
Alexander Koeppe(forma...@online.de) on 2019.07.29 17:01:02 +0200:
> Hi
>
> This is regarding nc's proxy capability.
> I've been facing an issue where as per the man-page of nc it should
> work, but effectively didn't.
>
> In my case, I launched the following and was expecting
Gilles Chehade(gil...@poolp.org) on 2019.07.23 09:06:33 +0200:
> On Tue, Jul 23, 2019 at 08:51:54AM +0200, Sebastien Marie wrote:
> > On Mon, Jul 22, 2019 at 11:26:28PM +0200, Klemens Nanni wrote:
> > > My mail is klem...@posteo.de and the provider expects this full address
> > > as username, so th
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.07.10 22:08:38 +0200:
> This diff is a bit of a monster. It changes the Adj-RIB-Out to be a peer
> specific set of RB trees instead of using a rib in the original sense.
> The reason for this is that the more peers a system has the more elements
> end
Solene Rapenne(sol...@perso.pw) on 2019.07.04 06:56:44 +0200:
> The example uses acme-v02.api.letsencrypt.org while acme-client.conf(5)
> still uses v01.
ups.
ok benno@
>
> Index: acme-client.conf.5
> ===
> RCS file: /data/cvs/src/
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.06.25 11:13:55 +0200:
> In bgpd there are a few objects that use reference counts to keep track on
> how many things point to them. Those are struct pt_entry, rde_aspath,
> rde_communities, and nexthop. The way this reference counting is done and
> es
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.06.28 09:44:35 +0200:
> It is possible that a session is going down while peer->rpending (the flag
> indicating that there is more data to process) is set. If that is
> happening the session engine is spinning until the session comes back up
> or the
Todd C. Miller(mill...@openbsd.org) on 2019.06.25 09:27:19 -0600:
> On Tue, 25 Jun 2019 09:18:28 -0600, "Todd C. Miller" wrote:
>
> > The ERRORS section could be clearer as to what error you get when
> > you try to lock a socket/fifo.
>
> Actually, for fcntl(2), we should be returning EINVAL, not
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.06.24 12:41:08 +0200:
> Hi,
>
> I think it is time to remove the bgpctl irrfilter code. It is not useful
> and it is better to use tools like bgpq3 to build as-sets and prefix-sets
> for bgpd filtering.
>
> If anyone is still using irrfilter please
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.06.22 10:30:46 +0200:
> Once again I broke mrt table dumps a bit. This time by not dumping the
sorry about that.
> community data anymore. Add this back by adding the needed code in
> rde_community.c and some other minor adjustments.
>
> With this
Hiltjo Posthuma(hil...@codemadness.org) on 2019.06.21 13:32:10 +0200:
> On Wed, Jun 12, 2019 at 06:58:31PM +0200, Hiltjo Posthuma wrote:
> > On Thu, Jun 06, 2019 at 02:14:05PM +0200, Christian Weisgerber wrote:
> > > Bj??rn Ketelaars:
> > >
> > > > Diff below is based on the latest diff from naddy
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.06.21 10:22:23 +0200:
> For a diff I'm working on I need to have a peer id that is never used.
> Because of this I changed the way we allocate peer ids a little bit by
> introducing a few defines and using them instead.
>
> OK?
read ok.
> --
> :wq
ok
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.06.20 18:53:04 +0200:
> prefix_add() is only called by path_update() and path_update already
> knows if the prefix exists or not (by calling prefix_get()). So doing
> the same check again in prefix_add() is silly and actually rather
> expensive wi
201 - 300 of 763 matches
Mail list logo
