Re: fec(4) mii_tick

2016-09-21 Thread Mike Belopuhov
On 21 September 2016 at 13:22, Mark Kettenis wrote: > Here is the promised diff that makes fec(4) call mii_tick() like all > our other ethernet drivers that use mii do. > > Does this fix your problem Philip? > > Looks good to me. OK mikeb if this works for Philip.

Re: fec(4) cleanup

2016-09-21 Thread Mike Belopuhov
On 21 September 2016 at 10:15, Mark Kettenis wrote: > Diff below removes nused code from the driver and makes sure we only > enable the tx and rx interrupts. This seems to work fine for me. > Next step will be to add the missing PHY tick stuff. > > ok? > OK mikeb. I was going to send a diff lik

Re: bluhm's splsoftassert

2016-09-20 Thread Mike Belopuhov
On Tue, Sep 20, 2016 at 17:20 +0200, Martin Pieuchot wrote: > On 20/09/16(Tue) 17:04, Mike Belopuhov wrote: > > On Tue, Sep 20, 2016 at 10:51 -0400, David Hill wrote: > > > On Tue, Sep 20, 2016 at 09:53:02AM -0400, David Hill wrote: > > > > More... > > >

Re: bluhm's splsoftassert

2016-09-20 Thread Mike Belopuhov
On 20 September 2016 at 17:09, Martin Pieuchot wrote: > On 20/09/16(Tue) 10:51, David Hill wrote: >> On Tue, Sep 20, 2016 at 09:53:02AM -0400, David Hill wrote: >> > More... >> > >> > splassert: sorwakeup: want 5 have 0 >> > Starting stack trace... >> > splassert_check() at splassert_check+0x78 >>

Re: bluhm's splsoftassert

2016-09-20 Thread Mike Belopuhov
On Tue, Sep 20, 2016 at 10:51 -0400, David Hill wrote: > On Tue, Sep 20, 2016 at 09:53:02AM -0400, David Hill wrote: > > More... > > > > splassert: sorwakeup: want 5 have 0 > > Starting stack trace... > > splassert_check() at splassert_check+0x78 > > sorwakeup() at sorwakeup+0x27 > > route_input()

Re: bluhm's splsoftassert

2016-09-20 Thread Mike Belopuhov
On 20 September 2016 at 16:50, Martin Pieuchot wrote: > On 20/09/16(Tue) 16:37, Alexander Bluhm wrote: >> On Tue, Sep 20, 2016 at 04:17:37PM +0200, Mike Belopuhov wrote: >> > Can we assert that *_usrreq is always called under splsoftnet? >> >> I think that is the

Re: bluhm's splsoftassert

2016-09-20 Thread Mike Belopuhov
On 20 September 2016 at 15:55, Alexander Bluhm wrote: > On Tue, Sep 20, 2016 at 08:21:55AM -0400, David Hill wrote: >> With bluhm's r1.160 uipc_socket.c. > > With splsoftnet() in soshutdown() I can fix this one. > > splassert: sowwakeup: want 5 have 0 > Starting stack trace... > splassert_check()

Re: bluhm's splsoftassert

2016-09-20 Thread Mike Belopuhov
On Tue, Sep 20, 2016 at 09:19 -0400, David Hill wrote: > Another... > > splassert: sorwakeup: want 5 have 4 > Starting stack trace... > splassert_check() at splassert_check+0x78 > sorwakeup() at sorwakeup+0x27 > pfkey_sendup() at pfkey_sendup+0x99 > pfkeyv2_sendmessage() at pfkeyv2_sendmessage+0x2

Re: bluhm's splsoftassert

2016-09-20 Thread Mike Belopuhov
On 20 September 2016 at 15:16, Alexander Bluhm wrote: > On Tue, Sep 20, 2016 at 08:21:55AM -0400, David Hill wrote: >> With bluhm's r1.160 uipc_socket.c. >> Here are the first ones that were detected. > > Thanks for the fast report. > > So fifo works around the socket layer. Better call soconnect

Re: timeout_set_proc(9)

2016-09-19 Thread Mike Belopuhov
On 19 September 2016 at 11:06, Martin Pieuchot wrote: > On 19/09/16(Mon) 13:47, David Gwynne wrote: >> [...] >> id rather not grow the timeout (or task for that matter) apis just >> yet. theyre nice and straightforward to read and understand so far. > > So better introduce a new API, right? > >> f

Re: Manpage for uctuctl(4)

2016-09-18 Thread Mike Belopuhov
On Sun, Sep 18, 2016 at 06:15 +, Visa Hankala wrote: > On Sat, Sep 17, 2016 at 02:40:09PM +0100, Rafael Neves wrote: > > Hi, > > > > Here follows a manpage for octuctl(4), based on dwctwo(4) manpage. > > I am not sure if the title should stop in Controller or in Interface, > > so I mantained

Re: Remove ip6_pcbopts

2016-09-14 Thread Mike Belopuhov
On 14 September 2016 at 17:53, Jeremie Courreges-Anglas wrote: > > Dead since the IPV6_PKTOPTIONS socket option was removed. > > ok? > > Sure.

Re: Fix an infinite loop in iked

2016-09-13 Thread Mike Belopuhov
On 10 September 2016 at 08:42, Nikolay Edigaryev wrote: > This fixes a bug introduced in revision 1.8 of timer.c that causes > evtimer_set() to be called on an already active event, which is an error > according to event_add(3): > >>The event in the ev argument must be already initialized by event

Re: Heads up to Xen users following -current

2016-09-12 Thread Mike Belopuhov
On 29 August 2016 at 19:10, Mike Belopuhov wrote: > Due to a recent change in -current the socket sending routine > has started producing small data packets crossing memory page > boundary. This is not supported by Xen and kernels with this > change will experience broken bulk

Re: Fix Wacom Intuos S 2 descriptor and make wsmouse work

2016-09-11 Thread Mike Burns
On 2016-09-11 16.14.44 +0200, Frank Groeneveld wrote: > I've also made some progress regarding the scaling bug. It seems the > device is not properly detached from Xorg when it is unplugged, because > the log starts getting spammed with loads of messages like this: > > [ 202.482] (EE) ws: wacom:

Re: subr_tree for netinet/ip_ipsp.[ch]

2016-09-06 Thread Mike Belopuhov
On Sep 6, 2016 07:07, "David Gwynne" wrote: > > this gives us back 5k on amd64. > > ok? > I can't test this ATM, but I endorse the idea. The diff looks good to me.

Re: Watchdog and ifp detach races

2016-09-04 Thread Mike Belopuhov
On 4 September 2016 at 17:43, Martin Pieuchot wrote: > Thanks to awolk@ hacking on USB wireless we found a lot of new races in > the network stack. > > Passing and ``ifp'' pointer to a task is *not* safe. If the task > sleeps, then another thread my start executing if_detach() freeing the > memor

Re: removing expired once rules in pf_purge_thread()

2016-09-03 Thread Mike Belopuhov
On 3 September 2016 at 18:03, Alexandr Nedvedicky wrote: > Hello, > > there was still one more glitch catched by mikeb: > > I have to sanitize pointer when copying rule to userland. > > The other thing pointed out by mike is the Expired time should > be printed for exp

Re: pfctl mixes up anchorname with anchorpath

2016-09-03 Thread Mike Belopuhov
On 3 September 2016 at 18:49, Alexandr Nedvedicky wrote: > Hello, > > mikeb pointed out I should not be copy'n'pasting buggy code. > I'm just re-sending updated patch with change below: > OK mikeb

Re: NAT-on-enc on iked(8)

2016-09-02 Thread Mike Belopuhov
On 1 September 2016 at 13:35, Vincent Gross wrote: > This diff adds the missing bits to support NAT-on-enc in iked(8). > > See OUTGOING NETWORK ADDRESS TRANSLATION in iked.conf(5), and also > http://undeadly.org/cgi?action=article&sid=20090127205841. > > Ok ? > OK mikeb

Re: Diff: Fix wrong bzero call in snmpd

2016-09-02 Thread Mike Belopuhov
On Fri, Sep 02, 2016 at 16:56 +0200, Jan Klemkow wrote: > Hi, > > When a new IP address shows up on an interface, the function > if_newaddr() save this IP address and its mask and boardcast address > into a data structure. If the corresponding IP mask or broad cast > address is not set, their dat

Re: Drop IPSec traffic that should be encapsulated but is not

2016-09-02 Thread Mike Belopuhov
On 1 September 2016 at 10:31, Vincent Gross wrote: > Our IPSec stack rejects UDP-encapsulated traffic using a non > encapsulating SA, but not the other way around. This diff adds > the missing check and the corresponding stat counter. > > Ok ? > Go for it. OK mikeb

Re: vmd: cleaning up virtio.c

2016-08-31 Thread Mike Larkin
On Wed, Aug 31, 2016 at 06:04:22AM -0600, nayden wrote: > Addressing "this function needs a cleanup block, lots of free(blah); return > (0)" > comment for vioblk_notifyq() and doing the same for vionet_enq_rx(). > go for it, thanks. > Index: virtio.c > =

Re: Undefined behaviour in subr_hibernate.c

2016-08-31 Thread Mike Larkin
On Wed, Aug 31, 2016 at 10:47:50AM +0200, Michal Mazurek wrote: > Section "J.2 Undefined behavior" of n1570 includes: > * Pointers that do not point to the same aggregate or union (nor just > beyond the same array object) are compared using relational > operators (6.5.8). > > I think that's wh

Re: Heads up to Xen users following -current

2016-08-30 Thread Mike Belopuhov
On Aug 30, 2016 10:56 AM, "Claudio Jeker" wrote: > > On Tue, Aug 30, 2016 at 10:48:53AM +0200, Mike Belopuhov wrote: > > On Tue, Aug 30, 2016 at 08:31 +0200, Mark Kettenis wrote: > > > > Date: Tue, 30 Aug 2016 07:48:09 +0200 > > > > From: Mike Belopuh

Re: Heads up to Xen users following -current

2016-08-30 Thread Mike Belopuhov
On Tue, Aug 30, 2016 at 08:31 +0200, Mark Kettenis wrote: > > Date: Tue, 30 Aug 2016 07:48:09 +0200 > > From: Mike Belopuhov > > > > On Tue, Aug 30, 2016 at 09:58 +1000, David Gwynne wrote: > > > On Mon, Aug 29, 2016 at 08:30:37PM +0200, Alexander Bluhm wrote: &

Re: Heads up to Xen users following -current

2016-08-29 Thread Mike Belopuhov
On Tue, Aug 30, 2016 at 09:58 +1000, David Gwynne wrote: > On Mon, Aug 29, 2016 at 08:30:37PM +0200, Alexander Bluhm wrote: > > On Mon, Aug 29, 2016 at 07:10:48PM +0200, Mike Belopuhov wrote: > > > Due to a recent change in -current the socket sending routine > > > has s

Heads up to Xen users following -current

2016-08-29 Thread Mike Belopuhov
Due to a recent change in -current the socket sending routine has started producing small data packets crossing memory page boundary. This is not supported by Xen and kernels with this change will experience broken bulk TCP transmit behaviour. We're working on fixing it. Cheers, Mike

Re: [PATCH] [0/1] pf refactoring

2016-08-20 Thread Mike Belopuhov
On 19 August 2016 at 16:34, Richard Procter wrote: > Hi Mike, > > On Fri, 19 Aug 2016, Mike Belopuhov wrote: > >> I've looked through it and couldn't find anything wrong with it. > > Thanks. > >> I do however find pacthing of values in pf_translate_icmp

Re: [PATCH] [1/1] pf refactoring

2016-08-19 Thread Mike Belopuhov
On 19 August 2016 at 11:49, Richard Procter wrote: > > The final patch in the pf series. Will commit when I do the previous one > in around 24 hours unless there are objections. > > > - pushes the 'field changed' guards into the 'change field' functions. > This lets us normalise many of the existi

Re: [PATCH] [0/1] pf refactoring

2016-08-19 Thread Mike Belopuhov
On 19 August 2016 at 11:33, Richard Procter wrote: > Hi, > > I've reduced the pf refactor (phase two) to two patches, which I'll be > committing in 24 hours or so unless there are any objections. > > I'm confident it won't, but supposing post-commit these have in > fact blown up, my first suspect

Re: [PATCH] fix mbuf leak in uicp_usrreq.c

2016-08-17 Thread Mike Belopuhov
On 17 August 2016 at 10:01, Simon Mages wrote: > Hi, > > while i was debugging dlg@'s diff regarding the bigger mbuf clusters i > stumbled > across a bug in the PRU_SEND case in uicp_usrreq.c. > > There is a call to sbappendcontrol which can fail, but there is no > error handling done. > If sbapp

Re: rwlock physlock mem.c

2016-08-15 Thread Mike Larkin
On Mon, Aug 15, 2016 at 06:10:55PM -0400, Ted Unangst wrote: > same change as for i386, but now for arm and sparcs. > ok mlarkin > Index: arm/arm/mem.c > === > RCS file: /cvs/src/sys/arch/arm/arm/mem.c,v > retrieving revision 1.16 >

Re: grab global lock during acpi_powerdown

2016-08-05 Thread Mike Larkin
t; probably cause hangs on some machines. > > I don't think that XXX is a big issue by the way. By the time > acpi_powerdown() runs we've halted the secondary CPUs and are running > on the primary CPU anyway. As long as the acpi_powerdown() doesn't > sleep, the acpi t

Re: quiet legacy drivers on amd64

2016-08-05 Thread Mike Larkin
On Mon, Aug 01, 2016 at 04:14:54PM -0500, joshua stein wrote: > are these complaints really helpful on modern machines? > > Please do not DEBUG these. They are useful for me when testing vmm, since presently I have neither the nvram or clock laid out right. We can remove these once I get the mc1

Re: amd64 mem.c comments

2016-07-27 Thread Mike Larkin
On Wed, Jul 27, 2016 at 11:35:13AM -0400, Ted Unangst wrote: > nothing much to change here, but the comments can be improved. > everybody knows what /dev/null is, just call it that instead of rathole. > if not already committed, ok mlarkin > Index: mem.c > ===

Re: Hyper-V protection fault trap on i386 with 5.9

2016-07-26 Thread Mike Larkin
On Mon, Jul 25, 2016 at 10:59:45AM +0200, Franco Fichtner wrote: > > > On 22 Jul 2016, at 7:58 PM, Mike Larkin wrote: > > > > What is your Hyper-V server host environment? Server 2012 R2? And I > > need a full dmesg from when this worked, please. > > It's

Re: Hyper-V protection fault trap on i386 with 5.9

2016-07-22 Thread Mike Larkin
On Fri, Jul 22, 2016 at 03:26:01PM +0200, Franco Fichtner wrote: > Hi, > > With a client we're running into the following boot panic > since upgrading from 5.7 to 5.9 on a specific Hyper-V guest: > > cpu0: Intel(R) Xeon(R) CPU E5420 @ 2.50GHz ("GenuineIntel" 686-class) 1.65 GHz > cpu0: > FPU,V86

Re: tcp output mbuf leak

2016-07-19 Thread Mike Belopuhov
On 19 July 2016 at 23:00, Alexander Bluhm wrote: > Hi, > > When looking at the error paths in tcp_output() I have found these > returns that look like mbuf leaks. > > ok? > > bluhm > looks correct indeed. ok mikeb

Re: Race in ARP

2016-07-13 Thread Mike Belopuhov
On 12 July 2016 at 10:45, Martin Pieuchot wrote: > dlg@ could reproduce a panic by running dhclient in a loop on one of his > machines. > > Turns out that there's a race between arplookup() and arpcache() inside > in_arpinput(). If another CPU removes the ARP entry from the table, via > RTM_DELET

Re: rwlock for sblock

2016-06-27 Thread Mike Belopuhov
On Mon, Jun 27, 2016 at 15:32 -0400, Ted Unangst wrote: > Mike Belopuhov wrote: > > On Thu, Jun 23, 2016 at 12:44 -0400, Ted Unangst wrote: > > > Instead of using the old flags and tsleep style lock, switch to rwlock in > > > sblock. That's what it's for. M

Re: rwlock for sblock

2016-06-27 Thread Mike Belopuhov
On Thu, Jun 23, 2016 at 12:44 -0400, Ted Unangst wrote: > Instead of using the old flags and tsleep style lock, switch to rwlock in > sblock. That's what it's for. More legible, and as a bonus, MP safer. > RW_NOSLEEP returns EBUSY if it has to wait, however old sblock macro would return EWOULDBLOC

Re: pf divert port reuse

2016-06-23 Thread Mike Belopuhov
On Thu, Jun 23, 2016 at 00:38 +0200, Alexander Bluhm wrote: > On Wed, Jun 22, 2016 at 08:15:09PM +0200, Mike Belopuhov wrote: > > Can you or benno test NAT64 with this change? > > In case of weird behavior do this: > > > > int sidx = pd->af == pd->naf ? pd->si

Re: pf divert port reuse

2016-06-21 Thread Mike Belopuhov
On Tue, Jun 21, 2016 at 16:08 +0200, Alexander Bluhm wrote: > On Tue, Jun 21, 2016 at 02:45:42PM +0200, Mike Belopuhov wrote: > > You're testing the sequence number > > of the new state with an existing one which has seen some > > traffic.. Are you sure this is correct?

Re: pf.conf macro with space

2016-06-21 Thread Mike Belopuhov
On 21 June 2016 at 14:57, Sebastian Benoit wrote: > Henning Brauer(hb-openbsdt...@ml.bsws.de) on 2016.06.21 13:11:16 +0200: >> * Stefan Sperling [2016-06-21 11:15]: >> > Generally, I would appreciate more detailed error messages from the pf.conf >> > parser. I recall several occasions where pfctl

Re: pf divert port reuse

2016-06-21 Thread Mike Belopuhov
On 21 June 2016 at 14:00, Alexander Bluhm wrote: > On Tue, Jun 21, 2016 at 11:24:14AM +0200, Mike Belopuhov wrote: >> So pf reused the port while some TCP segments were still in flight? > > No. The old state was in FIN_WAIT_2 and the socket in TIME_WAIT. Ah indeed, but hold on.

Re: ppp_compressors

2016-06-21 Thread Mike Belopuhov
On 21 June 2016 at 13:43, Jeremie Courreges-Anglas wrote: > > We don't support modules, so no need to reserve space for additional PPP > compression methods. > > ok? > Sure.

Re: pf divert port reuse

2016-06-21 Thread Mike Belopuhov
On 21 June 2016 at 00:14, Alexander Bluhm wrote: > Hi, > > I have seen a problem with pf divert when the dynamic port in a nat > rule got reused. The function pf_state_key_attach() reused the > state as it was in TCPS_FIN_WAIT_2. The corresponding socket was > not reused, as the the TCPS_TIME_WA

Re: af-to on pass out should be a parser error

2016-06-19 Thread Mike Belopuhov
On Mon, Jun 20, 2016 at 00:27 +0200, Sebastian Benoit wrote: > Mike Belopuhov(m...@belopuhov.com) on 2016.06.20 00:11:03 +0200: > > On Sun, Jun 19, 2016 at 23:43 +0200, Sebastian Benoit wrote: > > > manpage documents that af-to does not work on pass out rules, but the > >

Re: af-to on pass out should be a parser error

2016-06-19 Thread Mike Belopuhov
On Sun, Jun 19, 2016 at 23:43 +0200, Sebastian Benoit wrote: > manpage documents that af-to does not work on pass out rules, but the > pf.conf parser allows it, which leads a non working configuration being > loaded. > > this changes the parser to make pass out .. af-to an error. > > ok? > forg

Re: af-to on pass out should be a parser error

2016-06-19 Thread Mike Belopuhov
On Sun, Jun 19, 2016 at 23:43 +0200, Sebastian Benoit wrote: > manpage documents that af-to does not work on pass out rules, but the > pf.conf parser allows it, which leads a non working configuration being > loaded. > > this changes the parser to make pass out .. af-to an error. > what happens i

Re: enable FN_KEY_{SUSPEND,HIBERNATE} in acpitoshiba(4)

2016-06-15 Thread Mike Larkin
On Thu, Jun 16, 2016 at 12:53:24AM +0200, Giovanni Bechis wrote: > On Wed, Jun 15, 2016 at 03:49:46PM -0700, Mike Larkin wrote: > > On Thu, Jun 16, 2016 at 12:05:51AM +0200, Giovanni Bechis wrote: > > > Hi, > > > this diff enables suspend and hibernate through fn key

Re: enable FN_KEY_{SUSPEND,HIBERNATE} in acpitoshiba(4)

2016-06-15 Thread Mike Larkin
On Thu, Jun 16, 2016 at 12:05:51AM +0200, Giovanni Bechis wrote: > Hi, > this diff enables suspend and hibernate through fn keys in Toshiba laptops. > Comments ? Ok ? > Cheers > Giovanni If you fix your spelling mistake for "Hibernate" correctly below, sure. -ml > Index: acpitoshiba.c > =

Re: Set prio when bypassing pf(4)

2016-06-08 Thread Mike Belopuhov
On Mon, Jun 06, 2016 at 23:52 +0200, Vincent Gross wrote: > On Mon, 6 Jun 2016 17:33:36 +0100 > Stuart Henderson wrote: > > > On 2016/06/06 16:15, Vincent Gross wrote: > > > When sending ARP requests, or when writing to a bpf handle (as when > > > sending DHCP Discover), we bypass pf(4) so we hav

Re: Set prio when bypassing pf(4)

2016-06-08 Thread Mike Belopuhov
On Tue, Jun 07, 2016 at 22:02 +0100, Stuart Henderson wrote: > On 2016/06/07 21:49, Vincent Gross wrote: > > > > It's how henning@ set things up when integrating the new queuing mechanism. > > http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_mbuf.c#rev1.160 > > > > > Is there any use fo

Re: wifind(8) find your wifi

2016-06-02 Thread Mike Belopuhov
On 3 June 2016 at 00:17, Gleydson Soares wrote: > I usually just use a small script that lives in ~/bin > It's a great name, though. > cat ~/bin/wifi > > #!/bin/sh > > if [[ $1 == "home" ]]; then > doas ifconfig run0 nwid foonet wpa wpakey ultrasecret > doas dhclient run0 > fi >

Re: iked: fix ipv6 address pool assignment

2016-06-01 Thread Mike Belopuhov
On 1 June 2016 at 17:46, Patrick Wildt wrote: > On Wed, Jun 01, 2016 at 03:47:45PM +0200, Mike Belopuhov wrote: >> On 1 June 2016 at 13:33, Patrick Wildt wrote: >> > Hi, >> > >> > The IPv6 address assignment was basically copied from the IPv4 >> >

Re: iked: fix ipv6 address pool assignment

2016-06-01 Thread Mike Belopuhov
On 1 June 2016 at 13:33, Patrick Wildt wrote: > Hi, > > The IPv6 address assignment was basically copied from the IPv4 > code. Instead of working on the last 32-bits, it actually worked > on the fourth byte. Thus it modified the network bits instead of > the host bits. > > This diff fixes the co

Re: iked: address pools for both families

2016-06-01 Thread Mike Belopuhov
On 1 June 2016 at 10:16, Patrick Wildt wrote: > Hi, > > Currently there is only one address pool which is either v4 or v6. > This means that we cannot have dual-stack VPNs via iked. Clients > then might tunnel all IPv4 traffic, but IPv6 traffic is still using > the non-encrypted default route, wh

Re: iked: fix iked_cp_fixaddr()

2016-06-01 Thread Mike Belopuhov
On 1 June 2016 at 09:56, Patrick Wildt wrote: > Hi, > > iked_cp_fixaddr() is called to replace unspecified (e.g. 0.0.0.0) > addresses by specified (e.g. 192.0.2.1) ones. The function should > return if the address is already set. The check is wrong for the > IPv6 case, as it returns if it's not

Re: pppoe(4) vlan priorities

2016-05-30 Thread Mike Belopuhov
On 30 May 2016 at 20:15, Stuart Henderson wrote: > On 2016/05/30 19:26, Daniel Gillen wrote: >> Just tested your patch on my 5.9-stable amd64 gateway. >> >> Setting SPPP_CTL_PRIO to 1 and adding "match out on pppoe0 set prio 1" >> to /etc/pf.conf solves my issues. > > Thanks for testing. > >> The

Re: utvfu driver port

2016-05-27 Thread Mike Belopuhov
On Thu, May 26, 2016 at 16:09 -0700, patrick keshishian wrote: > Hi, > > Included is my initial effort to port the dual-licensed driver > for Fushicai Audio-Video Grabber (vendor 0x1b71 product 0x3002). > > As I mentioned in previous email it is "mostly working". I have > tested it on amd64 and m

Re: New 12" Retina Macbook (Macbook9,1)

2016-05-18 Thread Mike Larkin
On Wed, May 18, 2016 at 09:32:55AM -0500, joshua stein wrote: > On Wed, 18 May 2016 at 09:33:36 -0400, Bryan C. Everly wrote: > > 2. The keyboard works at the boot prompt, but does not work once the > > install/upgrade/shell prompt comes up > > The keyboard and trackpad appear to be connected ove

Re: remove special vlan ioctls in ifconfig

2016-05-17 Thread Mike Belopuhov
On 17 May 2016 at 02:56, David Gwynne wrote: > the vlan ioctls have been superseded by the generic ifparent and > vnetid ioctls, and will eventually go away. > > this removes the vlan ioctl handling from ifconfig. however, to > continue to support existing vlan interface configuration files > (/et

Re: vmctl: move some validations in start_vm()

2016-05-10 Thread Mike Larkin
On Sun, May 08, 2016 at 07:27:13PM +, Fabien Siron wrote: > Hi everyone, > > The following patch moves all the validations of the start command in > start_vm() as suggested in the comment. > > Index: main.c > === > RCS file: /cvs

Re: MSI-X support

2016-05-04 Thread Mike Belopuhov
On Tue, May 03, 2016 at 21:40 +0200, Mark Kettenis wrote: > Today mpi@ reminded me that I had written support for MSI-X some time > ago. Since he is interested in using multiple vectors, I extended the > code I had a bit to support that feature as well. This introduces a > new function: > > int

Re: MSI-X support

2016-05-04 Thread Mike Larkin
On Wed, May 04, 2016 at 04:01:54PM +0200, Mike Belopuhov wrote: > On Tue, May 03, 2016 at 21:40 +0200, Mark Kettenis wrote: > > Today mpi@ reminded me that I had written support for MSI-X some time > > ago. Since he is interested in using multiple vectors, I extended the > >

Re: vm.conf.5 - number of sections

2016-05-04 Thread Mike Larkin
On Wed, May 04, 2016 at 02:21:50PM +0200, Michal Mazurek wrote: > It seems that there are only two sections. It looks like this mistake > was introduced when copying a different .conf.5 file to use as a template. > > Index: usr.sbin/vmd/vm.conf.5 > =

Re: FW: Re: watchdog suport for new hardware

2016-05-04 Thread Mike Larkin
to attach this device ala acpisony or acpidock - see sys/dev/acpi/acpi.c around line 1080 or so for an example. In that case match the containing node instead. PS - moving this discussion to tech@, where it belongs. -ml > On Tue, May 3, 2016 at 5:29 PM, Mike Larkin wrote: > > On

Re: MSI-X support

2016-05-04 Thread Mike Larkin
On Wed, May 04, 2016 at 08:50:53AM +0200, Mark Kettenis wrote: > > Date: Tue, 3 May 2016 15:23:07 -0700 > > From: Mike Larkin > > > > On Tue, May 03, 2016 at 09:40:28PM +0200, Mark Kettenis wrote: > > > Today mpi@ reminded me that I had written support for MSI-X

Re: MSI-X support

2016-05-03 Thread Mike Larkin
On Tue, May 03, 2016 at 09:40:28PM +0200, Mark Kettenis wrote: > Today mpi@ reminded me that I had written support for MSI-X some time > ago. Since he is interested in using multiple vectors, I extended the > code I had a bit to support that feature as well. This introduces a > new function: > >

Re: Keyboard resume (zzz) diff

2016-04-21 Thread Mike Larkin
On Fri, Apr 22, 2016 at 12:12:58AM +0200, si...@slackware.it wrote: > - Original Message - > > Considering you don't even have a pckbd, I think this is not likely caused > > by the pckbd zzz diff committed last week. > AH! Good to know :D > > > If you want to be sure, revert that single c

Re: Keyboard resume (zzz) diff

2016-04-21 Thread Mike Larkin
On Thu, Apr 21, 2016 at 07:29:56PM +0200, si...@slackware.it wrote: > Coming late to the party for a negative report: OpenBSD 5.9-current on a > MacBookAir5,2 is suspending and hibernating OK but on resuming the keyboard > is not working correctly any more, it used to work fine on OpenBSD > 5.9-

Re: Vaio Pro 11" SVP112A1CL can't suspend to ram or hibernate

2016-04-20 Thread Mike Larkin
On Sat, Feb 20, 2016 at 10:42:02PM +0100, Mark Kettenis wrote: > > Date: Sat, 20 Feb 2016 11:32:15 -0800 > > From: Mike Larkin > > > > On Sat, Feb 20, 2016 at 10:04:28AM +0100, Mark Kettenis wrote: > > > > From: Noth > > > > Date: Sat, 20 Feb 201

Re: patch: acpitz: active cooling and notify 0x81

2016-04-19 Thread Mike Larkin
On Tue, Apr 19, 2016 at 11:18:33AM +0200, Sebastien Marie wrote: > Hi, > > As I got some feedback for this old thread, I would like to ressurect it > and ask for wider testing: does your fans still works correctly with the > patch ? > > I personnally ran with it since September 2014. > > > The

Re: Kill ipforward_rt

2016-04-19 Thread Mike Belopuhov
On 19 April 2016 at 11:06, Martin Pieuchot wrote: > This single cached route is a nice trick for having higher forwarding > numbers w/ benchmarks. But as soon as you start forwarding packets to > different end addresses, even using a single next hop, it becomes > useless. > > Since this single ca

Re: Fewer ip{_6,}forwart_rt

2016-04-18 Thread Mike Belopuhov
On 18 April 2016 at 15:40, Martin Pieuchot wrote: > On 18/04/16(Mon) 12:30, Mike Belopuhov wrote: >> On Mon, Apr 11, 2016 at 15:29 +0200, Martin Pieuchot wrote: >> > Instead of rtfree(9)ing the cached route after using it, if it is a >> > multipath one, f

Re: Fewer ip{_6,}forwart_rt

2016-04-18 Thread Mike Belopuhov
On Mon, Apr 11, 2016 at 15:29 +0200, Martin Pieuchot wrote: > Instead of rtfree(9)ing the cached route after using it, if it is a > multipath one, free it before. > > Ok? > This changes the case where ipforward_rt.ro_rt is NULL and the route that we allocate is RTF_MPATH (is that possible?). Befo

Re: less handrolled mbuf freeing code in uipc_mbuf.c

2016-04-15 Thread Mike Belopuhov
On 15 April 2016 at 07:35, David Gwynne wrote: > m_freem checks for NULL so the caller doesnt have to. > > ml_purge and m_purge were invented after some of the mq and ml code > was written, so fix that code to use the "new" functions. > > ok? > OK mikeb

Re: Fix for RDPMC on KVM OpenBSD guests

2016-04-13 Thread Mike Belopuhov
On 13 April 2016 at 15:26, Mike Larkin wrote: > The Intel SDM is a little unclear as to precisely how to check for the > presence > of the general purpose architectural performance monitoring counters (via the > 'rdpmc' instruction). In one place in the manual, it describe

Fix for RDPMC on KVM OpenBSD guests

2016-04-13 Thread Mike Larkin
The Intel SDM is a little unclear as to precisely how to check for the presence of the general purpose architectural performance monitoring counters (via the 'rdpmc' instruction). In one place in the manual, it describes capabilities based on cpu family (using family names like "Intel Core Duo, In

Re: Kill in_rtaddr()

2016-04-13 Thread Mike Belopuhov
On Mon, Apr 11, 2016 at 15:17 +0200, Martin Pieuchot wrote: > ``ipforward_rt'' is going away but rather than sending a big diff, > here's the first step. > > This diff replaces in_rtaddr() by rtalloc(9). Note that since the code > here is interested in rt_ifa it has to call rtisvalid(9) to preven

Re: pledge pstat

2016-04-12 Thread Mike Belopuhov
On 12 April 2016 at 22:25, Rob Pierce wrote: > Hoist sysct and kvm calls, and pledge stdio, rpath, vminfo. > > Rob > Please make sure that "pstat -d" still works. It's about the most useful thing it can do.

Re: manual section search order

2016-04-12 Thread Mike Belopuhov
On 12 April 2016 at 21:49, Theo Buehler wrote: > On Tue, Apr 12, 2016 at 03:37:42PM -0400, Ted Unangst wrote: >> Marc Espie wrote: >> > Parentheses are okay in urls, so I see no reason why: >> > >> > man.openbsd.org/carp(4) >> > >> > shouldn't work. >> >> There are an astounding number of text to

Re: manual section search order

2016-04-12 Thread Mike Belopuhov
On Tue, Apr 12, 2016 at 20:27 +0200, Ingo Schwarze wrote: > Hi Mike, > > Mike Belopuhov wrote on Tue, Apr 12, 2016 at 08:01:23PM +0200: > > > IMO it's a very bad idea to hardcode "3p/" like that. > > Aren't there packages using other funny section na

Re: pppoe(4): relax ifconfig command sequence requirements

2016-04-12 Thread Mike Belopuhov
On Wed, Apr 06, 2016 at 12:15 +0200, Mike Belopuhov wrote: > Hi, > > The EBUSY hack that I'm removing imposes an order on the ifconfig > commands issued against the pppoe interface used to configure the > sppp layer below. Right now ifconfig will fail with "

Re: manual section search order

2016-04-12 Thread Mike Belopuhov
On Tue, Apr 12, 2016 at 19:14 +0200, Ingo Schwarze wrote: > [moved to tech@, source-changes is not ideal for discussions] > > Marc Espie wrote on Tue, Apr 12, 2016 at 03:44:34PM +0200: > > On Tue, Apr 12, 2016 at 11:24:40PM +1000, Jonathan Gray wrote: > >> On Tue, Apr 12, 2016 at 02:36:09PM +0200,

Re: mpsafe aesni

2016-04-12 Thread Mike Belopuhov
On 26 March 2016 at 16:25, Mike Belopuhov wrote: > On Fri, Mar 25, 2016 at 22:43 +0100, Mark Kettenis wrote: >> > From: Mike Belopuhov >> > Date: Thu, 24 Mar 2016 21:33:25 +0100 >> > >> > On 24 March 2016 at 20:53, Mark Kettenis wrote: >> > >

Re: Spurious serial console interrupts

2016-04-12 Thread Mike Belopuhov
On 12 April 2016 at 15:12, Visa Hankala wrote: > On Fri, Apr 08, 2016 at 12:16:03PM +, Visa Hankala wrote: >> Every now and then I see "spurious interrupt 34" messages on octeon >> serial console. The root cause seems to be in comstart() which enables >> the TX holding register empty interrupt

Re: net80211: with more if_start()/if_enqueue()!

2016-04-12 Thread Mike Belopuhov
On 12 April 2016 at 08:34, Martin Pieuchot wrote: > As reported by jsg@ the wifi stack should use if_start() just like the > rest of the kernel. One of the patterns can even be converted to > if_enqueue(). > > Tested with: > iwn0 at pci2 dev 0 function 0 "Intel Centrino Advanced-N 6205" rev 0x3

Re: Keyboard resume (zzz) diff

2016-04-11 Thread Mike Larkin
On Tue, Apr 12, 2016 at 06:24:10AM +, Miod Vallat wrote: > > wskbd_enable (calls pckbd_enable) does not appear to be called from > > wskbd_activate, perhaps just calling wskbd_enable from there would be > > better? (as a matter of fact, wskbd_activate doesn't really do much at > > all except se

Re: Keyboard resume (zzz) diff

2016-04-11 Thread Mike Larkin
On Mon, Apr 11, 2016 at 11:23:57PM +0200, Martin Pieuchot wrote: > On 10/04/16(Sun) 23:33, Mike Larkin wrote: > > Please test this diff on all machines that you can successfully (today) > > resume with 'zzz'. Please make sure that after resume, the keyboard > > sti

Re: Keyboard resume (zzz) diff

2016-04-11 Thread Mike Larkin
On Mon, Apr 11, 2016 at 04:02:34PM +0200, Mark Kettenis wrote: > > Date: Sun, 10 Apr 2016 23:33:59 -0700 > > From: Mike Larkin > > > > Please test this diff on all machines that you can successfully (today) > > resume with 'zzz'. Please make sure that af

Re: bufcache KNF

2016-04-11 Thread Mike Belopuhov
On 11 April 2016 at 15:51, Mark Kettenis wrote: > > And prototypes with names in public headers are still an issue. > Interesting point. What's a public header though? Are files that end up in /usr/include/dev/pci/ public headers? If so, why do we install all of them indiscriminately?

Re: rtableid in ip6_input()

2016-04-11 Thread Mike Belopuhov
On 11 April 2016 at 13:16, Martin Pieuchot wrote: > This variable is also used for route lookups, so it must always be > assigned. > > ok? > OK. Initially there was some pf glue that got removed.

Keyboard resume (zzz) diff

2016-04-10 Thread Mike Larkin
Please test this diff on all machines that you can successfully (today) resume with 'zzz'. Please make sure that after resume, the keyboard still works. This diff re-enables the keyboard on resume. Previously, we were re-enabling the keyboard *controller* but apparently on some machines (notably t

Re: document NOLOCK in syscalls.master

2016-04-06 Thread Mike Belopuhov
On 6 April 2016 at 14:45, Michal Mazurek wrote: > * document NOLOCK - copy and paste from the commit message. > * keep MPSAFE undocumented, as it is never used. > * mention INDIR and NOLOCK in 'Fields'. > * sort the list of types in 'Fields'. > * sort the list of types in 'types'. > * place a dot

pppoe(4): relax ifconfig command sequence requirements

2016-04-06 Thread Mike Belopuhov
Hi, The EBUSY hack that I'm removing imposes an order on the ifconfig commands issued against the pppoe interface used to configure the sppp layer below. Right now ifconfig will fail with "device busy" after the authentication parameters have been set up because it kickstarts the LCP logic down i

Re: Patch for exporting PF queue status in snmpd

2016-04-05 Thread Mike Belopuhov
e width (80 characters). > I just added it on the end of the PF section and used the next number in > sequence, if there's a better way let me know. > All constructive feedback welcome. > > Diff against 5.9. > Cheers, Mike

Re: uvm: UVM_FLAG_AMAPPAD has no effect anymore, nuke it

2016-04-03 Thread Mike Larkin
On Sun, Apr 03, 2016 at 04:11:40PM +0200, Stefan Kempf wrote: > This flag caused amaps to be allocated with additional spare slots, to > make extending them cheaper. However, the kernel never extends amaps, > so allocating spare slots is pointless. Also UVM_FLAG_AMAPPAD only > has an effect in comb

<    4   5   6   7   8   9   10   11   12   13   >