Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Gilles CHEHADE
> On 20 Dec 2020, at 18:15, Chris Bennett > wrote: > > On Sun, Dec 20, 2020 at 09:51:35AM +0100, Gilles CHEHADE wrote: >> >> >>> On 20 Dec 2020, at 07:13, Sebastien Marie wrote: >>> >>> On Sat, Dec 19, 2020 at 10:36:32PM +, gil...@poolp.org wrote: Hello, Whenever a

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Chris Bennett
On Sun, Dec 20, 2020 at 09:51:35AM +0100, Gilles CHEHADE wrote: > > > > On 20 Dec 2020, at 07:13, Sebastien Marie wrote: > > > > On Sat, Dec 19, 2020 at 10:36:32PM +, gil...@poolp.org wrote: > >> Hello, > >> > >> Whenever a rule with a local action (mbox, maildir, lmtp or mda) is > >>

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Gilles CHEHADE
> On 20 Dec 2020, at 10:14, Sebastien Marie wrote: > > On Sat, Dec 19, 2020 at 11:19:10PM -0700, Theo de Raadt wrote: >> There are thousands of people with smtpd configurations, and sysmerge >> is not going to handle this. >> >> We cannot expect them all to change their files. This is

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Gilles CHEHADE
> On 20 Dec 2020, at 10:03, Gilles CHEHADE wrote: > > >> On 20 Dec 2020, at 07:19, Theo de Raadt wrote: >> >> There are thousands of people with smtpd configurations, and sysmerge >> is not going to handle this. >> >> We cannot expect them all to change their files. This is madness. >>

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Gilles CHEHADE
> On 20 Dec 2020, at 03:21, Theo de Raadt wrote: > > Todd C. Miller wrote: > >> I like this direction but I worry about breaking existing configs. >> How are we going to alert existing users that they need to update >> their configs if the behavior silently changes? > > I think the

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Gilles CHEHADE
> On 20 Dec 2020, at 07:19, Theo de Raadt wrote: > > There are thousands of people with smtpd configurations, and sysmerge > is not going to handle this. > > We cannot expect them all to change their files. This is madness. > > Gilles, I think you should be adding an option that blocks it

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Gilles CHEHADE
> On 20 Dec 2020, at 07:13, Sebastien Marie wrote: > > On Sat, Dec 19, 2020 at 10:36:32PM +, gil...@poolp.org wrote: >> Hello, >> >> Whenever a rule with a local action (mbox, maildir, lmtp or mda) is matched, >> smtpd will >> attempt to search for a ~/.forward file in the recipient

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Gilles CHEHADE
> On 20 Dec 2020, at 02:09, Todd C. Miller wrote: > > I like this direction but I worry about breaking existing configs. > How are we going to alert existing users that they need to update > their configs if the behavior silently changes? > > - todd I agree and this diff was more to suggest

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Sebastien Marie
On Sat, Dec 19, 2020 at 11:19:10PM -0700, Theo de Raadt wrote: > There are thousands of people with smtpd configurations, and sysmerge > is not going to handle this. > > We cannot expect them all to change their files. This is madness. Well, it wouldn't be the first time. But I agree that such

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-19 Thread Theo de Raadt
There are thousands of people with smtpd configurations, and sysmerge is not going to handle this. We cannot expect them all to change their files. This is madness. Gilles, I think you should be adding an option that blocks it optionally, and then some operators can use that. If they wish. I

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-19 Thread Sebastien Marie
On Sat, Dec 19, 2020 at 10:36:32PM +, gil...@poolp.org wrote: > Hello, > > Whenever a rule with a local action (mbox, maildir, lmtp or mda) is matched, > smtpd will > attempt to search for a ~/.forward file in the recipient directory and > process it. This > may be convenient for some

[diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-19 Thread gilles
Hello, Whenever a rule with a local action (mbox, maildir, lmtp or mda) is matched, smtpd will attempt to search for a ~/.forward file in the recipient directory and process it. This may be convenient for some setups but it is an implicit behavior that's not overridable and not always wanted.

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-19 Thread Theo de Raadt
Todd C. Miller wrote: > I like this direction but I worry about breaking existing configs. > How are we going to alert existing users that they need to update > their configs if the behavior silently changes? I think the configuration is backwards. Every endpoint box will need these new

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-19 Thread Todd C . Miller
I like this direction but I worry about breaking existing configs. How are we going to alert existing users that they need to update their configs if the behavior silently changes? - todd