On Sat, 10 Oct 2015 16:35:02 -0700, Philip Guenther wrote:
> Some isfoo(char) usages crept back into ftp
OK.
- todd
> Am 11.10.2015 um 04:38 schrieb Philip Guenther :
>
>> --- smtpd/rfc2822.c
>> +++ /tmp/cocci-output-29655-69b554-rfc2822.c
>> @@ -93,13 +93,13 @@ parser_feed_header(struct rfc2822_parser
>>char*pos;
>>
>>/* new header */
>> -if (! isspace(*line) &&
On Sat, Oct 10, 2015 at 08:03:28PM -0700, Philip Guenther wrote:
> On Sat, 10 Oct 2015, Michael McConville wrote:
> > FWIW, this is a perfect use case for Coccinelle. Below is what I dredged
> > up in src/usr.sbin (diff not yet carefully audited, but apparently
> > sane).
>
> These look good to
> Some isfoo(char) usages crept back into ftp
Hmm. I wonder how we can keep these errors out of base.
Having to re-audit all the time is painful.
On Sat, 10 Oct 2015, Bob Beck wrote:
> On Sat, Oct 10, 2015 at 04:35:02PM -0700, Philip Guenther wrote:
...
> > @@ -1409,7 +1410,7 @@ recode_credentials(const char *userinfo)
> > char
> > hextochar(const char *str)
> > {
> > - char c, ret;
> > + unsigned char c, ret;
> >
> > c =
On Sat, 10 Oct 2015, Michael McConville wrote:
...
> FWIW, this is a perfect use case for Coccinelle. Below is what I dredged
> up in src/usr.sbin (diff not yet carefully audited, but apparently
> sane).
I'm replying to this multiple times, cc'ing in the particular maintainers
as appropriate.
Some isfoo(char) usages crept back into ftp
ok?
Philip Guenther
Index: ftp/fetch.c
===
RCS file: /cvs/src/usr.bin/ftp/fetch.c,v
retrieving revision 1.142
diff -u -p -r1.142 fetch.c
--- ftp/fetch.c 10 Sep 2015 13:43:35 -
On Sat, 10 Oct 2015, Michael McConville wrote:
> FWIW, this is a perfect use case for Coccinelle. Below is what I dredged
> up in src/usr.sbin (diff not yet carefully audited, but apparently
> sane).
These look good to me. bluhm?
Side note: bluhm, please rename the dprintf() macro to
On Sat, 10 Oct 2015, Theo de Raadt wrote:
> > Some isfoo(char) usages crept back into ftp
>
> Hmm. I wonder how we can keep these errors out of base.
> Having to re-audit all the time is painful.
Right now, _ctype_ is a generic const char * pointer. Maybe there's way
to make it a pointer to
On Sat, Oct 10, 2015 at 04:35:02PM -0700, Philip Guenther wrote:
>
> Some isfoo(char) usages crept back into ftp
>
> ok?
>
> Philip Guenther
>
>
> Index: ftp/fetch.c
> ===
> RCS file: /cvs/src/usr.bin/ftp/fetch.c,v
> retrieving
On Sat, 10 Oct 2015, Michael McConville wrote:
> FWIW, this is a perfect use case for Coccinelle. Below is what I dredged
> up in src/usr.sbin (diff not yet carefully audited, but apparently
> sane).
I'm replying to this multiple times, cc'ing in the particular maintainers
as appropriate.
>
On Sat, 10 Oct 2015, Michael McConville wrote:
> FWIW, this is a perfect use case for Coccinelle. Below is what I dredged
> up in src/usr.sbin (diff not yet carefully audited, but apparently
> sane).
The ypserv chunks show your Coccinelle script could use an enhancement...
> ---
Theo de Raadt wrote:
> > Some isfoo(char) usages crept back into ftp
>
> Hmm. I wonder how we can keep these errors out of base.
> Having to re-audit all the time is painful.
FWIW, this is a perfect use case for Coccinelle. Below is what I dredged
up in src/usr.sbin (diff not yet carefully
On Sat, 10 Oct 2015, Michael McConville wrote:
> Theo de Raadt wrote:
> > > Some isfoo(char) usages crept back into ftp
> >
> > Hmm. I wonder how we can keep these errors out of base.
> > Having to re-audit all the time is painful.
>
> FWIW, this is a perfect use case for Coccinelle. Below is
> as well as this:
>
> > --- tcpdump/print-ipsec.c
> > +++ /tmp/cocci-output-17550-499a71-print-ipsec.c
> > @@ -101,7 +101,7 @@ esp_init (char *espspec)
> > s[0] = espkey[2*i];
> > s[1] = espkey[2*i + 1];
> > s[2] = 0;
> > - if (!isxdigit(s[0]) ||
15 matches
Mail list logo