I will commit this in the next few days unless I hear objections.
On Mon, Mar 18, 2019 at 07:39:45AM +, Nicholas Marriott wrote:
>
> This is OK with me, anyone else?
>
>
> On Fri, Mar 15, 2019 at 06:56:31PM +0200, Artturi Alm wrote:
> > On Fri, Mar 15, 2019 at 02:43:04PM +, Nicholas
This is OK with me, anyone else?
On Fri, Mar 15, 2019 at 06:56:31PM +0200, Artturi Alm wrote:
> On Fri, Mar 15, 2019 at 02:43:04PM +, Nicholas Marriott wrote:
> > .
> > Another couple of minor changes below, with those it looks good to
> > me. Any OK for this?
> >
>
> With joined lines, t
On Fri, Mar 15, 2019 at 09:51:12PM +, Nicholas Marriott wrote:
> On Fri, Mar 15, 2019 at 09:43:56AM -0600, Todd C. Miller wrote:
> > Wouldn't it be less error-prone to make escape_char u_char instead
> > of int?
>
> Maybe, I don't mind either way.
>
> However this in stream_read would still n
On Fri, Mar 15, 2019 at 09:43:56AM -0600, Todd C. Miller wrote:
> Wouldn't it be less error-prone to make escape_char u_char instead
> of int?
Maybe, I don't mind either way.
However this in stream_read would still need a cast as ptr is signed:
if (state_change && (u_char)*ptr == escape_
On Fri, Mar 15, 2019 at 02:43:04PM +, Nicholas Marriott wrote:
> .
> Another couple of minor changes below, with those it looks good to
> me. Any OK for this?
>
With joined lines, the cast, and some runtime testing with ~, % and ^[.
-Artturi
diff --git a/usr.bin/cu/command.c b/usr.bin/cu/co
Wouldn't it be less error-prone to make escape_char u_char instead
of int?
- todd
On Fri, Mar 15, 2019 at 02:43:04PM +, Nicholas Marriott wrote:
> .
> Another couple of minor changes below, with those it looks good to
> me. Any OK for this?
>
>
> On Fri, Mar 15, 2019 at 01:49:52PM +0200, Artturi Alm wrote:
> > On Thu, Mar 14, 2019 at 10:18:57AM +, Nicholas Marriott wro
.
Another couple of minor changes below, with those it looks good to
me. Any OK for this?
On Fri, Mar 15, 2019 at 01:49:52PM +0200, Artturi Alm wrote:
> On Thu, Mar 14, 2019 at 10:18:57AM +, Nicholas Marriott wrote:
> > Thanks, comments inline.
> >
>
> The diff looks much better to me, now
On Thu, Mar 14, 2019 at 10:18:57AM +, Nicholas Marriott wrote:
> Thanks, comments inline.
>
The diff looks much better to me, now with those things fixed based
on your feedback, thanks :]
-Artturi
diff --git a/usr.bin/cu/command.c b/usr.bin/cu/command.c
index c07fe73aeca..27d80f16dd7 10064
Thanks, comments inline.
> diff --git a/usr.bin/cu/command.c b/usr.bin/cu/command.c
> index c07fe73aeca..e225fb544be 100644
> --- a/usr.bin/cu/command.c
> +++ b/usr.bin/cu/command.c
> @@ -30,6 +30,7 @@
> #include
> #include
> #include
> +#include
>
> #include "cu.h"
>
> @@ -223,6 +224,
On Wed, Mar 13, 2019 at 07:47:08AM -0600, Todd C. Miller wrote:
> On Wed, 13 Mar 2019 14:35:06 +0200, Artturi Alm wrote:
>
> > i don't have issues with tilde when using locally, but i mostly ssh to
> > reach cu, and too many times i've forgotten to configure ssh/use -e,
> > with this cu(1) becomes
Why only % rather than have -e take an argument like ssh?
On Wed, Mar 13, 2019 at 02:35:06PM +0200, Artturi Alm wrote:
> Hi,
>
> i don't have issues with tilde when using locally, but i mostly ssh to
> reach cu, and too many times i've forgotten to configure ssh/use -e,
> with this cu(1) becomes
On Wed, 13 Mar 2019 14:35:06 +0200, Artturi Alm wrote:
> i don't have issues with tilde when using locally, but i mostly ssh to
> reach cu, and too many times i've forgotten to configure ssh/use -e,
> with this cu(1) becomes safer/easier to use for us with non-english
> keyboard.
> ~tilde is certa
Hi,
i don't have issues with tilde when using locally, but i mostly ssh to
reach cu, and too many times i've forgotten to configure ssh/use -e,
with this cu(1) becomes safer/easier to use for us with non-english
keyboard.
~tilde is certainly annoying when it's three key presses alone,
and then you
14 matches
Mail list logo
