Re: ifconfig with UTF-8 nwid

2020-02-24 Thread Stefan Sperling
On Sun, Feb 23, 2020 at 04:19:39PM -0800, Andrew Hewus Fresh wrote: > This removes any characters that are not marked as "printable", which I > expect is what folks want. Still doesn't always help since I still > haven't figured out font fallback in xterm so some chars don't exist in > my current

Re: ifconfig with UTF-8 nwid

2020-02-23 Thread Andrew Hewus Fresh
On Sat, Feb 22, 2020 at 10:21:56PM +, Stuart Henderson wrote: > On 2020/02/22 17:24, Stefan Sperling wrote: > > On Sat, Feb 22, 2020 at 02:56:54PM +0100, Mark Kettenis wrote: > > > IMHO it is a bad idea to make the output of ifconfig locale-dependent. > > > > Fine. I'll drop this diff. > > > >

Re: ifconfig with UTF-8 nwid

2020-02-23 Thread Stuart Henderson
On 2020/02/23 05:01, Theo de Raadt wrote: > Stefan Sperling wrote: > > > I don't understand why the installer would matter. Nothing would actually > > change for the installer. We're sure as hell not going to add UTF-8 there. > > The installer's ifconfig would just deal in hex all the way as it

Re: ifconfig with UTF-8 nwid

2020-02-23 Thread Stefan Sperling
On Sun, Feb 23, 2020 at 05:01:03AM -0700, Theo de Raadt wrote: > Stefan Sperling wrote: > > > I don't understand why the installer would matter. Nothing would actually > > change for the installer. We're sure as hell not going to add UTF-8 there. > > The installer's ifconfig would just deal in

Re: ifconfig with UTF-8 nwid

2020-02-23 Thread Theo de Raadt
Stefan Sperling wrote: > I don't understand why the installer would matter. Nothing would actually > change for the installer. We're sure as hell not going to add UTF-8 there. > The installer's ifconfig would just deal in hex all the way as it does today. > During install finding the right

Re: ifconfig with UTF-8 nwid

2020-02-23 Thread Stefan Sperling
On Sat, Feb 22, 2020 at 10:21:56PM +, Stuart Henderson wrote: > On 2020/02/22 17:24, Stefan Sperling wrote: > > On Sat, Feb 22, 2020 at 02:56:54PM +0100, Mark Kettenis wrote: > > > IMHO it is a bad idea to make the output of ifconfig locale-dependent. > > > > Fine. I'll drop this diff. > > >

Re: ifconfig with UTF-8 nwid

2020-02-22 Thread Stuart Henderson
On 2020/02/22 17:24, Stefan Sperling wrote: > On Sat, Feb 22, 2020 at 02:56:54PM +0100, Mark Kettenis wrote: > > IMHO it is a bad idea to make the output of ifconfig locale-dependent. > > Fine. I'll drop this diff. > Pity, it is quite useful if you are somewhere that uses UTF-8 SSIDs, otherwise

Re: ifconfig with UTF-8 nwid

2020-02-22 Thread Stefan Sperling
On Sat, Feb 22, 2020 at 07:08:36AM -0700, Theo de Raadt wrote: > Stefan Sperling wrote: > > > + > > +/* UTF-8 support */ > > +#include > > +#include > > +#include > > +#include > > #endif /* SMALL */ > > I don't see how the installer will work with this. I cannot, and that wasn't the

Re: ifconfig with UTF-8 nwid

2020-02-22 Thread Stefan Sperling
On Sat, Feb 22, 2020 at 02:56:54PM +0100, Mark Kettenis wrote: > IMHO it is a bad idea to make the output of ifconfig locale-dependent. Fine. I'll drop this diff.

Re: ifconfig with UTF-8 nwid

2020-02-22 Thread Theo de Raadt
Stefan Sperling wrote: > + > +/* UTF-8 support */ > +#include > +#include > +#include > +#include > #endif /* SMALL */ I don't see how the installer will work with this.

Re: ifconfig with UTF-8 nwid

2020-02-22 Thread Mark Kettenis
> Date: Sat, 22 Feb 2020 12:44:12 +0100 > From: Stefan Sperling > > This is another attempt at improving usability with non-ASCII network IDs. > > Previous attempts have been rejected in part because entering UTF-8 strings > is difficult to do for Americans and, to a lesser extent, Canadians. >

ifconfig with UTF-8 nwid

2020-02-22 Thread Stefan Sperling
This is another attempt at improving usability with non-ASCII network IDs. Previous attempts have been rejected in part because entering UTF-8 strings is difficult to do for Americans and, to a lesser extent, Canadians. It occurred to me that the real issue might have been that previous attempts