Re: seperate LRO/TSO flags

2023-05-16 Thread Alexander Bluhm
This diff passed a make release. I think it should be commited now, so that we can proceed with TSO in the driver layer. bluhm On Mon, May 15, 2023 at 11:16:59PM +0200, Jan Klemkow wrote: > Index: sbin/ifconfig/ifconfig.8 > === >

Re: seperate LRO/TSO flags

2023-05-15 Thread Alexander Bluhm
On Mon, May 15, 2023 at 11:16:59PM +0200, Jan Klemkow wrote: > - updated the diff to the current source state > - improved the vlan(4) capability handling > > ok? OK bluhm@ > - "\11CSUM_UDPv6\17TSO\20WOL" > + "\11CSUM_UDPv6\15TSOv4\16TSOv6\17LSO\20WOL" typo s/LSO/LRO/

Re: seperate LRO/TSO flags

2023-05-15 Thread Jan Klemkow
On Mon, May 15, 2023 at 11:40:20AM +0200, Alexander Bluhm wrote: > On Mon, May 15, 2023 at 09:34:21AM +0200, Jan Klemkow wrote: > > @@ -251,12 +251,16 @@ struct if_status_description { > > #defineIFCAP_VLAN_HWTAGGING0x0020 /* hardware VLAN tag > > support */ > > #define

Re: seperate LRO/TSO flags

2023-05-15 Thread Alexander Bluhm
On Mon, May 15, 2023 at 09:34:21AM +0200, Jan Klemkow wrote: > @@ -251,12 +251,16 @@ struct if_status_description { > #define IFCAP_VLAN_HWTAGGING0x0020 /* hardware VLAN tag > support */ > #define IFCAP_CSUM_TCPv60x0080 /* can do IPv6/TCP > checksums */

Re: seperate LRO/TSO flags

2023-05-15 Thread Jan Klemkow
On Sat, May 13, 2023 at 04:44:18PM +0200, Christian Weisgerber wrote: > Jan Klemkow: > > > This diff introduces separate flags for TCP offloading. We split this > > into LRO (large receive offloading) and TSO (TCP segmentation > > offloading). Thus, we are able to turn it on/off separately. >

Re: seperate LRO/TSO flags

2023-05-13 Thread Christian Weisgerber
Jan Klemkow: > This diff introduces separate flags for TCP offloading. We split this > into LRO (large receive offloading) and TSO (TCP segmentation > offloading). Thus, we are able to turn it on/off separately. Wait, why do we even have a knob for TSO? We specifically decided not to have a

Re: seperate LRO/TSO flags

2023-05-11 Thread Yuichiro NAITO
On 5/11/23 03:58, Todd C. Miller wrote: On Wed, 10 May 2023 20:55:24 +0200, Jan Klemkow wrote: For tcprecvoffload and ix(4) it's not possible to enable/disable it per address family. Its just one flag for the hardware. For tcpsendoffload its possible, but I won't do that till its necessary.

Re: seperate LRO/TSO flags

2023-05-10 Thread Todd C . Miller
On Wed, 10 May 2023 20:55:24 +0200, Jan Klemkow wrote: > For tcprecvoffload and ix(4) it's not possible to enable/disable it per > address family. Its just one flag for the hardware. > > For tcpsendoffload its possible, but I won't do that till its necessary. > > Why would you want to

Re: seperate LRO/TSO flags

2023-05-10 Thread Jan Klemkow
On Wed, May 10, 2023 at 11:13:04AM -0600, Todd C. Miller wrote: > On Wed, 10 May 2023 19:03:58 +0200, Jan Klemkow wrote: > > This diff introduces separate flags for TCP offloading. We split this > > into LRO (large receive offloading) and TSO (TCP segmentation > > offloading). Thus, we are able

Re: seperate LRO/TSO flags

2023-05-10 Thread Todd C . Miller
On Wed, 10 May 2023 19:03:58 +0200, Jan Klemkow wrote: > This diff introduces separate flags for TCP offloading. We split this > into LRO (large receive offloading) and TSO (TCP segmentation > offloading). Thus, we are able to turn it on/off separately. > > For ifconfig(8) we use

seperate LRO/TSO flags

2023-05-10 Thread Jan Klemkow
Hi, This diff introduces separate flags for TCP offloading. We split this into LRO (large receive offloading) and TSO (TCP segmentation offloading). Thus, we are able to turn it on/off separately. For ifconfig(8) we use "tcprecvoffload" and "tcpsendoffload". So, the user has a better insight