Implement VFS read clustering for MSDOSFS, third try

Hi, this is another try at making read clustering work for msdosfs. Last year, mpi@ implemented VFS read clustering for MSDOSFS in sys/msdosfs/denode.h 1.28 sys/msdosfs/msdosfs_vnops.c 1.105 This caused regressions when doing seeks past the end of the file and had. to be reverted. Then I tried

Re: ksh(1) history lines allocation

On Tue, Aug 15 2017, Rob Pierce wrote: [...] > I was able to reproduce the problem with a HISTSIZE of 10 which at 125000 > entries rendered my system unusable. With the patch I am running fine with a > HISTSIZE of 12 and have come back several times after hitting the

More docs for buffer cache, block sizes, etc.

Hi, here are some comments / man page updates for things I have learned in my adventures through msdosfs and vfs_bio.c. I have also added the bread_cluster function to buffercache(9). It would be nice if someone who knows the buffer/disk stuff could review this. Hint for the paragraph on

hfsc_deferred race

Hi, I've just triggered an assert in hfsc_deferred (a callout) on an MP kernel running on an SP virtual machine: panic: kernel diagnostic assertion "HFSC_ENABLED(ifq)" failed: file "/home/mike/src/openbsd/sys/net/hfsc.c", line 950 Stopped at db_enter+0x9: leave TIDPID

Skipping amd errata on hypervisors?

I have got a report that openbsd panics on boot with qemu -cpu Opteron_G3 (but Opteron_G2 works). kernel: protection fault trap, code=0 Stopped at amd64_errata_setmsr+0x14: rdmsr ddb{0}> >> OpenBSD/amd64 BOOT 3.33 boot> Qemu does not implement all the secret errata

Re: Skipping amd errata on hypervisors?

>I have got a report that openbsd panics on boot with qemu -cpu Opteron_G3 >(but Opteron_G2 works). > >kernel: protection fault trap, code=0 >Stopped at amd64_errata_setmsr+0x14: rdmsr >ddb{0}> >> OpenBSD/amd64 BOOT 3.33 >boot> > >Qemu does not implement all the secret

Re: Implement VFS read clustering for MSDOSFS, third try

On 08/15/17 17:20, Stefan Fritsch wrote: > Hi, > > this is another try at making read clustering work for msdosfs. > > Last year, mpi@ implemented VFS read clustering for MSDOSFS in > > sys/msdosfs/denode.h 1.28 > sys/msdosfs/msdosfs_vnops.c 1.105 > > This caused regressions when doing seeks

Re: [patch] Add -z and -Z to apmd for automatic suspend/hibernate

On Mon, Aug 14, 2017 at 05:12:05PM +0200, Klemens Nanni wrote: > Personally I'd also prefer having this in apmd(8) rather than some other > daemon or script. Some comments: > > You should pass optarg instead of errstr to error(). Either ways error() > will still append since it uses err(3). This

Re: Skipping amd errata on hypervisors?

On Tue, Aug 15, 2017 at 05:39:29PM +0200, Stefan Fritsch wrote: > I have got a report that openbsd panics on boot with qemu -cpu Opteron_G3 > (but Opteron_G2 works). > > kernel: protection fault trap, code=0 > Stopped at amd64_errata_setmsr+0x14: rdmsr > ddb{0}> >>

Re: ifstated: stop tracking interface indexes

On Tue, Aug 15, 2017 at 02:37:22PM -0400, Jeremie Courreges-Anglas wrote: > On Tue, Aug 15 2017, Rob Pierce wrote: > > On Mon, Aug 14, 2017 at 11:26:46PM -0400, Jeremie Courreges-Anglas wrote: > >> On Mon, Aug 14 2017, Rob Pierce wrote: > >> > ifstated currently

Re: ksh(1) history lines allocation

On Tue, Aug 15, 2017 at 02:03:43PM -0400, Jeremie Courreges-Anglas wrote: > On Tue, Aug 15 2017, Rob Pierce wrote: > > [...] > > > I was able to reproduce the problem with a HISTSIZE of 10 which at > > 125000 > > entries rendered my system unusable. With the patch I am

Re: ifstated: stop tracking interface indexes

On Tue, Aug 15 2017, Rob Pierce wrote: > On Mon, Aug 14, 2017 at 11:26:46PM -0400, Jeremie Courreges-Anglas wrote: >> On Mon, Aug 14 2017, Rob Pierce wrote: >> > ifstated currently tracks and maintains the index of each monitored >> > interface >> > and does not

Re: [patch] Add -z and -Z to apmd for automatic suspend/hibernate

Hi Ted, Ted Unangst wrote on Tue, Aug 15, 2017 at 07:42:39PM -0400: > Jesper Wallin wrote: >> On Sun, Aug 13, 2017 at 09:52:22AM +0200, Martijn van Duren wrote: >>> I've also been bitten by this a couple of times, but you can also solve >>> this via the sensorsd framework, which is how I've done

Re: llvm - xor return pointers

On Sat, 22 Jul 2017 02:25:29 -0400 Todd Mortimer wrote: > xor [rsp], rsp > > at the start of each function, and before every RET. Wouldn't this break with alloca() or C99 VLAs? %rbp may work better, if the frame pointer is retained. -- Ori Bernstein

Re: CID 1452909: Use of untrusted scalar value (pf_table.c)

On Tue, Aug 15, 2017 at 02:40:32PM +0200, Mike Belopuhov wrote: > Hi, > > Coverity has discovered that we're blindly trusting the value > of pfra_type that we read from the userland supplied pfr_addr > and use it to index an array of pools in pfr_create_kentry. > > I suggest to do two things:

Default TLS configuration of httpd / libtls

After responding to a question on misc@ ( http://marc.info/?l=openbsd-misc=150280482525307=2 ), I've noticed that the part of my response with regard to default-enabled TLS cipher suites on current was wrong. I was testing with an ECDSA-based instead of an RSA-based certificate which renders

Re: [patch] Add -z and -Z to apmd for automatic suspend/hibernate

Jesper Wallin wrote: > On Mon, Aug 14, 2017 at 05:12:05PM +0200, Klemens Nanni wrote: > > Personally I'd also prefer having this in apmd(8) rather than some other > > daemon or script. Some comments: > > > > You should pass optarg instead of errstr to error(). Either ways error() > > will still

Re: [patch] Add -z and -Z to apmd for automatic suspend/hibernate

Jesper Wallin wrote: > On Sun, Aug 13, 2017 at 09:52:22AM +0200, Martijn van Duren wrote: > > I've also been bitten by this a couple of times, but you can also solve > > this via the sensorsd framework, which is how I've done it. > > Yeah, someone on IRC also suggested sensorsd or even ksh and a

Re: llvm - xor return pointers

On Tue, Aug 15, 2017 at 05:12:39PM -0700, Ori Bernstein wrote: > On Sat, 22 Jul 2017 02:25:29 -0400 > Todd Mortimer wrote: > > > xor [rsp], rsp > > > > at the start of each function, and before every RET. > > Wouldn't this break with alloca() or C99 VLAs? > %rbp may work

Re: [patch] Add -z and -Z to apmd for automatic suspend/hibernate

Hi Jesper/all, On Sun, 13 Aug 2017 14:13:42 +0200 Jesper Wallin wrote: > > ... someone on IRC also suggested sensorsd or even ksh and a > cronjob. I personally find it a bit too ducttapey though, especially > for a feature one would expect on a laptop. For what its worth, below is an unpriv

make get_last_resort_ifid() truely random

Rename in6_get_rand_ifi() to get_last_resort_ifid() and delete the old get_last_resort_ifid() function because eww. Also if your system is so constraint that you end up in get_last_resort_ifid() you don't deserve a random ifid that stays stable over reboots. Simplify code a bit since get_ifid()

Re: ifstated: stop tracking interface indexes

On Mon, Aug 14, 2017 at 11:26:46PM -0400, Jeremie Courreges-Anglas wrote: > On Mon, Aug 14 2017, Rob Pierce wrote: > > ifstated currently tracks and maintains the index of each monitored > > interface > > and does not maintain interface names. This means we need to re-index on > >

CID 1452909: Use of untrusted scalar value (pf_table.c)

Hi, Coverity has discovered that we're blindly trusting the value of pfra_type that we read from the userland supplied pfr_addr and use it to index an array of pools in pfr_create_kentry. I suggest to do two things: add a check in pfr_validate_addr that is called after every copyin and also