Re: Include hostname in shell prompts by default

2017-12-09 Thread Jason McIntyre
On Sat, Dec 09, 2017 at 06:44:44PM +0100, Theo Buehler wrote: > This was discussed in a smaller circle and has been in snaps for two > days, but I'd like to show this to a wider audience. > > Theo asked me to make sure that all our shells print a prompt including > the hostname by default. The

Re: Include hostname in shell prompts by default

2017-12-09 Thread Jason McIntyre
On Sat, Dec 09, 2017 at 11:10:03AM -0700, Theo de Raadt wrote: > > the default prompt works exactly because it doesn;t try to second guess > > what the user wants, or what is or isn;t good for them. the mechanism > > for changing the prompt is trivial. > > > > i don;t think it makes sense to

Re: Include hostname in shell prompts by default

2017-12-09 Thread Theo de Raadt
> this just feels like a needless deviation. all i can say is: bash-4.4$

Include hostname in shell prompts by default

2017-12-09 Thread Theo Buehler
This was discussed in a smaller circle and has been in snaps for two days, but I'd like to show this to a wider audience. Theo asked me to make sure that all our shells print a prompt including the hostname by default. The reasoning is roughly as follows: With tmux, ssh and vmd, we tend to open

Re: Include hostname in shell prompts by default

2017-12-09 Thread Bryan Steele
On Sat, Dec 09, 2017 at 06:44:44PM +0100, Theo Buehler wrote: > This was discussed in a smaller circle and has been in snaps for two > days, but I'd like to show this to a wider audience. > > Theo asked me to make sure that all our shells print a prompt including > the hostname by default. The

Re: Include hostname in shell prompts by default

2017-12-09 Thread Marc Espie
On Sat, Dec 09, 2017 at 06:33:32PM +, Jason McIntyre wrote: > On Sat, Dec 09, 2017 at 11:10:03AM -0700, Theo de Raadt wrote: > > > the default prompt works exactly because it doesn;t try to second guess > > > what the user wants, or what is or isn;t good for them. the mechanism > > > for

Re: grep(1) -m support

2017-12-09 Thread Paul Irofti
On Fri, Dec 08, 2017 at 03:23:02PM -0700, Theo de Raadt wrote: > > Here is a new diff that supports 0 and negative m values. > > I am very unsure about negative values. > > In posix you have > >-m-1 > and >-m -1 > > And you'll observe the latter doesn't work like you think it should.

Re: Include hostname in shell prompts by default

2017-12-09 Thread lists
Sat, 9 Dec 2017 18:44:44 +0100 Theo Buehler > This was discussed in a smaller circle and has been in snaps for two > days, but I'd like to show this to a wider audience. > > Theo asked me to make sure that all our shells print a prompt including > the hostname by default.

Re: Include hostname in shell prompts by default

2017-12-09 Thread Theo de Raadt
> the default prompt works exactly because it doesn;t try to second guess > what the user wants, or what is or isn;t good for them. the mechanism > for changing the prompt is trivial. > > i don;t think it makes sense to change the shells in this way. Having seen bug reports with data from the

Re: Include hostname in shell prompts by default

2017-12-09 Thread lists
Sat, 09 Dec 2017 11:10:03 -0700 "Theo de Raadt" > > the default prompt works exactly because it doesn;t try to second guess > > what the user wants, or what is or isn;t good for them. the mechanism > > for changing the prompt is trivial. > > > > i don;t think it makes sense

Re: sshd(8) logging of client disconnect from ClientAliveInterval

2017-12-09 Thread Lars Nooden
On Wed, 18 Oct 2017, Darren Tucker wrote: > I meant reusing the existing function rather than cloning it. It's > currently static so it needs to be exported but IMO that's better than > duplicating the code. > > Index: packet.c >

nc: random failure with TLS: no protocols available / libtls patch

2017-12-09 Thread Sebastien Marie
Hi, With latest snapshot on amd64 (OpenBSD 6.2-current (GENERIC.MP) #263: Fri Dec 8 18:19:04 MST 2017), I have random failure with nc when using TLS. $ date ; nc -vvc www.free.fr 443 Sat Dec 9 09:05:34 CET 2017 Connection to www.free.fr 443 port [tcp/https] succeeded! nc: tls handshake

openbsd code coverage

2017-12-09 Thread Sergey Bronnikov
Hi, I'm working on measuring OpenBSD code coverage. The process still has drawbacks, but some results are already available. https://ligurio.github.io/openbsd-tests/6.2/coverage.html Sergey

Re: nc: random failure with TLS: no protocols available / libtls patch

2017-12-09 Thread Sebastien Marie
On Sat, Dec 09, 2017 at 09:23:13AM +0100, Sebastien Marie wrote: > > but I am unsure with nc(1) works sometimes... > replying to myself... because inside nc(1), it uses an uninitialized stack value in such cases... 150 main(int argc, char *argv[]) 151 { ... 164 uint32_t

new variable in bsd.regress.mk

2017-12-09 Thread Sergey Bronnikov
Hi, some regression tests depends on 3rd party modules and now some tests contains duplicate code which check precense of dependencies and install them in case of abcense. Perhaps it would be better to care about dependencies in the bsd.regress.mk and specify dependencies in special variable in

Re: Include hostname in shell prompts by default

2017-12-09 Thread Theo de Raadt
> With all the respect and understanding what you're saying is true, yet > I have the time to change my prompt, and it would still affect me. If you have changed it, it is irrelevant what the value was before the change. You detail no impact. You appeal is 100% emotion.

Re: Include hostname in shell prompts by default

2017-12-09 Thread Base Pr1me
As a server admin, I adore the idea. I've yelled profanity too many times rebooting the wrong machine in haste. Would be wonderful in a large tmux session. On Dec 9, 2017 11:57, wrote: Sat, 09 Dec 2017 11:10:03 -0700 "Theo de Raadt" > > the default prompt

Re: Include hostname in shell prompts by default

2017-12-09 Thread lists
Sat, 09 Dec 2017 12:02:07 -0700 "Theo de Raadt" > > With all the respect and understanding what you're saying is true, yet > > I have the time to change my prompt, and it would still affect me. > > If you have changed it, it is irrelevant what the value was before > the

Re: Include hostname in shell prompts by default

2017-12-09 Thread Job Snijders
On Sat, Dec 09, 2017 at 06:44:44PM +0100, Theo Buehler wrote: > Theo asked me to make sure that all our shells print a prompt > including the hostname by default. Thank you. This is a significant improvement. I keep finding myself updating /etc/profile everywhere to ensure I don't lose my

Re: Include hostname in shell prompts by default

2017-12-09 Thread Ian Darwin
On 2017-12-09 1:10 PM, Theo de Raadt wrote: the default prompt works exactly because it doesn;t try to second guess what the user wants, or what is or isn;t good for them. the mechanism for changing the prompt is trivial. i don;t think it makes sense to change the shells in this way. Having

Re: Include hostname in shell prompts by default

2017-12-09 Thread Theo de Raadt
> Sat, 09 Dec 2017 12:02:07 -0700 "Theo de Raadt" > > > With all the respect and understanding what you're saying is true, yet > > > I have the time to change my prompt, and it would still affect me. > > > > If you have changed it, it is irrelevant what the value was

Re: Include hostname in shell prompts by default

2017-12-09 Thread x9p
On Sat, December 9, 2017 3:44 pm, Theo Buehler wrote: > This was discussed in a smaller circle and has been in snaps for two > days, but I'd like to show this to a wider audience. > > Theo asked me to make sure that all our shells print a prompt including > the hostname by default. The reasoning

TIMEVAL_TO_TIMESPEC, etc: use do-loop for compound macros

2017-12-09 Thread Scott Cheloha
Hi, Per style(9), macros with compound statements are easier used in an if statement when do-loop wrapped. -- Scott Cheloha P.S. Is it just me or does the argument ordering for TIMESPEC_TO_TIMEVAL seem backwards? Index: sys/sys/time.h

grdc: simplify via clock_gettime

2017-12-09 Thread Scott Cheloha
Hi, This program can be simplified if we keep everything in a timespec and use clock_gettime(2)'s CLOCK_REALTIME clock instead of gettimeofday(2). The "now" timespec could be moved into main(), but I think that change belongs alongside other general refactoring/tidying in a separate diff. --

Re: Include hostname in shell prompts by default

2017-12-09 Thread Mark Kettenis
> From: "Theo de Raadt" > Date: Sat, 09 Dec 2017 11:38:44 -0700 > > > this just feels like a needless deviation. > > all i can say is: > > bash-4.4$ Which is perfectly fine for bash since it isn't the POSIX shell when invoked as bash. For the same reason we can do what

Re: Include hostname in shell prompts by default

2017-12-09 Thread Theo de Raadt
> But we should probably keep the POSIX default for sh. POSIX doesn't > cover csh, so we're free to do what we want here too. > > So my proposal is to make the change, but stick with the current > default for ksh-invoked-as-sh. Seriously, can anyone find one reason other than "dusty papers"?

Re: Include hostname in shell prompts by default

2017-12-09 Thread lists
Sat, 09 Dec 2017 12:33:30 -0700 "Theo de Raadt" > > Sat, 09 Dec 2017 12:02:07 -0700 "Theo de Raadt" > > > > With all the respect and understanding what you're saying is true, yet > > > > I have the time to change my prompt, and it would still affect

[Patch] man cdce(4) added ZTE MF831 LTE USB Modem

2017-12-09 Thread Christoph R. Murauer
Hello ! Index: cdce.4 === RCS file: /cvs/src/share/man/man4/cdce.4,v retrieving revision 1.23 diff -u -p -r1.23 cdce.4 --- cdce.4 13 Nov 2016 08:22:47 - 1.23 +++ cdce.4 9 Dec 2017 23:19:16 - @@ -68,6 +68,8 @@

Re: Include hostname in shell prompts by default

2017-12-09 Thread Brian Callahan
On 12/9/2017 1:28 PM, Bryan Steele wrote: > On Sat, Dec 09, 2017 at 06:44:44PM +0100, Theo Buehler wrote: >> This was discussed in a smaller circle and has been in snaps for two >> days, but I'd like to show this to a wider audience. >> >> Theo asked me to make sure that all our shells print a

rpc: use monotime for timeouts

2017-12-09 Thread Scott Cheloha
Hi, These timeouts in sunrpc need to be based on the monotonic clock to avoid a race with adjtime(2), settimeofday(2), etc. There are obvious possible improvements here and elsewhere in sunrpc. Here especially the time-related variable names could be made more descriptive, the various BSD time

Re: [Patch] man cdce(4) added ZTE MF831 LTE USB Modem

2017-12-09 Thread Jason McIntyre
On Sun, Dec 10, 2017 at 12:42:32AM +0100, Christoph R. Murauer wrote: > Hello ! > morning. fixed, thanks. jmc > > Index: cdce.4 > === > RCS file: /cvs/src/share/man/man4/cdce.4,v > retrieving revision 1.23 > diff -u -p -r1.23