New driver apupgio(4): interface for LEDs and button of APU1. (Advices needed)

2019-03-25 Thread Rafael Neves
Hi tech@, I wrote a driver to control the APU1 LEDs and read the state of the pushbutton switch, like skgpio(4). I would like some reviews and hints about some project decisions that I have to make. I am cooking a diff to support APU{2,3,4}, but it is an extension of this code. Setup: Machine:

Re: pfctl should allow administrator to flush _anchors

2019-03-25 Thread Ted Unangst
Alexandr Nedvedicky wrote: > it is, however -Fall operates on main ruleset only. -Fall also does > not reset limits and timeouts. Hence my first idea was to introduce > '-FNuke', which kills all rulesets and tables. > > I don't want to change behaviour of existing option

Re: pfctl should allow administrator to flush _anchors

2019-03-25 Thread Alexandr Nedvedicky
Hello, > > > > Isn't -U pretty close to -Fall ? > > > > > > > > > > it is, however -Fall operates on main ruleset only. -Fall also does > > > not reset limits and timeouts. Hence my first idea was to introduce > > > '-FNuke', which kills all rulesets and tables. > > > > > > I

Re: pfctl should allow administrator to flush _anchors

2019-03-25 Thread Theo de Raadt
Alexandr Nedvedicky wrote: > how about making the '-U' (or whatever name we agree) undocumented. We can > also make the option available if pfctl will get compiled with 'DEBUG' > option (assuming we are doing regress on debug bits anyway). no, it should be documented. but few

Re: MPLSv6 2/2 : bgpd diff

2019-03-25 Thread Denis Fondras
On Sun, Mar 24, 2019 at 10:03:15PM +1300, Richard Procter wrote: > The ldpd issue might merit a hint in the man page as I found it difficult to > diagnose > as a newbie (see attached patch), and the man page, while not wrong, threw me > by > stating that GTSM is mandatory for LDPv6; it is now

Re: ospfd: Warn when the router ID changes during config reload

2019-03-25 Thread Jeremie Courreges-Anglas
On Sun, Mar 24 2019, Mitchell Krome wrote: > On 24/03/2019 7:23 am, Theo de Raadt wrote: >> Sebastian Benoit wrote: >> >>> Mitchell Krome(mitchellkr...@gmail.com) on 2019.03.23 20:27:17 +1000: Was messing around with ospf and got myself into a situation where the router ID's were the

Re: [patch] Re: Possible sasyncd memory leak ?

2019-03-25 Thread Otto Moerbeek
On Sat, Mar 23, 2019 at 06:07:02PM +0100, MichaƂ Koc wrote: > ... [snip] This is almost good. You might fold host_ip() into net_set_sa(). the double malloc and copy isn't really needed. -Otto

diff: reboot(8): document the -l option

2019-03-25 Thread Jan Klemkow
Hi, The following diff adds missing documentation for the -l option of reboot(8) as its done in NetBSD. Bye, Jan Index: reboot.8 === RCS file: /cvs/src/sbin/reboot/reboot.8,v retrieving revision 1.50 diff -u -p -r1.50 reboot.8 ---

Re: diff: reboot(8): document the -l option

2019-03-25 Thread Theo de Raadt
When you see a comment like this, it means it is intentionally undocumented. It is the current mechanism shutdown uses. It could use a different mechanism in the future. It is done this way so that noone else depends on it. If you document this user-visible, they will come to depend on it,

Re: divert(4): increment divs_errors on if_get failure

2019-03-25 Thread Martin Pieuchot
On 24/03/19(Sun) 20:16, Lawrence Teo wrote: > This diff modifies divert_packet() to increment the divs_errors counter > on if_get failure so that users will be aware of it via netstat(1). If if_get(9) fails that means the interface no longer exists. Is it an error? Or a delayed free? Did we

Re: ssl(8): change example key size to 4096 bits

2019-03-25 Thread Jason McIntyre
On Sat, Mar 23, 2019 at 11:30:15PM -0600, Randy Hartman wrote: > ssl(8) man page changed example key size from 2048 to 4096 > in 2012 but reverted after two days. smtpd.conf(5)'s man page > and acme-client both use 4096. is it time to un-revert? > fixed, thanks. jmc > Index: ssl.8 >

chflagsat(2): fix function argument

2019-03-25 Thread Anton Lindqvist
Hi, My guess is that flag actually refers to atflags. Comments? OK? Index: chflags.2 === RCS file: /cvs/src/lib/libc/sys/chflags.2,v retrieving revision 1.27 diff -u -p -r1.27 chflags.2 --- chflags.2 19 Jan 2015 15:54:11 -

Re: ospfd: Warn when the router ID changes during config reload

2019-03-25 Thread Remi Locherer
On Mon, Mar 25, 2019 at 02:43:26PM +0100, Jeremie Courreges-Anglas wrote: > On Sun, Mar 24 2019, Mitchell Krome wrote: > > On 24/03/2019 7:23 am, Theo de Raadt wrote: > >> Sebastian Benoit wrote: > >> > >>> Mitchell Krome(mitchellkr...@gmail.com) on 2019.03.23 20:27:17 +1000: > Was messing

Re: chflagsat(2): fix function argument

2019-03-25 Thread Todd C . Miller
On Mon, 25 Mar 2019 21:44:45 +0100, Anton Lindqvist wrote: > My guess is that flag actually refers to atflags. Yes, looks like copy pasta from fchmodat. OK millert@ - todd

Re: chflagsat(2): fix function argument

2019-03-25 Thread Jeremie Courreges-Anglas
On Mon, Mar 25 2019, Anton Lindqvist wrote: > Hi, > My guess is that flag actually refers to atflags. > > Comments? OK? ok jca@ > Index: chflags.2 > === > RCS file: /cvs/src/lib/libc/sys/chflags.2,v > retrieving revision 1.27 >

unbound 1.9.1

2019-03-25 Thread Stuart Henderson
this has a couple of fixes, nothing particularly major. we already had the fix for "#4225: clients seem to erroneously receive no answer with DNS-over-TLS and qname-minimisation" backported. working here, anyone else want to test? Index: doc/Changelog

Re: pfctl should allow administrator to flush _anchors

2019-03-25 Thread Sebastian Benoit
Theo de Raadt(dera...@openbsd.org) on 2019.03.24 10:22:25 -0600: > Alexandr Nedvedicky wrote: > > > On Sun, Mar 24, 2019 at 09:51:13AM +0100, Denis Fondras wrote: > > > On Sun, Mar 24, 2019 at 09:24:34AM +0100, Alexandr Nedvedicky wrote: > > > > I think all the above calls for a new standalone

Re: ospfd: Warn when the router ID changes during config reload

2019-03-25 Thread Jeremie Courreges-Anglas
On Mon, Mar 25 2019, Remi Locherer wrote: [...] > This works and it makes sense to me. > > The log message is a bit lengthy compared to other log messages produced > by ospfd. Maybe something like this: "router-id changed: restart required" Yep, fine with me. > But the patch is also OK remi@

Re: ospfd: Warn when the router ID changes during config reload

2019-03-25 Thread Sebastian Benoit
ok Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2019.03.25 14:43:26 +0100: > On Sun, Mar 24 2019, Mitchell Krome wrote: > > On 24/03/2019 7:23 am, Theo de Raadt wrote: > >> Sebastian Benoit wrote: > >> > >>> Mitchell Krome(mitchellkr...@gmail.com) on 2019.03.23 20:27:17 +1000: > Was