Re: awk FS behaviour change

2020-06-27 Thread patrick keshishian
On Sat, Jun 27, 2020 at 06:50:39AM +0100, Jason McIntyre wrote: > On Fri, Jun 26, 2020 at 09:28:00PM -0600, Todd C. Miller wrote: > > On Fri, 26 Jun 2020 23:56:23 +0200, Klemens Nanni wrote: > > > > > How about adding something like "Therefore, FS should be set with -F or > > > in a BEGIN block

Re: 11n Tx aggregation for iwm(4)

2020-06-27 Thread Landry Breuil
On Fri, Jun 26, 2020 at 06:14:48PM +0200, Landry Breuil wrote: > On Fri, Jun 26, 2020 at 02:45:53PM +0200, Stefan Sperling wrote: > > This patch adds support for 11n Tx aggregation to iwm(4). > > > > Please help with testing if you can by running the patch and using wifi > > as usual. Nothing

Re: [PATCH] fast conditional console scrolling

2020-06-27 Thread Paul de Weerd
Hi John, With both your diffs applied, results are indeed more like 3x speed-up that I get on my machine. Average over 7 runs ls -R /usr/ports was 64.169s making for just under 3x increase. That's on 1920x1080 with the standard font size for that resolution (120x33 console, so 16x32 font).

ifconfig.8 Ar/Cm typo

2020-06-27 Thread Matthew Martin
A rule on a bridge interface that uses arp or rarp may be followed with a literal "request" or "reply" (cf. sbin/ifconfig/brconfig.c L1041 and 1048), so the Ar macro is incorrect as it's argument is not a placeholder. Aside: Is there a rule for when to list alternatives with foo | bar or foo Ns |

Re: [PATCH} Optimized rasops32 putchar

2020-06-27 Thread Mark Kettenis
> From: > Date: Fri, 26 Jun 2020 07:42:50 -0700 > > Optimized 32 bit character rendering with unrolled rows and pairwise > foreground / background pixel rendering. > > If it weren't for the 5x8 font, I would have just assumed everything > was an even width and made the fallback path also

Re: wg(4): encapsulated transport checksums

2020-06-27 Thread Theo de Raadt
> - Therefore, it's not necessary to check the IP checksum on ingress because: There is actually a really good reason. There are various counters (of all packets) which people observe to debug network problems. Now, if lower-level packets carrying wg with corruption don't increment those

Re: ifconfig.8 Ar/Cm typo

2020-06-27 Thread Jason McIntyre
On Sat, Jun 27, 2020 at 02:48:18AM -0500, Matthew Martin wrote: > A rule on a bridge interface that uses arp or rarp may be followed with > a literal "request" or "reply" (cf. sbin/ifconfig/brconfig.c L1041 and > 1048), so the Ar macro is incorrect as it's argument is not > a placeholder. >

Re: awk FS behaviour change

2020-06-27 Thread Todd C . Miller
On Sat, 27 Jun 2020 06:50:39 +0100, Jason McIntyre wrote: > i'm not sure it reads better when we switch the emphasis from whitespace > to FS. i think it's better that people see how it normally works, then > the gories about FS. so i'd have kept the first part of the sentence, > but maybe

Re: awk FS behaviour change

2020-06-27 Thread Klemens Nanni
On Sat, Jun 27, 2020 at 06:32:11AM -0600, Todd C. Miller wrote: > I wasn't sure that was an improvement either. Does this seem better? To me it does, thanks. OK kn > Index: usr.bin/awk/awk.1 > === > RCS file:

Re: pipex(4): use reference counters for `ifnet'

2020-06-27 Thread Martin Pieuchot
On 27/06/20(Sat) 01:02, Vitaliy Makkoveev wrote: > On Fri, Jun 26, 2020 at 09:15:38PM +0200, Martin Pieuchot wrote: > > On 26/06/20(Fri) 17:53, Vitaliy Makkoveev wrote: > > > On Fri, Jun 26, 2020 at 02:29:03PM +0200, Martin Pieuchot wrote: > > > > On 26/06/20(Fri) 12:35, Vitaliy Makkoveev wrote: >

Re: 11n Tx aggregation for iwm(4)

2020-06-27 Thread Tobias Heider
Works for me on a 7260. [ ID] Interval Transfer Bandwidth [ 3] 0.0-10.1 sec 108 MBytes 90.1 Mbits/sec

Re: awk FS behaviour change

2020-06-27 Thread Jason McIntyre
On Sat, Jun 27, 2020 at 06:32:11AM -0600, Todd C. Miller wrote: > On Sat, 27 Jun 2020 06:50:39 +0100, Jason McIntyre wrote: > > > i'm not sure it reads better when we switch the emphasis from whitespace > > to FS. i think it's better that people see how it normally works, then > > the gories

Re: fix races in if_clone_create()

2020-06-27 Thread Martin Pieuchot
On 27/06/20(Sat) 00:35, Vitaliy Makkoveev wrote: > On Fri, Jun 26, 2020 at 09:12:16PM +0200, Martin Pieuchot wrote: > > On 26/06/20(Fri) 16:56, Vitaliy Makkoveev wrote: > > > if_clone_create() has the races caused by context switch. > > > > Can you share a backtrace of such race? Where does the

Re: wg(4): encapsulated transport checksums

2020-06-27 Thread Jason A. Donenfeld
Hi Richard, Thanks for the patch. I had problems parsing some terminology in your description, so I thought I'd lay out my understanding of the matter, and you can let me know whether or not this corresponds with what you had in mind: - On egress, we must compute the packet checksum, because it

Re: [PATCH} Optimized rasops32 putchar

2020-06-27 Thread johnc
I did some more tests, and I think the odd performance I am seeing may be due to TLB thrash on the 32x64 characters with 4k pages, since writing each character will require 64 data TLB. Are huge page mappings supported in OpenBSD? Original Message Subject: Re: [PATCH} Optimized

Re: 11n Tx aggregation for iwm(4)

2020-06-27 Thread Johan Huldtgren
On 2020-06-26 20:11, Johan Huldtgren wrote: > hello, > > On 2020-06-26 14:45, Stefan Sperling wrote: > > It would be great to get at least one test for all the chipsets the driver > > supports: 7260, 7265, 3160, 3165, 3168, 8260, 8265, 9260, 9560 > > The behaviour of the access point also matters

Re: 11n Tx aggregation for iwm(4)

2020-06-27 Thread Tracey Emery
On Fri, Jun 26, 2020 at 02:45:53PM +0200, Stefan Sperling wrote: > This patch adds support for 11n Tx aggregation to iwm(4). > > Please help with testing if you can by running the patch and using wifi > as usual. Nothing should change, except that Tx speed may potentially > improve. If you have

[PATCH 5/5] pkcs12: add support for GOST PFX files

2020-06-27 Thread Dmitry Baryshkov
Russian standard body has changed the way MAC key is calculated for PKCS12 files. Generate proper keys depending on the digest type used for MAC generation. Sponsored by ROSA Linux Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/pkcs12/p12_key.c | 18 ++

Re: fix races in if_clone_create()

2020-06-27 Thread Vitaliy Makkoveev
On Sat, Jun 27, 2020 at 12:10:24PM +0200, Martin Pieuchot wrote: > On 27/06/20(Sat) 00:35, Vitaliy Makkoveev wrote: > > On Fri, Jun 26, 2020 at 09:12:16PM +0200, Martin Pieuchot wrote: > > > On 26/06/20(Fri) 16:56, Vitaliy Makkoveev wrote: > > > > if_clone_create() has the races caused by context

[PATCH 4/6] crypto: IDEA: convert to use new modes 64-bit helpers

2020-06-27 Thread Dmitry Baryshkov
Convert IDEA cipher to use 64-bit modes helper functions. Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/idea/i_cbc.c | 74 +++- src/lib/libcrypto/idea/i_cfb64.c | 57 ++-- src/lib/libcrypto/idea/i_ofb64.c | 47 ++-- 3

[PATCH 6/6] crypto: Gost 28147-89: convert to use new modes 64-bit helpers

2020-06-27 Thread Dmitry Baryshkov
Convert Gost 28147-89 cipher to use 64-bit modes helper functions. Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/gost/gost2814789.c | 121 ++- 1 file changed, 9 insertions(+), 112 deletions(-) diff --git a/src/lib/libcrypto/gost/gost2814789.c

Re: OpenBSD.calendar patch

2020-06-27 Thread jungle boogie
Hi Again, Here's a second attempt using git/got. Is this better? diff 382c05176131a97b161018e0e88f5417f810eb9c /var/git/src blob - b6b2ef6c918b12164e293c04db2be2dc45ab656a file + usr.bin/calendar/calendars/calendar.openbsd --- usr.bin/calendar/calendars/calendar.openbsd +++

Re: [PATCH} Optimized rasops32 putchar

2020-06-27 Thread johnc
I believe it is mapped as normally cached right now, rather than uncached or write combining. Reads aren't ultra-slow, and the timings of 48 byte writes appear to involve a cacheline read. 128 byte writes are actually slower than 64 byte writes, which I guessed might be because of automatic

OpenBSD.calendar patch

2020-06-27 Thread jungle boogie
Hi Friends, Here's a small patch to the OpenBSD.calendar. I didn't want to spend too much time on this until I find out if it would be accepted. Here's my changes: --- /usr/share/calendar/calendar.openbsdFri Jun 26 21:01:56 2020 +++ calendar.openbsdSat Jun 27 01:37:40 2020 @@

Re: [PATCH} Optimized rasops32 putchar

2020-06-27 Thread johnc
I was doing my timings with a user mode program after mmmaping the efifb display, so the mapping might be different in the kernel. Related to that, I was going to add mmap / WSDISPLAYIO_LINEBYTES / WSDISPLAYIO_SMODE to the drm drivers by consolidating code into rasops. While the point of the DRM

Re: [PATCH} Optimized rasops32 putchar

2020-06-27 Thread Mark Kettenis
> Content-Type: text/plain; charset="utf-8" > From: > > I was doing my timings with a user mode program after mmmaping the > efifb display, so the mapping might be different in the kernel. That should still give you a write-combining mapping as efifb_mmap() adds the PMAP_WC flag to the physical

Re: 11n Tx aggregation for iwm(4)

2020-06-27 Thread Jesper Wallin
Tested on a "Intel Dual Band Wireless-AC 9260" rev 0x29, msix (hw rev 0x320, fw ver 34.3125811985.0) I seem to be getting "iwm0: fatal firmware error" a few seconds after the 4-way handshake. I can send a few packets, so it sure connects and all, but then it fails shortly after. iwm0: begin

[PATCH 3/5] gost: support new PublicKeyParameters format

2020-06-27 Thread Dmitry Baryshkov
Add support for updated PublicKeyParameters format as defined by draft-deremin-rfc4491-bis. Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/gost/gost_asn1.c | 2 +- src/lib/libcrypto/gost/gostr341001_ameth.c | 42 -- 2 files changed, 41 insertions(+), 3

[PATCH 4/5] gostr341001: support unwrapped private keys support

2020-06-27 Thread Dmitry Baryshkov
GOST private keys can be wrapped in OCTET STRING, INTEGER or come unwrapped. Support the latter format. Sponsored by ROSA Linux Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/gost/gost_asn1.c | 52 ++ src/lib/libcrypto/gost/gost_asn1.h | 11 ++

[PATCH 2/5] gost: use ECerror to report EC errors

2020-06-27 Thread Dmitry Baryshkov
GOST code uses GOSTerror(EC_R_foo) to report several errors. Use ECerror(EC_R_foo) instead to make error messages match error code. Sponsored by ROSA Linux. Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/gost/gostr341001_ameth.c | 2 +- src/lib/libcrypto/gost/gostr341001_key.c | 14

[PATCH 1/5] gost: populate params tables with new curves

2020-06-27 Thread Dmitry Baryshkov
Allow users to specify new curves via strings. Sponsored by ROSA Linux Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/gost/gostr341001_params.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/lib/libcrypto/gost/gostr341001_params.c

Re: 11n Tx aggregation for iwm(4)

2020-06-27 Thread Denis Fondras
On Fri, Jun 26, 2020 at 02:45:53PM +0200, Stefan Sperling wrote: > This patch adds support for 11n Tx aggregation to iwm(4). iwm0 at pci2 dev 0 function 0 "Intel Dual Band Wireless AC 7260" rev 0x73, msi AP is Zyxel USG40W Before : bandwidth min/avg/max/std-dev = 9.800/14.000/14.214/0.606 Mbps

[PATCH 5/6] crypto: RC2: convert to use new modes 64-bit helpers

2020-06-27 Thread Dmitry Baryshkov
Convert RC2 cipher to use 64-bit modes helper functions. Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/rc2/rc2.h | 4 +- src/lib/libcrypto/rc2/rc2_cbc.c | 111 +++ src/lib/libcrypto/rc2/rc2_locl.h | 7 ++ src/lib/libcrypto/rc2/rc2cfb64.c | 57

[PATCH 1/6] modes: add functions implementing common code for 64-bit ciphers

2020-06-27 Thread Dmitry Baryshkov
64-bit ciphers are old, but it would be good to use common code for their implementations. Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/modes/cbc64.c | 202 src/lib/libcrypto/modes/cfb64.c | 169 ++

[PATCH 3/6] crypto: cast: convert to use new modes 64-bit helpers

2020-06-27 Thread Dmitry Baryshkov
Convert CAST cipher to use 64-bit modes helper functions. Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/Makefile| 2 +- src/lib/libcrypto/cast/c_cbc.c| 75 + src/lib/libcrypto/cast/c_cfb64.c | 56 ++-- src/lib/libcrypto/cast/c_enc.c|

[PATCH 2/6] crypto: bf: convert to use new modes 64-bit helpers

2020-06-27 Thread Dmitry Baryshkov
Convert Blowfish cipher to use 64-bit modes helper functions. Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/Makefile | 2 +- src/lib/libcrypto/bf/bf_cbc.c | 83 ++- src/lib/libcrypto/bf/bf_cfb64.c | 57 ++-- src/lib/libcrypto/bf/bf_enc.c |

Re: pipex(4): use reference counters for `ifnet'

2020-06-27 Thread Vitaliy Makkoveev
On Sat, Jun 27, 2020 at 12:41:29PM +0200, Martin Pieuchot wrote: > On 27/06/20(Sat) 01:02, Vitaliy Makkoveev wrote: > > On Fri, Jun 26, 2020 at 09:15:38PM +0200, Martin Pieuchot wrote: > > > On 26/06/20(Fri) 17:53, Vitaliy Makkoveev wrote: > > > > On Fri, Jun 26, 2020 at 02:29:03PM +0200, Martin

Re: [PATCH 3/6] crypto: cast: convert to use new modes 64-bit helpers

2020-06-27 Thread Joerg Sonnenberger
On Sat, Jun 27, 2020 at 10:36:58PM +0300, Dmitry Baryshkov wrote: > + * 3. All advertising materials mentioning features or use of this software > + *must display the following acknowledgement: > + *"This product includes cryptographic software written by > + * Eric Young

Re: Stuck in Needbuf state, trying to understand (6.7)

2020-06-27 Thread sven falempin
On Fri, Jun 26, 2020 at 7:35 PM sven falempin wrote: > > > On Fri, Jun 26, 2020 at 5:22 PM Stuart Henderson > wrote: > >> On 2020/06/26 15:30, sven falempin wrote: >> > behavior confirmed on current. >> > >> > Once the process stalls, ( could be anything writing to the vnconfig >> disk, >> >

Re: Stuck in Needbuf state, trying to understand (6.7)

2020-06-27 Thread Bob Beck
No. I know *exactly* what needbuf is but to attempt to diagnose what your problem is we need exact details. especially: 1) The configuration of your system including all the details of the filesystems you have mounted, all options used, etc. 2) The script you are using to generate the

Re: powerpc64: 64-bit-ize memmove.S

2020-06-27 Thread George Koehler
On Sat, 27 Jun 2020 01:27:14 +0200 Christian Weisgerber wrote: > That function simply copies as many (double)words plus a tail of > bytes as the length argument specifies. Neither source nor destination > are checked for alignment, so this will happily run a loop of > unaligned accesses, which

Re: ldomctl: Fix init-system with multiple PCIe root complexes

2020-06-27 Thread Klemens Nanni
On Sat, Jun 20, 2020 at 01:05:22AM +0200, Klemens Nanni wrote: > Opposed to all other (single CPU) machines I have encountered so far, > the T4-2 has two instead of one PCIe root complexes. > > ldomctl already accounts for this and iterates over them but lacks a > simple skip condition when