amd64 pmap pv_entry SLIST

Hi, Can we convert the pv_entry list in amd64 pmap into an SLIST? I think the code with macros is easier to read. ok? bluhm Index: arch/amd64//amd64/pmap.c === RCS file: /data/mirror/openbsd/cvs/src/sys/arch/amd64/amd64/pmap.c,v

bgpd: getifaddrs ifa_addr NULL check

getifaddrs can return a struct ifaddrs entry with a NULL ifa_addr. I think an unnumbered point-to-point interface can trigger this. So better check for it before accessing anything in ifa_addr. -- :wq Claudio Index: config.c ===

Re: regress print target name

On Wed, Dec 16, 2020 at 04:42:59PM +0100, Alexander Bluhm wrote: > When debugging tests, it is useful to see the target name and which > output belongs to it. A small addition: Run setup_once targets in a sepearate block with headline before all other targets. ok? bluhm Index:

Re: bgpd send side hold timer

On Wed, Dec 16, 2020 at 10:41:42PM +, Job Snijders wrote: > On Tue, Dec 15, 2020 at 05:02:19PM +0100, Claudio Jeker wrote: > > On Mon, Dec 14, 2020 at 06:22:09PM +, Job Snijders wrote: > > > This patch appears to be a very elegant solution to a thorny subtle > > > problem: what to do when

dig vs ipv6 (scoped) addresses

Hi, as noted on misc dig does not like to talk to local link addresses. This fixes that case. While investigating I also found another bug: selecting v6 or v4 addresses only from resolv.conf via the -4 or -6 command line argument does not work as expected. This fixes both. I did not test binding

Re: [diff] src/usr.sbin/smtpd: plug two memory leaks

On Thu, 17 Dec 2020 15:02:41 +, gil...@poolp.org wrote: > a- in lka_filter.c, the name of the filter chain for a session is strdup()-ed > upon session allocation but not released upon session release. free() it > in lka_filter_end(). > > b- in smtp_session.c, filter io channel should be

Re: regress print target name

On Thu, Dec 17, 2020 at 12:01:25PM +0100, Alexander Bluhm wrote: > On Wed, Dec 16, 2020 at 04:42:59PM +0100, Alexander Bluhm wrote: > > When debugging tests, it is useful to see the target name and which > > output belongs to it. > > A small addition: > > Run setup_once targets in a sepearate

[diff] src/usr.sbin/smtpd: plug two memory leaks

Hello, The following diffs plug two memory leaks in smtpd: a- in lka_filter.c, the name of the filter chain for a session is strdup()-ed upon session allocation but not released upon session release. free() it in lka_filter_end(). b- in smtp_session.c, filter io channel should be released when

Enhancing (some) PF state

Dear readers, pfctl -vv -ss shows detailed information on states. I would like to improve the information provided about specific TCP connections, regarding the latency of the network. An obvious way seems to be to measure the time to get ACKs back. Another way would be to use packets timestamps.

Re: WITNESS panic: acquiring blockable sleep lock with spinlock or critical section held (rwlock) kmmaplk

> Date: Thu, 17 Dec 2020 18:56:52 -0300 > From: Martin Pieuchot > > On 16/12/20(Wed) 22:49, Greg Steuck wrote: > > I just hit this while booting an i386-current in vmd. The source tree is > > synced to "Remove the assertion in uvm_km_pgremove()." > > > > I enabled WITNESS on top of GENERIC.

Re: diff: tcp ack improvement

ping On Fri, Nov 06, 2020 at 01:10:52AM +0100, Jan Klemkow wrote: > Hi, > > bluhm and I make some network performance measurements and kernel > profiling. > > Setup:Linux (iperf) -10gbit-> OpenBSD (relayd) -10gbit-> Linux (iperf) > > We figured out, that the kernel uses a huge amount

converting uvm_km_valloc to km_alloc

On Wed, Dec 16, 2020 at 12:00:38AM +0100, Mark Kettenis wrote: > > Date: Tue, 15 Dec 2020 21:21:37 +0100 > > From: Alexander Bluhm > > > > On Tue, Dec 15, 2020 at 06:57:03PM +0100, Mark Kettenis wrote: > > > Does the diff below fix this? > > > > I can reproduce the panic and your diff fixes it.

Re: WITNESS panic: acquiring blockable sleep lock with spinlock or critical section held (rwlock) kmmaplk

On 17/12/20(Thu) 23:16, Mark Kettenis wrote: > > Date: Thu, 17 Dec 2020 18:56:52 -0300 > > From: Martin Pieuchot > > > > On 16/12/20(Wed) 22:49, Greg Steuck wrote: > > > I just hit this while booting an i386-current in vmd. The source tree is > > > synced to "Remove the assertion in

Re: WITNESS panic: acquiring blockable sleep lock with spinlock or critical section held (rwlock) kmmaplk

On 16/12/20(Wed) 22:49, Greg Steuck wrote: > I just hit this while booting an i386-current in vmd. The source tree is > synced to "Remove the assertion in uvm_km_pgremove()." > > I enabled WITNESS on top of GENERIC. Naturally, GENERIC-Dec15 snap works. > > Anybody else see this so I know it's

Re: [diff] src/usr.sbin/smtpd: plug two memory leaks

December 17, 2020 4:02 PM, gil...@poolp.org wrote: > Hello, > > The following diffs plug two memory leaks in smtpd: > > a- in lka_filter.c, the name of the filter chain for a session is strdup()-ed > upon session allocation but not released upon session release. free() it > in lka_filter_end().