Re: mpbios: replace uvm_km_valloc() with km_alloc()

2020-12-19 Thread Mark Kettenis
> Date: Sat, 19 Dec 2020 20:05:08 +1000 > From: Jonathan Matthew > > A few more km_alloc()s following the same pattern as acpi. I don't have any > machines that actually need mpbios(4) but I've booted amd64 and i386 smp qemu > vms with acpi disabled, which causes mpbios to attach instead. > >

mpbios: replace uvm_km_valloc() with km_alloc()

2020-12-19 Thread Jonathan Matthew
A few more km_alloc()s following the same pattern as acpi. I don't have any machines that actually need mpbios(4) but I've booted amd64 and i386 smp qemu vms with acpi disabled, which causes mpbios to attach instead. ok? Index: arch/amd64/amd64/mpbios.c

Re: tpm(4): removing tvtohz(9)?

2020-12-19 Thread Scott Cheloha
> On Dec 18, 2020, at 20:16, joshua stein wrote: > > On Fri, 18 Dec 2020 at 18:58:43 -0600, Scott Cheloha wrote: >> Hi, >> >> tpm(4) is the last driver in the tree using tvtohz(9). There are no >> remaining callers using tstohz(9), so if and when we remove tvtohz(9) >> from tpm(4) we can

Re: WITNESS panic: acquiring blockable sleep lock with spinlock or critical section held (rwlock) kmmaplk

2020-12-19 Thread Martin Pieuchot
On 18/12/20(Fri) 08:04, Todd C. Miller wrote: > On Fri, 18 Dec 2020 13:34:39 +0100, Mark Kettenis wrote: > > > Anyway, your analysis is right. When a kernel thread wants to use > > pmap_extract(9) on a userland pmap, it needs to lock pm_apte_mtx to > > prevent another thread from simultaniously

sndiod: (mostly) suppress aliasing noise

2020-12-19 Thread Alexandre Ratchov
Hi, The current sndiod resampling algorithm is very basic mainly to keep CPU usage very low, which used to make sense for the zaurus. So, resampling produces aliasing noise, easily audible in 8kHz to 48kHz conversions but present in other cases. The diff below reduces the aliasing noise. It's a

IPsec PMTU and reject route

2020-12-19 Thread Alexander Bluhm
Hi, In revision 1.87 of ip_icmp.c claudio@ added ignoring reject routes to icmp_mtudisc_clone(). Otherwise TCP would clone these routes for PMTU discovery. They will not work, even after dynamic routing has found a better route than the reject route. With IPsec the use case is different.

Re: WITNESS panic: acquiring blockable sleep lock with spinlock or critical section held (rwlock) kmmaplk

2020-12-19 Thread Todd C . Miller
On Sat, 19 Dec 2020 18:07:41 -0300, Martin Pieuchot wrote: > A solution based on a comment and a non-enabled by option seems very > fragile to me. I came up with the idea of poisoning the ipl of the > mutex. What do you think? Even better. OK millert@ - todd

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-19 Thread Martijn van Duren
I'm in favour of this change, since I like proper nomenclature. But I think you should push this one to its logical conclusion and also rename the enum and potential other pony/klondike references, because with your diff the naming is inconsistent, which is even more confusing. martijn@ On Sat,

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-19 Thread Martijn van Duren
Personally I'd rather wait to keep the names in sync, especially since it's an easy 2 line diff that can easily be incorperated in the bigger thing. But it's not something I'm going to loose sleep over if others thing it can go in right now. On Sat, 2020-12-19 at 22:22 +, gil...@poolp.org

Re: doas sprinkle some more CFLAGS

2020-12-19 Thread Ted Unangst
On 2020-12-18, Martijn van Duren wrote: > So I ended up in doas again, this time with the CFLAGS I use for most of > my other projects. This popped up a few new not very exciting warnings. > Diff below compiles clean with both clang and gcc on amd64. > static int > match(uid_t uid, gid_t

Re: dig vs ipv6 (scoped) addresses

2020-12-19 Thread Jordan Geoghegan
On 12/18/20 5:04 PM, Jordan Geoghegan wrote: On 12/17/20 3:15 AM, Otto Moerbeek wrote: Hi, as noted on misc dig does not like to talk to local link addresses. This fixes that case. While investigating I also found another bug: selecting v6 or v4 addresses only from resolv.conf via the -4

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-19 Thread Theo de Raadt
There are thousands of people with smtpd configurations, and sysmerge is not going to handle this. We cannot expect them all to change their files. This is madness. Gilles, I think you should be adding an option that blocks it optionally, and then some operators can use that. If they wish. I

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-19 Thread Todd C . Miller
I like this direction but I worry about breaking existing configs. How are we going to alert existing users that they need to update their configs if the behavior silently changes? - todd

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-19 Thread Theo de Raadt
Todd C. Miller wrote: > I like this direction but I worry about breaking existing configs. > How are we going to alert existing users that they need to update > their configs if the behavior silently changes? I think the configuration is backwards. Every endpoint box will need these new

[diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-19 Thread gilles
Hello, Whenever a rule with a local action (mbox, maildir, lmtp or mda) is matched, smtpd will attempt to search for a ~/.forward file in the recipient directory and process it. This may be convenient for some setups but it is an implicit behavior that's not overridable and not always wanted.

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-19 Thread gilles
December 19, 2020 11:26 PM, "Martijn van Duren" wrote: > Personally I'd rather wait to keep the names in sync, especially since > it's an easy 2 line diff that can easily be incorperated in the bigger > thing. But it's not something I'm going to loose sleep over if others > thing it can go in

[diff] src/usr.sbin/smtpd: change process names

2020-12-19 Thread gilles
Hello, A very long time ago, smtpd had several more processes which then got factored into a single one. We couldn't find a decent name back then but since a hacker had requested a pony from me I temporarily named the process "pony express" as it was in charge of delivering mail. Later, reyk

[diff] src/usr.sbin/smtpd: add allow-exec to explicitly allow custom mda

2020-12-19 Thread gilles
Hello, As is done in other MTA, smtpd allows execution of a custom command in forward files so users can plug their procmail, fdm and other. It is currently not possible to allow the users to forward their mail through a .forward file without also allowing them to run a custom mda. This diff

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-19 Thread Todd C . Miller
I like it. I always forget which role the pony process performs. - todd

Re: Double entry in /usr/src/lib/libcurses/curs_util.3

2020-12-19 Thread Chris Bennett
On Mon, Dec 14, 2020 at 09:06:21PM +, Stuart Henderson wrote: > This is present in the latest release upstream, could you report it > there please? > https://invisible-island.net/ncurses/announce.html#h2-development > > SEE ALSO are usually in (at least roughly) alphabetical order so it's >

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-19 Thread Sebastien Marie
On Sat, Dec 19, 2020 at 10:36:32PM +, gil...@poolp.org wrote: > Hello, > > Whenever a rule with a local action (mbox, maildir, lmtp or mda) is matched, > smtpd will > attempt to search for a ~/.forward file in the recipient directory and > process it. This > may be convenient for some

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-19 Thread gilles
I agree but I thought this should be done in a second time as it is quite invasive and not required for the change to be visible outside the daemon December 19, 2020 11:13 PM, "Martijn van Duren" wrote: > I'm in favour of this change, since I like proper nomenclature. > But I think you should

[diff] src/usr.sbin/smtpd: add allow-exec to explicitly allow commands from aliases

2020-12-19 Thread gilles
Last diff of the series: This introduces the same logic as forward-file for executing commands. Executing commands from aliases should be discouraged as you can always achieve the same through a forward file and benefit from the privilege separation of running a command as a separate user