> On 7 Jun 2023, at 06:33, Vitaliy Makkoveev wrote:
>
>> On 6 Jun 2023, at 20:29, Alexander Bluhm wrote:
>>
>> On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote:
>>> On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote:
Hi,
I would suggest to
> On 6 Jun 2023, at 19:37, Chris Cappuccio wrote:
>
> Jan Klemkow [j.klem...@wemelug.de] wrote:
>> On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote:
>>> On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote:
I would suggest to rename ifconfig tcprecvoffload to
> On 6 Jun 2023, at 20:29, Alexander Bluhm wrote:
>
> On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote:
>> On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote:
>>> Hi,
>>>
>>> I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe
>>> it's just because
On Tue, Jun 06, 2023 at 11:33:36PM +0300, Vitaliy Makkoveev wrote:
> > On 6 Jun 2023, at 20:29, Alexander Bluhm wrote:
> >
> > On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote:
> >> On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote:
> >>> Hi,
> >>>
> >>> I would
On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote:
> Hi,
>
> I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe
> it's just because I had to type that long name too often.
>
> With that we have consistent naming:
> # ifconfig ix0 tcplro
> # sysctl
On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote:
> On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote:
> > Hi,
> >
> > I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe
> > it's just because I had to type that long name too often.
> >
> > With
On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote:
> On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote:
> > I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe
> > it's just because I had to type that long name too often.
> >
> > With that we have
Jan Klemkow [j.klem...@wemelug.de] wrote:
> On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote:
> > On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote:
> > > I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe
> > > it's just because I had to type that
On Tue, Jun 06, 2023 at 09:37:22AM -0700, Chris Cappuccio wrote:
> Jan Klemkow [j.klem...@wemelug.de] wrote:
> > On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote:
> > > On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote:
> > > > I would suggest to rename ifconfig
Replace some ibuf_data() + offset constructs to use ibuf_seek() the actual
interface built exactly for this.
Should behave the same unless the code is already broken and overflowing
the buffer.
--
:wq Claudio
Index: crypto.c
===
On Tue, Jun 06, 2023 at 12:59:05PM +0200, Claudio Jeker wrote:
> Replace some ibuf_data() + offset constructs to use ibuf_seek() the actual
> interface built exactly for this.
>
> Should behave the same unless the code is already broken and overflowing
> the buffer.
Agreed. Reads fine, ok tb
>
On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote:
> I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe
> it's just because I had to type that long name too often.
>
> With that we have consistent naming:
> # ifconfig ix0 tcplro
> # sysctl net.inet.tcp.tso=1
>
>
My plan is to make ibuf_data() return void * not uint8_t *. Because of
this you can't do pointer arithmetics with that function.
The following diff just uses the same construct that many other functions
in ikev2_pld.c use.
This code should be rewritten but we are not there yet. The goal is to
Hi,
I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe
it's just because I had to type that long name too often.
With that we have consistent naming:
# ifconfig ix0 tcplro
# sysctl net.inet.tcp.tso=1
Also the coresponding flag are named LRO.
# ifconfig ix1 hwfeatures
ix1:
On Tue, Jun 06, 2023 at 03:33:50PM +0200, Claudio Jeker wrote:
> My plan is to make ibuf_data() return void * not uint8_t *. Because of
> this you can't do pointer arithmetics with that function.
> The following diff just uses the same construct that many other functions
> in ikev2_pld.c use.
>
>
15 matches
Mail list logo