Re: ifconfig rename tcplro

2023-06-06 Thread David Gwynne
> On 7 Jun 2023, at 06:33, Vitaliy Makkoveev wrote: > >> On 6 Jun 2023, at 20:29, Alexander Bluhm wrote: >> >> On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote: >>> On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote: Hi, I would suggest to

Re: ifconfig rename tcplro

2023-06-06 Thread Vitaliy Makkoveev
> On 6 Jun 2023, at 19:37, Chris Cappuccio wrote: > > Jan Klemkow [j.klem...@wemelug.de] wrote: >> On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote: >>> On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote: I would suggest to rename ifconfig tcprecvoffload to

Re: ifconfig rename tcplro

2023-06-06 Thread Vitaliy Makkoveev
> On 6 Jun 2023, at 20:29, Alexander Bluhm wrote: > > On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote: >> On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote: >>> Hi, >>> >>> I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe >>> it's just because

Re: ifconfig rename tcplro

2023-06-06 Thread Alexander Bluhm
On Tue, Jun 06, 2023 at 11:33:36PM +0300, Vitaliy Makkoveev wrote: > > On 6 Jun 2023, at 20:29, Alexander Bluhm wrote: > > > > On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote: > >> On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote: > >>> Hi, > >>> > >>> I would

Re: ifconfig rename tcplro

2023-06-06 Thread Vitaliy Makkoveev
On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote: > Hi, > > I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe > it's just because I had to type that long name too often. > > With that we have consistent naming: > # ifconfig ix0 tcplro > # sysctl

Re: ifconfig rename tcplro

2023-06-06 Thread Alexander Bluhm
On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote: > On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote: > > Hi, > > > > I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe > > it's just because I had to type that long name too often. > > > > With

Re: ifconfig rename tcplro

2023-06-06 Thread Jan Klemkow
On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote: > On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote: > > I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe > > it's just because I had to type that long name too often. > > > > With that we have

Re: ifconfig rename tcplro

2023-06-06 Thread Chris Cappuccio
Jan Klemkow [j.klem...@wemelug.de] wrote: > On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote: > > On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote: > > > I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe > > > it's just because I had to type that

Re: ifconfig rename tcplro

2023-06-06 Thread Jan Klemkow
On Tue, Jun 06, 2023 at 09:37:22AM -0700, Chris Cappuccio wrote: > Jan Klemkow [j.klem...@wemelug.de] wrote: > > On Tue, Jun 06, 2023 at 05:54:31PM +0300, Vitaliy Makkoveev wrote: > > > On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote: > > > > I would suggest to rename ifconfig

iked, use ibuf_seek() where it is obvious

2023-06-06 Thread Claudio Jeker
Replace some ibuf_data() + offset constructs to use ibuf_seek() the actual interface built exactly for this. Should behave the same unless the code is already broken and overflowing the buffer. -- :wq Claudio Index: crypto.c ===

Re: iked, use ibuf_seek() where it is obvious

2023-06-06 Thread Theo Buehler
On Tue, Jun 06, 2023 at 12:59:05PM +0200, Claudio Jeker wrote: > Replace some ibuf_data() + offset constructs to use ibuf_seek() the actual > interface built exactly for this. > > Should behave the same unless the code is already broken and overflowing > the buffer. Agreed. Reads fine, ok tb >

Re: ifconfig rename tcplro

2023-06-06 Thread Jan Klemkow
On Tue, Jun 06, 2023 at 02:31:52PM +0200, Alexander Bluhm wrote: > I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe > it's just because I had to type that long name too often. > > With that we have consistent naming: > # ifconfig ix0 tcplro > # sysctl net.inet.tcp.tso=1 > >

iked, adjust ikev2_pld code

2023-06-06 Thread Claudio Jeker
My plan is to make ibuf_data() return void * not uint8_t *. Because of this you can't do pointer arithmetics with that function. The following diff just uses the same construct that many other functions in ikev2_pld.c use. This code should be rewritten but we are not there yet. The goal is to

ifconfig rename tcplro

2023-06-06 Thread Alexander Bluhm
Hi, I would suggest to rename ifconfig tcprecvoffload to tcplro. Maybe it's just because I had to type that long name too often. With that we have consistent naming: # ifconfig ix0 tcplro # sysctl net.inet.tcp.tso=1 Also the coresponding flag are named LRO. # ifconfig ix1 hwfeatures ix1:

Re: iked, adjust ikev2_pld code

2023-06-06 Thread Theo Buehler
On Tue, Jun 06, 2023 at 03:33:50PM +0200, Claudio Jeker wrote: > My plan is to make ibuf_data() return void * not uint8_t *. Because of > this you can't do pointer arithmetics with that function. > The following diff just uses the same construct that many other functions > in ikev2_pld.c use. > >