Re: Xorg stipple
Thanks to the stipple pattern I noticed this: https://marc.info/?l=openbsd-x11=146506160500583=2 I know it's not relevant or if it's useful for discovering some bug, but I'd still like to know what's that phantom shadow that appears at the right bottom of my screen. :-)
Re: Xorg stipple
On Sun, 26 Feb 2017 at 10:43:50 +0100, Landry Breuil wrote: > On Wed, Mar 09, 2016 at 05:09:13PM -0600, joshua stein wrote: > > Is anyone seriously finding video/Xorg bugs through the default X > > stipple pattern anymore? Xorg changed the default to draw a black > > background a while ago (with stipple enabled using the -retro flag), > > but we have this local change that reverted it while adding a silly > > -retard flag in order to show the black background. > > > > I think we can finally stop partying like it's 1989 (vax is dead, > > after all) and have X show a solid black background by default. > > Reviving this thread because everyone likes to party like it's > 1989^W^W^W^Wthe smell of a sunday morning bikeshed From what i > understand, we default to the -retro mode, that option is #ifndef'ed > out, but Xserver(1) still mentions it. We instead provide (since xserver > 1.6.4, 8 years ago) an undocumented -retard option which is supposed to > have the default 'black background' behaviour. And then, there's -br > flag. > > So.. should we fix the code (from what i understood in the thread, > there was opposition) or the manpage ? > Or document (where?) that one can use xsetroot -solid in > /etc/X11/xdm/Xsetup_0 to paint the default xdm/X background to its > own bikeshed color ? While I still think we should get rid of the stipple by default, I propose this diff to xdm which paints the background black after X fully starts up. The stipple pattern will still appear briefly, to bring enlightenment to all of those lost souls troubleshooting their X startup problems in 2017 without consulting /var/log/Xorg.0.log, or those using startx because they like the stipple and fvwm. But once X has loaded far enough to start xdm, it will paint the background black. diff --git app/xdm/config/Xsetup_0 app/xdm/config/Xsetup_0 index a24818c9d..7ff2260ee 100644 --- app/xdm/config/Xsetup_0 +++ app/xdm/config/Xsetup_0 @@ -1,5 +1,8 @@ #!/bin/sh # $OpenBSD: Xsetup_0,v 1.3 2010/03/28 09:33:02 matthieu Exp $ + +xsetroot -solid black + if [ "$DISPLAY" = ":0" -o "$DISPLAY" = ":0.0" ] then xconsole -geometry 480x130-0-0 -daemon -notify -verbose -fn fixed -exitOnFail
Re: Xorg stipple
On Sun, Feb 26, 2017 at 10:43:50AM +0100, Landry Breuil wrote: > On Wed, Mar 09, 2016 at 05:09:13PM -0600, joshua stein wrote: > > Is anyone seriously finding video/Xorg bugs through the default X > > stipple pattern anymore? Xorg changed the default to draw a black > > background a while ago (with stipple enabled using the -retro flag), > > but we have this local change that reverted it while adding a silly > > -retard flag in order to show the black background. > > > > I think we can finally stop partying like it's 1989 (vax is dead, > > after all) and have X show a solid black background by default. > > Reviving this thread because everyone likes to party like it's > 1989^W^W^W^Wthe smell of a sunday morning bikeshed From what i > understand, we default to the -retro mode, that option is #ifndef'ed > out, but Xserver(1) still mentions it. We instead provide (since xserver > 1.6.4, 8 years ago) an undocumented -retard option which is supposed to > have the default 'black background' behaviour. And then, there's -br > flag. > > So.. should we fix the code (from what i understood in the thread, > there was opposition) or the manpage ? > Or document (where?) that one can use xsetroot -solid in > /etc/X11/xdm/Xsetup_0 to paint the default xdm/X background to its > own bikeshed color ? > xmd(1) already points to Xsetup_0: DisplayManager.DISPLAY.setup This specifies a program which is run (as root) before offering the Login window. This may be used to change the appearance of the screen around the Login window or to put up other windows (e.g., you may want to run xconsole here). By default, no program is run. The conventional name for a file used here is Xsetup. See the section Setup Program. -- -=[rpe]=-
Re: Xorg stipple
On Wed, Mar 09, 2016 at 05:09:13PM -0600, joshua stein wrote: > Is anyone seriously finding video/Xorg bugs through the default X > stipple pattern anymore? Xorg changed the default to draw a black > background a while ago (with stipple enabled using the -retro flag), > but we have this local change that reverted it while adding a silly > -retard flag in order to show the black background. > > I think we can finally stop partying like it's 1989 (vax is dead, > after all) and have X show a solid black background by default. Reviving this thread because everyone likes to party like it's 1989^W^W^W^Wthe smell of a sunday morning bikeshed From what i understand, we default to the -retro mode, that option is #ifndef'ed out, but Xserver(1) still mentions it. We instead provide (since xserver 1.6.4, 8 years ago) an undocumented -retard option which is supposed to have the default 'black background' behaviour. And then, there's -br flag. So.. should we fix the code (from what i understood in the thread, there was opposition) or the manpage ? Or document (where?) that one can use xsetroot -solid in /etc/X11/xdm/Xsetup_0 to paint the default xdm/X background to its own bikeshed color ?
Re: Xorg stipple
joshua stein writes: > Is anyone seriously finding video/Xorg bugs through the default X > stipple pattern anymore? Xorg changed the default to draw a black > background a while ago (with stipple enabled using the -retro flag), > but we have this local change that reverted it while adding a silly > -retard flag in order to show the black background. > > I think we can finally stop partying like it's 1989 (vax is dead, > after all) and have X show a solid black background by default. While on this topic, I recently "synced" the look of ssh-askpass with the semi-recent changes for the XDM login screen: ssh-askpass*font: -adobe-helvetica-medium-r-normal--18-180-75-75-p-98-iso8859-1 ssh-askpass*foreground: #ff ssh-askpass*background: #798a99 ssh-askpass.*.borderWidth: 1 ssh-askpass.*.borderColor: black ssh-askpass.*.shadowThickness: 0 ssh-askpass.*Button.borderWidth:0 ssh-askpass.*Button.background: #99aab9 ssh-askpass.indicator.borderWidth: 0 ssh-askpass.indicator.background: #99aab9 ssh-askpass.indicator.foreground: #fffa06 Not suggesting we modify it, but figured someone else might be interested :D
Re: Xorg stipple
Wed, 9 Mar 2016 19:40:35 -0600 joshua stein> On Thu, 10 Mar 2016 at 03:32:53 +0200, li...@wrant.com wrote: > > Apparently all you guys use laptops with LVDS, but TFT/LCD panels on > > VGA are still widely common in use. You remember the automatic adjust > > functional button on these monitors, right? It does phase and sync > > adjust that saves a lot of fiddling. It works best on a fine pattern > > exactly like the stipple which we know is from old times but is that > > pattern for the same reason, help you focus you CRT tubes. Also, think > > about focusing projectors that use VGA. Same thing, focus is good to > > have and the pattern still helps. I'll comment on floppies another day. > > So start X with -retro for those specific times you need it. This > is a weak argument for forcing this default on everyone, every time. Sure, no problem. I'm not a conference presenter at the time. Also, we have xtestpicture in ports. So, I agree with your proposal (though you don't need it to proceed).
Re: Xorg stipple
Wed, 9 Mar 2016 17:10:07 -0800 Michael McConville> Theo de Raadt wrote: > > > > Is anyone seriously finding video/Xorg bugs through the default X > > > > stipple pattern anymore? Xorg changed the default to draw a black > > > > background a while ago (with stipple enabled using the -retro flag), > > > > but we have this local change that reverted it while adding a silly > > > > -retard flag in order to show the black background. > > > > > > > > I think we can finally stop partying like it's 1989 (vax is dead, > > > > after all) and have X show a solid black background by default. > > > > > > The reason for this is to be able distinguish between: > > > > > > "I get a black screen because X is not working" > > > > > > and > > > > > > "I get a black screen because my desktop environment is not working" > > > > And as we all can observe, this problem has become more severe over > > the last decade. > > Can anyone think of a good option that isn't black but is less hideous > than stipple? Even a dark navy or something like that. Now mailing also the list, sorry for the triple message, Joshua. Apparently all you guys use laptops with LVDS, but TFT/LCD panels on VGA are still widely common in use. You remember the automatic adjust functional button on these monitors, right? It does phase and sync adjust that saves a lot of fiddling. It works best on a fine pattern exactly like the stipple which we know is from old times but is that pattern for the same reason, help you focus you CRT tubes. Also, think about focusing projectors that use VGA. Same thing, focus is good to have and the pattern still helps. I'll comment on floppies another day.
Re: Xorg stipple
Thu, 10 Mar 2016 13:37:50 +0100 Matthieu Herrb> On Wed, Mar 09, 2016 at 05:09:13PM -0600, joshua stein wrote: > > Is anyone seriously finding video/Xorg bugs through the default X > > stipple pattern anymore? Xorg changed the default to draw a black > > background a while ago (with stipple enabled using the -retro flag), > > but we have this local change that reverted it while adding a silly > > -retard flag in order to show the black background. > > > > I think we can finally stop partying like it's 1989 (vax is dead, > > after all) and have X show a solid black background by default. > > I don't have a strong preference. If the team who prefer to get rid > of the stipple (and seem to be the majority of expressed opinons) > agree to take the extra step to try with -retro and/or check > Xorg.0.log carefully before reporting problems to bugs@, I'm ok with > dumping this extra local change. > > And eventually the -retro option will be removed upstreams... As long as the pattern is still available and usable, I'd prefer it over any dark background which is worse. Dark screens don't save electricity, and we're not running CRTs daily, so our eyes are OK even when using the pattern. For this one can run xsetroot -def and over time learn to appreciate IPS (or better) panels that don't flicker on their PWM (free) brightness & contrast control and work OK on lower settings. In fact it is considered an important monitor testing and selection feature, a quick glimpse and you can tell which is TN and PWM flickering and not settle for it at all at right away, instead of years after purchase. Then, after all the test patterns are considered the full time usage and the talking head is a minor interruption (and not the other way round). If you want to not ever see the pattern, OK, just please don't rip out the way to have if for others that like it. So, I don't have a strong preference either, as long as the pattern is available and can be opted for after starting the server and cwm (twm), or whatever. > > > > > > > Index: dix/globals.c > > === > > RCS file: /var/cvs/xenocara/xserver/dix/globals.c,v > > retrieving revision 1.11 > > diff -u -p -u -p -r1.11 globals.c > > --- dix/globals.c 16 Sep 2015 19:10:20 - 1.11 > > +++ dix/globals.c 9 Mar 2016 22:57:54 - > > @@ -118,11 +118,7 @@ const char *defaultCursorFont = COMPILED > > FontPtr defaultFont;/* not declared in dix.h to avoid > > including font.h in > > every compilation of dix code */ > > CursorPtr rootCursor; > > -#ifndef __OpenBSD__ > > Bool party_like_its_1989 = FALSE; > > -#else > > -Bool party_like_its_1989 = TRUE; > > -#endif > > Bool whiteRoot = FALSE; > > > > TimeStamp currentTime; > > Index: os/utils.c > > === > > RCS file: /var/cvs/xenocara/xserver/os/utils.c,v > > retrieving revision 1.21 > > diff -u -p -u -p -r1.21 utils.c > > --- os/utils.c 7 Nov 2015 16:48:53 - 1.21 > > +++ os/utils.c 9 Mar 2016 22:57:37 - > > @@ -579,11 +579,7 @@ UseMsg(void) > > ErrorF("-r turns off auto-repeat\n"); > > ErrorF("r turns on auto-repeat \n"); > > ErrorF("-render [default|mono|gray|color] set render color alloc > > policy\n"); > > -#ifndef __OpenBSD__ > > ErrorF("-retro start with classic stipple and > > cursor\n"); > > -#else > > -ErrorF("-retard start with black background and no > > cursor\n"); > > -#endif > > ErrorF("-s # screen-saver timeout (minutes)\n"); > > ErrorF("-seat string seat to run on\n"); > > ErrorF("-t # default pointer threshold > > (pixels/t)\n"); > > @@ -918,13 +914,8 @@ ProcessCommandLine(int argc, char *argv[ > > defaultKeyboardControl.autoRepeat = TRUE; > > else if (strcmp(argv[i], "-r") == 0) > > defaultKeyboardControl.autoRepeat = FALSE; > > -#ifndef __OpenBSD__ > > else if ( strcmp( argv[i], "-retro") == 0) > > party_like_its_1989 = TRUE; > > -#else > > - else if ( strcmp( argv[i], "-retard") == 0) > > - party_like_its_1989 = FALSE; > > -#endif > > else if (strcmp(argv[i], "-s") == 0) { > > if (++i < argc) > > defaultScreenSaverTime = ((CARD32) atoi(argv[i])) * >
Re: Xorg stipple
On Wed, Mar 09, 2016 at 07:40:35PM -0600, joshua stein wrote: > On Thu, 10 Mar 2016 at 03:32:53 +0200, li...@wrant.com wrote: > > Apparently all you guys use laptops with LVDS, but TFT/LCD panels on > > VGA are still widely common in use. You remember the automatic adjust > > functional button on these monitors, right? It does phase and sync > > adjust that saves a lot of fiddling. It works best on a fine pattern > > exactly like the stipple which we know is from old times but is that > > pattern for the same reason, help you focus you CRT tubes. Also, think > > about focusing projectors that use VGA. Same thing, focus is good to > > have and the pattern still helps. I'll comment on floppies another day. > > So start X with -retro for those specific times you need it. This > is a weak argument for forcing this default on everyone, every time. > So "$ startx -- -retro". Solid black is the worst w/black background on xterm etc. when stacking, not saying i don't feel embarrassed about it whenever anyone does see the stipple, but it is also colored enough to use the display for some light in a dark room. If it is not going to be black, i hope atleast cwm default border colors will be taken into consideration when choosing it. -Artturi
Re: Xorg stipple
On Thu, Mar 10, 2016 at 08:00:43AM +0100, Martin Pieuchot wrote: > The current status is just a bad software experience from the 80s. Usually you complain about the 90s :-) Personally I like the traditional X11 appearance. bluhm
Re: Xorg stipple
On Wed, Mar 09, 2016 at 05:09:13PM -0600, joshua stein wrote: > Is anyone seriously finding video/Xorg bugs through the default X > stipple pattern anymore? Xorg changed the default to draw a black > background a while ago (with stipple enabled using the -retro flag), > but we have this local change that reverted it while adding a silly > -retard flag in order to show the black background. > > I think we can finally stop partying like it's 1989 (vax is dead, > after all) and have X show a solid black background by default. I don't have a strong preference. If the team who prefer to get rid of the stipple (and seem to be the majority of expressed opinons) agree to take the extra step to try with -retro and/or check Xorg.0.log carefully before reporting problems to bugs@, I'm ok with dumping this extra local change. And eventually the -retro option will be removed upstreams... > > > Index: dix/globals.c > === > RCS file: /var/cvs/xenocara/xserver/dix/globals.c,v > retrieving revision 1.11 > diff -u -p -u -p -r1.11 globals.c > --- dix/globals.c 16 Sep 2015 19:10:20 - 1.11 > +++ dix/globals.c 9 Mar 2016 22:57:54 - > @@ -118,11 +118,7 @@ const char *defaultCursorFont = COMPILED > FontPtr defaultFont;/* not declared in dix.h to avoid including > font.h in > every compilation of dix code */ > CursorPtr rootCursor; > -#ifndef __OpenBSD__ > Bool party_like_its_1989 = FALSE; > -#else > -Bool party_like_its_1989 = TRUE; > -#endif > Bool whiteRoot = FALSE; > > TimeStamp currentTime; > Index: os/utils.c > === > RCS file: /var/cvs/xenocara/xserver/os/utils.c,v > retrieving revision 1.21 > diff -u -p -u -p -r1.21 utils.c > --- os/utils.c7 Nov 2015 16:48:53 - 1.21 > +++ os/utils.c9 Mar 2016 22:57:37 - > @@ -579,11 +579,7 @@ UseMsg(void) > ErrorF("-r turns off auto-repeat\n"); > ErrorF("r turns on auto-repeat \n"); > ErrorF("-render [default|mono|gray|color] set render color alloc > policy\n"); > -#ifndef __OpenBSD__ > ErrorF("-retro start with classic stipple and cursor\n"); > -#else > -ErrorF("-retard start with black background and no > cursor\n"); > -#endif > ErrorF("-s # screen-saver timeout (minutes)\n"); > ErrorF("-seat string seat to run on\n"); > ErrorF("-t # default pointer threshold (pixels/t)\n"); > @@ -918,13 +914,8 @@ ProcessCommandLine(int argc, char *argv[ > defaultKeyboardControl.autoRepeat = TRUE; > else if (strcmp(argv[i], "-r") == 0) > defaultKeyboardControl.autoRepeat = FALSE; > -#ifndef __OpenBSD__ > else if ( strcmp( argv[i], "-retro") == 0) > party_like_its_1989 = TRUE; > -#else > - else if ( strcmp( argv[i], "-retard") == 0) > - party_like_its_1989 = FALSE; > -#endif > else if (strcmp(argv[i], "-s") == 0) { > if (++i < argc) > defaultScreenSaverTime = ((CARD32) atoi(argv[i])) * -- Matthieu Herrb pgpvMXM2ziNi2.pgp Description: PGP signature
Re: Xorg stipple
On 10/03/16(Thu) 01:04, Mark Kettenis wrote: > > Date: Wed, 9 Mar 2016 17:09:13 -0600 > > From: joshua stein> > > > Is anyone seriously finding video/Xorg bugs through the default X > > stipple pattern anymore? Xorg changed the default to draw a black > > background a while ago (with stipple enabled using the -retro flag), > > but we have this local change that reverted it while adding a silly > > -retard flag in order to show the black background. > > > > I think we can finally stop partying like it's 1989 (vax is dead, > > after all) and have X show a solid black background by default. > > The reason for this is to be able distinguish between: > > "I get a black screen because X is not working" > > and > > "I get a black screen because my desktop environment is not working" In this case can we have a non-ugly party-like-its-2016 background? The actual user experience just sucks. > > Index: dix/globals.c > > === > > RCS file: /var/cvs/xenocara/xserver/dix/globals.c,v > > retrieving revision 1.11 > > diff -u -p -u -p -r1.11 globals.c > > --- dix/globals.c 16 Sep 2015 19:10:20 - 1.11 > > +++ dix/globals.c 9 Mar 2016 22:57:54 - > > @@ -118,11 +118,7 @@ const char *defaultCursorFont = COMPILED > > FontPtr defaultFont;/* not declared in dix.h to avoid > > including font.h in > > every compilation of dix code */ > > CursorPtr rootCursor; > > -#ifndef __OpenBSD__ > > Bool party_like_its_1989 = FALSE; > > -#else > > -Bool party_like_its_1989 = TRUE; > > -#endif > > Bool whiteRoot = FALSE; > > > > TimeStamp currentTime; > > Index: os/utils.c > > === > > RCS file: /var/cvs/xenocara/xserver/os/utils.c,v > > retrieving revision 1.21 > > diff -u -p -u -p -r1.21 utils.c > > --- os/utils.c 7 Nov 2015 16:48:53 - 1.21 > > +++ os/utils.c 9 Mar 2016 22:57:37 - > > @@ -579,11 +579,7 @@ UseMsg(void) > > ErrorF("-r turns off auto-repeat\n"); > > ErrorF("r turns on auto-repeat \n"); > > ErrorF("-render [default|mono|gray|color] set render color alloc > > policy\n"); > > -#ifndef __OpenBSD__ > > ErrorF("-retro start with classic stipple and > > cursor\n"); > > -#else > > -ErrorF("-retard start with black background and no > > cursor\n"); > > -#endif > > ErrorF("-s # screen-saver timeout (minutes)\n"); > > ErrorF("-seat string seat to run on\n"); > > ErrorF("-t # default pointer threshold > > (pixels/t)\n"); > > @@ -918,13 +914,8 @@ ProcessCommandLine(int argc, char *argv[ > > defaultKeyboardControl.autoRepeat = TRUE; > > else if (strcmp(argv[i], "-r") == 0) > > defaultKeyboardControl.autoRepeat = FALSE; > > -#ifndef __OpenBSD__ > > else if ( strcmp( argv[i], "-retro") == 0) > > party_like_its_1989 = TRUE; > > -#else > > - else if ( strcmp( argv[i], "-retard") == 0) > > - party_like_its_1989 = FALSE; > > -#endif > > else if (strcmp(argv[i], "-s") == 0) { > > if (++i < argc) > > defaultScreenSaverTime = ((CARD32) atoi(argv[i])) * > > > > >
Re: Xorg stipple
On Wed, Mar 09, 2016 at 05:09:13PM -0600, joshua stein wrote: > Is anyone seriously finding video/Xorg bugs through the default X > stipple pattern anymore? Xorg changed the default to draw a black > background a while ago (with stipple enabled using the -retro flag), > but we have this local change that reverted it while adding a silly > -retard flag in order to show the black background. > > I think we can finally stop partying like it's 1989 (vax is dead, > after all) and have X show a solid black background by default. I am fully supporting of this move. I am currently patching GDM to prevent having the ugly stipple pattern. > Index: dix/globals.c > === > RCS file: /var/cvs/xenocara/xserver/dix/globals.c,v > retrieving revision 1.11 > diff -u -p -u -p -r1.11 globals.c > --- dix/globals.c 16 Sep 2015 19:10:20 - 1.11 > +++ dix/globals.c 9 Mar 2016 22:57:54 - > @@ -118,11 +118,7 @@ const char *defaultCursorFont = COMPILED > FontPtr defaultFont;/* not declared in dix.h to avoid including > font.h in > every compilation of dix code */ > CursorPtr rootCursor; > -#ifndef __OpenBSD__ > Bool party_like_its_1989 = FALSE; > -#else > -Bool party_like_its_1989 = TRUE; > -#endif > Bool whiteRoot = FALSE; > > TimeStamp currentTime; > Index: os/utils.c > === > RCS file: /var/cvs/xenocara/xserver/os/utils.c,v > retrieving revision 1.21 > diff -u -p -u -p -r1.21 utils.c > --- os/utils.c7 Nov 2015 16:48:53 - 1.21 > +++ os/utils.c9 Mar 2016 22:57:37 - > @@ -579,11 +579,7 @@ UseMsg(void) > ErrorF("-r turns off auto-repeat\n"); > ErrorF("r turns on auto-repeat \n"); > ErrorF("-render [default|mono|gray|color] set render color alloc > policy\n"); > -#ifndef __OpenBSD__ > ErrorF("-retro start with classic stipple and cursor\n"); > -#else > -ErrorF("-retard start with black background and no > cursor\n"); > -#endif > ErrorF("-s # screen-saver timeout (minutes)\n"); > ErrorF("-seat string seat to run on\n"); > ErrorF("-t # default pointer threshold (pixels/t)\n"); > @@ -918,13 +914,8 @@ ProcessCommandLine(int argc, char *argv[ > defaultKeyboardControl.autoRepeat = TRUE; > else if (strcmp(argv[i], "-r") == 0) > defaultKeyboardControl.autoRepeat = FALSE; > -#ifndef __OpenBSD__ > else if ( strcmp( argv[i], "-retro") == 0) > party_like_its_1989 = TRUE; > -#else > - else if ( strcmp( argv[i], "-retard") == 0) > - party_like_its_1989 = FALSE; > -#endif > else if (strcmp(argv[i], "-s") == 0) { > if (++i < argc) > defaultScreenSaverTime = ((CARD32) atoi(argv[i])) * > -- Antoine
Re: Xorg stipple
Theo de Raadt wrote: > > > Is anyone seriously finding video/Xorg bugs through the default X > > > stipple pattern anymore? Xorg changed the default to draw a black > > > background a while ago (with stipple enabled using the -retro flag), > > > but we have this local change that reverted it while adding a silly > > > -retard flag in order to show the black background. > > > > > > I think we can finally stop partying like it's 1989 (vax is dead, > > > after all) and have X show a solid black background by default. > > > > The reason for this is to be able distinguish between: > > > > "I get a black screen because X is not working" > > > > and > > > > "I get a black screen because my desktop environment is not working" > > And as we all can observe, this problem has become more severe over > the last decade. Can anyone think of a good option that isn't black but is less hideous than stipple? Even a dark navy or something like that.
Re: Xorg stipple
> > Is anyone seriously finding video/Xorg bugs through the default X > > stipple pattern anymore? Xorg changed the default to draw a black > > background a while ago (with stipple enabled using the -retro flag), > > but we have this local change that reverted it while adding a silly > > -retard flag in order to show the black background. > > > > I think we can finally stop partying like it's 1989 (vax is dead, > > after all) and have X show a solid black background by default. > > The reason for this is to be able distinguish between: > > "I get a black screen because X is not working" > > and > > "I get a black screen because my desktop environment is not working" And as we all can observe, this problem has become more severe over the last decade.
Re: Xorg stipple
> Date: Wed, 9 Mar 2016 17:09:13 -0600 > From: joshua stein> > Is anyone seriously finding video/Xorg bugs through the default X > stipple pattern anymore? Xorg changed the default to draw a black > background a while ago (with stipple enabled using the -retro flag), > but we have this local change that reverted it while adding a silly > -retard flag in order to show the black background. > > I think we can finally stop partying like it's 1989 (vax is dead, > after all) and have X show a solid black background by default. The reason for this is to be able distinguish between: "I get a black screen because X is not working" and "I get a black screen because my desktop environment is not working" > Index: dix/globals.c > === > RCS file: /var/cvs/xenocara/xserver/dix/globals.c,v > retrieving revision 1.11 > diff -u -p -u -p -r1.11 globals.c > --- dix/globals.c 16 Sep 2015 19:10:20 - 1.11 > +++ dix/globals.c 9 Mar 2016 22:57:54 - > @@ -118,11 +118,7 @@ const char *defaultCursorFont = COMPILED > FontPtr defaultFont;/* not declared in dix.h to avoid including > font.h in > every compilation of dix code */ > CursorPtr rootCursor; > -#ifndef __OpenBSD__ > Bool party_like_its_1989 = FALSE; > -#else > -Bool party_like_its_1989 = TRUE; > -#endif > Bool whiteRoot = FALSE; > > TimeStamp currentTime; > Index: os/utils.c > === > RCS file: /var/cvs/xenocara/xserver/os/utils.c,v > retrieving revision 1.21 > diff -u -p -u -p -r1.21 utils.c > --- os/utils.c7 Nov 2015 16:48:53 - 1.21 > +++ os/utils.c9 Mar 2016 22:57:37 - > @@ -579,11 +579,7 @@ UseMsg(void) > ErrorF("-r turns off auto-repeat\n"); > ErrorF("r turns on auto-repeat \n"); > ErrorF("-render [default|mono|gray|color] set render color alloc > policy\n"); > -#ifndef __OpenBSD__ > ErrorF("-retro start with classic stipple and cursor\n"); > -#else > -ErrorF("-retard start with black background and no > cursor\n"); > -#endif > ErrorF("-s # screen-saver timeout (minutes)\n"); > ErrorF("-seat string seat to run on\n"); > ErrorF("-t # default pointer threshold (pixels/t)\n"); > @@ -918,13 +914,8 @@ ProcessCommandLine(int argc, char *argv[ > defaultKeyboardControl.autoRepeat = TRUE; > else if (strcmp(argv[i], "-r") == 0) > defaultKeyboardControl.autoRepeat = FALSE; > -#ifndef __OpenBSD__ > else if ( strcmp( argv[i], "-retro") == 0) > party_like_its_1989 = TRUE; > -#else > - else if ( strcmp( argv[i], "-retard") == 0) > - party_like_its_1989 = FALSE; > -#endif > else if (strcmp(argv[i], "-s") == 0) { > if (++i < argc) > defaultScreenSaverTime = ((CARD32) atoi(argv[i])) * > >
Re: Xorg stipple
On Wed, 9 Mar 2016, joshua stein wrote: > Is anyone seriously finding video/Xorg bugs through the default X > stipple pattern anymore? Xorg changed the default to draw a black > background a while ago (with stipple enabled using the -retro flag), > but we have this local change that reverted it while adding a silly > -retard flag in order to show the black background. > > I think we can finally stop partying like it's 1989 (vax is dead, > after all) and have X show a solid black background by default. X11 isn't my area, but 1000 x YES PLEASE