Re: bluhm's splsoftassert

2016-10-18 Thread David Hill
On Tue, Sep 20, 2016 at 04:17:37PM +0200, Mike Belopuhov wrote: > On 20 September 2016 at 15:55, Alexander Bluhm > wrote: > > On Tue, Sep 20, 2016 at 08:21:55AM -0400, David Hill wrote: > >> With bluhm's r1.160 uipc_socket.c. > > > > With splsoftnet() in soshutdown() I can fix this one. > > > > s

Re: bluhm's splsoftassert

2016-09-21 Thread David Hill
On Wed, Sep 21, 2016 at 12:32:50PM -0400, David Hill wrote: > Hit another. > > splassert: sorwakeup: want 5 have 0 > Starting stack trace... > splassert_check() at splassert_check+0x78 > sorwakeup() at sorwakeup+0x27 > route_input() at route_input+0x284 > ifioctl() at ifioctl+0x765 > sys_ioctl() a

Re: bluhm's splsoftassert

2016-09-21 Thread David Hill
Hit another. splassert: sorwakeup: want 5 have 0 Starting stack trace... splassert_check() at splassert_check+0x78 sorwakeup() at sorwakeup+0x27 route_input() at route_input+0x284 ifioctl() at ifioctl+0x765 sys_ioctl() at sys_ioctl+0x196 syscall() at syscall+0x27b --- syscall (number 54) --- end o

Re: bluhm's splsoftassert

2016-09-20 Thread Mike Belopuhov
On Tue, Sep 20, 2016 at 17:20 +0200, Martin Pieuchot wrote: > On 20/09/16(Tue) 17:04, Mike Belopuhov wrote: > > On Tue, Sep 20, 2016 at 10:51 -0400, David Hill wrote: > > > On Tue, Sep 20, 2016 at 09:53:02AM -0400, David Hill wrote: > > > > More... > > > > > > > > splassert: sorwakeup: want 5 have

Re: bluhm's splsoftassert

2016-09-20 Thread Mike Belopuhov
On 20 September 2016 at 17:09, Martin Pieuchot wrote: > On 20/09/16(Tue) 10:51, David Hill wrote: >> On Tue, Sep 20, 2016 at 09:53:02AM -0400, David Hill wrote: >> > More... >> > >> > splassert: sorwakeup: want 5 have 0 >> > Starting stack trace... >> > splassert_check() at splassert_check+0x78 >>

Re: bluhm's splsoftassert

2016-09-20 Thread Martin Pieuchot
On 20/09/16(Tue) 17:04, Mike Belopuhov wrote: > On Tue, Sep 20, 2016 at 10:51 -0400, David Hill wrote: > > On Tue, Sep 20, 2016 at 09:53:02AM -0400, David Hill wrote: > > > More... > > > > > > splassert: sorwakeup: want 5 have 0 > > > Starting stack trace... > > > splassert_check() at splassert_ch

Re: bluhm's splsoftassert

2016-09-20 Thread David Hill
On Tue, Sep 20, 2016 at 05:04:02PM +0200, Mike Belopuhov wrote: > On Tue, Sep 20, 2016 at 10:51 -0400, David Hill wrote: > > On Tue, Sep 20, 2016 at 09:53:02AM -0400, David Hill wrote: > > > More... > > > > > > splassert: sorwakeup: want 5 have 0 > > > Starting stack trace... > > > splassert_check

Re: bluhm's splsoftassert

2016-09-20 Thread Theo Buehler
On Tue, Sep 20, 2016 at 05:09:41PM +0200, Martin Pieuchot wrote: > On 20/09/16(Tue) 10:51, David Hill wrote: > > On Tue, Sep 20, 2016 at 09:53:02AM -0400, David Hill wrote: > > > More... > > > > > > splassert: sorwakeup: want 5 have 0 > > > Starting stack trace... > > > splassert_check() at splass

Re: bluhm's splsoftassert

2016-09-20 Thread Theo Buehler
On Tue, Sep 20, 2016 at 05:04:02PM +0200, Mike Belopuhov wrote: > On Tue, Sep 20, 2016 at 10:51 -0400, David Hill wrote: > > On Tue, Sep 20, 2016 at 09:53:02AM -0400, David Hill wrote: > > > More... > > > > > > splassert: sorwakeup: want 5 have 0 > > > Starting stack trace... > > > splassert_check

Re: bluhm's splsoftassert

2016-09-20 Thread Martin Pieuchot
On 20/09/16(Tue) 10:51, David Hill wrote: > On Tue, Sep 20, 2016 at 09:53:02AM -0400, David Hill wrote: > > More... > > > > splassert: sorwakeup: want 5 have 0 > > Starting stack trace... > > splassert_check() at splassert_check+0x78 > > sorwakeup() at sorwakeup+0x27 > > route_input() at route_inp

Re: bluhm's splsoftassert

2016-09-20 Thread Mike Belopuhov
On Tue, Sep 20, 2016 at 10:51 -0400, David Hill wrote: > On Tue, Sep 20, 2016 at 09:53:02AM -0400, David Hill wrote: > > More... > > > > splassert: sorwakeup: want 5 have 0 > > Starting stack trace... > > splassert_check() at splassert_check+0x78 > > sorwakeup() at sorwakeup+0x27 > > route_input()

Re: bluhm's splsoftassert

2016-09-20 Thread Mike Belopuhov
On 20 September 2016 at 16:50, Martin Pieuchot wrote: > On 20/09/16(Tue) 16:37, Alexander Bluhm wrote: >> On Tue, Sep 20, 2016 at 04:17:37PM +0200, Mike Belopuhov wrote: >> > Can we assert that *_usrreq is always called under splsoftnet? >> >> I think that is the way to go. Long time back the spl

Re: bluhm's splsoftassert

2016-09-20 Thread David Hill
On Tue, Sep 20, 2016 at 09:53:02AM -0400, David Hill wrote: > More... > > splassert: sorwakeup: want 5 have 0 > Starting stack trace... > splassert_check() at splassert_check+0x78 > sorwakeup() at sorwakeup+0x27 > route_input() at route_input+0x284 > pflog_clone_create() at pflog_clone_create+0xa4

Re: bluhm's splsoftassert

2016-09-20 Thread Martin Pieuchot
On 20/09/16(Tue) 16:37, Alexander Bluhm wrote: > On Tue, Sep 20, 2016 at 04:17:37PM +0200, Mike Belopuhov wrote: > > Can we assert that *_usrreq is always called under splsoftnet? > > I think that is the way to go. Long time back the spl moved from > inet to socket. We need it in the socket laye

Re: bluhm's splsoftassert

2016-09-20 Thread Alexander Bluhm
On Tue, Sep 20, 2016 at 04:17:37PM +0200, Mike Belopuhov wrote: > Can we assert that *_usrreq is always called under splsoftnet? I think that is the way to go. Long time back the spl moved from inet to socket. We need it in the socket layer to fix various races. > I recall fixing some of them f

Re: bluhm's splsoftassert

2016-09-20 Thread Mike Belopuhov
On 20 September 2016 at 15:55, Alexander Bluhm wrote: > On Tue, Sep 20, 2016 at 08:21:55AM -0400, David Hill wrote: >> With bluhm's r1.160 uipc_socket.c. > > With splsoftnet() in soshutdown() I can fix this one. > > splassert: sowwakeup: want 5 have 0 > Starting stack trace... > splassert_check()

Re: bluhm's splsoftassert

2016-09-20 Thread Alexander Bluhm
On Tue, Sep 20, 2016 at 03:39:17PM +0200, Mike Belopuhov wrote: > On Tue, Sep 20, 2016 at 09:19 -0400, David Hill wrote: > > Another... > > > > splassert: sorwakeup: want 5 have 4 > > Starting stack trace... > > splassert_check() at splassert_check+0x78 > > sorwakeup() at sorwakeup+0x27 > > pfkey_

Re: bluhm's splsoftassert

2016-09-20 Thread Alexander Bluhm
On Tue, Sep 20, 2016 at 08:21:55AM -0400, David Hill wrote: > With bluhm's r1.160 uipc_socket.c. With splsoftnet() in soshutdown() I can fix this one. splassert: sowwakeup: want 5 have 0 Starting stack trace... splassert_check() at splassert_check+0x78 sowwakeup() at sowwakeup+0x27 uipc_usrreq()

Re: bluhm's splsoftassert

2016-09-20 Thread David Hill
More... splassert: sorwakeup: want 5 have 0 Starting stack trace... splassert_check() at splassert_check+0x78 sorwakeup() at sorwakeup+0x27 route_input() at route_input+0x284 pflog_clone_create() at pflog_clone_create+0xa4 if_clone_create() at if_clone_create+0x7f ifioctl() at ifioctl+0x35a sys_io

Re: bluhm's splsoftassert

2016-09-20 Thread David Hill
Another splassert: sowwakeup: want 5 have 0 Starting stack trace... splassert_check() at splassert_check+0x78 sowwakeup() at sowwakeup+0x27 uipc_usrreq() at uipc_usrreq+0xfd sys_shutdown() at sys_shutdown+0x67 syscall() at syscall+0x27b --- syscall (number 134) --- end of kernel end trace frame: 0

Re: bluhm's splsoftassert

2016-09-20 Thread Mike Belopuhov
On Tue, Sep 20, 2016 at 09:19 -0400, David Hill wrote: > Another... > > splassert: sorwakeup: want 5 have 4 > Starting stack trace... > splassert_check() at splassert_check+0x78 > sorwakeup() at sorwakeup+0x27 > pfkey_sendup() at pfkey_sendup+0x99 > pfkeyv2_sendmessage() at pfkeyv2_sendmessage+0x2

Re: bluhm's splsoftassert

2016-09-20 Thread Alexander Bluhm
On Tue, Sep 20, 2016 at 09:27:57AM -0400, David Hill wrote: > On Tue, Sep 20, 2016 at 03:16:50PM +0200, Alexander Bluhm wrote: > > On Tue, Sep 20, 2016 at 08:21:55AM -0400, David Hill wrote: > > > With bluhm's r1.160 uipc_socket.c. > > > Here are the first ones that were detected. > > > > Thanks f

Re: bluhm's splsoftassert

2016-09-20 Thread David Hill
On Tue, Sep 20, 2016 at 03:16:50PM +0200, Alexander Bluhm wrote: > On Tue, Sep 20, 2016 at 08:21:55AM -0400, David Hill wrote: > > With bluhm's r1.160 uipc_socket.c. > > Here are the first ones that were detected. > > Thanks for the fast report. > > So fifo works around the socket layer. Better

Re: bluhm's splsoftassert

2016-09-20 Thread Mike Belopuhov
On 20 September 2016 at 15:16, Alexander Bluhm wrote: > On Tue, Sep 20, 2016 at 08:21:55AM -0400, David Hill wrote: >> With bluhm's r1.160 uipc_socket.c. >> Here are the first ones that were detected. > > Thanks for the fast report. > > So fifo works around the socket layer. Better call soconnect

Re: bluhm's splsoftassert

2016-09-20 Thread David Hill
And another. splassert: sorwakeup: want 5 have 4 Starting stack trace... splassert_check() at splassert_check+0x78 sorwakeup() at sorwakeup+0x27 pfkey_sendup() at pfkey_sendup+0x99 pfkeyv2_sendmessage() at pfkeyv2_sendmessage+0x226 pfkeyv2_expire() at pfkeyv2_expire+0x18d tdb_soft_timeout() at tdb

Re: bluhm's splsoftassert

2016-09-20 Thread David Hill
Another... splassert: sorwakeup: want 5 have 4 Starting stack trace... splassert_check() at splassert_check+0x78 sorwakeup() at sorwakeup+0x27 pfkey_sendup() at pfkey_sendup+0x99 pfkeyv2_sendmessage() at pfkeyv2_sendmessage+0x226 pfkeyv2_expire() at pfkeyv2_expire+0x18d tdb_timeout() at tdb_timeou

Re: bluhm's splsoftassert

2016-09-20 Thread Alexander Bluhm
On Tue, Sep 20, 2016 at 08:21:55AM -0400, David Hill wrote: > With bluhm's r1.160 uipc_socket.c. > Here are the first ones that were detected. Thanks for the fast report. So fifo works around the socket layer. Better call soconnect2() instead of unp_connect2(). This adds the missing splsoftnet(

bluhm's splsoftassert

2016-09-20 Thread David Hill
Hello - With bluhm's r1.160 uipc_socket.c. Here are the first ones that were detected. splassert: sowwakeup: want 5 have 0 Starting stack trace... splassert_check() at splassert_check+0x78 sowwakeup() at sowwakeup+0x27 unp_connect2() at unp_connect2+0x62 fifo_open() at fifo_open+0x244 VOP_OPEN()