[tw5] Re: Git hub saver

2020-12-24 Thread 'Mark S.' via TiddlyWiki
On Thursday, December 24, 2020 at 4:07:08 PM UTC-8 wrote: > >> > I believe we have always been able to save to any branch we want. The only > limitation is that only one branch for a given repository can be published > via github pages to be served over HTTP, which is a github limitation and

[tw5] Re: Git hub saver

2020-12-24 Thread Saq Imtiaz
> > So, I guess what you're saying is that we didn't need $:/GitHub/Branch > before and therefore I never created it (because the default was good > enough). > Precisely. The default value in 5.1.21 shown in the UI for the saver is what you wanted, so you never edited it and $:/Github/Branch

[tw5] Re: Git hub saver

2020-12-24 Thread 'Mark S.' via TiddlyWiki
Ok, think I got it. When I go back to my last commit from 3 months ago, I see that there is no $:/GitHub/ <#%24%3A%2FGitHub%2FUsername>Branch So, I guess what you're saying is that we didn't need $:/GitHub/Branch before and therefore I never created it (because the default was good enough).

[tw5] Re: Git hub saver

2020-12-24 Thread 'Mark S.' via TiddlyWiki
On Thursday, December 24, 2020 at 3:14:52 PM UTC-8 wrote: > > As am I. I suggest re-reading my previous message with this in mind, as > well as last looking at the links provided here and in the GitHub issue. An > input field being filled in does not necessarily mean the underlying > tiddler

[tw5] Re: Git hub saver

2020-12-24 Thread Saq Imtiaz
> I'm not talking about a brand-new setup on Github. I'm talking about an > existing one. So all the fields already had values. > As am I. I suggest re-reading my previous message with this in mind, as well as last looking at the links provided here and in the GitHub issue. An input field

[tw5] Re: Git hub saver

2020-12-24 Thread 'Mark S.' via TiddlyWiki
On Thursday, December 24, 2020 at 1:17:47 PM UTC-8 wrote: > I would wager you never entered a value for the branch, but rather used > the displayed default which is pre-filled as "master". > Thus the $:/Github/Branch tiddler was never created in your wiki (it isn't > new for 5.1.23). Like

[tw5] Re: Git hub saver

2020-12-24 Thread Saq Imtiaz
I would wager you never entered a value for the branch, but rather used the displayed default which is pre-filled as "master". Thus the $:/Github/Branch tiddler was never created in your wiki (it isn't new for 5.1.23). Like all the other tiddlers for the Github saver, it is only created when

[tw5] Re: Git hub saver

2020-12-24 Thread 'Mark S.' via TiddlyWiki
So I guess that configuration tiddler $:/GitHub/Branch was added to 5.1.23 (it doesn't seem to be in 5.1.22) ? I'm trying to understand why my existing configuration didn't persist through the upgrade process, no matter what the default attribute provided. All the other configurations (path,

[tw5] Re: Git hub saver

2020-12-24 Thread Saq Imtiaz
@Mark S I posted some details in the issue I created for this: https://github.com/Jermolene/TiddlyWiki5/issues/5317 The text you see is from the default attribute of the <$edit-text> in the UI, see https://github.com/Jermolene/TiddlyWiki5/blob/master/core/ui/ControlPanel/Saving/GitHub.tid#L13

[tw5] Re: Git hub saver

2020-12-24 Thread 'Mark S.' via TiddlyWiki
I don't understand. My branch was specified (it shows as "master" in the saver panel). But I had to delete it and type it in again to get it to work. So is there an internal 5.1.23 configuration file that has to be overwritten? Thanks! On Thursday, December 24, 2020 at 11:37:56 AM UTC-8

[tw5] Re: Git hub saver

2020-12-24 Thread Saq Imtiaz
Yep, we have our first bug. The placeholder shown when the branch has not been specified is "master", but the code uses "main" for the branch. The interim fix for users is fortunately easy, just empty and re-fill the branch name. On Thursday, December 24, 2020 at 8:33:15 PM UTC+1 Saq Imtiaz

[tw5] Re: Git hub saver

2020-12-24 Thread Saq Imtiaz
Hmm. I am a bit surprised that worked. I wonder if the changes made to the Github saver to reflect the change made by Github to the default branch (master vs main) got something wrong. On Thursday, December 24, 2020 at 8:30:50 PM UTC+1 Ste wrote: > Cheers Saq! > Refilled in all fields and

[tw5] Re: Git hub saver

2020-12-24 Thread Ste
Cheers Saq! Refilled in all fields and for some reason.. It works..! On Thursday, 24 December 2020 at 19:25:22 UTC Ste wrote: > Just reread my own post.. Let me clarify... Using the git hub saving in > tiddlywiki works in pre release but not from newly upgraded. This is true > both with the

[tw5] Re: Git hub saver

2020-12-24 Thread Ste
Just reread my own post.. Let me clarify... Using the git hub saving in tiddlywiki works in pre release but not from newly upgraded. This is true both with the file on my phone or the new file uploaded to git hub and trying the github saver from there. XMLHttpRequest error code: 401 Sorry.

[tw5] Re: Git hub saver

2020-12-24 Thread Saq Imtiaz
Long shot, but whatever is entered for "target branch", remove it and re-enter. Check your repo to make sure you have the right branch name (master/main). On Thursday, December 24, 2020 at 8:10:55 PM UTC+1 Ste wrote: > I'm sure it's my own muppetry and that I'm trying to do this on my phone >