Re: [Tigervnc-devel] Deprecating "video" and generic pixel format support

2009-03-05 Thread Pierre Ossman
On Thu, 26 Feb 2009 13:40:15 +0100 Adam Tkac wrote: > On Thu, Feb 26, 2009 at 12:49:58PM +0100, Pierre Ossman wrote: > > > > The problem is that the code is very macro happy, so a basic profiler > > will not easily tell you where the cycles are spent. If you dig a bit > > more you'll see that th

Re: [Tigervnc-devel] Deprecating "video" and generic pixel format support

2009-03-05 Thread Peter Åstrand
This seems to be a style inherited from RealVNC. As such, any major cleanup will mean that vendor drops won't be as easy when it comes to the encoder/decoder parts. Is this still okay with everyone? Ok with me. Regards, --- Peter Åstrand ThinLinc Chief Developer Cendio AB

Re: [Tigervnc-devel] Deprecating "video" and generic pixel format support

2009-03-05 Thread Pierre Ossman
On Thu, 5 Mar 2009 15:07:33 +0100 (CET) Peter Åstrand wrote: > > >This seems to be a style inherited from RealVNC. As such, any major > >cleanup will mean that vendor drops won't be as easy when it comes to > >the encoder/decoder parts. Is this still okay with everyone? > > Ok with me. > That

[Tigervnc-devel] 24-bit default

2009-03-05 Thread Pierre Ossman
The server current selects a 16 bit framebuffer by default. I vote we change this to 24-bit for the following reasons: - It's what everyone else uses on their desktops and is therefore the most tested method. We here at Cendio have already noticed a series of annoying compatibility problems

Re: [Tigervnc-devel] 24-bit default

2009-03-05 Thread Karl J. Runge
On Thu, 5 Mar 2009, Pierre Ossman wrote: > > The downside to this is a potential increase in bandwidth. I'm not sure > there is one in practice though. It's not clear to me how the choice would affect network bandwidth usage because the vnc client normally selects the bpp and depth, right? Karl

Re: [Tigervnc-devel] 24-bit default

2009-03-05 Thread Pierre Ossman
On Thu, 05 Mar 2009 10:13:40 -0500 "Karl J. Runge" wrote: > On Thu, 5 Mar 2009, Pierre Ossman wrote: > > > > The downside to this is a potential increase in bandwidth. I'm not sure > > there is one in practice though. > > It's not clear to me how the choice would affect network bandwidth > usa

Re: [Tigervnc-devel] 24-bit default

2009-03-05 Thread Karl J. Runge
On Thu, 5 Mar 2009, Pierre Ossman wrote: > On Thu, 05 Mar 2009 10:13:40 -0500 > > It's not clear to me how the choice would affect network bandwidth > > usage because the vnc client normally selects the bpp and depth, right? > > Silly me. You're of course correct. BTW, I think your desire to cha

Re: [Tigervnc-devel] 24-bit default

2009-03-05 Thread Peter Åstrand
On Thu, 5 Mar 2009, Karl J. Runge wrote: I wonder why the Xvnc default was set to 16bpp? Do you know if Realvnc does this or is it a Tightvnc change? VFB_DEFAULT_DEPTH is defined as 16 in xvnc.cc. It seems it has been defined as 16 in all RealVNC 4.X versions, see: http://tigervnc.svn.sour

Re: [Tigervnc-devel] 24-bit default

2009-03-05 Thread Patrik Pira
Pierre Ossman wrote: > The server current selects a 16 bit framebuffer by default. I vote we > change this to 24-bit for the following reasons: > > - It's what everyone else uses on their desktops and is therefore the >most tested method. We here at Cendio have already noticed a series >o