Re: [Tigervnc-devel] [PATCH] Support more menu keys

2011-08-31 Thread Martin Koegler
On Wed, Aug 31, 2011 at 10:15:34AM +0200, Peter ?strand wrote: > On Tue, 30 Aug 2011, DRC wrote: > > >On 8/30/11 5:33 AM, Pierre Ossman wrote: > >>You seem to be providing good stuff, so I'd vote for you getting > >>commit rights. Adam? DRC? Any objections? > > > >No objections here-- just standar

Re: [Tigervnc-devel] [PATCH] Support more menu keys

2011-08-31 Thread Peter Åstrand
On Tue, 30 Aug 2011, DRC wrote: On 8/30/11 5:33 AM, Pierre Ossman wrote: You seem to be providing good stuff, so I'd vote for you getting commit rights. Adam? DRC? Any objections? No objections here-- just standard rules for everyone: before committing any potentially disruptive new features

[Tigervnc-devel] [PATCH] Support more menu keys

2011-08-30 Thread Martin Koegler
--- V1: keysyms.* renamed to menukey.* vncviewer/CMakeLists.txt|1 + vncviewer/OptionsDialog.cxx | 20 vncviewer/Viewport.cxx | 12 +-- vncviewer/menukey.cxx | 71 +++ vncviewer/menukey.h | 30

Re: [Tigervnc-devel] [PATCH] Support more menu keys

2011-08-30 Thread DRC
On 8/30/11 5:33 AM, Pierre Ossman wrote: > You seem to be providing good stuff, so I'd vote for you getting > commit rights. Adam? DRC? Any objections? No objections here-- just standard rules for everyone: before committing any potentially disruptive new features, always discuss with the list

Re: [Tigervnc-devel] [PATCH] Support more menu keys

2011-08-30 Thread Pierre Ossman
On Fri, 26 Aug 2011 20:29:17 +0200 Martin Koegler wrote: > On Fri, Aug 26, 2011 at 09:36:25AM +0200, Pierre Ossman wrote: > > Looks good to me, with two notes: > > > > > vncviewer/keysyms.cxx | 71 > > > +++ > > > vncviewer/keysyms.h |

Re: [Tigervnc-devel] [PATCH] Support more menu keys

2011-08-26 Thread DRC
On 8/26/11 12:29 PM, Martin Koegler wrote: > The three column approach would proably be the best. +1 -- EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified mana

Re: [Tigervnc-devel] [PATCH] Support more menu keys

2011-08-26 Thread Martin Koegler
On Fri, Aug 26, 2011 at 09:36:25AM +0200, Pierre Ossman wrote: > Looks good to me, with two notes: > > > vncviewer/keysyms.cxx | 71 > > +++ > > vncviewer/keysyms.h | 30 ++ > > Perhaps another name might be better as to n

Re: [Tigervnc-devel] [PATCH] Support more menu keys

2011-08-26 Thread Pierre Ossman
Hi Martin, Looks good to me, with two notes: > vncviewer/keysyms.cxx | 71 > +++ > vncviewer/keysyms.h | 30 ++ Perhaps another name might be better as to not confuse this with the X11/VNC keysym handling? menukey.*? > +

[Tigervnc-devel] [PATCH] Support more menu keys

2011-08-25 Thread Martin Koegler
--- vncviewer/CMakeLists.txt|1 + vncviewer/OptionsDialog.cxx | 20 vncviewer/Viewport.cxx | 12 +-- vncviewer/keysyms.cxx | 71 +++ vncviewer/keysyms.h | 30 ++ 5 files changed, 111 inserti