Re: [Toaster] [PATCH] toaster: ensure ToasterTable chrome is redrawn when ordering changes

2016-03-23 Thread Michael Wood
I'd rather you didn't remove the chrome redraw optimisation, that saves redrawing the chrome on lots of other table operations. Just storing the default order by would be sufficient: diff --git a/bitbake/lib/toaster/toastergui/static/js/table.js b/bitbake/lib/to index a7e4fba..e9c5225 100644

Re: [Toaster] localhostbecontroller error

2016-03-29 Thread Michael Wood
Hi Daniel, Could you describe your project setup, I'll try and see if I can recreate the issue; what version of toaster are you using? and what release is the project set to? Thanks, Michael On 28/03/16 19:57, Daniel Goguen wrote: Hi All, I've successfully created a few .hddimg files that

Re: [Toaster] Toaster Weekly Meeting Minutes 03/30/16

2016-03-30 Thread Michael Wood
Just updated a wiki page which contains a bit more of an overview of Toaster as I don't think we have anything high level at the moment. Could do with more detail but hopefully others can also add to it. https://wiki.yoctoproject.org/wiki/Toaster_architecture_design On 30/03/16 16:43, Jolley,

Re: [Toaster] [PATCH 5/5] toaster-tests: migrate landing page tests to Selenium

2016-03-31 Thread Michael Wood
Hijacking this with a bit of an RFC, but as I'm looking at tests at the moment, shall we start consolidating the tests in a single directory? I was thinking: ├──bitbake/lib/toaster/tests │ ├── browser │ ├── views │ ├── build │ ├── api │ ├── static ...etc usage ./manage.py test tests

Re: [Toaster] Review required for patches related to bug 7005

2016-03-31 Thread Michael Wood
Done a quick review on IRC we'll try to convert the project page from doing a POST directly to the view to use the ajax+ReST like approach we have else where (e.g. custom image recipes). Michael On 30/03/16 16:04, sujith h wrote: Hi, I have posted my changes for bug 7005: http://git.yoctopr

Re: [Toaster] [PATCH 5/5] toaster-tests: migrate landing page tests to Selenium

2016-03-31 Thread Michael Wood
Yes that'd be great. Michael On 31/03/16 16:06, Smith, Elliot wrote: Sounds like a good idea to me. Do you want me to amend my branch to start the ball rolling? Elliot On 31 March 2016 at 15:41, Michael Wood <mailto:michael.g.w...@intel.com>> wrote: Hijacking this with a

Re: [Toaster] [PATCH 5/5] toaster-tests: migrate landing page tests to Selenium

2016-03-31 Thread Michael Wood
virtualenv if using) $ cd ./bitbake/lib/toaster/ $ pip install -r ./tests/toaster-tests-requirements.txt $ TOASTER_TESTS_BROWSER=firefox ./manage.py test tests.browser Michael On 31/03/16 16:12, Michael Wood wrote: Yes that'd be great. Michael On 31/03/16 16:06, Smith, Elliot wrote: S

[Toaster] [review-request] michaelw/toaster/selenium-test-js

2016-04-04 Thread Michael Wood
-contrib/log/?h=michaelw/toaster/selenium-test-js Michael Wood (5): toaster: Add quint to project so that it can be used offline toaster: tests Set MACHINE for the test projects toaster: views jsunittest Add MACHINE and an extra layer to test project toaster: testsjs Add call back to append

Re: [Toaster] Removing 7844358 from toaster-next ("create Build object earlier in bitbake processing")

2016-04-04 Thread Michael Wood
it's never used anywhere in Toaster, so it has been removed (along with any functions which refer to it). [YOCTO #8440] Signed-off-by: Elliot Smith <mailto:elliot.sm...@intel.com>> Signed-off-by: Michael Wood <mailto:mic

Re: [Toaster] [PATCH v9 00/42] per project build directory + build cancel + DL_DIR/SSTATE_DIR

2016-04-06 Thread Michael Wood
oasterui: update build in internal state toaster: reorder migrations Michael Wood (9): toaster: Move xhr calls for starting and stopping builds toaster: xhr Update the implementation of the build cancellation request toaster: libtoaster Update implementation of startABuild and cancel

Re: [Toaster] Outstanding review requests

2016-04-19 Thread Michael Wood
All pushed to toaster-next and upstream Thanks Michael On 19/04/16 11:49, Smith, Elliot wrote: I have the following review requests outstanding, if someone could please review them for me. The links go to the original request on the mailing list where I explain how to test etc.; the related

Re: [Toaster] [PATCH 2/2] toaster: fix sorting after hiding a column in build tables

2016-04-19 Thread Michael Wood
Sent to bitbake-devel and added to toaster-next Thanks, Michael On 29/03/16 10:07, Elliot Smith wrote: When hiding a column in the build tasks or build packages included table, if the column is set as the current order by for the table, the order by is not reset to the default. The result is t

Re: [Toaster] [PATCH 1/3] toaster: add build dashboard buttons to edit/create custom images

2016-04-19 Thread Michael Wood
Sent to bitbake-devel and added to toaster-next Thanks, Michael On 11/04/16 15:56, Elliot Smith wrote: When a build is viewed in the dashboard, enable users to edit a custom image which was built during that build, and/or create a new custom image based on one of the image recipes built during

Re: [Toaster] [PATCH 0/4] Validate custom image names correctly

2016-04-19 Thread Michael Wood
Sent to bitbake-devel and added to toaster-next Thanks, Michael On 14/04/16 08:13, Smith, Elliot wrote: Thanks for the review, Dave. I'll have another look at this once the Bootstrap 3 work is done. Elliot On 13 April 2016 at 21:57, Lerner, Dave M (Wind River) mailto:dave.ler...@windriver

Re: [Toaster] Outstanding review requests

2016-04-19 Thread Michael Wood
All done On 19/04/16 11:49, Smith, Elliot wrote: I have the following review requests outstanding, if someone could please review them for me. The links go to the original request on the mailing list where I explain how to test etc.; the related bug numbers are in the branch names. * ellio

Re: [Toaster] [PATCH] toaster: disable/enable "Add layer" button according to input's content

2016-04-19 Thread Michael Wood
Sent to bitbake-devel and added to toaster-next Thanks, Michael On 12/04/16 15:23, Smith, Elliot wrote: Thanks for the review. Yes, that should be possible. Note that I have to rework this a bit anyway because of the bootstrap 3 changes, which will have an impact on it. It might be best to

[Toaster] Toaster planning for 2.2

2016-04-20 Thread Michael Wood
Hi All, I've updated the Wiki for the release planning for 2.2 and updated my section, for me it's mostly been a case of cleaning up what we achieved for 2.1. https://wiki.yoctoproject.org/wiki/Toaster_future_release_planning Michael -- ___ toaster

[Toaster] [PATCH 2/3] toaster: bin/toaster Add ability to specify port and address to bind to

2016-04-20 Thread Michael Wood
Allow binding to a specified address and port to start the django development server on. Remove the assumption that you want to bind to 0.0.0.0 and set the default to localhost. Add some additional help text after Toaster webserver has started Signed-off-by: Michael Wood --- bitbake/bin/toaster

[Toaster] [PATCH 3/3] toaster: bin/toaster Fix noweb command

2016-04-20 Thread Michael Wood
For the noweb command we don't need to check if a socket is in use or not as we're not starting the django development server. We're just setting up the environment and running the runbuilds scheduler. Signed-off-by: Michael Wood --- bitbake/bin/toaster | 4 +++- 1 file change

[Toaster] [PATCH 1/3] toaster: bin/toaster Add help text for unrecognised command

2016-04-20 Thread Michael Wood
Add help text for unrecognised or missing command for toaster script Remove assumption that no command is 'start' as the default. Signed-off-by: Michael Wood --- bitbake/bin/toaster | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/bitbake/b

Re: [Toaster] Weird migration issue

2016-04-21 Thread Michael Wood
t, while at ELC, someone came to me because they were having the same problem. His trace is below. Restarting the host seems to solve the problem for me. In his case, he tried a different host and everything worked. It doesn't seem distro-related: his was CentOS, mine Ubuntu. That's all I kno

[Toaster] [PATCH 1/2] toaster: orm Add get_base_recipe_file to CustomImageRecipe

2016-04-25 Thread Michael Wood
fixes also added in generate_recipe_file_contents Signed-off-by: Michael Wood --- bitbake/lib/toaster/orm/models.py | 60 --- 1 file changed, 37 insertions(+), 23 deletions(-) diff --git a/bitbake/lib/toaster/orm/models.py b/bitbake/lib/toaster/orm/models.py

[Toaster] [PATCH 2/2] toaster: customrecipe Only show download icon or button if it's possible

2016-04-25 Thread Michael Wood
If the based on recipe has not yet been checked out/cloned we cannot generate the custom image recipe file that uses it. So disable/remove the option to download it. [YOCTO #9425] Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/tables.py | 4 +++- bitbake/lib

Re: [Toaster] Review required for patches related to bug 7005

2016-04-25 Thread Michael Wood
Hi Sujith, Thanks for the patches here is some code-review, it's mostly cosmetic issues: http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=sujith/toaster-unique-projectname&id=17739189416e444d8dce7cb7c64aaf776f85d1ff From 17739189416e444d8dce7cb7c64aaf776f85d1ff Mon Sep 17 00:0

[Toaster] [PATCH 1/5] toaster: Remove DATABASE_URL being passed around as an environment var

2016-04-25 Thread Michael Wood
. This is preparation work to migrate the build tests and be able to trigger builds on differently configured databases. Signed-off-by: Michael Wood --- bitbake/bin/toaster| 2 - bitbake/lib/bb/ui/buildinfohelper.py | 20 +++ .../toastermain/

[Toaster] [PATCH 3/5] toaster: Add a specific test settings file

2016-04-25 Thread Michael Wood
When running certain tests we want a particular database specified. When bitbake toaster ui is being tested pass it these test settings so that it uses the same database as the unit tests running. Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastermain/settings-test.py | 41

[Toaster] [PATCH 4/5] toaster: tests Add a BuildTest helper class

2016-04-25 Thread Michael Wood
Add a helper class for running build tests. Subclass this and call the build method to get setup for running tests on the resulting data from a build. Signed-off-by: Michael Wood --- bitbake/lib/toaster/tests/builds/__init__.py | 0 bitbake/lib/toaster/tests/builds/buildtest.py | 133

[Toaster] [PATCH 5/5] toaster: tests build Add a test for a build of core-image-minimal

2016-04-25 Thread Michael Wood
This is a port of the oe self test to the django test framework from oe-core meta/lib/oeqa/selftest/_toaster.py Signed-off-by: Michael Wood --- .../toaster/tests/builds/test_core_image_min.py| 389 + 1 file changed, 389 insertions(+) create mode 100644 bitbake/lib

[Toaster] [PATCH 2/5] toaster: runbuilds move the execution sequence out of the poll loop

2016-04-25 Thread Michael Wood
Move the execution sequence for a build out of the polling loop and into it's own fuction. This means that we can call the function on it's own if we just want to trigger one build rather than infinite polling. This is something needed for the build tests. Signed-off-by: Mi

Re: [Toaster] Automatically import current configuration on fresh toaster installation

2016-04-27 Thread Michael Wood
Hi David, Unfortunately we don't currently support importing your existing configuration into toaster. Though this is a feature we'd like to have. The supported use case is either using Toaster to view builds being done on the command line or to configure your build in a project in Toaster. (

Re: [Toaster] Toaster to work with non-git layers

2016-04-29 Thread Michael Wood
Hi Sujith, Thanks for the ping. My thoughts on this... I had a look at those patches and unfortunately I think it's just too much of a work-around to push this into the toaster at the moment. That's not to say that this isn't something that we want to fix. There are at least two larger proble

[Toaster] [PATCH v2 1/6] toaster: Remove DATABASE_URL being passed around as an environment var

2016-05-05 Thread Michael Wood
. This is preparation work to migrate the build tests and be able to trigger builds on differently configured databases. Signed-off-by: Michael Wood --- bitbake/bin/toaster| 2 - bitbake/lib/bb/ui/buildinfohelper.py | 20 +++ .../toastermain/

[Toaster] [PATCH v2 2/6] toaster: runbuilds move the execution sequence out of the poll loop

2016-05-05 Thread Michael Wood
Move the execution sequence for a build out of the polling loop and into it's own fuction. This means that we can call the function on it's own if we just want to trigger one build rather than infinite polling. This is something needed for the build tests. Signed-off-by: Mi

[Toaster] [PATCH v2 3/6] toaster: Add a specific test settings file

2016-05-05 Thread Michael Wood
When running certain tests we want a particular database specified. When bitbake toaster ui is being tested pass it these test settings so that it uses the same database as the unit tests running. Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastermain/settings-test.py | 41

[Toaster] [PATCH v2 4/6] toaster: tests Add a BuildTest helper class

2016-05-05 Thread Michael Wood
Add a helper class for running build tests. Subclass this and call the build method to get setup for running tests on the resulting data from a build. Signed-off-by: Michael Wood --- bitbake/lib/toaster/tests/builds/__init__.py | 0 bitbake/lib/toaster/tests/builds/buildtest.py | 133

[Toaster] [PATCH v2 6/6] toaster: tests builds Add SSTATE_MISS as a valid condition for tc=833

2016-05-05 Thread Michael Wood
Task.SSTATE_NA and Task.SSTATE_MISS are both valid conditions for the condition that a Task.OUTCOME_COVERED and Task.OUTCOME_PREBUILT. Signed-off-by: Michael Wood --- bitbake/lib/toaster/tests/builds/test_core_image_min.py | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions

[Toaster] [PATCH v2 5/6] toaster: tests build Add a test for a build of core-image-minimal

2016-05-05 Thread Michael Wood
This is a port of the oe self test to the django test framework from oe-core meta/lib/oeqa/selftest/_toaster.py Signed-off-by: Michael Wood --- .../toaster/tests/builds/test_core_image_min.py| 389 + 1 file changed, 389 insertions(+) create mode 100644 bitbake/lib

Re: [Toaster] [PATCH v2 1/6] toaster: Remove DATABASE_URL being passed around as an environment var

2016-05-05 Thread Michael Wood
On 05/05/16 14:12, Michael Wood wrote: We don't need to pass the DATABASE_URL around and read it back if we setup the django framework in the correct way. We make the default sqlite database path a full path so that the database isn't being assumed to be in CWD. Also add some m

[Toaster] [PATCH v3 2/6] toaster: runbuilds move the execution sequence out of the poll loop

2016-05-05 Thread Michael Wood
Move the execution sequence for a build out of the polling loop and into it's own fuction. This means that we can call the function on it's own if we just want to trigger one build rather than infinite polling. This is something needed for the build tests. Signed-off-by: Mi

[Toaster] [PATCH v3 1/6] toaster: Remove DATABASE_URL being passed around as an environment var

2016-05-05 Thread Michael Wood
. This is preparation work to migrate the build tests and be able to trigger builds on differently configured databases. Signed-off-by: Michael Wood --- bitbake/bin/toaster| 2 - bitbake/lib/bb/ui/buildinfohelper.py | 20 +++ .../toastermain/

[Toaster] [PATCH v3 3/6] toaster: Add a specific test settings file

2016-05-05 Thread Michael Wood
When running certain tests we want a particular database specified. When bitbake toaster ui is being tested pass it these test settings so that it uses the same database as the unit tests running. Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastermain/settings-test.py | 41

[Toaster] [PATCH v3 4/6] toaster: tests Add a BuildTest helper class

2016-05-05 Thread Michael Wood
Add a helper class for running build tests. Subclass this and call the build method to get setup for running tests on the resulting data from a build. Signed-off-by: Michael Wood --- bitbake/lib/toaster/tests/builds/__init__.py | 0 bitbake/lib/toaster/tests/builds/buildtest.py | 133

[Toaster] [PATCH v3 6/6] toaster: tests builds Add SSTATE_MISS as a valid condition for tc=833

2016-05-05 Thread Michael Wood
Task.SSTATE_NA and Task.SSTATE_MISS are both valid conditions for the condition that a Task.OUTCOME_COVERED and Task.OUTCOME_PREBUILT. Signed-off-by: Michael Wood --- bitbake/lib/toaster/tests/builds/test_core_image_min.py | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions

[Toaster] [PATCH v3 5/6] toaster: tests build Add a test for a build of core-image-minimal

2016-05-05 Thread Michael Wood
This is a port of the oe self test to the django test framework from oe-core meta/lib/oeqa/selftest/_toaster.py Signed-off-by: Michael Wood --- .../toaster/tests/builds/test_core_image_min.py| 389 + 1 file changed, 389 insertions(+) create mode 100644 bitbake/lib

[Toaster] [PATCH 2/3] toaster: toastergui tests Fix toastertable tests

2016-05-06 Thread Michael Wood
After clean ups remove api assumptions. Our table data often contains html snippets to display certain things such as dependency pop overs or simply links to other parts of the UI. Take these into account when testing the values of the table data. Signed-off-by: Michael Wood --- bitbake/lib

[Toaster] [PATCH 3/3] toaster: toastertables port table for Built packages

2016-05-06 Thread Michael Wood
This is the table that displays all the packages built in the build. Build -> Packages Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/buildtables.py | 77 + bitbake/lib/toaster/toastergui/tables.py | 1 + .../lib/toaster/toastergui/templa

[Toaster] [PATCH 1/3] toaster: toastertables: Clean up and fix up a number of items

2016-05-06 Thread Michael Wood
e warnings Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/static/js/table.js | 21 +--- bitbake/lib/toaster/toastergui/tables.py | 11 -- bitbake/lib/toaster/toastergui/widgets.py | 127 -- 3 files changed, 72 insertions(+), 87 deletions(-) di

[Toaster] [PATCH v4 1/6] toaster: Remove DATABASE_URL being passed around as an environment var

2016-05-06 Thread Michael Wood
. This is preparation work to migrate the build tests and be able to trigger builds on differently configured databases. Signed-off-by: Michael Wood --- bitbake/bin/toaster| 2 - bitbake/lib/bb/ui/buildinfohelper.py | 20 +++ .../toastermain/

[Toaster] [PATCH v4 3/6] toaster: Add a specific test settings file

2016-05-06 Thread Michael Wood
When running certain tests we want a particular database specified. When bitbake toaster ui is being tested pass it these test settings so that it uses the same database as the unit tests running. Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastermain/settings-test.py | 41

[Toaster] [PATCH v4 0/6] Build tests

2016-05-06 Thread Michael Wood
Changes since v3: - Make sure config_file is initialised - Add a README file to explain how to run the tests Michael Wood (6): toaster: Remove DATABASE_URL being passed around as an environment var toaster: runbuilds move the execution sequence out of the poll loop toaster: Add a specific

[Toaster] [PATCH v4 2/6] toaster: runbuilds move the execution sequence out of the poll loop

2016-05-06 Thread Michael Wood
Move the execution sequence for a build out of the polling loop and into it's own fuction. This means that we can call the function on it's own if we just want to trigger one build rather than infinite polling. This is something needed for the build tests. Signed-off-by: Mi

[Toaster] [PATCH v4 6/6] toaster: tests builds Add SSTATE_MISS as a valid condition for tc=833

2016-05-06 Thread Michael Wood
Task.SSTATE_NA and Task.SSTATE_MISS are both valid conditions for the condition that a Task.OUTCOME_COVERED and Task.OUTCOME_PREBUILT. Signed-off-by: Michael Wood --- bitbake/lib/toaster/tests/builds/test_core_image_min.py | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions

[Toaster] [PATCH v4 5/6] toaster: tests build Add a test for a build of core-image-minimal

2016-05-06 Thread Michael Wood
This is a port of the oe self test to the django test framework from oe-core meta/lib/oeqa/selftest/_toaster.py Signed-off-by: Michael Wood --- .../toaster/tests/builds/test_core_image_min.py| 389 + 1 file changed, 389 insertions(+) create mode 100644 bitbake/lib

[Toaster] [PATCH v4 4/6] toaster: tests Add a BuildTest helper class

2016-05-06 Thread Michael Wood
Add a helper class for running build tests. Subclass this and call the build method to get setup for running tests on the resulting data from a build. Signed-off-by: Michael Wood --- bitbake/lib/toaster/tests/builds/README | 14 +++ bitbake/lib/toaster/tests/builds/__init__.py | 0

Re: [Toaster] [PATCH v4 0/6] Build tests

2016-05-09 Thread Michael Wood
pushed on to the branch poky-contrib michael/toaster/build-tests to fix the typo in first patch: s/toaster1.sqlite/toaster.sqlite/ Thanks, Michael On 06/05/16 22:26, Michael Wood wrote: Changes since v3: - Make sure config_file is initialised - Add a README file to explain how to run the

[Toaster] [PATCH 1/5] toaster: projectNameValidation API added

2016-05-09 Thread Michael Wood
From: Sujith H The projectNameValidation API would help users to validate if a project name exists or not. This API is added to libtoaster. [YOCTO #7005] Signed-off-by: Sujith H --- .../lib/toaster/toastergui/static/js/libtoaster.js | 62 ++ 1 file changed, 62 insertions(+

[Toaster] [PATCH 3/5] toaster: ui handles duplicate project name in project page

2016-05-09 Thread Michael Wood
From: Sujith H When already existing project name is typed by user, the ui pops up message regarding the existance of the project name. When an existing project is typed the save button will be disabled. Else user can proceed ahead by modifying the project name. [YOCTO #7005] Signed-off-by: Suj

[Toaster] [PATCH 2/5] toaster: ui handles duplicate project name in new project page

2016-05-09 Thread Michael Wood
From: Sujith H When already existing project name is typed by user, the ui pops up message regarding the existance of the project name. [YOCTO #7005] Signed-off-by: Sujith H --- bitbake/lib/toaster/toastergui/templates/newproject.html | 12 ++-- 1 file changed, 10 insertions(+), 2 del

[Toaster] [PATCH 4/5] toaster: models Add missing import sys

2016-05-09 Thread Michael Wood
Signed-off-by: Michael Wood --- bitbake/lib/toaster/orm/models.py | 1 + 1 file changed, 1 insertion(+) diff --git a/bitbake/lib/toaster/orm/models.py b/bitbake/lib/toaster/orm/models.py index 6716ddf..2669606 100644 --- a/bitbake/lib/toaster/orm/models.py +++ b/bitbake/lib/toaster/orm

[Toaster] [PATCH 5/5] toaster: tests browser Add test for creating a project

2016-05-09 Thread Michael Wood
Add browser tests for creating a project and test validation of duplicate project names. Signed-off-by: Michael Wood --- .../toaster/tests/browser/test_new_project_page.py | 109 + 1 file changed, 109 insertions(+) create mode 100644 bitbake/lib/toaster/tests/browser

[Toaster] [PATCH 0/5] Unique project names

2016-05-09 Thread Michael Wood
Patch series to add the unique project name validation. All Sujith patches have been reviewed already, just my two that need a quick look over. Happy to do the upstreaming. Michael Wood (2): toaster: models Add missing import sys toaster: tests browser Add test for creating a project Sujith

Re: [Toaster] [PATCH 5/5] toaster: tests browser Add test for creating a project

2016-05-10 Thread Michael Wood
Upstreamed and pushed to toaster-next with the typo corrected On 09/05/16 17:22, Smith, Elliot wrote: Looks good, but one typo (see below). I'm happy for you to upstream it. Elliot On 9 May 2016 at 16:27, Michael Wood <mailto:michael.g.w...@intel.com>> wrote: Add bro

Re: [Toaster] [PATCH 0/3] [v3] Cancel builds when cli is interrupted

2016-05-12 Thread Michael Wood
Sent upstream and push to toaster-next Thanks, Michael On 06/05/16 15:24, Barros Pena, Belen wrote: On 06/05/2016 12:53, "toaster-boun...@yoctoproject.org on behalf of Elliot Smith" wrote: If a bitbake build is running on the command line and is interrupted (e.g. by Ctrl-c), capture the in

[Toaster] [PATCH v2 1/3] toaster: toastertables: Clean up and fix up a number of items

2016-05-13 Thread Michael Wood
e warnings Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/static/js/table.js | 21 +--- bitbake/lib/toaster/toastergui/tables.py | 11 -- bitbake/lib/toaster/toastergui/widgets.py | 127 -- 3 files changed, 72 insertions(+), 87 deletions(-) di

[Toaster] [PATCH v2 2/3] toaster: toastergui tests Fix toastertable tests

2016-05-13 Thread Michael Wood
After clean ups remove api assumptions. Our table data often contains html snippets to display certain things such as dependency pop overs or simply links to other parts of the UI. Take these into account when testing the values of the table data. Signed-off-by: Michael Wood --- bitbake/lib

[Toaster] [PATCH v2 3/3] toaster: toastertables port table for Built packages

2016-05-13 Thread Michael Wood
This is the table that displays all the packages built in the build. Build -> Packages. Adds a template snippet for the git revision popover. Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/buildtables.py | 112 + bitbake/lib/toaster/toastergui/tables

Re: [Toaster] [PATCH] toaster: fix progress bar in MySQL environment

2016-05-13 Thread Michael Wood
On 13/05/16 11:43, Smith, Elliot wrote: On 13 May 2016 at 11:40, Elliot Smith > wrote: When using MySQL, the project builds info delivered by MySQL differs from that delivered by SQLite: the former returns text values from the enumeration for Build outc

[Toaster] [PATCH 1/2] toaster: toastertables: Clean up and fix up a number of items

2016-05-16 Thread Michael Wood
e warnings Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/static/js/table.js | 21 +--- bitbake/lib/toaster/toastergui/tables.py | 11 -- bitbake/lib/toaster/toastergui/widgets.py | 127 -- 3 files changed, 72 insertions(+), 87 deletions(-) di

[Toaster] [PATCH 0/2] Toastertable clean ups

2016-05-16 Thread Michael Wood
Toaster table clean ups, this supersedes the previous patch series "[PATCH v2 1/3] toaster: toastertables: Clean up and fix up a number of items" I will split out the build tables porting into a different series. Michael Wood (2): toaster: toastertables: Clean up and fix up a numbe

[Toaster] [PATCH 2/2] toaster: toastergui tests Fix toastertable tests

2016-05-16 Thread Michael Wood
After clean ups remove api assumptions. Our table data often contains html snippets to display certain things such as dependency pop overs or simply links to other parts of the UI. Take these into account when testing the values of the table data. Signed-off-by: Michael Wood --- bitbake/lib

Re: [Toaster] [PATCH v4 0/6] Build tests

2016-05-16 Thread Michael Wood
Re-based on toaster-next and pushed onto poky-contrib michael/toaster/build-tests Thanks, Michael On 09/05/16 14:52, Michael Wood wrote: pushed on to the branch poky-contrib michael/toaster/build-tests to fix the typo in first patch: s/toaster1.sqlite/toaster.sqlite/ Thanks, Michael On

[Toaster] [PATCH 2/7] toaster: port table for Built packages to ToasterTable

2016-05-23 Thread Michael Wood
This is the table that displays all the packages built in the build. Build -> Packages. Adds a template snippet for the git revision popover. Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/buildtables.py | 152 + bitbake/lib/toaster/toastergui/tables

[Toaster] [PATCH 0/7] Port main build tables to ToasterTables

2016-05-23 Thread Michael Wood
Port the main build tables in the build analysis area to ToasterTables. This is the table for Installed packages, Tasks, Recipes, Packages, Time, CPU usage and Disk I/O Michael Wood (7): toaster: ToasterTable widget add an 'a' to Name in Exception class toaster: port table

[Toaster] [PATCH 1/7] toaster: ToasterTable widget add an 'a' to Name in Exception class

2016-05-23 Thread Michael Wood
Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/widgets.py | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/bitbake/lib/toaster/toastergui/widgets.py b/bitbake/lib/toaster/toastergui/widgets.py index 4117031..17c97fd 100644 --- a/bitbake/lib/toaster

[Toaster] [PATCH 3/7] toaster: port Built recipes table to toastertables

2016-05-23 Thread Michael Wood
Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/buildtables.py | 129 + .../lib/toaster/toastergui/templates/recipes.html | 113 -- bitbake/lib/toaster/toastergui/urls.py | 7 +- bitbake/lib/toaster/toastergui/views.py

[Toaster] [PATCH 6/7] toaster: table.js Add the ability to highlight a particular row

2016-05-23 Thread Michael Wood
As in the old build tables it's useful to jump and highlight a particular row in the table using the #hash in the URL. Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/static/js/table.js | 9 + 1 file changed, 9 insertions(+) diff --git a/bitbake/lib/toaster/toast

[Toaster] [PATCH 7/7] toaster: tests Add new build tables to tests

2016-05-23 Thread Michael Wood
- Add new build tables to be tested - Add required data into the fixture and clean up a few empty fields - Fix the SoftwareRecipesTable specific test so as not to rely on two particular defined recipes Signed-off-by: Michael Wood --- .../fixtures/toastergui-unittest-data.xml | 91

[Toaster] [PATCH 5/7] toaster: port Installed packages table to ToasterTable

2016-05-23 Thread Michael Wood
Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/buildtables.py | 63 +++- .../toastergui/templates/builddashboard.html | 4 +- .../lib/toaster/toastergui/templates/target.html | 115 +- bitbake/lib/toaster/toastergui/urls.py | 9

[Toaster] [PATCH 4/7] toaster: port Task tables to ToasterTables widget

2016-05-23 Thread Michael Wood
Port the Task based tables to ToasterTable. This is the Task, Time, CPU usage and Disk I/O tables. Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/buildtables.py | 227 - .../templates/buildinfo-toastertable.html | 4 +- .../toaster/toastergui

Re: [Toaster] [PATCH] toaster: show https proxy in error output

2016-05-24 Thread Michael Wood
On 19/04/16 13:19, Elliot Smith wrote: urllib2 automatically uses any http_proxy and https_proxy settings from the environment. Now that the layer index is available over https, there is a possibility that a user may experience an error while fetching layer index. In this situation, show the http

Re: [Toaster] [PATCH 059/106] toaster: Update OE json file

2016-05-24 Thread Michael Wood
Should be able to drop this one as it appears upstream already Michael On 24/05/16 12:39, Belen Barros Pena wrote: Update the OpenEmbedded Toaster configuration file to include the krogoth branch. Also, make sure the DISTRO default value is set to "nodistro". Signed-off-by: Belen Barros Pena

Re: [Toaster] [PATCH 106/106] toaster: Unique project names to Boostrap 3

2016-05-24 Thread Michael Wood
Phew! great work, thank you!! So on my TODO list the next steps are - Fix the indentation of patches #77, #80 , #81, 82, #91. #92, #93, #94, #96, #98, #102 - Drop #59 - Fixup/squash patches which rewrite the same parts. - Fix the authorship of the typeahead patch - somehow it's been attribute

[Toaster] [PATCH v2 0/9] Port build tables to ToasterTables

2016-05-26 Thread Michael Wood
ust having both as columns if applicable - Reworked the display of dependencies popover Michael Wood (9): toaster: ToasterTable widget add an 'a' to Name in Exception class toaster: port table for Built packages to ToasterTable toaster: port Built recipes table to toastertables

[Toaster] [PATCH v2 2/9] toaster: port table for Built packages to ToasterTable

2016-05-26 Thread Michael Wood
This is the table that displays all the packages built in the build. Build -> Packages. Adds a template snippet for the git revision popover. Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/buildtables.py | 152 + bitbake/lib/toaster/toastergui/tables

[Toaster] [PATCH v2 1/9] toaster: ToasterTable widget add an 'a' to Name in Exception class

2016-05-26 Thread Michael Wood
Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/widgets.py | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/bitbake/lib/toaster/toastergui/widgets.py b/bitbake/lib/toaster/toastergui/widgets.py index 4117031..17c97fd 100644 --- a/bitbake/lib/toaster

[Toaster] [PATCH v2 3/9] toaster: port Built recipes table to toastertables

2016-05-26 Thread Michael Wood
Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/buildtables.py | 129 + .../lib/toaster/toastergui/templates/recipes.html | 113 -- bitbake/lib/toaster/toastergui/urls.py | 7 +- bitbake/lib/toaster/toastergui/views.py

[Toaster] [PATCH v2 5/9] toaster: port Installed packages table to ToasterTable

2016-05-26 Thread Michael Wood
Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/buildtables.py | 63 +++- .../toastergui/templates/builddashboard.html | 4 +- .../lib/toaster/toastergui/templates/target.html | 115 +- bitbake/lib/toaster/toastergui/urls.py | 9

[Toaster] [PATCH v2 6/9] toaster: table.js Add the ability to highlight a particular row

2016-05-26 Thread Michael Wood
As in the old build tables it's useful to jump and highlight a particular row in the table using the #hash in the URL. Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/static/js/table.js | 9 + 1 file changed, 9 insertions(+) diff --git a/bitbake/lib/toaster/toast

[Toaster] [PATCH v2 7/9] toaster: tests Add new build tables to tests

2016-05-26 Thread Michael Wood
- Add new build tables to be tested - Add required data into the fixture and clean up a few empty fields - Fix the SoftwareRecipesTable specific test so as not to rely on two particular defined recipes Signed-off-by: Michael Wood --- .../fixtures/toastergui-unittest-data.xml | 91

[Toaster] [PATCH v2 8/9] toaster: widgets ToasterTable Catch template rendering exceptions

2016-05-26 Thread Michael Wood
If a cell template rendering causes an exception catch it and carry on, this at least allows the table to show the rest of the data if nothing else. Also improve the error logging so that it's possible what the offending template snippet was. Signed-off-by: Michael Wood --- bitbake/lib/to

[Toaster] [PATCH v2 4/9] toaster: port Task tables to ToasterTables widget

2016-05-26 Thread Michael Wood
Port the Task based tables to ToasterTable. This is the Task, Time, CPU usage and Disk I/O tables. Signed-off-by: Michael Wood --- bitbake/lib/toaster/toastergui/buildtables.py | 227 - .../templates/buildinfo-toastertable.html | 4 +- .../toaster/toastergui

[Toaster] [PATCH v2 9/9] toaster: Rework displaying package dependencies across Toaster

2016-05-26 Thread Michael Wood
that package to get the dependency information. [YOCTO #9676] Signed-off-by: Michael Wood --- bitbake/lib/toaster/orm/models.py | 61 ++ bitbake/lib/toaster/toastergui/buildtables.py | 15 +- bitbake/lib/toaster/toastergui/tables.py

[Toaster] toaster-next bootstrap3

2016-05-26 Thread Michael Wood
Hi All, For people who are working off toaster-next branch please note I have pushed Belen's work to migrate the project configuration pages to Bootstrap 3. (You may want to make sure you clear your browser's cache to make sure any old html/css/js/cached objects are cleared.) This means that

Re: [Toaster] [PATCH 8/9] toaster-tests: fix tests for latest Selenium version

2016-06-07 Thread Michael Wood
On 06/06/16 17:01, Ed Bartosh wrote: From: Elliot Smith Previously, we didn't specify a specific version of Selenium. When upgrading to Python 3 and installing Selenium to work with it, the JS unit test broke, as the report format produced by Selenium had changed. Modify the test so that it wo

Re: [Toaster] [PATCH 0/9] python 3 fixes

2016-06-07 Thread Michael Wood
I've looked at Elliot's patches, apart from that one little thing it looks good to me. Thanks, Michael On 07/06/16 10:42, Smith, Elliot wrote: Thanks Ed. I've been through and reviewed your patches from this series, and they look good to me. Michael has said he will review my patches in thi

Re: [Toaster] virtualenv for toaster and python 3

2016-06-08 Thread Michael Wood
On 01/06/16 21:12, Ed Bartosh wrote: On Wed, Jun 01, 2016 at 10:24:52AM -0700, Christopher Larson wrote: On Wed, Jun 1, 2016 at 2:27 AM, Ed Bartosh wrote: On Tue, May 31, 2016 at 11:48:01AM -0700, Christopher Larson wrote: On Tue, May 31, 2016 at 11:47 AM, Brian Avery wrote: One possible

Re: [Toaster] [PATCH] toaster-tests: maximize browser window when running UI tests

2016-06-09 Thread Michael Wood
Thanks - Added to toaster-next Michael On 28/04/16 14:57, Barros Pena, Belen wrote: On 28/04/2016 14:31, "Smith, Elliot" wrote: On 28 April 2016 at 14:23, Barros Pena, Belen wrote: On 26/04/2016 17:12, "toaster-boun...@yoctoproject.org on behalf of Elliot Smith" wrote: In some pages of

Re: [Toaster] [PATCH 0/2] Capture command-line builds which fail due to bad targets

2016-06-09 Thread Michael Wood
Thanks - pushed to toaster-next On 28/04/16 14:15, Barros Pena, Belen wrote: On 25/04/2016 16:26, "toaster-boun...@yoctoproject.org on behalf of Elliot Smith" wrote: Toaster currently can't catch build failures which are due to bad targets (e.g. "bitbake ecky-thump"), as the bitbake run does

Re: [Toaster] [PATCH][v2] toaster: fix typo which prevents filters from working

2016-06-09 Thread Michael Wood
Thanks pushed to toaster-next On 07/06/16 16:29, Elliot Smith wrote: 'k' was replaced by 'key' at some point but not fixed in the body of the loop. This caused a failure when the the query was constructed for a filtered queryset, due to the variable not being defined. Signed-off-by: Elliot Smit

Re: [Toaster] [PATCH][v2 2/8] toaster: fix migrations

2016-06-09 Thread Michael Wood
Is this patch needed? I see this is in master already: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/bitbake?id=15bb3d4e7fd33a921e9b0681297dfee6986a66eb On 07/06/16 16:37, Elliot Smith wrote: From: Ed Bartosh Signed-off-by: Ed Bartosh --- .../migrations/0004_auto_20160523_1446.py

  1   2   3   4   5   6   7   8   >