me know... I might
be able to remember some of it.
-casey
peter lin wrote:
thanks larry for that information. I will take a look before I jump in.
Larry Isaacs wrote:
This was done by Casey Lucas. However, be aware that it comes
with a disadvantage in that because of the extra code
I heard that. Get rid of it.
-casey
Andy Armstrong wrote:
+1 (cleaning is good -- I love deleting stuff)
Mike Anderson wrote:
+1
Mike Anderson
[EMAIL PROTECTED] 06/19/01 03:49PM
Hi,
Does anyone have any objection to my deleting the following folders
from the
Craig R. McClanahan wrote:
On Sat, 16 Jun 2001, Casey Lucas wrote:
[EMAIL PROTECTED] wrote:
On Fri, 15 Jun 2001, Casey Lucas wrote:
Costin,
sounds good.
btw, when do you think the generator code in 34 will settle down
a little?
Soon
Costin,
sounds good.
btw, when do you think the generator code in 34 will settle down
a little?
-casey
[EMAIL PROTECTED] wrote:
Ok, time to discuss the first mini-optimization.
Right now jasper has 2 ways to output data - one is the common
out.println(String );
The other ( not very
[EMAIL PROTECTED] wrote:
On Fri, 15 Jun 2001, Casey Lucas wrote:
Costin,
sounds good.
btw, when do you think the generator code in 34 will settle down
a little?
Soon :-)
There is only one more change in the generator layout - switching to
a visitor pattern
+1
-casey
Hey Mel,
I'll use this as a chance to explain some thoughts
I've recently had on tag pooling. Maybe you and
others have comments.
Mel Martinez wrote:
Hi folks!
I'm still overwhelmed with other priorities (new job,
house-hunting, moving, etc.) to be able to help again,
but I managed
Rickard,
Thanks for sending the test application. I've been using monthlist.jsp while
testing rendered then hand bashed code. After some preliminary bashing :)
I think it will be possible to call all setters (except runtime expressions)
only once per run of the page. Also, we can create /
Glenn Nielsen wrote:
[snip]
I just had an idea (dangerous things) regarding tag pooling optimizations.
When Jasper translates a page it should be able to generate information
about which tag handler classes it needs, and for each tag handler, the
profile of the attribute/value pairs.
tried in proposals/jasper34 is just wrong and against the basic
ideas of evolution - and I realize that.
Just give me 2 days, I need to finish with xalan ( we just had the 2.1.0
release and I need to finish my work on it )
Costin
On Wed, 23 May 2001, Casey Lucas wrote:
Costin Craig
Rickard,
Can you please send in some complete examples? Also, did you run the
tests with and without tag pooling enabled on the same version of
tomcat? (By adding removing TagPoolManagerInterceptor.)
My experience has been that if the jsp uses many tags, then pooling is
a big performance
I finally had some time last night to see why all of the watchdog tests
wouldn't run correctly if tag pooling was turned on.
Based on my understanding of the spec I think that that some of the code
included in watchdog may be incorrect. The spec says that a tag handler
can be used multiple
Craig,
As you requested... I've attached diffs for the java file and for the jsp.
Let me know if you have any questions / comments.
-casey
Craig R. McClanahan wrote:
On Thu, 17 May 2001, Casey Lucas wrote:
I finally had some time last night to see why all of the watchdog tests
Rickard,
As Glenn mentioned, Jasper is in the process of getting a rework. But in the
mean time and since you mentioned taglibs, you may want to look at the tag
pooling module that was added to tc 3.3. If your jsps use a lot of tags,
you should see a big performance gain. Let me know if you
). Getting the code
generator to work is first, but I hope in few weeks to finally merge the 2
runtimes and make the changes, and I hope you can review ( or help
:-) some of it.
Costin
On Sun, 29 Apr 2001, Casey Lucas wrote:
Costin,
Web based build will be a nice addition -- cool
As I started to add some code to remove pooled tag handlers from
the tag pool if an exception is thrown during tag usage, I came
across an issue...
In Tomcat 3, at the end of a JSP page, Jasper renders code to
catch java.lang.Exception. In Tomcat 4, Jasper renders code to
catch Throwable. This
Mel,
Thanks for the comments. See below.
Mel Martinez wrote:
--- Casey Lucas [EMAIL PROTECTED] wrote:
As I started to add some code to remove pooled tag
handlers from
the tag pool if an exception is thrown during tag
usage, I came
across an issue...
To clean up tag handlers
I noticed that for PageContextImpl you made a comment about removing
the log dependency. Was this just because it was used on a case that
"shouldn't happen" or is there another reason why jasper components
shouldn't rely on tomcat logging code?
Just wondering / checking, because some jasper
Just curious... why did you take out the buffer size double? Is that too
much memory to sacrifice? Someone ? recently sent this in as a performance
improvement patch.
You know I love anything that makes tags faster. :)
-Casey
[EMAIL PROTECTED] wrote:
costin 01/03/21 11:51:06
Casey Lucas wrote:
Just curious... why did you take out the buffer size double? Is that too
much memory to sacrifice? Someone ? recently sent this in as a performance
improvement patch.
Of course the line
tmp = new char [bufferSize + Constants.DEFAULT_BUFFER_SIZE];
also needs
I'm -1 on the 15 sec. You never know what type of network a client
may be traversing.
-Casey
GOMEZ Henri wrote:
Hi,
I notice you corrected the patch which is a good thing
but settings timeout to 5mn (300s) is a little too high
for an http 1.0 connection. The timeout could be as low as
Hola.
I'm sure I wont have enough time to take over Jasper for 3, but I may find some
time to help out. I'll try to take a look after I wrap up some other stuff.
-Casey
"Ignacio J. Ortega" wrote:
Hola a todos:
There are so many Tomcat 3/Jasper bugs and the component itself assigned
to
...
myHandlers.push(returnValue);
} else {
returnValue = (Tag) myHandlers.pop();
}
--
janco
Casey Lucas wrote:
The attached files and diffs are based on 3.3 (hopefully latest code).
They add tag pooling for tomcat. I hope
un, 18 Mar 2001, Casey Lucas wrote:
snip
Questions:
-
1. Each web application wide TagPoolManager is stored in application scope
as an attribute. Of course this means that an application could change it.
Is this acceptable?
We're doing that kind of thing in
e tag pooling. To disable tag pooling, just
* dont include this interceptor.
*
* @author Casey Lucas [EMAIL PROTECTED]
* @see TagPoolManager
*/
public class TagPoolManagerInterceptor extends BaseInterceptor {
/**
* This hook is called when an application context is initialized.
*
Great!
You will do before/after performance comparisons?
In the process...
Ok, here are some basic numbers.
For simple performance testing I wrote a jsp that
uses an outer tag (BodyTag iteration style) and an
inner tag. I placed timings around the outer tag.
Based on 3.3 (nightly
The attached files and diffs are based on 3.3 (hopefully latest code).
They add tag pooling for tomcat. I hope that some of you will have
time to take a look and provide feedback. I mainly tested with our
application that uses a lot of tags.
To disable pooling, don't include the
but hopefully it will port easily to
others. I was hoping for comments before verifying other
builds.
BTW, I love your sig. I'm a terrible speller too.
-casey
Regards,
Glenn
Casey Lucas wrote:
The attached files and diffs are based on 3.3 (hopefully latest code).
They add tag
I pulled src for 3.3 m2 (with jasper.runtime in common dir) and it
all started working cool!
Additionally, I have a much better understanding of tomcat's use
of ClassLoaders.
Thanks for the help.
-Casey
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
I'm doing some prototyping for tag pooling in tomcat (based on
the 3.3 tree.) I'd like to implement tag handler pooling
per web application. Can someone point me to where I can
hook into in order to setup the internal pool stuff when
each web application starts, stop, reloads, etc.?
I need to
On Fri, 9 Mar 2001, Casey Lucas wrote:
So, given all that, I need to control lifetime of TagHandlerPoolManager's
default instance. By controlling it, I can have one TagHandlerPoolManager
instance per web application and when the web application gets unloaded,
all the Tag.release methods
I am planning on implementing tag handler pooling and would like
to throw out a few ideas for feedback:
assumptions:
- Tag handlers can only be reused if the same set of attributes
are used for the tag.
- Tag.relese is called only once -- at some point before the
handler is garbage collected.
Thanks for the comments.
Just a quick note - my experience so far with server-side performance is
that it doesn't matter how many objects you create, as long as you do it
only once ( and not for each request ).
Right. I was planning on using a web-application-wide collection of pools.
Sorry for the long message, but I'm a bit unclear on some Tag related
spec details. I need to make sure I have a clear understanding before
I start thinking about tag handler reuse implementation.
My original understanding of Tag.release was that it was always called after
a tag handler was
Looking at the rendered jsp - java files in the work directory
(and noticing the calls to Tag.release), I realized that Jasper
is not reusing tags that it creates. So, my question is:
Has there been any conversations about implementing tag
reuse in Jasper?
-Casey
To: [EMAIL PROTECTED]
Subject: Re: re-use of tag objects via Tag.release method
Casey Lucas wrote:
Looking at the rendered jsp - java files in the work directory
(and noticing the calls to Tag.release), I realized that Jasper
is not reusing tags that it creates. So, my question is:
Has
Last week I sent a message about some optimizations that might
be added to tomcat, but didn't see any response. Can someone
tell me what the normal procedure for suggesting code changes is?
patch format? work with a developer that is a commiter?
I'm not trying to nag, I just want to make sure
Hopefully this is the right place for the following information. If
not, I'm sorry.
I don't really do active development on tomcat (cvs updates, etc) but
while profiling our application, I noticed a couple of minor improvements
that could be made to BodyContentImpl.java. Specifically, in
38 matches
Mail list logo
