Mailing List - I WANT OUT!!!!!!
Dear Sirs, I wish to be excluded IMMEDIATELY from your mailing list. I do not know HOW I ended up there, but I am certainly NOT interested in the topics and I don't want to get anymore of your mails. So, please, remove my mail address from your list. Thank you in advance! Kirsi Grn Project Manager, L.Sc. Olympus Diagnostica Olympus Finland Oy Airport Plaza Business Park Presto yritie 12 B 01510 VANTAA Phone: +358 9 875 81154 Mobile: +358 50 5523 557 Fax:+358 9 875 81100 mailto: [EMAIL PROTECTED] URL: http://www.olympus.fi - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.13 TAGGED
Günter Knauf wrote: Hi Mladen, JK 1.2.13 has been taggeded as we agreed last week, and the tarballs are available at: http://www.apache.org/dist/jakarta/tomcat-connectors/jk/source/jk-1.2.13/ any particular reason why you didnt tag my last commit on jk_connect.c? http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-connectors/jk/native/common/jk_connect.c?rev=1.59view=log now we can again not build for AP13 on NetWare without patching. I thought you said last time that you are fine with the patch? Yes I am. Have no idea why this file wasn't tagged. Can we retag that file only and rerelease? Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34693] - Tomcat infinite wait on noised network
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34693. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34693 --- Additional Comments From [EMAIL PROTECTED] 2005-05-18 09:13 --- Ok, I give up trying to close this report, but I won't look into it either. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.13 TAGGED
Henri Gomez wrote: Yes ;-) Yes what? Broke a rule or recreate the tarballs, or both :)? And put a note about this change also in the download location In a form of? Any example? Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c
Mladen Turk wrote: Jean-Jacques Clar wrote: re-sending : Am I missing details? Calling ap_rflush() at the end of ws_write() in mod_jk.c is causing me problems when doing downloads from the server to a client. Performance degradation and, less importantly, memory usage, are the problems. Seems we are the only module out there that calls the apr_rflush in Apache2. Althought I said 'no more features' I propose that we make a config option that will be in the form of: JkFlush (On|Off|size) with On as default for each packet write. That way we'd be able to flush after each write, flush after each 'size' bytes or not flush at all. How that sounds? Won't it be better to have a ws_flush()? Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34693] - Tomcat infinite wait on noised network
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34693. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34693 [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-05-18 09:37 --- Marked as invalid as requested from Remy via private email ... but this does not mean that the problem is solved! -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.13 TAGGED
Mladen Turk wrote: Günter Knauf wrote: Hi Mladen, JK 1.2.13 has been taggeded as we agreed last week, and the tarballs are available at: http://www.apache.org/dist/jakarta/tomcat-connectors/jk/source/jk-1.2.13/ any particular reason why you didnt tag my last commit on jk_connect.c? http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-connectors/jk/native/common/jk_connect.c?rev=1.59view=log now we can again not build for AP13 on NetWare without patching. I thought you said last time that you are fine with the patch? Seems I made a mistake while tagging, although have no idea why that happened :(. I've retagged the jk_connect.c JK_1_2_13 to rev 1.59, so that Netware patches are now included. Hope I didn't break any ASF rule by that. Should I recreate the tarballs? I am not 100% ok with this because the tarballs without the patch are already in mirrors... If the error is only in NetWare put the patch in README.html of /www/www.apache.org/dist/jakarta/tomcat-connectors/jk/binaries/netware. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.13 TAGGED
Or provide a jk 1.2.13a including this fix for novell ? 2005/5/18, jean-frederic clere [EMAIL PROTECTED]: Mladen Turk wrote: Günter Knauf wrote: Hi Mladen, JK 1.2.13 has been taggeded as we agreed last week, and the tarballs are available at: http://www.apache.org/dist/jakarta/tomcat-connectors/jk/source/jk-1.2.13/ any particular reason why you didnt tag my last commit on jk_connect.c? http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-connectors/jk/native/common/jk_connect.c?rev=1.59view=log now we can again not build for AP13 on NetWare without patching. I thought you said last time that you are fine with the patch? Seems I made a mistake while tagging, although have no idea why that happened :(. I've retagged the jk_connect.c JK_1_2_13 to rev 1.59, so that Netware patches are now included. Hope I didn't break any ASF rule by that. Should I recreate the tarballs? I am not 100% ok with this because the tarballs without the patch are already in mirrors... If the error is only in NetWare put the patch in README.html of /www/www.apache.org/dist/jakarta/tomcat-connectors/jk/binaries/netware. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c
jean-frederic clere wrote: Mladen Turk wrote: JkFlush (On|Off|size) with On as default for each packet write. That way we'd be able to flush after each write, flush after each 'size' bytes or not flush at all. Won't it be better to have a ws_flush()? Not sure what you mean by that. Like a generic callback? Not sure if it would make sense. IIS for example does auto flushing, so It's only needed for Apache2. Having 'JkFlush size' like 'JkFlush 65536' will insert an EOS bucket after 64K. Having large chunks might make problems to outgoing filters like deflate, that depends on EOS bucket for compressing window size. Right now the chunk size is AJP packet size (8K) that might cause memory problems like JJC said. Adding that as configurable server wide option will not break exiting behavior, while it might speed up large data transfer, and keep the memory low. If 'JkFlush Off' is used a single ap_rflush will be issued when all the data is send. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c
Mladen Turk wrote: jean-frederic clere wrote: Mladen Turk wrote: JkFlush (On|Off|size) with On as default for each packet write. That way we'd be able to flush after each write, flush after each 'size' bytes or not flush at all. Won't it be better to have a ws_flush()? Not sure what you mean by that. Like a generic callback? Yes to able to flush the same way we write. Not sure if it would make sense. IIS for example does auto flushing, so It's only needed for Apache2. Having 'JkFlush size' like 'JkFlush 65536' will insert an EOS bucket after 64K. Having large chunks might make problems to outgoing filters like deflate, that depends on EOS bucket for compressing window size. Right now the chunk size is AJP packet size (8K) that might cause memory problems like JJC said. yep. (write(8K) + flush())*n is not ok. (write(8K)*n + flush() is the right thing. Adding that as configurable server wide option will not break exiting behavior, while it might speed up large data transfer, and keep the memory low. If 'JkFlush Off' is used a single ap_rflush will be issued when all the data is send. Then why not using 'JkFlush Off' as default behaviour? Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.13 TAGGED
Henri Gomez wrote: Or provide a jk 1.2.13a including this fix for novell ? I would like to skip that, but I like the Jean-Frederic's idea about putting the tarballs inside binaries/netware/ Anyhow, the plan was retag that as 1.2.14 if everything else is OK, or make 1.2.14-rc-(xxx), after some test period, like couple of weeks. If you guys are OK with JJC concerns and my proposal on ap_rflush/JkFlush we can add that to 1.2.14-rc-1, or leave that for 1.3 branch. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net AprEndpoint.java
remm2005/05/18 02:02:32
Modified:util/java/org/apache/tomcat/util/net AprEndpoint.java
Log:
- Remove a useless synchronized, and add some javadoc.
Revision ChangesPath
1.28 +31 -4
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/AprEndpoint.java
Index: AprEndpoint.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/AprEndpoint.java,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -r1.27 -r1.28
--- AprEndpoint.java 17 May 2005 12:20:20 - 1.27
+++ AprEndpoint.java 18 May 2005 09:02:32 - 1.28
@@ -43,7 +43,10 @@
* liSendfile thread/li
* liWorker threads pool/li
* /ul
- *
+ *
+ * When switching to Java 5, there's an opportunity to use the virtual
+ * machine's thread pool.
+ *
* @author Mladen Turk
* @author Remy Maucherat
*/
@@ -372,7 +375,8 @@
/**
* Initialize the endpoint.
*/
-public void init() throws Exception {
+public void init()
+throws Exception {
if (initialized)
return;
@@ -409,7 +413,11 @@
}
-public void start() throws Exception {
+/**
+ * Start the APR endpoint, creating acceptor, poller and sendfile
threads.
+ */
+public void start()
+throws Exception {
// Initialize socket if not done before
if (!initialized) {
init();
@@ -443,6 +451,9 @@
}
+/**
+ * Pause the endpoint, which will make it stop accepting new sockets.
+ */
public void pause() {
if (running !paused) {
paused = true;
@@ -450,12 +461,21 @@
}
}
+
+/**
+ * Resume the endpoint, which will make it start accepting new sockets
+ * again.
+ */
public void resume() {
if (running) {
paused = false;
}
}
+
+/**
+ * Stop the endpoint. This will cause all processing threads to stop.
+ */
public void stop() {
if (running) {
running = false;
@@ -468,6 +488,10 @@
}
}
+
+/**
+ * Deallocate APR memory pools, and close server socket.
+ */
public void destroy() throws Exception {
if (running) {
stop();
@@ -540,6 +564,9 @@
}
+/**
+ * Process the specified connection.
+ */
protected boolean processSocket(long socket, long pool) {
// Process the connection
int step = 1;
@@ -731,7 +758,7 @@
* Create the poller. With some versions of APR, the maximum poller
size will
* be 62 (reocmpiling APR is necessary to remove this limitation).
*/
-protected synchronized void init() {
+protected void init() {
pool = Pool.create(serverSockPool);
try {
serverPollset = Poll.create(pollerSize, pool, 0, soTimeout *
1000);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project jakarta-tomcat-jk-native (in module jakarta-tomcat-connectors) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project jakarta-tomcat-jk-native has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 159 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - jakarta-tomcat-jk-native : Connectors to various web servers Full details are available at: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed The following work was performed: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/gump_work/build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native.html Work Name: build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native (Type: Build) Work ended in a state of : Failed Elapsed: Command Line: make [Working Directory: /usr/local/gump/public/workspace/jakarta-tomcat-connectors/jk/native] - Making all in common make[1]: Entering directory `/home/gump/workspaces2/public/workspace/jakarta-tomcat-connectors/jk/native/common' /bin/sh /usr/local/gump/public/workspace/apache-httpd/dest-18052005/build/libtool --silent --mode=compile gcc -I/usr/local/gump/public/workspace/apache-httpd/dest-18052005/include -g -O2 -g -O2 -pthread -DHAVE_APR -I/usr/local/gump/public/workspace/apr/dest-18052005/include/apr-1 -g -O2 -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I/home/gump/workspaces2/public/workspace/apache-httpd/srclib/pcre -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_ajp12_worker.c /usr/local/gump/public/workspace/apache-httpd/dest-18052005/build/libtool: /usr/local/gump/public/workspace/apache-httpd/dest-18052005/build/libtool: No such file or directory make[1]: *** [jk_ajp12_worker.lo] Error 127 make[1]: Leaving directory `/home/gump/workspaces2/public/workspace/jakarta-tomcat-connectors/jk/native/common' make: *** [all-recursive] Error 1 - To subscribe to this information via syndicated feeds: - RSS: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/rss.xml - Atom: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/atom.xml == Gump Tracking Only === Produced by Gump version 2.2. Gump Run 2418052005, brutus:brutus-public:2418052005 Gump E-mail Identifier (unique within run) #20. -- Apache Gump http://gump.apache.org/ [Instance: brutus] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project jakarta-tomcat-jk-native (in module jakarta-tomcat-connectors) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project jakarta-tomcat-jk-native has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 159 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - jakarta-tomcat-jk-native : Connectors to various web servers Full details are available at: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed The following work was performed: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/gump_work/build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native.html Work Name: build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native (Type: Build) Work ended in a state of : Failed Elapsed: Command Line: make [Working Directory: /usr/local/gump/public/workspace/jakarta-tomcat-connectors/jk/native] - Making all in common make[1]: Entering directory `/home/gump/workspaces2/public/workspace/jakarta-tomcat-connectors/jk/native/common' /bin/sh /usr/local/gump/public/workspace/apache-httpd/dest-18052005/build/libtool --silent --mode=compile gcc -I/usr/local/gump/public/workspace/apache-httpd/dest-18052005/include -g -O2 -g -O2 -pthread -DHAVE_APR -I/usr/local/gump/public/workspace/apr/dest-18052005/include/apr-1 -g -O2 -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I/home/gump/workspaces2/public/workspace/apache-httpd/srclib/pcre -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_ajp12_worker.c /usr/local/gump/public/workspace/apache-httpd/dest-18052005/build/libtool: /usr/local/gump/public/workspace/apache-httpd/dest-18052005/build/libtool: No such file or directory make[1]: *** [jk_ajp12_worker.lo] Error 127 make[1]: Leaving directory `/home/gump/workspaces2/public/workspace/jakarta-tomcat-connectors/jk/native/common' make: *** [all-recursive] Error 1 - To subscribe to this information via syndicated feeds: - RSS: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/rss.xml - Atom: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/atom.xml == Gump Tracking Only === Produced by Gump version 2.2. Gump Run 2418052005, brutus:brutus-public:2418052005 Gump E-mail Identifier (unique within run) #20. -- Apache Gump http://gump.apache.org/ [Instance: brutus] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 InternalAprOutputBuffer.java
remm2005/05/18 02:25:08
Modified:http11/src/java/org/apache/coyote/http11
InternalAprOutputBuffer.java
Log:
- Fix write algorithm (at least a return was missing), which could likely be
improved further. Thanks to Jean-Francois for spotting the problem.
Revision ChangesPath
1.4 +12 -7
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/InternalAprOutputBuffer.java
Index: InternalAprOutputBuffer.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/InternalAprOutputBuffer.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- InternalAprOutputBuffer.java 14 May 2005 20:41:26 - 1.3
+++ InternalAprOutputBuffer.java 18 May 2005 09:25:08 - 1.4
@@ -743,15 +743,20 @@
public int doWrite(ByteChunk chunk, Response res)
throws IOException {
-if (bbuf.position() + chunk.getLength() bbuf.capacity()) {
-flushBuffer();
-if (chunk.getLength() bbuf.capacity()) {
-if (Socket.send(socket, chunk.getBuffer(),
chunk.getStart(),
-chunk.getLength()) 0)
-throw new
IOException(sm.getString(iib.failedwrite));
+// FIXME: It would likely be more efficient to do a number of
writes
+// through the direct BB; however, the case should happen very
rarely.
+// An algorithm similar to ByteChunk.append may also be better.
+if (chunk.getLength() bbuf.capacity()) {
+if (Socket.send(socket, chunk.getBuffer(), chunk.getStart(),
+chunk.getLength()) 0) {
+throw new IOException(sm.getString(iib.failedwrite));
}
+} else {
+if (bbuf.position() + chunk.getLength() bbuf.capacity()) {
+flushBuffer();
+}
+bbuf.put(chunk.getBuffer(), chunk.getStart(),
chunk.getLength());
}
-bbuf.put(chunk.getBuffer(), chunk.getStart(), chunk.getLength());
return chunk.getLength();
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c
jean-frederic clere wrote: Mladen Turk wrote: I think on/off is enough - Think of the questions nnn will bring in user list - So how about to just add the flag to JkOptions like +FlushPackets? Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
mturk 2005/05/18 04:03:32
Modified:jk/native/common jk_uri_worker_map.c
Log:
Log invalid uri map request as warning rather then error.
No functional change.
Revision ChangesPath
1.54 +3 -3
jakarta-tomcat-connectors/jk/native/common/jk_uri_worker_map.c
Index: jk_uri_worker_map.c
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_uri_worker_map.c,v
retrieving revision 1.53
retrieving revision 1.54
diff -u -r1.53 -r1.54
--- jk_uri_worker_map.c 13 Apr 2005 11:04:10 - 1.53
+++ jk_uri_worker_map.c 18 May 2005 11:03:31 - 1.54
@@ -425,8 +425,8 @@
return NULL;
}
if (*uri != '/') {
-jk_log(l, JK_LOG_ERROR,
-uri must start with /);
+jk_log(l, JK_LOG_WARNING,
+Uri %s is invalid. Uri must start with /);
JK_TRACE_EXIT(l);
return NULL;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
mturk 2005/05/18 04:09:55
Modified:jk/native/common jk_uri_worker_map.c
Log:
Log invalid uri map request as warning rather then error.
No functional change.
Revision ChangesPath
1.55 +2 -2
jakarta-tomcat-connectors/jk/native/common/jk_uri_worker_map.c
Index: jk_uri_worker_map.c
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_uri_worker_map.c,v
retrieving revision 1.54
retrieving revision 1.55
diff -u -r1.54 -r1.55
--- jk_uri_worker_map.c 18 May 2005 11:03:31 - 1.54
+++ jk_uri_worker_map.c 18 May 2005 11:09:55 - 1.55
@@ -426,7 +426,7 @@
}
if (*uri != '/') {
jk_log(l, JK_LOG_WARNING,
-Uri %s is invalid. Uri must start with /);
+Uri %s is invalid. Uri must start with /, uri);
JK_TRACE_EXIT(l);
return NULL;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Filter question
Hi, suggest, that I am creating a filter, which replaces the input stream. This works fine, if the input stream is used by the application itself. However, there are cases, when the Request class itself is accessing the input stream: If the method is POST and the content type is application/x-www-form-urlencoded and a method like getParameterNames() is invoked. In that case, the Request class is simply accessing the original input stream, circumventing the request wapper, that my filter has created. 1.) Is that intentional or is that a bug? 2.) If the former: Is there a way, I can ensure that my input stream is used? 3.) If the latter: Is there any chance to fix the bug? In other words: Does the Request class have access to the wrapper created by my filter? I'd be able to create and submit a patch in that case. Regards, Jochen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34952] New: - Installer modifies windows service when it shouldn't
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34952. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34952 Summary: Installer modifies windows service when it shouldn't Product: Tomcat 5 Version: 5.5.9 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Native:Packaging AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] 1) Install one instance of Tomcat with install service enabled 2) Install second instance of Tomcat with install service disabled The 2nd installation will modify the existing Tomcat service to point to the new Tomcat installation path. Expected behavior: The 2nd installation should not touch the service configuration since the installer was explicitly instructed *not* to do anything service-related. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c
Mladen Turk wrote: jean-frederic clere wrote: Mladen Turk wrote: I think on/off is enough - Think of the questions nnn will bring in user list - So how about to just add the flag to JkOptions like +FlushPackets? +1. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34956] New: - Tomcat should enforce the requirements from servlet 2.4 specification SRV.8.2
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34956. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34956 Summary: Tomcat should enforce the requirements from servlet 2.4 specification SRV.8.2 Product: Tomcat 5 Version: 5.5.9 Platform: All OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Servlet JSP API AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] Tomcat should enforce the requirements from servlet 2.4 specification SRV.8.2 SRV.8.2 Using a Request Dispatcher To use a request dispatcher, a servlet calls either the include method or forward method of the RequestDispatcher interface. The parameters to these methods can be either the request and response arguments that were passed in via the service method of the Servlet interface, or instances of subclasses of the request and response wrapper classes that have been introduced for version 2.3 of the specification. In the latter case, the wrapper instances must wrap the request or response objects that the container passed into the service method. The Container Provider must ensure that the dispatch of the request to a target servlet occurs in the same thread of the same VM as the original request Justification: == The absense of this enforcement leads to software beeing developed not following the specification. The software cannot be deployed later on a container which conforms to the above paragraph and hence must be changed before deployment. This somehow contradicts the idea of having a standards based infrastructure. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c
good idea. Which state by default ? 2005/5/18, jean-frederic clere [EMAIL PROTECTED]: Mladen Turk wrote: jean-frederic clere wrote: Mladen Turk wrote: I think on/off is enough - Think of the questions nnn will bring in user list - So how about to just add the flag to JkOptions like +FlushPackets? +1. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c
Henri Gomez wrote: good idea. Which state by default ? off (-FlushPackets). 2005/5/18, jean-frederic clere [EMAIL PROTECTED]: Mladen Turk wrote: jean-frederic clere wrote: Mladen Turk wrote: I think on/off is enough - Think of the questions nnn will bring in user list - So how about to just add the flag to JkOptions like +FlushPackets? +1. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c
I really like being able to do: write(8K)*n + flush(). +1 on adding a FlushPackets config option set to off by default. Thank you Mladen and Jean-Frederic. Jean-Jacques [EMAIL PROTECTED] 5/18/2005 7:41 AM Henri Gomez wrote: good idea. Which state by default ? off (-FlushPackets). 2005/5/18, jean-frederic clere [EMAIL PROTECTED]: Mladen Turk wrote: jean-frederic clere wrote: Mladen Turk wrote: I think on/off is enough - Think of the questions nnn will bring in user list - So how about to just add the flag to JkOptions like +FlushPackets? +1. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net AprEndpoint.java
mturk 2005/05/18 09:01:46
Modified:util/java/org/apache/tomcat/util/net AprEndpoint.java
Log:
Fix typo. data.fdpool is APR pool not APR pollset.
Revision ChangesPath
1.29 +1 -1
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/AprEndpoint.java
Index: AprEndpoint.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/AprEndpoint.java,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -r1.28 -r1.29
--- AprEndpoint.java 18 May 2005 09:02:32 - 1.28
+++ AprEndpoint.java 18 May 2005 16:01:46 - 1.29
@@ -1132,7 +1132,7 @@
data.pos = data.pos + nw;
if (data.pos = data.end) {
// Entire file has been send
-Poll.destroy(data.fdpool);
+Pool.destroy(data.fdpool);
// Set back socket to blocking mode
Socket.optSet(data.socket,
Socket.APR_SO_NONBLOCK, 0);
return true;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net AprEndpoint.java
[EMAIL PROTECTED] wrote: mturk 2005/05/18 09:01:46 Modified:util/java/org/apache/tomcat/util/net AprEndpoint.java Log: Fix typo. data.fdpool is APR pool not APR pollset. -Poll.destroy(data.fdpool); +Pool.destroy(data.fdpool); Lol, sorry about that one ... It didn't crash on Windows, for some reason ;) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: APR support
Remy Maucherat wrote: Hi, After optimizing JNI invocations with NIO, I got the benchmark results I wanted from APR. The performance of the HTTP APR connector is now the same as the regular HTTP connector (at least on Windows) Here are the results for Linux: Server SLES9/amd64 with sp1. Client RHEL4/amd64. Connecet with Gigabit ethernet via crossconnect cable. Tested only static content. One interesting thing is that CPU usage for Tomcat is around 50% for 1m file, while when using APR with sendfile enabled it is around 23%. On window it's even lower. Not sure weather all the attachment will pass. If they don't I'll put them somewhere. One interesting thing is that for small files (1k) the httpd is two times slower then regular Tomcat. Regards, Mladen. std100k.txt Description: application/octet-string apr1k.txt Description: application/octet-string apr1m.txt Description: application/octet-string apr10k.txt Description: application/octet-string apr100k.txt Description: application/octet-string httpd1k.txt Description: application/octet-string httpd1m.txt Description: application/octet-string httpd10k.txt Description: application/octet-string httpd100k.txt Description: application/octet-string std1k.txt Description: application/octet-string std1m.txt Description: application/octet-string std10k.txt Description: application/octet-string - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/xdocs/config apache.xml
mturk 2005/05/18 11:04:53
Modified:jk/native/apache-1.3 mod_jk.c
jk/native/apache-2.0 mod_jk.c
jk/native/common jk_ajp_common.c jk_global.h jk_service.h
jk/native/iis jk_isapi_plugin.c
jk/native/netscape jk_nsapi_plugin.c
jk/xdocs changelog.xml
jk/xdocs/config apache.xml
Log:
Adde FlushPackets option.
Revision ChangesPath
1.83 +19 -7 jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c
Index: mod_jk.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c,v
retrieving revision 1.82
retrieving revision 1.83
diff -u -r1.82 -r1.83
--- mod_jk.c 15 May 2005 11:10:11 - 1.82
+++ mod_jk.c 18 May 2005 18:04:52 - 1.83
@@ -300,6 +300,15 @@
return JK_FALSE;
}
+static void JK_METHOD ws_flush(jk_ws_service_t *s)
+{
+if (s s-ws_private) {
+apache_private_data_t *p = s-ws_private;
+BUFF *bf = p-r-connection-client;
+ap_bflush(bf);
+}
+}
+
/*
* Write a chunk of response data back to the browser. If the headers
* haven't yet been sent over, send over default header values (Status =
@@ -317,7 +326,6 @@
apache_private_data_t *p = s-ws_private;
if (len) {
-BUFF *bf = p-r-connection-client;
char *buf = (char *)b;
int w = (int)len;
int r = 0;
@@ -329,6 +337,7 @@
}
if (p-r-header_only) {
+BUFF *bf = p-r-connection-client;
ap_bflush(bf);
return JK_TRUE;
}
@@ -351,11 +360,6 @@
}
}
-
-/*
- * To allow server push.
- */
-ap_bflush(bf);
}
return JK_TRUE;
@@ -436,6 +440,7 @@
s-start_response = ws_start_response;
s-read = ws_read;
s-write = ws_write;
+s-flush = ws_flush;
/* Clear RECO status */
s-reco_status = RECO_NONE;
@@ -454,6 +459,10 @@
else
s-remote_addr = NULL_FOR_EMPTY(r-connection-remote_ip);
+if (conf-options JK_OPT_FLUSHPACKETS)
+s-flush_packets = 1;
+else
+s-flush_packets = 0;
/* get server name */
/* s-server_name = (char *)(r-hostname ? r-hostname :
r-server-server_hostname); */
/* XXX : à la jk2 */
@@ -1503,6 +1512,9 @@
else if (!strcasecmp(w, ForwardLocalAddress)) {
opt = JK_OPT_FWDLOCAL;
}
+else if (!strcasecmp(w, FlushPackets)) {
+opt = JK_OPT_FLUSHPACKETS;
+}
else
return ap_pstrcat(cmd-pool, JkOptions: Illegal option ', w,
', NULL);
1.146 +14 -14jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c
Index: mod_jk.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v
retrieving revision 1.145
retrieving revision 1.146
diff -u -r1.145 -r1.146
--- mod_jk.c 15 May 2005 11:10:11 - 1.145
+++ mod_jk.c 18 May 2005 18:04:52 - 1.146
@@ -317,6 +317,14 @@
return JK_FALSE;
}
+static void JK_METHOD ws_flush(jk_ws_service_t *s)
+{
+if (s s-ws_private) {
+apache_private_data_t *p = s-ws_private;
+ap_rflush(p-r);
+}
+}
+
/*
* Write a chunk of response data back to the browser. If the headers
* haven't yet been sent over, send over default header values (Status =
@@ -387,18 +395,6 @@
}
}
-
-/*
- * To allow server push. After writing full buffers
- */
-#ifndef AS400
-if (ap_rflush(p-r) != APR_SUCCESS) {
-ap_log_error(APLOG_MARK, APLOG_STARTUP | APLOG_CRIT, 0,
- NULL, mod_jk: Error flushing);
-return JK_FALSE;
-}
-#endif
-
}
return JK_TRUE;
@@ -462,6 +458,7 @@
s-start_response = ws_start_response;
s-read = ws_read;
s-write = ws_write;
+s-flush = ws_flush;
/* Clear RECO status */
s-reco_status = RECO_NONE;
@@ -478,7 +475,10 @@
s-remote_addr = NULL_FOR_EMPTY(r-connection-local_ip);
else
s-remote_addr = NULL_FOR_EMPTY(r-connection-remote_ip);
-
+if (conf-options JK_OPT_FLUSHPACKETS)
+s-flush_packets = 1;
+else
+s-flush_packets = 0;
/* get server name */
s-server_name = (char *)ap_get_server_name(r);
1.117 +15 -12
jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c
cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c
mturk 2005/05/18 11:17:23 Modified:jk/native/apache-1.3 mod_jk.c jk/native/apache-2.0 mod_jk.c Log: Add JK_OPT_FLUSHPACKETS to default options. Revision ChangesPath 1.84 +2 -2 jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c Index: mod_jk.c === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c,v retrieving revision 1.83 retrieving revision 1.84 diff -u -r1.83 -r1.84 --- mod_jk.c 18 May 2005 18:04:52 - 1.83 +++ mod_jk.c 18 May 2005 18:17:23 - 1.84 @@ -1879,7 +1879,7 @@ c-format_string = NULL; c-format = NULL; c-mountcopy = JK_FALSE; -c-options = JK_OPT_FWDURIDEFAULT; +c-options = JK_OPT_FWDURIDEFAULT | JK_OPT_FLUSHPACKETS; /* * By default we will try to gather SSL info. 1.147 +2 -2 jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c Index: mod_jk.c === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v retrieving revision 1.146 retrieving revision 1.147 diff -u -r1.146 -r1.147 --- mod_jk.c 18 May 2005 18:04:52 - 1.146 +++ mod_jk.c 18 May 2005 18:17:23 - 1.147 @@ -2048,7 +2048,7 @@ c-format = NULL; c-mountcopy = JK_FALSE; c-was_initialized = JK_FALSE; -c-options = JK_OPT_FWDURIDEFAULT; +c-options = JK_OPT_FWDURIDEFAULT | JK_OPT_FLUSHPACKETS; /* * By default we will try to gather SSL info. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c
mturk 2005/05/18 11:19:31 Modified:jk/native/apache-1.3 mod_jk.c jk/native/apache-2.0 mod_jk.c Log: Brr... Revert latest commit. We agreed not to flush packets by default. Revision ChangesPath 1.85 +2 -2 jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c Index: mod_jk.c === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c,v retrieving revision 1.84 retrieving revision 1.85 diff -u -r1.84 -r1.85 --- mod_jk.c 18 May 2005 18:17:23 - 1.84 +++ mod_jk.c 18 May 2005 18:19:31 - 1.85 @@ -1879,7 +1879,7 @@ c-format_string = NULL; c-format = NULL; c-mountcopy = JK_FALSE; -c-options = JK_OPT_FWDURIDEFAULT | JK_OPT_FLUSHPACKETS; +c-options = JK_OPT_FWDURIDEFAULT; /* * By default we will try to gather SSL info. 1.148 +2 -2 jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c Index: mod_jk.c === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v retrieving revision 1.147 retrieving revision 1.148 diff -u -r1.147 -r1.148 --- mod_jk.c 18 May 2005 18:17:23 - 1.147 +++ mod_jk.c 18 May 2005 18:19:31 - 1.148 @@ -2048,7 +2048,7 @@ c-format = NULL; c-mountcopy = JK_FALSE; c-was_initialized = JK_FALSE; -c-options = JK_OPT_FWDURIDEFAULT | JK_OPT_FLUSHPACKETS; +c-options = JK_OPT_FWDURIDEFAULT; /* * By default we will try to gather SSL info. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c
mturk 2005/05/18 11:21:59
Modified:jk/native/apache-2.0 mod_jk.c
Log:
Add missing FlushPackets JkOption.
Revision ChangesPath
1.149 +4 -1 jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c
Index: mod_jk.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v
retrieving revision 1.148
retrieving revision 1.149
diff -u -r1.148 -r1.149
--- mod_jk.c 18 May 2005 18:19:31 - 1.148
+++ mod_jk.c 18 May 2005 18:21:59 - 1.149
@@ -1525,6 +1525,9 @@
else if (!strcasecmp(w, ForwardLocalAddress)) {
opt = JK_OPT_FWDLOCAL;
}
+else if (!strcasecmp(w, FlushPackets)) {
+opt = JK_OPT_FLUSHPACKETS;
+}
else
return apr_pstrcat(cmd-pool, JkOptions: Illegal option ', w,
', NULL);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.13 TAGGED
Hi, Henri Gomez wrote: Or provide a jk 1.2.13a including this fix for novell ? I would like to skip that, but I like the Jean-Frederic's idea about putting the tarballs inside binaries/netware/ my concern if any is that the patch should be tested by all platforms, not only with NetWare - that's one discipline of beta testing I thought however since the patch is really trivial it really shouldnt matter this time BUT: if this one file was left out with tagging consider that there might be more files missing we not know of yet...! Anyhow, the plan was retag that as 1.2.14 if everything else is OK, or make 1.2.14-rc-(xxx), after some test period, like couple of weeks. hmm, cant we just have 1.2.13.1, 1.2.13.2, 1.2.13.3, till we reach 1.2.14 finally at first hit as stable? just a question... If you guys are OK with JJC concerns and my proposal on ap_rflush/JkFlush we can add that to 1.2.14-rc-1, or leave that for 1.3 branch. +1 for adding now. greets, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
