DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 07:59 ---
(In reply to comment #9)
 The .jsp file date stamp doesn't have to go back in time for the isOutDated
 check to fail, it can and does fail in a more normal usage pattern.
 Here is a scenario that shows the problem:
 - I deploy version 1, the .jsp has time1
 - I make version 2 of the .jsp at time2
 - Visitor visits the site, and the .jsp is compiled at time3
 - I deploy version2
 - isOutDated returns false as time3  time2
 
 Would setting the date stamp of the .java and .class files to the date stamp 
 of
 the .jsp file, and changing the comparison from  to != in the isOutDated 
 check
 fix the problem sufficiently?  Or are there negative side effects I haven't
 thought of?
 
 I am working on patching my Tomcat to do exactly as above, I would be happy to
 give it to someone for evaluation when its ready.  

As looked into in comment #6, this is not doable easily, which makes the few use
cases which could benefit from this not worth it. Please try to read the report
next time.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-5 build.xml

2005-09-22 Thread remm
remm2005/09/22 03:39:37

  Modified:.build.xml
  Log:
  - Fix build by excluding tagPlugins.xml.
  - This file shouldn't be in the standard examples, but rather copied there
before precompiling (once it works again, of course).
  
  Revision  ChangesPath
  1.238 +3 -1  jakarta-tomcat-5/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
  retrieving revision 1.237
  retrieving revision 1.238
  diff -u -r1.237 -r1.238
  --- build.xml 1 Sep 2005 18:28:24 -   1.237
  +++ build.xml 22 Sep 2005 10:39:37 -  1.238
  @@ -779,7 +779,9 @@
   
   mkdir dir=${tomcat.build}/webapps/jsp-examples/
   copy todir=${tomcat.build}/webapps/jsp-examples
  -  fileset dir=${api.home}/jsr152/build/examples includes=**/
  +  fileset dir=${api.home}/jsr152/build/examples
  +exclude name=WEB-INF/tagPlugins.xml /
  +  /fileset
   /copy
   
   ant dir=${catalina.home}/webapps/ROOT target=build-main
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 29687] - java.lang.StackOverflowError

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=29687.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29687





--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 15:06 ---
Created an attachment (id=16488)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16488action=view)
Test case source and binary

This is simple test case which shows problem.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36742] - Missing diagnostics in InternalInputBuffer on overly long headers

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36742.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36742





--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 15:06 ---
Since the patch is logging at the info level - I would guess that most
production environments leave info turned off so the log filling issue wouldn't
be a non-issue.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Collecting Statistics

2005-09-22 Thread anita kulshreshtha
   Where could I find more information about the
statistics available via RequestInfo/RequestGroupInfo?
The manager application displays some of these 
statistics, but collects them differently. What is the
difference between the two?

Thanks
Anita



__ 
Yahoo! Mail - PC Magazine Editors' Choice 2005 
http://mail.yahoo.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 29687] - java.lang.StackOverflowError

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=29687.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29687


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 15:12 ---
Recently i noticed similar behaviour, and i attached little test case, whih
repeatedly shows analogous stack trace. The idea is to generate exception inside
error-page, which then recursively calls itself. Stupid idea, but it's stupidity
still doesn't permits bugs in tomcat.

Please notice: StackOverflow occurs not in client's code -- it occurs between
tomcat and servlet api. So, i believe, this bug isn't about forwarding on
client's page -- it's about pointer, lost somewhere in tomcat code, or similar.

I use tomcat 5.5.9.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36742] - Missing diagnostics in InternalInputBuffer on overly long headers

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36742.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36742





--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 15:25 ---
(In reply to comment #5)
 Since the patch is logging at the info level - I would guess that most
 production environments leave info turned off so the log filling issue 
 wouldn't
 be a non-issue.

Ok.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-09-22 Thread yoavs
yoavs   2005/09/22 06:34:06

  Modified:catalina/src/bin service.bat
   webapps/docs changelog.xml
  Log:
  Bugzilla 35609: http://issues.apache.org/bugzilla/show_bug.cgi?id=35609
  
  Revision  ChangesPath
  1.13  +3 -3  jakarta-tomcat-catalina/catalina/src/bin/service.bat
  
  Index: service.bat
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/bin/service.bat,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- service.bat   5 May 2005 16:24:38 -   1.12
  +++ service.bat   22 Sep 2005 13:34:05 -  1.13
  @@ -54,7 +54,7 @@
   if %1 == uninstall goto doRemove
   echo Unknown parameter %1
   :displayUsage
  -echo 
  +echo.
   echo Usage: service.bat install/remove [service_name]
   goto end
   
  @@ -71,7 +71,7 @@
   echo Using CATALINA_BASE:%CATALINA_BASE%
   echo Using JAVA_HOME:%JAVA_HOME%
   
  -rem Use the environment variables as an exaple
  +rem Use the environment variables as an example
   rem Each command line option is prefixed with PR_
   
   set PR_DESCRIPTION=Apache Tomcat Server - http://jakarta.apache.org/tomcat
  
  
  
  1.376 +4 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.375
  retrieving revision 1.376
  diff -u -r1.375 -r1.376
  --- changelog.xml 20 Sep 2005 10:56:48 -  1.375
  +++ changelog.xml 22 Sep 2005 13:34:05 -  1.376
  @@ -66,6 +66,10 @@
 fix
   bug36541/bug: Full synchronization for session objects 
attributes collections (remm)
 /fix
  +  fix
  +bug35609/bug: service.bat echo command when wrong arguments 
given [patch by Robert
  +Longson] (yoavs)
  +  /fix
   /changelog
 /subsection
 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 35609] - windows service.bat prints ECHO is off. with invalid arguments

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35609.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35609


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 15:34 ---
Done for 5.5.12.  Thank you for contributing ;)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36771] New: - Using DataSource Realm exausts connections on redeploy

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36771.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36771

   Summary: Using DataSource Realm exausts connections on redeploy
   Product: Tomcat 5
   Version: 5.5.6
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: major
  Priority: P2
 Component: Unknown
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Hello,
I'm testing an application with a DataSourceRealm configured in the Context in
this way:
Realm className=org.apache.catalina.realm.DataSourceRealm
 dataSourceName=jdbc/myds
 roleNameCol=domain_name
 userCredCol=password
 userNameCol=username
 userRoleTable=domainadmin 
 userTable=adminuser
/

They works fine but everytime I redeploy the application a connection is kept
and not freed, so after redeploying n times where n is the number of connections
defined in the datasource the realm can't work any more and I have to restart
tomcat.
I suppose the realm should intercept the context shutdown and release the
connection used to authenticate users.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml cluster-howto.xml

2005-09-22 Thread yoavs
yoavs   2005/09/22 06:39:32

  Modified:webapps/docs changelog.xml cluster-howto.xml
  Log:
  Bugzilla 35613: http://issues.apache.org/bugzilla/show_bug.cgi?id=35613
  
  Revision  ChangesPath
  1.377 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.376
  retrieving revision 1.377
  diff -u -r1.376 -r1.377
  --- changelog.xml 22 Sep 2005 13:34:05 -  1.376
  +++ changelog.xml 22 Sep 2005 13:39:32 -  1.377
  @@ -109,6 +109,9 @@
 fix
   bug36518/bug: Classname typos for senders, submitted by 
Christoph Bachhuber-Haller (remm)
 /fix
  +  add
  +bug35613/bug: Added FAQ question and answer about 
tcpListenAddress=auto and /etc/hosts (yoavs)
  +  /add
   /changelog
 /subsection
 
  
  
  
  1.12  +5 -0  jakarta-tomcat-catalina/webapps/docs/cluster-howto.xml
  
  Index: cluster-howto.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/cluster-howto.xml,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- cluster-howto.xml 8 Jul 2005 20:52:50 -   1.11
  +++ cluster-howto.xml 22 Sep 2005 13:39:32 -  1.12
  @@ -1131,6 +1131,11 @@
   /ul   
 p/p
 /li
  +liQ: I get localhost rather than eth0 or another interface when using 
tcpListenAddress=auto.p/p
  +A: Change /etc/hosts so that the localhost domain resolves to the actual 
IP address of the NIC, eth0.  
  +   Please see a 
href=http://issues.apache.org/bugzilla/show_bug.cgi?id=35613;Bugzilla/a for 
more.
  +p/p
  +/li
   
   /ol
   /section
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 35613] - server.xml - tcpListenAddress within cluster/Receiver with 'auto' breaking cluster

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35613.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35613


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 15:39 ---
Added this as a clustering FAQ question and answer.  Thanks.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 29687] - java.lang.StackOverflowError

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=29687.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29687


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 15:39 ---
The test case provided will cause a java.lang.StackOverflowError regardless of
container.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r290948 [2/2] - in /tomcat/site/trunk: docs/faq/ docs/faq/printer/ xdocs-faq/

2005-09-22 Thread yoavs
Added: tomcat/site/trunk/docs/faq/printer/cluster.html
URL: 
http://svn.apache.org/viewcvs/tomcat/site/trunk/docs/faq/printer/cluster.html?rev=290948view=auto
==
--- tomcat/site/trunk/docs/faq/printer/cluster.html (added)
+++ tomcat/site/trunk/docs/faq/printer/cluster.html Thu Sep 22 07:04:25 2005
@@ -0,0 +1,123 @@
+htmlheadMETA http-equiv=Content-Type content=text/html; 
charset=iso-8859-1titleTomcat FAQ - Cluster/titlemeta value=Yoav 
Shapira name=authormeta value=yoavs[at]apache[dot]org 
name=emailstyle
+  dt { font-size : larger;  font-weight : bold }
+  dd {padding-bottom : 10px;}
+/style/headbody vlink=#525D76 alink=#525D76 link=#525D76 
text=#00 bgcolor=#fftable cellspacing=4 width=100% 
border=0!--PAGE HEADER--trtd colspan=2!--JAKARTA LOGO--a 
href=http://jakarta.apache.org/;img border=0 alt=The Jakarta Project 
align=left 
src=http://jakarta.apache.org//images/jakarta-logo.gif;/a!--PROJECT 
LOGO--a href=http://jakarta.apache.org/tomcat/;img border=0 alt=
+  Tomcat FAQ
+ align=right src=../../images/tomcat.gif/a/td/tr!--HEADER 
SEPARATOR--trtd colspan=2hr size=1 noshade=/td/trtr!--RIGHT 
SIDE MAIN BODY--td align=left valign=top width=80%table 
cellspacing=4 width=100% border=0trtd nowrap=true valign=top 
align=lefth1Tomcat FAQ/h1h2Cluster/h2/tdtd nowrap=true 
valign=top align=rightimg border=0 hspace=0 vspace=0 height=1 
width=1 src=../../images/void.gif/td/tr/tabletable cellpadding=2 
cellspacing=0 border=0trtd bgcolor=#525D76font 
face=arial,helvetica.sanserif color=#ffa 
name=PrefacestrongPreface/strong/a/font/td/trtrtdblockquote
+  p
+This page discusses cluster- and clustering-related questions.  Please make
+sure to read the Clustering HowTo page in the main Tomcat documentation
+bundle as well.
+  /p
+/blockquote/td/tr/tabletable cellpadding=2 cellspacing=0 
border=0trtd bgcolor=#525D76font face=arial,helvetica.sanserif 
color=#ffa 
name=QuestionsstrongQuestions/strong/a/font/td/trtrtdblockquote
+p
+  ul
+lia href=#1Can I configure a cluster at the codeEngine/code 
level?/a/li
+lia href=#2Show me a simple cluster configuration example./a/li
+lia href=#3How do I turn on transport logging?/a/li
+lia href=#4How do I use JMX to monitor the cluster?/a/li
+lia href=#5Can I pause the message sending?/a/li
+lia href=#6Can I add more senders?/a/li
+lia href=#7What happens when I pull the network cable?/a/li
+lia href=#8At my windows laptop without network my cluster doesn't 
work?/a/li
+lia href=#9The cluster dosen't work under linux with two nodes at 
two boxes?/a/li
+lia href=#10I get localhost rather than eth0 or another 
interface when using tcpListenAddress=auto./a/li
+  /ul
+/p
+/blockquote/td/tr/tabletable cellpadding=2 cellspacing=0 
border=0trtd bgcolor=#525D76font face=arial,helvetica.sanserif 
color=#ffa 
name=AnswersstrongAnswers/strong/a/font/td/trtrtdblockquote
+  b style=font-size: larger
+a name=1Can I configure a cluster at the codeEngine/code level?/a
+  /b
+  div style=padding-left : 20px;
+Yes, beginning with Tomcat 5.5.10 you can configure clusters at both the
+codeEngine/code and codeHost/code levels.  This helps support
+clustering for web hosting companies.
+  /divbr
+
+  b style=font-size: larger
+a name=Show me a simple cluster configuration example./a
+  /b
+  div style=padding-left : 20px;
+For Tomcat 5.5.10 and later:br
+codelt;Cluster 
className=org.apache.catalina.cluster.tcp.SimpleTcpCluster defaultMode=true 
/gt;/code
+  /divbr
+
+  b style=font-size: larger
+a name=3How do I turn on transport logging?/a
+  /b
+  div style=padding-left : 20px;
+ol
+  liUse org.apache.catalina.cluster as logger category and switch to 
info, debug or trace as log level./li
+  liConfigure the bclusterLog/b attribute (logging category) to get 
and send and receive message log./li
+/ol
+  /divbr
+
+  b style=font-size: larger
+a name=4How do I use JMX to monitor the cluster?/a
+  /b
+  div style=padding-left : 20px;
+With Java 5 you can use the bjconsole/b application to look inside the 
runnnig cluster: please see the
+JMX configuration section in the Clustering HowTo document. br
+
+In ifastasyncmode/i replication mode you can got more information with 
+sender attributes codedoProcessingStats=true/code and 
codequeueDoStats=true/code.
+Finally, with the new JMX remote ant task you can access the state and 
call operations. 
+  /divbr
+
+  b style=font-size: larger
+a name=5Can I pause the message sending?/a
+  /b
+  div style=padding-left : 20px;
+Yes, the async senders buffer the messages, but make sure the membership 
ping is active.  With fastasyncqueue 
+mode you can limit the max queue size. 
+  /divbr
+
+  b style=font-size: larger
+a name=6Can I add more senders?/a
+  /b
+  div style=padding-left : 20px;
+Yes, with sender 

SVN update of site working OK?

2005-09-22 Thread Yoav Shapira
Hi,
Maybe I did something wrong here, or maybe I'm just missing a step, but if
someone (probably Mark) could help out  here, that'd be great ;)

I just added a new FAQ section on clustering to the SVN tomcat/site/trunk area.
 It's in xdocs-faq/cluster.xml.  I did svn add for that file, as well as the
docs/faq/cluster.html and docs/faq/printer/cluster.html.  The files were added
into SVN, then I did svn commit.  No errors, all looks fine.

Next I went to /www/jakarta.apache.org/tomcat/faq, ran SVN update.  Again no
errors, just a line saying it's at revision X, where X was the number after my
commit, so that looks correct.  But I don't see the cluster.html files there. 
I know I won't see them on the web for a while due to replication delays, but
when we used CVS I saw them on the filesystem right away.  Am I doing something
wrong?

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml cluster-howto.xml

2005-09-22 Thread yoavs
yoavs   2005/09/22 07:21:19

  Modified:webapps/docs changelog.xml cluster-howto.xml
  Log:
  Relocate clustering FAQ from howto to the main FAQ.
  
  Revision  ChangesPath
  1.378 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.377
  retrieving revision 1.378
  diff -u -r1.377 -r1.378
  --- changelog.xml 22 Sep 2005 13:39:32 -  1.377
  +++ changelog.xml 22 Sep 2005 14:21:18 -  1.378
  @@ -112,6 +112,9 @@
 add
   bug35613/bug: Added FAQ question and answer about 
tcpListenAddress=auto and /etc/hosts (yoavs)
 /add
  +  update
  +Moved FAQ section for Clustering from Clustering HowTo page to its 
own FAQ page. (yoavs)
  +  /update
   /changelog
 /subsection
 
  
  
  
  1.13  +1 -72 jakarta-tomcat-catalina/webapps/docs/cluster-howto.xml
  
  Index: cluster-howto.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/cluster-howto.xml,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- cluster-howto.xml 22 Sep 2005 13:39:32 -  1.12
  +++ cluster-howto.xml 22 Sep 2005 14:21:18 -  1.13
  @@ -1066,78 +1066,7 @@
   /section
   
   section name=FAQ
  -pTo be completed once we receive questions about session replication:/p
  -ol
  -liQ: Can I configure as engine level?p/p
  -
  -A: Since Tomcat 5.5.10 you can configure a cluster as engine and host 
level.
  -This helps to support clustering at a web hosting szenario.
  -  p/p
  -  /li
  -liQ: What is the simples cluster config?p/p
  -
  -A: Since Tomcat 5.5.10 you can configure a cluster with following: 
codelt;Cluster className=org.apache.catalina.cluster.tcp.SimpleTcpCluster 
defaultMode=true /gt;/code
  -  p/p
  -  /li
  -liQ: How can I activated transparent logging?p/p
  -
  -A: Use org.apache.catalina.cluster as logger category and switch to 
info, debug or trace as log level.
  -A: Configure the bclusterLog/b attribute (logging category) to get 
and send and receive message log.
  -  p/p
  -  /li
  -liQ: How can I used JMX information to monitor the cluster?p/p
  -
  -A: Yes, it exists a lot ot usefull information to the cluster as MBeans. 
With Java 5 you can use the
  -   jconsole to look inside the runnnig cluster (s. JMX section above).
  -   At fastasyncmode replication mode you can got more information with 
  -   sender attributes codedoProcessingStats=true/code and 
codequeueDoStats=true/code.
  -   With the new JMX remote ant task you can access the state and call 
operations. 
  -  p/p
  -  /li
  -lip/pQ: Can I pause the message sending?p/p
  -
  -A: Yes, the async senders buffer the messages, but make sure the 
membership ping is active. 
  -   With fastasyncqueue mode you can limit the max queue size. 
  -  p/p
  -  /li
  -liQ: Can I at more pooled senders?p/p
  -
  -A: Yes, with sender attribute codemaxPoolSocketLimit=40/code you 
can have more than the default
  -   code25/code sockets to transfer more parallel messages. 
  -  p/p
  -  /li
  -liQ: What happens when I pull the network cable?p/p
  -
  -A: Well, the other members will remove the instance from the cluster,
  -   but when you insert the cable again, the Tomcat instance might have 
completely flipped out.
  -   This is because the OS might start going 100% CPU when a multicast 
message is sent.
  -   There has not yet been a good solution for this, I will let you know 
when I have come up with one.
  -   (pero: I test this and I works correct with java 5 and exists when 
you use the cluster with JDK 1.4.x)
  -  p/p
  -  /li
  -liQ: At my windows laptop without network my cluster doesn't work?p/p
  -
  -A: The Membership attribute codemcastBindAddress=127.0.0.1/code 
must be set!  
  -  p/p
  -  /li
  -liQ: The cluster dosen't work under linux with two nodes at two 
boxes?p/p
  -
  -A: Check the the following topics:
  -ul
  -liIs your network interface enabled for multicast? codeifconfig eth0 
MULTICAST/code/li
  -liExists a multicast route to your network interface? coderoute add 
-host 228.0.0.4 dev eth0/code/li
  -liIs your firewall active? Then check that multicast port is on your 
UDP open list
  -   and the receiver TCP port is also for both machines open!/li
  -/ul   
  -  p/p
  -  /li
  -liQ: I get localhost rather than eth0 or another interface when using 
tcpListenAddress=auto.p/p
  -A: Change /etc/hosts so that the localhost domain resolves to the actual 
IP address of the NIC, eth0.  
  -   Please see a 
href=http://issues.apache.org/bugzilla/show_bug.cgi?id=35613;Bugzilla/a for 
more.
  -p/p
  -/li
  -
  -/ol
  +pPlease see 

Re: SVN update of site working OK?

2005-09-22 Thread Rahul Akolkar
On 9/22/05, Yoav Shapira [EMAIL PROTECTED] wrote:
 Hi,
 Maybe I did something wrong here, or maybe I'm just missing a step, but if
 someone (probably Mark) could help out  here, that'd be great ;)

 I just added a new FAQ section on clustering to the SVN tomcat/site/trunk 
 area.
  It's in xdocs-faq/cluster.xml.  I did svn add for that file, as well as the
 docs/faq/cluster.html and docs/faq/printer/cluster.html.  The files were added
 into SVN, then I did svn commit.  No errors, all looks fine.

 Next I went to /www/jakarta.apache.org/tomcat/faq, ran SVN update.  Again no
 errors, just a line saying it's at revision X, where X was the number after my
 commit, so that looks correct.  But I don't see the cluster.html files there.
 I know I won't see them on the web for a while due to replication delays, but
 when we used CVS I saw them on the filesystem right away.  Am I doing 
 something
 wrong?
snip/

AFAICS, your changes were to trunk and the update to the filesystem
looks at the pre-tlp branch.

-Rahul



 Yoav


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 35899] - Compression, noCompressionUserAgents and no user-agent header causes crash

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35899.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35899


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 16:25 ---
This has been fixed on the 5.5 tree for a little.  I don't know when the next
5.0 release will be out.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 35899] - Compression, noCompressionUserAgents and no user-agent header causes crash

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35899.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35899


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 16:27 ---
It's also fixed on the 5.0 branch, but the fix was committed after the 5.0.30
release.  Again, we don't know when 5.0.31 will come out.  If you really need
the fix, you can grab the code from CVS for the TOMCAT_5_0 branch and build
yourself, or just add the one line of code that is the fix into your own custom
Tomcat build...  (Or move to 5.5 of course).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34278] - error compiling file with jikes compiler

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34278.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34278


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 16:29 ---
Since we don't have the equipment to reproduce it, we depend on information from
you.  As no comment has been made in a couple of months, I'm closing this.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: SVN update of site working OK?

2005-09-22 Thread Yoav Shapira
Hi,

 AFAICS, your changes were to trunk and the update to the filesystem
 looks at the pre-tlp branch.

OK, that makes sense, and thank you for the explanation.

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 17:32 ---
Remy,
With all due respect I did read the report fully and I believe the
recommendation I made addressed comment #6.  If you feel my recommendation isn't
sufficient, please state why.
The other point in my first comment was that this bug can manifest itself in
ways more common than the original report, in fact that's why my colleague and I
found it.  
I have patched and tested my local Tomcat, and am attaching the two files I
modified for review.

(In reply to comment #10)
 (In reply to comment #9)
  The .jsp file date stamp doesn't have to go back in time for the isOutDated
  check to fail, it can and does fail in a more normal usage pattern.
  Here is a scenario that shows the problem:
  - I deploy version 1, the .jsp has time1
  - I make version 2 of the .jsp at time2
  - Visitor visits the site, and the .jsp is compiled at time3
  - I deploy version2
  - isOutDated returns false as time3  time2
  
  Would setting the date stamp of the .java and .class files to the date 
  stamp of
  the .jsp file, and changing the comparison from  to != in the isOutDated 
  check
  fix the problem sufficiently?  Or are there negative side effects I haven't
  thought of?
  
  I am working on patching my Tomcat to do exactly as above, I would be happy 
  to
  give it to someone for evaluation when its ready.  
 
 As looked into in comment #6, this is not doable easily, which makes the few 
 use
 cases which could benefit from this not worth it. Please try to read the 
 report
 next time.
 



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453





--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 17:35 ---
Created an attachment (id=16489)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16489action=view)
Changes to Compiler.java and JspCompilationContext.java to fix bug 33453

Modified Compiler.java isOutDated() method to use != instead of  for datestamp
comparison.
Modified JspCompilationContext.java compile() method to set the datestamp of
the generated .java and .class files to the datestamp of the source .jsp.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 18:23 ---
Remy,
I will keep re-opening this bug until you take the time to explain to me why I
am wrong.  Which even you can't, because I'm not.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector CoyoteAdapter.java

2005-09-22 Thread remm
remm2005/09/22 10:20:21

  Modified:webapps/docs changelog.xml
   catalina/src/share/org/apache/catalina/connector
CoyoteAdapter.java
  Log:
  - 34749: jsessionid dropped on trailing slash (/) redirect.
  
  Revision  ChangesPath
  1.379 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.378
  retrieving revision 1.379
  diff -u -r1.378 -r1.379
  --- changelog.xml 22 Sep 2005 14:21:18 -  1.378
  +++ changelog.xml 22 Sep 2005 17:20:21 -  1.379
  @@ -70,6 +70,9 @@
   bug35609/bug: service.bat echo command when wrong arguments 
given [patch by Robert
   Longson] (yoavs)
 /fix
  +  fix
  +bug34749/bug: jsessionid dropped on trailing slash (/) redirect 
(remm)
  +  /fix
   /changelog
 /subsection
 
  
  
  
  1.10  +7 -1  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/CoyoteAdapter.java
  
  Index: CoyoteAdapter.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/CoyoteAdapter.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- CoyoteAdapter.java30 Apr 2005 03:32:43 -  1.9
  +++ CoyoteAdapter.java22 Sep 2005 17:20:21 -  1.10
  @@ -305,6 +305,12 @@
   if (!redirectPathMB.isNull()) {
   String redirectPath = redirectPathMB.toString();
   String query = request.getQueryString();
  +if (request.isRequestedSessionIdFromURL()) {
  +// This is not optimal, but as this is not very common, it
  +// shouldn't matter
  +redirectPath = redirectPath + ;jsessionid= 
  ++ request.getRequestedSessionId();
  +}
   if (query != null) {
   // This is not optimal, but as this is not very common, it
   // shouldn't matter
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34749] - jsessionid dropped on trailing slash (/) redirect

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34749.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34749


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 19:20 ---
I have fixed this in the 5.5.x branch, to be integrated in 5.5.12.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 35984] - ClientAbortException should override getCause()

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35984.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35984


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 19:24 ---
This has been fixed in 5.5.11.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36254] - Creating symlink causes NullPointerException

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36254.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36254


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 19:26 ---
This has most likely been fixed in 5.5.10.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-5 build.xml

2005-09-22 Thread Mark Thomas

[EMAIL PROTECTED] wrote:

remm2005/09/22 03:39:37

  Modified:.build.xml
  Log:
  - Fix build by excluding tagPlugins.xml.
  - This file shouldn't be in the standard examples, but rather copied there
before precompiling (once it works again, of course).


This should be unnecessary. Bill has already removed the file from SVN.

For the record, all members of the tomcat pmc have karma for all 
modules including the specs. This allows us to fix issues with the 
examples.


Mark



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 20:18 ---
Sorry for letting you down, I was having dinner.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-5 build.xml

2005-09-22 Thread Remy Maucherat

Mark Thomas wrote:

[EMAIL PROTECTED] wrote:


remm2005/09/22 03:39:37

  Modified:.build.xml
  Log:
  - Fix build by excluding tagPlugins.xml.
  - This file shouldn't be in the standard examples, but rather copied 
there

before precompiling (once it works again, of course).


This should be unnecessary. Bill has already removed the file from SVN.


Yes, I saw it after my commit, you're completely right. I'm still using 
the CVS repository however, and it doesn't hurt much ;)


Will Yoav tag the CVS or SVN for the upcoming release ?

For the record, all members of the tomcat pmc have karma for all modules 
including the specs. This allows us to fix issues with the examples.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453





--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 21:05 ---
Since when is it a good idea to *close* a bug that you can't think of how to fix
offhand, and don't feel like fixing yourself?

This behavior is infantile and is an embarassing contradiction to the spirit of
the open source development model. And now you're refusing to look at a patch
just to save face? This is really sad.

I wonder how many other Tomcat bugs exist but were closed because somebody
didn't want to think about them or try to resolve them.

Maybe you ought to use the priority and target milestone features instead of
pretending that Tomcat does the right thing because whatever it currently does
defines what the right thing is.

I'm not going to reopen this because I'm not wasting any more time on this
little power game. There are competitors to Tomcat and this is just another
reason to use them instead.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-5 build.xml

2005-09-22 Thread Yoav Shapira
Hi,

 Will Yoav tag the CVS or SVN for the upcoming release ?

I was going to tag both repositories this one time.

  For the record, all members of the tomcat pmc have karma for all modules 
  including the specs. This allows us to fix issues with the examples.

This is great.

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-5 build.xml

2005-09-22 Thread Mark Thomas

Yoav Shapira wrote:

Hi,



Will Yoav tag the CVS or SVN for the upcoming release ?



I was going to tag both repositories this one time.


I am 99% sure that you will not be able to tag the CVS repositories 
that have already migrated since they will be locked. This will only 
affect servletapi for TC5.


Mark



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453





--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 21:45 ---
Created an attachment (id=16492)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16492action=view)
Changes to JspCompilationContext.java

Sets the lastModified on the generated .java and .class files to the
lastModified of the source .jsp

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #16489|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 21:46 ---
Created an attachment (id=16493)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16493action=view)
Change to Compiler.java

Change the  to != in the isOutDated method.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |




--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 22:00 ---
As suggested by Rainer, I have submitted my recommended changes in patch form
for easier review.

Remy, I was also at lunch so unfortunately I was delayed in re-opening the bug,
which I likewise apologize for.  I accept your apology. I am considering
creating a script to automate my re-opening of the bug.  As a peace offering I
am willing to automate your part, automatically changing the status to RESOLVED
WONTFIX, just send me your bugzilla login and password.

By the way, if you bothered to take the time to think about the problem, you
would realize as I have that the current behavior is very broken.  As I have
stated before, not just for the original use case in the bug report, it affects
every .jsp modification, without moving the timestamp backward whatsoever.  This
bug affects everyone, period.
 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453





--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 23:27 ---
My instinct is that changing the true timestamp of generated files is going to
cause other problems. I am very uneasy with a solution that means what a user
sees (in terms of timestamps) isn't going to be what actually happened.

It is also worth having a look at bug 23406. In that case timing resolutions to
the nearest second were not sufficient to resolve the issue. Any patch for this
issue should also address the issue in 23406.

My preference would be for a patch that recorded, for each JSP, somthing that is
guaranteed to change for all of the related use cases. Timestamp + file size
should be OK, MD5 certainly would be.

My general unease about changing file timestamps hasn't got to the point where I
would -1 this patch but I haven't had time to reflect on this yet.

In summary:
- I agree this is a problem
- I agree the right solution isn't going to be easy
- I think we need a more robust solution that the current patch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453





--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 23:33 ---
(In reply to comment #19)
 In summary:
 - I agree this is a problem

I disagree.

 - I agree the right solution isn't going to be easy

I do not wish to find any solution to this non issue. The only problem is that
people will have to use touch or similar in a few very select situations, which
apparently is too difficult.

 - I think we need a more robust solution that the current patch.

Yes, -1 for it. Obviously, anyone is free to waste his time on this trying to
find an acceptable solution, but the said solution has better be trivial,
otherwise it will get a -1 from me.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453





--- Additional Comments From [EMAIL PROTECTED]  2005-09-22 23:43 ---
Setting timestamp seems not a clean solution to me. API doc says, hat the time
might be rounded, so even if we try to set the time to the same timestamp we get
from the JSP, the resulting timestamp might differ and not be equal to the
original time (Consider diffrent file system types etc.).

I would also prefer a solution where information about the JSP is saved and
later compared. Would JspServletWrapper be the right place to save the original
JSP modification time?

MD5 would be nice, but then md5 checksum would need to be recalculated on every
JSP check with unchanged file time, so unfortunately not a rare case. I guess
that's too bad for performance.

Maybe timestamp and size would be enough, because both can be retrieved easy and
efficiently, and if timestamp did not change, but content did change, it is very
likely, that the file was in progress of being written to, so at least size
should have changed.

If we agree, that it's worth trying to make a patch to JspServletWrapper, I'll
try to submit one tomorrow (not really for 5.5.12).

One thing remains though: I'm not sure how to handle the case of included JSPs
(dependecies). Maybe I'll find a solution by digging deeper into Jasper.

One last word: I had customers having problems with both scenarios: rolling back
file changes, but also distributing content with wrong timestamps (future time)
and in consequence continuous recompilation for several minutes. Not trying to
assume a simple time model seems to make jasper more robust.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 35302] - [PATCH] error page redirection for JK/ISAPI on service fail

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35302.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35302





--- Additional Comments From [EMAIL PROTECTED]  2005-09-23 00:02 ---
To clarify why this patch is useful (this is the way we use the functionality).

We usually deploy several applications to a single website, requiring multiple
ISAPI redirectors.
There are a couple of cases where the connection from the web server to the
Tomcat engine can fail:
 1. The ISAPI redirector isn't installer properly as a filter
 2. The Extension side of things fails to communicate with Tomcat

We handle these errors on a site by:
 1. Putting a static page on the web server with the same name as the default
resource indicating a web server misconfiguration. If the filter doesn't work,
then this page is served.
 2. Sending a redirect to a designated static error page indicating that Tomcat
couldn't be reached when the Extension fails to communicate with Tomcat. 

Case 2 is what this patch addresses. It allows us to distinguish between generic
500 errors and those caused by the ISAPI redirector, and further allows us to
distinguish between failures to different back-end applications.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453





--- Additional Comments From [EMAIL PROTECTED]  2005-09-23 00:13 ---
(In reply to comment #21)
 I would also prefer a solution where information about the JSP is saved and
 later compared. Would JspServletWrapper be the right place to save the 
 original
 JSP modification time?

Nope, people can restart the container.

 MD5 would be nice, but then md5 checksum would need to be recalculated on 
 every
 JSP check with unchanged file time, so unfortunately not a rare case. I guess
 that's too bad for performance.

Arg MD5.

 Maybe timestamp and size would be enough, because both can be retrieved easy 
 and
 efficiently, and if timestamp did not change, but content did change, it is 
 very
 likely, that the file was in progress of being written to, so at least size
 should have changed.

This is simple, and maybe acceptable, but would make the cost of checking for
recompilation (even) more expensive than it is right now.

 One last word: I had customers having problems with both scenarios: rolling 
 back
 file changes, but also distributing content with wrong timestamps (future 
 time)
 and in consequence continuous recompilation for several minutes. Not trying to
 assume a simple time model seems to make jasper more robust.

On access compilation and its friend the development mode - which you are using
or you would not have this issue - should not be used in production (the only
reason why it is not as bad as it used to be is that I tweaked it do do only one
check at most per page per time interval - obviously if there are 100 pages, my
trick will not work that well).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453





--- Additional Comments From [EMAIL PROTECTED]  2005-09-23 00:32 ---
You disagree because you don't fully understand the problem.  If someone first
visits your .jsp after your modification, but before redeployment, you will be
hit by this bug.  You will wonder why your change didn't take effect.  It is not
necessary for the timestamp to move backwards.  You don't control when your .jsp
is accessed.  As your development/test servers will see different access than
your production, you will encounter a production bug that you didn't see in your
other environments.  Or if you are load balanced you will encounter the bug on
one machine but not another.  Good luck debugging that when it happens to you.

Using touch is not difficult, just add it to the documentation for JBoss and
every other web server that to hot deploy, do the following:  hot deploy, find
the tmp directory where the war is unpacked, touch every .jsp file that changed.
   And do that atomically so that noone can visit the .jsp inbetween.

The jasper code as is fails badly, my fix is trivial, is an improvement, but
still not 100% correct and has the side effect of changing a couple timestamps.
 The only place I'm aware of in Jasper that uses those timestamps is the broken
isOutDated logic.  

My fix doesn't handle dependencies correctly, and there is still the possibility
the .jsp is visited in the same second / minute / whatever the OS granularity is
as the modification.  Another side effect of my fix is that every .jsp will be
recompiled once after the fix is applied.

Timestamp rounding by the filesystem is not an issue, the timestamp of the .jsp
will be rounded the same way as the .class and .java files.  Every OS will round
timestamps in an internally consistent manner.

If changing the timestamps of the .java and .class files is still deemed
verboten, then I suggest copying the .jsp to the same temporary directory that
the .java and .class files are generated in, and preserving its timestamp.  Then
 timestamp, filesize, md5, even the exact contents of the file can be compared.

Remy, I am using JBoss4.0.2, how should I be deploying .jsps to production to
avoid this issue?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2005-09-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33453.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453





--- Additional Comments From [EMAIL PROTECTED]  2005-09-23 01:01 ---
For what it's worth:
A few years ago we implemented the timestamp approach to this issue in the
WebSphere Application Server JSP container at the request of a small number of
customers - for whom it was critical.  A generated classfiles is set to the
timestamp of the source JSP file.  The classfile is considered to be outdated
when the two timestamps do not match.  File size is not part of the equation.
Tag files are handled the same way.
The timestamp disconnect :) of classfiles vs. their actual compilation time
rarely causes confusion among customers; it's a non-issue. We write compilation
time/date and other information into the generated .java file, in a comment, so
any confusion that might occur can be easily cleared up.
The timestamp != strategy has worked well on Versions 4 through 6, on all
platforms. Dependency tracking (static includes, TLDs, tag files) is easily
managed. The race condition described in bug 23406 has never been reported. 
Timestamp rounding has never been an issue.
Google for websphere jsp timestamp and you'll find some info about the
implementation.
Some things to consider if you all decide it's an appropriate change for Tomcat
(this stuff is all documented and easily found on the web):
When serving JSP sources from JARs, we use the timestamp of the JAR for the
outdated check.
Any expansion of WARs or other compressed artifacts with precompiled JSP classes
must maintain timestamps (doh).
There *will* be first-time recompilation cost to Tomcat users if this is
implemented, as Jonathan mentioned.  Some won't like it.  
Keeping data only in a runtime artifact like the servletwrapper won't work, as
Remy stated.
  



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]