PATCH jk_worker_status.c jk2_worker_status_service()

[NormW]

Greetings All.
The following link is a patch which I believe simplifies the structure of
the _sevice() function by removing some NULL tests and an If(test) from the
processing stream.
http://www.gknw.com/norm/jk_worker_status.c.diff
The following section shows the structure implemented rather the diff itself
as is the usual case.
By setting a default query_string first, the NULL tests are no loner
required. By doing the common headers first, only one if(qry=) test is
needed.
Norm
--
if( w->mbean->debug > 0 )
env->l->jkLog(env, env->l, JK_LOG_DEBUG, "status.service() %s %s\n",
  JK_CHECK_NULL(uri), JK_CHECK_NULL(s->query_string));

if( s->query_string == NULL ) {
s->query_string="all";
}

/* Generate the header */
s->status=200;
s->msg="OK";
s->headers_out->put(env, s->headers_out, "Pragma", "no-cache", NULL);
s->headers_out->put(env, s->headers_out, "Cache-Control", "no-cache",
NULL);

/** Decide if text or html. */
if( strncmp( s->query_string, "qry=", 4) == 0 ) {
s->headers_out->put(env, s->headers_out, "Content-Type",
"text/plain", NULL);
s->head(env, s );
} else {
s->headers_out->put(env, s->headers_out, "Content-Type",
"text/html", NULL);
s->head(env, s );
s->jkprintf(env, s, "%s\n", DEFAULT_CSS );
}

/** Process the query string.
 */

--


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: jk2 new shmem using APR

[Glenn Nielsen]

On Tue, Mar 16, 2004 at 02:48:26PM -, [EMAIL PROTECTED] wrote:
> > Greg,
> As an aside our team will be looking at apache2 and tomcat5 sooner rather
> than later as it would appear that more development effort is taking place
> on these platforms.  However balancing lots of apps and infrastructure
> upgrades and testing with day to day support means this will not happen
> soon.

I went through the process of upgrading our servers to Apache2 over
the last 9 months. These are Sun servers running Solaris and using
the Apache 2 worker MPM.  There are alot of advantages to upgrading.
My testing found Apache 2 to require a great deal fewer system resources
(CPU,memory) when using the worker MPM and be much more scaleable.
I also like the way filters work. You can now have Tomcat generate HTML
with SSI which mod_include can then parse. This can help scaling for
Tomcat.  We use it with Tomcat4 and mod_jk 1.2.5, both are working very
reliably for us.

I did run into a number of problems at first. Most of them were
Solaris specific.  And some bugs which caused problems. I ended
up learning a whole lot more about apache internals than I really
wanted to, and even submitted a number of patches which got rolled
into later releases.

All in all it is working pretty well for us but we still get some
core dumps once in a while, nothing that causes apache to completely
fail though. We do have one nasty bug we hope the 2.0.49 release will
fix.  That is a runaway apache process which consumes all memory on
the server.  That was pretty nasty until we used ulimit on solaris
to limit the size of the data and virtual memory segments for apache
processes. Now the infrequent times this bug is triggered the apache
process core dumps when it hits these memory limits rather than 
causing general failures on the server due to exhausing all physical
and virtual memory.

The biggest effort had to be put into making sure all the third
party apache modules we use were thread safe. This included patches
to mod_jk 1.2 to fix a few thread safe problems. The mod_jk 1.2.5
includes all these patches.

All in all it was worth the effort, 9 months later it should be
easier for someone with a similar environment to mine to upgrade
to apache 2.

Regards,

Glenn

--
Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder|
MOREnet System Programming   |  * if iz ina coment.  |
Missouri Research and Education Network  |  */   |
--

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

PATCH jk_shm.c Cosmetic only.

[NormW]

Greetings All.
The following links to a 'patch' primarily intended to remove some
'comments' I had put in my previous patch to Guenter but hadn't noticed were
also included in the diff he prepared. Cosmetic tidy up only.
http://www.gknw.com/norm/jk_shm.c.diff
Note this _is_ a different file to yesterdays.
-
--- jk_shm.c.orig Tue Mar 16 22:19:21 2004
+++ jk_shm.c Wed Mar 17 07:40:54 2004
@@ -463,17 +463,15 @@

 result->setAttribute = jk2_shm_setAttribute;
 result->setAttributeInfo = jk2_shm_setAttributeInfo;
-/* Add the following to this function - seems someone else */
-/* thought of it based on the 'comment' previously there */
 result->getAttributeInfo = jk2_shm_getAttributeInfo;
 result->getAttribute = jk2_shm_getAttribute;
 result->multiValueInfo = NULL;
 shm->mbean = result;
 result->object = shm;
 result->invoke=jk2_shm_invoke;
+
 shm->init = jk2_shm_init;
 shm->destroy = jk2_shm_destroy;
-
 shm->getSlot = jk2_shm_getSlot;
 shm->createSlot = jk2_shm_createSlot;
 shm->reset = jk2_shm_reset;
--


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27664] - Welcome files not found in combination with jsp-property-group

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27664

Welcome files not found in combination with jsp-property-group

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-03-17 00:16 ---
Fixed (I'll let the community decide if they want to go with this fix).

Notice that in your example, /notwelcome/index.html will be interpreted as a
JSP, as it matches the url-pattern of the jsp-property-group.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

[markt]

markt   2004/03/16 16:11:30

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
  Log:
  Fix bug 14228
  - Load on startup servlets should be loaded after AFTER_START_EVENT
(where environment entries are created).
  
  Revision  ChangesPath
  1.119 +8 -6  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.118
  retrieving revision 1.119
  diff -u -r1.118 -r1.119
  --- StandardContext.java  16 Mar 2004 22:18:35 -  1.118
  +++ StandardContext.java  17 Mar 2004 00:11:30 -  1.119
  @@ -4252,11 +4252,6 @@
   }
   }
   
  -// Load and initialize all "load on startup" servlets
  -if (ok) {
  -loadOnStartup(findChildren());
  -}
  -
   // Unbinding thread
   unbindThread(oldCCL);
   
  @@ -4291,6 +4286,13 @@
   new Notification("j2ee.state.running", this.getObjectName(), 
   sequenceNumber++);
   broadcaster.sendNotification(notification);
  +}
  +
  +// Load and initialize all "load on startup" servlets
  +if (ok) {
  +oldCCL = bindThread();
  +loadOnStartup(findChildren());
  +unbindThread(oldCCL);
   }
   
   // Close all JARs right away to avoid always opening a peak number 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs jasper-howto.xml

[markt]

markt   2004/03/16 16:09:22

  Modified:webapps/docs jasper-howto.xml
  Log:
  Remove reference to unsupported largefile option.
  
  Revision  ChangesPath
  1.13  +0 -4  jakarta-tomcat-catalina/webapps/docs/jasper-howto.xml
  
  Index: jasper-howto.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/jasper-howto.xml,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- jasper-howto.xml  19 Dec 2003 18:58:51 -  1.12
  +++ jasper-howto.xml  17 Mar 2004 00:09:22 -  1.13
  @@ -108,10 +108,6 @@
   code for each page instead of deleting it? true or
   false, default true.
   
  -largefile - Should we store the static content of JSP
  -pages in external data files, to reduce the size of the generated servlets?
  -true or false, default false.
  -
   mappedfile - Should we generate static content with one 
   print statement per input line, to ease debugging?
   true or false, default true.
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 14228] - Environment entries inaccessible to servlet init()

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14228

Environment  entries inaccessible to servlet init()

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-03-17 00:06 ---
I have now fixed this in TC4 and ported the fix to TC5.

Many thanks for reporting this bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 13833] - Webapp install/start failures not reported by Deployer install operation

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=13833

Webapp install/start failures not reported by Deployer install operation

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-03-17 00:01 ---
I have fixed this in TC4. Thanks for reporting this.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardContext.java

[markt]

markt   2004/03/16 16:00:21

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
  Log:
  Fix bug 13833
  - StandardContext.Start() should throw an exception if it fails.
  Fix bug 14228
  - Load on startup servlets should be loaded after AFTER_START_EVENT
(where environment entries are created).
  
  Revision  ChangesPath
  1.124 +9 -8  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.123
  retrieving revision 1.124
  diff -u -r1.123 -r1.124
  --- StandardContext.java  16 Mar 2004 23:23:33 -  1.123
  +++ StandardContext.java  17 Mar 2004 00:00:21 -  1.124
  @@ -3606,10 +3606,6 @@
   ok = false;
   }
   
  -// Load and initialize all "load on startup" servlets
  -if (ok)
  -loadOnStartup(findChildren());
  -
   // Unbinding thread
   unbindThread(oldCCL);
   
  @@ -3626,11 +3622,16 @@
   log(sm.getString("standardContext.startCleanup"), t);
   }
   setAvailable(false);
  +throw new 
LifecycleException(sm.getString("standardContext.startFailed"));
   }
   
   // Notify our interested LifecycleListeners
   lifecycle.fireLifecycleEvent(AFTER_START_EVENT, null);
   
  +// Load and initialize all "load on startup" servlets
  +oldCCL = bindThread();
  +loadOnStartup(findChildren());
  +unbindThread(oldCCL);
   }
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper Mapper.java MappingData.java

[Bill Barker]

- Original Message -
From: "Remy Maucherat" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Tuesday, March 16, 2004 2:13 PM
Subject: Re: cvs commit:
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper
Mapper.java MappingData.java


Bill Barker wrote:
>> Since from section 3.3 of the JSP spec, jsp-property-groups are
translation
>> time mappings, the only "clean" solution I can see would be to implement
>> something like the TC 3.3 JspInterceptor (obviously, changed to a
JspValve
>> :) that would handle the pre-compilation checks with the required
>> jsp-property-group applied.  This would still be bending the spec a bit,
but
>> not as much as this patch does.
>
> Jan's solution seems unfortunately the least worst (my favorite by far
> is to not fix anything): the problem is that with TC > 4 (I know, this
> sucks), the valve will not be invoked for request dispatching :(
>

Point taken.  One other possibility would be to go the whole route to
JspInterceptor, and have a JspListener (which is much more like how
JspInterceptor is implemented, than like JspValve).  This would listen for a
(new) MAPPING_EVENT to handle the translation phase of the JSP if necessary.

Of course, the best solution would be for the JSR-152 expert group to issue
an Errata clearing this up :).

> So, patatras, it becomes much slower and much more complex (the valve
> has access to the lower level stuff, while the RD does not). I suppose a
> filter-like algorithm wouldn't be too bad (works on Strings without GC),
> but it's another mapping operation and additional complexity (I believe
> the mapping rules have subtle differences :) ).
>
> :( :( :(
>
> I suppose it's when implementing specs completely that you uncover
> issues, and this is quite bad :(
>
> Rémy
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18079] - Documentation error: configuration of resource caching (BaseDirContext).

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=18079

Documentation error: configuration of resource caching (BaseDirContext).

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 23:43 ---
This has been fixed in TC4.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-4.0/webapps/tomcat-docs/config context.xml resources.xml

[markt]

markt   2004/03/16 15:23:33

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
   webapps/tomcat-docs/config context.xml resources.xml
  Log:
  Fix bug 18079.
  - Modify StandardContext so cached attribute of resources has an effect
  - Update docs to reflect changes
  - Remove unused imports highlighted by Eclipse
  - Reported by 'gawix'
  
  Revision  ChangesPath
  1.123 +8 -25 
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.122
  retrieving revision 1.123
  diff -u -r1.122 -r1.123
  --- StandardContext.java  27 Dec 2003 20:37:58 -  1.122
  +++ StandardContext.java  16 Mar 2004 23:23:33 -  1.123
  @@ -69,35 +69,18 @@
   import java.io.IOException;
   import java.util.ArrayList;
   import java.util.HashMap;
  -import java.net.URL;
   import java.util.Iterator;
   import java.util.TreeMap;
   import java.util.Hashtable;
   import java.util.Stack;
  -import java.util.Enumeration;
  -import java.util.StringTokenizer;
   import javax.servlet.FilterConfig;
   import javax.servlet.ServletContext;
   import javax.servlet.ServletContextEvent;
   import javax.servlet.ServletContextListener;
   import javax.servlet.ServletException;
  -import javax.servlet.http.HttpServletRequest;
  -import javax.servlet.http.HttpServletResponse;
   import javax.naming.NamingException;
  -import javax.naming.InitialContext;
  -import javax.naming.Reference;
  -import javax.naming.StringRefAddr;
  -import javax.naming.NamingEnumeration;
  -import javax.naming.Binding;
  -import javax.naming.StringRefAddr;
   import javax.naming.directory.DirContext;
  -import org.apache.naming.NamingContext;
   import org.apache.naming.ContextBindings;
  -import org.apache.naming.ContextAccessController;
  -import org.apache.naming.EjbRef;
  -import org.apache.naming.ResourceRef;
  -import org.apache.naming.ResourceEnvRef;
  -import org.apache.naming.TransactionRef;
   import org.apache.naming.resources.BaseDirContext;
   import org.apache.naming.resources.FileDirContext;
   import org.apache.naming.resources.ProxyDirContext;
  @@ -106,10 +89,8 @@
   import org.apache.catalina.Container;
   import org.apache.catalina.ContainerListener;
   import org.apache.catalina.Context;
  -import org.apache.catalina.Engine;
   import org.apache.catalina.Host;
   import org.apache.catalina.Globals;
  -import org.apache.catalina.HttpRequest;
   import org.apache.catalina.InstanceListener;
   import org.apache.catalina.Lifecycle;
   import org.apache.catalina.LifecycleEvent;
  @@ -134,7 +115,6 @@
   import org.apache.catalina.deploy.ResourceParams;
   import org.apache.catalina.deploy.SecurityCollection;
   import org.apache.catalina.deploy.SecurityConstraint;
  -import org.apache.catalina.loader.StandardClassLoader;
   import org.apache.catalina.loader.WebappLoader;
   import org.apache.catalina.session.StandardManager;
   import org.apache.catalina.util.CharsetMapper;
  @@ -1168,7 +1148,10 @@
   return;
   
   if (resources instanceof BaseDirContext) {
  -((BaseDirContext) resources).setCached(isCachingAllowed());
  +((BaseDirContext) resources).setCached(
  +isCachingAllowed() &&
  +((BaseDirContext) resources).isCached()
  +);
   }
   if (resources instanceof FileDirContext) {
   filesystemBased = true;
  
  
  
  1.13  +7 -0  jakarta-tomcat-4.0/webapps/tomcat-docs/config/context.xml
  
  Index: context.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/tomcat-docs/config/context.xml,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- context.xml   12 Jan 2003 17:26:48 -  1.12
  +++ context.xml   16 Mar 2004 23:23:33 -  1.13
  @@ -169,6 +169,13 @@
   
   
   
  +  
  +This boolean flag indicates if the resources may be cached. It
  +defaults to true. If set to false, this
  +flag overrides the cached attribute of any contained
  +Resources
 element.
  +  
  +
 
   The level of debugging detail logged by this Engine
   to the associated Logger.  Higher numbers
  
  
  
  1.3   +3 -1  jakarta-tomcat-4.0/webapps/tomcat-docs/config/resources.xml
  
  Index: resources.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/tomcat-docs/config/resources.xml,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- resources.xml 12 Jan 2003 17:26:48 -  1.2

cvs commit: jakarta-tomcat-4.0/webapps/tomcat-docs jasper-howto.xml

[markt]

markt   2004/03/16 14:51:17

  Modified:webapps/tomcat-docs jasper-howto.xml
  Log:
  Remove reference to unsupported largefile option.
  
  Revision  ChangesPath
  1.10  +0 -4  jakarta-tomcat-4.0/webapps/tomcat-docs/jasper-howto.xml
  
  Index: jasper-howto.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/tomcat-docs/jasper-howto.xml,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- jasper-howto.xml  12 Mar 2003 09:51:48 -  1.9
  +++ jasper-howto.xml  16 Mar 2004 22:51:17 -  1.10
  @@ -126,10 +126,6 @@
   code for each page instead of deleting it? true or
   false, default true.
   
  -largefile - Should we store the static content of JSP
  -pages in external data files, to reduce the size of the generated servlets?
  -true or false, default false.
  -
   logVerbosityLevel - The level of detailed messages to be
   produced by this servlet.  Increasing levels cause the generation of more
   messages.  Valid values are FATAL, ERROR, WARNING, INFORMATION,
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

[luehe]

luehe   2004/03/16 14:18:35

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
  Log:
  Fix for Bugzilla 27664 ("Welcome files not found in combination with
  jsp-property-group") [cont.]
  
  Revision  ChangesPath
  1.118 +20 -3 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.117
  retrieving revision 1.118
  diff -u -r1.117 -r1.118
  --- StandardContext.java  27 Feb 2004 14:58:42 -  1.117
  +++ StandardContext.java  16 Mar 2004 22:18:35 -  1.118
  @@ -1939,7 +1939,7 @@
   }
   
   if( findChild(servletName) != null) {
  -addServletMapping(pattern, servletName);
  +addServletMapping(pattern, servletName, true);
   } else {
   log.debug("Skiping " + pattern + " , no servlet " + servletName);
   }
  @@ -2130,7 +2130,24 @@
*  is not known to this Context
*/
   public void addServletMapping(String pattern, String name) {
  +addServletMapping(pattern, name, false);
  +}
  +
   
  +/**
  + * Add a new servlet mapping, replacing any existing mapping for
  + * the specified pattern.
  + *
  + * @param pattern URL pattern to be mapped
  + * @param name Name of the corresponding servlet to execute
  + * @param jspWildCard true if name identifies the JspServlet
  + * and pattern contains a wildcard; false otherwise
  + *
  + * @exception IllegalArgumentException if the specified servlet name
  + *  is not known to this Context
  + */
  +public void addServletMapping(String pattern, String name,
  +  boolean jspWildCard) {
   // Validate the proposed mapping
   if (findChild(name) == null)
   throw new IllegalArgumentException
  @@ -2155,7 +2172,7 @@
   wrapper.addMapping(pattern);
   
   // Update context mapper
  -mapper.addWrapper(pattern, wrapper);
  +mapper.addWrapper(pattern, wrapper, jspWildCard);
   
   fireContainerEvent("addServletMapping", pattern);
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper Mapper.java

[luehe]

luehe   2004/03/16 14:18:13

  Modified:util/java/org/apache/tomcat/util/http/mapper Mapper.java
  Log:
  Fix for Bugzilla 27664 ("Welcome files not found in combination with
  jsp-property-group") [cont.]
  
  Revision  ChangesPath
  1.36  +7 -2  
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java
  
  Index: Mapper.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java,v
  retrieving revision 1.35
  retrieving revision 1.36
  diff -u -r1.35 -r1.36
  --- Mapper.java   16 Mar 2004 19:24:59 -  1.35
  +++ Mapper.java   16 Mar 2004 22:18:13 -  1.36
  @@ -307,6 +307,11 @@
   }
   
   
  +public void addWrapper(String path, Object wrapper, boolean jspWildCard) {
  +addWrapper(context, path, wrapper, jspWildCard);
  +}
  +
  +
   protected void addWrapper(Context context, String path, Object wrapper) {
   addWrapper(context, path, wrapper, false);
   }
  @@ -318,8 +323,8 @@
* @param context The context to which to add the wrapper
* @param path Wrapper mapping
* @param wrapper The Wrapper object
  - * @param jspWildCard true if the wrapper corresponds to the JspServlet, 
  - * and the mapping path contains a wildcard
  + * @param jspWildCard true if the wrapper corresponds to the JspServlet
  + * and the mapping path contains a wildcard; false otherwise
*/
   protected void addWrapper(Context context, String path, Object wrapper,
 boolean jspWildCard) {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27723] New: - jk_logger_file.c fails to build on Alpha. jk2_logger_file_jkVLog uses 'args' incorrectly?

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27723

jk_logger_file.c fails to build on Alpha. jk2_logger_file_jkVLog uses 'args' 
incorrectly?

   Summary: jk_logger_file.c fails to build on Alpha.
jk2_logger_file_jkVLog uses 'args' incorrectly?
   Product: Tomcat 4
   Version: Unknown
  Platform: Alpha
   URL: http://groups.google.com/groups?q=tomcat+%22wrong+type+a
rgument+to+unary%22&selm=2262dffc.0403041012.2635895c%40
posting.google.com&rnum=1
OS/Version: Other
Status: NEW
  Severity: Major
  Priority: Other
 Component: Connector:Coyote JK 2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


(This is with JK2 2.0.2 -- jakarta-tomcat-connectors-jk2-2.0.2-src)

The connector fails to compile at the file "jk_logger_file.c", due to a problem
with the jk2_logger_file_jkVLog function.

Here is a log of my build commands:

==
./configure --with-apxs2=/path/to/apache/bin/apxs --with-java-home=/path/to/jdk131
(... SNIP ...)

make
(... SNIP ...)

gcc -g -O2 -DOSF1 -I../../include -I/tmp/workdir/apache/incl
ude -I /tmp/workdir/java131/include -I /tmp/workdir/java131/include/alpha
-DCHUNK_SIZE=4096 -DUSE_APACHE_MD5 -DHAS_APR -
c ../../common/jk_logger_file.c  -DPIC -o ../../../build/jk2/apache2/.libs/jk_lo
gger_file.lo
../../common/jk_logger_file.c: In function `jk2_logger_file_jkVLog':
../../common/jk_logger_file.c:247: wrong type argument to unary exclamation mark
==

In jk_logger_file.c , the relevant code from lines 233 - 247 is this:

static int JK_METHOD jk2_logger_file_jkVLog(jk_env_t *env, jk_logger_t *l,
  const char *file,
  int line,
  int level,
  const char *fmt,
  va_list args)
{
int rc = 0;
char *buf;
char *fmt1;
apr_pool_t *aprPool=env->tmpPool->_private;
char rfctime[APR_RFC822_DATE_LEN];
apr_time_t time = apr_time_now();

if( !file || !args) {
return -1;
}

==

It looks like '!' and 'args' are incompatable data types.

At least one other person  has run into this error. Some other people replied
with their analysis that 'args' is the wring data type.

http://groups.google.com/groups?q=tomcat+%22wrong+type+argument+to+unary%22&selm=2262dffc.0403041012.2635895c%40posting.google.com&rnum=1

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper Mapper.java MappingData.java

[Remy Maucherat]

Bill Barker wrote:
Since from section 3.3 of the JSP spec, jsp-property-groups are translation
time mappings, the only "clean" solution I can see would be to implement
something like the TC 3.3 JspInterceptor (obviously, changed to a JspValve
:) that would handle the pre-compilation checks with the required
jsp-property-group applied.  This would still be bending the spec a bit, but
not as much as this patch does.
Jan's solution seems unfortunately the least worst (my favorite by far 
is to not fix anything): the problem is that with TC > 4 (I know, this 
sucks), the valve will not be invoked for request dispatching :(

So, patatras, it becomes much slower and much more complex (the valve 
has access to the lower level stuff, while the RD does not). I suppose a 
filter-like algorithm wouldn't be too bad (works on Strings without GC), 
but it's another mapping operation and additional complexity (I believe 
the mapping rules have subtle differences :) ).

:( :( :(

I suppose it's when implementing specs completely that you uncover 
issues, and this is quite bad :(

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper Mapper.java MappingData.java

[Bill Barker]

- Original Message -
From: "Remy Maucherat" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Tuesday, March 16, 2004 12:47 PM
Subject: Re: cvs commit:
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper
Mapper.java MappingData.java


Remy Maucherat wrote:
>> [EMAIL PROTECTED] wrote:
>>
>>> luehe   2004/03/16 11:24:59
>>>
>>>  Modified:util/java/org/apache/tomcat/util/http/mapper Mapper.java
>>> MappingData.java
>>>   Log:
>>>   Fix for Bugzilla 27664 ("Welcome files not found in combination with
>>>   jsp-property-group")
>>> Rather than having the JspServlet know about welcome files, the
>>> mapper
>>>   algorithm has been amended to search for welcome files in URI spaces
>>>   that match a url-pattern in a jsp-property-group.
>>> Please review carefully and let me know what you think.
>>
>>
>> Obviously I hate it.
>> Since when the mapper must have JSP stuff in it ?

My opinion is much like Remy's here.

>>
>> It just shows the specification is broken.
>
> And to think you're likely going to do something even uglier to fix
> "bug" 27704.
> I can't wait ;)
>
> Seriously: the specification needs to be fixed, as I do not plan to
> integrate these changes in any release.
>
> I thought about something a little bit cleaner to address the "bugs". I
> think you need to remove the extra servlet mappings for the JSP servlets
> jsp-property-group. Then add something to the context valve (calling a
> utility class to do the "mapping" = change the servlet from the default
> servlet or other to the JSP servlet if it matches a jsp-property-group;
> the algorithms are very similar to filter mapping). Unfortunately, the
> request dispatcher will also have to call this utility class :( This
> adds a significant amount of complexity in the servlet layer ...
>

Since from section 3.3 of the JSP spec, jsp-property-groups are translation
time mappings, the only "clean" solution I can see would be to implement
something like the TC 3.3 JspInterceptor (obviously, changed to a JspValve
:) that would handle the pre-compilation checks with the required
jsp-property-group applied.  This would still be bending the spec a bit, but
not as much as this patch does.

> I can suggest sensible erratas to the specification if you need them.
>
> Rémy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 12363] - StandardSession.setAttribute() does not conform to the servlet spec

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=12363

StandardSession.setAttribute() does not conform to the servlet spec

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 21:29 ---
We conform with the specification. valueUnbound is to notify the attribute value
object that it is removed. It is not to notify that the attribute is removed
from the session (you have regular session attribute listeners for that). This
is why the order is irrelevant. Please do not reopen this report.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [Fwd: Releasing JK 2.0.4]

[NormW]

Darn.
I was hoping to prove I needed a rest.
Norm

- Original Message - 
From: "Mladen Turk" <[EMAIL PROTECTED]>
To: "'Tomcat Developers List'" <[EMAIL PROTECTED]>
Sent: Wednesday, March 17, 2004 8:09 AM
Subject: RE: [Fwd: Releasing JK 2.0.4]


> 
> 
> > -Original Message-
> > From: NormW
> > 
> > I want to also echo Guenter's thanks to the committers, less 
> > for adopting the suggestions offered but for taking the time 
> > to look at and (hopefully) consider them. I suspect all have 
> > other commitments beyond Mod_Jk2 and suggestions generally 
> > tendered asynchronously with their available time.
> > 
> 
> The time (and stress) is always a problem.
> I have a simple stress test available at:
> 
> http://www.apache.org/~mturk/stress.html
> 
> Hope you've passed :-).
> 
> > Yes, there are things I think still need attention, but a lot 
> > of people are 'waiting' on 2.0.4, and NetWare is but a 
> > newcomer to the Mod_Jk2 house so can bide its time for 2.0.5.
> > 
> 
> Yes, it's been quite a while since the last release.
> 
> MT.
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 12363] - StandardSession.setAttribute() does not conform to the servlet spec

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=12363

StandardSession.setAttribute() does not conform to the servlet spec

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 21:20 ---
I think the right interpretation of the spec is the following:

1. get old attribute from context
2. remove old attribute from context
3. call valueUnbound() on old attribute
4. call valueBound() on new attribute
5. add the new attribute to the context

The way it is done now it calls valueUnbound() on the attribute after it is made
available through the context if you just rebind it - I highly doubt anybody
ever desired that.

The spec does say that step 3 should be executed after step 1 and 2; it also
says  that step 5 should be executed after 4. It never says that you should deal
with the old object after you finish with the new one. 

Here's what the spec says:

...
Some objects may require notification when they are placed into, or removed
from, a session. This information can be obtained by having the object implement
the HttpSessionBindingListener interface. This interface defines the following
methods that will signal an object being bound into, or being unbound from, a
session.
• valueBound
• valueUnbound
The valueBound method must be called before the object is made available via
the getAttribute method of the HttpSession interface. The valueUnbound
method must be called after the object is no longer available via the getAttribute
method of the HttpSession interface.
...
setAttribute(String, Object)
public void setAttribute(java.lang.String name,
java.lang.Object value)
Binds an object to this session, using the name specified. If an object of the
same name is already bound to the session, the object is replaced.
After this method executes, and if the new object implements HttpSession-
BindingListener, the container calls HttpSessionBinding-
Listener.valueBound. The container then notifies any
HttpSessionAttributeListeners in the web application.

If an object was already bound to this session of this name that implements
HttpSessionBindingListener, its HttpSessionBindingListener.value-
Unbound method is called.
If the value passed in is null, this has the same effect as calling remove-
Attribute().
...

Again, the spec does mention the old object after it mentions the new one but it
does not say it should only handle it after finishing with the new one. In fact,
you could argue that if an object is just rebound you should not call
valueUnbound() at all, after all, it was never unbound.

What happens now is that when Struts rebinds our session formbean the last
action performed on the bean is valueUnbound(). So after a successfull login our
session bean is told to mop up and go away. Needless to say you can no longer
use the application.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27694] - port 8080 is not responding

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27694

port 8080 is not responding

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 21:19 ---
This looks like a configuration problem to me. Please follow up on the tomcat-
user mailing list.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [Fwd: Releasing JK 2.0.4]

[Mladen Turk]

 

> -Original Message-
> From: NormW
> 
> I want to also echo Guenter's thanks to the committers, less 
> for adopting the suggestions offered but for taking the time 
> to look at and (hopefully) consider them. I suspect all have 
> other commitments beyond Mod_Jk2 and suggestions generally 
> tendered asynchronously with their available time.
> 

The time (and stress) is always a problem.
I have a simple stress test available at:

http://www.apache.org/~mturk/stress.html

Hope you've passed :-).

> Yes, there are things I think still need attention, but a lot 
> of people are 'waiting' on 2.0.4, and NetWare is but a 
> newcomer to the Mod_Jk2 house so can bide its time for 2.0.5.
> 

Yes, it's been quite a while since the last release.

MT.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 13805] - Code and HOW-TO disagrees about "shared" classes.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=13805

Code and HOW-TO disagrees about "shared" classes.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 20:56 ---
*** Bug 27710 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27710] - Classloader documentation incorrect

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27710

Classloader documentation incorrect

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 20:56 ---


*** This bug has been marked as a duplicate of 13805 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper Mapper.java MappingData.java

[Remy Maucherat]

Remy Maucherat wrote:
[EMAIL PROTECTED] wrote:

luehe   2004/03/16 11:24:59

  Modified:util/java/org/apache/tomcat/util/http/mapper Mapper.java
MappingData.java
  Log:
  Fix for Bugzilla 27664 ("Welcome files not found in combination with
  jsp-property-group")
Rather than having the JspServlet know about welcome files, the 
mapper
  algorithm has been amended to search for welcome files in URI spaces
  that match a url-pattern in a jsp-property-group.
Please review carefully and let me know what you think.


Obviously I hate it.
Since when the mapper must have JSP stuff in it ?
It just shows the specification is broken.
And to think you're likely going to do something even uglier to fix 
"bug" 27704.
I can't wait ;)

Seriously: the specification needs to be fixed, as I do not plan to 
integrate these changes in any release.

I thought about something a little bit cleaner to address the "bugs". I 
think you need to remove the extra servlet mappings for the JSP servlets 
jsp-property-group. Then add something to the context valve (calling a 
utility class to do the "mapping" = change the servlet from the default 
servlet or other to the JSP servlet if it matches a jsp-property-group; 
the algorithms are very similar to filter mapping). Unfortunately, the 
request dispatcher will also have to call this utility class :( This 
adds a significant amount of complexity in the servlet layer ...

I can suggest sensible erratas to the specification if you need them.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [Fwd: Releasing JK 2.0.4]

[NormW]

Greetings All!
What?! Me? Complain? The only thing that gets me excited in an 'open' forum
is being ignored, as if I didn't exist.

I want to also echo Guenter's thanks to the committers, less for adopting
the suggestions offered but for taking the time to look at and (hopefully)
consider them. I suspect all have other commitments beyond Mod_Jk2 and
suggestions generally tendered asynchronously with their available time.

Yes, there are things I think still need attention, but a lot of people are
'waiting' on 2.0.4, and NetWare is but a newcomer to the Mod_Jk2 house so
can bide its time for 2.0.5.

Norm


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper Mapper.java MappingData.java

[Remy Maucherat]

[EMAIL PROTECTED] wrote:

luehe   2004/03/16 11:24:59

  Modified:util/java/org/apache/tomcat/util/http/mapper Mapper.java
MappingData.java
  Log:
  Fix for Bugzilla 27664 ("Welcome files not found in combination with
  jsp-property-group")
  
  Rather than having the JspServlet know about welcome files, the mapper
  algorithm has been amended to search for welcome files in URI spaces
  that match a url-pattern in a jsp-property-group.
  
  Please review carefully and let me know what you think.
Obviously I hate it.
Since when the mapper must have JSP stuff in it ?
It just shows the specification is broken.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [Fwd: Releasing JK 2.0.4]

[Mladen Turk]

 
> -Original Message-
> From: [EMAIL PROTECTED]
> 
> > > 2004] (error ) [jk_shm.c (102)]  shm.create(): error 
> creating shm 22 
> > > Invalid argument
> > 
> > This is very interesting error (Invalid argument), can you 
> enlight me 
> > with the server setings like what is the maxchilds number.
> 
> MinSpareServers 24
> MaxSpareServers 100
> StartServers 75
> MaxClients 200
> MaxRequestsPerChild 5000
> 
> ok.  Now set to:
> 
> [shm]
> file=anonymous
> slots=75
> debug=10
> 
> Should slots be startservers or maxclients?
> 


To MaxClients (maximum number of servers that will ever be able to start).
In your case 200.


> Out of interest where is the file now?
> 

I hope it's in the kernel :-)

> > 
> > Could you turn the LogLevel debug and post the errorl.log here.
> > It would be very helpful.
> > 
> > there should be line like:
> > [debug] jk_shm.c(166): shm.init(): file=anonymous size=2162688
> 
> Nothing in jk2.log
>

Set also the
[logger]
level=DEBUG
 
to actually turn the jk2 debuging on.

MT.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [Fwd: Releasing JK 2.0.4]

[Greg . Cope]

> > Turk,
> > 
> 
> The name is Mladen :-).

Very sorry.

> That's actualy good, we are getting somewhere :).

:-)

> > 2004] (error ) [jk_shm.c (102)]  shm.create(): error creating 
> > shm 22 Invalid argument
> 
> This is very interesting error (Invalid argument), can you 
> enlight me with
> the server setings like what is the maxchilds number.

MinSpareServers 24
MaxSpareServers 100
StartServers 75
MaxClients 200
MaxRequestsPerChild 5000

> Also,
> In the workers2.properties try to set
> [shm:]
> file=anonymous
> slots=xxx (where xxx is the number of forked child processes)
> debug=10

ok.  Now set to:

[shm]
#debug=100
#file=/var/tmp/cr.sandwich.pfizer.com_81.shm
#size=1048576

file=anonymous
slots=75
debug=10

Should slots be startservers or maxclients?

Out of interest where is the file now?

> Instead of the current shm file, and see if it works.
> 
> > 
> > Again I have not had time to look into this.
> >
> 
> Could you turn the LogLevel debug and post the errorl.log here.
> It would be very helpful.
> 
> there should be line like:
> [debug] jk_shm.c(166): shm.init(): file=anonymous size=2162688

Nothing in jk2.log

Interesting this is the error.log

[Tue Mar 16 20:03:00 2004] ( info ) [mod_jk2.c (412)]  mod_jk child init
[Tue Mar 16 20:03:00 2004] ( info ) [mod_jk2.c (420)]  mod_jk.post_config()
init worker env
[Tue Mar 16 20:03:01 2004] [warn] module mod_ntauth.c is already added,
skipping
[Tue Mar 16 20:03:01 2004] ( info ) [mod_jk2.c (321)]  Set serverRoot
/WWW/servers/apache/1.3.26c/cr.sandwich.pfizer.com_81
Apache() loaded, lib directory added
[Tue Mar 16 20:03:04 2004] ( info ) [mod_jk2.c (412)]  mod_jk child init
[Tue Mar 16 20:03:04 2004] ( info ) [mod_jk2.c (420)]  mod_jk.post_config()
init worker env
[Tue Mar 16 20:03:05 2004] [notice] Apache/1.3.26 (Unix) mod_jk2/2.0.4-dev
mod_perl/1.27 configured -- resuming normal operations
[Tue Mar 16 20:03:05 2004] [notice] suEXEC mechanism enabled (wrapper:
/WWW/app/apache/1.3.26c/bin/suexec)
[Tue Mar 16 20:03:05 2004] [info] Server built: Aug 20 2002 18:03:13
[Tue Mar 16 20:03:05 2004] [notice] Accept mutex: fcntl (Default: fcntl)


Greg

Ps I am off home now!

> 
> 
> MT.
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [Fwd: Releasing JK 2.0.4]

[Mladen Turk]

 

> -Original Message-
> From: [EMAIL PROTECTED]
> > 
> 
> Turk,
> 

The name is Mladen :-).


> Different errors, but still does not work:
> 

That's actualy good, we are getting somewhere :).

> 2004] (error ) [jk_shm.c (102)]  shm.create(): error creating 
> shm 22 Invalid argument

This is very interesting error (Invalid argument), can you enlight me with
the server setings like what is the maxchilds number.

Also,
In the workers2.properties try to set
[shm:]
file=anonymous
slots=xxx (where xxx is the number of forked child processes)
debug=10

Instead of the current shm file, and see if it works.

> 
> Again I have not had time to look into this.
>

Could you turn the LogLevel debug and post the errorl.log here.
It would be very helpful.

there should be line like:
[debug] jk_shm.c(166): shm.init(): file=anonymous size=2162688


MT.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: StandardClassLoader

[Simon Raess]

Am 16.03.2004 um 20:34 schrieb Shapira, Yoav:

Hi,

Is there some documentation (besides the javadoc) that describes
StandardClassLoader? Does it follow the standard delegation model or
does it query its local repository first?
There's the loader documentation page,
http://jakarta.apache.org/tomcat/tomcat-5.0-doc/config/loader.html,
which talks a bit about delegation.
Your question (to which the answer is delegating is false by default)  
is
not hard to discern from the source code of StandardClassLoader:
http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-catalina/catalina/ 
src/s
hare/org/apache/catalina/loader/StandardClassLoader.java? 
rev=1.8&view=ma
rkup
that's the way to go ;-)

Then there's the classloader how-to which gives more information:
http://jakarta.apache.org/tomcat/tomcat-5.0-doc/class-loader-howto.html
These questions so far belong on tomcat-user, not tomcat-dev.
Well, the question was actually about using StandardClassLoader in  
another project, so I thought I post in tomcat-dev because it has  
nothing to do with 'using' tomcat.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/coyote build.xml

[kinman]

kinman  2004/03/16 11:48:39

  Modified:coyote   build.xml
  Log:
  - Fix the build
  
  Revision  ChangesPath
  1.28  +2 -2  jakarta-tomcat-connectors/coyote/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/build.xml,v
  retrieving revision 1.27
  retrieving revision 1.28
  diff -u -r1.27 -r1.28
  --- build.xml 10 Mar 2004 22:35:10 -  1.27
  +++ build.xml 16 Mar 2004 19:48:38 -  1.28
  @@ -228,7 +228,7 @@
   
 
   
  -  
  +  
   

RE: StandardClassLoader

[Shapira, Yoav]

Hi,

>Is there some documentation (besides the javadoc) that describes
>StandardClassLoader? Does it follow the standard delegation model or
>does it query its local repository first?

There's the loader documentation page,
http://jakarta.apache.org/tomcat/tomcat-5.0-doc/config/loader.html,
which talks a bit about delegation.

Your question (to which the answer is delegating is false by default) is
not hard to discern from the source code of StandardClassLoader:
http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-catalina/catalina/src/s
hare/org/apache/catalina/loader/StandardClassLoader.java?rev=1.8&view=ma
rkup

Then there's the classloader how-to which gives more information:
http://jakarta.apache.org/tomcat/tomcat-5.0-doc/class-loader-howto.html

These questions so far belong on tomcat-user, not tomcat-dev.

Yoav Shapira



This e-mail, including any attachments, is a confidential business communication, and 
may contain information that is confidential, proprietary and/or privileged.  This 
e-mail is intended only for the individual(s) to whom it is addressed, and may not be 
saved, copied, printed, disclosed or used by anyone else.  If you are not the(an) 
intended recipient, please immediately delete this e-mail from your computer system 
and notify the sender.  Thank you.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 MapperListener.java

[luehe]

luehe   2004/03/16 11:25:39

  Modified:catalina/src/share/org/apache/coyote/tomcat5
MapperListener.java
  Log:
  Fix for Bugzilla 27664 ("Welcome files not found in combination with
  jsp-property-group")
  
  Rather than having the JspServlet know about welcome files, the mapper
  algorithm has been amended to search for welcome files in URI spaces
  that match a url-pattern in a jsp-property-group.
  
  Please review carefully and let me know what you think.
  
  Revision  ChangesPath
  1.19  +4 -1  
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/MapperListener.java
  
  Index: MapperListener.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/MapperListener.java,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- MapperListener.java   27 Feb 2004 14:58:53 -  1.18
  +++ MapperListener.java   16 Mar 2004 19:25:39 -  1.19
  @@ -469,7 +469,10 @@
   mBeanServer.invoke(objectName, "findMappingObject", null, null);
   
   for (int i = 0; i < mappings.length; i++) {
  -mapper.addWrapper(hostName, contextName, mappings[i], wrapper);
  +boolean jspWildCard = (wrapperName.equals("jsp")
  +   && mappings[i].endsWith("/*"));
  +mapper.addWrapper(hostName, contextName, mappings[i], wrapper,
  +  jspWildCard);
   }
   
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper Mapper.java MappingData.java

[luehe]

luehe   2004/03/16 11:24:59

  Modified:util/java/org/apache/tomcat/util/http/mapper Mapper.java
MappingData.java
  Log:
  Fix for Bugzilla 27664 ("Welcome files not found in combination with
  jsp-property-group")
  
  Rather than having the JspServlet know about welcome files, the mapper
  algorithm has been amended to search for welcome files in URI spaces
  that match a url-pattern in a jsp-property-group.
  
  Please review carefully and let me know what you think.
  
  Revision  ChangesPath
  1.35  +53 -8 
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java
  
  Index: Mapper.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper/Mapper.java,v
  retrieving revision 1.34
  retrieving revision 1.35
  diff -u -r1.34 -r1.35
  --- Mapper.java   24 Feb 2004 08:50:06 -  1.34
  +++ Mapper.java   16 Mar 2004 19:24:59 -  1.35
  @@ -267,8 +267,14 @@
* @param path Wrapper mapping
* @param wrapper Wrapper object
*/
  -public void addWrapper
  -(String hostName, String contextPath, String path, Object wrapper) {
  +public void addWrapper(String hostName, String contextPath, String path,
  +   Object wrapper) {
  +addWrapper(hostName, contextPath, path, wrapper, false);
  +}
  +
  +
  +public void addWrapper(String hostName, String contextPath, String path,
  +   Object wrapper, boolean jspWildCard) {
   Host[] hosts = this.hosts;
   int pos = find(hosts, hostName);
   if (pos < 0) {
  @@ -284,7 +290,7 @@
   }
   Context context = contexts[pos2];
   if (context.name.equals(contextPath)) {
  -addWrapper(context, path, wrapper);
  +addWrapper(context, path, wrapper, jspWildCard);
   }
   }
   }
  @@ -294,6 +300,7 @@
* Add a wrapper to the context associated with this wrapper.
*
* @param path Wrapper mapping
  + * @param wrapper The Wrapper object
*/
   public void addWrapper(String path, Object wrapper) {
   addWrapper(context, path, wrapper);
  @@ -301,9 +308,26 @@
   
   
   protected void addWrapper(Context context, String path, Object wrapper) {
  +addWrapper(context, path, wrapper, false);
  +}
  +
  +
  +/**
  + * Adds a wrapper to the given context.
  + *
  + * @param context The context to which to add the wrapper
  + * @param path Wrapper mapping
  + * @param wrapper The Wrapper object
  + * @param jspWildCard true if the wrapper corresponds to the JspServlet, 
  + * and the mapping path contains a wildcard
  + */
  +protected void addWrapper(Context context, String path, Object wrapper,
  +  boolean jspWildCard) {
  +
   synchronized (context) {
   Wrapper newWrapper = new Wrapper();
   newWrapper.object = wrapper;
  +newWrapper.jspWildCard = jspWildCard;
   if (path.endsWith("/*")) {
   // Wildcard wrapper
   newWrapper.name = path.substring(0, path.length() - 2);
  @@ -625,22 +649,42 @@
   internalMapExactWrapper(exactWrappers, path, mappingData);
   
   // Rule 2 -- Prefix Match
  +boolean checkJspWelcomeFiles = false;
   Wrapper[] wildcardWrappers = context.wildcardWrappers;
   if (mappingData.wrapper == null) {
   internalMapWildcardWrapper(wildcardWrappers, context.nesting, 
  path, mappingData);
  +if (mappingData.wrapper != null && mappingData.jspWildCard) {
  +char[] buf = path.getBuffer();
  +if (buf[pathEnd - 1] == '/') {
  +/*
  + * Path ending in '/' was mapped to JSP servlet based on
  + * wildcard match (e.g., as specified in url-pattern of a
  + * jsp-property-group.
  + * Force the context's welcome files, which are interpreted
  + * as JSP files (since they match the url-pattern), to be
  + * considered. See Bugzilla 27664.
  + */ 
  +mappingData.wrapper = null;
  +checkJspWelcomeFiles = true;
  +}
  +}
   }
   
   // Rule 3 -- Extension Match
   Wrapper[] extensionWrappers = context.extensionWrappers;
  -if (mappingData.wrapper == null) {
  +if (mappingData.wrapper == null && !checkJspWelcomeFiles) {
   internalMapExtensionWrapper(extensionWrappers, path, mappingData);
   }
   
   // Rule 4 -- Welcome resources processing fo

StandardClassLoader

[Simon Raess]

hi

Is there some documentation (besides the javadoc) that describes 
StandardClassLoader? Does it follow the standard delegation model or 
does it query its local repository first?

simon

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [Fwd: Releasing JK 2.0.4]

[Greg . Cope]

> Hi,
> 
> Seems that the shm is working now.
> Greg, have you been able to test it with the current patches?
> Anyhow IMO it should work, cause the same problem manifested 
> on FreeBSD 
> has been solved.
> 
> Henri, when do you plan to tag the release?
> 
> MT.
> 

Turk,

Different errors, but still does not work:

# rm -fr /var/tmp/cr.sandwich.pfizer.com_81.shm 
leopard# rm logs/jk2.log
leopard# ./start
[Tue Mar 16 19:04:10 2004] [warn] module mod_ntauth.c is already added,
skipping
[Tue Mar 16 19:04:10 2004] ( info ) [mod_jk2.c (321)]  Set serverRoot
/WWW/servers/apache/1.3.26c/cr.sandwich.pfizer.com_81
Apache() loaded, lib directory added
/WWW/servers/apache/1.3.26c/apachectl start: httpd started
leopard# 
leopard# tail -f logs/jk2.log
[Tue Mar 16 19:04:10 2004] (error ) [jk_shm.c (102)]  shm.create(): error
creating shm 22 Invalid argument
[Tue Mar 16 19:04:10 2004] (error ) [jk_shm.c (174)]  shm.create(): error
creating shm /var/tmp/cr.sandwich.pfizer.com_81.shm
[Tue Mar 16 19:04:14 2004] (error ) [jk_shm.c (102)]  shm.create(): error
creating shm 70014 End of file found
[Tue Mar 16 19:04:14 2004] (error ) [jk_shm.c (174)]  shm.create(): error
creating shm /var/tmp/cr.sandwich.pfizer.com_81.shm
^C
leopard# ls -la /var/tmp/cr.sandwich.pfizer.com_81.shm 
-rw-r--r--   1 root other  0 Mar 16 19:04
/var/tmp/cr.sandwich.pfizer.com_81.shm

Again I have not had time to look into this.

Greg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: cvs commit: jakarta-tomcat-connectors/jk/conf workers2.properties.minimal

[Guenter Knauf]

Hi Mladen,
>> here's what Norm has put together:
>> http://www.gknw.com/development/apache/docs/win32/mod_jk2/
>> http://www.gknw.com/development/apache/docs/netware/mod_jk2/
>> I think this is a good base.
>>

> Well, i was thinking to something like txt file (INSTALL from Apache2 for
> example),
I meant more the content, not the format; its easy to convert this to a plain text 
document.

> that has both httpd.conf and workers2.minimal in it along with either .rpm
> install instructions,
> or howto build from source.
hmm, I thought we are talking about binary dists, so building from source shouldnt be 
covered there;
IMO building from source should go into a separate document, because that's probably a 
far bigger document if we really cover building for all platforms.
My intention was to get ready within 2 minutes, that means that in the ideal case you 
only have to extract the binary archive over the Apache2 directory and put one line 
'Include conf/mod_jk2.conf' into httpd.conf, and after a restart you are already able 
to check the Tomcat samples - of course provided that TC runs on the same host.

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: cvs commit: jakarta-tomcat-connectors/jk/conf workers2.properties.minimal

[Mladen Turk]

 

> -Original Message-
> From: Guenter Knauf
> Subject: RE: cvs commit: jakarta-tomcat-connectors/jk/conf 
> workers2.properties.minimal
> 
> 
> > The INSTALL can include some except from xdocs.
> > I can make that, but would rather see some native speaker involved.
> here's what Norm has put together:
> http://www.gknw.com/development/apache/docs/win32/mod_jk2/
> http://www.gknw.com/development/apache/docs/netware/mod_jk2/
> I think this is a good base.
>

Well, i was thinking to something like txt file (INSTALL from Apache2 for
example),
that has both httpd.conf and workers2.minimal in it along with either .rpm
install instructions,
or howto build from source.
 
> 
> please take a look at this archive:
> http://www.gknw.com/development/apache/httpd-2.0/netware/modul
> es/mod_jk2-20040228232017-2.0.49-dev-nw.zip
> which is a sample of the above, and in addition uses also an 
> archive comment which is displayed when opened with WinZip.
>

Yes, something  like that.

MT. 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [Fwd: Releasing JK 2.0.4]

[Mladen Turk]

 

> -Original Message-
> From: Henri Gomez
> > 
> > Henri, when do you plan to tag the release?
> 
> Did everything is correct with SHM ?
> 

Yes, It seems it does.
Not so sure about 1.3 but it should, cause the problem was with double shm
initialization for each child, but that is fixed now.


> If Jean-Frederic, Mladen, Kurt (commiters) agreed, and if 
> Gueunter, NorW and users didn't complain, I think I could tag 
> tomorrow and prepare the 2.0.4 release
> 

Fine with me.

MT.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [PATCH] ./jk/native/isapi/isapi.dsp - remove notes.lib dependence

[Henri Gomez]

Guenter Knauf wrote:

Hi,
this patch removes wrong dependence on notes.lib from isapi.dsp.
http://www.gknw.com/test/isapi.dsp.diff

--- isapi.dsp.orig  Thu Feb 12 10:34:34 2004
+++ isapi.dsp   Tue Mar 16 14:56:58 2004
@@ -54,7 +54,7 @@
 # ADD BSC32 /nologo
 LINK32=link.exe
 # ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib /nologo /dll /machine:I386
-# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib wsock32.lib notes.lib /nologo /dll /machine:I386 /out:"Release/tomcat_redirector.dll" /libpath:"C:\notesapi\lib\mswin32"
+# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib wsock32.lib /nologo /dll /machine:I386 /out:"Release/tomcat_redirector.dll"
 
 !ELSEIF  "$(CFG)" == "isapi - Win32 Debug"
 
@@ -81,7 +81,7 @@
 # ADD BSC32 /nologo
 LINK32=link.exe
 # ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib /nologo /dll /debug /machine:I386 /pdbtype:sept
-# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib wsock32.lib notes.lib /nologo /dll /debug /machine:I386 /out:"Debug/tomcat_redirector.dll" /pdbtype:sept /libpath:"C:\notesapi\lib\mswin32"
+# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib wsock32.lib /nologo /dll /debug /machine:I386 /out:"Debug/tomcat_redirector.dll" /pdbtype:sept
 
 !ENDIF 
Commited.

PS: Guenter, take a look at the commit comment

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jk/native/isapi isapi.dsp

[hgomez]

hgomez  2004/03/16 09:14:41

  Modified:jk/native/isapi isapi.dsp
  Log:
  Remove dep on notes.lib for isapi

  

  Again provided by Guenter (which should accept a commiter status !-)
  
  Revision  ChangesPath
  1.4   +2 -2  jakarta-tomcat-connectors/jk/native/isapi/isapi.dsp
  
  Index: isapi.dsp
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/isapi/isapi.dsp,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- isapi.dsp 12 Feb 2004 09:34:34 -  1.3
  +++ isapi.dsp 16 Mar 2004 17:14:41 -  1.4
  @@ -54,7 +54,7 @@
   # ADD BSC32 /nologo
   LINK32=link.exe
   # ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib 
advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib 
/nologo /dll /machine:I386
  -# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib 
advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib 
wsock32.lib notes.lib /nologo /dll /machine:I386 /out:"Release/tomcat_redirector.dll" 
/libpath:"C:\notesapi\lib\mswin32"
  +# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib 
advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib 
wsock32.lib /nologo /dll /machine:I386 /out:"Release/tomcat_redirector.dll" 
/libpath:"C:\notesapi\lib\mswin32"
   
   !ELSEIF  "$(CFG)" == "isapi - Win32 Debug"
   
  @@ -81,7 +81,7 @@
   # ADD BSC32 /nologo
   LINK32=link.exe
   # ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib 
advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib 
/nologo /dll /debug /machine:I386 /pdbtype:sept
  -# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib 
advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib 
wsock32.lib notes.lib /nologo /dll /debug /machine:I386 
/out:"Debug/tomcat_redirector.dll" /pdbtype:sept /libpath:"C:\notesapi\lib\mswin32"
  +# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib 
advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib 
wsock32.lib /nologo /dll /debug /machine:I386 /out:"Debug/tomcat_redirector.dll" 
/pdbtype:sept /libpath:"C:\notesapi\lib\mswin32"
   
   !ENDIF 
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Hidden message

[shachor]

<>-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [Fwd: Releasing JK 2.0.4]

[Henri Gomez]

Mladen Turk wrote:

Oops, hit a wrong button so the post ended up the users list :-)

 Original Message 
Subject: Releasing JK 2.0.4
Date: Tue, 16 Mar 2004 13:36:11 +0100
From: Mladen Turk <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]


Hi,

Seems that the shm is working now.
Greg, have you been able to test it with the current patches?
Anyhow IMO it should work, cause the same problem manifested on FreeBSD 
has been solved.

Henri, when do you plan to tag the release?
Did everything is correct with SHM ?

If Jean-Frederic, Mladen, Kurt (commiters) agreed,
and if Gueunter, NorW and users didn't complain, I think
I could tag tomorrow and prepare the 2.0.4 release
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/jk/conf workers2.properties.minimal

[Henri Gomez]

Mladen Turk wrote:
 


-Original Message-
From: Guenter Knauf
Subject: Re: cvs commit: jakarta-tomcat-connectors/jk/conf 
workers2.properties.minimal

great!! That was really missing!
Guenter.


Well, not such a big deal :).

What I'd like to do is to make a JK2 distribution (perhaps even 2.0.4)
to include the README, INSTALL, and CHANGES.
Inside INSTALL can be few workers2 samples, README and CHANGES are already
in jk/native2.
The INSTALL can include some except from xdocs.
I can make that, but would rather see some native speaker involved.
That would change the distribution types from simply shiping .dll (or .so)
to creating either .zip or .tgz archives for particular platfom.
I'll do that in the release tarball, doc in html, README, CHANGES and so on.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: cvs commit: jakarta-tomcat-connectors/jk/conf workers2.properties.minimal

[Guenter Knauf]

Hi Mladen,
> Well, not such a big deal :).
but was missing...

> What I'd like to do is to make a JK2 distribution (perhaps even 2.0.4)
> to include the README, INSTALL, and CHANGES.
> Inside INSTALL can be few workers2 samples, README and CHANGES are already
> in jk/native2.
that's exactly what I already do with my binaries, just look at my site; but with 
latest I believe I had even a better idea: I have packed it in such a way that you can 
directly extract it over the Apache2 dir so that all files are already in place; my 
structure looks like:
./apache2
 /conf
  /workers2.properties.minimal
  /mod_jk2.conf
 /modules
 /mod_jk2.dll|nlm|so
 /ver-info
  /mod_jk2
  /README
  /CHANGES
  /STATUS
  /INSTALL

> The INSTALL can include some except from xdocs.
> I can make that, but would rather see some native speaker involved.
here's what Norm has put together:
http://www.gknw.com/development/apache/docs/win32/mod_jk2/
http://www.gknw.com/development/apache/docs/netware/mod_jk2/
I think this is a good base.

> That would change the distribution types from simply shiping .dll (or .so)
> to creating either .zip or .tgz archives for particular platfom.
that should be no problem since I brought that already on the table, and there was a 
common agreement.

please take a look at this archive:
http://www.gknw.com/development/apache/httpd-2.0/netware/modules/mod_jk2-20040228232017-2.0.49-dev-nw.zip
which is a sample of the above, and in addition uses also an archive comment which is 
displayed when opened with WinZip.

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27705] - HttpServletResponse.encodeURL does not work correctly with https

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27705

HttpServletResponse.encodeURL does not work correctly with https

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 16:15 ---
If the protocol, server or port are different, then the URL refers to a 
different webapp (see section 9.1 of the servlet spec).  Therefore, the URL 
should not be encoded.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 12363] - StandardSession.setAttribute() does not conform to the servlet spec

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=12363

StandardSession.setAttribute() does not conform to the servlet spec

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 16:01 ---
Well, that's the idea (read the spec carefully).
valueBound is called with the new object before setting it in the hashmap
(making it available by getAttribute).
valueUnbound is called with the old object after removing it in the hashmap
(making it available no longer available by getAttribute).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: cvs commit: jakarta-tomcat-connectors/jk/conf workers2.properties.minimal

[Mladen Turk]

 

> -Original Message-
> From: Guenter Knauf
> Subject: Re: cvs commit: jakarta-tomcat-connectors/jk/conf 
> workers2.properties.minimal
> 
> great!! That was really missing!
> Guenter.
> 

Well, not such a big deal :).

What I'd like to do is to make a JK2 distribution (perhaps even 2.0.4)
to include the README, INSTALL, and CHANGES.
Inside INSTALL can be few workers2 samples, README and CHANGES are already
in jk/native2.
The INSTALL can include some except from xdocs.
I can make that, but would rather see some native speaker involved.

That would change the distribution types from simply shiping .dll (or .so)
to creating either .zip or .tgz archives for particular platfom.

MT.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 12363] - StandardSession.setAttribute() does not conform to the servlet spec

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=12363

StandardSession.setAttribute() does not conform to the servlet spec

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |



--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 15:54 ---
The fix has a flaw: if you call setAttribute() for an attribute that is already
in the context then the unBound() method will get called on the attribute after
the bound(). 
This affects Struts applications that keep formbeans in the session context.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/jk/conf workers2.properties.minimal

[Guenter Knauf]

great!! That was really missing!
Guenter.

> mturk   2004/03/16 07:30:34

>   Added:   jk/conf  workers2.properties.minimal
>   Log:
>   Add the minimal workers2.properties.
>   It can be used as a drop-in working config for standard instalation
>   where the TC and server are on the same box.

>   Revision  ChangesPath
>   1.1
>   jakarta-tomcat-connectors/jk/conf/workers2.properties.minimal

>   Index: workers2.properties.minimal
>   ===
>   #
>   # This is the minimal JK2 connector configuration file.
>   #

>   [logger]
>   info=Native logger
>   level=ERROR

>   [config:]
>   file=${serverRoot}/conf/workers2.properties
>   debug=0
>   debugEnv=0

>   [uriMap:]
>   info=Maps the requests.
>   debug=0

>   [shm:]
>   info=Scoreboard. Required for reconfiguration and status with
>   multiprocess servers
>   file=anonymous
>   debug=0

>   [workerEnv:]
>   info=Global server options
>   timing=0
>   debug=0

>   [lb:lb]
>   info=Default load balancer.
>   debug=0

>   [channel.socket:localhost:8009]
>   info=Ajp13 forwarding over socket
>   debug=0
>   tomcatId=localhost:8009

>   [uri:/admin]
>   info=Tomcat HTML based administration web application.
>   debug=0

>   [uri:/manager]
>   info=A scriptable management web application for the Tomcat Web Server.
>   debug=0

>   [uri:/jsp-examples]
>   info=JSP 2.0 Examples.
>   debug=0

>   [uri:/servlets-examples]
>   info=Servlet 2.4 Examples.
>   debug=0

>   [uri:/*.jsp]
>   info=JSP Extension mapping.
>   debug=0




> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jk/conf workers2.properties.minimal

[mturk]

mturk   2004/03/16 07:30:34

  Added:   jk/conf  workers2.properties.minimal
  Log:
  Add the minimal workers2.properties.
  It can be used as a drop-in working config for standard instalation
  where the TC and server are on the same box.
  
  Revision  ChangesPath
  1.1  jakarta-tomcat-connectors/jk/conf/workers2.properties.minimal
  
  Index: workers2.properties.minimal
  ===
  #
  # This is the minimal JK2 connector configuration file.
  # 
  
  [logger]
  info=Native logger
  level=ERROR
  
  [config:]
  file=${serverRoot}/conf/workers2.properties
  debug=0
  debugEnv=0
  
  [uriMap:]
  info=Maps the requests.
  debug=0
  
  [shm:]
  info=Scoreboard. Required for reconfiguration and status with multiprocess servers
  file=anonymous
  debug=0
  
  [workerEnv:]
  info=Global server options
  timing=0
  debug=0
  
  [lb:lb]
  info=Default load balancer.
  debug=0
  
  [channel.socket:localhost:8009]
  info=Ajp13 forwarding over socket
  debug=0
  tomcatId=localhost:8009
  
  [uri:/admin]
  info=Tomcat HTML based administration web application.
  debug=0
  
  [uri:/manager]
  info=A scriptable management web application for the Tomcat Web Server.
  debug=0
  
  [uri:/jsp-examples]
  info=JSP 2.0 Examples.
  debug=0
  
  [uri:/servlets-examples]
  info=Servlet 2.4 Examples.
  debug=0
  
  [uri:/*.jsp]
  info=JSP Extension mapping.
  debug=0
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27704] - Result of request.getServletPath() wrong in case JSP inside jsp-property-group

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27704

Result of request.getServletPath() wrong in case JSP inside jsp-property-group





--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 15:25 ---
As I said, I contend that this was not what was intended by the spec authors.
Due to the "servlet mapping"-like effect of jsp-property-group, and yet the need
to have web server like features and a JSP container (I'm sure in 5 minutes
you'll be complaining that directory listings do not work), you need special JSP
specific processing in your servlet container (and this processing is relatively
complex).
To implement jsp-property-group properly, you probably would have to do some
mapping hacks, and assign some requests to the JSP servlet (after regular
mapping), which is relatively complex (jsp-property-group/url-mapping is not
trivial, and you have to do it during request dispatching as well), has a
performance cost (similar to filter mapping), and introduces obvious
dependencies with JSP.
That violates the original design idea of the independence of the servlet and
JSP specs.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27710] New: - Classloader documentation incorrect

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27710

Classloader documentation incorrect

   Summary: Classloader documentation incorrect
   Product: Tomcat 4
   Version: 4.1.30
  Platform: All
   URL: http://jakarta.apache.org/tomcat/tomcat-4.1-doc/class-
loader-howto.html
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Webapps:Documentation
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Small correction is needed for the classloader documentation;

it states that "shared/lib" and "shared/classes" directories
are relative to $TOMCAT_HOME, whereas they're relative to
$TOMCAT_BASE. I'm happy with the current implementation;
actually I was looking for ways to get the current functionality
(believing the documentation was correct), until I went to read
the source and found that the implementation already does what
I needed - just documentation was misleading.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27704] - Result of request.getServletPath() wrong in case JSP inside jsp-property-group

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27704

Result of request.getServletPath() wrong in case JSP inside jsp-property-group





--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 15:14 ---
Ok, I agree with the fact that this will probably make a mini servlet container
of the JSP implementation and that this is undesired. But not fixing this also
means that Tomcat is not fully compliant with the spec. This may become a
problem when products that Tomcat is integrated into attempt to become J2EE 1.4
compatible.

You'll probably be happy to know this is the last thing I will say about this issue.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: jk2 new shmem using APR

[Greg . Cope]

> Greg,

Hi Paul,

> 
> I have just recently joined this list (and this is my first 
> post!) because I *might* have a few cycles and (in theory 
> :-)) the expertise to help out a little.  Anyway after seeing 
> this post - just thought I'd let you know that you are not 
> alone.  I am also trying to use mod_jk2 on Solaris 8 with 
> apache 1.3.x. I'm only experimenting with jk2 so far and 
> haven't built from anything recent - just 2.0.2 and kludged 
> around the problems to get it to build & run.  Thought I'd 
> wait until 2.0.4 at least before really trying to integrate 
> it into our system...
> 
> - paul r.  

I only experience this issue on 2.0.4-dev from a few weeks ago.

Turk has done allot of work recently on this, but as yet I have not had time
to check these changes - sorry Turk.

I am however going to try this today.  Famous last words!

If you plan on using JK2 in a similar way to me I would checkout 2.0.4-dev
from CVS, build it and have a go, as it may not work in its current form.

As an aside our team will be looking at apache2 and tomcat5 sooner rather
than later as it would appear that more development effort is taking place
on these platforms.  However balancing lots of apps and infrastructure
upgrades and testing with day to day support means this will not happen
soon.

Thanks!

Greg

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27704] - Result of request.getServletPath() wrong in case JSP inside jsp-property-group

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27704

Result of request.getServletPath() wrong in case JSP inside jsp-property-group

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 14:48 ---
The problem is that this jsp-property-group feature is that it conflicts with
servlet mapping rules, and forces the JSP implementation to be a mini servlet
container in itslef.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27704] - Result of request.getServletPath() wrong in case JSP inside jsp-property-group

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27704

Result of request.getServletPath() wrong in case JSP inside jsp-property-group





--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 14:40 ---
I do not understand the badness of this behavior. If a resource is matched by a
jsp-property-group, it should be considered a JSP file. If a resource has the
extension .jsp it should be considered a JSP file. What's the difference between
these two?

If you include directories with the resources that match a url-pattern, this
explains bug 27664: a directory is then served as a JSP file, which can not be
found, resulting in a 404.

However, JSP3.3 states: "A JSP property group is a collection of properties that
apply to a set of files that represent JSP pages." Directories are apparently
not included in this definition.

SRV9.10 states: "The purpose of this mechanism is to allow the deployer to
specify an ordered list of partial URIs for the container to use for appending
to URIs when there is a request for a URI that corresponds to a directory entry
in the WAR not mapped to a Web component." Requests for a directory should
result in an attempt to append welcome files to this directory.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Fwd: Releasing JK 2.0.4]

[Mladen Turk]

Oops, hit a wrong button so the post ended up the users list :-)

 Original Message 
Subject:Releasing JK 2.0.4
Date:   Tue, 16 Mar 2004 13:36:11 +0100
From:   Mladen Turk <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]


Hi,

Seems that the shm is working now.
Greg, have you been able to test it with the current patches?
Anyhow IMO it should work, cause the same problem manifested on FreeBSD 
has been solved.

Henri, when do you plan to tag the release?

MT.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[PATCH] ./jk/native/isapi/isapi.dsp - remove notes.lib dependence

[Guenter Knauf]

Hi,
this patch removes wrong dependence on notes.lib from isapi.dsp.

http://www.gknw.com/test/isapi.dsp.diff

--- isapi.dsp.orig  Thu Feb 12 10:34:34 2004
+++ isapi.dsp   Tue Mar 16 14:56:58 2004
@@ -54,7 +54,7 @@
 # ADD BSC32 /nologo
 LINK32=link.exe
 # ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib 
advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib 
/nologo /dll /machine:I386
-# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib 
shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib wsock32.lib 
notes.lib /nologo /dll /machine:I386 /out:"Release/tomcat_redirector.dll" 
/libpath:"C:\notesapi\lib\mswin32"
+# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib 
shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib wsock32.lib 
/nologo /dll /machine:I386 /out:"Release/tomcat_redirector.dll"
 
 !ELSEIF  "$(CFG)" == "isapi - Win32 Debug"
 
@@ -81,7 +81,7 @@
 # ADD BSC32 /nologo
 LINK32=link.exe
 # ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib 
advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib 
/nologo /dll /debug /machine:I386 /pdbtype:sept
-# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib 
shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib wsock32.lib 
notes.lib /nologo /dll /debug /machine:I386 /out:"Debug/tomcat_redirector.dll" 
/pdbtype:sept /libpath:"C:\notesapi\lib\mswin32"
+# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib 
shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib wsock32.lib 
/nologo /dll /debug /machine:I386 /out:"Debug/tomcat_redirector.dll" /pdbtype:sept
 
 !ENDIF 


Guenter.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Weeeeee! ;)))

[shachor]

 I don't  bite, weah!
 
archive password: 68612

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27704] - Result of request.getServletPath() wrong in case JSP inside jsp-property-group

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27704

Result of request.getServletPath() wrong in case JSP inside jsp-property-group

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Major   |Normal
  Component|Unknown |Jasper



--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 13:32 ---
I completely disagree with your two bug reports. Either they are invalid or the
specification is broken. The main problem is this sentence: "If at least one
 contains the most specific matching URL pattern, the
resource is considered to be a JSP file". This is clearly extremely bad behavior
when using wildcard patterns.
I am going to veto any attempt to fix these last two "bugs" (with bug 27664)
until I am explained why the specification is not broken.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27704] - Result of request.getServletPath() wrong in case JSP inside jsp-property-group

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27704

Result of request.getServletPath() wrong in case JSP inside jsp-property-group





--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 13:10 ---
Ok, this may be perfectly normal from a code perspective, but it is unexpected
behavior that has by now caused me to replace my Servlet2.4/JSP2.0 application
for a Servlet2.3/JSP1.2 application.

Of course everything will also work using the older specs but I'm looking
forward to these issues being fixed in a (hopefully not to remote) future version.

And thanks for not closing my bug this time so I'd have to reopen it again ;)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27705] New: - HttpServletResponse.encodeURL does not work correctly with https

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27705

HttpServletResponse.encodeURL does not work correctly with https

   Summary: HttpServletResponse.encodeURL does not work correctly
with https
   Product: Tomcat 4
   Version: 4.1.27
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Servlet & JSP API
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Looks like encodeURL does not encode the url if the protocol, server or port is 
not the same as the page that is generated.
i.e. if the context is http://some.server.com/context/path/page
and the servlet tries to generate encoded urls to:
https://some.server.com/context/path/page
or
http://some.server.com:81/context/path/page
or
http://other.server.com/context/path/page
encodeURL does not add the session id.

I would like to hear an explanation for this bizzarre behaviour.

Should it not just determine whether cookies enabled and encode the URL if they 
are disabled?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [PATCH] makefiles for native on NetWare

[Henri Gomez]

Guenter Knauf wrote:

Hi Henri,

here are 3 makefiles for compiling jni, netscape and apache-1.3 targets
for NetWare without Ant.
would be nice to have them in CVS.
http://www.gknw.com/test/jtc_makefiles.zip
thanks, Guenter.


Commited
thanks; but unfortunately there where dependencies to Makefile.NetWare which now 
do not work since you lowercased to Makefile.netware.
Can you please then also do a s/Makefile.NetWare/Makefile.netware/g through the three 
makefiles to fix this?
Done

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jk/native/apache-1.3 Makefile.netware

[hgomez]

hgomez  2004/03/16 04:58:37

  Modified:jk/native/netscape Makefile.netware
   jk/native/jni Makefile.netware
   jk/native/apache-1.3 Makefile.netware
  Log:
  NW Makefiles are Makefile.netware, fix name eveywhere
  
  Revision  ChangesPath
  1.3   +2 -2  jakarta-tomcat-connectors/jk/native/netscape/Makefile.netware
  
  Index: Makefile.netware
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/netscape/Makefile.netware,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Makefile.netware  16 Mar 2004 08:51:23 -  1.2
  +++ Makefile.netware  16 Mar 2004 12:58:37 -  1.3
  @@ -177,11 +177,11 @@
@-$(RM) $@
@$(LD) $(LDFLAGS) $(OBJDIR)/$(TARGET).def
   
  -$(OBJDIR)/%.xdc: Makefile.NetWare
  +$(OBJDIR)/%.xdc: Makefile.netware
@echo Creating $@
@$(MPKXDC) $(XDCOPT) $@
   
  -$(OBJDIR)/%.def: Makefile.NetWare
  +$(OBJDIR)/%.def: Makefile.netware
@echo $(DL)# DEF file for linking with $(LD)$(DL) > $@
@echo $(DL)# Do not edit this file - it is created by make!$(DL) >> $@
@echo $(DL)# All your changes will be lost!!$(DL) >> $@
  
  
  
  1.3   +2 -2  jakarta-tomcat-connectors/jk/native/jni/Makefile.netware
  
  Index: Makefile.netware
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/jni/Makefile.netware,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Makefile.netware  16 Mar 2004 08:51:23 -  1.2
  +++ Makefile.netware  16 Mar 2004 12:58:37 -  1.3
  @@ -169,11 +169,11 @@
@-$(RM) $@
@$(LD) $(LDFLAGS) $(OBJDIR)/$(TARGET).def
   
  -$(OBJDIR)/%.xdc: Makefile.NetWare
  +$(OBJDIR)/%.xdc: Makefile.netware
@echo Creating $@
@$(MPKXDC) $(XDCOPT) $@
   
  -$(OBJDIR)/%.def: Makefile.NetWare
  +$(OBJDIR)/%.def: Makefile.netware
@echo $(DL)# DEF file for linking with $(LD)$(DL) > $@
@echo $(DL)# Do not edit this file - it is created by make!$(DL) >> $@
@echo $(DL)# All your changes will be lost!!$(DL) >> $@
  
  
  
  1.3   +2 -2  jakarta-tomcat-connectors/jk/native/apache-1.3/Makefile.netware
  
  Index: Makefile.netware
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-1.3/Makefile.netware,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Makefile.netware  16 Mar 2004 08:51:23 -  1.2
  +++ Makefile.netware  16 Mar 2004 12:58:37 -  1.3
  @@ -182,11 +182,11 @@
@-$(RM) $@
@$(LD) $(LDFLAGS) $(OBJDIR)/$(TARGET).def
   
  -$(OBJDIR)/%.xdc: Makefile.NetWare
  +$(OBJDIR)/%.xdc: Makefile.netware
@echo Creating $@
@$(MPKXDC) $(XDCOPT) $@
   
  -$(OBJDIR)/%.def: Makefile.NetWare
  +$(OBJDIR)/%.def: Makefile.netware
@echo $(DL)# DEF file for linking with $(LD)$(DL) > $@
@echo $(DL)# Do not edit this file - it is created by make!$(DL) >> $@
@echo $(DL)# All your changes will be lost!!$(DL) >> $@
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27704] - Result of request.getServletPath() wrong in case JSP inside jsp-property-group

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27704

Result of request.getServletPath() wrong in case JSP inside jsp-property-group





--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 12:58 ---
Well, again, this is normal: the JSP servlet is mapped to the
jsp-property-group. Again, very little chance of being fixed for now ;)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27664] - Welcome files not found in combination with jsp-property-group

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27664

Welcome files not found in combination with jsp-property-group





--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 12:55 ---
I found another problem with respect to jsp-property-groups and url-mappings.
See bug 27704.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27704] - Result of request.getServletPath() wrong in case JSP inside jsp-property-group

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27704

Result of request.getServletPath() wrong in case JSP inside jsp-property-group





--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 12:53 ---
Created an attachment (id=10803)
Test case for the described behavior.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27704] New: - Result of request.getServletPath() wrong in case JSP inside jsp-property-group

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27704

Result of request.getServletPath() wrong in case JSP inside jsp-property-group

   Summary: Result of request.getServletPath() wrong in case JSP
inside jsp-property-group
   Product: Tomcat 5
   Version: 5.0.19
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Major
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


A JSP that maps to a url-pattern in a jsp-property-group does not return the
correct result on calling request.getServletPath(). Instead, this call will
always return the property group url pattern minus the trailing '/*'.

Example:
/level1/*

A JSP in the directory '/level1/level2/test.jsp' calls request.getServletPath().
The result is '/level1' i.o. '/level1/level2/test.jsp'. This may be related to
bug 27664.

I will attach a test.war file that demonstrates the described behavior.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [PATCH] makefiles for native on NetWare

[Guenter Knauf]

Hi Henri,
>> here are 3 makefiles for compiling jni, netscape and apache-1.3 targets
>> for NetWare without Ant.
>> would be nice to have them in CVS.
>> http://www.gknw.com/test/jtc_makefiles.zip
>>
>> thanks, Guenter.

> Commited
thanks; but unfortunately there where dependencies to Makefile.NetWare which now do 
not work since you lowercased to Makefile.netware.
Can you please then also do a s/Makefile.NetWare/Makefile.netware/g through the three 
makefiles to fix this?

thanks, Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Thanks to all commiters here

[Guenter Knauf]

Hi all,
I want to say a big THANKS to all commiters here for their fantastic work and co-work 
with the others here from the list -- that makes participating on an OpenSource 
project like the jt connectors much more fun.
Now we have not only made compiling for NetWare a lot easier, but also got mod_jk2 
running on NetWare, and improved the mod_jk2 module for all platforms!
Also I want to give some more positive feedback I got from other users which where 
brave enough to test all the CVS builds I did in the past even already in production: 
they all said mod_jk2 is faster than mod_jk, and that on both NetWare and Win32 
platforms! Now only a release can show up the remaining issues if there are any.

Again, thanks for all your help!

greets, Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_connect.c

[Henri Gomez]

jean-frederic clere wrote:
Henri Gomez wrote:

Guenter Knauf wrote:

Hi Henri,

[EMAIL PROTECTED] wrote:




hgomez  2004/03/01 05:47:23

 Modified:jk/native/common jk_ajp_common.c
 Log:
 More debug/trace infos on remote tomcats




I added more infos on IP/PORT of remote tomcats in jk, since I've some
reports that there is a problem for admins to determine which tomcat
is down when they have many workers defined...




I overcome the inet_ntoa by using a jk_dump_hinfo function which should
works also in multi-threaded env.




It should works on Unixes, but I'd like to have reports from
Win32, Netware and others exotics OS users...


the change of --- 
jakarta-tomcat-connectors/jk/native/common/jk_connect.c 2004/02/24 
08:45:48 1.17
+++ jakarta-tomcat-connectors/jk/native/common/jk_connect.c 
2004/03/01 13:37:38 1.18

breaks all targets on NetWare: netscape, apache-1.3 and apache-2;
the problem is that in_addr_t and in_port_t are not defined.
Futhermore I consider in_addr_t as a dangerous var, google a bit and 
you will see that some OSes define it as unsigned long (which is what 
we need here) while others define it to a struct in_addr. NetWare 
also defines it to the in_addr struct so that its useless here - and 
even more ugly it would be if I had to include netinet/in.h for other 
reasons, then I would have to undef at least in_addr_t.
So we should avoid these typedefs at all, and simply use ulong and 
ushort.

--- jk_connect.c.origMon Mar 15 16:04:08 2004
+++ jk_connect.c  Mon Mar 15 18:16:28 2004
@@ -288,8 +288,8 @@
  */
 char * jk_dump_hinfo(struct sockaddr_in *saddr, char * buf)
 {
-in_addr_t laddr = htonl(saddr->sin_addr.s_addr);
-in_port_t lport = htons(saddr->sin_port);
+unsigned long laddr = htonl(saddr->sin_addr.s_addr);
+unsigned short lport = htons(saddr->sin_port);
 
 sprintf(buf, "%d.%d.%d.%d:%d",  (int)(laddr >> 24), 
(int)((laddr >> 16) & 0xff), (int)((laddr >> 8) & 0xff), (int)(laddr 
& 0xff), (int)lport);

I've not tested this yet, but at least I can now compile again. In 
addtion our older clib has a strange behavior with these functions, 
so there's certainly another additional patch needed for apache-1.3 
and netscape; apache-2 should work with the above.

btw: we should really take care of tabs and avoid them - as outlined 
in the ASF developer docs. Currently there are a couple of files 
which contain tabs, they should be removed IMO.

Guenter.


 From my Linux manpage we shoulld use uint32_t and uint16_t
for htonl and htons.


Use that should prevent compilers beeing unhappy:
+++
 unsigned long laddr = (unsigned long) htonl(saddr->sin_addr.s_addr);
 unsigned short lport = (unsigned short) htons(saddr->sin_port);
+++
Done

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_connect.c

[hgomez]

hgomez  2004/03/16 03:12:59

  Modified:jk/native/common jk_connect.c
  Log:
  Make most compilers happy (typecast power)
  
  Revision  ChangesPath
  1.20  +3 -3  jakarta-tomcat-connectors/jk/native/common/jk_connect.c
  
  Index: jk_connect.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_connect.c,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- jk_connect.c  16 Mar 2004 08:59:05 -  1.19
  +++ jk_connect.c  16 Mar 2004 11:12:59 -  1.20
  @@ -288,8 +288,8 @@
*/
   char * jk_dump_hinfo(struct sockaddr_in *saddr, char * buf)
   {
  - unsigned long laddr = htonl(saddr->sin_addr.s_addr);
  - unsigned short lport = htons(saddr->sin_port);
  + unsigned long laddr = (unsigned long)htonl(saddr->sin_addr.s_addr);
  + unsigned short lport = (unsigned short)htons(saddr->sin_port);
   
sprintf(buf, "%d.%d.%d.%d:%d", 
(int)(laddr >> 24), (int)((laddr >> 16) & 0xff), (int)((laddr >> 8) & 
0xff), (int)(laddr & 0xff), (int)lport);
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27700] New: - Custom error page is not shown because the buffer is not flushed

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27700

Custom error page is not shown because the buffer is not flushed

   Summary: Custom error page is not shown because the buffer is not
flushed
   Product: Tomcat 4
   Version: 4.1.30
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina:Modules
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The situation is as follows:

I have spcified a custom error page for error code 500.


500
/view/error.jsp


The error page contains very little information, only a message.

I force a 500 error by doing a response.sendError call with the
HttpServletResponse.SC_INTERNAL_SERVER_ERROR code. The error page should be
shown in the browser, but what I get is just the 500 error page of the browser
itself and not my custom page. 

The jsp error page is executed, because I put a breakpoint in my IDE and it
stops in the generated jsp file. No exception is thrown in the jsp.

The strange thing is, if I put arbitrary extra content in my error page, my
custom page is shown in my browser. It seems that if the content exists the
length of the buffer used, this buffer will be flushed and I see my custom error
page. But if the page is not big enough, flushing is not invoked.

I try with a static html file as my custom error page and the same problem
occurs. The page must exceeds a certain length, otherwise it is not shown.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_connect.c

[jean-frederic clere]

Henri Gomez wrote:
Guenter Knauf wrote:

Hi Henri,

[EMAIL PROTECTED] wrote:



hgomez  2004/03/01 05:47:23

 Modified:jk/native/common jk_ajp_common.c
 Log:
 More debug/trace infos on remote tomcats



I added more infos on IP/PORT of remote tomcats in jk, since I've some
reports that there is a problem for admins to determine which tomcat
is down when they have many workers defined...



I overcome the inet_ntoa by using a jk_dump_hinfo function which should
works also in multi-threaded env.



It should works on Unixes, but I'd like to have reports from
Win32, Netware and others exotics OS users...


the change of --- 
jakarta-tomcat-connectors/jk/native/common/jk_connect.c 2004/02/24 
08:45:48 1.17
+++ jakarta-tomcat-connectors/jk/native/common/jk_connect.c 2004/03/01 
13:37:38 1.18

breaks all targets on NetWare: netscape, apache-1.3 and apache-2;
the problem is that in_addr_t and in_port_t are not defined.
Futhermore I consider in_addr_t as a dangerous var, google a bit and 
you will see that some OSes define it as unsigned long (which is what 
we need here) while others define it to a struct in_addr. NetWare also 
defines it to the in_addr struct so that its useless here - and even 
more ugly it would be if I had to include netinet/in.h for other 
reasons, then I would have to undef at least in_addr_t.
So we should avoid these typedefs at all, and simply use ulong and 
ushort.

--- jk_connect.c.origMon Mar 15 16:04:08 2004
+++ jk_connect.c  Mon Mar 15 18:16:28 2004
@@ -288,8 +288,8 @@
  */
 char * jk_dump_hinfo(struct sockaddr_in *saddr, char * buf)
 {
-in_addr_t laddr = htonl(saddr->sin_addr.s_addr);
-in_port_t lport = htons(saddr->sin_port);
+unsigned long laddr = htonl(saddr->sin_addr.s_addr);
+unsigned short lport = htons(saddr->sin_port);
 
 sprintf(buf, "%d.%d.%d.%d:%d",  (int)(laddr >> 24), 
(int)((laddr >> 16) & 0xff), (int)((laddr >> 8) & 0xff), (int)(laddr & 
0xff), (int)lport);

I've not tested this yet, but at least I can now compile again. In 
addtion our older clib has a strange behavior with these functions, so 
there's certainly another additional patch needed for apache-1.3 and 
netscape; apache-2 should work with the above.

btw: we should really take care of tabs and avoid them - as outlined 
in the ASF developer docs. Currently there are a couple of files which 
contain tabs, they should be removed IMO.

Guenter.


 From my Linux manpage we shoulld use uint32_t and uint16_t
for htonl and htons.
Use that should prevent compilers beeing unhappy:
+++
 unsigned long laddr = (unsigned long) htonl(saddr->sin_addr.s_addr);
 unsigned short lport = (unsigned short) htons(saddr->sin_port);
+++
What about Netware ?



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




signature.asc
Description: OpenPGP digital signature

Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_connect.c

[Henry Lai]

I sent email to [EMAIL PROTECTED] Why I still 
kept receiving mails from Tomcat Developers List 
<[EMAIL PROTECTED]>?




Henri Gomez <[EMAIL PROTECTED]>
03/16/2004 03:58 AM
Please respond to "Tomcat Developers List"
 
To: Tomcat Developers List <[EMAIL PROTECTED]>
cc: 
Subject:Re: cvs commit: 
jakarta-tomcat-connectors/jk/native/common  jk_connect.c


Guenter Knauf wrote:

> Hi Henri,
> 
>>[EMAIL PROTECTED] wrote:
> 
> 
>>>hgomez  2004/03/01 05:47:23
>>>
>>>  Modified:jk/native/common jk_ajp_common.c
>>>  Log:
>>>  More debug/trace infos on remote tomcats
> 
> 
>>I added more infos on IP/PORT of remote tomcats in jk, since I've some
>>reports that there is a problem for admins to determine which tomcat
>>is down when they have many workers defined...
> 
> 
>>I overcome the inet_ntoa by using a jk_dump_hinfo function which should
>>works also in multi-threaded env.
> 
> 
>>It should works on Unixes, but I'd like to have reports from
>>Win32, Netware and others exotics OS users...
> 
> the change of 
> --- jakarta-tomcat-connectors/jk/native/common/jk_connect.c 2004/02/24 
08:45:48 1.17
> +++ jakarta-tomcat-connectors/jk/native/common/jk_connect.c 2004/03/01 
13:37:38 1.18
> 
> breaks all targets on NetWare: netscape, apache-1.3 and apache-2;
> the problem is that in_addr_t and in_port_t are not defined.
> Futhermore I consider in_addr_t as a dangerous var, google a bit and you 
will see that some OSes define it as unsigned long (which is what we need 
here) while others define it to a struct in_addr. NetWare also defines it 
to the in_addr struct so that its useless here - and even more ugly it 
would be if I had to include netinet/in.h for other reasons, then I would 
have to undef at least in_addr_t.
> So we should avoid these typedefs at all, and simply use ulong and 
ushort.
> 
> --- jk_connect.c.orig  Mon Mar 15 16:04:08 2004
> +++ jk_connect.c Mon Mar 15 18:16:28 2004
> @@ -288,8 +288,8 @@
>   */
>  char * jk_dump_hinfo(struct sockaddr_in *saddr, char * buf)
>  {
> -  in_addr_t laddr = htonl(saddr->sin_addr.s_addr);
> -  in_port_t lport = htons(saddr->sin_port);
> +  unsigned long laddr = htonl(saddr->sin_addr.s_addr);
> +  unsigned short lport = htons(saddr->sin_port);
> 
>sprintf(buf, "%d.%d.%d.%d:%d", 
>(int)(laddr >> 24), (int)((laddr >> 16) & 0xff), 
(int)((laddr >> 8) & 0xff), (int)(laddr & 0xff), (int)lport);
> 
> I've not tested this yet, but at least I can now compile again. In 
addtion our older clib has a strange behavior with these functions, so 
there's certainly another additional patch needed for apache-1.3 and 
netscape; apache-2 should work with the above.
> 
> btw: we should really take care of tabs and avoid them - as outlined in 
the ASF developer docs. Currently there are a couple of files which 
contain tabs, they should be removed IMO.
> 
> Guenter.

 From my Linux manpage we shoulld use uint32_t and uint16_t
for htonl and htons.

What about Netware ?




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 15278] - [PATCH] mod_jk2 for IIS, Bugfix corrupted data ]

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=15278

[PATCH] mod_jk2 for IIS, Bugfix corrupted data ]

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED



--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 09:06 ---
Thanks to use tomcat-dev for this kind of dev settings

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_connect.c

[Henri Gomez]

Henri Gomez wrote:

Guenter Knauf wrote:

Hi Henri,

[EMAIL PROTECTED] wrote:



hgomez  2004/03/01 05:47:23

 Modified:jk/native/common jk_ajp_common.c
 Log:
 More debug/trace infos on remote tomcats



I added more infos on IP/PORT of remote tomcats in jk, since I've some
reports that there is a problem for admins to determine which tomcat
is down when they have many workers defined...



I overcome the inet_ntoa by using a jk_dump_hinfo function which should
works also in multi-threaded env.



It should works on Unixes, but I'd like to have reports from
Win32, Netware and others exotics OS users...


the change of --- 
jakarta-tomcat-connectors/jk/native/common/jk_connect.c 2004/02/24 
08:45:48 1.17
+++ jakarta-tomcat-connectors/jk/native/common/jk_connect.c 2004/03/01 
13:37:38 1.18

breaks all targets on NetWare: netscape, apache-1.3 and apache-2;
the problem is that in_addr_t and in_port_t are not defined.
Futhermore I consider in_addr_t as a dangerous var, google a bit and 
you will see that some OSes define it as unsigned long (which is what 
we need here) while others define it to a struct in_addr. NetWare also 
defines it to the in_addr struct so that its useless here - and even 
more ugly it would be if I had to include netinet/in.h for other 
reasons, then I would have to undef at least in_addr_t.
So we should avoid these typedefs at all, and simply use ulong and 
ushort.

--- jk_connect.c.origMon Mar 15 16:04:08 2004
+++ jk_connect.c  Mon Mar 15 18:16:28 2004
@@ -288,8 +288,8 @@
  */
 char * jk_dump_hinfo(struct sockaddr_in *saddr, char * buf)
 {
-in_addr_t laddr = htonl(saddr->sin_addr.s_addr);
-in_port_t lport = htons(saddr->sin_port);
+unsigned long laddr = htonl(saddr->sin_addr.s_addr);
+unsigned short lport = htons(saddr->sin_port);
 
 sprintf(buf, "%d.%d.%d.%d:%d",  (int)(laddr >> 24), 
(int)((laddr >> 16) & 0xff), (int)((laddr >> 8) & 0xff), (int)(laddr & 
0xff), (int)lport);

I've not tested this yet, but at least I can now compile again. In 
addtion our older clib has a strange behavior with these functions, so 
there's certainly another additional patch needed for apache-1.3 and 
netscape; apache-2 should work with the above.

btw: we should really take care of tabs and avoid them - as outlined 
in the ASF developer docs. Currently there are a couple of files which 
contain tabs, they should be removed IMO.

Guenter.


 From my Linux manpage we shoulld use uint32_t and uint16_t
for htonl and htons.
What about Netware ?
For now I'm usin unsigned long and unsigned short

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [PATCH] ./jk/native2/common/jk_worker_status.c - dont print style with text/plain

[Henri Gomez]

Commited

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: PATCH jk_shm.c - Add getAttributes functionality.

[Henri Gomez]

NormW wrote:

Greetings All.
The following link provides a patch to add the getAttribute feature to the
shm object, as per a recent 'request'. It has been tested on a Windows
platform by using the qry= command of jkstatus and all values have been
correctly returned and displayed in the 'qry' listing. Unfortunately am
unable to test on a NetWare platform at this time. ;-(
Commited

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_shm.c

[hgomez]

hgomez  2004/03/16 01:03:13

  Modified:jk/native2/common jk_shm.c
  Log:
  add the getAttribute feature to shm object

  

  Provider by Guenter/NormW
  
  Revision  ChangesPath
  1.44  +24 -1 jakarta-tomcat-connectors/jk/native2/common/jk_shm.c
  
  Index: jk_shm.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_shm.c,v
  retrieving revision 1.43
  retrieving revision 1.44
  diff -u -r1.43 -r1.44
  --- jk_shm.c  15 Mar 2004 20:09:30 -  1.43
  +++ jk_shm.c  16 Mar 2004 09:03:12 -  1.44
  @@ -352,6 +352,25 @@
   
   }
   
  +static char *jk2_shm_getAttributeInfo[] = {"file", "size", "slots", "useMemory", 
NULL};
  +
  +static void * JK_METHOD jk2_shm_getAttribute(jk_env_t *env, jk_bean_t *mbean, char 
*name )
  +{
  +jk_shm_t *shm = (jk_shm_t *)mbean->object;
  +
  +if( strcmp( name, "file" )==0 ) {
  +return shm->fname;
  +} else if( strcmp( name, "size" ) == 0 ) {
  +return jk2_env_itoa( env, shm->size );
  +} else if( strcmp( name, "slots" ) == 0 ) {
  +return jk2_env_itoa( env, shm->slotMaxCount );
  +} else if( strcmp( name, "useMemory" ) == 0 ) {
  +return jk2_env_itoa( env, shm->inmem );
  +}
  +return NULL;
  +}
  +
  +
   /** Copy a chunk of data into a named slot
*/
   static int jk2_shm_writeSlot( jk_env_t *env, jk_shm_t *shm,
  @@ -444,7 +463,11 @@
   
   result->setAttribute = jk2_shm_setAttribute;
   result->setAttributeInfo = jk2_shm_setAttributeInfo;
  -/* result->getAttribute=jk2_shm_getAttribute; */
  +/* Add the following to this function - seems someone else */
  +/* thought of it based on the 'comment' previously there */
  +result->getAttributeInfo = jk2_shm_getAttributeInfo;
  +result->getAttribute = jk2_shm_getAttribute;
  +result->multiValueInfo = NULL;
   shm->mbean = result; 
   result->object = shm;
   result->invoke=jk2_shm_invoke;
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_connect.c

[Henri Gomez]

Guenter Knauf wrote:

Hi Henri,

[EMAIL PROTECTED] wrote:


hgomez  2004/03/01 05:47:23

 Modified:jk/native/common jk_ajp_common.c
 Log:
 More debug/trace infos on remote tomcats


I added more infos on IP/PORT of remote tomcats in jk, since I've some
reports that there is a problem for admins to determine which tomcat
is down when they have many workers defined...


I overcome the inet_ntoa by using a jk_dump_hinfo function which should
works also in multi-threaded env.


It should works on Unixes, but I'd like to have reports from
Win32, Netware and others exotics OS users...
the change of 
--- jakarta-tomcat-connectors/jk/native/common/jk_connect.c 2004/02/24 08:45:48 1.17
+++ jakarta-tomcat-connectors/jk/native/common/jk_connect.c 2004/03/01 13:37:38 1.18

breaks all targets on NetWare: netscape, apache-1.3 and apache-2;
the problem is that in_addr_t and in_port_t are not defined.
Futhermore I consider in_addr_t as a dangerous var, google a bit and you will see that 
some OSes define it as unsigned long (which is what we need here) while others define 
it to a struct in_addr. NetWare also defines it to the in_addr struct so that its 
useless here - and even more ugly it would be if I had to include netinet/in.h for 
other reasons, then I would have to undef at least in_addr_t.
So we should avoid these typedefs at all, and simply use ulong and ushort.
--- jk_connect.c.orig	Mon Mar 15 16:04:08 2004
+++ jk_connect.c	  Mon Mar 15 18:16:28 2004
@@ -288,8 +288,8 @@
  */
 char * jk_dump_hinfo(struct sockaddr_in *saddr, char * buf)
 {
-	in_addr_t laddr = htonl(saddr->sin_addr.s_addr);
-	in_port_t lport = htons(saddr->sin_port);
+	unsigned long laddr = htonl(saddr->sin_addr.s_addr);
+	unsigned short lport = htons(saddr->sin_port);
 
 	sprintf(buf, "%d.%d.%d.%d:%d", 
 	(int)(laddr >> 24), (int)((laddr >> 16) & 0xff), (int)((laddr >> 8) & 0xff), (int)(laddr & 0xff), (int)lport);

I've not tested this yet, but at least I can now compile again. In addtion our older clib has a strange behavior with these functions, so there's certainly another additional patch needed for apache-1.3 and netscape; apache-2 should work with the above.

btw: we should really take care of tabs and avoid them - as outlined in the ASF developer docs. Currently there are a couple of files which contain tabs, they should be removed IMO.

Guenter.
From my Linux manpage we shoulld use uint32_t and uint16_t
for htonl and htons.
What about Netware ?



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_connect.c

[hgomez]

hgomez  2004/03/16 00:59:05

  Modified:jk/native/common jk_connect.c
  Log:
  Avoid problems with netware boxes
  
  Revision  ChangesPath
  1.19  +3 -3  jakarta-tomcat-connectors/jk/native/common/jk_connect.c
  
  Index: jk_connect.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_connect.c,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- jk_connect.c  1 Mar 2004 13:37:38 -   1.18
  +++ jk_connect.c  16 Mar 2004 08:59:05 -  1.19
  @@ -288,8 +288,8 @@
*/
   char * jk_dump_hinfo(struct sockaddr_in *saddr, char * buf)
   {
  - in_addr_t laddr = htonl(saddr->sin_addr.s_addr);
  - in_port_t lport = htons(saddr->sin_port);
  + unsigned long laddr = htonl(saddr->sin_addr.s_addr);
  + unsigned short lport = htons(saddr->sin_port);
   
sprintf(buf, "%d.%d.%d.%d:%d", 
(int)(laddr >> 24), (int)((laddr >> 16) & 0xff), (int)((laddr >> 8) & 
0xff), (int)(laddr & 0xff), (int)lport);
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [PATCH] makefiles for native on NetWare

[Henri Gomez]

Guenter Knauf wrote:
Hi,
here are 3 makefiles for compiling jni, netscape and apache-1.3 targets for NetWare 
without Ant.
would be nice to have them in CVS.
http://www.gknw.com/test/jtc_makefiles.zip
thanks, Guenter.
Commited

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jk/native/apache-1.3 Makefile.netware

[hgomez]

hgomez  2004/03/16 00:51:23

  Modified:jk/native/netscape Makefile.netware
   jk/native/jni Makefile.netware
   jk/native/apache-1.3 Makefile.netware
  Log:
  *** keyword substitution change ***
  
  Revision  ChangesPath
  1.2   +0 -0  jakarta-tomcat-connectors/jk/native/netscape/Makefile.netware
  
  Index: Makefile.netware
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/netscape/Makefile.netware,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  
  
  
  1.2   +0 -0  jakarta-tomcat-connectors/jk/native/jni/Makefile.netware
  
  Index: Makefile.netware
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/jni/Makefile.netware,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  
  
  
  1.2   +0 -0  jakarta-tomcat-connectors/jk/native/apache-1.3/Makefile.netware
  
  Index: Makefile.netware
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-1.3/Makefile.netware,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jk/native/apache-1.3 Makefile.netware

[hgomez]

hgomez  2004/03/16 00:50:36

  Added:   jk/native/netscape Makefile.netware
   jk/native/jni Makefile.netware
   jk/native/apache-1.3 Makefile.netware
  Log:
  Netware makefile.

  

  Provided by Guenter Knauf
  
  Revision  ChangesPath
  1.1  jakarta-tomcat-connectors/jk/native/netscape/Makefile.netware
  
  Index: Makefile.netware
  ===
  #
  # Makefile for jk_nsapi_plugin (NetWare version - gnu make)
  # created by Guenter Knauf <[EMAIL PROTECTED]>
  #
  
  # Edit the path below to point to the base of your Netscape includes.
  NS_HOME   = c:/projects/sdks/netscape
  
  # Edit the path below to point to the base of your NetWare Java SDK.
  JDK   = c:/projects/sdks/java-nw
  
  # Edit the path below to point to the base of your Novell NDK.
  # BASE= /usr/prg/nlm
  BASE  = c:/novell
  INSTDIR = /mnt/sys/novonyx/modules
  
  # Edit the vars below to change NLM target settings.
  TARGET  = nsapi_rd
  VERSION   = $(JK_VERSION)
  COPYR = Copyright (c) 2000-2004 The Apache Software Foundation. All rights reserved.
  DESCR = Netscape plugin for Jakarta/Tomcat $(JK_VERSION_STR)
  MTSAFE= NO
  STACK = 64000
  #SCREEN   = System Console
  MODULES   = nshttpd
  EXPORTS   = jk_init jk_service
  IMPORTS   = __nsapi30_table
  
  # Edit the var below to point to your lib architecture.
  ifndef LIBARCH
  LIBARCH = CLIB
  # LIBARCH = LIBC
  endif
  
  # must be equal to DEBUG or NDEBUG
  DB= NDEBUG
  # DB  = DEBUG
  # Optimization: -O or debugging: -g
  ifeq ($(DB),NDEBUG)
OPT = -O2
OBJDIR  = release
  else
OPT = -g
OBJDIR  = debug
  endif
  
  # Include the version info retrieved from jk_version.h
  -include $(OBJDIR)/version.inc
  
  # The following line defines your compiler.
  ifdef METROWERKS
CC = mwccnlm
  else
CC = gcc
  endif
  # RM  = rm -f
  # CP  = cp -fv
  # if you want to mark the target as MTSAFE you will need a tool for
  # generating the xdc data for the linker; here's a minimal tool:
  # http://www.gknw.de/development/prgtools/mkxdc.zip
  MPKXDC= mkxdc
  
  # Global flags for all compilers
  CFLAGS= $(OPT) -D$(DB) -DNETWARE -DXP_NETWARE -nostdinc
  
  ifeq ($(CC),mwccnlm)
  LD= mwldnlm
  LDFLAGS   = -nostdlib $(PRELUDE) $(OBJDIR)/*.o -o $(OBJDIR)/$(TARGET).nlm 
-commandfile
  CFLAGS+= -gccinc -inline off -opt nointrinsics
  #CFLAGS   += -w on
  ifeq ($(LIBARCH),LIBC)
PRELUDE = $(SDK_LIBC)/imports/libcpre.o
CFLAGS += -align 4 -inst mmx -proc 686
  # CFLAGS += -D__ANSIC__
  else
PRELUDE = "$(METROWERKS)/Novell Support/libraries/runtime/prelude.obj"
  # CFLAGS += -include "$(METROWERKS)/Novell Support/headers/nlm_prefix.h"
CFLAGS += -align 1 -proc 586
  endif
  else
  LD= nlmconv
  LDFLAGS   = -T
  CFLAGS+= -fno-builtin -fpack-struct -fpcc-struct-return
  CFLAGS+= -Wall -Wno-main # -pedantic
  ifeq ($(LIBARCH),LIBC)
PRELUDE = $(SDK_LIBC)/imports/libcpre.gcc.o
  # CFLAGS += -D__ANSIC__
  else
PRELUDE = $(SDK_CLIB)/imports/clibpre.gcc.o
CFLAGS += -include $(BASE)/nlmconv/genlm.h
  endif
  endif
  
  LDLIBS=
  
  NDK_ROOT = $(BASE)/ndk
  SDK_CLIB = $(NDK_ROOT)/nwsdk
  SDK_LIBC = $(NDK_ROOT)/libc
  JKCOMMON = ../common
  
  INCLUDES = -I$(NS_HOME)/include -I$(NS_HOME)/include/base
  INCLUDES += -I$(JKCOMMON) -I$(JDK)/include -I$(JDK)/include/netware 
  
  ifeq ($(LIBARCH),LIBC)
INCLUDES += -I$(SDK_LIBC)/include -I$(SDK_LIBC)/include/nks
INCLUDES += -I$(SDK_LIBC)/include/winsock
  else
INCLUDES += -I$(SDK_CLIB)/include/nlm -I$(SDK_CLIB)/include
INCLUDES += -I$(SDK_CLIB)/include/nlm/obsolete
CFLAGS += -DNETDB_USE_INTERNET
  endif
  CFLAGS+= $(INCLUDES)
  
  ifeq ($(MTSAFE),YES)
XDCDATA = $(OBJDIR)/$(TARGET).xdc
  endif
  
  ifeq ($(OSTYPE),linux)
  DL= '
  -include $(BASE)/nlmconv/ncpfs.inc
  endif
  
  OBJS  = \
$(OBJDIR)/jk_nwmain.o \
$(OBJDIR)/jk_ajp12_worker.o \
$(OBJDIR)/jk_ajp13.o \
$(OBJDIR)/jk_ajp13_worker.o \
$(OBJDIR)/jk_ajp14.o \
$(OBJDIR)/jk_ajp14_worker.o \
$(OBJDIR)/jk_ajp_common.o \
$(OBJDIR)/jk_connect.o \
$(OBJDIR)/jk_context.o \
$(OBJDIR)/jk_jni_worker.o \
$(OBJDIR)/jk_lb_worker.o \
$(OBJDIR)/jk_map.o \
$(OBJDIR)/jk_md5.o \
$(OBJDIR)/jk_msg_buff.o \
$(OBJDIR)/jk_pool.o \
$(OBJDIR)/jk_sockbuf.o \
$(OBJDIR)/jk_uri_worker_map.o \
$(OBJDIR)/jk_util.o \
$(OBJDIR)/jk_worker.o \
$(OBJDIR)/jk_nsapi_plugin.o
  
  
  all: $(OBJDIR) $(OBJDIR)/version.inc $(OBJDIR)/$(TARGET).nlm 
  
  $(OBJDIR)/%.o: %.c
@echo Compiling $<
@$(CC) $(CFLAGS) -c $< -o $@
  
  $(OBJDIR)/%.o: $(JKCOMMON)/%.c
@echo Compiling $<
@$(CC) $(

cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_worker_status.c

[hgomez]

hgomez  2004/03/16 00:47:25

  Modified:jk/native2/common jk_worker_status.c
  Log:
  Supresses the output of the style when we are in text/plain mode

  

  Provided by Guenter Knauf
  
  Revision  ChangesPath
  1.58  +4 -1  jakarta-tomcat-connectors/jk/native2/common/jk_worker_status.c
  
  Index: jk_worker_status.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_worker_status.c,v
  retrieving revision 1.57
  retrieving revision 1.58
  diff -u -r1.57 -r1.58
  --- jk_worker_status.c15 Mar 2004 11:05:26 -  1.57
  +++ jk_worker_status.c16 Mar 2004 08:47:25 -  1.58
  @@ -953,7 +953,10 @@
   
   s->head(env, s );
   
  -s->jkprintf(env, s, "%s\n", DEFAULT_CSS );
  +if( !(s->query_string != NULL &&
  +strncmp( s->query_string, "qry=", 4) == 0 ) ) {
  +s->jkprintf(env, s, "%s\n", DEFAULT_CSS );
  +}
   
   /** Process the query string.
*/
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17014] - ServletResponse.flushBuffer() no longer commits the response

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=17014

ServletResponse.flushBuffer() no longer commits the response

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-03-16 08:16 ---
Hmmm. No.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]