cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2005-01-29 Thread pero
pero2005/01/29 11:30:44 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: recreate server Socket after stop! Revision ChangesPath 1.43 +1 -0 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-10-14 Thread remm
remm2004/10/14 01:07:48 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - Remove bad shutdown logic for ms strategy. Revision ChangesPath 1.42 +3 -7 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-10-05 Thread remm
remm2004/10/05 15:16:20 Modified:util/java/org/apache/tomcat/util/net/res LocalStrings.properties util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - Improve i18n (help is needed to do this kind of work everywhere

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-10-03 Thread remm
remm2004/10/03 04:48:59 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - Oops, made a mistake with what the default should be. Probably I set that to the wrong value during early testing. Revision ChangesPath 1.40 +1 -1 jakarta

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-05-27 Thread yoavs
yoavs 2004/05/27 09:12:46 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Added support for threadPriority attribute (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=28914). Revision ChangesPath 1.37 +9 -3 jakarta-tomcat-connectors

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-02-03 Thread luehe
luehe 2004/02/03 12:28:56 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Reverted change that was done in revision 1.34 Revision ChangesPath 1.35 +4 -4 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-02-03 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: luehe 2004/02/02 15:08:29 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Expose handshake failure as error, so it gets logged unconditionally -1. Unlike what occurs for normal sockets, errors at this point are rather common

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-02-02 Thread luehe
luehe 2004/02/02 15:08:29 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Expose handshake failure as error, so it gets logged unconditionally Revision ChangesPath 1.34 +4 -4 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-01-26 Thread remm
/net PoolTcpEndpoint.java Log: - Remove compilation warnings. Revision ChangesPath 1.5 +54 -51 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/Reaper.java Index: Reaper.java === RCS

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-01-26 Thread remm
remm2004/01/26 10:19:48 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - Implement clean shutdown of the connectors (my third proposal). - Add pause and resume methods on the TCP endpoint. - The method I've choosen is to stop accepting to i

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-01-13 Thread remm
remm2004/01/13 02:16:39 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - So I'm removing the pool thing. Feel free to let me know if this was actually useful. Revision ChangesPath 1.31 +10 -33 jakarta-tomcat-connectors/util

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-01-13 Thread Remy Maucherat
if( usePool ) { con=(TcpConnection)connectionCache.get(); if( con == null ) I would like to remove this "pool" thing. It is dead code (there's a static final flag to enable it at compile time), so I think it should go. Rémy --

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-01-13 Thread remm
remm2004/01/13 01:56:24 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - Fix build. - Also group evertything in a big try catch, with a small flag for the logging. That way, this critical code will be less error prone. Logging will be, but it&#

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2004-01-12 Thread billbarker
billbarker2004/01/12 20:58:35 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Move the call to setSocketOptions to prevent a potential DoS condition when using SSL. Reported By: Alex Chan <[EMAIL PROTECTED]> Revision ChangesPath 1.29

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-25 Thread Amy Roh
- Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Tuesday, November 25, 2003 12:27 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEn

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-25 Thread Bill Barker
- Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Tuesday, November 25, 2003 12:27 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEn

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-25 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: amyroh 2003/11/24 15:01:22 Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Add getters for all attributes defined in MBeanInfo so getAttribute calls suceed

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-25 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: amyroh 2003/11/24 15:01:22 Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Add getters for all attributes defined in MBeanInfo so getAttribute calls suceed

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-24 Thread amyroh
amyroh 2003/11/24 15:01:22 Modified:http11/src/java/org/apache/coyote/http11 Http11Protocol.java util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Add getters for all attributes defined in MBeanInfo so getAttribute calls suceed. Revision Changes

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-03 Thread luehe
luehe 2003/11/03 13:13:01 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Reverted support for maxThreads=1 Revision ChangesPath 1.27 +9 -24 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java Index

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-01 Thread Sriram N
+1 on that. I'd rather that TC defaulted to safe values over my idotically low or even absent settings. -- Sriram --- Remy Maucherat <[EMAIL PROTECTED]> wrote: > Tim Funk wrote: > > Could a simple compromise be > > - Die (with error message) if < 2 > > - Warn if less than 10 (or ??). Letting the

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-01 Thread Remy Maucherat
Tim Funk wrote: Could a simple compromise be - Die (with error message) if < 2 - Warn if less than 10 (or ??). Letting the user be "stupid", but warn them about it. I don't agree with that behavior. Why should we fail or (worse) allow bad values ? Good defaults and being tolerant is a quality of

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-01 Thread Tim Funk
Could a simple compromise be - Die (with error message) if < 2 - Warn if less than 10 (or ??). Letting the user be "stupid", but warn them about it. -Tim Bill Barker wrote: "Jan Luehe" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Remy, I agree we should help users come up with

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-11-01 Thread Remy Maucherat
Bill Barker wrote: "Jan Luehe" <[EMAIL PROTECTED]> wrote in message Remy, I think we should make any maxThreads setting work, as my patch attempts to do, and update the documentation to make users aware of the limitations they will run into when picking a low maxThreads. I think that would be the

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-31 Thread Bill Barker
"Jan Luehe" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Remy, > > >> I agree we should help users come up with reasonable config values, > >> but I'm just afraid rejecting any maxThreads < 10 or < 20 will send the > >> wrong message, as if there was a bug in the way we dispatch i

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-31 Thread Jan Luehe
Remy, I agree we should help users come up with reasonable config values, but I'm just afraid rejecting any maxThreads < 10 or < 20 will send the wrong message, as if there was a bug in the way we dispatch incoming requests that requires at least 10 threads. Nope, I disagree. If maxThreads < (sa

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-31 Thread Remy Maucherat
Jan Luehe wrote: I agree we should help users come up with reasonable config values, but I'm just afraid rejecting any maxThreads < 10 or < 20 will send the wrong message, as if there was a bug in the way we dispatch incoming requests that requires at least 10 threads. Nope, I disagree. If maxThrea

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-31 Thread Jan Luehe
Remy Maucherat wrote: Jan Luehe wrote: Remy Maucherat wrote: I guess I don't understand what makes "1" bad but "2" OK. Where do we draw the line of what is a stupid config? Yes, definitely, 2 is nearly as stupid as 1. We need a reasonable minimal value for maxThreads; let's say 10 - 20. Remy,

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-31 Thread Remy Maucherat
Jan Luehe wrote: Remy Maucherat wrote: I guess I don't understand what makes "1" bad but "2" OK. Where do we draw the line of what is a stupid config? Yes, definitely, 2 is nearly as stupid as 1. We need a reasonable minimal value for maxThreads; let's say 10 - 20. Remy --

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-30 Thread Jan Luehe
Remy Maucherat wrote: Bill Barker wrote: [EMAIL PROTECTED] wrote: luehe 2003/10/30 13:01:39 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Fixed problem where if maxThreads is set to 1, ThreadPool.findControlRunnable() will log this error on the first

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-30 Thread Remy Maucherat
Bill Barker wrote: [EMAIL PROTECTED] wrote: luehe 2003/10/30 13:01:39 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Fixed problem where if maxThreads is set to 1, ThreadPool.findControlRunnable() will log this error on the first request: SEVERE: All

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-30 Thread Bill Barker
- Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Thursday, October 30, 2003 1:45 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEn

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-30 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: luehe 2003/10/30 13:01:39 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Fixed problem where if maxThreads is set to 1, ThreadPool.findControlRunnable() will log this error on the first request: SEVERE: All threads (1

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-30 Thread luehe
luehe 2003/10/30 13:01:39 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Fixed problem where if maxThreads is set to 1, ThreadPool.findControlRunnable() will log this error on the first request: SEVERE: All threads (1) are currently busy

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-22 Thread Glenn Nielsen
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: glenn 2003/10/22 06:46:28 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: SocketExceptions can occur in a networked app. No need to log a stack trace, just log the remote host name/ip and the exception

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-22 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: glenn 2003/10/22 06:46:28 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: SocketExceptions can occur in a networked app. No need to log a stack trace, just log the remote host name/ip and the exception message. Then there is

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-22 Thread glenn
glenn 2003/10/22 06:46:28 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: SocketExceptions can occur in a networked app. No need to log a stack trace, just log the remote host name/ip and the exception message. Then there is less cruft in the logs

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-12 Thread billbarker
billbarker2003/10/12 14:15:53 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Don't pretend that the tab-police won't come after you. Revision ChangesPath 1.24 +4 -4 jakarta-tomcat-connectors/util/java/org/apache/tomca

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-12 Thread billbarker
billbarker2003/10/12 14:08:22 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Don't pretend that we are going to do something if the SSL handshake fails. Revision ChangesPath 1.23 +4 -3 jakarta-tomcat-connectors/util/java/org/a

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-04 Thread Bill Barker
- Original Message - From: "Bill Barker" <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Saturday, October 04, 2003 3:10 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.j

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-04 Thread Bill Barker
- Original Message - From: <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Saturday, October 04, 2003 11:05 AM Subject: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java > remm2003/10/04 11:05:29 > > Modif

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-04 Thread remm
remm2003/10/04 11:05:29 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - No bug fix ! - Use the appropriate exception for killing the thread, - Improve ifs. - Replace while + break with a simpler (IMO) if. - Please let me know ASAP if there

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-10-03 Thread remm
remm2003/10/03 03:48:45 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - Change the way to kill the thread after a server socket restart. Revision ChangesPath 1.20 +10 -8 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-23 Thread remm
remm2003/09/23 00:09:55 Modified:util/java/org/apache/tomcat/util/net Tag: coyote_10 PoolTcpEndpoint.java Log: - Port patch. - Don't catch SocketException when setting the socket options, so that when it happens the socket is discarded right

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-22 Thread remm
remm2003/09/22 23:37:08 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - Fix logging of errors which occur in setSocketOptions. - This will also cause the connection to not be processed (which is a good thing, obviously). Revision Changes

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-18 Thread hgomez
hgomez 2003/09/18 09:09:16 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Clean Import, the first one Revision ChangesPath 1.18 +15 -10 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java Index

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-12 Thread billbarker
billbarker2003/09/12 21:01:24 Modified:util/java/org/apache/tomcat/util/net Tag: coyote_10 PoolTcpEndpoint.java Log: Port patch. Revision ChangesPath No revision No revision 1.12.2.2 +4 -4 jakarta

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-12 Thread billbarker
billbarker2003/09/12 20:59:57 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Catch all throwables when trying to close the socket. Revision ChangesPath 1.17 +4 -4 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-12 Thread Remy Maucherat
Bill Barker wrote: I don't know. From traces I saw, there are conditions where there could be no thread listening on the socket (at that point, the connector was dead, of course), while everything else in the TP was looking ok (including no deadlock). There didn't seem to be anything in the logs re

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-12 Thread Bill Barker
- Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Friday, September 12, 2003 1:38 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEnd

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-12 Thread Stefan Bodewig
On Fri, 12 Sep 2003, Bill Barker <[EMAIL PROTECTED]> wrote: > From: "Stefan Bodewig" <[EMAIL PROTECTED]> >> >> wouldn't it be better to put the "accepted = null" into a finally >> block > > Wouldn't do anything. The 'accepted' variable is local to the > stack-frame, so it goes away if I throw cle

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-12 Thread Remy Maucherat
Bill Barker wrote: On 12 Sep 2003, <[EMAIL PROTECTED]> wrote: +++ PoolTcpEndpoint.java 12 Sep 2003 03:51:36 - 1.16 @@ -389,12 +389,12 @@ if (accepted != null) { try { accepted.close(); -accepted

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-12 Thread Bill Barker
- Original Message - From: "Stefan Bodewig" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Friday, September 12, 2003 12:58 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java > On 12 Sep 2003,

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-12 Thread Stefan Bodewig
On 12 Sep 2003, <[EMAIL PROTECTED]> wrote: > +++ PoolTcpEndpoint.java 12 Sep 2003 03:51:36 - 1.16 > @@ -389,12 +389,12 @@ > if (accepted != null) { > try { > accepted.close(); > -

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-11 Thread billbarker
billbarker2003/09/11 20:53:03 Modified:util/java/org/apache/tomcat/util/net Tag: coyote_10 PoolTcpEndpoint.java Log: Make certain that we don't return a bad Socket. Fix for Bug #21763 Reported By: Rex Young [EMAIL PROTECTED] Reported By: we

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-09-11 Thread billbarker
billbarker2003/09/11 20:51:36 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Make certain that we don't return a bad Socket. Fix for Bug #21763 Reported By: Rex Young [EMAIL PROTECTED] Reported By: wendy69 [EMAIL PROTECTED] Revision Ch

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-07-26 Thread remm
remm2003/07/26 08:04:35 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - Close socket inside a finally block. Revision ChangesPath 1.15 +12 -5 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-03-26 Thread costin
costin 2003/03/26 20:08:20 Modified:util/java tomcat-util.manifest util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Fix bug that prevented clean shutdown. Remove ClassPath from manifest, added spec version and the other entries so it may be

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-03-04 Thread costin
costin 2003/03/04 10:20:36 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Reduce verbosity and add more info to the message Revision ChangesPath 1.13 +7 -5 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2003-01-01 Thread remm
remm2003/01/01 05:55:22 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - Don't check for null on the connection (it should never be null, and should be caught by the throwable and logged if it happens). - Fix a problem when using SSL: wh

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2002-12-19 Thread costin
costin 2002/12/19 07:55:46 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Fix from Michael ( with strange email address ). Declare the "running" as volatile and some code cleanups. Revision ChangesPath 1.10 +39 -44 jaka

[PATCH] PoolTcpEndpoint.java (was: Thread priority)

2002-12-19 Thread Michael
at you must have meant this: Index: PoolTcpEndpoint.java === RCS file: /home/cvspublic/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java,v retrieving revision 1.9 diff -u -r1.9 PoolTcpEndpoint.java --- PoolTc

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2002-12-18 Thread costin
costin 2002/12/18 21:31:47 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Use commons-loggign directly. This way any logger can be used ( and the same logger config ). Revision ChangesPath 1.9 +42 -25 jakarta-tomcat-connectors

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2002-11-28 Thread remm
remm2002/11/28 07:16:32 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - Small reorganization of the code so that the next accept is called sooner when not using the connection cache. Revision ChangesPath 1.8 +9 -12 jakarta

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2002-11-28 Thread remm
remm2002/11/28 03:24:29 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - Experiment with not using the pool. Revision ChangesPath 1.7 +4 -4 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2002-10-22 Thread remm
remm2002/10/22 02:42:49 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - Fix NPE (bug 13842). - Remove useless logging (maybe the hadshake failure should be an INFO). - Make sure socket is correctly closed in all cases. - Tighten up exception

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2002-10-19 Thread remm
remm2002/10/19 02:30:37 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - Attempts to address bug 13736. - Add code for recovery if the serverSocket dies. Needs testing (I tested with an exception thrown according to a random value after the socket

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2002-05-16 Thread remm
Http11Protocol.java jk/java/org/apache/jk/server JkCoyoteHandler.java util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: - Add support for a two phase protocol init (init where the port binding occurs, and start where the connector is actually started). This

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java

2002-05-15 Thread keith
keith 02/05/15 11:53:46 Modified:util/java/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Wrap acceptSocket in a try to be more robust Revision ChangesPath 1.3 +9 -4 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java

2002-02-23 Thread larryi
larryi 02/02/23 19:36:15 Modified:src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Add the port number to JVM_Bind exceptions. Submitted by: Jon Stevens Revision ChangesPath 1.17 +12 -8 jakarta-tomcat/src/share/org/apache/tomcat/util/net

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/net JSSEImplementation.java JSSESocketFactory.java JSSESupport.java PureTLSImplementation.java PureTLSSocket.java PureTLSSocketFactory.java PureTLSSupport.java SSLImplementation.java SSLSupport.java DefaultServerSocketFactory.java PoolTcpEndpoint.java ServerSocketFactory.java SSLSocketFactory.java

2001-12-06 Thread billbarker
billbarker01/12/06 20:40:06 Modified:src/share/org/apache/tomcat/util/net DefaultServerSocketFactory.java PoolTcpEndpoint.java ServerSocketFactory.java Added: src/share/org/apache/tomcat/util/net JSSEImplementation.java

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java

2001-08-30 Thread costin
costin 01/08/30 21:13:12 Modified:src/share/org/apache/tomcat/util/http MimeHeaders.java Parameters.java ServerCookie.java src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Use the newInstance method. The old one is still usable

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java

2001-08-22 Thread mmanders
mmanders01/08/22 09:58:29 Modified:src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Added code to handle shutdown a little cleaner by setting soLinger to a small value (0) just before we close the socket, and just logging any exceptions instead of doing a stacktrace

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java

2001-06-24 Thread costin
costin 01/06/24 15:44:16 Modified:src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Added the test in the base class, to avoid duplicating it in all subclasses. Revision ChangesPath 1.12 +6 -3 jakarta-tomcat/src/share/org/apache/tomcat/util/net

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java

2001-05-18 Thread larryi
PoolTcpEndpoint.java Log: Improve security by providing default bindings for Ajp connectors. Submitted by: Andrey Kartashov Revision ChangesPath 1.75 +6 -0 jakarta-tomcat/src/etc/server.xml Index: server.xml

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java

2001-04-21 Thread costin
costin 01/04/21 11:12:19 Modified:src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Stop endpoint will create a socket and connect to the listenning port, to unblock accept(). Part of 1418 fix. Revision ChangesPath 1.10 +10 -4 jakarta-tomcat

RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/service PoolTcpEndpoint.java

2001-03-20 Thread Tal Dayan
-Original Message- > From: GOMEZ Henri [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, March 20, 2001 3:28 PM > To: [EMAIL PROTECTED] > Subject: RE: cvs commit: > jakarta-tomcat/src/share/org/apache/tomcat/service PoolTcpEndpoint.java > > > I suggest you to set

RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/service PoolTcpEndpoint.java

2001-03-20 Thread GOMEZ Henri
e- >From: GOMEZ Henri >Sent: Wednesday, March 21, 2001 12:19 AM >To: '[EMAIL PROTECTED]' >Subject: RE: cvs commit: >jakarta-tomcat/src/share/org/apache/tomcat/service PoolTcpEndpoint.java > > >You we're just too fast ;-) > >What happen to ajpx connector w

RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/service PoolTcpEndpoint.java

2001-03-20 Thread GOMEZ Henri
Pierre Dac >-Original Message- >From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] >Sent: Tuesday, March 20, 2001 11:21 PM >To: [EMAIL PROTECTED] >Subject: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/service >PoolTcpEndpoint.java > > >marcsaeg01/03/20

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/service PoolTcpEndpoint.java

2001-03-20 Thread marcsaeg
marcsaeg01/03/20 14:21:28 Modified:src/share/org/apache/tomcat/service Tag: tomcat_32 PoolTcpEndpoint.java Log: Set the SO_TIMEOUT value on the accepted socket. This prevents a DOS attacked by clients opening connections and never sending any data

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java

2001-02-16 Thread costin
costin 01/02/16 23:09:02 Modified:src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java Log: Remove log messages. Revision ChangesPath 1.7 +3 -5 jakarta-tomcat/src/share/org/apache/tomcat/util/net/PoolTcpEndpoint.java Index: PoolTcpEndpoint.java

Re: PoolTcpEndpoint.java

2000-12-11 Thread Glenn Nielsen
I only applied a small patch to PoolTcpEndpoint.java. I am directing this to the tomcat-dev list, there are alot of different people who work on the tomcat source, so this type of question is best directed to the list. Glenn Boon Hian Tek wrote: > > Hi Glenn, > > I saw that you w

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java

2000-12-07 Thread costin
/apache/tomcat/util/log LogEntry.java QueueLogger.java src/share/org/apache/tomcat/util/net PoolTcpEndpoint.java Added: src/share/org/apache/tomcat/util/collections EmptyEnumeration.java Queue.java SimplePool.java Removed: src

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/service LocalStrings.properties PoolTcpEndpoint.java

2000-11-17 Thread craigmcc
craigmcc00/11/17 15:19:55 Modified:src/share/org/apache/tomcat/service Tag: tomcat_32 LocalStrings.properties PoolTcpEndpoint.java Log: (Porting a change from the 3.3 tree) If Tomcat is run under a security manager, and a remote client tries to