Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor28-must
-+-

Comment (by arlolra):

 > Unfortunately, there seems to be some permissioning issue with the
 icons/ folder. Trying to fix that ...

 It was an aliasing issue (hat tip to @boklm).  There's a default alias for
 `icons/`, https://www.electrictoolbox.com/apache-icons-directory/

 Fixed in (and deployed),
 https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/commit/?id=b324d9d42fff09e7db0f2fe2657a2265a3b39271

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor28-must
-+-

Comment (by arlolra):

 > merged in 8de6e26c597edadac633ae8bed163893f4d932e2

 Thanks, I deployed these changes (which you should now also be able to do,
 see comment:6:ticket:31143)

 Unfortunately, there seems to be some permissioning issue with the
 `icons/` folder.  Trying to fix that ...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by cohosh):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged in `8de6e26c597edadac633ae8bed163893f4d932e2`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by cohosh):

 * status:  needs_revision => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor28-must
-+-

Comment (by cohosh):

 Replying to [comment:26 arlolra]:
 > > My host machine is ubuntu 18.04 with node v10.16.0, and I ran it in
 snowbox which is debian with node v12.1.0
 >
 > I see, this should fix it,
 >
 
https://github.com/keroserene/snowflake/commit/0aa5ee24d4e4f7fac8a4f63f1917ab2fa34330eb
 Yup, works now. Thanks!
 >
 > I also added a commit for #31222 in,
 >
 
https://github.com/keroserene/snowflake/commit/8385e7c2dab3e587ce63cc522d3a667b02c949b8
 >
 Awesome, thanks for doing that.
 > If you're happy with this branch, please merge it.  I'll be away for a
 few days
 >
 Okay, sounds good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor28-must
-+-

Comment (by arlolra):

 > My host machine is ubuntu 18.04 with node v10.16.0, and I ran it in
 snowbox which is debian with node v12.1.0

 I see, this should fix it,
 
https://github.com/keroserene/snowflake/commit/0aa5ee24d4e4f7fac8a4f63f1917ab2fa34330eb

 I also added a commit for #31222 in,
 
https://github.com/keroserene/snowflake/commit/8385e7c2dab3e587ce63cc522d3a667b02c949b8

 If you're happy with this branch, please merge it.  I'll be away for a few
 days

 > Ah, my bad I keep forgetting there's another README in the webext
 directory.

 Maybe this is an indication that we should move the contents to the one in
 the higher directory.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor28-must
-+-

Comment (by cohosh):

 Replying to [comment:24 arlolra]:
 > > It's possible this is just a problem for me locally. I'm using npm
 version '6.9.0'
 >
 > I installed that version of npm and it seemed to work for me.  What
 version of node?  It's odd that invoking the command manually wasn't an
 issue.  I should test in a different OS.
 >
 My host machine is ubuntu 18.04 with node v10.16.0, and I ran it in
 snowbox which is debian with node v12.1.0
 > > Also, maybe not as a part of these changes though, we should probably
 update the README with insructions to build the webextension
 >
 > They are here but can certainly be improved,
 > https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/tree/proxy/webext/README.md
 Ah, my bad I keep forgetting there's another README in the webext
 directory.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor28-must
-+-

Comment (by arlolra):

 > is this the right way to build the webextenson?

 Yes

 > It's possible this is just a problem for me locally. I'm using npm
 version '6.9.0'

 I installed that version of npm and it seemed to work for me.  What
 version of node?  It's odd that invoking the command manually wasn't an
 issue.  I should test in a different OS.

 > Also, maybe not as a part of these changes though, we should probably
 update the README with insructions to build the webextension

 They are here but can certainly be improved,
 https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/tree/proxy/webext/README.md

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor28-must
-+-

Comment (by cohosh):

 Replying to [comment:22 arlolra]:
 > > When I run it manually it works, but when I ran npm run webext to
 build it, the files didn't copy and it fails with the error
 >
 > Where are getting this error?  I'm not able to reproduce it.
 If I clean the `webext` directory to remove all nontracked files, and then
 run `npm run webext`, the `embed.css` and `embed.html` files don't copy
 over... is this the right way to build the webextenson? It's possible this
 is just a problem for me locally. I'm using npm version '6.9.0'

 Also, maybe not as a part of these changes though, we should probably
 update the README with insructions to build the webextension
 >
 > > A few comments on the refactoring:
 >
 > Added another commit to the branch to address this,
 >
 
https://github.com/keroserene/snowflake/commit/f9c515cbdd302097245fd85231dc34c06d234802
 >
 > I left `UI.prototype.active = false;` where it was since it's used in
 both the badge and webextension.
 Cool, looks good to me!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor28-must
-+-

Comment (by arlolra):

 > Smaller commits in the future would be easier to review for changes like
 this where it's hard to piece together which code was just moved around
 and where the logic changed.

 Sorry, I was working on this on the last day of the meeting and just
 pushed what I had since it wasn't clear when I'd be able to get back to
 it.

 > When I run it manually it works, but when I ran npm run webext to build
 it, the files didn't copy and it fails with the error

 Where are getting this error?  I'm not able to reproduce it.

 > A few comments on the refactoring:

 Added another commit to the branch to address this,
 
https://github.com/keroserene/snowflake/commit/f9c515cbdd302097245fd85231dc34c06d234802

 I left `UI.prototype.active = false;` where it was since it's used in both
 the badge and webextension.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor28-must
-+-

Comment (by cohosh):

 Overall, I like the code changes and refactors. Smaller commits in the
 future would be easier to review for changes like this where it's hard to
 piece together which code was just moved around and where the logic
 changed.

 It looks like `cp -r static/{embed.html,embed.css,popup.js,icons} webext/`
 isn't running properly for some reason. When I run it manually it works,
 but when I ran `npm run webext` to build it, the files didn't copy and it
 fails with the error
 {{{
 The character encoding of the HTML document was not declared. The document
 will render with garbled text in some browser configurations if the
 document contains characters from outside the US-ASCII range. The
 character encoding of the page must be declared in the document or in the
 transfer protocol.
 }}}

 A few comments on the refactoring:
 - WebExtUI and BadgeUI classes were moved to init-webext.js and init-
 badge.js, respectively, but DebugUI is still in ui.js. To follow the
 pattern, should DebugUI be moved to init-test.js? That leaves ui.js pretty
 sparse...
 -
 {{{
 UI.prototype.active = false;

 UI.prototype.enabled = true;
 }}}
  This code might be specific to just WebExtUI. If so we should probably
 move it into that class or init-webext.js.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by cohosh):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:  cohosh   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by cohosh):

 * reviewer:   => cohosh


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by arlolra):

 * cc: cohosh (added)


Comment:

 > It's rather invasive and doesn't offer much in terms of explanation,
 sorry.

 Ok, looking this over, the goal was to,

 * reuse the html and css from the webextension for the badge
 * move setting the cookie over to the badge, using the on/off toggle (as
 suggested in this ticket)
 * consolidate the use specific code in one place (init, ui, etc)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-+-
 Reporter:  cypherpunks3 |  Owner:  arlolra
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Circumvention/Snowflake  |Version:
 Severity:  Major| Resolution:
 Keywords:  snowflake, ux-team, anti-|  Actual Points:
  censorship-roadmap-july|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor28-must
-+-
Changes (by gaba):

 * keywords:  snowflake, ux-team, ex-sponsor-19 => snowflake, ux-team, anti-
 censorship-roadmap-july


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
---+---
 Reporter:  cypherpunks3   |  Owner:  arlolra
 Type:  defect | Status:
   |  needs_review
 Priority:  High   |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Major  | Resolution:
 Keywords:  snowflake, ux-team, ex-sponsor-19  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by arlolra):

 * status:  assigned => needs_review


Comment:

 Here's a patch that pretty much gets this done,
 
https://github.com/keroserene/snowflake/commit/12e7b92b4c59888cf43d2e1f0e5518df02b72bdc

 It's rather invasive and doesn't offer much in terms of explanation,
 sorry.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
---+---
 Reporter:  cypherpunks3   |  Owner:  arlolra
 Type:  defect | Status:  assigned
 Priority:  High   |  Milestone:
Component:  Circumvention/Snowflake|Version:
 Severity:  Major  | Resolution:
 Keywords:  snowflake, ux-team, ex-sponsor-19  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
   |  Sponsor28-must
---+---
Changes (by arlolra):

 * owner:  (none) => arlolra
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs