[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-09-20 Thread Pat McGowan
** Changed in: canonical-devices-system-image Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity-scopes-api in Ubuntu. https://bugs.launchpad.net/bugs/1531913 Title: Fallback

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-08-16 Thread Michał Sawicz
** Changed in: canonical-devices-system-image Milestone: backlog => 13 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity-scopes-api in Ubuntu. https://bugs.launchpad.net/bugs/1531913 Title: Fallback image not shown

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-02-15 Thread Michał Sawicz
** Changed in: canonical-devices-system-image Status: Confirmed => Fix Committed ** Changed in: unity-scopes-api (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-02-15 Thread Launchpad Bug Tracker
** Branch linked: lp:~ci-train-bot/unity8/unity8-ubuntu-xenial- landing-064 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity-scopes-api in Ubuntu. https://bugs.launchpad.net/bugs/1531913 Title: Fallback image not

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-02-15 Thread Launchpad Bug Tracker
This bug was fixed in the package unity8 - 8.11+16.04.20160212-0ubuntu1 --- unity8 (8.11+16.04.20160212-0ubuntu1) xenial; urgency=medium [ Albert Astals Cid ] * Do not use components in card creator generated code * Forward the makesurevisible signal from the inner preview

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-28 Thread Michi Henning
** Changed in: unity-scopes-api (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity-scopes-api in Ubuntu. https://bugs.launchpad.net/bugs/1531913 Title: Fallback image

Re: [Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-18 Thread Michał Sawicz
W dniu 17.01.2016 o 16:06, Michi Henning pisze: > What's the problem with doc? If it isn't right, I'll fix it. The question is whether fallback was supposed to be used when the scope did not send a url for the image, vs. if whatever it did send failed to load. -- You received this bug

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-18 Thread Michi Henning
If the card requires an image and the scope doesn't provide one, the fallback should be shown. If the scope does specify an image, but it doesn't load, the fallback should be shown too. That makes the most sense to me. ** Changed in: unity-scopes-api (Ubuntu) Assignee: (unassigned) =>

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-18 Thread Michi Henning
I've pushed an MR with the doc update for scopes API here: https://code.launchpad.net/~michihenning/unity-scopes-api/doc- fix/+merge/283001 ** Changed in: unity-scopes-api (Ubuntu) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-18 Thread Albert Astals Cid
** Changed in: unity8 (Ubuntu) Status: Opinion => In Progress ** Branch linked: lp:~michihenning/unity-scopes-api/doc-fix -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity-scopes-api in Ubuntu.

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-17 Thread Michi Henning
The intention was that a scope can specify a specific fallback image. That image should be shown when the normal image load returns an error or an empty image (zero-length ByteArray, or whatever type it is). This allows the scope to specify a specific fallback image that might be needed to keep

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-15 Thread Michał Sawicz
Ultimately it's the call of whoever wrote the API and what was their intention. I tend to agree that the fallback is only meant to deal with cases where the scope can't do anything about it. When sending empty, it might very well send the fallback URL instead. What's the argument against the

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-08 Thread Albert Astals Cid
> If it's the image to be shown when there is an error loading the image, then > the API is wrong, No, it is exactly that. That is the reason why fallback was introduced for, in case the art image fails to load (server is overloaded, resource is gone, etc) and then we show a fallback. It is

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-08 Thread Michael Zanetti
yeah... I tend to agree that the fallback should be loaded if the specified artwork fails to load. if the scope returns a empty icon, that won't produce a failure. The dash can display what the scope requested just fine. No need for a fallback. I totally get Rodney's point too, in the end it's

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-08 Thread Albert Astals Cid
The new code is at https://code.launchpad.net/~aacid/unity8/fallback_for_empty/+merge/282002 I still disagree with this solution and with Rodney expectation of what the fallback image does given how the API is documented, but it's not my call to decide if this goes in or not. ** Changed in:

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-07 Thread Michał Sawicz
** Changed in: unity8 (Ubuntu) Status: New => Triaged ** Changed in: unity8 (Ubuntu) Importance: Undecided => Medium ** Changed in: unity8 (Ubuntu) Assignee: (unassigned) => Albert Astals Cid (aacid) -- You received this bug notification because you are a member of Ubuntu Touch

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-07 Thread Albert Astals Cid
Doing that will make it not possible to actually specify a blank artwork if we ever want one. -> if we specify a fallback image -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity8 in Ubuntu.

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-07 Thread Albert Astals Cid
Doing that will make it not possible to actually specify a blank artwork if we ever want one. Whether that is useful or not I don't know :D -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unity8 in Ubuntu.

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-07 Thread Rodney Dawes
Specifying a blank artwork is still possible, and still not sensible. One can always specify a 1x1 transparent image as the artwork for intentionally blank space. :) We don't detect that we are sending an empty image. We just specify the fallback and expect it to work as a fallback should. If a

[Touch-packages] [Bug 1531913] Re: Fallback image not shown when no image specified

2016-01-07 Thread Pat McGowan
** Changed in: canonical-devices-system-image Importance: Undecided => Medium ** Changed in: canonical-devices-system-image Status: New => Confirmed ** Changed in: canonical-devices-system-image Milestone: None => backlog ** Changed in: canonical-devices-system-image