[Toybox] [PATCH] nl: nl -v

Implement nl -v supporting negative and zero starting values. --- ../toybox-0.8.1-bak/tests/nl.test 2019-06-29 13:17:36.381513304 +0100 +++ ./tests/nl.test 2019-07-03 09:30:24.221718523 +0100 @@ -39,8 +39,13 @@ " one\n 1ookboing\n 2ooksproingy\n" \ ""

Re: [Toybox] [PATCH] Add ifplugd

netlink/rtnetlink. I'll take a look at extending mdev to support RTM_GETLINK messages. For now consider this patch abandoned and I'll come back after I read up a bit more. - Eric On Mon, May 11, 2020 at 8:32 PM Rob Landley wrote: > On 5/10/20 1:34 PM, Eric Molitor wrote: > >

[Toybox] [PATCH 3/3] Add support for mss, win and irtt to new netlink based display_routes

--- toys/pending/route.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/toys/pending/route.c b/toys/pending/route.c index 62fde509..4c673172 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -197,8 +197,13 @@ static void

[Toybox] [PATCH 1/3] Add xsend, xrecv and send_nlrtmsg

--- toys/pending/route.c | 32 1 file changed, 32 insertions(+) diff --git a/toys/pending/route.c b/toys/pending/route.c index b4e7ea0d..562e5ecd 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -49,6 +49,7 @@ config ROUTE #define FOR_route

Re: [Toybox] [PATCH] Fix address family help text

, May 17, 2020 at 12:06 PM Rob Landley wrote: > On 5/17/20 5:08 AM, Eric Molitor wrote: > > I'll send over another set of changes shortly that refactors > display_routes to > > use netlink. The changes will probably be controversial as they increase > code > > size a

[Toybox] [PATCH 4/4] Merge IPv6 support into display_routes

--- toys/pending/route.c | 141 --- 1 file changed, 51 insertions(+), 90 deletions(-) diff --git a/toys/pending/route.c b/toys/pending/route.c index 4c673172..e7de50bd 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -145,20 +145,7 @@ static

[Toybox] [PATCH] Add ifplugd

A simple implementation of ifplugd that I'm using on a few personal projects. I've cleaned it up and attempted to mostly adhere to the toybox coding style. - Eric ifplugd.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net

[Toybox] [PATCH] route should be in sbin

Trivial patch to move route to sbin. - Eric --- toybox-clean/toys/pending/route.c 2020-05-11 14:13:45.52000 +0100 +++ toybox/toys/pending/route.c 2020-05-11 14:13:59.33000 +0100 @@ -12,7 +12,7 @@ * * mod dyn reinstate metric netmask gw mss window irtt dev -USE_ROUTE(NEWTOY(route,

[Toybox] [PATCH] Fix address family help text

--- toys/pending/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toys/pending/route.c b/toys/pending/route.c index 1fd3b55f..b4e7ea0d 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -17,7 +17,7 @@ config ROUTE bool "route" default n help -

[Toybox] [PATCH] Add RTA_CACHEINFO support and resolve remaining todo items in display_routes

--- toys/pending/route.c | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/toys/pending/route.c b/toys/pending/route.c index e7de50bd..fba5f717 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -151,7 +151,6 @@ static void

[Toybox] [PATCH 3/3] First pass of adding RTNetlink setroute support

--- toys/pending/route.c | 221 +-- 1 file changed, 127 insertions(+), 94 deletions(-) diff --git a/toys/pending/route.c b/toys/pending/route.c index cc6ecd54..a24e146e 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -88,6 +88,18 @@ int

[Toybox] [PATCH 2/3] Remove send_nlrtmsg embedding call into display_route as it is only used here

--- toys/pending/route.c | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/toys/pending/route.c b/toys/pending/route.c index 2de3e831..cc6ecd54 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -88,24 +88,6 @@ int xrecv(int

[Toybox] [PATCH 1/3] Use perror_exit to replace exit calls.

--- toys/pending/route.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/toys/pending/route.c b/toys/pending/route.c index fba5f717..2de3e831 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -77,13 +77,13 @@ static struct _arglist arglist2[] = {

[Toybox] [PATCH 2/2] Cleanup setRoute and resolve warnings about alignment and NULL args

--- toys/pending/route.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/toys/pending/route.c b/toys/pending/route.c index 9c95d996..b37d3ecd 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -290,20 +290,17 @@ static void setroute(sa_family_t

[Toybox] [PATCH 1/2] Implement hostname lookups in display_routes

--- toys/pending/route.c | 46 +++- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/toys/pending/route.c b/toys/pending/route.c index 39ba160b..9c95d996 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -94,6 +94,18 @@ void

Re: [Toybox] [PATCH 2/2] Cleanup setRoute and resolve warnings about alignment and NULL args

Crap, please don't apply as this is broken for IPv6. I will rework them and resubmit a new set of patches. - Eric On Sun, May 31, 2020 at 12:26 PM Eric Molitor wrote: > --- > toys/pending/route.c | 17 +++-- > 1 file changed, 7 insertions(+), 10 deletions(-) > > di

[Toybox] [PATCH 2/4] Cleanup setRoute and resolve warnings about alignment and NULL args

--- toys/pending/route.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/toys/pending/route.c b/toys/pending/route.c index 9c95d996..b37d3ecd 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -290,20 +290,17 @@ static void setroute(sa_family_t

[Toybox] [PATCH 1/4] Implement hostname lookups in display_routes

--- toys/pending/route.c | 46 +++- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/toys/pending/route.c b/toys/pending/route.c index 39ba160b..9c95d996 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -94,6 +94,18 @@ void

[Toybox] [PATCH 3/4] Autodetect if IPv6 address is used and display warning

* Copyright 2013 Kyungwan Han + * Copyright 2020 Eric Molitor * * No Standard * - * TODO: autodetect -net -host target dev -A (but complain) * route add -net target 10.0.0.0 netmask 255.0.0.0 dev eth0 * route del delete * delete net route, must match netmask, informative error message

[Toybox] [PATCH 4/4] Fix AF_INET6 hostlookups

--- toys/pending/route.c | 49 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/toys/pending/route.c b/toys/pending/route.c index f7592312..99ba946e 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -94,19 +94,14 @@ void

[Toybox] [PATCH 1/2] Merge ipv6 setroute into a single function

--- toys/pending/route.c | 110 +-- 1 file changed, 2 insertions(+), 108 deletions(-) diff --git a/toys/pending/route.c b/toys/pending/route.c index a24e146e..0acca6c8 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -120,25 +120,6 @@ static

[Toybox] [PATCH 2/2] Remove unused include and constants

--- toys/pending/route.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/toys/pending/route.c b/toys/pending/route.c index 0acca6c8..0d5e4449 100644 --- a/toys/pending/route.c +++ b/toys/pending/route.c @@ -48,20 +48,14 @@ config ROUTE #define FOR_route #include "toys.h" -#include

Re: [Toybox] Horrible microsoft github tests spamming me.

You can download the raw logs by using the "triple dot" menu to the right of the search logs field. This may or may not help avoid the issues with the javascript on that page. If you add Elliott as a collaborator you can configure the notification route to go to him instead of you. (You can also

Re: [Toybox] Horrible microsoft github tests spamming me.

Make sure you are logged into github and go to https://github.com/settings/notifications near the middle of that page you will find the notification settings for GitHub actions allowing you to disable and configure them as necessary. For Rob, you probably want to uncheck all the github action

Re: [Toybox] GitHub Action Example

We are extremely busy at work so coming back to this thread later than I intended. I also have mixed feelings about MSFT and GithHub but in some ways why not take advantage of them and exploit what they are offering. I don't believe there is any significant coupling to MSFT and it's a relatively

[Toybox] [PATCH] Add github action support to build with MacOS and Ubuntu * Builds at 02:00 each day * Builds on each push

--- .github/workflows/toybox.yml | 36 1 file changed, 36 insertions(+) create mode 100644 .github/workflows/toybox.yml diff --git a/.github/workflows/toybox.yml b/.github/workflows/toybox.yml new file mode 100644 index ..b3b16676 --- /dev/null +++

Re: [Toybox] GitHub Action Example

a few of the Alpine tests are failing as some of the tests depend upon privileges that are not available when running in a container. - the other guy On Sat, Jun 20, 2020 at 1:36 AM enh wrote: > On Wed, Jun 17, 2020 at 3:36 PM Eric Molitor wrote: > > > > We are extremely busy at

Re: [Toybox] [PATCH] Add github action support to build with MacOS and Ubuntu * Builds at 02:00 each day * Builds on each push

:) On Sun, Jun 28, 2020 at 1:54 AM Rob Landley wrote: > On 6/25/20 7:47 AM, Eric Molitor wrote: > > * MacOS and Ubuntu builds run on every push *and* at 02:00 UTC (2:00 am > UTC). > > * Emails are only sent on build or test failure to the project > collaborators. >

Re: [Toybox] [PATCH] Add github action support to build with MacOS and Ubuntu * Builds at 02:00 each day * Builds on each push

gt; page on > this?) > > Rob > > On 6/24/20 8:00 AM, Eric Molitor wrote: > > --- > > .github/workflows/toybox.yml | 36 > > 1 file changed, 36 insertions(+) > > create mode 100644 .github/workflows/toybox.yml > > >

[Toybox] GitHub Action Example

Hi Rob, Here is an example github action building toybox and running tests on MacOS, Ubuntu and Alpine. It builds nightly at 2:00am and on each push and pull request. While I'm not a huge fan of proprietary CI systems GitHub isn't too invasive and supports MacOS. You can see an example of the

Re: [Toybox] [PATCH 1/4] Implement hostname lookups in display_routes

An example is probably the simplest option. I'll create a fork and share the changelist with you. - Eric On Wed, Jun 3, 2020 at 6:12 AM Rob Landley wrote: > On 6/2/20 4:13 PM, Eric Molitor wrote: > > Mmh, I just switched my dev machine from Alpine to Ubuntu befor

Re: [Toybox] GitHub Action Example

Would aarch64 builds on Ubuntu and Alpine be useful? That will be slightly more complex to setup but is possible. > it seems like your setup is running on a cron-like timer? is there a way > to say "on every push" instead? > > There are three build triggers in the configuration, cron, push on

Re: [Toybox] [PATCH 1/4] Implement hostname lookups in display_routes

Mmh, I just switched my dev machine from Alpine to Ubuntu before working on this, normally I would have caught this. Rob, what are your thoughts on using GitHub actions to build toybox on Alpine, Ubuntu and MacOS and running through the test suite? This would have caught this earlier. I'm happy

Re: [Toybox] [PATCH 1/2] Add MacOS 11.0 to CI Builds

y Mac OS 11 is showing up twice in the > github CI UI, once as a success and once as a failure? > https://github.com/landley/toybox/runs/1655239181 for example. > > On Wed, Jan 6, 2021 at 4:42 AM Eric Molitor wrote: > >> Welcome, I had a break over the holidays long enough to quic

[Toybox] [PATCH 1/2] Add MacOS 11.0 to CI Builds

--- .github/workflows/toybox.yml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/.github/workflows/toybox.yml b/.github/workflows/toybox.yml index a1ad1773..c6fd9d92 100644 --- a/.github/workflows/toybox.yml +++ b/.github/workflows/toybox.yml @@ -7,6 +7,20 @@ on:

[Toybox] [PATCH 2/2] Capitalise Toybox name in CI Builds

--- .github/workflows/toybox.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/toybox.yml b/.github/workflows/toybox.yml index c6fd9d92..037018c3 100644 --- a/.github/workflows/toybox.yml +++ b/.github/workflows/toybox.yml @@ -1,4 +1,4 @@ -name: toybox CI

Re: [Toybox] [PATCH 2/2] Capitalise Toybox name in CI Builds

Thanks, I forgot about that. - Eric On Fri, Dec 25, 2020 at 6:46 AM Rob Landley wrote: > On 12/24/20 6:36 AM, Eric Molitor wrote: > > --- > > .github/workflows/toybox.yml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/.gith

Re: [Toybox] [PATCH 1/2] Add MacOS 11.0 to CI Builds

. - Eric On Tue, Jan 5, 2021 at 10:26 PM enh wrote: > awesome, thanks! > > (i'm not allowed to update my work mac yet, so i can only test 10.15 for > now...) > > On Thu, Dec 24, 2020 at 4:36 AM Eric Molitor wrote: > >> --- >> .github/workflows/toybox.yml | 14

Re: [Toybox] [PATCH] wget: add TLS support

I need to sort out a few more defects but will try both BoringSSL and the FIPS Version of OpenSSL 3.0. In theory both should "just work" with this integration. Albeit with the caveat that FIPS 140-2 verification ended last mouth and I don't believe either BoringSSL or OpenSSL 3 are FIPS 140-3

[Toybox] [PATCH] wget: add TLS support

Attached is a relatively quick and certainly dirty patch to wget adding TLS support via libtls. I threw this together on a plane but it's working reasonably well for me allowing me to remove Curl/libcurl on a few projects. I will submit further patches to clean up this toy as it's in pretty dire

Re: [Toybox] [PATCH] wget: add TLS support

a look at whether it's feasible to hook up BearSSL to the existing crypto abstraction - Eric On Tue, Oct 19, 2021 at 5:35 AM Rob Landley wrote: > On 10/17/21 2:48 PM, Eric Molitor wrote: > > Let me take a look at signify I'll also send the missing part of the > patch with >

Re: [Toybox] [PATCH] wget: add TLS support

integrating for everyone. - Eric On Sun, 17 Oct 2021, 8:04 pm Rob Landley, wrote: > On 10/17/21 8:44 AM, Eric Molitor wrote: > > Attached is a relatively quick and certainly dirty patch to wget adding > TLS > > support via libtls. > > > https://landley.net/toybox/design.html#:

Re: [Toybox] [PATCH] wget: add TLS support

but this patch is based on your local git so should cleanly apply. - Eric On Sun, Oct 17, 2021 at 8:48 PM Eric Molitor wrote: > Let me take a look at signify I'll also send the missing part of the patch > with -ltls shortly. > > Alpine has libtls, either the openssl port in the libr

[Toybox] FTP Fixes

Hi Rob, I was unclear if you were going to go through and cleanup the ftp toy or whether you wanted me to rev the patches to simplify/remove strrchr? - Eric ___ Toybox mailing list Toybox@lists.landley.net

Re: [Toybox] WGET: OpenSSL and BoringSSL Patch

the regular build yet, i > assume we'll turn it on some day.) > > > 1. which rob _said_ he'd committed, but i think he forgot to `git push` > --- i applied the patch manually. > 2. despite being comically anachronistic, at least the part i'm familiar > with :-( > > On

Re: [Toybox] ftpget: Remove

Ok, I'll take a look at fixing ftpget as there are still users out there. - Eric On Sat, 30 Oct 2021, 4:56 am David Seikel, wrote: > On 2021-10-29 17:22:33, Eric Molitor wrote: > >I genuinely had trouble finding an FTP server to test until I > remembered > >those two

[Toybox] ftpget - Fixes and minor new features.

Attention should be paid to the change to portability.h. I believe this is the correct way to expose memrchr for glibc. I've tested it and it works with glibc but I primarily use MUSL. - Eric 0002-ftpget-Use-modern-flag-macro.patch Description: Binary data

Re: [Toybox] [PATCH] wget: cleanup, add support for file disposition and fix HTTP protocol version

Final patch which adds TLS support. - Eric On Wed, Oct 27, 2021 at 3:42 PM Eric Molitor wrote: > I missed this change so creating a second patch to apply after the HTTP > 1.1 patch is applied. > > - Eric > > On Wed, Oct 27, 2021 at 1:58 PM Eric Molitor wrote: > >>

Re: [Toybox] [PATCH] wget: cleanup, add support for file disposition and fix HTTP protocol version

Yeah that would break. Let me take a look to figure out a better way to handle the libraries. - Eric On Thu, 28 Oct 2021, 6:50 am Rob Landley, wrote: > On 10/27/21 11:58 AM, Eric Molitor wrote: > > Final patch which adds TLS support. > > > > - Eric > > Hmmm, the li

Re: [Toybox] [PATCH] wget: cleanup, add support for file disposition and fix HTTP protocol version

, 2021 at 8:17 AM Eric Molitor wrote: > Let me clean this up first and do a bit more testing to sort the libraries > out. Yeah BoringSSL uses the same symbols as older OpenSSL. If you do want > to give it a whirl there is a new experimental WGET_TLS suboption to enable > in addi

Re: [Toybox] [PATCH] wget: cleanup, add support for file disposition and fix HTTP protocol version

ct 27, 2021, 22:50 Rob Landley wrote: > >> On 10/27/21 11:58 AM, Eric Molitor wrote: >> > Final patch which adds TLS support. >> > >> > - Eric >> >> Hmmm, the lib stuff is awkward. (If you have more than one installed, I >> think it >&g

[Toybox] WGET: OpenSSL and BoringSSL Patch

Attached is a reworked patch which adds OpenSSL and BoringSSL support to wget. It avoids the use of OpenSSL's IO abstractions and uses default settings which should be sensible on any modern OpenSSL (1.1+) or BoringSSL version. I tested it with the latest version of BoringSSL but it should also

[Toybox] ftpget: Remove

While looking at adding ftp support back into wget I realised that the ftpget toy is broken. When testing using the ftp.gnu.org or xmlsoft.org ftp sites toybox ftpget makes incorrect assumptions about the FTP protocol and fails. In theory this could be fixed but why? Unless someone objects sending

Re: [Toybox] [PATCH] wget: cleanup, add support for file disposition and fix HTTP protocol version

Ok this annoyed me so I just added direct OpenSSL support parallel to the LibTLS support. Elliot, the OpenSSL version should work with the latest versions of BoringSSL that Android is using. - Eric On Thu, Oct 28, 2021 at 1:19 PM Eric Molitor wrote: > Annoyingly libretls requires open

Re: [Toybox] [PATCH] wget: cleanup, add support for file disposition and fix HTTP protocol version

the OpenSSL API's. - Eric On Thu, Oct 28, 2021 at 10:59 AM Eric Molitor wrote: > Reworked TLS patch. This limits the make.sh change to just tls which > should resolve any concerns about multiple libraries. This also folds in a > few fixes I've found while testing. Elliot this sh

Re: [Toybox] ftpget: Remove

> (interesting that gnu sends you to an https server suggesting you update > any scripts before they remove ftp completely [without giving a specific > deadline], but libxml2 is basically just broken with current browsers.) > > On Fri, Oct 29, 2021 at 7:34 AM Eric Molitor wrote: &g

Re: [Toybox] [PATCH] wget: cleanup, add support for file disposition and fix HTTP protocol version

, not been the case. But for more recent versions of OpenSSL (1.1.1b and higher) is reasonably safe. This is also using the BIO abstraction which is the simplest "modern" way to hold OpenSSL correctly that I know of. - Eric On Thu, Oct 28, 2021 at 6:12 PM Rob Landley wrote: > On 10/28/21

Re: [Toybox] [PATCH] wget: cleanup, add support for file disposition and fix HTTP protocol version

This adds in error handling and makes the two options mutually exclusive. On Thu, Oct 28, 2021 at 3:57 PM Eric Molitor wrote: > Ok this annoyed me so I just added direct OpenSSL support parallel to the > LibTLS support. Elliot, the OpenSSL version should work with the latest >

Re: [Toybox] [PATCH] wget: cleanup, add support for file disposition and fix HTTP protocol version

Attached is a patch which fixes the ifdefs. I'll spend a bit of time reworking the OpenSSL patch and resubmit it in a new thread. On Thu, Oct 28, 2021 at 6:33 PM Eric Molitor wrote: > It's very contrarian but I like ifdefs indented like this. But this isn't > my code base so let me

Re: [Toybox] WGET: OpenSSL and BoringSSL Patch

, wrote: > On 10/29/21 7:03 AM, Eric Molitor wrote: > > Attached is a reworked patch which adds OpenSSL and BoringSSL support to > wget. > > It avoids the use of OpenSSL's IO abstractions and uses default settings > which > > should be sensible on any modern OpenSSL (1.1+) or

[Toybox] [PATCH] wget: cleanup, add support for file disposition and fix HTTP protocol version

Attached is an initial cleanup of wget. This addresses a number of defects with the existing implementation and generally cleans up the code. I've squashed the commits but can provide a more incremental set of patches if desired. I have two more pending changes which correctly add HTTP 1.1

[Toybox] wget add back support for ftp urls

This change adds back support in wget for ftp urls. - Eric 0001-wget-Add-support-for-ftp-urls.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] ftpget - Fixes and minor new features.

Aye, the backside of FTP can't come soon enough. Even sftp, basically FTP protocol over SSH, needs to die. - Eric On Sat, 6 Nov 2021, 11:29 pm Rob Landley, wrote: > On 11/5/21 11:54 PM, Rob Landley wrote: > > On 11/2/21 2:00 PM, Eric Molitor wrote: > >> Attention should be

Re: [Toybox] [PATCH] wget: cleanup, add support for file disposition and fix HTTP protocol version

that the first read would contain the complete headers. - Eric On Wed, Oct 27, 2021 at 4:30 AM Rob Landley wrote: > On 10/26/21 9:05 AM, Eric Molitor wrote: > > Attached is an initial cleanup of wget. This addresses a number of > defects with > > the existing implementation and generally

Re: [Toybox] [PATCH] wget: cleanup, add support for file disposition and fix HTTP protocol version

I missed this change so creating a second patch to apply after the HTTP 1.1 patch is applied. - Eric On Wed, Oct 27, 2021 at 1:58 PM Eric Molitor wrote: > Agree, that could have been better. The attached patch adds HTTP 1.1 and > chunked encoding support. It also cleans up and im

Re: [Toybox] debian patch applying $CFLAGS to $HOSTCC

On Wed, 14 Sept 2022, 7:11 am Rob Landley, wrote: > I already said the whole directory needs to be completely replaced, that's > inching up the todo list...) > I'm not usually a fan of +1 responses but modernizing kconfig would fix some annoyances for me and likely make it a bit easier to

[Toybox] [PATCH] BLKID: Add support for iso9660

Add iso9660 support to blkid. Rather than attach a binary for the test generate the blkid test image file in tests/files/blkid via xorriso -as mkisofs -V 'MYISO' -o iso --modification-date=1970010212554200 /dev/null bzip2 iso - Eric --- tests/blkid.test | 3 +++ toys/other/blkid.c | 12

Re: [Toybox] [PATCH] BLKID: Add support for iso9660

Something got confused with the git comment on that. To generate the test image file run... xorriso -as mkisofs -V 'MYISO' -o iso \ --modification-date=1970010212554200 \ /dev/null bzip2 iso On Mon, 6 Feb 2023 at 14:53, Eric Molitor wrote: > Add iso9660 support to blkid. Rather t

[Toybox] [PATCH 2/2] BLKID: Fix SEC_TYPE for vfat and iso9660

Move SEC_TYPE for vfat to not display when searching by label Remove SEC_TYPE from iso9660 --- tests/blkid.test | 6 +++--- toys/other/blkid.c | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/blkid.test b/tests/blkid.test index 4c385dcb..37bce67a 100755 ---

[Toybox] [PATCH] Fix SEC_TYPE for vfat and iso9660

Actually you were spot on with your feedback. I also checked with e2fsprogs, util-linux and busy box blkid and this is the most consistent ordering of output for SEC_TYPE. - Eric --- tests/blkid.test | 2 +- toys/other/blkid.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [Toybox] [PATCH] Fix SEC_TYPE for vfat and iso9660

SFT and everyone treats it as such and ignores the label on the boot sector. http://www.c-jump.com/CIS24/Slides/FAT/FAT.html https://lkml.org/lkml/2017/10/4/512 - Eric On Sat, 11 Feb 2023 at 17:06, enh wrote: > On Sat, Feb 11, 2023 at 4:07 AM Rob Landley wrote: > > > > > > &g

Re: [Toybox] [PATCH 2/2] BLKID: Fix SEC_TYPE for vfat and iso9660

YISO" UUID="1970-01-02-12-55-42-00" > TYPE="iso9660" > +temp.img: UUID="2023-02-08-04-47-27-00" LABEL="CDROM" TYPE="iso9660" > > And... sigh. Why are the fields out of order? Let me check a couple more blkid implementations and get back

Re: [Toybox] [PATCH] Enable ASan for github CI.

I can take a look this weekend. - Eric On Thu, 20 Jul 2023, 8:32 pm enh via Toybox, wrote: > heh, and the revert commit _did_ get a green ci run. so, yeah, definitely > bad. but now we need the guy who set up the github ci in the first place to > hit us with his cluestick... :-) (how is a

Re: [Toybox] Bash Compatibility Patch

On Sat, 29 Jun 2019 at 18:37, Rob Landley wrote: > On 6/29/19 7:52 AM, Eric Molitor wrote: > > I know that you are working on toysh which I'm looking forward to. In the > > meantime below is a patch to improve compatibility with older/odd > versions of > > bash. This fix

Re: [Toybox] Bash Compatibility Patch

Correct zsh in emulated bash mode. The other is a version of pdksh symbolically linked as /bin/bash but only claims to be a Bourne shell, not bash. Sorry for the confusion. On Mon, 1 Jul 2019, 21:45 Rob Landley, wrote: > On 7/1/19 3:03 PM, enh wrote: > > and in the other case they talk about a

[Toybox] Bash Compatibility Patch

I know that you are working on toysh which I'm looking forward to. In the meantime below is a patch to improve compatibility with older/odd versions of bash. This fixed a minor build issue I was having on MacOS (which was using zsh in emulated bash mode) as well as an oddball embedded SDK using a