Re: [Trac] Re: Notifications - what is current in 1.2.2 vs what is deprecated

[Roger Oberholtzer]

On Tue, Jun 12, 2018 at 9:41 PM, Peter Suter  wrote:

> You refer to "my_bla" again in "my_bla.keyword1 = value1", "my_bla.keyword2
> = value2".
> AFAIK that's the only / standard syntax to define such groups of
> keywords/values in INI files.

I meant that something like this looked more sensible to me:

[notification-subscriber]
default = 
CarbonCopySubscriber,TicketPreviousUpdatersSubscriber,TicketUpdaterSubscriber,TicketReporterSubscriber,TicketOwnerSubscriber






-- 
Roger Oberholtzer

-- 
You received this message because you are subscribed to the Google Groups "Trac 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to trac-users+unsubscr...@googlegroups.com.
To post to this group, send email to trac-users@googlegroups.com.
Visit this group at https://groups.google.com/group/trac-users.
For more options, visit https://groups.google.com/d/optout.

Re: [Trac] Re: Notifications - what is current in 1.2.2 vs what is deprecated

[Peter Suter]

On 12.06.2018 13:08, Roger Oberholtzer wrote:

On Tue, Jun 12, 2018 at 9:25 AM, Peter Suter  wrote:


Does that clear things up a bit?

When I understood that that the text like
"my_default_subscriber_rule_to_always_notify_ticket_owners_via_html_email"
has no inherent meaning to Trac, and that one cannot (it seems to me)
make any reference to it, I understood.  I am guessing that there will
be some feature in the future where
"my_default_subscriber_rule_to_always_notify_ticket_owners_via_html_email"
itself (not just what it is set to) is used and can be referenced for
some reason. If that's not the case, then the syntax is strange.
You refer to "my_bla" again in "my_bla.keyword1 = value1", 
"my_bla.keyword2 = value2".
AFAIK that's the only / standard syntax to define such groups of 
keywords/values in INI files.




But no problem. I know what is going on now. And a few people have
reported getting notifications that they previously did not get. How
the INI file settings relate to the things individual users can select
for notification in the Trac GUI is a different question.

The INI file settings define the default rules.
The GUI potentially allows overriding those default rules with per-user 
preferences.


--
You received this message because you are subscribed to the Google Groups "Trac 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to trac-users+unsubscr...@googlegroups.com.
To post to this group, send email to trac-users@googlegroups.com.
Visit this group at https://groups.google.com/group/trac-users.
For more options, visit https://groups.google.com/d/optout.

Re: [Trac] Re: Notifications - what is current in 1.2.2 vs what is deprecated

[Roger Oberholtzer]

On Tue, Jun 12, 2018 at 9:25 AM, Peter Suter  wrote:

> Does that clear things up a bit?

When I understood that that the text like
"my_default_subscriber_rule_to_always_notify_ticket_owners_via_html_email"
has no inherent meaning to Trac, and that one cannot (it seems to me)
make any reference to it, I understood.  I am guessing that there will
be some feature in the future where
"my_default_subscriber_rule_to_always_notify_ticket_owners_via_html_email"
itself (not just what it is set to) is used and can be referenced for
some reason. If that's not the case, then the syntax is strange.

But no problem. I know what is going on now. And a few people have
reported getting notifications that they previously did not get. How
the INI file settings relate to the things individual users can select
for notification in the Trac GUI is a different question.

-- 
Roger Oberholtzer

-- 
You received this message because you are subscribed to the Google Groups "Trac 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to trac-users+unsubscr...@googlegroups.com.
To post to this group, send email to trac-users@googlegroups.com.
Visit this group at https://groups.google.com/group/trac-users.
For more options, visit https://groups.google.com/d/optout.

Re: [Trac] Re: Notifications - what is current in 1.2.2 vs what is deprecated

[Peter Suter]

On Tuesday, June 12, 2018 at 7:54:32 AM UTC+2, Roger Oberholtzer wrote:
>
> On Mon, Jun 11, 2018 at 9:32 PM, Peter Suter  > wrote: 
> > On 11.06.2018 13:28, Roger Oberholtzer wrote: 
> >> 
> >> On Mon, Jun 11, 2018 at 12:56 PM, Peter Suter  > wrote: 
> >> 
> >>> And as is mentioned there: "The subscription rule name on the left 
> side 
> >>> of 
> >>> the = can be anything, it has no meaning outside this configuration 
> >>> file." 
> >>> So "the labels that they are typically specified with in trac.ini" are 
> >>> not 
> >>> listed. Maybe that is too confusing? 
> >> 
> >> At least it is inconsistent with everywhere else in the ini file, 
> >> where I think the labels to the left always have meaning. I did not 
> >> get the significance of that statement. So I assumed there was a list 
> >> of expected labels somewhere. 
> > 
> > There are a few other groups that allow the user to chose any name on 
> the 
> > left of the = sign, like: 
> > [ticket-custom] 
> > [ticket-workflow] 
> > [milestone-groups] 
> > [repositories] 
>
> True. But there you are defining something of your own. Like your own 
> variable or repository. And still the tags are only partly your own. 
> Most have an appended .keyword that is defined by Trac. 
>
> Why isn't the parameter for the desired notifications a single list 
> with the notification names as the list items? Isn't that effectively 
> what the current thing does, since the tags have no meaning to Trac? 
>

All the same things also apply to the [notification-subscriber] section.
You define your default notification rule, and for each rule name you can 
append .keyword properties defined by Trac.

Example:

[notification-subscriber]

my_default_subscriber_rule_to_always_notify_ticket_owners_via_html_email = 
TicketOwnerSubscribermy_default_subscriber_rule_to_always_notify_ticket_owners_via_html_email.distributor
 = email
my_default_subscriber_rule_to_always_notify_ticket_owners_via_html_email.format 
= text/html

my_default_subscriber_rule_to_also_always_notify_ticket_owner_via_plain_text_xmpp
 = 
TicketOwnerSubscribermy_default_subscriber_rule_to_also_always_notify_ticket_owner_via_plain_text_xmpp.distributor
 = xmpp
my_default_subscriber_rule_to_also_always_notify_ticket_owner_via_plain_text_xmpp.format
 = text/plain


It's just that so far there's rarely a need / use for this, because Trac does 
not yet include any distributors other than for email, nor any formatters other 
than for text/plain.

For another example with more .keywords see 
https://trac.edgewall.org/wiki/TracNotification#ExampleConfigurationdefaultsubscriptions

Does that clear things up a bit?

-- 
You received this message because you are subscribed to the Google Groups "Trac 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to trac-users+unsubscr...@googlegroups.com.
To post to this group, send email to trac-users@googlegroups.com.
Visit this group at https://groups.google.com/group/trac-users.
For more options, visit https://groups.google.com/d/optout.

Re: [Trac] Re: Notifications - what is current in 1.2.2 vs what is deprecated

[Roger Oberholtzer]

On Mon, Jun 11, 2018 at 9:32 PM, Peter Suter  wrote:
> On 11.06.2018 13:28, Roger Oberholtzer wrote:
>>
>> On Mon, Jun 11, 2018 at 12:56 PM, Peter Suter  wrote:
>>
>>> And as is mentioned there: "The subscription rule name on the left side
>>> of
>>> the = can be anything, it has no meaning outside this configuration
>>> file."
>>> So "the labels that they are typically specified with in trac.ini" are
>>> not
>>> listed. Maybe that is too confusing?
>>
>> At least it is inconsistent with everywhere else in the ini file,
>> where I think the labels to the left always have meaning. I did not
>> get the significance of that statement. So I assumed there was a list
>> of expected labels somewhere.
>
> There are a few other groups that allow the user to chose any name on the
> left of the = sign, like:
> [ticket-custom]
> [ticket-workflow]
> [milestone-groups]
> [repositories]

True. But there you are defining something of your own. Like your own
variable or repository. And still the tags are only partly your own.
Most have an appended .keyword that is defined by Trac.

Why isn't the parameter for the desired notifications a single list
with the notification names as the list items? Isn't that effectively
what the current thing does, since the tags have no meaning to Trac?


-- 
Roger Oberholtzer

-- 
You received this message because you are subscribed to the Google Groups "Trac 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to trac-users+unsubscr...@googlegroups.com.
To post to this group, send email to trac-users@googlegroups.com.
Visit this group at https://groups.google.com/group/trac-users.
For more options, visit https://groups.google.com/d/optout.

Re: [Trac] Re: Notifications - what is current in 1.2.2 vs what is deprecated

[Peter Suter]

On 11.06.2018 13:28, Roger Oberholtzer wrote:

On Mon, Jun 11, 2018 at 12:56 PM, Peter Suter  wrote:


And as is mentioned there: "The subscription rule name on the left side of
the = can be anything, it has no meaning outside this configuration file."
So "the labels that they are typically specified with in trac.ini" are not
listed. Maybe that is too confusing?

At least it is inconsistent with everywhere else in the ini file,
where I think the labels to the left always have meaning. I did not
get the significance of that statement. So I assumed there was a list
of expected labels somewhere.
There are a few other groups that allow the user to chose any name on 
the left of the = sign, like:

[ticket-custom]
[ticket-workflow]
[milestone-groups]
[repositories]

I you know how please change the explanation to be more clear. I suspect 
it's still unclear to many other people as well.





I miss notifications when wiki pages change. But as the Announcer
plugin is no longer compatible, I guess the wiki is not part of this.


There's an old patch for this here:
https://trac.edgewall.org/ticket/1660#comment:25

Is that patch compatible with Trac 1.2.x?
No, it was very outdated. I added an updated v2 patch now, but that one 
requires Trac 1.3.2+ (Jinja templates) / trunk and a fix for #13041.


--
You received this message because you are subscribed to the Google Groups "Trac 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to trac-users+unsubscr...@googlegroups.com.
To post to this group, send email to trac-users@googlegroups.com.
Visit this group at https://groups.google.com/group/trac-users.
For more options, visit https://groups.google.com/d/optout.

Re: [Trac] Re: Notifications - what is current in 1.2.2 vs what is deprecated

[Roger Oberholtzer]

On Mon, Jun 11, 2018 at 12:56 PM, Peter Suter  wrote:

> And as is mentioned there: "The subscription rule name on the left side of
> the = can be anything, it has no meaning outside this configuration file."
> So "the labels that they are typically specified with in trac.ini" are not
> listed. Maybe that is too confusing?

At least it is inconsistent with everywhere else in the ini file,
where I think the labels to the left always have meaning. I did not
get the significance of that statement. So I assumed there was a list
of expected labels somewhere.

>> I miss notifications when wiki pages change. But as the Announcer
>> plugin is no longer compatible, I guess the wiki is not part of this.
>>
>
> There's an old patch for this here:
> https://trac.edgewall.org/ticket/1660#comment:25

Is that patch compatible with Trac 1.2.x?

-- 
Roger Oberholtzer

-- 
You received this message because you are subscribed to the Google Groups "Trac 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to trac-users+unsubscr...@googlegroups.com.
To post to this group, send email to trac-users@googlegroups.com.
Visit this group at https://groups.google.com/group/trac-users.
For more options, visit https://groups.google.com/d/optout.

Re: [Trac] Re: Notifications - what is current in 1.2.2 vs what is deprecated

[Peter Suter]

On Monday, June 11, 2018 at 8:44:47 AM UTC+2, Roger Oberholtzer wrote:
>
> This topic has always confused me as well. It seems that the docs for 
> the current/new notification system are a bit all over the place. One 
> thing I do not see is a simple list that tells both all the Subscriber 
> function names AND the labels that they are typically specified with 
> in trac.ini. I think this is the current complete list of possible 
> notifiers that come as part of trac?: 
>
> [notification-subscriber] 
> always_notify_cc = CarbonCopySubscriber 
> always_notify_previous_updater = TicketPreviousUpdatersSubscriber 
> always_notify_updater = TicketUpdaterSubscriber 
> always_notify_reporter = TicketReporterSubscriber 
> always_notify_owner = TicketOwnerSubscriber 
>   
>
Are there any others? 
>
The full list should be here: 
https://trac.edgewall.org/wiki/TracNotification#SubscriberConfiguration
and here: 
https://trac.edgewall.org/wiki/TracIni#notification-subscriber-section
and they can be also be listed with the SubscriberListMacro: 
https://trac.edgewall.org/wiki/TracDev/ReleaseNotes/1.2#/SubscriberListMacro
And as is mentioned there: "The subscription rule name on the left side of 
the = can be anything, it has no meaning outside this configuration file."
So "the labels that they are typically specified with in trac.ini" are not 
listed. Maybe that is too confusing?

AlwaysEmailSubscriber can not be configured in that section: 
https://trac.edgewall.org/ticket/12036
NewTicketSubscriber was added very recently and can also not be configured 
in that section: https://trac.edgewall.org/ticket/6613

Some more optional ones are listed here: 
https://trac.edgewall.org/wiki/CookBook/Notification/Subscriptions



> I miss notifications when wiki pages change. But as the Announcer 
> plugin is no longer compatible, I guess the wiki is not part of this. 
>
>
There's an old patch for this here: 
https://trac.edgewall.org/ticket/1660#comment:25

-- 
You received this message because you are subscribed to the Google Groups "Trac 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to trac-users+unsubscr...@googlegroups.com.
To post to this group, send email to trac-users@googlegroups.com.
Visit this group at https://groups.google.com/group/trac-users.
For more options, visit https://groups.google.com/d/optout.

Re: [Trac] Re: Notifications - what is current in 1.2.2 vs what is deprecated

[Roger Oberholtzer]

On Mon, Jun 11, 2018 at 8:26 AM, Ryan Ollos  wrote:
>
> On Sun, Jun 10, 2018 at 11:24 PM, Roger Oberholtzer
>  wrote:
>>
>> On Sun, Jun 10, 2018 at 7:36 AM, RjOllos  wrote:

> That's correct. They are listed for the "demo-1.0" site because they are
> still valid in Trac 1.0.
>
> They are not listed in a Trac 1.2 site:
> https://trac.edgewall.org/demo-1.2/wiki/TracIni#notification-section

Makes sense. I just followed your link after your statement that they
are no longer supported.

This topic has always confused me as well. It seems that the docs for
the current/new notification system are a bit all over the place. One
thing I do not see is a simple list that tells both all the Subscriber
function names AND the labels that they are typically specified with
in trac.ini. I think this is the current complete list of possible
notifiers that come as part of trac?:

[notification-subscriber]
always_notify_cc = CarbonCopySubscriber
always_notify_previous_updater = TicketPreviousUpdatersSubscriber
always_notify_updater = TicketUpdaterSubscriber
always_notify_reporter = TicketReporterSubscriber
always_notify_owner = TicketOwnerSubscriber

Are there any others?

I miss notifications when wiki pages change. But as the Announcer
plugin is no longer compatible, I guess the wiki is not part of this.


-- 
Roger Oberholtzer

-- 
You received this message because you are subscribed to the Google Groups "Trac 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to trac-users+unsubscr...@googlegroups.com.
To post to this group, send email to trac-users@googlegroups.com.
Visit this group at https://groups.google.com/group/trac-users.
For more options, visit https://groups.google.com/d/optout.

Re: [Trac] Re: Notifications - what is current in 1.2.2 vs what is deprecated

[Ryan Ollos]

On Sun, Jun 10, 2018 at 11:24 PM, Roger Oberholtzer <
roger.oberholt...@gmail.com> wrote:

> On Sun, Jun 10, 2018 at 7:36 AM, RjOllos  wrote:
>
> >> Are these conf settings still used?
> >>
> >> always_notify_owner = true
> >> always_notify_reporter = true
> >> always_notify_updater = true
> >
> >
> > Those settings are no longer used by Trac.
>
> But they are still listed in
> https://trac.edgewall.org/demo-1.0/wiki/TracIni#notification-section
>
> What else might no longer be used that is still listed?
>

That's correct. They are listed for the "demo-1.0" site because they are
still valid in Trac 1.0.

They are not listed in a Trac 1.2 site:
https://trac.edgewall.org/demo-1.2/wiki/TracIni#notification-section

- Ryan

-- 
You received this message because you are subscribed to the Google Groups "Trac 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to trac-users+unsubscr...@googlegroups.com.
To post to this group, send email to trac-users@googlegroups.com.
Visit this group at https://groups.google.com/group/trac-users.
For more options, visit https://groups.google.com/d/optout.

Re: [Trac] Re: Notifications - what is current in 1.2.2 vs what is deprecated

[Roger Oberholtzer]

On Sun, Jun 10, 2018 at 7:36 AM, RjOllos  wrote:

>> Are these conf settings still used?
>>
>> always_notify_owner = true
>> always_notify_reporter = true
>> always_notify_updater = true
>
>
> Those settings are no longer used by Trac.

But they are still listed in
https://trac.edgewall.org/demo-1.0/wiki/TracIni#notification-section

What else might no longer be used that is still listed?




-- 
Roger Oberholtzer

-- 
You received this message because you are subscribed to the Google Groups "Trac 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to trac-users+unsubscr...@googlegroups.com.
To post to this group, send email to trac-users@googlegroups.com.
Visit this group at https://groups.google.com/group/trac-users.
For more options, visit https://groups.google.com/d/optout.

[Trac] Re: Notifications - what is current in 1.2.2 vs what is deprecated

[RjOllos]

On Saturday, June 9, 2018 at 5:23:15 PM UTC-7, Michela Ledwidge wrote:
>
>
> There are 44 open notification tickets 
>  
> so posting here for clarification on what could be a logic bug or just 
> unclear docs
>
> Are these conf settings still used? 
>
> always_notify_owner = true
> always_notify_reporter = true
> always_notify_updater = true
>

Those settings are no longer used by Trac.
 

> With this conf, no email notification was sent when I updated a ticket and 
> was also the reporter
>
> [notification]
> admit_domains =
> always_notify_owner = true
> always_notify_reporter = true
> always_notify_updater = true
> [notification-subscriber]
> always_notify_cc = CarbonCopySubscriber
> always_notify_previous_updater = TicketPreviousUpdatersSubscriber
> always_notify_updater = TicketUpdaterSubscriber
>
> and according to Preferences, these were the default preferences active 
> (i.e. not including always_notify_reporter )
>
>- Notify: Ticket that I own is created or modified
>- Notify: I update a ticket
>- Notify: Ticket that I previously updated is modified
>
> I added the following to [notification-subscriber] and now all defaults 
> appear listed in Preferences but why is this necessary? 
>
> always_notify_email_subscriber = AlwaysEmailSubscriber
> always_notify_owner_subscriber = TicketOwnerSubscriber
> always_notify_reporter_subscriber = TicketReporterSubscriber
>
> Are the always_notify_* conf lines deprecated?
>

The default subscriptions are configurable. The defaults for a new 
installation are:

always_notify_cc = CarbonCopySubscriber
always_notify_previous_updater = TicketPreviousUpdatersSubscriber
always_notify_updater = TicketUpdaterSubscriber

, which appears to be what you had in the [notification-subscriber] 
section. If you want rules for "notify owner" and "notify reporter" you 
have to add them. This is consistent with the pre-1.2 behavior in which 
always_notify_reporter and always_notify_owner defaulted to false.

https://trac.edgewall.org/demo-1.0/wiki/TracIni#notification-section

If you had the [trac] always_notify_* rules implemented in Trac 1.0.x, on 
upgrade to Trac 1.2.x the [notification-subscriber] rules should have been 
added:
https://trac.edgewall.org/browser/tags/trac-1.2.2/trac/upgrades/db40.py#L17

I don't think you need the "always_notify_email_subscriber" default 
subscription.

- Ryan

-- 
You received this message because you are subscribed to the Google Groups "Trac 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to trac-users+unsubscr...@googlegroups.com.
To post to this group, send email to trac-users@googlegroups.com.
Visit this group at https://groups.google.com/group/trac-users.
For more options, visit https://groups.google.com/d/optout.