Re: [Twisted-Python] twistechecker and twisted-dev-tools as part of twisted main repo

2015-03-19 Thread Glyph
> On Mar 19, 2015, at 8:41 AM, Christopher Armstrong > wrote: > > >> On Mar 19, 2015, at 4:45 AM, Adi Roiban wrote: >> >>> OK, cool. I didn't realize that was ready for review. I am liking the >>> process we have for Mimic for flagging PRs with keywords - >>> https://github.com/rackerlabs/

Re: [Twisted-Python] twistechecker and twisted-dev-tools as part of twisted main repo

2015-03-19 Thread Christopher Armstrong
> On Mar 19, 2015, at 10:46 AM, HawkOwl wrote: > > >> On 19 Mar 2015, at 23:41, Christopher Armstrong >> wrote: >> >> I suggest making the default, tagless state of a PR mean “in review”, for a >> couple of reasons: >> >> - having labels for both `needs-changes` and `in-review` means you c

Re: [Twisted-Python] twistechecker and twisted-dev-tools as part of twisted main repo

2015-03-19 Thread HawkOwl
> On 19 Mar 2015, at 23:41, Christopher Armstrong > wrote: > > I suggest making the default, tagless state of a PR mean “in review”, for a > couple of reasons: > > - having labels for both `needs-changes` and `in-review` means you can enter > an invalid state where both labels are applied >

Re: [Twisted-Python] twistechecker and twisted-dev-tools as part of twisted main repo

2015-03-19 Thread Christopher Armstrong
> On Mar 19, 2015, at 4:45 AM, Adi Roiban wrote: > >> OK, cool. I didn't realize that was ready for review. I am liking the >> process we have for Mimic for flagging PRs with keywords - >> https://github.com/rackerlabs/mimic/pulls - but this needs automation so as >> not to be unfriendly to no

Re: [Twisted-Python] twistechecker and twisted-dev-tools as part of twisted main repo

2015-03-19 Thread Adi Roiban
> OK, cool. I didn't realize that was ready for review. I am liking the > process we have for Mimic for flagging PRs with keywords - > https://github.com/rackerlabs/mimic/pulls - but this needs automation so as > not to be unfriendly to non-committer contributors. > > I'll try to get to it by the

Re: [Twisted-Python] twistechecker and twisted-dev-tools as part of twisted main repo

2015-03-18 Thread Glyph Lefkowitz
> On Mar 18, 2015, at 3:55 AM, Adi Roiban wrote: > > Ok. Let's focus on Git then. > > My biggest annoyance is buildbot and the builders with false positives. > > Is this the only wiki page documenting the progress and next steps for > git migration https://twistedmatrix.com/trac/wiki/Infrastr

Re: [Twisted-Python] twistechecker and twisted-dev-tools as part of twisted main repo

2015-03-18 Thread Adi Roiban
Ok. Let's focus on Git then. My biggest annoyance is buildbot and the builders with false positives. Is this the only wiki page documenting the progress and next steps for git migration https://twistedmatrix.com/trac/wiki/Infrastructure/SwitchToGit I have started working at vagrant file but the

Re: [Twisted-Python] twistechecker and twisted-dev-tools as part of twisted main repo

2015-03-18 Thread Glyph
> On Mar 18, 2015, at 1:38 AM, Adi Roiban wrote: > > On 18 March 2015 at 05:43, Glyph wrote: >> >>> On Mar 16, 2015, at 2:17 AM, Adi Roiban wrote: >> > [snip] > >> I'm approximately -0 on this. I don't like the idea of dumping a bunch of >> code into the main Twisted repo that isn't distri

Re: [Twisted-Python] twistechecker and twisted-dev-tools as part of twisted main repo

2015-03-18 Thread Adi Roiban
On 18 March 2015 at 05:43, Glyph wrote: > >> On Mar 16, 2015, at 2:17 AM, Adi Roiban wrote: > [snip] > I'm approximately -0 on this. I don't like the idea of dumping a bunch of > code into the main Twisted repo that isn't distributed along with Twisted > (personally I cannot wait to get rid of

Re: [Twisted-Python] twistechecker and twisted-dev-tools as part of twisted main repo

2015-03-17 Thread Glyph
> On Mar 16, 2015, at 2:17 AM, Adi Roiban wrote: > > Hi > > I know that twisted main repo contains a lot of code but I would like > to discuss the option of merging > twisted-dev-tools and twistedchecker into twisted main repo. > > The main reason why I want this is to make reviews for these r

[Twisted-Python] twistechecker and twisted-dev-tools as part of twisted main repo

2015-03-16 Thread Adi Roiban
Hi I know that twisted main repo contains a lot of code but I would like to discuss the option of merging twisted-dev-tools and twistedchecker into twisted main repo. The main reason why I want this is to make reviews for these repos more visible to twisted developers. I don't think that we woul