Re: [Twisted-Python] INCOMPATIBLE CHANGE: Removal of t.c.ssh.filetransfer.FileTransferClient.wasAFile

t;, trac bug 9362) I'm removing an > attribute of FileTransferClient which I'm pretty sure was never intended to > be public. Adi Roiban points out that this is technically a > compatibility-breaking change, though, and so it needs more public review. > > My reasoning for thinking t

Re: [Twisted-Python] Building Python3 wheels for Win32 and releasing to Pypi

n64/macOS/manylinux1 on one side and py27 py34 py35 py36 on the > other. > > Maybe it helps, There is some work for moving the Windows builds to appveyor Ticket https://twistedmatrix.com/trac/ticket/8676 initial PR https://github.com/twisted/twisted/pull/413 I no lo

[Twisted-Python] failUnlessFailure vs assertFailure

/ce0b00de026a896b731d8794de2fd61b54a78a98 -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] github process automation shortcut

so in order to make it easier for everybody to contribute I don't like that we depend that much on GitHub, but I don't see how there will be time to keep custom infrastructure. There is little time to do review, and at this stage I think that is more important for people to do reviews and w

Re: [Twisted-Python] Drop support for Python 3.3

o that we don't have to change the release notes for 17.9.0 That is 18.X.X should be the last release to support 3.4 -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Accepting/merging patches for unsupported platforms without CI

On 26 November 2017 at 22:30, Glyph <gl...@twistedmatrix.com> wrote: > >> On Nov 26, 2017, at 10:23 AM, Adi Roiban <a...@roiban.ro> wrote: >> >> Hi, >> >> What is the procedure for accepting patches for platforms for which we >> don't have a co

[Twisted-Python] Accepting/merging patches for unsupported platforms without CI

to manually run the tests to check the patch. Twisted is supported on so many systems and I don't think that is OK to ask reviewers to have each supported system at hand, ready to fire a manual test. Any comments? Thanks, -- Adi Roiban ___ Twisted

Re: [Twisted-Python] SMTPConnectError as a side effect on connection lost

On 26 November 2017 at 05:36, Glyph <gl...@twistedmatrix.com> wrote: > >> On Nov 25, 2017, at 8:52 PM, Adi Roiban <a...@roiban.ro> wrote: >> >> Do you see anything suspicious with this code? > > Just that it looks like it leaves a Deferred in an error state.

[Twisted-Python] SMTPConnectError as a side effect on connection lost

result.errback(value) then the test will pass. But I still don't understand how the error from one client request is passed to another client request when they are using different servers. Do you see anything suspicious with this code? Thanks! -- Adi Roiban __

Re: [Twisted-Python] PyPy 5.9.0 on buildbots

can get something similar to Travis-CI. Before running the tests, buildbot will call something like `python admin/buildbot-init` and depending on the environment variables, this script can install various things. In this way we have more configuration logic in the repo and developers can adv

Re: [Twisted-Python] Defining the review workflow on top of GitHub PR

t should behave, I can look at deploying a dedicated bot for Twisted and then update it to sync with Trac. What do you think? PS: I am not deploying it into Twisted infra now as for me twisted-infra/braid and vagrant vm is broken... working on fixing it -- Adi Roiban _

[Twisted-Python] Defining the review workflow on top of GitHub PR

PS: I have checked pyca/crypography but I don't see any pattern there and a lot of PR are merged without any comment https://github.com/pyca/cryptography/pulls?q=is%3Apr+is%3Aclosed -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Migrating Trac Tickets to GitHub issues

On 30 September 2017 at 22:15, Adi Roiban <a...@roiban.ro> wrote: [snip] > > > Below are the things that I things we will lose when migrating to > GitHub Issues and which will require extra work. > [snip] 6. We will no longer get the tickets pending review rep

[Twisted-Python] Migrating Trac Tickets to GitHub issues

of a ticket. Thanks, PS: For my private project I am still using Trac for issues and GitHub for PR and manage the tools to keep them in sync. I am using the Trac ticket workflows with a dedicated state for a ticket when it needs a review or when a review was done and it needs changes. -- Adi Roiban

Re: [Twisted-Python] KeyError in SSHConnection.ssh_CHANNEL_OPEN_CONFIRMATION

e the single file together with a description of how to run it and how to wait for the error. Regards, -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] KeyError in SSHConnection.ssh_CHANNEL_OPEN_CONFIRMATION

nip] As suggested by Glyph. Please provide a complete minimal example which can be used to reproduce this behaviour. http://sscce.org/ I am happy to help with any SSH related bugs. -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twist

[Twisted-Python] buildbot/osx10.10-py2.7 and required builders for merge

o be green in order to merge? I am reading this page, but is not clear which tests need to be green: https://twistedmatrix.com/trac/wiki/ReviewProcess#Authors:Howtomergethechangetotrunk Thanks! -- Adi Roiban ___ Twisted-Python mailing list Twis

Re: [Twisted-Python] How to set up Twisted buildbot VM?

On 22 June 2017 at 09:44, Craig Rodrigues wrote: > Hi, > > I tried to set up a VM to test changes to Twisted's buildbot. > > I did this: > > > git clone https://github.com/twisted-infra/braid > cd braid > vagrant up > fab config.vagrant > fab config.vagrant base.bootstrap

Re: [Twisted-Python] on adopting projects

ew or without tests. What do you think? Maybe I am just paranoid, and there is no risk quality decrease by outsourcing to external projects. Thanks! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Combining eventually and incremental dependencies

and versioning functionalities are related. From what I can see in the current examples, each time you use eventually you are forced to use incremental so that you can pass that bloody Version instance, which I don't know why we can't go with just a tupple :) Thanks! -- Adi Roiban

Re: [Twisted-Python] Regarding the SHA 512 support in twisted.

what we have noticed is >>>> that when we negotiate SHA 512 MAC with twisted we always get a failure and >>>> other MAC algorithms are working fine with twisted. So wanted to cross >>>> check >>>> do we have any bug or any issue with SHA 512 and

Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

On 7 March 2017 at 09:31, Cory Benfield <c...@lukasa.co.uk> wrote: > > On 6 Mar 2017, at 09:05, Adi Roiban <a...@roiban.ro> wrote: > > I am not sure about which code are we talking here. > The specific HTTP11ClientProtocol which will fix only the HTTP c

Re: [Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

On 6 March 2017 at 08:17, Cory Benfield <c...@lukasa.co.uk> wrote: > > On 5 Mar 2017, at 14:25, Tristan Seligmann <mithra...@mithrandi.net> wrote: > > On Sun, 5 Mar 2017 at 15:36 Adi Roiban <a...@roiban.ro> wrote: >> >> I have observed this wh

[Twisted-Python] HTTP Agent persistent connections not closed for some HTTPS sites

sed Thanks! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] trac spam

ing list > Twisted-Python@twistedmatrix.com > http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python > -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Test coverage requirements

ome parenthesis) which were indented and that code was not previously covered ... so now it is considered code on which someone made a change without having the tests to cover the changes. -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedm

[Twisted-Python] Hanging SFTP client operations on server disconnection

and these type of errors should be handled in a different way. Thanks! PS: There is a stray release notes fragment in conch https://github.com/twisted/twisted/blob/trunk/src/twisted/conch/8791.feature -- Adi Roiban ___ Twisted-Python mailing list Twisted

[Twisted-Python] conch.ssh.SSHFactory publicKeys and getPublicKeys

key from it. Are there any SSH key formats which will store a private key without the public components ? Or this is just a legacy code from the time when twisted.conch.ssh.keys.Key was not there... and getPublicKeys should be deprecated? Thanks! -- Adi Roiban

Re: [Twisted-Python] hmac-sha2-512 - Corrupted MAC on input with OpenSSH

. There is a defect ticket which is not yet closed https://twistedmatrix.com/trac/ticket/8258 I hope that the ticket description can be used to reproduce this error. This might not be a hmac-sha2-512 specific issue, but a generic issue related to padding... is just that sha2-512 t

Re: [Twisted-Python] eliminating MSI builder

el https://twistedmatrix.com/trac/ticket/8544 Once that is done, there is a follow up ticket for moving the builder on Appveyor https://twistedmatrix.com/trac/ticket/8676 -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http

Re: [Twisted-Python] Waiting time for tests running on Travis CI and Buildbot

We now have 15 concurrent jobs for the next 10 days. Please check if it makes a difference worth more than $6000 per year :) Also, do we need both python 3.3 and 3.4 jobs? I think that we have non python 3.5 builders to prevent the usage of string formatting for bytes which is not available

Re: [Twisted-Python] Tests on Windows with Python 3 now passing

ublish the wheel on Azure and if is ok to create it from Win2008R2 Server vs Win7 -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Please fix the broken buildbots

"%(test-case-name:~twisted)s")] This should put twisted when test-case-name is not defined by a build job. Any objections on that? -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] setup.py broken in trunk

l need to have `pip install .` called so that we don't run the OS trial version. There is also ticket https://twistedmatrix.com/trac/ticket/8544 which tries to create tox environments for all Buildbot builders so that we can run everything with Tox on buildbot

Re: [Twisted-Python] setup.py broken in trunk

t; Twisted-Python@twistedmatrix.com > http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] SSL4ClientEndpoint not updating the transport's connected flag on connection lost

On 20 August 2016 at 08:37, Glyph Lefkowitz <gl...@twistedmatrix.com> wrote: > > On Aug 11, 2016, at 06:59, Adi Roiban <a...@roiban.ro> wrote: > > Hi, > > I have observed that when a SSL4ClientEndpoint was used, the > protocol's transport `connected` attribute is

Re: [Twisted-Python] Waiting time for tests running on Travis CI and Buildbot

PR for running only on trunk and release branches is here https://twistedmatrix.com/trac/ticket/8767 Travis-CI told that they can increase the limit to 15 jobs for one week so that we can give it a try. It would help to have the PR only build branch merged soon :) Cheers, Adi

Re: [Twisted-Python] making appveyor a required status

On 14 August 2016 at 11:38, Adi Roiban <a...@roiban.ro> wrote: > On 14 August 2016 at 00:40, Glyph Lefkowitz <gl...@twistedmatrix.com> wrote: >> Just a bit of Github housekeeping: Appveyor has looked pretty stable (more >> than our other Windows builds, even).

Re: [Twisted-Python] [BACKWARDS INCOMPATIBILITY] Making twisted.python.dist3 private

leaf modules and not core modules. > > - Amber > > ___ > Twisted-Python mailing list > Twisted-Python@twistedmatrix.com > http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python > -- Adi Roiban ___

Re: [Twisted-Python] Waiting time for tests running on Travis CI and Buildbot

On 15 August 2016 at 00:10, Glyph Lefkowitz <gl...@twistedmatrix.com> wrote: > >> On Aug 14, 2016, at 3:38 AM, Adi Roiban <a...@roiban.ro> wrote: >> >> Hi, >> >> We now have 5 concurrent jobs on Travis-CI for the whole Twisted >> organization. &

Re: [Twisted-Python] making appveyor a required status

vis (for every branch > but trunk), and just making it PR statuses. Is anyone using the push status, > or is it just making builds take twice as long? +1 for having Travis-CI run push tests only on trunk. I will come back with more details in a separate ema

[Twisted-Python] Waiting time for tests running on Travis CI and Buildbot

. Cheers -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] More tests running on Python 3

increase of 51.5% in Python3 tests. Also, while on the 3rd of June only 55% of Python2 tests were executed on Python3 (as a raw measure) in 11th of August the gap was reduced and now we have 88% of total tests executed on Python3 This is a huge progress! Many thanks! -- Adi Roiban __

Re: [Twisted-Python] close to the finish line on hosted windows testing

sh the Windows wheels generated on Appveyor using the Azure Blob storage Many thanks to Microsoft for providing access to these VMs and for the MSDN subscription.T -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatr

[Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.dist renamed to twisted.python._setup

of the automated test suite. twisted.python.dist3 was kept as a private API as it is already used by https://github.com/habnabit/twisted-depgraph Please let me know if you are using twisted.python.dist outside of Twisted and are against this change or if you approve it. Thanks! -- Adi Roiban

Re: [Twisted-Python] twisted.python.dist as a public API

email, I just wanted to get an initial feedback and try to understand why we have code split between setup.py and dist.py I will come back with an email following the compatibility process. Thanks! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Py

[Twisted-Python] twisted.python.dist as a public API

from twisted.python.dist without a deprecation dance? -- The dedicated ticket is here https://twistedmatrix.com/trac/ticket/8622 and is in the review queue Regards, -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python

Re: [Twisted-Python] Twisted tests on public CI

On 20 July 2016 at 22:36, Glyph Lefkowitz <gl...@twistedmatrix.com> wrote: > > On Jul 20, 2016, at 11:59 AM, Adi Roiban <a...@roiban.ro> wrote: > > Hi, > > We now have Ubuntu / Windows Server and OS X running Twisted tests for > each PR, using Travis-CI and Appv

[Twisted-Python] Twisted tests on public CI

was pretty fast in the last days... after the move to Rackspace. Travis-CI was a bit slow on the free queue... not sure how fast is the payed queue :) Please report any issues here or on Twisted Infrastructure tracker https://github.com/twisted-infra/braid/issues Regards, -- Adi Roiban

Re: [Twisted-Python] buildbot.twistedmatrix.com is down a lot

On 20 July 2016 at 17:51, Glyph Lefkowitz <gl...@twistedmatrix.com> wrote: > > On Jul 20, 2016, at 6:31 AM, Adi Roiban <a...@roiban.ro> wrote: > > > > On 18 July 2016 at 19:04, James Broadhead <jamesbroadh...@gmail.com> > wrote: > >

Re: [Twisted-Python] buildbot.twistedmatrix.com is down a lot

n cases > like this? > > This might help, but will not help up understand what we are doing wrong :) After disabling the github webhooks, the buildbot look stable... so we might have a clue about what goes wrong. Right now I don't have time to look into this issue, so github hooks are dis

Re: [Twisted-Python] removing twistedchecker buildbot for the time being

On 13 July 2016 at 01:27, Adi Roiban <a...@roiban.ro> wrote: > > > On 13 July 2016 at 00:37, Glyph Lefkowitz <gl...@twistedmatrix.com> wrote: > >> Right now it seems the difference-computation logic on the twistedchecker >> buildbot has just broken complet

Re: [Twisted-Python] buildbot.twistedmatrix.com is down a lot

could size up the RAM in the meantime I guess? > > -Amber > I can try to revert the github webhooks + github status send and see if we still get these errors. I also don't have too much time to investigate, but I can revert things if it helps. -- Adi Roiban

Re: [Twisted-Python] IProtocolWithReactor, or passing the reactor though to protocols

On 15 July 2016 at 22:06, Glyph Lefkowitz <gl...@twistedmatrix.com> wrote: > Or, perhaps what you want is this 7-year-old ticket? :) > https://twistedmatrix.com/trac/ticket/3205 > I left my feedback on the ticket :) +1 for getting the reactor from the transport

Re: [Twisted-Python] Coverage exceptions

> This is blocking forward progress on patches to fix the Pypy tests. > > I have disabled codecov patch coverage for now as I think that codecov.io reporting is buggy. For coverage merge protection please see See https://github.com/twisted-infra/braid/issues/213 -- Adi Roiban _

Re: [Twisted-Python] Buildbot upgrade to latest eight branch

On 4 July 2016 at 11:06, Cory Benfield <c...@lukasa.co.uk> wrote: > > > On 2 Jul 2016, at 23:42, Adi Roiban <a...@roiban.ro> wrote: > > > > With this change, Buildbot should have a closer behavior to Travis-CI. > That is, it will automatically start th

Re: [Twisted-Python] Python 3 code coverage not working?

On 4 July 2016 at 12:27, Craig Rodrigues <rodr...@crodrigues.org> wrote: > On Sun, Jul 3, 2016 at 11:00 PM, Adi Roiban <a...@roiban.ro> wrote: > >> >> >> Only the modules (including the test modules) from dist3.py are executed >> on Python3 >> https

Re: [Twisted-Python] Python 3 code coverage not working?

On 4 July 2016 at 08:00, Craig Rodrigues <rodr...@crodrigues.org> wrote: > > > On Sun, Jul 3, 2016 at 11:00 PM, Adi Roiban <a...@roiban.ro> wrote: > >> >> >> >> On 4 July 2016 at 00:43, Craig Rodrigues <rodr...@crodrigues.org> wrote: >&

Re: [Twisted-Python] Python 3 code coverage not working?

the header of that file you can see # -*- test-case-name: twisted.python.test.test_dist3 -*- and also in the test modules we have twisted.python.test.test_dist3 --- That is you need to make the changes in that module twisted.python.test.test_dist is not executed on Python3 ... hence its cover

Re: [Twisted-Python] Coverage exceptions

On 3 July 2016 at 09:53, Tristan Seligmann wrote: > The tests directories can simply be excluded in coverage.py (or codecov), > I don't think there's any need to do something more complicated than that. > > That is, don't report coverage at all for the test code? I

Re: [Twisted-Python] Coverage exceptions

Hi, What decision should be made based on the feedback sent so far? Should we disabled the codecov coverage enforcement for 100% coverage for a patch as it also blocks missing coverage in a test? If we want to enforce only implementation code, then we need to update the tests to send separate

Re: [Twisted-Python] FreeBSD buildbots down?

h left, sponsored by RackSpace. BTW. I see that the Windows slave is pretty busy sometimes. Can we add a Windows slave hosted by Rackspace? (I think that Glyph or Amber can answer this) -- Adi Roiban ___ Twisted-Python mailing list Twisted

[Twisted-Python] Coverage exceptions

be refactored... but I think that the topic of ignoring missing coverage is still valid. I suggest to introduce ` # pragma: no cover` and update the coverage config with [report] exclude_lines = pragma: no cover --- What do you think? Thanks! -- Adi Roiban

Re: [Twisted-Python] Buildbot upgrade to latest eight branch

! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Buildbot upgrade to latest eight branch

rs you see when interacting with buildbot here, over #twisted-admin or by creating a new issue here https://github.com/twisted-infra/braid/issues Have a good day! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.co

Re: [Twisted-Python] Responding to PRs

On 14 June 2016 at 05:24, Glyph wrote: > > > I'm the owner of txghbot. I hope it ends up being useful for Twisted! > > > I strongly suspect that it will be the official solution. Thanks so much > for doing this - the existence of this code is a structural expression of

Re: [Twisted-Python] two minor things

hat when we add the automation, it will work with both methods... but hopefully people will prefer 1234. For me is easier to auto-complete branches based on id. Cheers, Adi -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.co

Re: [Twisted-Python] Need write access to Twisted

am looking forward for just reviewing the buildbot status, codecoverage and then adding comments, rather than also creating branches in twisted, updating Trac ticket, trigger buildbot builds, composing the merge message and doing the actual merge and push :) Many thanks Craig for yo

Re: [Twisted-Python] Deprecating classes and writing tests

On 13 June 2016 at 22:46, Glyph <gl...@twistedmatrix.com> wrote: > > On Jun 13, 2016, at 4:26 AM, Adi Roiban <a...@roiban.ro> wrote: > > Hi, > > What is the best practice for deprecating a class in Twisted and writing > tests for it ... and updating existi

Re: [Twisted-Python] Responding to PRs

ake sure that the PR contributor has an account in Trac and that the contributor will receive notifications for all the discussions done in the Trac ticket. AFAIK the PR are just replacing the attached patched to a Trac ticket. The review should still be d

Re: [Twisted-Python] Responding to PRs

On 13 June 2016 at 22:35, Glyph <gl...@twistedmatrix.com> wrote: > > On Jun 13, 2016, at 4:20 AM, Adi Roiban <a...@roiban.ro> wrote: > > Is there a wiki page, a ticket or some place where switching to the > 'review queue' as GitHub PR list is discussed or brain

[Twisted-Python] Deprecating classes and writing tests

and document it as part of the work for ticket #8368 Regards, -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Responding to PRs

braid/milestones/Migrate-to-Git -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Responding to PRs

d's official review queue (https://twistedmatrix.com/trac/report/25) which is already huge. Thanks again Craig and keep up the good work ! :) -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Need clarification on reviews for Python 3 fixes for Twisted

n't have python 2.7 coverage . Is is still acceptable to touch that code ? :) Regards, Adi -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] overview: new review queue venue

might take some time until there is support for Python on Windows and I am not sure if Travis-ci.org will support this free of charge. I think that we can have both... and in the first instance automatically trigger Travis-CI builds and manually trigger buildbot builds. -- GitLab is an

Re: [Twisted-Python] Twisted 16.2 Release Announcement

his release - the supporters of > the Twisted Software Foundation, the developers who contributed code as > well as documentation, and all the people building great things with > Twisted! > > Twisted Regards, > Amber Brown (HawkOwl) > This is also the release in which the code hos

Re: [Twisted-Python] How to get the class of the wrapped fget/fset property methods

FYI. Amber has merged the branch adding @deprecatedProperty https://twistedmatrix.com/trac/ticket/8124 and the issue raised in this ticket is solved Thanks! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http

Re: [Twisted-Python] Twisted serialport

from 2.7 to 3.0.1 and fails with the following error. > > > Hi, I think that this is a know issue. Please see https://twistedmatrix.com/trac/ticket/8159 It would help if you could try the patch and report that all is ok for your use case. If not the same issue, please report a

Re: [Twisted-Python] The role of twisted.internet._sslverify.IOpenSSLTrustRoot

Hi, On 25 December 2015 at 11:20, Glyph Lefkowitz <gl...@twistedmatrix.com> wrote: > > On Dec 20, 2015, at 9:05 AM, Adi Roiban <a...@roiban.ro> wrote: > > Hi, > > What is the purpose of IOpenSSLTrustRoot ? > > > The idea is that we have public functions

[Twisted-Python] The role of twisted.internet._sslverify.IOpenSSLTrustRoot

at my review and add your wisdom :) Thanks! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Attaching the release number to a closed/merged ticket

nt it. For me, having the released version info in the Trac ticket is easier than searching the NEWS file. Thanks! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Attaching the release number to a closed/merged ticket

On 5 December 2015 at 02:17, Glyph Lefkowitz <gl...@twistedmatrix.com> wrote: > > > On Dec 4, 2015, at 4:51 AM, Adi Roiban <a...@roiban.ro> wrote: > > > > Hi, > > > > Please send your suggestions and comments. > > By "tags" do yo

[Twisted-Python] Attaching the release number to a closed/merged ticket

use a 'next-release' tag and when a release is done, check all tickets and update their tag. Please send your suggestions and comments. Thanks! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http

Re: [Twisted-Python] Suggested plan for GitHub migration

g Rodrigues <rodr...@crodrigues.org> > wrote: > > > > On Tue, Nov 17, 2015 at 8:57 AM, Adi Roiban <a...@roiban.ro> wrote: > > > > For now, the funds were raised to migrate to GitHub, so we can not use > > them to do other things. > > > > We will

[Twisted-Python] Implementing server ESMTP extensions in Twisted

extensions or encourage people to collaborate toward a single implementation which is hosted by Twisted? Thanks! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo

Re: [Twisted-Python] Suggested plan for GitHub migration

ttp://doodle.com/poll/4ys8m8qakav9u9f9 Thanks! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] How to get the class of the wrapped fget/fset property methods

On 23 November 2015 at 02:32, Glyph Lefkowitz <gl...@twistedmatrix.com> wrote: > > On Nov 22, 2015, at 07:04, Adi Roiban <a...@roiban.ro> wrote: > > The @deprecated decorator (at leas on py2.7) does not work when paired > @property > > For deprecated instance

Re: [Twisted-Python] How to get the class of the wrapped fget/fset property methods

> > > > Will push the tests and will ask for help in the review queue. > > Thanks! > > Another option is to fix @deprecated to call getDeprecationWarningString when the method is called not when it is created. Regards -- Adi Roiban __

Re: [Twisted-Python] twisted/runner/inetdtap.py pyflakes warnings cleanup

C code. I'd prefer you don't delete the whole > module though. > > Done https://twistedmatrix.com/trac/ticket/8123 I will go with the deprecation part. Thanks for the feedback. -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] How to get the class of the wrapped fget/fset property methods

deprecatedMember method which is called as a normal method. Thanks! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] twisted/runner/inetdtap.py pyflakes warnings cleanup

sts, I have no idea what this code is expected to do and how end users are expecting to use it. Does someone volunteer to fix it? Otherwise, has anyone any objections against deprecating twisted/runner/inetdtap.py? Since it is broken, can we just remove it? Thanks! -- Adi Roi

Re: [Twisted-Python] incompatible change - need revert before release

Twisted-Python@twistedmatrix.com > http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python > > -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Migration to Git / GitHub

not disrupt the dev process and to not lose data/metadata. GitHub issues are pretty basic and we have little control over them so at least in the first phase we will not try to migrate to GitHub issues. We will just move to cloud based Git hosting as main repo ... and see how we can mig

[Twisted-Python] Conch SSH client dropping support for non/pre RFC 4419 clients

In case you care about Twisted SSH client interacting with very of SSH servers, please take a look and send your feedback over the Trac issue Otherwise, feel free to ignore and enjoy the rest of the day /night :) -- Adi Roiban ___ Twisted-Python

[Twisted-Python] Migration to Git / GitHub

task and start working on them. Cheers -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] pyserial on Python3

! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Specification / RFC of the twisted.conch.ssh.keys.Key.privateBlob implementation

? Thanks! -- Adi Roiban ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] INCOMPATIBLE CHANGE: removing dependency on PyCrypto

ementing a compatibility getter / setter for keyObject while deprecating it in the same time. - I am happy to work or review any code which tries to remove PyCrypto dependency and work on deprecating current PyCrytpo dependency.

Re: [Twisted-Python] Possible bug

gt; -glyph > > > ___ > Twisted-Python mailing list > Twisted-Python@twistedmatrix.com > http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python > > > > ___ > Twisted-Pyth

<    1   2   3   4   >