Francois,
Don't get me wrong, I really appreciate your suggestions to improve ICS. If
you see the history in each source file, you'll see the large number of
contributors.
I got your point, but I really wonder, what kind of suggestions will you accept
if:
1) small internal changes you don't
I got your point, but I really wonder, what kind of suggestions
will you accept if:
1) small internal changes you don't like because version comparing
becomes more sophisticated
Someone has to implement and test those changes, and there is always a
risk of unforseen complications or new
This is an and not an or. The exception is raised when FProtoStr is
neither 'tcp' no '6'.
Aaaah, yeah, I got it. Seems my mind was too sleepy yesterday ;)
Probably. Maybe you'll implement those features ?
I could make a try when I have some time, but it will be a kind of sketch
anyway, as I
When Unicode Delphi came out the goal was to port ICS with minimum
changes, I guess the same was true when Delphi .Net came out.
No argues, but sometimes the things done in hurry should be polished, shouldn't
they?
About .Net: I see that it's in eraly development stage, so let it go as you
if (_LowerCase(FProtoStr) 'tcp') and (_Trim(FProtoStr) '6') then
begin
RaiseException('TCP is the only protocol supported thru socks
server'); { V5.26 }
Exit;
end;
a) looks quite weird, as it likely to throw exception in every case
(FProtoStr can't be equal to 'tcp'
Anton Sviridov wrote:
Having looked at the OverbyteIcsWSocket unit, I've noticed many IFDEF
CLR which probably might be removed.
First of all, I think it's better to turn all buffers from PAnsiChar
/ array of AnsiChar to TBytes, as it is recommended by Embarcadero
(though one would declare
Having looked at the OverbyteIcsWSocket unit, I've noticed many IFDEF CLR which
probably might be removed.
First of all, I think it's better to turn all buffers from PAnsiChar / array of
AnsiChar to TBytes, as it is recommended by Embarcadero (though one would
declare this type for compilers
And even more:
1)
procedure TCustomSocksWSocket.SetSocksServer(sServer : String);
begin
...
if Length(FSocksServer) = 0 then begin
FSocksServerAssigned := FALSE;
Exit;
end;
FSocksServerAssigned := TRUE;
end;
=
FSocksServerAssigned := Length(FSocksServer) 0;