Re: [Txaws-dev] [Merge] lp:~radix/txaws/parameter-enrichment into lp:txaws

2012-04-26 Thread Thomas Herve
Review: Approve [1] In _secret_convert_old_schema, you should pass item.name as name parameter to List, to keep compatibility. [2] You also need to forward the optional parameter. [3] Still in the sample, it seems you should forward the default value, and use [] otherwise as default. [4] In

[Txaws-dev] [Merge] lp:~radix/txaws/parameter-enrichment into lp:txaws

2012-04-25 Thread Christopher Armstrong
Christopher Armstrong has proposed merging lp:~radix/txaws/parameter-enrichment into lp:txaws. Requested reviews: txAWS Technical List (txaws-tech) txAWS Technical List (txaws-tech) Related bugs: Bug #984660 in txAWS: Enrich schema declarations to allow for describing all the details of

[Txaws-dev] [Merge] lp:~radix/txaws/parameter-enrichment into lp:txaws

2012-04-25 Thread Christopher Armstrong
You have been requested to review the proposed merge of lp:~radix/txaws/parameter-enrichment into lp:txaws. For more details, see: https://code.launchpad.net/~radix/txaws/parameter-enrichment/+merge/103592 This is one part of schema enrichment. It adds List and Structure Parameter types, and