Re: [U-Boot] [RFC] 83xx: uec: miiphybb: Added support for bitBang SMI and uec SMI enabled at the same time.

2010-01-17 Thread Ben Warren
Hi Richard, Richard Retanubun wrote: Wolfgang Denk wrote: snip Can you please check the status of this patch: http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/61758 Thanks. Best regards, Wolfgang Denk Hello, Wofgang, I believe at the time Ben made the comment that my patch's

[U-Boot] MMC problem in PXA270 hardware

2010-01-17 Thread Vaisakh
Hi, I am trying bring up MMC in our hardware which is running on PXA270 processor with 128 MB RAM. But i am not able to detect the SDCARD, as it is showing the invalid partition table (the dos partition magic number is not correct, it is 44aa, instead of 55 aa), what could be the problem for such

Re: [U-Boot] [PATCH v5 08/12] SPEAr : Support for HW mac id read/write from i2c mem

2010-01-17 Thread Ben Warren
Hi Vipin, Sorry for chiming in so late in the review process. Vipin KUMAR wrote: This patch adds the support to read and write mac id from i2c memory. For reading: if (env contains ethaddr) pick env ethaddr else pick ethaddr from i2c memory For

Re: [U-Boot] [PATCH V2 1/9] mkimage: Add Freescale imx Boot Image support (imximage)

2010-01-17 Thread Stefano Babic
Wolfgang Denk wrote: Dear Stefano Babic, Hi Wolfgang, Line to long. And please try to stick with a consistent error message format. I see I have too long lines in all patches I have sent. I check this issue for all of them. +return (params-dflag (params-fflag || params-lflag)) ||

Re: [U-Boot] [PATCH 3/9] MX51: Add register definitions

2010-01-17 Thread Stefano Babic
Wolfgang Denk wrote: Dear Stefano Babic, Hi Wolfgang, +#define MXC_CCM_CBCDR_EMI_PODF_OFFSET (22) Thanks, I do it. +/* WEIM registers */ +#define CSGCR1 0x00 +#define CSGCR2 0x04 +#define CSRCR1 0x08 +#define CSRCR2 0x0C +#define CSWCR1 0x10

[U-Boot] Antw: Re: [PATCH] Add support for jadecpu board

2010-01-17 Thread Matthias Weisser
Hello Wolfgang Wolfgang Denk w...@denx.de schrieb am 16.01.2010 um 21:11: Dear Matthias Weisser, In message 4b5210ea.8000...@windriver.com Tom Rix wrote: index ed6156f..98c147d 100644 --- a/Makefile +++ b/Makefile @@ -2874,6 +2874,13 @@ TNY_A9260_config: unconfig

Re: [U-Boot] [PATCH 2/9] MX51: Add initial support for the Freescale MX51

2010-01-17 Thread Stefano Babic
Wolfgang Denk wrote: Dear Stefano Babic, Hi Wolfgang, It makes little sense to implement arch specific commands that will most probably repeated - I don;t want to see a mx51clocks command here, and mx25clocks, mx27clocks, mx31clocks, mx35clocks, ... commands on other systems. Just name

Re: [U-Boot] [PATCH v5 08/12] SPEAr : Support for HW mac id read/write from i2c mem

2010-01-17 Thread Vipin KUMAR
On 1/18/2010 11:45 AM, Ben Warren wrote: int misc_init_r(void) { +#if defined(CONFIG_CMD_NET) +uchar mac_id[6]; + +if (!eth_getenv_enetaddr(ethaddr, mac_id) !i2c_read_mac(mac_id)) +eth_setenv_enetaddr(ethaddr, mac_id); It's really not a good idea to programatically

Re: [U-Boot] [PATCH v5 08/12] SPEAr : Support for HW mac id read/write from i2c mem

2010-01-17 Thread Mike Frysinger
On Monday 18 January 2010 01:15:43 Ben Warren wrote: Vipin KUMAR wrote: This patch adds the support to read and write mac id from i2c memory. For reading: if (env contains ethaddr) pick env ethaddr else pick ethaddr from i2c memory For writing:

Re: [U-Boot] [PATCH 5/9] serial_mxc: add support for MX51 processor

2010-01-17 Thread Stefano Babic
Wolfgang Denk wrote: Dear Stefano Babic, Hi Wolfgang, @@ -49,8 +51,14 @@ #define UART_PHYS 0x1001b000 #elif defined(CONFIG_SYS_MX27_UART6) #define UART_PHYS 0x1001c000 +#elif defined(CONFIG_SYS_MX51_UART1) +#define UART_PHYS UART1_BASE_ADDR +#elif defined(CONFIG_SYS_MX51_UART2)

Re: [U-Boot] [PATCH v5 08/12] SPEAr : Support for HW mac id read/write from i2c mem

2010-01-17 Thread Ben Warren
Vipin, Vipin KUMAR wrote: On 1/18/2010 11:45 AM, Ben Warren wrote: int misc_init_r(void) { +#if defined(CONFIG_CMD_NET) +uchar mac_id[6]; + +if (!eth_getenv_enetaddr(ethaddr, mac_id) !i2c_read_mac(mac_id)) +eth_setenv_enetaddr(ethaddr, mac_id); It's

Re: [U-Boot] [PATCH v5 08/12] SPEAr : Support for HW mac id read/write from i2c mem

2010-01-17 Thread Vipin KUMAR
On 1/18/2010 12:49 PM, Ben Warren wrote: if (chip-cpufreq == -1) @@ -156,6 +215,13 @@ int do_chip_config(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) else printf(DDR Type= Not Known\n); +if (!i2c_read_mac(mac)) { +

Re: [U-Boot] [PATCH 9/9] Add initial support for Freescale mx51evk board

2010-01-17 Thread Stefano Babic
Wolfgang Denk wrote: Dear Stefano Babic, Hi Wolfgang, +$(obj)u-boot.imx: $(obj)u-boot.bin +$(obj)tools/mkimage -n $(IMX_CONFIG) -T imximage \ +-e $(TEXT_BASE) -d $ $@ This actually belongs into the patch that adds the imx image format support. Correct,

Re: [U-Boot] [PATCH 3/9] MX51: Add register definitions

2010-01-17 Thread Wolfgang Denk
Dear Stefano, In message 4b54024e.1070...@denx.de you wrote: +#define PLL_DP_CTL0x00 +#define PLL_DP_CONFIG 0x04 +#define PLL_DP_OP 0x08 +#define PLL_DP_MFD0x0C +#define PLL_DP_MFN0x10 +#define PLL_DP_MFNMINUS 0x14 +#define PLL_DP_MFNPLUS0x18

Re: [U-Boot] [PATCH] Add support for jadecpu board

2010-01-17 Thread Matthias Weißer
Hi Tom thanks for your feedback. Am 16.01.2010 20:18, schrieb Tom: +/* + * Miscellaneous platform dependent initialisations + */ +int board_init(void) +{ board_init should fill out entries in structglobal_data. See other board like lopgicpd/zoom1 as an example. Make sure to

Re: [U-Boot] Antw: Re: [PATCH] Add support for jadecpu board

2010-01-17 Thread Wolfgang Denk
Dear Matthias Weisser, In message 4b541652.2e8a.006...@graf-syteco.de you wrote: --- a/Makefile +++ b/Makefile @@ -2874,6 +2874,13 @@ TNY_A9260_config : unconfig @echo #define CONFIG_$(@:_config=) 1 $(obj)include/config.h @$(MKCONFIG) -a tny_a9260 arm

<    1   2