Re: [PATCH 13/13] cbfs: Don't require the CBFS size with cbfs_init_mem()

2020-05-20 Thread Bin Meng
On Wed, May 13, 2020 at 10:24 PM Simon Glass wrote: > > The size is not actually used since it is present in the header. Drop this > parameter. Also tidy up error handling while we are here. > > Signed-off-by: Simon Glass > --- > > arch/x86/lib/fsp2/fsp_init.c | 3 +-- > fs/cbfs/cbfs.c

Re: [PATCH 12/13] cbfs: Allow reading a file from a CBFS given its base addr

2020-05-20 Thread Bin Meng
Hi Simon, On Wed, May 13, 2020 at 10:24 PM Simon Glass wrote: > > Currently we support reading a file from CBFS given the address of the end > of the ROM. Sometimes we only know the start of the CBFS. Add a function > to find a file given that. > > Signed-off-by: Simon Glass > --- > >

Re: [PATCH 11/13] cbfs: Change file_cbfs_find_uncached() to return an error

2020-05-20 Thread Bin Meng
Hi Simon, On Wed, May 13, 2020 at 10:24 PM Simon Glass wrote: > > This function currently returns a node pointer so there is no way to know > the error code. Also it uses data in BSS which seems unnecessary since the > caller might prefer to use a local variable. > > Update the function and

Re: [PATCH v12 21/21] riscv: Add Sipeed Maix support

2020-05-20 Thread Rick Chen
Hi Sean > > The Sipeed Maix series is a collection of boards built around the RISC-V > Kendryte K210 processor. This processor contains several peripherals to > accelerate neural network processing and other "ai" tasks. This includes a > "KPU" neural network processor, an audio processor

Re: [PATCH 10/13] cbfs: Return the error code from file_cbfs_init()

2020-05-20 Thread Bin Meng
On Wed, May 13, 2020 at 10:24 PM Simon Glass wrote: > > We may as well return the error code and use it directly in the command > code. CBFS still uses its own error enum which we may be able to remove, > but leave it for now. > > Signed-off-by: Simon Glass > --- > > cmd/cbfs.c | 3 +-- >

Re: [PATCH 09/13] cbfs: Record the start address in cbfs_priv

2020-05-20 Thread Bin Meng
On Wed, May 13, 2020 at 10:24 PM Simon Glass wrote: > > The start address of the CBFS is used when scanning for files. It makes > sense to put this in our cbfs_priv struct and calculate it when we read > the header. > > Update the code accordingly. > > Signed-off-by: Simon Glass > --- > >

Re: [PATCH 08/13] cbfs: Use void * for the position pointers

2020-05-20 Thread Bin Meng
On Wed, May 13, 2020 at 10:24 PM Simon Glass wrote: > > It doesn't make sense to use u8 * as the pointer type for accessing the > CBFS since we do not access it as bytes, but via structures. Change it to > void *, which allows us to avoid a cast. > > Signed-off-by: Simon Glass > --- > >

Re: [PATCH 07/13] cbfs: Unify the two header loaders

2020-05-20 Thread Bin Meng
Hi Simon, On Wed, May 13, 2020 at 10:24 PM Simon Glass wrote: > > These two functions have mostly the same code. Pull this out into a common > function. > > Also make this function zero the private data so that callers don't have > to do it. Finally, update cbfs_load_header_ptr() to take the

Re: [PATCH 2/2] fdtdec: Honor #address-cells and #size-cells in fdtdec_add_reserved_memory()

2020-05-20 Thread Bin Meng
Hi Simon, On Wed, May 20, 2020 at 10:20 PM Simon Glass wrote: > > Hi Bin, > > On Wed, 20 May 2020 at 00:38, Bin Meng wrote: > > > > From: Bin Meng > > > > At present fdtdec_add_reserved_memory() calls fdtdec_get_addr_size() > > to get address and size for the subnodes of /reserved-memory node.

Re: [RESEND PATCH] usb: dwc3: fix NULL pointer issue

2020-05-20 Thread Chunfeng Yun
zation rejected your message: mail-in.m-online.net [212.114.242.10]. Diagnostic information for administrators: Generating server: mailgw01.mediatek.com ma...@denx.de mail-in.m-online.net [212.114.242.10] Remote Server returned '' Original message headers: X-UUID: 6e032eea3af94db48b3664ec882

Re: [PATCH 1/1] test: stabilize test_efi_secboot

2020-05-20 Thread AKASHI Takahiro
Heinrich, On Mon, May 11, 2020 at 03:56:56PM +0900, AKASHI Takahiro wrote: > Heinrich, > > On Fri, May 08, 2020 at 08:10:28AM +0900, AKASHI Takahiro wrote: > > On Thu, May 07, 2020 at 11:14:17PM +0200, Heinrich Schuchardt wrote: > > > On 5/7/20 2:36 AM, AKASHI Takahiro wrote: > > > > Heinrich, >

Re: [PATCH] efi_loader: Remove unnecessary debug

2020-05-20 Thread AKASHI Takahiro
On Tue, May 19, 2020 at 12:24:27PM +0200, Heinrich Schuchardt wrote: > On 19.05.20 12:13, Pragnesh Patel wrote: > > Remove unnecessary debug() from efi_set_variable_common(). > > native_name is NULL, so there is no meaning to print it. > > > > Signed-off-by: Pragnesh Patel > > Reviewed-by:

[PATCH 1/1] efi_loader: device path for SATA devices

2020-05-20 Thread Heinrich Schuchardt
Provide device path nodes for SATA devices. This avoids creation of two handles with the same device path indicating our root node. This is what the device paths for a SATA drive with four partitions could like: /VenHw(..)/Sata(0x0,0x,0x0)

[PATCH 1/1] efi_loader: device path for virtio block devices

2020-05-20 Thread Heinrich Schuchardt
The UEFI specification does not define a device sub-type for virtio. Let's use a vendor hardware node here. This avoids creation of two handles with the same device path indicating our root node. Reported-by: Ard Biesheuvel Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h

[PATCH 1/1] doc: driver-model: there is no UCLASS_SATA

2020-05-20 Thread Heinrich Schuchardt
%s/UCLASS_SATA/UCLASS_AHCI/g Signed-off-by: Heinrich Schuchardt --- doc/driver-model/design.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/driver-model/design.rst b/doc/driver-model/design.rst index 635effcef6..9e9272777d 100644 --- a/doc/driver-model/design.rst +++

[PATCH 1/1] MAINTAINERS: add doc/driver-model/ to DRIVER MODEL

2020-05-20 Thread Heinrich Schuchardt
The documentation should rest with the same maintainer as the code. Signed-off-by: Heinrich Schuchardt --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8add9d4c2a..d1c4a28ce3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -607,6 +607,7 @@ DRIVER

Re: pull request of u-boot-fsl-qoriq for v2020.07

2020-05-20 Thread Tom Rini
On Wed, May 20, 2020 at 05:19:12AM +, Priyanka Jain wrote: > Dear Tom, > > Please find my pull-request for u-boot-fsl-qoriq/master > https://travis-ci.org/github/p-priyanka-jain/u-boot/builds > > > Summary > Add DM_ETH support for lx2160aqds, ls2080aqds, ls1088aqds > QSI related fixes on

[PATCH 1/1] efi_loader: initialize root node first

2020-05-20 Thread Heinrich Schuchardt
With commit 16ad946f41d3 ("efi_loader: change setup sequence") the detection of block device was moved to the start of the initialization sequence. In the case of virtio devices to two handles with the same device path being created. The root node handle should be created before anything else.

[PATCH v12 21/21] riscv: Add Sipeed Maix support

2020-05-20 Thread Sean Anderson
The Sipeed Maix series is a collection of boards built around the RISC-V Kendryte K210 processor. This processor contains several peripherals to accelerate neural network processing and other "ai" tasks. This includes a "KPU" neural network processor, an audio processor supporting beamforming

[PATCH v12 15/21] riscv: Add option to support RISC-V privileged spec 1.9

2020-05-20 Thread Sean Anderson
Some older processors (notably the Kendryte K210) use an older version of the RISC-V privileged specification. The primary changes between the old and new are in virtual memory, and in the merging of three separate counter enable CSRs. Using the new CSR on an old processor causes an illegal

[PATCH v12 19/21] riscv: Add device tree for K210 and Sipeed Maix BitM

2020-05-20 Thread Sean Anderson
Where possible, I have tried to find compatible drivers based on the layout of registers. However, many devices remain untested. All untested devices have been left disabled, but some tentative properties (such as compatible strings, and clocks, interrupts, and resets properties) have been added.

[PATCH v12 17/21] riscv: Try to get cpu frequency from a "clocks" node if it exists

2020-05-20 Thread Sean Anderson
Instead of always using the "clock-frequency" property to determine cpu frequency, try using a clock in "clocks" if it exists. This patch also fixes a bug where there could be spurious higher frequencies if sizeof(u32) != sizeof(ulong). Signed-off-by: Sean Anderson Reviewed-by: Bin Meng ---

[PATCH v12 18/21] riscv: Enable cpu clock if it is present

2020-05-20 Thread Sean Anderson
The cpu clock is probably already enabled if we are executing code (though we could be executing from a different core). This patch prevents the cpu clock or its parents from being disabled. Signed-off-by: Sean Anderson Reviewed-by: Bin Meng --- This patch was previously submitted on its own as

[PATCH v12 20/21] doc: riscv: Add documentation for Sipeed Maix Bit

2020-05-20 Thread Sean Anderson
This patch adds documentation for the Sipeed Maix bit, and more generally for the Kendryte K210 processor. Signed-off-by: Sean Anderson --- Changes in v9: - Mark dts code block as "none" explicitly Changes in v7: - Split off into its own patch - Fix size of clint doc/board/index.rst|

[PATCH v12 16/21] riscv: Allow use of reset drivers

2020-05-20 Thread Sean Anderson
Currently, one cannot use a reset driver on RISC-V. Follow the MIPS example, and disable the default reset handler when the sysreset driver is enabled. Signed-off-by: Sean Anderson Reviewed-by: Bin Meng --- Changes in v3: - New arch/riscv/lib/reset.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH v12 14/21] riscv: Clean up IPI initialization code

2020-05-20 Thread Sean Anderson
The previous IPI code initialized the device whenever the first call was made to a riscv_*_ipi function. This made it difficult to determine when the IPI device was initialized. This patch introduces a new function riscv_init_ipi. It is called once during arch_cpu_init_dm. In SPL, it is called in

[PATCH v12 10/21] reset: Add generic reset driver

2020-05-20 Thread Sean Anderson
This patch adds a generic reset driver. It is designed to be useful when one has a register in a regmap which contains bits that reset other devices. I thought this seemed like a very generic use, so here is a generic driver. The overall structure has been modeled on the syscon-reboot driver.

[PATCH v12 12/21] riscv: Add headers for asm/global_data.h

2020-05-20 Thread Sean Anderson
This header depended on bd_t and ulong, but did not include the appropriate headers. Signed-off-by: Sean Anderson Reviewed-by: Bin Meng --- Changes in v4: - Include compiler.h not linux/compiler.h arch/riscv/include/asm/global_data.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v12 13/21] riscv: Clear pending interrupts before enabling IPIs

2020-05-20 Thread Sean Anderson
On some platforms (k210), the previous stage bootloader may have not cleared pending IPIs before transferring control to U-Boot. This can cause race conditions, as multiple harts all attempt to initialize the IPI controller at once. This patch clears IPIs before enabling them, ensuring that only

[PATCH v12 11/21] lib: Always set errno in hcreate_r

2020-05-20 Thread Sean Anderson
This could give a confusing error message if it failed and didn't set errno. Signed-off-by: Sean Anderson Reviewed-by: Bin Meng --- Changes in v5: - New lib/hashtable.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/hashtable.c b/lib/hashtable.c index

[PATCH v12 08/21] dm: Add support for simple-pm-bus

2020-05-20 Thread Sean Anderson
This type of bus is used in Linux to designate buses which have power domains and/or clocks which need to be enabled before their child devices can be used. Because power domains are automatically enabled before probing in U-Boot, we just need to enable any clocks present. Signed-off-by: Sean

[PATCH v12 05/21] clk: Add K210 pll support

2020-05-20 Thread Sean Anderson
This pll code is primarily based on the code from the kendryte standalone sdk in lib/drivers/sysctl.c. k210_pll_calc_config is roughly analogous to the algorithm used to set the pll frequency, but it has been completely rewritten to be fixed-point based. Signed-off-by: Sean Anderson CC: Lukasz

[PATCH v12 07/21] clk: Add K210 clock support

2020-05-20 Thread Sean Anderson
Due to the large number of clocks, I decided to use the CCF. The overall structure is modeled after the imx code. Clocks parameters are stored in several arrays, and are then instantiated at run-time. There are some translation macros (FOOIFY()) which allow for more dense packing. Signed-off-by:

[PATCH v12 09/21] dm: Fix error handling for dev_read_addr_ptr

2020-05-20 Thread Sean Anderson
dev_read_addr_ptr had different semantics depending on whether OF_LIVE was enabled. This patch converts both implementations to return NULL on error, and converts all call sites which check for FDT_ADDR_T_NONE to check for NULL instead. This patch also removes the call to map_physmem, since we

[PATCH v12 06/21] clk: Add a bypass clock for K210

2020-05-20 Thread Sean Anderson
This is a small driver to do a software bypass of a clock if hardware bypass is not working. I have tried to write this in a generic fashion, so that it could be potentially broken out of the kendryte code at some future date. For the K210, it is used to have aclk bypass pll0 and use in0 instead

[PATCH v12 01/21] clk: Always use the supplied struct clk

2020-05-20 Thread Sean Anderson
CCF clocks should always use the struct clock passed to their methods for extracting the driver-specific clock information struct. Previously, many functions would use the clk->dev->priv if the device was bound. This could cause problems with composite clocks. The individual clocks in a composite

[PATCH v12 04/21] clk: Fix clk_get_by_* handling of index

2020-05-20 Thread Sean Anderson
clk_get_by_index_nodev only ever fetched clock 1, due to passing a boolean predicate instead of the index. Other clk_get_by_* functions got the clock correctly, but passed a predicate instead of the index to clk_get_by_tail. This could lead to confusing error messages. Signed-off-by: Sean

[PATCH v12 00/21] riscv: Add Sipeed Maix support

2020-05-20 Thread Sean Anderson
This patch series adds support for Sipeed Maix boards and the Kendryte K210 CPU. Currently, only the Maix Bit V2.0 is supported, however other models are similar. Known Bugs/Limitations: - Accessing the AI ram hangs, limiting available ram to 6M - Trying to boot an image with bootm fails with

[PATCH v12 02/21] clk: Check that ops of composite clock components exist before calling

2020-05-20 Thread Sean Anderson
clk_composite_ops was shared between all devices in the composite clock driver. If one clock had a feature (such as supporting set_parent) which another clock did not, it could call a null pointer dereference. This patch does three things 1. It adds null-pointer checks to all composite clock

[PATCH v12 03/21] clk: Unconditionally recursively en-/dis-able clocks

2020-05-20 Thread Sean Anderson
For clocks not in the CCF, their parents will not have UCLASS_CLK, so we just enable them as normal. The enable count is local to the struct clk, but this will never result in the actual en-/dis-able op being called (unless the same struct clk is enabled twice). For clocks in the CCF, we always

Re: [PATCH] rockchip: rk3328: rock64 - fix gen3 SPL hang

2020-05-20 Thread Matwey V. Kornilov
ср, 20 мая 2020 г. в 20:41, Kurt Miller : > > On Wed, 2020-05-20 at 16:30 +0800, Chen-Yu Tsai wrote: > > On Wed, May 20, 2020 at 4:05 PM Matwey V. Kornilov > > wrote: > > > > > > > > > вт, 19 мая 2020 г. в 17:30, Kurt Miller : > > > > > > > > > > > > On Tue, 2020-05-19 at 12:48 +0300, Matwey V.

Re: [PATCH] rockchip: rk3328: rock64 - fix gen3 SPL hang

2020-05-20 Thread Matwey V. Kornilov
ср, 13 мая 2020 г. в 22:55, Kurt Miller : > > Use the same approach as ROC-RK3328-CC which enables SPL GPIO, > pinctl and regulator support. This allows the gen3 board to > boot through SPL and does not break gen2 in the process. > > Signed-off-by: Kurt Miller Acked-by: Matwey V. Kornilov >

Re: [PATCH] rockchip: rk3328: rock64 - fix gen3 SPL hang

2020-05-20 Thread Kurt Miller
On Wed, 2020-05-20 at 16:30 +0800, Chen-Yu Tsai wrote: > On Wed, May 20, 2020 at 4:05 PM Matwey V. Kornilov > wrote: > > > > > > вт, 19 мая 2020 г. в 17:30, Kurt Miller : > > > > > > > > > On Tue, 2020-05-19 at 12:48 +0300, Matwey V. Kornilov wrote: > > > > > > > > вт, 19 мая 2020 г. в

Re: [PATCH v2 2/3] spl: fit: fail fit loading in case of FDT appending error

2020-05-20 Thread Michael Nazzareno Trimarchi
Hi Dario On Mon, May 11, 2020 at 8:43 AM Dario Binacchi wrote: > > If uboot does not embed its device tree and the FIT loading function > returns error in case of failure in the FDT append, the redundant itb > image could be loaded. > > cc: Michael Trimarchi > Signed-off-by: Dario Binacchi > >

[PATCH] phy: Fix possible NULL pointer deference

2020-05-20 Thread Vignesh Raghavendra
It is possible that users of generic_phy_*() APIs may pass a valid struct phy pointer but phy->dev can be NULL, leading to NULL pointer deference in phy_dev_ops(). So call generic_phy_valid() to verify that phy and phy->dev are both valid. Signed-off-by: Vignesh Raghavendra ---

Re: [PATCH v4] dm: uclass: don't assign aliased seq numbers

2020-05-20 Thread Michael Walle
Hi Simon, Am 2020-05-19 18:47, schrieb Simon Glass: Hi Michael, On Tue, 19 May 2020 at 06:17, Michael Walle wrote: Hi Simon, Am 2020-04-24 16:17, schrieb Michael Walle: > Hi Simon, > > Am 2020-04-20 01:38, schrieb Simon Glass: > > [..snip..] > >>> > uclass 31: eth >>> > 0 * smsc95xx_eth

[PATCH v5 1/2] usb: provide a device tree node to USB devices

2020-05-20 Thread Michael Walle
It is possible to specify a device tree node for an USB device. This is useful if you have a static USB setup and want to use aliases which point to these nodes, like on the Raspberry Pi. The nodes are matched against their hub port number, the compatible strings are not matched for now.

[PATCH v5 2/2] dm: uclass: don't assign aliased seq numbers

2020-05-20 Thread Michael Walle
If there are aliases for an uclass, set the base for the "dynamically" allocated numbers next to the highest alias. Please note, that this might lead to holes in the sequences, depending on the device tree. For example if there is only an alias "ethernet1", the next device seq number would be 2.

Re: patman: ImportError

2020-05-20 Thread Stefan Bosch
Hi Simon, Am 20.05.20 um 02:52 schrieb Simon Glass: Hi Stefan, On Sun, 17 May 2020 at 07:54, Stefan Bosch wrote: Hi Simon, Am 17.05.20 um 01:03 schrieb Simon Glass: Hi Stefan, On Sat, 16 May 2020 at 05:27, Stefan Bosch wrote: Hello, recently, I updated my local repository (U-Boot

Re: Regression when building with DEVICE_TREE parameter

2020-05-20 Thread Masahiro Yamada
On Wed, May 20, 2020 at 10:50 PM Patrice CHOTARD wrote: > > Hi Masahiro > > As indicated into doc/README.fdt-control, it's possible build U-boot with > specifying dts-file-name using > $ make DEVICE_TREE= I think this doc might be misleading. The intended usage is like this. If you see

Re: [PATCH v1 2/3] board: ns3: add FIT image its file

2020-05-20 Thread Pramod Kumar
Hi Thomas, This is generic and used for development. Specific keys will be used by Customer/Specific applications. Regards, Pramod On Wed, May 20, 2020 at 7:25 AM Thomas Fitzsimmons wrote: > Hi Rayagonda and Pramod, > > Rayagonda Kokatanur writes: > > > From: Pramod Kumar > > > > Add FIT

Re: [PATCH 3/6] ARM: uniphier: drop #include again from umc-pxs2.c

2020-05-20 Thread Simon Glass
On Tue, 19 May 2020 at 21:32, Masahiro Yamada wrote: > > I do not understand the change made to this file by > commit 691d719db718 ("common: Drop init.h from common header"). > > git show 691d719db718 -- arch/arm/mach-uniphier/dram/umc-pxs2.c > > This file does not call or define any functions

RE: [PATCH v11 15/18] sifive: fu540: Add sample SD gpt partition layout

2020-05-20 Thread Pragnesh Patel
Hi Bin/Jagan, >-Original Message- >From: Bin Meng >Sent: 20 May 2020 19:30 >To: Pragnesh Patel >Cc: U-Boot Mailing List ; Atish Patra >; Palmer Dabbelt ; Paul >Walmsley ; Jagan Teki >; Anup Patel ; Sagar >Kadam ; Rick Chen ; Palmer >Dabbelt >Subject: Re: [PATCH v11 15/18] sifive:

Re: [PATCH 5/6] ARM: uniphier: delete or replace includes

2020-05-20 Thread Simon Glass
On Tue, 19 May 2020 at 21:32, Masahiro Yamada wrote: > > pulls in a lot of bloat. is unneeded in most of > places. > > Signed-off-by: Masahiro Yamada > --- > > arch/arm/mach-uniphier/arm32/cache-uniphier.c | 1 - > arch/arm/mach-uniphier/arm32/psci.c | 1 - >

Re: [PATCH 4/6] ARM: uniphier: drop #include again

2020-05-20 Thread Simon Glass
Hi Masahiro, On Tue, 19 May 2020 at 21:32, Masahiro Yamada wrote: > > I do not understand the changes made to these files by > commit f7ae49fc4f36 ("common: Drop log.h from common header"). > > git show f7ae49fc4f36 -- arch/arm/mach-uniphier/ > > None of them uses the log function feature. > >

Re: [PATCH 2/2] fdtdec: Honor #address-cells and #size-cells in fdtdec_add_reserved_memory()

2020-05-20 Thread Simon Glass
Hi Bin, On Wed, 20 May 2020 at 00:38, Bin Meng wrote: > > From: Bin Meng > > At present fdtdec_add_reserved_memory() calls fdtdec_get_addr_size() > to get address and size for the subnodes of /reserved-memory node. > > We should honor #address-cells and #size-cells properties in the > parent

Re: [PATCH 1/6] ARM: uniphier: include instead of from psci.c

2020-05-20 Thread Simon Glass
Hi Masahiro, On Tue, 19 May 2020 at 21:32, Masahiro Yamada wrote: > > I do not understand the change made to this file by > commit 90526e9fbac4 ("common: Drop net.h from common header"). > > git show 90526e9fbac4 -- arch/arm/mach-uniphier/arm32/psci.c > > It added while this file does not

Re: [PATCH v1 00/15] add basic driver support for broadcom NS3 soc

2020-05-20 Thread Simon Glass
Hi Rayagonda, On Tue, 19 May 2020 at 23:19, Rayagonda Kokatanur wrote: > > Hi Thomas, > > On Wed, May 20, 2020 at 7:34 AM Thomas Fitzsimmons > wrote: > > > > Rayagonda Kokatanur writes: > > > > > On Tue, May 19, 2020 at 11:01 PM Tom Rini wrote: > > >> > > >> On Tue, May 19, 2020 at

Re: [PATCH 1/2] fdtdec: Fix the types of addr and size in fdtdec_add_reserved_memory()

2020-05-20 Thread Simon Glass
On Wed, 20 May 2020 at 00:38, Bin Meng wrote: > > From: Bin Meng > > fdtdec_get_addr_size() expects size is of type 'fdt_size_t', and > return value is of type 'fdt_addr_t'. Adjust their types accordingly. > > Signed-off-by: Bin Meng > --- > > lib/fdtdec.c | 3 ++- > 1 file changed, 2

Re: Warnings on Edison

2020-05-20 Thread Andy Shevchenko
On Wed, May 20, 2020 at 09:35:34AM -0400, Tom Rini wrote: ... > as Edison still works. I believe no-one who is building it from sources for Edison uses that old ACPICA tools. -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 1/9] spl: Try to get SPL boot device via board_get_int

2020-05-20 Thread Tom Rini
On Wed, May 20, 2020 at 06:46:55PM +0530, Jagan Teki wrote: > On Wed, May 20, 2020 at 6:32 PM Tom Rini wrote: > > > > On Wed, May 20, 2020 at 12:53:32AM +0530, Jagan Teki wrote: > > > > > Usually, the associated board would supply spl boot device > > > using spl_boot_device() but some boards have

Re: [PATCH v11 15/18] sifive: fu540: Add sample SD gpt partition layout

2020-05-20 Thread Bin Meng
Hi Pragnesh, On Tue, May 19, 2020 at 3:05 PM Pragnesh Patel wrote: > > From: Jagan Teki > > This is a sample GPT partition layout for SD card, > right now three important partitions are added to > make the system bootable. > > partition layout: > > PartStart LBA End LBA Name >

RE: [PATCH v11 00/18] RISC-V SiFive FU540 support SPL

2020-05-20 Thread Pragnesh Patel
Hi Bin, >-Original Message- >From: Bin Meng >Sent: 20 May 2020 19:15 >To: Pragnesh Patel >Cc: Rick Chen ; Jagan Teki >; Sean Anderson ; U- >Boot Mailing List ; rick ; Alan >Kao >Subject: Re: [PATCH v11 00/18] RISC-V SiFive FU540 support SPL > >[External Email] Do not click links or

RE: [PATCH v10 17/18] configs: fu540: Add config options for U-Boot SPL

2020-05-20 Thread Pragnesh Patel
Hi Bin, >-Original Message- >From: Bin Meng >Sent: 20 May 2020 19:14 >To: Pragnesh Patel >Cc: Jagan Teki ; U-Boot-Denx b...@lists.denx.de>; Atish Patra ; Palmer Dabbelt >; Paul Walmsley ; >Anup Patel ; Sagar Kadam >; Rick Chen ; Palmer >Dabbelt >Subject: Re: [PATCH v10 17/18] configs:

Regression when building with DEVICE_TREE parameter

2020-05-20 Thread Patrice CHOTARD
Hi Masahiro As indicated into doc/README.fdt-control, it's possible build U-boot with specifying dts-file-name using $ make DEVICE_TREE= But since your commit a3444bd09af9 ("Revert "Ensure device tree DTS is compiled") it's no more possible: make ARCH=arm CROSS_COMPILE=$CROSS_COMPILE -j 16

Re: [PATCH v11 00/18] RISC-V SiFive FU540 support SPL

2020-05-20 Thread Bin Meng
Hi Pragnesh, On Wed, May 20, 2020 at 7:52 PM Pragnesh Patel wrote: > > Hi Bin, > > >-Original Message- > >From: Bin Meng > >Sent: 20 May 2020 15:54 > >To: Pragnesh Patel > >Cc: Rick Chen ; Jagan Teki > >; Sean Anderson ; U- > >Boot Mailing List ; rick ; Alan > >Kao > >Subject: Re:

Re: [PATCH v10 17/18] configs: fu540: Add config options for U-Boot SPL

2020-05-20 Thread Bin Meng
Hi Pragnesh, On Wed, May 20, 2020 at 9:33 PM Pragnesh Patel wrote: > > Hi Jagan, > > >-Original Message- > >From: U-Boot On Behalf Of Pragnesh Patel > >Sent: 20 May 2020 12:55 > >To: Bin Meng ; Jagan Teki > > > >Cc: U-Boot-Denx ; Atish Patra > >; Palmer Dabbelt ; Paul > >Walmsley ; Anup

Re: Warnings on Edison

2020-05-20 Thread Tom Rini
On Wed, May 20, 2020 at 07:22:26AM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 20 May 2020 at 07:06, Tom Rini wrote: > > > > On Wed, May 20, 2020 at 11:17:17AM +0300, Andy Shevchenko wrote: > > > On Tue, May 19, 2020 at 10:47:27AM -0600, Simon Glass wrote: > > > > Hi Andy, > > > > > > > >

RE: [PATCH v10 17/18] configs: fu540: Add config options for U-Boot SPL

2020-05-20 Thread Pragnesh Patel
Hi Jagan, >-Original Message- >From: U-Boot On Behalf Of Pragnesh Patel >Sent: 20 May 2020 12:55 >To: Bin Meng ; Jagan Teki > >Cc: U-Boot-Denx ; Atish Patra >; Palmer Dabbelt ; Paul >Walmsley ; Anup Patel ; >Sagar Kadam ; Rick Chen ; >Palmer Dabbelt >Subject: RE: [PATCH v10 17/18]

[PATCH v2] imx: imx8qm_rom7720_a1: update README

2020-05-20 Thread Oliver Graute
Update README to extract firmware from scripts Signed-off-by: Oliver Graute --- board/advantech/imx8qm_rom7720_a1/README | 11 +++ 1 file changed, 11 insertions(+) diff --git a/board/advantech/imx8qm_rom7720_a1/README b/board/advantech/imx8qm_rom7720_a1/README index

Re: [PATCH] imx: imx8qm_rom7720_a1: update README

2020-05-20 Thread Oliver Graute
On 15/05/20, Oliver Graute wrote: > Update README to extract firmware from scripts > > Signed-off-by: Oliver Graute > --- > board/advantech/imx8qm_rom7720_a1/README | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/board/advantech/imx8qm_rom7720_a1/README >

Re: [PATCH v2 1/9] spl: Try to get SPL boot device via board_get_int

2020-05-20 Thread Jagan Teki
On Wed, May 20, 2020 at 6:32 PM Tom Rini wrote: > > On Wed, May 20, 2020 at 12:53:32AM +0530, Jagan Teki wrote: > > > Usually, the associated board would supply spl boot device > > using spl_boot_device() but some boards have board driver > > that are possible to supply boot device via

Re: [PATCH v2 2/9] dt-bindings: board: Document sifive, fu540-modeselect

2020-05-20 Thread Bin Meng
Hi Jagan, On Wed, May 20, 2020 at 3:24 AM Jagan Teki wrote: > > Add dt-bindings documentation for sifive,fu540-modeselect board > driver, which usually get runtime boot mode of fu540 boards. > > Cc: Simon Glass > Signed-off-by: Jagan Teki > --- > Changes for v2: > - new patch > >

Re: Warnings on Edison

2020-05-20 Thread Tom Rini
On Wed, May 20, 2020 at 11:17:17AM +0300, Andy Shevchenko wrote: > On Tue, May 19, 2020 at 10:47:27AM -0600, Simon Glass wrote: > > Hi Andy, > > > > When I build edison on master I recently started seeing this warning: > > > > +board/intel/edison/dsdt.asl.tmp210: Name (SSCN, Package

Re: [PATCH 1/7] amlogic: Remove ARCH= references from documentation

2020-05-20 Thread Neil Armstrong
Hi, Le 19/05/2020 à 16:51, Tom Rini a écrit : > When building U-Boot we select the architecture via Kconfig and not ARCH > being passed in via the environment or make cmdline. > > Cc: Beniamino Galvani > Cc: Neil Armstrong > Cc: u-boot-amlo...@groups.io > Signed-off-by: Tom Rini > --- > As an

Re: [PATCH v2 1/9] spl: Try to get SPL boot device via board_get_int

2020-05-20 Thread Tom Rini
On Wed, May 20, 2020 at 12:53:32AM +0530, Jagan Teki wrote: > Usually, the associated board would supply spl boot device > using spl_boot_device() but some boards have board driver > that are possible to supply boot device via board_get_int > with BOARD_SPL_BOOT_DEVICE id. > > This patch add

Re: [PATCH] image: Add support for ZSTD decompression

2020-05-20 Thread Tom Rini
On Wed, May 20, 2020 at 01:38:01PM +0200, Robert Marko wrote: > Tom, > I have tried various things but CONFIG_IS_ENABLED won't work inside of > switch case. > It works fine outside of if though. OK, thanks, I'll poke things more to make sure what I'm worried about doesn't happen. -- Tom

Re: [PATCH] armv8: cache_v8: fix mmu_set_region_dcache_behaviour

2020-05-20 Thread Tom Rini
On Wed, May 20, 2020 at 12:10:23PM +, Peng Fan wrote: > > Subject: [PATCH] armv8: cache_v8: fix mmu_set_region_dcache_behaviour > > Any comments? I'll put it on my list, thanks. -- Tom signature.asc Description: PGP signature

Re: [PATCH v2] cmd: avb: free partition buffer upon verify completion

2020-05-20 Thread Tom Rini
On Mon, May 11, 2020 at 12:11:53PM +0200, Gary Bisson wrote: > Doing the same as the unittests for libavb [1]. > > Allows to run 'avb verify' multiple times which can be useful after a > failure to be able to re-flash the partition and try again. > > [1] >

Re: [PATCH v2] drivers: crypto: mod_exp_sw: Re-add DM_FLAG_PRE_RELOC

2020-05-20 Thread Tom Rini
On Thu, May 07, 2020 at 08:36:03PM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > This driver is safe to use in SPL without relocation. Denying > DM_FLAG_PRE_RELOC prevents its usability for verifying the main U-Boot > or other artifacts from the SPL unless needless enabling the full driver >

Re: [PATCH v2] test: Use ut_asserteq_mem() where possible

2020-05-20 Thread Tom Rini
On Sun, May 10, 2020 at 12:52:45PM -0600, Simon Glass wrote: > Quite a few tests still use ut_assertok(memcmp(...)) and variants. Modify > them to use the macro designed for this purpose. > > Suggested-by: Wolfgang Wallner > > Signed-off-by: Simon Glass > Reviewed-by: Wolfgang Wallner

Re: [PATCH] mpc83xx: remove redundant MPC83xx_RESET #define

2020-05-20 Thread Tom Rini
On Tue, May 05, 2020 at 12:21:18AM +0200, Rasmus Villemoes wrote: > This macro is only used (tested for existence) in mpc83xx.c, which > unconditionally includes mpc83xx.h where it is unconditionally > defined. Removing it makes the remaining code easier to read. > > Signed-off-by: Rasmus

Re: [PATCH] mpc83xx, abb: remove suvd3 board

2020-05-20 Thread Tom Rini
On Tue, Feb 18, 2020 at 06:03:51PM +0100, Heiko Schocher wrote: > the mpc83xxx suvd3 variant is not longer used, so > remove it. > > Signed-off-by: Holger Brunck > Signed-off-by: Heiko Schocher > Reviewed-by: Simon Glass > Reviewed-by: Priyanka Jain Applied to u-boot/master, thanks! --

RE: [PATCH] armv8: cache_v8: fix mmu_set_region_dcache_behaviour

2020-05-20 Thread Peng Fan
> Subject: [PATCH] armv8: cache_v8: fix mmu_set_region_dcache_behaviour Any comments? Thanks, Peng. > > enum dcache_option already shift left 2 bits, PMD_ATTRINDX(option), will > wrongly shift left the attr 4bits, which is wrong. And make the region user > set > not has expected attribute and

rk3399: SPI boot: Return from ROM unsuccessful (with TPL)

2020-05-20 Thread Jagan Teki
It seems like SPI boot on rk3399 with TPL based is unable to return from ROM or switching to from TPL to SPL is unsuccessful. I have verified board_init_f on spl.c and the control is not even reached here. On the other hand the SPL-alone boot flow works fine from SPI. SPI boot log: U-Boot TPL

RE: [PATCH v11 00/18] RISC-V SiFive FU540 support SPL

2020-05-20 Thread Pragnesh Patel
Hi Bin, >-Original Message- >From: Bin Meng >Sent: 20 May 2020 15:54 >To: Pragnesh Patel >Cc: Rick Chen ; Jagan Teki >; Sean Anderson ; U- >Boot Mailing List ; rick ; Alan >Kao >Subject: Re: [PATCH v11 00/18] RISC-V SiFive FU540 support SPL > >[External Email] Do not click links or

Re: [RESEND PATCH] usb: dwc3: fix NULL pointer issue

2020-05-20 Thread Marek Vasut
On 5/20/20 9:53 AM, Chunfeng Yun wrote: > Hi Marek, > > On Thu, 2020-05-14 at 13:55 +0800, Chunfeng Yun wrote: >> The phy_bulk pointer *usb_phys is used before allocated, >> fix it by using a phy_bulk variable instead in >> xhci_dwc3_platdata struct >> I'm never receiving the emails to the denx

Re: [PATCH] image: Add support for ZSTD decompression

2020-05-20 Thread Robert Marko
Tom, I have tried various things but CONFIG_IS_ENABLED won't work inside of switch case. It works fine outside of if though. On Tue, May 5, 2020 at 11:19 PM Robert Marko wrote: > > > > On Mon, May 4, 2020 at 3:04 PM Tom Rini wrote: >> >> On Sun, May 03, 2020 at 12:24:14PM +0200, Robert Marko

[PATCH 3/3] gpio: mpc8xxx: support fsl-layerscape platform.

2020-05-20 Thread Hui Song
From: "hui.song" Make the MPC8XXX gpio driver to support the fsl-layerscape. Signed-off-by: hui.song --- drivers/gpio/mpc8xxx_gpio.c | 108 +--- 1 file changed, 87 insertions(+), 21 deletions(-) diff --git a/drivers/gpio/mpc8xxx_gpio.c

Re: [PATCH] rockchip: rk3328: rock64 - fix gen3 SPL hang

2020-05-20 Thread Chen-Yu Tsai
On Wed, May 20, 2020 at 4:05 PM Matwey V. Kornilov wrote: > > вт, 19 мая 2020 г. в 17:30, Kurt Miller : > > > > On Tue, 2020-05-19 at 12:48 +0300, Matwey V. Kornilov wrote: > > > вт, 19 мая 2020 г. в 01:06, Kurt Miller : > > > > > > > > > > > > On Wed, 2020-05-13 at 16:10 -0400, Kurt Miller

[PATCH 2/3] dm: armv8: gpio: include for fsl-layerscape

2020-05-20 Thread Hui Song
From: "hui.song" Enable the gpio feature on fsl-layerscape platform. Signed-off-by: hui.song --- arch/arm/include/asm/gpio.h | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm/gpio.h index 333e407b66..7715a01706

[PATCH 1/3] armv8: gpio: add gpio feature

2020-05-20 Thread Hui Song
From: "hui.song" add one struct mpc8xxx_gpio_plat to enable gpio feature. Signed-off-by: hui.song --- .../include/asm/arch-fsl-layerscape/gpio.h| 22 +++ 1 file changed, 22 insertions(+) create mode 100644 arch/arm/include/asm/arch-fsl-layerscape/gpio.h diff --git

[PATCH] serial: Corrected riscv_sbi console flag to ensure it loads at first time

2020-05-20 Thread Kongou Hikari
Signed-off-by: Kongou Hikari --- arch/riscv/dts/nuclei-hbird.dts | 1 - drivers/serial/serial_riscv_sbi.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/dts/nuclei-hbird.dts b/arch/riscv/dts/nuclei-hbird.dts index 39d76b63ba..aea6719b24 100644 ---

[PATCH] serial: Add riscv_sbi console support

2020-05-20 Thread
From: Kongou Hikari - This patch supports debug serial and console from SBI syscall. Signed-off-by: Kongou Hikari --- drivers/serial/Kconfig| 17 + drivers/serial/Makefile | 1 + drivers/serial/serial_riscv_sbi.c | 104 ++ 3 files

[PATCH] riscv: Add Nuclei Hummingbird (UX600) platform support

2020-05-20 Thread
From: Kongou Hikari --- arch/riscv/Kconfig | 4 + arch/riscv/dts/Makefile | 1 + arch/riscv/dts/nuclei-hbird.dts | 132 board/nuclei/hbird/Kconfig | 53 + board/nuclei/hbird/MAINTAINERS | 6 ++

[PATCH 1/2] serial: Add riscv_sbi console support

2020-05-20 Thread Kongou Hikari
- This patch supports debug serial and console from SBI syscall. Signed-off-by: Kongou Hikari --- drivers/serial/Kconfig| 17 + drivers/serial/Makefile | 1 + drivers/serial/serial_riscv_sbi.c | 104 ++ 3 files changed, 122

[PATCH 2/2] riscv: Add Nuclei Hummingbird (UX600) platform support

2020-05-20 Thread Kongou Hikari
--- arch/riscv/Kconfig | 4 + arch/riscv/dts/Makefile | 1 + arch/riscv/dts/nuclei-hbird.dts | 132 board/nuclei/hbird/Kconfig | 53 + board/nuclei/hbird/MAINTAINERS | 6 ++ board/nuclei/hbird/Makefile | 5 ++

RE: [PATCH v2 1/6] arm: dts: lx2160a: add noted for dpmacs 1, 2, 5-6

2020-05-20 Thread Priyanka Jain (OSS)
>-Original Message- >From: U-Boot On Behalf Of Ioana Ciornei >Sent: Monday, April 27, 2020 5:51 PM >To: Priyanka Jain ; u-boot@lists.denx.de >Cc: Alexandru Marginean ; Madalin Bucur >; Florin Laurentiu Chiculita >; Razvan Ionut Cirjan >; Ioana Ciornei >Subject: [PATCH v2 1/6] arm: dts:

RE: [PATCH] board_r: Detect ifc-nor flash at run-time

2020-05-20 Thread Priyanka Jain (OSS)
>-Original Message- >From: U-Boot On Behalf Of Rajesh Bhagat >Sent: Thursday, April 30, 2020 3:54 PM >To: u-boot@lists.denx.de >Cc: Priyanka Jain ; Pankit Garg > >Subject: [PATCH] board_r: Detect ifc-nor flash at run-time > >From: Pankit Garg > >CONFIG_MTD_NOR_FLASH flag needs to be

RE: [PATCH] net: fsl-mc: fixup DPC: add /board/ports node if missing

2020-05-20 Thread Priyanka Jain (OSS)
>-Original Message- >From: U-Boot On Behalf Of Razvan Ionut >Cirjan >Sent: Tuesday, April 28, 2020 6:40 PM >To: Priyanka Jain ; joe.hershber...@ni.com; u- >b...@lists.denx.de >Cc: Ioana Ciornei ; Florin Laurentiu Chiculita >; Cristi Sovaiala >; Razvan Ionut Cirjan > >Subject: [PATCH] net:

  1   2   >