Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-21 Thread Pali Rohár
On Tuesday 21 February 2023 21:45:07 Tony Dinh wrote: > Hi Pali, > > On Tue, Feb 21, 2023 at 3:14 PM Pali Rohár wrote: > > > > On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote: > > > Hi Pali, > > > > > > On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár wrote: > > > > > > > > This patch series

Re: [PATCH] board: edgeble: Fix neural-compute-module-2 board name

2023-02-21 Thread Kever Yang
On 2023/1/25 03:31, Jagan Teki wrote: The board should be RV1126-NEU2 instead RV1126-ECM0. Fix the wrong name. Fixes: b8f1ca954013 ("board: rockchip: Add Edgeble Neu2 IO Board") Signed-off-by: Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever ---

Re: [PATCH V2 7/9] gpio/rockchip: rk_gpio support v2 gpio controller

2023-02-21 Thread Kever Yang
On 2023/2/14 06:27, Chris Morgan wrote: From: Chris Morgan Add support for the newer GPIO controller used by the rk356x series, as well as the pinctrl device for the rk356x series. The GPIOv2 controller has a write enable bit for some registers which differs from the older versions of the

Re: [PATCH V2 9/9] evb1-v10-rk3568: Update MAINTAINERS and documentation

2023-02-21 Thread Kever Yang
On 2023/2/14 06:27, Chris Morgan wrote: From: Chris Morgan Update the MAINTAINERS file to include the devicetree for the rk3568-evb1-v10 board. Also update Rockchip board docs to include information on building RK3568 based devices. Signed-off-by: Chris Morgan ---

Re: [PATCH V2 8/9] arm64: dts: rockchip: add gpio-ranges property to gpio nodes

2023-02-21 Thread Kever Yang
On 2023/2/14 06:27, Chris Morgan wrote: From: Chris Morgan Add gpio-ranges property to GPIO nodes so that the bank ID can be correctly derived for each GPIO bank. Signed-off-by: Chris Morgan Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk356x.dtsi | 5 + 1 file

Re: [PATCH V2 5/9] rockchip: rk3568: add boot device detection

2023-02-21 Thread Kever Yang
On 2023/2/16 02:28, Jonas Karlman wrote: Hi Chris, On 2023-02-13 23:27, Chris Morgan wrote: From: Chris Morgan Enable spl to detect which device it was booted from. Signed-off-by: Peter Geis Signed-off-by: Chris Morgan --- arch/arm/mach-rockchip/rk3568/rk3568.c | 7 +++ 1 file

Re: [PATCH] dm: adc: add iMX93 ADC support

2023-02-21 Thread Luca Ellero
On 21/02/2023 21:28, Fabio Estevam wrote: Hi Luca, On Tue, Feb 21, 2023 at 9:55 AM Luca Ellero wrote: +int imx93_adc_channel_data(struct udevice *dev, int channel, static int +int imx93_adc_start_channel(struct udevice *dev, int channel) static int +int imx93_adc_stop(struct udevice

Re: [PATCH V2 2/9] dts: rockchip: px30: add gpio-ranges property to gpio nodes

2023-02-21 Thread Kever Yang
On 2023/2/14 06:27, Chris Morgan wrote: From: Chris Morgan Add the gpio-ranges property to each GPIO node for use in deriving the correct bank ID. Note that invoking "gpio status -a" no longer causes the board to hit a "Synchronous Abort". Fixes: 537b1a277479 ("rockchip: add px30

Re: [PATCH V2 1/9] gpio: gpio-rockchip: parse gpio-ranges for bank id

2023-02-21 Thread Kever Yang
On 2023/2/14 06:27, Chris Morgan wrote: From: Chris Morgan Use the new devicetree property of gpio-ranges to determine the GPIO bank ID. Preserve the "old" way of doing things too, so that boards can be migrated and tested gradually (I only have a 3566 and 3326 to test). Signed-off-by:

Re: [PATCH V2 6/9] rockchip: rk3568: enable automatic power savings

2023-02-21 Thread Kever Yang
On 2023/2/14 06:27, Chris Morgan wrote: From: Chris Morgan It enables automatic clock gating on idle, disables the eDP phy by default, and sets the core pvtpll ring length. It is reported this lowers the temperature on at least one SoC by 7C. Signed-off-by: Peter Geis Signed-off-by: Chris

Re: [PATCH V2 4/9] arm64: dts: rockchip: Sync rk356x from Linux main

2023-02-21 Thread Kever Yang
Hi Chris, On 2023/2/16 02:44, Jonas Karlman wrote: On 2023-02-13 23:27, Chris Morgan wrote: From: Chris Morgan Sync rk3566 and rk3568 from the mainline Linux kernel (6.2-rc2 as of this writing). Note that this will rename the rk3568-evb to rk3568-evb1-v10. Is the rename and sync of

Re: [PATCH v1 18/18] board: rockchip: Add Edgeble Neural Compute Module 6

2023-02-21 Thread Kever Yang
Hi Jagan, On 2023/1/30 22:57, Jagan Teki wrote: Neural Compute Module 6(Neu2) is a 96boards SoM-CB compute module based on Rockchip RK3588 from Edgeble AI. General features: - Rockchip RK3588 - up to 32GB LPDDR4x - up to 128GB eMMC - 2x MIPI CSI2 FPC On module WiFi6/BT5 is available in the

Re: [PATCH v1 15/18] ARM: dts: rockchip: Add rk3588-u-boot.dtsi

2023-02-21 Thread Kever Yang
On 2023/1/30 22:57, Jagan Teki wrote: Add u-boot,dm-spl and u-boot,dm-pre-reloc related properties for Rockchip RK3588 SoC to boot the SPL. Signed-off-by: Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3588-u-boot.dtsi | 7 +

Re: [PATCH] include: rk3328: Add default env for compressed kernel images

2023-02-21 Thread Kever Yang
On 2023/1/28 01:03, Christopher Obbard wrote: Add default memory addresses for kernel_comp_addr_r and kernel_comp_size to enable booting from a compressed kernel image. This area is temporarily used to decompress the kernel image on-the-fly. Signed-off-by: Christopher Obbard Reviewed-by:

Re: [PATCH v2] usb: dwc3: Use the devm_gpiod_get_optional() API for reset gpio

2023-02-21 Thread Michal Simek
On 2/22/23 02:06, Marek Vasut wrote: On 1/13/23 06:12, Venkatesh Yadav Abbarapu wrote: As the "reset-gpios" property is optional, don't return the error and just skip the gpio reset sequence. Signed-off-by: Venkatesh Yadav Abbarapu --- Changes in v2: - Replaced the gpio_request_by_name()

Re: [PATCH v3 1/2] configs: phycore-rk3288: Enable CONFIG_LTO

2023-02-21 Thread Kever Yang
Hi Wadim, Samuel,     Migrate to use the TPL+SPL can fix the size limit issue. On 2023/1/22 08:08, Samuel Holland wrote: From: Wadim Egorov The phycore-rk3288 SPL binary is reaching the limits of 32KB very often. Enable CONFIG_LTO to reduce the size of the SPL and make the board more future

Re: [PATCH v2] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo

2023-02-21 Thread Kever Yang
On 2022/10/18 03:02, Christian Kohlschütter wrote: Provide human-readable manufacturer and product names for the FriendlyELEC NanoPi R4S. Enable CONFIG_SYSINFO and CONFIG_SYSINFO_SMBIOS by default. Signed-off-by: Christian Kohlschütter Reviewed-by: Kever Yang Thanks, - Kever ---

bootstd breakages

2023-02-21 Thread Ilias Apalodimas
Hi Simon, Using the attached config U-Boot fails to compile. aarch64-linux-gnu-ld.bfd: boot/bootmeth_efi_mgr.o: in function `efi_mgr_check': /home/apalos/work/u-boot-tpm/boot/bootmeth_efi_mgr.c:39: undefined reference to `bootflow_iter_check_system' make: *** [Makefile:1752: u-boot] Error 1

Re: rk3399: Loading OP-TEE by SPL?

2023-02-21 Thread Kever Yang
Hi Christoph,     The SPL_OPTEE_IMAGE is suppose to use like ATF for armv7:     TPL->SPL->BL31/ATF/OPTEE->U-Boot.     But not for OPTEE use as a BL32 after BL31.     BL31 and U-Boot is package as a itb file, so it's easy to add a BL32, but you may need to study how BL31 get entry to BL32

Re: [PATCH RFC u-boot-mvebu 19/59] tools: kwboot: Show image type and error parsing reasons

2023-02-21 Thread Tony Dinh
On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár wrote: > > Show image type and version during parsing of kwbimage. > And show reasons in error messages when parsing failed. > This can help to debug issues with invalid images. > > Signed-off-by: Pali Rohár > --- > tools/kwboot.c | 39

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-21 Thread Tony Dinh
Hi Pali, On Tue, Feb 21, 2023 at 3:14 PM Pali Rohár wrote: > > On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote: > > Hi Pali, > > > > On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár wrote: > > > > > > This patch series contains various improvements and fixes for existing > > > logical errors.

Re: [PATCH v5 0/6] tpm: Support boot measurements

2023-02-21 Thread Joel Stanley
On Thu, 2 Feb 2023 at 17:08, Eddie James wrote: > > This series adds support for measuring the boot images more generically > than the existing EFI support. Several EFI functions have been moved to > the TPM layer. The series includes optional measurement from the bootm > command. > A new test

Re: [PATCH v2] binman: bintool: Add support for tool directories

2023-02-21 Thread Neha Malcom Francis
Hi Simon On 22/02/23 01:05, Simon Glass wrote: Hi Neha, On Fri, 17 Feb 2023 at 04:46, Neha Malcom Francis wrote: Currently, bintool supports external compilable tools as single executable files. Adding support for git repos that can be used to run non-compilable scripting tools that cannot

Re: [PATCH v4 00/10] usb: dwc3: Refactor dwc3-generic and apply to dwc3-uniphier

2023-02-21 Thread Marek Vasut
On 2/22/23 03:00, Kunihiko Hayashi wrote: Hi Marek, On 2023/02/21 0:53, Marek Vasut wrote: On 2/20/23 06:50, Kunihiko Hayashi wrote: This series achieves refactoring of dwc3-generic. First, dwc3-generic allows DT controller nodes to be children of glue nodes, but outside of glue nodes. To

Re: [PATCH v4 00/10] usb: dwc3: Refactor dwc3-generic and apply to dwc3-uniphier

2023-02-21 Thread Kunihiko Hayashi
Hi Marek, On 2023/02/21 0:53, Marek Vasut wrote: On 2/20/23 06:50, Kunihiko Hayashi wrote: This series achieves refactoring of dwc3-generic. First, dwc3-generic allows DT controller nodes to be children of glue nodes, but outside of glue nodes. To achieve this goal, define a glue-specific

[PATCH v1 23/24] arm: cpu: armv7: ls102xa: fdt: remove eth_device support

2023-02-21 Thread Troy Kisky
commit e524f3a449f5 ("net: Remove eth_legacy.c") removed struct eth_device This prevents errors in the conversion to CONFIG_IS_ENABLED(DM_ETH). Signed-off-by: Troy Kisky --- arch/arm/cpu/armv7/ls102xa/fdt.c | 12 1 file changed, 12 deletions(-) diff --git

[PATCH v1 00/24] CONFIG_IS_ENABLED vs IS_ENABLED

2023-02-21 Thread Troy Kisky
This patch set gets ready to checks the usage of CONFIG_IS_ENABLED/IS_ENABLED. After the set has been applied, you can delete test/usage_of_is_enabled_todo.txt and run test/usage_of_is_enabled_commit.sh The script test/usage_of_is_enabled_check.sh checks for new questionable uses of

[PATCH v1 24/24] CI: add test/usage_of_is_enabled_check.sh

2023-02-21 Thread Troy Kisky
Add script usage_of_is_enabled_check to print any configs that use CONFIG_IS_ENABLED instead of IS_ENABLED and vice versa. Add usage_of_is_enabled_commit.sh to generate commits to fix the above issues. You can remove entries from test/usage_of_is_enabled_todo.txt or the entire file and then run

[PATCH v1 22/24] power: pmic: add dm style definitions if not CONFIG_IS_ENABLED(POWER_LEGACY)

2023-02-21 Thread Troy Kisky
This avoids an error in converting to CONFIG_IS_ENABLED(DM_PMIC). Many boards SPL code needs these definitions to compile, even if the functions are not linked. Signed-off-by: Troy Kisky --- include/power/pmic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] doc: uefi: fix links

2023-02-21 Thread Heinrich Schuchardt
On 2/20/23 15:37, Vincent Stehlé wrote: Fix a couple of links so that they are rendered correctly with sphinx. Signed-off-by: Vincent Stehlé Cc: Heinrich Schuchardt Cc: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt --- doc/develop/uefi/fwu_updates.rst | 3 ++-

[PATCH v1 20/24] x86: cpu: i386: cpu: only set pci_ram_top if CONFIG_IS_ENABLED(PCI)

2023-02-21 Thread Troy Kisky
This avoids an error when ifdef CONFIG_PCI is changed to if CONFIG_IS_ENABLED(PCI) Signed-off-by: Troy Kisky --- arch/x86/cpu/i386/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/cpu/i386/cpu.c b/arch/x86/cpu/i386/cpu.c index c7f6c5a013e..07a73f79768 100644 ---

[PATCH v1 19/24] arm: mach-imx: use CONFIG_$(SPL_)SATA instead of CONFIG_SATA

2023-02-21 Thread Troy Kisky
This avoid an error with enable_sata_clock when defined(CONFIG_SATA) is changed to CONFIG_IS_ENABLED(SATA). Signed-off-by: Troy Kisky --- arch/arm/mach-imx/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile index

[PATCH v1 21/24] gateworks: venice: surround call of setup_fec with if IS_ENABLED(CONFIG_NET)

2023-02-21 Thread Troy Kisky
This is the same as the definition is surrounded by. It avoids an error in converting to CONFIG_IS_ENABLED(NET). Signed-off-by: Troy Kisky --- board/gateworks/venice/venice.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/board/gateworks/venice/venice.c

[PATCH v1 16/24] freescale: common: pfuze: define pfuze_mode_init only if defined(CONFIG_DM_PMIC)

2023-02-21 Thread Troy Kisky
pfuze_mode_init calls pmic_reg_read which is only available from obj-$(CONFIG_$(SPL_TPL_)DM_PMIC) += pmic-uclass.o Prepare for conversion of defined(CONFIG_DM_PMIC) to CONFIG_IS_ENABLED(DM_PMIC). Signed-off-by: Troy Kisky --- board/freescale/common/pfuze.c | 2 +- 1 file changed, 1

[PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-21 Thread Troy Kisky
When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI) bdf is no longer accessible. So change to preprocessor to avoid access. Signed-off-by: Troy Kisky --- arch/x86/cpu/apollolake/uart.c | 6 +++--- include/ns16550.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)

[PATCH v1 15/24] m53menlo: define ft_board_setup only if CONFIG_IS_ENABLED(OF_LIBFDT)

2023-02-21 Thread Troy Kisky
The function ft_board_setup calls do_fixup_by_path_string which is only available on CONFIG_IS_ENABLED(OF_LIBFDT). This prepares for the conversion. ft_board_setup is only called from image-fdt which is linked by obj-$(CONFIG_$(SPL_TPL_)OF_LIBFDT) += image-fdt.o Signed-off-by: Troy Kisky ---

[PATCH v1 18/24] solidrun: mx6cuboxi: use CONFIG_IS_ENABLED(SATA) instead of CONFIG_CMD_SATA

2023-02-21 Thread Troy Kisky
setup_sata is linked with obj-$(CONFIG_SATA) += sata.o So use SATA instead of CMD_SATA. Signed-off-by: Troy Kisky --- board/solidrun/mx6cuboxi/mx6cuboxi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c

[PATCH v1 13/24] puma-rk3399: remove check for ENV_IS_NOWHERE, it is an SPL config

2023-02-21 Thread Troy Kisky
When IS_ENABLED(CONFIG_ENV_IS_NOWHERE) is converted to CONFIG_IS_ENABLED(ENV_IS_NOWHERE) this will give unwanted errors on spl builds. Signed-off-by: Troy Kisky --- board/theobroma-systems/puma_rk3399/puma-rk3399.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH v1 14/24] fdt_support: always define fdt_fixup_mtdparts

2023-02-21 Thread Troy Kisky
SPL code wants fdt_fixup_mtdparts defined as a NOP when the function isn't linked in. Prepare for ifdef CONFIG_OF_LIBFDT being converted to if CONFIG_IS_ENABLED(OF_LIBFDT) Signed-off-by: Troy Kisky --- include/fdt_support.h | 23 +-- 1 file changed, 13 insertions(+), 10

[PATCH v1 12/24] ringneck-px30: remove check for ENV_IS_NOWHERE, it is an SPL config

2023-02-21 Thread Troy Kisky
When IS_ENABLED(CONFIG_ENV_IS_NOWHERE) is converted to CONFIG_IS_ENABLED(ENV_IS_NOWHERE) this will give unwanted errors on spl builds. Signed-off-by: Troy Kisky --- board/theobroma-systems/ringneck_px30/ringneck-px30.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH v1 09/24] x86: cpu: qemu: qemu: remove SPL use with CONFIG_IS_ENABLED

2023-02-21 Thread Troy Kisky
CONFIG_IS_ENABLED(SPL_X86_32BIT_INIT) would check for CONFIG_SPL_SPL_X86_32BIT_INIT for SPL builds Signed-off-by: Troy Kisky --- arch/x86/cpu/qemu/qemu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/cpu/qemu/qemu.c b/arch/x86/cpu/qemu/qemu.c index

[PATCH v1 11/24] ofnode: fdt_support definitions needed if OF_CONTROL is enabled

2023-02-21 Thread Troy Kisky
With the use of CONFIG_IS_ENABLED in code, instead of at the preprocessor level, these defines are still needed if OF_CONTROL is enabled. Signed-off-by: Troy Kisky --- include/fdt_support.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/fdt_support.h

[PATCH v1 10/24] config_distro_bootcmd: remove booting environment variables from SPL environment

2023-02-21 Thread Troy Kisky
SPL environments don't need command that they can never use. Avoid errors with CONFIG_IS_ENABLED conversions by skipping them now. Signed-off-by: Troy Kisky --- include/config_distro_bootcmd.h | 23 +++ 1 file changed, 23 insertions(+) diff --git

[PATCH v1 08/24] tools: Makefile: prepare for CONFIG_IS_ENABLED changes by adding CONFIG_TOOLS_xxx

2023-02-21 Thread Troy Kisky
CONFIG_IS_ENABLED(FIT_SIGNATURE) will check for CONFIG_TOOLS_FIT_SIGNATURE. So define it now in preparation. Signed-off-by: Troy Kisky --- tools/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/Makefile b/tools/Makefile index e13effbb66a..2670c77b2cb 100644 ---

[PATCH v1 07/24] tools: prevent CONFIG_IS_ENABLED errors by including linux/kconfig.h

2023-02-21 Thread Troy Kisky
We need to include in order to include files that use CONFIG_IS_ENABLED. Signed-off-by: Troy Kisky --- boot/fdt_region.c | 1 + lib/fdtdec_common.c | 1 + lib/hash-checksum.c | 1 + tools/env/fw_env.c | 1 + tools/fdt_host.h| 1 + tools/mkimage.h | 1 + 6 files changed, 6

[PATCH v1 05/24] lib: sha256: prepare for CONFIG_IS_ENABLED changes

2023-02-21 Thread Troy Kisky
We need to include in order to include files that use CONFIG_IS_ENABLED. TO prepare for that don't pet the watchdog when USE_HOSTCC is defined. Signed-off-by: Troy Kisky --- lib/sha256.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/sha256.c b/lib/sha256.c

[PATCH v1 06/24] lib: sha512: prepare for CONFIG_IS_ENABLED changes

2023-02-21 Thread Troy Kisky
We need to include in order to include files that use CONFIG_IS_ENABLED. TO prepare for that don't pet the watchdog when USE_HOSTCC is defined. Signed-off-by: Troy Kisky --- lib/sha512.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/sha512.c

[PATCH v1 04/24] lib: sha1: prepare for CONFIG_IS_ENABLED changes

2023-02-21 Thread Troy Kisky
We need to include in order to include files that use CONFIG_IS_ENABLED. TO prepare for that don't pet the watchdog when USE_HOSTCC is defined. Signed-off-by: Troy Kisky --- lib/sha1.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/sha1.c b/lib/sha1.c index

[PATCH v1 02/24] lib: crc32: prepare for CONFIG_IS_ENABLED changes

2023-02-21 Thread Troy Kisky
We need to include in order to include files that use CONFIG_IS_ENABLED. TO prepare for that be more direct with using defined(USE_HOSTCC). Signed-off-by: Troy Kisky --- lib/crc32.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/crc32.c b/lib/crc32.c

[PATCH v1 03/24] lib: md5: prepare for CONFIG_IS_ENABLED changes

2023-02-21 Thread Troy Kisky
We need to include in order to include files that use CONFIG_IS_ENABLED. TO prepare for that don't pet the watchdog when USE_HOSTCC is defined. Signed-off-by: Troy Kisky --- lib/md5.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/md5.c b/lib/md5.c index

[PATCH v1 01/24] cmd: nvedit: check for ENV_SUPPORT

2023-02-21 Thread Troy Kisky
Avoid error messages when SPL,TPL,VPL build don't have the environment options of the main build. This is needed when defined(CONFIG_ENV_IS_IN_xxx) is changed to CONFIG_IS_ENABLED(ENV_IS_IN_xxx). Signed-off-by: Troy Kisky --- cmd/nvedit.c | 5 - 1 file changed, 4 insertions(+), 1

Re: [PATCH v2 00/10] Backport BRCMNAND changes from Linux

2023-02-21 Thread William Zhang
Hi Linus. On 02/11/2023 07:28 AM, Linus Walleij wrote: Hunting down a bug on my system I took to back-porting all reasonable changes from the Linux brcmnand driver that were not yet in the U-Boot derivative. I noticed that a simple diff -ur between brcmnand.c between the file in Linux and

Re: [PATCH v2 10/10] mtd: rawnand: brcmnand: fix OOB R/W with Hamming ECC

2023-02-21 Thread William Zhang
On 02/11/2023 07:29 AM, Linus Walleij wrote: From: Álvaro Fernández Rojas Hamming ECC doesn't cover the OOB data, so reading or writing OOB shall always be done without ECC enabled. This is a problem when adding JFFS2 cleanmarkers to erased blocks. If JFFS2 clenmarkers are added to the OOB

Re: [PATCH v2 09/10] mtd: rawnand: brcmnand: support v2.1-v2.2 controllers

2023-02-21 Thread William Zhang
On 02/11/2023 07:29 AM, Linus Walleij wrote: From: Álvaro Fernández Rojas v2.1: tested on Netgear DGND3700v1 (BCM6368) v2.2: tested on Netgear DGND3700v2 (BCM6362) Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli Signed-off-by: Miquel Raynal Link:

Re: [PATCH v2 08/10] mtd: rawnand: brcmnand: rename page sizes

2023-02-21 Thread William Zhang
On 02/11/2023 07:29 AM, Linus Walleij wrote: From: Álvaro Fernández Rojas Current pages sizes apply to controllers after v3.4 Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli Signed-off-by: Miquel Raynal Link:

Re: [PATCH v2 07/10] mtd: rawnand: brcmnand: fix CS0 layout

2023-02-21 Thread William Zhang
On 02/11/2023 07:29 AM, Linus Walleij wrote: From: Álvaro Fernández Rojas Only v3.3-v5.0 have a different CS0 layout. Controllers before v3.3 use the same layout for every CS. Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller") Signed-off-by:

[PATCH 1/1] test: unit test for crc8

2023-02-21 Thread Heinrich Schuchardt
Add a unit test for the crc8() function. Signed-off-by: Heinrich Schuchardt --- test/lib/Makefile| 1 + test/lib/test_crc8.c | 29 + 2 files changed, 30 insertions(+) create mode 100644 test/lib/test_crc8.c diff --git a/test/lib/Makefile b/test/lib/Makefile

Re: [PATCH v2 06/10] mtd: rawnand: brcmnand: rename v4 registers

2023-02-21 Thread William Zhang
On 02/11/2023 07:29 AM, Linus Walleij wrote: From: Álvaro Fernández Rojas These registers are also used on v3.3. Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Miquel Raynal Acked-by: Florian Fainelli Signed-off-by: Miquel Raynal Link:

Re: [PATCH v2 05/10] mtd: rawnand: brcmnand: correctly verify erased pages

2023-02-21 Thread William Zhang
On 02/11/2023 07:29 AM, Linus Walleij wrote: From: Álvaro Fernández Rojas The current code checks that the whole OOB area is erased. This is a problem when JFFS2 cleanmarkers are added to the OOB, since it will fail due to the usable OOB bytes not being 0xff. Correct this by only checking

Re: [PATCH v2 04/10] mtd: nand: brcmnand: Add support for flash-dma v0

2023-02-21 Thread William Zhang
On 02/11/2023 07:29 AM, Linus Walleij wrote: From: Kamal Dasu This change adds support for flash dma v0.0. Signed-off-by: Kamal Dasu Signed-off-by: Miquel Raynal [Ported to U-Boot from the Linux kernel] Signed-off-by: Linus Walleij --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 21

Re: [PATCH v2 03/10] mtd: rawnand: brcmnand: Fix ecc chunk calculation for erased page bitfips

2023-02-21 Thread William Zhang
On 02/11/2023 07:29 AM, Linus Walleij wrote: From: Claire Lin In brcmstb_nand_verify_erased_page(), the ECC chunk pointer calculation while correcting erased page bitflips is wrong, fix it. Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflips") Signed-off-by: Claire Lin

Re: [PATCH v2 02/10] mtd: rawnand: brcmnand: Add support for v7.3 controller

2023-02-21 Thread William Zhang
On 02/11/2023 07:29 AM, Linus Walleij wrote: From: Kamal Dasu This change adds support for brcm NAND v7.3 controller. This controller uses a newer version of flash_dma engine and change mostly implements these differences. Signed-off-by: Kamal Dasu Signed-off-by: Miquel Raynal [Ported to

Re: [PATCH v2 01/10] mtd: rawnand: brcmnand: Refactored code to introduce helper functions

2023-02-21 Thread William Zhang
On 02/11/2023 07:29 AM, Linus Walleij wrote: From: Kamal Dasu Refactored NAND ECC and CMD address configuration code to use helper functions. Signed-off-by: Kamal Dasu Signed-off-by: Miquel Raynal [Ported to U-Boot from the Linux kernel] Signed-off-by: Linus Walleij ---

Re: [PATCH v2] usb: dwc3: Use the devm_gpiod_get_optional() API for reset gpio

2023-02-21 Thread Marek Vasut
On 1/13/23 06:12, Venkatesh Yadav Abbarapu wrote: As the "reset-gpios" property is optional, don't return the error and just skip the gpio reset sequence. Signed-off-by: Venkatesh Yadav Abbarapu --- Changes in v2: - Replaced the gpio_request_by_name() the API with devm_gpiod_get_optional().

[PULL] u-boot-socfpga/master

2023-02-21 Thread Marek Vasut
The following changes since commit 4eb7c5030d3f3c707c02a64dc8ea90de3da89928: Merge tag 'efi-2023-04-rc3' of https://source.denx.de/u-boot/custodians/u-boot-efi (2023-02-19 17:03:30 -0500) are available in the Git repository at: git://git.denx.de/u-boot-socfpga.git master for you to

[PATCH v2 1/1] sandbox: fix building with CONFIG_SPL_TIMER=y

2023-02-21 Thread Heinrich Schuchardt
Building sandbox_defconfig with CONFIG_SPL_TIMER=y results in an error include/dm/platdata.h:63:33: error: static assertion failed: "Cannot use U_BOOT_DRVINFO with of-platdata. Please use devicetree instead" Add a missing condition in the sandbox driver. Signed-off-by: Heinrich

[PATCH] linker_lists.h: Add attribute used to ll_entry_start macro

2023-02-21 Thread Aditya Kumar
>From 39d292a327b104dcb1347afb545b2baeb7b2227e Mon Sep 17 00:00:00 2001 From: AdityaK Date: Tue, 21 Feb 2023 15:05:54 -0800 Subject: [PATCH] linker_lists.h: Add attribute used to ll_entry_start macro The variable gets dropped by clang compiler in an optimized builds. Adding attribute((used))

Re: [PATCH 2/3] rockchip: Disable DISTRO_DEFAULTS for rockpro64

2023-02-21 Thread Vagrant Cascadian
On 2023-02-21, Simon Glass wrote: > This board has moved to standard boot but the old 'distro_bootcmd' > command is still active. Disable DISTRO_DEFAULTS to fix this. Works for booting rockpro64-rk3399, thanks! Tested-by: Vagrant Cascadian > Signed-off-by: Simon Glass > --- > >

Re: [PATCH v2 RESEND 0/6] Update Chameleon v3 configuration

2023-02-21 Thread Marek Vasut
On 2/21/23 16:17, Paweł Anikiel wrote: These changes add the third chameleon variation and make it easier to deploy images to different boards. v2 changes: - rename chameleonv3.dts to .dtsi - add missing CONFIG_SPL_MAX_SIZE symbol Paweł Anikiel (6): socfpga: chameleonv3: Enable ext4 in

Re: [PATCH 3/3] bootstd: Enable BOOTSTD_DEFAULTS by default

2023-02-21 Thread Vagrant Cascadian
On 2023-02-21, Simon Glass wrote: > This is needed to enable the boot command used to start standard boot. > Enable it by default. This brings in quite a few features, mostly in > common with DISTRO_DEFAULTS Works for booting rockpro64-rk3399, thanks! Tested-by: Vagrant Cascadian >

Re: [PATCH 1/3] rockchip: Drop bootstage stash in TPL and SPL

2023-02-21 Thread Vagrant Cascadian
On 2023-02-21, Simon Glass wrote: > Unfortunately the IRAM used to stash the bootstage records in TPL > becomes accessible after SPL runs. Presumably this is because of ATF > taking it over. > > We could move the stash to another address in SPL, before passing it to > U-Boot proper. But it seems

Re: [PATCH v3 11/95] Correct SPL use of PHY_CADENCE_SIERRA

2023-02-21 Thread Simon Glass
Hi Tom, On Tue, 21 Feb 2023 at 16:09, Simon Glass wrote: > > Hi Tom, > > On Tue, 21 Feb 2023 at 16:02, Tom Rini wrote: > > > > On Tue, Feb 21, 2023 at 12:35:41PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 14 Feb 2023 at 09:31, Tom Rini wrote: > > > > > > > > On Sun, Feb 12,

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-21 Thread Pali Rohár
On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote: > Hi Pali, > > On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár wrote: > > > > This patch series contains various improvements and fixes for existing > > logical errors. Boot phase was adjusted to match behavior of Armada 385 > > BootROM by

Re: [PATCH v1 1/1] input: button_kbd: make driver complementary to gpio buttons

2023-02-21 Thread Simon Glass
Hi Svyatoslav, If there is no input maintainer, It should just get picked up by Tom at some point. Regards, Simon On Tue, 21 Feb 2023 at 12:51, Svyatoslav Ryhel wrote: > Thanks! Do I need someone else to be able to merge this or your review > is enough? > > Best regards, > Svyatoslav R. > >

Re: [PATCH v3 11/95] Correct SPL use of PHY_CADENCE_SIERRA

2023-02-21 Thread Simon Glass
Hi Tom, On Tue, 21 Feb 2023 at 16:02, Tom Rini wrote: > > On Tue, Feb 21, 2023 at 12:35:41PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 14 Feb 2023 at 09:31, Tom Rini wrote: > > > > > > On Sun, Feb 12, 2023 at 04:15:14PM -0700, Simon Glass wrote: > > > > This converts 1 usage of this

Re: [PATCH 9/9] Makefile: Show binman missing blob message

2023-02-21 Thread Tom Rini
On Tue, Feb 21, 2023 at 12:41:52PM -0700, Simon Glass wrote: > Hi Jonas > > +Tom Rini > > On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > > > When binman is invoked during a build of U-Boot and an external blob is > > missing, the user is usually presented with a generic file not found

Re: [PATCH 2/2] board: rock5b-rk3588: add memory gaps into kernel's DTB

2023-02-21 Thread Mark Kettenis
> Date: Tue, 21 Feb 2023 10:35:18 +0200 > From: Eugen Hristev > > On 2/21/23 00:47, Mark Kettenis wrote: > >> From: Eugen Hristev > >> Date: Thu, 16 Feb 2023 15:29:05 +0200 > >> > >> RK3588 has two memory gaps when using 16 GiB DRAM size: > >> [0x3fc00 , 0x3fc50] > >> and > >>

Re: [PATCH 2/2] clk: ast2600: Keep PLL power on

2023-02-21 Thread Joel Stanley
On Tue, 21 Feb 2023 at 13:01, Dylan Hung wrote: > > According to the PLL vendor, we should keep the PLL power on, so we > shouldn't toggle the power-down bit during PLL initialization. > > Signed-off-by: Dylan Hung Reviewed-by: Joel Stanley > --- > drivers/clk/aspeed/clk_ast2600.c | 3 +-- >

Re: [PATCH 1/2] ram: ast2600: Keep MPLL power on

2023-02-21 Thread Joel Stanley
On Tue, 21 Feb 2023 at 13:01, Dylan Hung wrote: > > According to the PLL vendor, we should keep the PLL power on, so we > shouldn't toggle the power-down bit during PLL initialization. > > Signed-off-by: Dylan Hung Reviewed-by: Joel Stanley > --- > drivers/ram/aspeed/sdram_ast2600.c | 6

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-21 Thread Tony Dinh
Hi Pali, On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár wrote: > > This patch series contains various improvements and fixes for existing > logical errors. Boot phase was adjusted to match behavior of Armada 385 > BootROM by inspecting and disassembling of BootROM binary dump itself. > Important

Re: [PATCH v3 11/95] Correct SPL use of PHY_CADENCE_SIERRA

2023-02-21 Thread Tom Rini
On Tue, Feb 21, 2023 at 12:35:41PM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 14 Feb 2023 at 09:31, Tom Rini wrote: > > > > On Sun, Feb 12, 2023 at 04:15:14PM -0700, Simon Glass wrote: > > > This converts 1 usage of this option to the non-SPL form, since there is > > > no

[PATCH RFC u-boot-mvebu 46/59] tools: kwbimage: Add support for XIP SPI/NOR images

2023-02-21 Thread Pali Rohár
Marvell BootROM can execute SPI images directly from NOR (either SPI/serial or parallel) without copying them to DDR RAM. This is know at XIP - execute in place. To achieve that, destination address in kwbimage must be set to 0x and execute address to the offset in bytes from the beginning

[PATCH RFC u-boot-mvebu 35/59] tools: kwbimage: Fix generating of kwbimage v0 header checksum

2023-02-21 Thread Pali Rohár
Checksum for v0 image must be generated after filling all fields in the main header. Otherwise it would be invalid. Exactly same problem for v1 images was already fixed in the past in commit 9203c73895ab ("tools: kwbimage: Fix checksum calculation for v1 images"). Fixes: 5c61710c9880 ("tools:

[PATCH RFC u-boot-mvebu 33/59] tools: kwbimage: Fix dumping NAND_BADBLK_LOCATION

2023-02-21 Thread Pali Rohár
Value 0x0 for NAND_BADBLK_LOCATION/nandbadblklocation means that BBI is on the first or second page and value 0x1 means that BBI is on the last page. This indicates also NAND Flash Technology, value 0x0 is SLC NAND and value 0x1 is MLC NAND. Therefore we need to dump NAND_BADBLK_LOCATION also

[PATCH RFC u-boot-mvebu 27/59] cmd: mvebu/bubt: Set correct default image name for 32-bit Armada SoCs

2023-02-21 Thread Pali Rohár
32-bit Armada SoCs uses u-boot binary packed in kwbimage format. Name of the image is in CONFIG_BUILD_TARGET option. So use it as a default option in Kconfig. Signed-off-by: Pali Rohár --- cmd/mvebu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/mvebu/Kconfig

[PATCH RFC u-boot-mvebu 21/59] cmd: mvebu/bubt: Add support for writing image to SATA disk

2023-02-21 Thread Pali Rohár
All 32-bit Armada SoCs and also 64-bit Armada 3720 SoC can load and boot firmware from SATA disk. This adds support for updating firmware binary for these SoCs. On 32-bit Armada SoC is firmware stored at sector 1 and on Armada 3720 is stored at MBR partition 0x4d or GPT partition with type GUID

[PATCH RFC u-boot-mvebu 11/59] spl: mmc: Allow to disable SYS_MMCSD_FS_BOOT_PARTITION

2023-02-21 Thread Pali Rohár
On some platforms is SYS_MMCSD_FS_BOOT_PARTITION unsupported. So allow to completely disable MMC FS Boot support via new option SYS_MMCSD_FS_BOOT. By default MMC FS Boot support is enabled (like it was before) except for ARCH_MVEBU where MMC FS Boot supported is unsupported due to Marvell BootROM

[PATCH RFC u-boot-mvebu 05/59] tools: kwbimage: Fix generating, verifying and extracting SATA kwbimage

2023-02-21 Thread Pali Rohár
Despite the official specification, Marvell BootROM does not interpret srcaddr from SATA image as number of sectors the beginning of the hard drive, but as number of sectors relative to the main header. The main header is stored at absolute sector number 1. So do not add or subtract it when

Re: [PATCH v5 0/6] tpm: Support boot measurements

2023-02-21 Thread Eddie James
On 2/6/23 06:20, Ilias Apalodimas wrote: Thanks Eddie, I quickly tested this but the EFI subsystem fails to initialize the TCG protocol properly now. Unfortunately I am on a business trip and I won't be able to take a look into why till next week Hi Ilias, I haven't had the opportunity

[PATCH RFC u-boot-mvebu 42/59] tools: kwbimage: Rename imagesz to dataoff

2023-02-21 Thread Pali Rohár
Variable imagesz in functions image_create_v0(), image_create_v1() and kwbimage_set_header() stores offset to data from the beginning of the main header. So it is not image size. Signed-off-by: Pali Rohár --- tools/kwbimage.c | 20 ++-- 1 file changed, 10 insertions(+), 10

[PATCH RFC u-boot-mvebu 37/59] tools: kwbimage: Reject mkimage -F option

2023-02-21 Thread Pali Rohár
mkimage -F option (re-sign existing FIT image) signaled by fflag is not supported by kwbimage. So mark its usage as invalid parameter. Signed-off-by: Pali Rohár --- tools/kwbimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index

[PATCH RFC u-boot-mvebu 25/59] cmd: mvebu/bubt: Do not modify image in A8K check_image_header()

2023-02-21 Thread Pali Rohár
Change checksum verification code so it does require to modify image. Signed-off-by: Pali Rohár --- cmd/mvebu/bubt.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c index 820d342ae100..1b08ca9298c2 100644 --- a/cmd/mvebu/bubt.c +++

[PATCH RFC u-boot-mvebu 50/59] arm: mvebu: Add support for generating NAND kwbimage

2023-02-21 Thread Pali Rohár
Add a new Kconfig option CONFIG_MVEBU_SPL_BOOT_DEVICE_NAND which instruct make to generate kwbimage with NAND header. This image is used for booting from NAND flash (either SPI or parallel). Support is very simple, SPL after finishes DDR training returns back to the BootROM (via

[PATCH RFC u-boot-mvebu 10/59] arm: mvebu: spl: Load proper U-Boot from selected eMMC boot partition

2023-02-21 Thread Pali Rohár
When eMMC boot is selected then BootROM loads kwbimage header (U-Boot SPL) from the selected eMMC boot partition. So for eMMC boot ensure that U-Boot SPL loads U-Boot proper (from kwbimage) also from the same selected eMMC boot partition. Fixes: 2226ca173486 ("arm: mvebu: Load U-Boot proper

[PATCH RFC u-boot-mvebu 15/59] tools: kwboot: Fix parsing UART image without data checksum

2023-02-21 Thread Pali Rohár
The 32-bit data checksum in UART image is not checked by the BootROM and also Marvell tools do not generate it. So if data checksum stored in UART image does not match calculated checksum from the image then treat those checksum bytes as part of the executable image code (and not as the checksum)

[PATCH RFC u-boot-mvebu 03/59] arm: mvebu: spl: Fix parsing SDIO kwbimage

2023-02-21 Thread Pali Rohár
Despite the official specification, Marvell BootROM does not interpret srcaddr from SDIO image as offset in number of sectors (like for SATA image), but as offset in bytes (like for all other images except SATA). To process SDIO kwbimage and load U-Boot proper from it in the same way as Marvell

[PATCH RFC u-boot-mvebu 48/59] tools: mkimage: Do not try to open datafile when it is skipped

2023-02-21 Thread Pali Rohár
When mkimage was instructed to skip datafile via option -s then do not try to validate or open datafile as it does not have to exist or to be specified via -d option. This change allows to use -s option for skipping datafile when -d option for datafile was not specified. Signed-off-by: Pali

[PATCH RFC u-boot-mvebu 16/59] tools: kwboot: Validate optional kwbimage v1 headers

2023-02-21 Thread Pali Rohár
Before starting parsing of kwbimage, first validate that all optional v1 headers and correct. This prevents kwboot crashes on invalid input. Signed-off-by: Pali Rohár --- tools/kwboot.c | 8 1 file changed, 8 insertions(+) diff --git a/tools/kwboot.c b/tools/kwboot.c index

Re: rk3399 boards broken, only partially converted to standard boot? (was Re: [PATCH 71/71] rockchip: Convert rockpro64-rk3399 to use standard boot)

2023-02-21 Thread Simon Glass
Hi Vagrant, On Tue, 21 Feb 2023 at 13:32, Vagrant Cascadian wrote: > > On 2023-02-20, Simon Glass wrote: > > On Sat, 18 Feb 2023 at 19:19, Vagrant Cascadian wrote: > >> On 2022-12-07, Simon Glass wrote: > >> > Drop the use of scripts and rely on standard boot for all operation. > >> > >> This

Re: rk3399 boards broken, only partially converted to standard boot? (was Re: [PATCH 71/71] rockchip: Convert rockpro64-rk3399 to use standard boot)

2023-02-21 Thread Vagrant Cascadian
On 2023-02-20, Simon Glass wrote: > On Sat, 18 Feb 2023 at 19:19, Vagrant Cascadian wrote: >> On 2022-12-07, Simon Glass wrote: >> > Drop the use of scripts and rely on standard boot for all operation. >> >> This patch, applied as 3891c68ef50eda38d78c95ecd03aed030aa6bb53 broke >> booting on

  1   2   3   >