Re: [PATCH] efi_selftests: fix protocol repeated selftesting

2023-06-15 Thread Heinrich Schuchardt
On 6/13/23 15:23, Ilias Apalodimas wrote: Running the protocols selftest more than one times fails with => setenv efi_selftest 'manage protocols' && bootefi selftest Testing EFI API implementation Selected test: 'manage protocols' Setting up 'manage protocols' Setting up 'manage protocols'

Re: [PATCH 4/7] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-06-15 Thread Takahiro Akashi
On Fri, Jun 16, 2023 at 10:37:01AM +0530, Sughosh Ganu wrote: > hi Takahiro, > > On Fri, 16 Jun 2023 at 10:16, Takahiro Akashi > wrote: > > > > Hi Sughosh, > > > > On Fri, Jun 16, 2023 at 09:56:33AM +0530, Sughosh Ganu wrote: > > > On Thu, 15 Jun 2023 at 11:19, Takahiro Akashi > > > wrote: > >

Re: [PATCH 4/7] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-06-15 Thread Sughosh Ganu
hi Takahiro, On Fri, 16 Jun 2023 at 10:16, Takahiro Akashi wrote: > > Hi Sughosh, > > On Fri, Jun 16, 2023 at 09:56:33AM +0530, Sughosh Ganu wrote: > > On Thu, 15 Jun 2023 at 11:19, Takahiro Akashi > > wrote: > > > > > > On Thu, Jun 15, 2023 at 10:09:06AM +0530, Sughosh Ganu wrote: > > > > On

Re: [PATCH 4/7] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-06-15 Thread Takahiro Akashi
Hi Sughosh, On Fri, Jun 16, 2023 at 09:56:33AM +0530, Sughosh Ganu wrote: > On Thu, 15 Jun 2023 at 11:19, Takahiro Akashi > wrote: > > > > On Thu, Jun 15, 2023 at 10:09:06AM +0530, Sughosh Ganu wrote: > > > On Wed, 14 Jun 2023 at 11:23, Takahiro Akashi > > > wrote: > > > > > > > > On Wed, Jun

Re: [PATCH 4/7] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-06-15 Thread Sughosh Ganu
On Thu, 15 Jun 2023 at 11:19, Takahiro Akashi wrote: > > On Thu, Jun 15, 2023 at 10:09:06AM +0530, Sughosh Ganu wrote: > > On Wed, 14 Jun 2023 at 11:23, Takahiro Akashi > > wrote: > > > > > > On Wed, Jun 14, 2023 at 10:56:23AM +0530, Sughosh Ganu wrote: > > > > hi Takahiro, > > > > > > > > On

Re: imx8m optee load address?

2023-06-15 Thread Peng Fan
On 6/16/2023 9:56 AM, Tim Harvey wrote: Greetings, I've seen several IMX8M boards include a firmware/optee node in the U-Boot dt (git grep optee arch/arm/dts/imx8m*.dtsi) yet but none that I see configure binman to actually add the binary in the u-boot.dtsi, do anything to keep U-Boot from

imx8m optee load address?

2023-06-15 Thread Tim Harvey
Greetings, I've seen several IMX8M boards include a firmware/optee node in the U-Boot dt (git grep optee arch/arm/dts/imx8m*.dtsi) yet but none that I see configure binman to actually add the binary in the u-boot.dtsi, do anything to keep U-Boot from accessing the OPTEE memory, or document how to

Re: [PATCH v2] mx8m: csf.sh: use vars for keys to avoid file edits when signing

2023-06-15 Thread Peng Fan
On 6/15/2023 11:21 PM, Tim Harvey wrote: Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button The csf_spl.txt and csf_fit.txt templates contain file paths which must be

Re: [PATCH] menu: Re-enable the ANSI codes

2023-06-15 Thread Peng Fan
On 6/13/2023 4:14 AM, Simon Glass wrote: Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button The intent here was to allow ANSI codes to be disabled, since it was proving

Re: [PATCH 5/7] arch: arm: dts: ls1046a: tag serial nodes with bootph-all

2023-06-15 Thread Peng Fan
On 6/15/2023 8:37 PM, Camelia Groza wrote: Make sure the serial driver is initialized before relocation by tagging the serial nodes with "bootph-all". Add fsl-ls1046a-u-boot.dtsi for U-Boot specific changes. Thanks, Peng. Signed-off-by: Camelia Groza --- arch/arm/dts/fsl-ls1046a.dtsi

Re: [PATCH 4/7] arch: arm: dts: ls1046a: sync serial nodes with Linux

2023-06-15 Thread Peng Fan
On 6/15/2023 8:37 PM, Camelia Groza wrote: Pick up the serial node descriptions from Linux for the ls1046ardb and ls1046afrwy boards and their dependencies. Including the fsl,qoriq-clockgen.h and arm-gic.h headers forces us to change the include directives to explicitly go through the C

Re: [PATCH 2/7] arch: arm: dts: ls1043a: tag serial nodes with bootph-all

2023-06-15 Thread Peng Fan
On 6/15/2023 8:37 PM, Camelia Groza wrote: Make sure the serial driver is initialized before relocation by tagging the serial nodes with "bootph-all". Please add fsl-ls1043a-u-boot.dtsi for U-Boot specific changes. Regards, Peng. Signed-off-by: Camelia Groza ---

Re: [PATCH 1/7] arch: arm: dts: ls1043a: sync serial nodes with Linux

2023-06-15 Thread Peng Fan
On 6/15/2023 8:37 PM, Camelia Groza wrote: Pick up the serial node descriptions from Linux for the ls1043ardb board and its dependencies. Including the fsl,qoriq-clockgen.h and arm-gic.h headers forces us to change the include directives to explicitly go through the C preprocessor for all

Re: [PATCH] board_f: Relocate fdt if SKIP_RELOC and fdt is in bss

2023-06-15 Thread Kunihiko Hayashi
Hi Simon, Thank you for your comment. On 2023/06/13 6:17, Simon Glass wrote: Hi Kunihiko, On Thu, 8 Jun 2023 at 07:53, Kunihiko Hayashi wrote: There are cases that the devicetree blob is placed after _end, such as fdt_find_separate() returns _end. This is in bss area cleared before

Re: [GIT PULL] please pull fsl-qoriq-2023-6-15 for next

2023-06-15 Thread Tom Rini
On Thu, Jun 15, 2023 at 09:46:48AM +, Peng Fan wrote: > Hi Tom, > > Please pull fsl-qoriq-2023-6-15 for next. > Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] usb: dwc3: core: fix clk_get_rate returning negative value

2023-06-15 Thread Marek Vasut
On 6/15/23 16:59, Eugen Hristev wrote: Unlike it's Linux counterpart, clk_get_rate can return a negative value, -ve. The driver does not take that into account, stores the rate into an unsigned long, and if clk_get_rate fails, it will take into consideration the actual value and wrongly program

Re: Trying to boot custom kernel on Wink Hub (i.MX28)

2023-06-15 Thread Fabio Estevam
Hi Rogan, On Thu, Jun 15, 2023 at 9:00 AM Rogan Dawes wrote: > > Hi folks, > > I am trying to boot a custom kernel on a Wink Hub v1, which has an i.MX28 > CPU, and is running U-Boot (U-Boot 2014.01-14400-gda781c6-dirty (Apr 30 > 2014 - 22:35:38)). > > I have tried compiling my own modern kernel

[PATCH v4 2/2] usb: musb-new: sunxi: clarify the purpose of SRAM initialization

2023-06-15 Thread Sam Edwards
This is largely a cosmetic change, with one functional distinction: We are now only setting BIT(0), and no longer clearing BIT(1). The A20 manual confirms the purpose and bitwidth of this field, and we have also been doing it this way for a while in Linux-land: The prior narrative about this

[PATCH v4 1/2] usb: musb-new: sunxi: only perform SRAM initialization when necessary

2023-06-15 Thread Sam Edwards
Only the older (ca. A10, A20) sunxis need this poke for the MUSB to function. Mimic the Linux kernel and add a `has_sram` flag to the config structure that is only set for the specific compatibles that require this initialization. Signed-off-by: Sam Edwards Reviewed-by: Andre Przywara

[PATCH v4 0/2] sunxi, usb: Clean up SRAM initialization code

2023-06-15 Thread Sam Edwards
Hi list, Only change from v4 is that I reworded the commit message in 2/2 not to mention the TODO comment block that I removed in v3. Cheers, Sam Sam Edwards (2): usb: musb-new: sunxi: only perform SRAM initialization when necessary usb: musb-new: sunxi: clarify the purpose of SRAM

Re: [PATCH] riscv: add backtrace support

2023-06-15 Thread Bo Gan
On 6/14/23 10:15 AM, Ben Dooks wrote: On 14/06/2023 07:25, Bo Gan wrote: On 5/25/23 4:05 AM, Ben Dooks wrote: On 15/05/2023 14:03, Ben Dooks wrote: When debugging, it is useful to have a backtrace to find out what is in the call stack as the previous function (RA) may not have been the

Re: [PATCH] menu: Re-enable the ANSI codes

2023-06-15 Thread Pali Rohár
On Thursday 15 June 2023 13:34:09 Simon Glass wrote: > Hi Pali, > > On Mon, 12 Jun 2023 at 22:33, Pali Rohár wrote: > > > > On Monday 12 June 2023 22:17:48 Simon Glass wrote: > > > Hi Pali, > > > > > > On Mon, 12 Jun 2023 at 21:22, Pali Rohár wrote: > > > > > > > > On Monday 12 June 2023

Re: [PATCH 5/7] Makefile: Add a target for building capsules

2023-06-15 Thread Sughosh Ganu
hi Simon, On Thu, 15 Jun 2023 at 14:44, Simon Glass wrote: > > Hi Sughosh, > > On Tue, 13 Jun 2023 at 11:39, Sughosh Ganu wrote: > > > > Add a target for building EFI capsules. The capsule parameters are > > specified through a config file, and the path to the config file is > > specified

Re: [PATCH 1/7] capsule: authenticate: Embed capsule public key in platform's dtb

2023-06-15 Thread Sughosh Ganu
hi Simon, On Thu, 15 Jun 2023 at 14:44, Simon Glass wrote: > > Hi Sughosh, > > On Tue, 13 Jun 2023 at 11:41, Sughosh Ganu wrote: > > > > The EFI capsule authentication logic in u-boot expects the public key > > in the form of an EFI Signature List(ESL) to be provided as part of > > the

[PATCH v2] mx8m: csf.sh: use vars for keys to avoid file edits when signing

2023-06-15 Thread Tim Harvey
The csf_spl.txt and csf_fit.txt templates contain file paths which must be edited for the location of your NXP CST generated key files. Streamline the process of signing an image by assigning unique var names to these which can be expended from env variables in the csf.sh script. The following

[PATCH] usb: dwc3: core: fix clk_get_rate returning negative value

2023-06-15 Thread Eugen Hristev
Unlike it's Linux counterpart, clk_get_rate can return a negative value, -ve. The driver does not take that into account, stores the rate into an unsigned long, and if clk_get_rate fails, it will take into consideration the actual value and wrongly program the hardware. E.g. on error -2 (no such

[PATCH] lib/zlib: Fix a bug when getting a gzip header extra field

2023-06-15 Thread Oleksandr Suvorov
This fixes CVE-2022-37434 [1] and bases on 2 commits from Mark Adler's zlib master repo - the original fix of CVE bug [2] and the fix for the fix [3]. [1] https://github.com/advisories/GHSA-cfmr-vrgj-vqwv [2] https://github.com/madler/zlib/commit/eff308af425b67093bab25f80f1ae950166bece1 [3]

[PATCH 5/5] efi_selftests: add extra testcases on controller handling

2023-06-15 Thread Ilias Apalodimas
We recently fixed a few issues wrt to controller handling. Add a few test cases to cover the new code. - add a second driver in the same controller handle which will refuse to unbind on the first protocol removal - add tests to verify controllers are reconnected when uninstalling a protocol

[PATCH 2/5] efi_loader: reconnect drivers on failure

2023-06-15 Thread Ilias Apalodimas
efi_disconnect_controller() doesn't reconnect drivers in case of failure. Reconnect the disconnected drivers properly Signed-off-by: Ilias Apalodimas --- lib/efi_loader/efi_boottime.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git

[PATCH 3/5] efi_loader: disconnect all controllers when uninstalling a protocol

2023-06-15 Thread Ilias Apalodimas
When we are trying to uninstall a protocol interface from a controller handle we are trying to disconnect drivers related to that protocol. However, when we call efi_disconnect_all_drivers() we pass the protocol GUID. If 2 different drivers are using the same protocol interface and one of them

[PATCH 4/5] efi_loader: fix the return codes of UninstallProtocol

2023-06-15 Thread Ilias Apalodimas
Up to now we did not check the return value of DisconnectController. A previous patch is fixing that taking into account what happened during the controller disconnect. But that check takes place before our code is trying to figure out if the interface exists to begin with. In case a driver is

[PATCH 1/5] efi_loader: check the status of disconnected drivers

2023-06-15 Thread Ilias Apalodimas
efi_uninstall_protocol() calls efi_disconnect_all_drivers() but never checks the return value. Honor that and return an appropriate error if the associated controllers failed to disconnect Signed-off-by: Ilias Apalodimas --- lib/efi_loader/efi_boottime.c | 6 +- 1 file changed, 5

Re: [PATCH] arm: mx6: module_fuse: fix build failure due to wrong argument name

2023-06-15 Thread Fabio Estevam
On Thu, Apr 6, 2023 at 1:17 PM Giulio Benetti wrote: > > nodeoff variable should be variable off returned by fdt_path_offset() so > let's rename it to off. > > Signed-off-by: Giulio Benetti Reviewed-by: Fabio Estevam

Re: [PATCH] arm: mx6: module_fuse: fix build failure due to wrong argument name

2023-06-15 Thread Giulio Benetti
Hello All, On 07/04/23 03:52, Peng Fan wrote: On 4/7/2023 12:17 AM, Giulio Benetti wrote: nodeoff variable should be variable off returned by fdt_path_offset() so let's rename it to off. Signed-off-by: Giulio Benetti Reviewed-by: Peng Fan I kindly ping Best regards -- CEO/CTO@Benetti

[PATCH 6/7] configs: ls1046ardb: enable DM_SERIAL

2023-06-15 Thread Camelia Groza
As the serial devices are configured in the device tree, enable DM_SERIAL in the ls1046ardb defconfigs. Signed-off-by: Camelia Groza --- configs/ls1046ardb_emmc_defconfig | 3 ++- configs/ls1046ardb_qspi_SECURE_BOOT_defconfig | 4 +++- configs/ls1046ardb_qspi_defconfig

[PATCH 7/7] configs: ls1046afrwy: enable DM_SERIAL

2023-06-15 Thread Camelia Groza
As the serial devices are configured in the device tree, enable DM_SERIAL in the ls1046afrwy defconfigs. Signed-off-by: Camelia Groza --- configs/ls1046afrwy_tfa_SECURE_BOOT_defconfig | 4 +++- configs/ls1046afrwy_tfa_defconfig | 4 +++- 2 files changed, 6 insertions(+), 2

[PATCH 5/7] arch: arm: dts: ls1046a: tag serial nodes with bootph-all

2023-06-15 Thread Camelia Groza
Make sure the serial driver is initialized before relocation by tagging the serial nodes with "bootph-all". Signed-off-by: Camelia Groza --- arch/arm/dts/fsl-ls1046a.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/fsl-ls1046a.dtsi b/arch/arm/dts/fsl-ls1046a.dtsi index

[PATCH 4/7] arch: arm: dts: ls1046a: sync serial nodes with Linux

2023-06-15 Thread Camelia Groza
Pick up the serial node descriptions from Linux for the ls1046ardb and ls1046afrwy boards and their dependencies. Including the fsl,qoriq-clockgen.h and arm-gic.h headers forces us to change the include directives to explicitly go through the C preprocessor for all boards in the ls1046a SoC

[PATCH 3/7] configs: ls1043ardb: enable DM_SERIAL

2023-06-15 Thread Camelia Groza
As the serial devices are configured in the device tree, enable DM_SERIAL in the ls1043ardb defconfigs. Signed-off-by: Camelia Groza --- configs/ls1043ardb_SECURE_BOOT_defconfig| 4 +++- configs/ls1043ardb_defconfig| 4 +++-

[PATCH 2/7] arch: arm: dts: ls1043a: tag serial nodes with bootph-all

2023-06-15 Thread Camelia Groza
Make sure the serial driver is initialized before relocation by tagging the serial nodes with "bootph-all". Signed-off-by: Camelia Groza --- arch/arm/dts/fsl-ls1043a.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/fsl-ls1043a.dtsi b/arch/arm/dts/fsl-ls1043a.dtsi index

[PATCH 1/7] arch: arm: dts: ls1043a: sync serial nodes with Linux

2023-06-15 Thread Camelia Groza
Pick up the serial node descriptions from Linux for the ls1043ardb board and its dependencies. Including the fsl,qoriq-clockgen.h and arm-gic.h headers forces us to change the include directives to explicitly go through the C preprocessor for all boards in the ls1043a SoC family. Signed-off-by:

[PATCH 0/7] Enable DM_SERIAL for the LS104xA RDB/FRWY boards

2023-06-15 Thread Camelia Groza
This series enables DM_SERIAL for ls1043ardb, ls1046ardb and ls1046afrwy. First, the device tree serial nodes are synced with their counterpart descriptions in Linux. Secondly, the serial nodes are tagged with 'bootph-all' to guarantee the drivers are initialized before relocation. Lastly,

Re: [PATCH 1/1] bootm: don't call booti_setup for EFI images

2023-06-15 Thread Simon Glass
Hi Heinrich, On Thu, 15 Jun 2023 at 12:38, Heinrich Schuchardt wrote: > > On 6/15/23 11:14, Simon Glass wrote: > > On Tue, 13 Jun 2023 at 09:11, Heinrich Schuchardt > > wrote: > >> > >> On the arm64 architecture booti_setup() is called for EFI FIT images. > >> This function call fails because

Re: [PATCH] menu: Re-enable the ANSI codes

2023-06-15 Thread Simon Glass
Hi Pali, On Mon, 12 Jun 2023 at 22:33, Pali Rohár wrote: > > On Monday 12 June 2023 22:17:48 Simon Glass wrote: > > Hi Pali, > > > > On Mon, 12 Jun 2023 at 21:22, Pali Rohár wrote: > > > > > > On Monday 12 June 2023 21:14:32 Simon Glass wrote: > > > > The intent here was to allow ANSI codes to

Trying to boot custom kernel on Wink Hub (i.MX28)

2023-06-15 Thread Rogan Dawes
Hi folks, I am trying to boot a custom kernel on a Wink Hub v1, which has an i.MX28 CPU, and is running U-Boot (U-Boot 2014.01-14400-gda781c6-dirty (Apr 30 2014 - 22:35:38)). I have tried compiling my own modern kernel and putting it in place of the vendor (Linux version 2.6.35.3-flex-dvt)

[PATCH 1/1] test: correct architecture in EFI FIT test

2023-06-15 Thread Heinrich Schuchardt
On arm64 the its we use to generate the test FIT image has arch = "arm"; We should use "arm64" here which is mapped to IH_ARCH_ARM64 via uimage_arch[]. Fixes: 8391f955494e ("test/py: Create a test for launching UEFI binaries from FIT images") Signed-off-by: Heinrich Schuchardt ---

Re: [PATCH 1/3] binman: Allow to define custom arguments

2023-06-15 Thread Jan Kiszka
On 15.06.23 13:38, Simon Glass wrote: > Hi Jan, > > On Thu, 15 Jun 2023 at 12:21, Jan Kiszka wrote: >> >> On 15.06.23 13:19, Simon Glass wrote: >>> Hi Jan, >>> >>> On Thu, 15 Jun 2023 at 12:09, Jan Kiszka wrote: On 15.06.23 12:55, Simon Glass wrote: > Hi Jan, > > On Thu,

Re: [PATCH 1/3] binman: Allow to define custom arguments

2023-06-15 Thread Simon Glass
Hi Jan, On Thu, 15 Jun 2023 at 12:21, Jan Kiszka wrote: > > On 15.06.23 13:19, Simon Glass wrote: > > Hi Jan, > > > > On Thu, 15 Jun 2023 at 12:09, Jan Kiszka wrote: > >> > >> On 15.06.23 12:55, Simon Glass wrote: > >>> Hi Jan, > >>> > >>> On Thu, 15 Jun 2023 at 11:26, Jan Kiszka wrote: >

Re: [PATCH 1/1] bootm: don't call booti_setup for EFI images

2023-06-15 Thread Heinrich Schuchardt
On 6/15/23 11:14, Simon Glass wrote: On Tue, 13 Jun 2023 at 09:11, Heinrich Schuchardt wrote: On the arm64 architecture booti_setup() is called for EFI FIT images. This function call fails because EFI images typically do not have a kernel signature. Check that the operating system property

Re: [PATCH 3/3] boards: siemens: iot2050: Unify PG1 and PG2/M.2 configurations again

2023-06-15 Thread Jan Kiszka
On 12.06.23 23:17, Simon Glass wrote: > Hi Jan, > > On Mon, 5 Jun 2023 at 15:40, Jan Kiszka wrote: >> >> From: Jan Kiszka >> >> This avoids having to maintain to defconfigs that are 99% equivalent. >> The approach is to use binman to generate two flash images, >> flash-pg1.bin and

Re: [PATCH 1/3] binman: Allow to define custom arguments

2023-06-15 Thread Jan Kiszka
On 15.06.23 13:19, Simon Glass wrote: > Hi Jan, > > On Thu, 15 Jun 2023 at 12:09, Jan Kiszka wrote: >> >> On 15.06.23 12:55, Simon Glass wrote: >>> Hi Jan, >>> >>> On Thu, 15 Jun 2023 at 11:26, Jan Kiszka wrote: On 12.06.23 23:17, Simon Glass wrote: > Hi Jan, > > On Mon, 5

Re: [PATCH 1/3] binman: Allow to define custom arguments

2023-06-15 Thread Simon Glass
Hi Jan, On Thu, 15 Jun 2023 at 12:09, Jan Kiszka wrote: > > On 15.06.23 12:55, Simon Glass wrote: > > Hi Jan, > > > > On Thu, 15 Jun 2023 at 11:26, Jan Kiszka wrote: > >> > >> On 12.06.23 23:17, Simon Glass wrote: > >>> Hi Jan, > >>> > >>> On Mon, 5 Jun 2023 at 15:39, Jan Kiszka wrote: >

Re: [PATCH 1/3] binman: Allow to define custom arguments

2023-06-15 Thread Jan Kiszka
On 15.06.23 12:55, Simon Glass wrote: > Hi Jan, > > On Thu, 15 Jun 2023 at 11:26, Jan Kiszka wrote: >> >> On 12.06.23 23:17, Simon Glass wrote: >>> Hi Jan, >>> >>> On Mon, 5 Jun 2023 at 15:39, Jan Kiszka wrote: From: Jan Kiszka Introduce BINMAN_EXTRA_ARGS that can be set

Re: [PATCH 1/3] binman: Allow to define custom arguments

2023-06-15 Thread Simon Glass
Hi Jan, On Thu, 15 Jun 2023 at 11:26, Jan Kiszka wrote: > > On 12.06.23 23:17, Simon Glass wrote: > > Hi Jan, > > > > On Mon, 5 Jun 2023 at 15:39, Jan Kiszka wrote: > >> > >> From: Jan Kiszka > >> > >> Introduce BINMAN_EXTRA_ARGS that can be set per board, e.g., to inject > >> specific

Re: [PATCH v3 2/2] usb: musb-new: sunxi: clarify the purpose of SRAM initialization

2023-06-15 Thread Andre Przywara
On Mon, 12 Jun 2023 14:03:02 -0600 Sam Edwards wrote: > This is largely a cosmetic change, with one functional distinction: > We are now only setting BIT(0), and no longer clearing BIT(1). > > The A20 manual confirms the purpose and bitwidth of this field, and we > have also been doing it this

Re: [PATCH 1/3] binman: Allow to define custom arguments

2023-06-15 Thread Jan Kiszka
On 12.06.23 23:17, Simon Glass wrote: > Hi Jan, > > On Mon, 5 Jun 2023 at 15:39, Jan Kiszka wrote: >> >> From: Jan Kiszka >> >> Introduce BINMAN_EXTRA_ARGS that can be set per board, e.g., to inject >> specific settings. Will be used by IOT2050 first to define multiple >> of-lists. >> >>

[PATCH v2 2/3] riscv: dts: sync mpfs-icicle devicetree with linux

2023-06-15 Thread Conor Dooley
The "notable" disappearances are: - the pac193x stanza - there's nothing in mainline linux w.r.t. bindings for this & what is going to appear in mainline linux is going to be incompatible with what is currently in U-Boot. - operating points - these operating points should not be set at the

[PATCH v2 3/3] board: microchip: set mac address for ethernet1 on icicle

2023-06-15 Thread Conor Dooley
The dts sync from Linux leaves mac0/ethernet1 enabled on icicle, but U-Boot does not currently set a mac address for it. Expand on the code which currently sets the mac for mac1/ethernet0 to optionally set the mac address for the second ethernet. Reviewed-by: Padmarao Begari Tested-by: Padmarao

[PATCH v2 1/3] riscv: dts: drop microchip from dts filenames

2023-06-15 Thread Conor Dooley
The original names picked for the DT doesn't match Linux's naming scheme and it was renamed there a while ago. Rename it in U-Boot to allow easily syncing dts between the two projects. Reviewed-by: Rick Chen Reviewed-by: Padmarao Begari Signed-off-by: Conor Dooley --- arch/riscv/dts/Makefile

[PATCH v2 0/3] Sync PolarFire SoC dts with Linux

2023-06-15 Thread Conor Dooley
Hey, Couple of patches here that do a long-overdue sync of the Linux devicetree for PolarFire SoC & the Icicle kit with Linux. This wasn't possible for a while due to an incorrect dts & clock driver that were based on a pre-upstream version of the dt-binding. That's fixed now, so a complete

[GIT PULL] please pull fsl-qoriq-2023-6-15 for next

2023-06-15 Thread Peng Fan
Hi Tom, Please pull fsl-qoriq-2023-6-15 for next. DM_MDIO/CMD for ls1046afrwy sync APIs for fsl-mc ldpaa_eth update lx2160ardb recv support. net: dsa fix of fallback lookup CI:

[PATCH v5 11/11] board: starfive: Dynamic configuration of DT for 1.2A and 1.3B

2023-06-15 Thread Yanhong Wang
The main difference between StarFive VisionFive 2 1.2A and 1.3B is gmac. You can read the PCB version of the current board by get_pcb_revision_from_eeprom(), and then dynamically configure the difference of gmac in spl_perform_fixups() according to different PCB versions, so that one DT and one

[PATCH v5 10/11] ram: starfive: Read memory size information from EEPROM

2023-06-15 Thread Yanhong Wang
StarFive VisionFive 2 has two versions, 1.2A and 1.3B, each version of DDR capacity includes 2G/4G/8G, a DT can not support multiple capacities, so the capacity size information is recorded to EEPROM, when DDR initialization required capacity size information is read from EEPROM. If there is no

[PATCH v5 08/11] riscv: dts: starfive: Add support eeprom device tree node

2023-06-15 Thread Yanhong Wang
Add support "atmel,24c04" eeprom for StarFive VisionFive2 board. Signed-off-by: Yanhong Wang --- .../dts/jh7110-starfive-visionfive-2-u-boot.dtsi | 14 ++ arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi | 6 ++ 2 files changed, 20 insertions(+) diff --git

[PATCH v5 09/11] configs: starfive: Enable ID EEPROM configuration

2023-06-15 Thread Yanhong Wang
Enabled ID_EEPROM and I2C configuration for StarFive VisionFive2 board. Signed-off-by: Yanhong Wang --- .../visionfive2/starfive_visionfive2.c| 13 + configs/starfive_visionfive2_defconfig| 19 ++- 2 files changed, 31 insertions(+), 1 deletion(-)

[PATCH v5 07/11] eeprom: starfive: Enable ID EEPROM configuration

2023-06-15 Thread Yanhong Wang
Enabled ID_EEPROM configuration for StarFive VisionFive2 board. Signed-off-by: Yanhong Wang --- arch/riscv/include/asm/arch-jh7110/eeprom.h | 13 + board/starfive/visionfive2/Makefile | 1 + .../visionfive2/visionfive2-i2c-eeprom.c | 561 ++ 3 files changed,

[PATCH v5 05/11] doc: board: starfive: Reword the make defconfig information

2023-06-15 Thread Yanhong Wang
The defconfig file name for StarFive VisionFive2 has been changed, and the documentation description has also changed. Signed-off-by: Yanhong Wang --- doc/board/starfive/visionfive2.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/board/starfive/visionfive2.rst

[PATCH v5 06/11] configs: starfive: Enable ethernet configuration for StarFive VisionFive2

2023-06-15 Thread Yanhong Wang
Enable DWC_ETH_QOS and PHY_MOTORCOMM configuration to support ethernet function for StarFive VisionFive 2 board,including versions 1.2A and 1.3B. Signed-off-by: Yanhong Wang --- configs/starfive_visionfive2_defconfig | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v5 02/11] net: dwc_eth_qos: Add StarFive ethernet driver glue layer

2023-06-15 Thread Yanhong Wang
The StarFive ETHQOS hardware has its own clock and reset,so add a corresponding glue driver to configure them. Signed-off-by: Yanhong Wang Reviewed-by: Ramon Fried --- drivers/net/Kconfig| 7 + drivers/net/Makefile | 1 + drivers/net/dwc_eth_qos.c |

[PATCH v5 04/11] riscv: dts: jh7110: Combine the board device tree files of 1.2A and 1.3B

2023-06-15 Thread Yanhong Wang
The difference between 1.2A and 1.3B is dynamically configured according to the PCB version, and there is no difference on the board device tree, so the same DT file can be used. Signed-off-by: Yanhong Wang --- arch/riscv/dts/Makefile | 3 +- ...

[PATCH v5 03/11] riscv: dts: jh7110: Add ethernet device tree nodes

2023-06-15 Thread Yanhong Wang
Add ethernet device tree node to support StarFive ethernet driver for the JH7110 RISC-V SoC. Signed-off-by: Yanhong Wang --- .../dts/jh7110-starfive-visionfive-2.dtsi | 34 + arch/riscv/dts/jh7110.dtsi| 69 +++ 2 files changed, 103 insertions(+)

[PATCH v5 01/11] net: phy: Add driver for Motorcomm yt8531 gigabit ethernet phy

2023-06-15 Thread Yanhong Wang
Add a driver for the motorcomm yt8531 gigabit ethernet phy. We have verified the driver on StarFive VisionFive2 board. Signed-off-by: Yanhong Wang Reviewed-by: Ramon Fried --- drivers/net/phy/Kconfig | 6 + drivers/net/phy/Makefile| 1 + drivers/net/phy/motorcomm.c | 437

[PATCH v5 00/11] Add ethernet driver for StarFive JH7110 SoC

2023-06-15 Thread Yanhong Wang
This series of patches base on the latest branch/master,and adds ethernet support for the StarFive JH7110 RISC-V SoC. The series includes EEPROM, PHY and MAC drivers. The PHY model is YT8531 (from Motorcomm Inc), and the MAC version is dwmac-5.20 (from Synopsys DesignWare). The implementation of

[PATCH V2 12/30] imx: ele_api: add DEK Blob generation

2023-06-15 Thread Peng Fan (OSS)
From: Peng Fan - Add crc computation. - Add ele_generate_dek_blob API for encrypted boot support. Signed-off-by: Clement Faure Signed-off-by: Peng Fan --- arch/arm/include/asm/mach-imx/ele_api.h | 2 +- drivers/misc/imx_ele/ele_api.c | 44 + 2 files changed,

[PATCH V2 30/30] imx: fsl_sec: preprocessor casting issue with addresses involving math

2023-06-15 Thread Peng Fan (OSS)
From: Utkarsh Gupta The sec_in32 preprocessor is defined as follows in include/fsl_sec.h file: When address "a" is calculated using math for ex: addition of base address and an offset, then casting is applied only to the first address which in this example is base address. caam_ccbvid_reg =

[PATCH V2 29/30] imx: priblob: Update to use structure

2023-06-15 Thread Peng Fan (OSS)
From: Maximus Sun Use structure to avoid define CAAM_SCFGR for each platform Signed-off-by: Maximus Sun Signed-off-by: Peng Fan --- arch/arm/mach-imx/priblob.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-imx/priblob.c

[PATCH V2 28/30] imx: imx8m: add CAAM_BASE_ADDR

2023-06-15 Thread Peng Fan (OSS)
From: Peng Fan Add CAAM_BASE_ADDR which will be used by priblob.c Signed-off-by: Peng Fan --- arch/arm/include/asm/arch-imx8m/imx-regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/include/asm/arch-imx8m/imx-regs.h b/arch/arm/include/asm/arch-imx8m/imx-regs.h index

[PATCH V2 26/30] imx: ahab: Update AHAB for iMX8 and iMX8ULP

2023-06-15 Thread Peng Fan (OSS)
From: Ye Li Abstract common interfaces for AHAB authentication operations. Then share some common codes for AHAB and SPL container authentication Signed-off-by: Ye Li Signed-off-by: Peng Fan --- arch/arm/include/asm/mach-imx/ahab.h | 15 arch/arm/mach-imx/imx8/ahab.c| 129

[PATCH V2 27/30] imx: imx8: ahab: sha256: enable image verification using ARMv8 crypto extension

2023-06-15 Thread Peng Fan (OSS)
From: Gaurav Jain add support for SHA-256 secure hash algorithm using the ARM v8 SHA-256 instructions for verifying image hash. Signed-off-by: Gaurav Jain Signed-off-by: Peng Fan --- arch/arm/mach-imx/imx8/ahab.c | 28 1 file changed, 24 insertions(+), 4

[PATCH V2 25/30] imx: parse-container: Use malloc for container processing

2023-06-15 Thread Peng Fan (OSS)
From: Nitin Garg If the container has image which conflicts with spl_get_load_buffer address, there are processing failures. Use malloc instead of spl_get_load_buffer. Reviewed-by: Ye Li Signed-off-by: Nitin Garg Signed-off-by: Peng Fan --- arch/arm/mach-imx/parse-container.c | 38

[PATCH V2 24/30] imx: imx8m: clock: not configure reserved SRC register

2023-06-15 Thread Peng Fan (OSS)
From: Peng Fan i.MX8M[M,N,P] SRC not has 0x1004 offset register, so drop it. Reviewed-by: Ye Li Signed-off-by: Peng Fan --- arch/arm/mach-imx/imx8m/clock_imx8mm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-imx/imx8m/clock_imx8mm.c

[PATCH V2 23/30] imx: imx8: bootaux: Add i.MX8 M4 boot support

2023-06-15 Thread Peng Fan (OSS)
From: Ye Li 1. Implement bootaux for the M4 boot on i.MX8QM and QXP. Users need to download M4 image to any DDR address first. Then use the "bootaux [M4 core id]" to boot CM4_0 or CM4_1, the default core id is 0 for CM4_0. Since current M4 only supports running in TCM. The bootaux

[PATCH V2 22/30] imx: bootaux: Fix bootaux issue when running on ARM64

2023-06-15 Thread Peng Fan (OSS)
From: Ye Li The bootaux uses ulong to read private data and write to M4 TCM, this cause problem on ARM64 platform where the ulong is 8bytes. Fix it by using u32 to replace ulong. Reviewed-by: Peng Fan Signed-off-by: Ye Li Signed-off-by: Peng Fan --- arch/arm/mach-imx/imx_bootaux.c | 6

[PATCH V2 21/30] imx: bootaux: change names of MACROs used to boot MCU on iMX devices

2023-06-15 Thread Peng Fan (OSS)
From: Peng Fan The current bootaux supports i.MX8M and i.MX93, but the name "_M4_" implies that the SoCs have Cortex-M4. Actually i.MX8MM/Q use Cortex-M4, i.MX8MN/P use Cortex-M7, i.MX93 use Cortex-M33, so use "_MCU_" in place of "_M4_" to simplify the naming. Signed-off-by: faqiang.zhu

[PATCH V2 20/30] imx: iamge-container: support secondary container

2023-06-15 Thread Peng Fan (OSS)
From: Peng Fan Add the support for loading image from secondary container set on iMX8QM B0, iMX8QXP C0. Using the SCFW API to get container set index, if it is the secondary boot, get the offset from fuse and apply to offset of current container set beginning for loading. Also override the

[PATCH V2 19/30] imx: image-container: Fix container header checking

2023-06-15 Thread Peng Fan (OSS)
From: Ye Li Checking container header tag and version is wrong, it causes to fail to bypass invalid container Reviewed-by: Peng Fan Signed-off-by: Ye Li Signed-off-by: Peng Fan --- arch/arm/mach-imx/image-container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH V2 18/30] imx: hab: Fix coverity issue in HAB event decoding

2023-06-15 Thread Peng Fan (OSS)
From: Ye Li Fix below coverity issues caused by get_idx function where "-1" is compared with uint8_t "element" 343336 Unsigned compared with neg 343337 Operands don't affect result Additional, this function returns "-1" will cause overflow to event string array. Reviewed-by: Peng Fan

[PATCH V2 17/30] imx: imx8ulp: start the ELE RNG at boot

2023-06-15 Thread Peng Fan (OSS)
From: Peng Fan On the imx8ulp A1 SoC, the ELE RNG needs to be manually started. Signed-off-by: Clement Faure Signed-off-by: Peng Fan --- arch/arm/include/asm/mach-imx/ele_api.h | 1 + board/freescale/imx8ulp_evk/spl.c | 10 ++ drivers/misc/imx_ele/ele_api.c | 25

[PATCH V2 16/30] imx: misc: ele_mu: Update ELE MU driver

2023-06-15 Thread Peng Fan (OSS)
From: Ye Li Extend the RX timeout value to 10s, because when authentication is failed the ELE needs long time (>2s for 28M image) to return the result. Print rx wait info per 1s. Also correct TX and RX status registers in debug. Signed-off-by: Ye Li Signed-off-by: Peng Fan ---

[PATCH V2 14/30] imx: cmd_dek: add ELE DEK Blob generation support

2023-06-15 Thread Peng Fan (OSS)
From: Clement Faure Add ELE DEK Blob generation for the cmd_dek command. Signed-off-by: Clement Faure Signed-off-by: Peng Fan --- arch/arm/mach-imx/Kconfig | 7 arch/arm/mach-imx/cmd_dek.c | 84 + 2 files changed, 91 insertions(+) diff --git

[PATCH V2 15/30] imx: misc: ele_mu: Update MU TR registers count

2023-06-15 Thread Peng Fan (OSS)
From: Ye Li According to SRM, the Sentinel MU has 8 TR and 4 RR registers. All of them are used for ELE message. So update TR count to 8 and fix a typo in receive msg Reviewed-by: Peng Fan Signed-off-by: Ye Li Signed-off-by: Peng Fan --- drivers/misc/imx_ele/ele_mu.c | 4 ++-- 1 file

[PATCH V2 13/30] imx: cmd_dek: Fix Uninitialized pointer read

2023-06-15 Thread Peng Fan (OSS)
From: Ye Li Fix Coverity (CID 21143558). When tee_shm_register returns failure, the shm_input pointer is invalid, should not free it. Same issue also exists on registering shm_output. Reviewed-by: Peng Fan Signed-off-by: Ye Li Signed-off-by: Peng Fan --- arch/arm/mach-imx/cmd_dek.c | 3 ++-

[PATCH V2 08/30] imx: use generic name ele(EdgeLockSecure Enclave)

2023-06-15 Thread Peng Fan (OSS)
From: Peng Fan Per NXP requirement, we rename all the NXP EdgeLock Secure Enclave code including comment, folder and API name to ELE to align. Signed-off-by: Peng Fan --- arch/arm/Kconfig | 4 +- arch/arm/include/asm/arch-imx9/ccm_regs.h | 2 +-

[PATCH V2 11/30] imx: ele_api: support program secure fuse and return lifecycle

2023-06-15 Thread Peng Fan (OSS)
From: Peng Fan Add two ELE API: ele_return_lifecycle_update and ele_write_secure_fuse Add two cmd: ahab_return_lifecycle and ahab_sec_fuse_prog Signed-off-by: Peng Fan --- arch/arm/include/asm/mach-imx/ele_api.h | 2 + arch/arm/mach-imx/ele_ahab.c| 74 +

[PATCH V2 10/30] imx: ele_ahab: use hextoul

2023-06-15 Thread Peng Fan (OSS)
From: Peng Fan Use hextoul which looks a bit simpler. Signed-off-by: Peng Fan --- arch/arm/mach-imx/ele_ahab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/ele_ahab.c b/arch/arm/mach-imx/ele_ahab.c index 9bb37919638..5f23486304c 100644 ---

[PATCH V2 09/30] imx: parse-container: fix build warning

2023-06-15 Thread Peng Fan (OSS)
From: Peng Fan Fix build warning: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘u64’ {aka ‘long long unsigned int’} [-Wformat=] printf("can't find memreg for image %d load address 0x%x, error %d\n", warning: format ‘%lx’ expects argument of type

[PATCH V2 07/30] imx: scu_api: update to version 1.16 and add more APIs

2023-06-15 Thread Peng Fan (OSS)
From: Peng Fan Upgrade SCFW API to 1.16 Add more APIs: sc_misc_get_button_status sc_pm_reboot sc_seco_v2x_build_info Signed-off-by: Peng Fan --- drivers/misc/imx8/scu_api.c | 78 include/firmware/imx/sci/rpc.h | 27 ---

[PATCH V2 06/30] imx: congatec/cgtqmx8: correct SCU API usage

2023-06-15 Thread Peng Fan (OSS)
From: Peng Fan The return value is int type, not sc_err_t(u8), correct the usage. Signed-off-by: Peng Fan Tested-by: Oliver Graute Reviewed-by: Oliver Graute --- board/congatec/cgtqmx8/cgtqmx8.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH V2 05/30] imx: advantech: correct SCU API usage

2023-06-15 Thread Peng Fan (OSS)
From: Peng Fan The return value is int type, not sc_err_t(u8), correct the usage. Signed-off-by: Peng Fan Tested-by: Oliver Graute Reviewed-by: Oliver Graute --- board/advantech/imx8qm_dmsse20_a1/spl.c | 6 +++--- board/advantech/imx8qm_rom7720_a1/spl.c | 6 +++--- 2 files changed, 6

[PATCH V2 04/30] imx: siemens/capricorn: correct SCU API usage

2023-06-15 Thread Peng Fan (OSS)
From: Peng Fan The return value is int type, not sc_err_t(u8), correct the usage. Signed-off-by: Peng Fan --- board/siemens/capricorn/board.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/board/siemens/capricorn/board.c b/board/siemens/capricorn/board.c

  1   2   >