Re: [PATCH v2] mx6cuboxi: Fix Ethernet after DT sync with Linux

2024-04-01 Thread Christian Gmeiner
x6qdl-sr-som-u-boot.dtsi.] > Signed-off-by: Fabio Estevam > Tested-by: Christian Gmeiner > --- > Changes since v1: > - Disable ethernet-phy at addresses 0, 1 and 4. > - Remove the fixup of the fake 0xff address before booting Linux. > > Josua and Christian, &

Re: [PATCH v2] mx6cuboxi: Do not print devicetree model

2024-04-01 Thread Christian Gmeiner
fit WDT: Started watchdog@20bc000 with servicing every 1000ms (128s timeout) MMC: FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... *** Warning - bad CRC, using default environment In:serial Out: serial Err: serial Board: MX6 Cubox-i Net: eth0: ethernet@2188000 Tested-by: Christian Gmeiner Thanks & Regards, Christian

Re: [PATCH] mx6cuboxi: Do not print devicetree model

2024-03-28 Thread Christian Gmeiner
Hi Fabio > The mx6cuboxi_defconfig target supports several board > variants. All of these variants use the hummingboard devicetree in U-Boot. > > Currently, the devicetree model as well as the board variant name > are shown: > > U-Boot 2024.04-rc5-3-g774ec4fda8 (Mar 27 2024 - 16:48:35

Re: [PATCH] mx6cuboxi: fix ethernet after synchronise device-tree

2024-03-28 Thread Christian Gmeiner
are > touching ft_board_setup(). I am able to load kernel and dtb via tftp and ssh into a nfs debian rootfs. Thanks a lot - all my problems are solved :) -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH] mx6cuboxi: Convert to watchdog driver model

2024-03-27 Thread Christian Gmeiner
=> => reset resetting ... U-Boot SPL 2024.04-rc5-3-g3988fdb94c (Mar 27 2024 - 17:00:03 +0100) WDT: Started watchdog@20bc000 with servicing every 1000ms (128s timeout) ... Tested-by: Christian Gmeiner Thanks & Regards, Christian

Re: [PATCH] mx6cuboxi: fix ethernet after synchronise device-tree

2024-03-27 Thread Christian Gmeiner
unning"; > >>> - status = "disabled"; > >>> }; > >>> }; > >>> }; > >>> diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c > >>> b/board/solidrun/mx6cuboxi/mx6cuboxi.c > >>> index debf4f6a3b..52172a03b1 100644 > >>> ---_a/board/solidrun/mx6cuboxi/mx6cuboxi.c > >>> +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c > >>> @@ -446,7 +446,7 @@ static int find_ethernet_phy(void) > >>> */ > >>> int ft_board_setup(void *fdt, struct bd_info *bd) > >>> { > >>> - int node_phy0, node_phy1, node_phy4; > >>> + int node_phy, node_phy0, node_phy1, node_phy4; > >>> int ret, phy; > >>> bool enable_phy0 = false, enable_phy1 = false, enable_phy4 = > >>> false; > >>> enum board_type board; > >>> @@ -478,6 +478,10 @@ int ft_board_setup(void *fdt, struct bd_info *bd) > >>> return 0; > >>> } > >>> > >>> + // update U-Boot's own unified phy node phy address, if > >>> present > >>> + node_phy = fdt_path_offset(fdt, > >>> "/soc/bus@210/ethernet@2188000/mdio/phy"); > >>> + ret = fdt_setprop_u32(fdt, node_phy, "reg", phy); > >>> + > >>> // update all phy nodes status > >>> node_phy0 = fdt_path_offset(fdt, > >>> "/soc/bus@210/ethernet@2188000/mdio/ethernet-phy@0"); > >>> ret = fdt_setprop_string(fdt, node_phy0, "status", > >>> enable_phy0 ? "okay" : "disabled"); > >>> --_ > >>> 2.37.1 > >>> -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH] mx6cuboxi: fix ethernet after synchronise device-tree

2024-03-27 Thread Christian Gmeiner
1 = false, enable_phy4 = > > false; > > enum board_type board; > > @@ -478,6 +478,10 @@ int ft_board_setup(void *fdt, struct bd_info *bd) > > return 0; > > } > > > > + // update U-Boot's own unified phy node phy address, if present > > + node_phy = fdt_path_offset(fdt, > > "/soc/bus@210/ethernet@2188000/mdio/phy"); > > + ret = fdt_setprop_u32(fdt, node_phy, "reg", phy); > > + > > // update all phy nodes status > > node_phy0 = fdt_path_offset(fdt, > > "/soc/bus@210/ethernet@2188000/mdio/ethernet-phy@0"); > > ret = fdt_setprop_string(fdt, node_phy0, "status", enable_phy0 > > ? "okay" : "disabled"); > > --_ > > 2.37.1 > > -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH] mx6cuboxi: Fix board revision detection

2024-03-27 Thread Christian Gmeiner
he GPIO DM > API, but board_type() still uses the legacy non-DM GPIO API. > > Fix it by using the GPIO DM API in board_type() to read the > board revision pins in SPL. > > Reported-by: Christian Gmeiner > Signed-off-by: Fabio Estevam Tested-by: Christian Gmeiner -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: mx6cuboxi: failes to detect model

2024-03-27 Thread Christian Gmeiner
return HUMMINGBOARD; > - > - gpio_direction_input(IMX_GPIO_NR(4, 9)); > - val1 = gpio_get_value(IMX_GPIO_NR(4, 9)); > + val1 = !!dm_gpio_get_value(&(board_detect_desc[2])); > > if (val1 == 0) { > return CUBOXI; It does help \o/

Re: mx6cuboxi: failes to detect model

2024-03-26 Thread Christian Gmeiner
Hi Fabio > > On Tue, Mar 26, 2024 at 12:17 PM Christian Gmeiner > wrote: > > > > I am seeing model detection problems with the current git master. > > > > U-Boot 2024.04-rc5 (Mar 26 2024 - 15:59:22 +0100) > > > > CPU: Freescale i.MX6Q rev1.3 996

mx6cuboxi: failes to detect model

2024-03-26 Thread Christian Gmeiner
directions on how to fix this issue. -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH v2 5/6] led: led_pwm: use led_bind_generic() helper

2023-11-27 Thread Christian Gmeiner
> > Use the helper led_bind_generic() to reduce code duplication. > > Signed-off-by: Rasmus Villemoes Reviewed-by: Christian Gmeiner > --- > drivers/led/led_pwm.c | 14 +- > 1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/drivers/

Re: [PATCH v2 4/6] led: led_gpio: use led_bind_generic() helper

2023-11-27 Thread Christian Gmeiner
> > Use the helper led_bind_generic() to reduce code duplication. > > Signed-off-by: Rasmus Villemoes Reviewed-by: Christian Gmeiner > --- > drivers/led/led_gpio.c | 15 +-- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/drivers/l

Re: [PATCH 2/6] led-uclass: honour ->label field populated by driver's own .bind

2023-11-14 Thread Christian Gmeiner
has been ongoing for many many years (I think there was an > > LWN article at some point), where this could be exposed as a single > > multi-color LED, as opposed to the "traditional" three/four individual > > LEDs. In the former case, there would only be one sysfs entry, but with > > attributes exposing the multicolor functionality. I must admit I don't > > know the status of that work, when something reaches v31, > > http://archive.lwn.net:8080/linux-kernel/20200722071055.GA8984@amd/t/ , > > it's hard to know if it ever lands, or if pieces of it has landed.] > > +CC Pavel -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH] led: Do not overwrite label

2023-11-14 Thread Christian Gmeiner
ping Am Mo., 23. Okt. 2023 um 10:26 Uhr schrieb Marek Vasut : > > On 10/23/23 10:21, Christian Gmeiner wrote: > > label might have been set by a non device-tree based U-Boot driver already. > > > > In my concrete case there is a PCI driver that uses device_bind_driver(..)

Re: [PATCH 2/6] led-uclass: honour ->label field populated by driver's own .bind

2023-10-23 Thread Christian Gmeiner
entry, but with > attributes exposing the multicolor functionality. I must admit I don't > know the status of that work, when something reaches v31, > http://archive.lwn.net:8080/linux-kernel/20200722071055.GA8984@amd/t/ , > it's hard to know if it ever lands, or if pieces of it has landed.] > > Rasmus > I have an almost similar patch sent out today as I have not seen yours before. The end results is the same as mine https://patchwork.ozlabs.org/project/uboot/patch/20231023082117.39290-1-christian.gmei...@gmail.com/ Reviewed-by: Christian Gmeiner -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

[PATCH] led: Do not overwrite label

2023-10-23 Thread Christian Gmeiner
are not available. Fixes: 83c63f0d11 ("led: Move OF "label" property parsing to core") Signed-off-by: Christian Gmeiner --- drivers/led/led-uclass.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/led/led-uclass.c b/drivers/led/led-uclas

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-13 Thread Christian Gmeiner
nst it Peter. After that I lost motivation on working on this series as I had the feeling you will always be against adding legacy stuff that is still used today. Tom had taken it and committed it to the master branch. Peter, If you feel better let's revert all the changes. -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-11 Thread Christian Gmeiner
Am So., 11. Juni 2023 um 17:10 Uhr schrieb Pali Rohár : > > On Sunday 11 June 2023 16:57:07 Christian Gmeiner wrote: > > Hello > > > > > > > > Hello! I must admit that this patch is broken and does not add any NFSv1 > > > support. Just look below

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-11 Thread Christian Gmeiner
Am So., 11. Juni 2023 um 15:02 Uhr schrieb Peter Robinson : > > On Sun, Jun 11, 2023 at 1:54 PM Pali Rohár wrote: > > > > Hello! I must admit that this patch is broken and does not add any NFSv1 > > support. Just look below > > > > On Friday 10 March 2

Re: [PATCH v2 4/4] net: add NFSv1 support

2023-06-11 Thread Christian Gmeiner
Hello > > Hello! I must admit that this patch is broken and does not add any NFSv1 > support. Just look below > So .. let see what happend here. > On Friday 10 March 2023 10:51:55 Christian Gmeiner wrote: > > From: Thomas RIENOESSL > > > > NFSv1 support a

Re: [PATCH v3 00/19] Migration to using binman for bootloader

2023-05-05 Thread Christian Gmeiner
Hi > > On 04/05/23 14:08, Christian Gmeiner wrote: > > Hi > > > >> > >> This series aims to eliminate the use of additional custom repositories > >> such as k3-image-gen (K3 Image Generation) repo and core-secdev-k3 (K3 > >> Security Developm

Re: [PATCH v3 00/19] Migration to using binman for bootloader

2023-05-04 Thread Christian Gmeiner
es building U-Boot with sysfw alot - thanks for your work! I have tested this series on an am642 based design. One thing is missing for my HSM use case. I want to build an unsigned Image and need to sign it with binman in the context of the HSM. Therefore we need repacking support. Are you workin

Re: [PATCH 1/4] net: e1000: add and make use of NUM_RX_DESC macro

2023-05-02 Thread Christian Gmeiner
Am Sa., 1. Apr. 2023 um 21:01 Uhr schrieb Ramon Fried : > > On Fri, Mar 3, 2023 at 10:49 PM Christian Gmeiner > wrote: > > > > The call to DEFINE_ALIGN_BUFFER for the rx_desc array > > conained an icnonsistency as 16 receive descriptors > > were allocated when

[PATCH v3] ata: pci: enable bus mastering

2023-04-11 Thread Christian Gmeiner
The non DM code path already would enable pci bus mastering. Do the same for the DM code path. Fixes AHCI problems I am seeing on an Intel Apollolake device. Signed-off-by: Christian Gmeiner Reviewed-by: Bin Meng --- v2: Add Bin's R-b and remove the ending '.' from comment. v3: Add the patch

Re: [PATCH v2] ata: pci: enable bus mastering

2023-04-11 Thread Christian Gmeiner
Am Di., 11. Apr. 2023 um 16:29 Uhr schrieb Bin Meng : > > On Tue, Apr 11, 2023 at 10:25 PM Christian Gmeiner > wrote: > > > > The non DM code path already would enable pci bus mastering. Do the > > same for the DM code path. > > > > Fixes AHCI problems I

[PATCH v2] ata: pci: enable bus mastering

2023-04-11 Thread Christian Gmeiner
The non DM code path already would enable pci bus mastering. Do the same for the DM code path. Fixes AHCI problems I am seeing on an Intel Apollolake device. v2: Add Bin's R-b and remove the ending '.' from comment. Signed-off-by: Christian Gmeiner Reviewed-by: Bin Meng --- drivers/ata

[PATCH] ata: pci: enable bus mastering

2023-04-11 Thread Christian Gmeiner
The non DM code path already would enable pci bus mastering. Do the same for the DM code path. Fixes AHCI problems I am seeing on an Intel Apollolake device. Signed-off-by: Christian Gmeiner --- drivers/ata/ahci.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v4 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-04-09 Thread Christian Gmeiner
e rest of the SoC IDs for completeness and later use. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > arch/arm/mach-k3/common.c | 20 -- > arch/arm/mach-k3/common.h | 3 --- > arch/ar

Re: [PATCH v3 12/12] arm: mach-k3: Remove empty sys_proto.h include

2023-04-06 Thread Christian Gmeiner
> > This header file is now empty, remove it. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > arch/arm/mach-k3/am642_init.c | 2 -- > arch/arm/mach-k3/am654_init.c | 1 - > arch/arm/mach-k3/common.c |

Re: [PATCH v3 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-06 Thread Christian Gmeiner
ned-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > arch/arm/mach-k3/Kconfig | 5 - > arch/arm/mach-k3/am642_init.c | 4 ++-- > arch/arm/mach-k3/am654_init.c | 4 ++-- > arch/arm/mach-k3/common.c | 10

Re: [PATCH v3 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-04-06 Thread Christian Gmeiner
TYPE_SHIFT 0 > #define SYS_STATUS_DEV_TYPE_MASK (0xf) > diff --git a/arch/arm/mach-k3/include/mach/sys_proto.h > b/arch/arm/mach-k3/include/mach/sys_proto.h > index 0b5d606eaa2..d5d4b787b7d 100644 > --- a/arch/arm/mach-k3/include/mach/sys_proto.h > +++ b/arch/arm/mach-k3/inc

Re: [PATCH] arm: mach-k3: am642: move do_dt_magic() after sysfw loading

2023-04-06 Thread Christian Gmeiner
> > Makes it possible to use e.g mcu_spi0 for custom board detection. > gentle ping > Signed-off-by: Christian Gmeiner > --- > arch/arm/mach-k3/am642_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-k3/am64

Re: [PATCH 2/4] net: e1000: move all rx data structures to hw instance

2023-04-06 Thread Christian Gmeiner
> > On Wed, Apr 05, 2023 at 09:50:08AM +0200, Christian Gmeiner wrote: > > Hi all > > > > > > > > Preparation for per driver instance allocated data structures. > > > > > > Signed-off-by: Christian Gmeiner > > > > gentle pin

Re: [PATCH v2 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-06 Thread Christian Gmeiner
Am Mi., 5. Apr. 2023 um 22:29 Uhr schrieb Andrew Davis : > > On 4/5/23 3:09 PM, Christian Gmeiner wrote: > > Hi > > > >> > >> This matches how it was done for pre-K3 TI platforms and it allows > >> us to move the forward declaration out of sy

Re: [PATCH v2 04/12] configs: j721x_evm: Remove unneeded check for SYS_K3_SPL_ATF

2023-04-06 Thread Christian Gmeiner
> > The TARGET_x_R5_EVM check is already enough to limit these defines to > only the correct builds. Remove the extra outer check. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > board/ti/j721e/j721e.env | 2 -- > board/ti/j721s2/j721s2.env |

Re: [PATCH v2 07/12] arm: mach-k3: Move sysfw-loader.h out of mach includes

2023-04-06 Thread Christian Gmeiner
> > This header is only used locally by K3 init files, no need to have it > up with the global mach includes. Move into local includes. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > arch/arm/mach-k3/am625_init.c | 2 +

Re: [PATCH v2 06/12] arm: mach-k3: Make release_resources_for_core_shutdown() common

2023-04-06 Thread Christian Gmeiner
> > This function is the same for each device when it needs to shutdown > the R5 core. Move this to the common section and move the remaining > device specific ID list to the device hardware include. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --

Re: [PATCH v2 11/12] arm: mach-k3: Move J721s2 SPL init functions to mach-k3

2023-04-06 Thread Christian Gmeiner
> > This matches AM64 and J721e and removes the need to forward > declare k3_spl_init(), k3_mem_init(), and check_rom_loaded_sysfw() > in sys_proto.h. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > arch/arm/mach-k3/include/mach/sys_proto.h |

Re: [PATCH v2 10/12] arm: mach-k3: Move sdelay() and wait_on_value() declaration

2023-04-06 Thread Christian Gmeiner
s.c > +++ b/drivers/ram/k3-am654-ddrss.c > @@ -18,6 +18,10 @@ > #include > #include "k3-am654-ddrss.h" > > +void sdelay(unsigned long loops); > +u32 wait_on_value(u32 read_bit_mask, u32 match_value, void *read_addr, > + u32 bound); > + > #d

Re: [PATCH v2 09/12] arm: mach-k3: Remove unused fdt_disable_node()

2023-04-06 Thread Christian Gmeiner
> > This function is not used currently; remove it. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > arch/arm/mach-k3/common.c | 19 --- > arch/arm/mach-k3/include/mach/sys_proto.h | 1 - > 2 files changed, 20 del

Re: [PATCH v2 05/12] configs: j721s2_evm.h: Remove refrences to J7200 EVM

2023-04-06 Thread Christian Gmeiner
> > The J7200 EVM will not include this file, this J7200 checks look > to be a copy/paste errora from j721e_evm.h, which J7200 *can* include. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > include/configs/j721s2_evm.h | 2 +- > 1 file ch

Re: [PATCH v2 03/12] soc: soc_ti_k3: Use hardware.h to remove definition duplication

2023-04-06 Thread Christian Gmeiner
> > The K3 JTAG and SoC ID information is already stored in the K3 arch > hardware file, include that and use its definitions here. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner > --- > drivers/soc/Kconfig | 2 +- > driv

Re: [PATCH v2 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-04-06 Thread Christian Gmeiner
u32 soc; > + > + soc = (readl(CTRLMMR_WKUP_JTAG_ID) & > + JTAG_ID_PARTNO_MASK) >> JTAG_ID_PARTNO_SHIFT; > + > + return soc == JTAG_ID_PARTNO_J721E; > +} > + > +bool soc_is_j7200(void) static bool soc_is_j7200(void) > +{ > + u32 soc; > +

Re: [PATCH v2 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-05 Thread Christian Gmeiner
--git a/board/ti/common/Kconfig b/board/ti/common/Kconfig > index f03357cc751..49edd98014a 100644 > --- a/board/ti/common/Kconfig > +++ b/board/ti/common/Kconfig > @@ -1,6 +1,5 @@ > config TI_I2C_BOARD_DETECT > bool "Support for Board detection for TI platforms" > - select K3_BOARD_DETECT if ARCH_K3 > help >Support for detection board information on Texas Instrument's >Evaluation Boards which have I2C based EEPROM detection > -- > 2.39.2 > -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH 2/4] net: e1000: move all rx data structures to hw instance

2023-04-05 Thread Christian Gmeiner
Hi all > > Preparation for per driver instance allocated data structures. > > Signed-off-by: Christian Gmeiner gentle ping - what can I do better to get some feedback, RBs, etc faster? This experience is quite frustrating and it happens for me from time to time for U-Boot patches

Re: [PATCH v3 08/16] pci: coreboot: Don't read regions when booting

2023-04-02 Thread Christian Gmeiner
Signed-off-by: Simon Glass > Reviewed-by: Bin Meng Tested-by: Christian Gmeiner This fixes a regression that got introduced with f2ebaaa9f3 ("pci: Handle failed calloc in decode_regions()") For more details see: https://lore.kernel.org/all/202205191

Re: [PATCH 01/12] arm: mach-k3: Move MSMC fixup to SoC level

2023-04-02 Thread Christian Gmeiner
uses these SoCs. > > We use ft_system_setup() here instead of ft_board_setup() since it is no > longer board level. Enable OF_SYSTEM_SETUP in the configurations that use > this to keep functionality the same. > > Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner &

Re: [PATCH 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-02 Thread Christian Gmeiner
is function, which might not be the right guard ifdef > should a board use a different method for board detection. > > Signed-off-by: Andrew Davis This change is conflicting with what is u-boot/next: https://source.denx.de/u-boot/u-boot/-/commit/e44657ed744d1b4e216d8dda5d528ff0d0a623

[PATCH] arm: mach-k3: am642: move do_dt_magic() after sysfw loading

2023-03-28 Thread Christian Gmeiner
Makes it possible to use e.g mcu_spi0 for custom board detection. Signed-off-by: Christian Gmeiner --- arch/arm/mach-k3/am642_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-k3/am642_init.c b/arch/arm/mach-k3/am642_init.c index 96f292ea75..2478ac162b

Re: [PATCH v2 0/4] NFSv1 support

2023-03-24 Thread Christian Gmeiner
Hi Peter > > > > Hi Peter, > > > > Am Fr., 24. März 2023 um 11:10 Uhr schrieb Peter Robinson > > : > > > > > > On Fri, Mar 24, 2023 at 9:35 AM Christian Gmeiner > > > wrote: > > > > > > > > Hi Peter, >

Re: [PATCH v2 0/4] NFSv1 support

2023-03-24 Thread Christian Gmeiner
Hi Peter, Am Fr., 24. März 2023 um 11:10 Uhr schrieb Peter Robinson : > > On Fri, Mar 24, 2023 at 9:35 AM Christian Gmeiner > wrote: > > > > Hi Peter, > > > > > > > > > > This patch series adds support for NFSv1 and is more &

Re: [PATCH v2 0/4] NFSv1 support

2023-03-24 Thread Christian Gmeiner
e case but we want to upstream most of our downstream patches. Btw. if this patch series will not land does this mean NFSv2 will die too soon? -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH v2 0/4] NFSv1 support

2023-03-24 Thread Christian Gmeiner
is just a bootloader. As TCP support landed I thought I might > > give this patch series another try. > > > > gentle ping Adding some more people to CC - maybe this helps. -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH v2 08/16] pci: coreboot: Don't read regions when booting

2023-03-24 Thread Christian Gmeiner
t; > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng Tested-by: Christian Gmeiner This fixes a regression that got introduced with f2ebaaa9f3 ("pci: Handle failed calloc in decode_regions()") For more details see: https://lore.kernel.org/all/202205191648

Re: [PATCH 1/4] net: e1000: add and make use of NUM_RX_DESC macro

2023-03-23 Thread Christian Gmeiner
> > > > > The call to DEFINE_ALIGN_BUFFER for the rx_desc array > > conained an icnonsistency as 16 receive descriptors > > were allocated when the remaining code would only use > > 8 of them. > > > > Signed-off-by: Christian Gmeiner > > g

Re: [PATCH] pci: Handle failed calloc in decode_regions()

2023-03-22 Thread Christian Gmeiner
Hi > > Hi, > > On Tue, Mar 21, 2023 at 08:57:18AM +0100, Christian Gmeiner wrote: > > Am So., 4. Dez. 2022 um 22:22 Uhr schrieb Pierre-Clément Tosi > > : > > > > > > Hi, > > > > > > On Fri, Dec 02, 2022 at 08:38:37PM +0100, s...@g

Re: [PATCH 07/13] pci: coreboot: Don't read regions when booting

2023-03-22 Thread Christian Gmeiner
nges. > > > > Signed-off-by: Simon Glass > > --- > > > > drivers/pci/pci-uclass.c | 4 > > 1 file changed, 4 insertions(+) > > > Tested-by: Christian Gmeiner -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH] pci: Handle failed calloc in decode_regions()

2023-03-21 Thread Christian Gmeiner
return; > > > + return 0; > > > > > > for (i = 0; i < CONFIG_NR_DRAM_BANKS; ++i) { > > > if (bd->bi_dram[i].size) { > > > @@ -1068,7 +1070,7 @@ static void decode_regions(struct pci_controller > > > *hose, ofnode parent_node, > > >

Re: [PATCH 1/4] net: e1000: add and make use of NUM_RX_DESC macro

2023-03-17 Thread Christian Gmeiner
> > The call to DEFINE_ALIGN_BUFFER for the rx_desc array > conained an icnonsistency as 16 receive descriptors > were allocated when the remaining code would only use > 8 of them. > > Signed-off-by: Christian Gmeiner gentle ping -- greets -- Christian Gmeiner, M

Re: [PATCH v2 0/4] NFSv1 support

2023-03-17 Thread Christian Gmeiner
ded I thought I might > give this patch series another try. > gentle ping -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

[PATCH v2 4/4] net: add NFSv1 support

2023-03-10 Thread Christian Gmeiner
From: Thomas RIENOESSL NFSv1 support added by Christian Gmeiner, Thomas Rienoessl, September 27, 2018. As of now, NFSv3 is the default choice. if the server does not support NFSv3, we fall back to versions 2 or 1. Signed-off-by: Thomas RIENOESSL --- net/nfs.c | 42

[PATCH v2 2/4] nfs: factor out generic reply error handling

2023-03-10 Thread Christian Gmeiner
From: Thomas RIENOESSL Signed-off-by: Thomas RIENOESSL --- net/nfs.c | 94 ++- 1 file changed, 52 insertions(+), 42 deletions(-) diff --git a/net/nfs.c b/net/nfs.c index d1858faaa9..a2749bae82 100644 --- a/net/nfs.c +++ b/net/nfs.c @@ -443,6

[PATCH v2 3/4] nfs: handle rpc errors for mount calls

2023-03-10 Thread Christian Gmeiner
From: Thomas RIENOESSL Signed-off-by: Thomas RIENOESSL --- net/nfs.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/net/nfs.c b/net/nfs.c index a2749bae82..21cae52f35 100644 --- a/net/nfs.c +++ b/net/nfs.c @@ -524,6 +524,7 @@ static int rpc_lookup_reply(int

[PATCH v2 1/4] nfs: convert supported_nfs_versions bitfield to an enum

2023-03-10 Thread Christian Gmeiner
From: Thomas RIENOESSL Prep. work to support nfs v1. Signed-off-by: Thomas RIENOESSL --- net/nfs.c | 93 +++ 1 file changed, 52 insertions(+), 41 deletions(-) diff --git a/net/nfs.c b/net/nfs.c index c6a124885e..d1858faaa9 100644 ---

[PATCH v2 0/4] NFSv1 support

2023-03-10 Thread Christian Gmeiner
This patch series adds support for NFSv1 and is more or less a rebased version of an older series. During V1 there was a discussion if it really makes sense to bring more features into the network stack of U-Boot as it is just a bootloader. As TCP support landed I thought I might give this patch

[PATCH 4/4] net: e1000: make use of multiple rx packets

2023-03-03 Thread Christian Gmeiner
When facing a very busy network, the single rx packet buffer was oftentimes overwritten before a desired response packet (e.g. a Ping reply) could have been processed. This change improves resistance to this by utilising multiple buffers. Signed-off-by: Christian Gmeiner --- drivers/net/e1000.c

[PATCH 3/4] net: e1000: dynamically allocate rx data buffers per instance

2023-03-03 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- drivers/net/e1000.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c index 08c84ce3d1..ea9ca76917 100644 --- a/drivers/net/e1000.c +++ b/drivers/net/e1000.c @@ -54,14

[PATCH 2/4] net: e1000: move all rx data structures to hw instance

2023-03-03 Thread Christian Gmeiner
Preparation for per driver instance allocated data structures. Signed-off-by: Christian Gmeiner --- drivers/net/e1000.c | 26 +++--- drivers/net/e1000.h | 5 + 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c

[PATCH 1/4] net: e1000: add and make use of NUM_RX_DESC macro

2023-03-03 Thread Christian Gmeiner
The call to DEFINE_ALIGN_BUFFER for the rx_desc array conained an icnonsistency as 16 receive descriptors were allocated when the remaining code would only use 8 of them. Signed-off-by: Christian Gmeiner --- drivers/net/e1000.c | 6 +++--- drivers/net/e1000.h | 2 ++ 2 files changed, 5

[PATCH] arm: mach-k3: introduce generic board detction kconfig option

2023-03-03 Thread Christian Gmeiner
For non TI boards it is not possible to enable the do_board_detect() call as TI_I2C_BOARD_DETECT is defined in board/ti/common/Kconfig. I want to use do_board_detect() to dectect boards and properties based on some SPI communication with a FPGA. Signed-off-by: Christian Gmeiner --- arch/arm

[PATCH] arm: dts: ti: k3-am64-mcu: Add pinctrl

2022-12-05 Thread Christian Gmeiner
Add the definition of the pinctrl for the MCU domain. Same as kernel commit 500e6dfbb465531150ac6e2ff0856dd357ddc8a4 Signed-off-by: Christian Gmeiner --- arch/arm/dts/k3-am64-mcu.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/dts/k3-am64-mcu.dtsi b/arch/arm/dts/k3

Re: [PATCH 1/3] arm: dts: k3-am62x: sync dt with linux kernel

2022-11-04 Thread Christian Gmeiner
es? > > I would also like to see a sync of all k3 dts files! Can you come up with such a patch the next days as it a duplicate of my patch here: https://patchwork.ozlabs.org/project/uboot/patch/20221026111556.1427201-1-christian.gmei...@gmail.com/ greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH v2] arm: dts: ti: k3-am64-main: Add RTI watchdog nodes

2022-11-04 Thread Christian Gmeiner
Am Do., 3. Nov. 2022 um 18:24 Uhr schrieb Tom Rini : > > On Thu, Nov 03, 2022 at 12:27:39AM -0500, Nishanth Menon wrote: > > On 13:15-20221026, Christian Gmeiner wrote: > > > Add the needed bus mappings for the two main RTI memory ranges and > > > the required device

[PATCH v2] arm: dts: ti: k3-am64-main: Add RTI watchdog nodes

2022-10-26 Thread Christian Gmeiner
Add the needed bus mappings for the two main RTI memory ranges and the required device tree nodes in the main domain. Same as kernel commit 6dd8457dc20693e2ba9054c171499b22664fd4e7 Signed-off-by: Christian Gmeiner --- arch/arm/dts/k3-am64-main.dtsi | 18 ++ arch/arm/dts/k3-am64

[PATCH] arm: dts: ti: k3-am64-main: Add RTI watchdog nodes

2022-10-26 Thread Christian Gmeiner
Add the needed bus mappings for the two main RTI memory ranges and the required device tree nodes in the main domain. Same as kernel commit 6dd8457dc20693e2ba9054c171499b22664fd4e7 --- arch/arm/dts/k3-am64-main.dtsi | 18 ++ arch/arm/dts/k3-am64.dtsi | 2 ++ 2 files

Re: [ANN] U-Boot v2022.07-rc4 released

2022-06-07 Thread Christian Gmeiner
bug > fixes people are aware of that have not yet been applied, please let me > know. Can we land https://patchwork.ozlabs.org/project/uboot/patch/20220512062101.1786376-1-christian.gmei...@gmail.com/ ? -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

[PATCH] arch: arm: mach-k3: am642_init: bring back MCU_PADCFG_MMR1 unlock

2022-05-12 Thread Christian Gmeiner
Without this register unlock it is not possible to configure the pinmux used for mcu spi0. Fixes: 92e46092f2 ("arch: arm: mach-k3: am642_init: Probe ESM nodes") Signed-off-by: Christian Gmeiner --- arch/arm/mach-k3/am642_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 2/2] ram: k3-am654: Make VTT regulator optional

2022-03-23 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- drivers/ram/k3-am654-ddrss.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/ram/k3-am654-ddrss.c b/drivers/ram/k3-am654-ddrss.c index a48ebe6ada..4453c247b2 100644 --- a/drivers/ram/k3-am654-ddrss.c +++ b/drivers/ram/k3-am654

[PATCH 1/2] ram: k3-am654: Write all configuration values

2022-03-23 Thread Christian Gmeiner
From: Dominic Rath Makes it possible to use 16-bit DDR memory. Signed-off-by: Dominic Rath Signed-off-by: Christian Gmeiner --- drivers/ram/k3-am654-ddrss.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/ram/k3-am654-ddrss.c b/drivers/ram/k3-am654-ddrss.c index

Re: [PATCH v3 4/4] configs: am64x_evm_r5_defconfig: Add support for ESM

2022-03-21 Thread Christian Gmeiner
Am Mi., 9. März 2022 um 21:43 Uhr schrieb Hari Nagalla : > > Enable ESM driver for AM64x R5 SPL/u-boot builds. > > Signed-off-by: Hari Nagalla Reviewed-by: Christian Gmeiner > --- > configs/am64x_evm_r5_defconfig | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH v3 3/4] arch: arm: mach-k3: am642_init: Probe ESM nodes

2022-03-21 Thread Christian Gmeiner
ROR_RESET_EN_Z is set to '0'. > > On K3 AM64x devices, the R5 SPL u-boot handles the ESM device node > configurations. > > Signed-off-by: Hari Nagalla Reviewed-by: Christian Gmeiner > --- > arch/arm/mach-k3/am642_init.c | 40 +++ > 1 file

Re: [PATCH v3 2/4] arm: dts: k3-am64: Add support for ESM device nodes

2022-03-21 Thread Christian Gmeiner
Am Mi., 9. März 2022 um 21:42 Uhr schrieb Hari Nagalla : > > Enable access to ESM0 configuration space and add Main ESM0 and MCU ESM > nodes to the AM64 device tree. > > Signed-off-by: Hari Nagalla Reviewed-by: Christian Gmeiner > --- > arch/arm/dts/k3-am64.dtsi|

Re: [PATCH v3 1/4] misc: k3_esm: Add functionality to set and route error events within K3SoC

2022-03-21 Thread Christian Gmeiner
t; + esm_clear_raw_status(base, pins[i]); > esm_pin_enable(base, pins[i]); > + esm_intr_enable(base, pins[i]); > + } > + > + /* Enable ESM */ > + writel(ESM_EN_KEY, base + ESM_EN); > > free_pins: > kfree(pins); > -- > 2.17.1 > -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH v2 3/4] arch: arm: mach-k3: am642_init: Probe ESM nodes

2022-03-07 Thread Christian Gmeiner
Am Mo., 7. März 2022 um 12:18 Uhr schrieb Christian Gmeiner : > > Am Mo., 28. Feb. 2022 um 05:56 Uhr schrieb Hari Nagalla : > > > > On AM64x devices, it is possible to route Main ESM0 error events to MCU > > ESM. MCU ESM high error output can trigger the reset logic to

Re: [PATCH v2 3/4] arch: arm: mach-k3: am642_init: Probe ESM nodes

2022-03-07 Thread Christian Gmeiner
00", ); > + if (ret) > + printf("esm main init failed: %d\n", ret); > + > + /* Probe/configure MCUESM */ > + ret = uclass_get_device_by_name(UCLASS_MISC, "esm@410", ); > + if (ret) > + printf("esm mcu init failed: %d\n", ret); > + > + enable_mcu_esm_reset(); enable_mcu_esm_reset() is undefined! I think you forgot something in this patch series :( -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH v2] arm: mach-k3: am6_init: Use CONFIG_TI_I2C_BOARD_DETECT

2022-03-04 Thread Christian Gmeiner
Am Do., 24. Feb. 2022 um 08:21 Uhr schrieb Christian Gmeiner : > > Hi > > Am Di., 15. Feb. 2022 um 07:48 Uhr schrieb Christian Gmeiner > : > > > > We only want to call do_board_detect() if CONFIG_TI_I2C_BOARD_DETECT > > is set. Same as done for am64. > > >

Re: [PATCH v2 4/4] configs: am64x_evm_r5_defconfig: Add support for ESM

2022-03-01 Thread Christian Gmeiner
Am Mo., 28. Feb. 2022 um 05:56 Uhr schrieb Hari Nagalla : > > Enable ESM driver for AM64x R5 SPL/u-boot builds. > > Signed-off-by: Hari Nagalla Reviewed-by: Christian Gmeiner -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH v2 2/4] arm: dts: k3-am64: Add support for ESM device nodes

2022-03-01 Thread Christian Gmeiner
Am Mo., 28. Feb. 2022 um 05:56 Uhr schrieb Hari Nagalla : > > Enable access to ESM0 configuration space and add Main ESM0 and MCU ESM > nodes to the AM64 device tree. > > Signed-off-by: Hari Nagalla Reviewed-by: Christian Gmeiner -- greets -- Christian Gmeiner, MSc ht

Re: [PATCH v2 3/4] arch: arm: mach-k3: am642_init: Probe ESM nodes

2022-03-01 Thread Christian Gmeiner
ROR_RESET_EN_Z is set to '0'. > > On K3 AM64x devices, the R5 SPL u-boot handles the ESM device node > configurations. > > Signed-off-by: Hari Nagalla Reviewed-by: Christian Gmeiner -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH v2 1/4] misc: k3_esm: Add functionality to set and route error events within K3SoC

2022-03-01 Thread Christian Gmeiner
Nagalla Reviewed-by: Christian Gmeiner -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

Re: [PATCH v2] arm: mach-k3: am6_init: Use CONFIG_TI_I2C_BOARD_DETECT

2022-02-23 Thread Christian Gmeiner
Hi Am Di., 15. Feb. 2022 um 07:48 Uhr schrieb Christian Gmeiner : > > We only want to call do_board_detect() if CONFIG_TI_I2C_BOARD_DETECT > is set. Same as done for am64. > > This makes it possible to add a custom am65 based board design to > U-Boot that does not use th

Re: [PATCH 0/5] Add ESM driver support for AM64x R5

2022-02-22 Thread Christian Gmeiner
there any plans to send out a V2 of this patch series? If not I can jump in (as I really want to see in U-Boot sooner than later). -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

[PATCH] spi: cadence-qspi: Make reset control optinal

2022-02-22 Thread Christian Gmeiner
In the TI am65 device tree files there is no reset defined. Also the Linux kernel driver uses devm_reset_control_get_optional_exclusive(..) to get the reset. Lets do the same as the kernel does and make thr reset optinal. Signed-off-by: Christian Gmeiner --- drivers/spi/cadence_qspi.c | 14

Re: [PATCH] arm: mach-k3: am6_init: Use CONFIG_TI_I2C_BOARD_DETECT

2022-02-14 Thread Christian Gmeiner
Hi Bryan. Am Mo., 14. Feb. 2022 um 23:25 Uhr schrieb Bryan Brattlof : > > On this day, February 14, 2022, thus sayeth Christian Gmeiner: > > Hi Bryan. > > > > > > > > On this day, February 7, 2022, thus sayeth Christian Gmeiner: > >

[PATCH v2] arm: mach-k3: am6_init: Use CONFIG_TI_I2C_BOARD_DETECT

2022-02-14 Thread Christian Gmeiner
We only want to call do_board_detect() if CONFIG_TI_I2C_BOARD_DETECT is set. Same as done for am64. This makes it possible to add a custom am65 based board design to U-Boot that does not use this board detection mechanism. Signed-off-by: Christian Gmeiner --- arch/arm/mach-k3/am6_init.c | 3

Re: [PATCH] arm: mach-k3: am6_init: Use CONFIG_TI_I2C_BOARD_DETECT

2022-02-14 Thread Christian Gmeiner
Hi Bryan. > > On this day, February 7, 2022, thus sayeth Christian Gmeiner: > > We only want to call bo_board_detect() if CONFIG_TI_I2C_BOARD_DETECT > > s/bo_board_detect/do_board_detect/ Upps.. > > > is set. Same as done for am64. > > > > Signed-off-b

Re: [PATCH v1 4/4] configs: am64x_evm_r5_defconfig: Add support for ESM

2022-02-10 Thread Christian Gmeiner
Hi Am Mi., 2. Feb. 2022 um 19:22 Uhr schrieb Hari Nagalla : > > Enable ESM driver for AM64x R5 SPL/u-boot builds. > > Signed-off-by: Hari Nagalla Reviewed-by: Christian Gmeiner > --- > configs/am64x_evm_r5_defconfig | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH v1 2/4] arm: dts: k3-am64: Add support for ESM device nodes

2022-02-10 Thread Christian Gmeiner
Am Mi., 2. Feb. 2022 um 19:22 Uhr schrieb Hari Nagalla : > > Enable acces to ESM0 configuration space and add Main ESM0 and MCU ESM > nodes to the AM64 device tree. > > Signed-off-by: Hari Nagalla Reviewed-by: Christian Gmeiner > --- > arch/arm/dts/k3-am64.dtsi|

[PATCH] arm: mach-k3: am6_init: Use CONFIG_TI_I2C_BOARD_DETECT

2022-02-07 Thread Christian Gmeiner
We only want to call bo_board_detect() if CONFIG_TI_I2C_BOARD_DETECT is set. Same as done for am64. Signed-off-by: Christian Gmeiner --- arch/arm/mach-k3/am6_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/am6_init.c b/arch/arm/mach-k3/am6_init.c

  1   2   3   4   >